Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18712 )
Change subject: KUDU-2671 Make WebUI compatible with custom hash schema ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/18712/5/src/kudu/common/partition.h File src/kudu/common/partition.h: http://gerrit.cloudera.org:8080/#/c/18712/5/src/kudu/common/partition.h@406 PS5, Line 406: a comma separated > BTW, impala-shell is going to output them as space separated: https://gerri I made it space separated here as well. Just forgot to update to update the comment. Will fix it http://gerrit.cloudera.org:8080/#/c/18712/5/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/18712/5/src/kudu/common/partition.cc@1059 PS5, Line 1059: } else if (lower_unbounded) { : partition = Substitute("VALUES < $0", RangeKeyDebugString(lower)); : } else if (upper_unbounded) { : partition = Substitute("VALUES >= $0", RangeKeyDebugString(upper)); > It seems this is messed up a bit. Okay, so that will need https://gerrit.cloudera.org/#/c/18712/5/src/kudu/common/partition.cc@1000 to be changed as well to maintain uniformity. http://gerrit.cloudera.org:8080/#/c/18712/5/src/kudu/common/partition.cc@1064 PS5, Line 1064: < > Should this be '<='? Yes, good catch. Will fix it. -- To view, visit http://gerrit.cloudera.org:8080/18712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8b8d90f70c39f13b838e858c870e08dacbdfcd3 Gerrit-Change-Number: 18712 Gerrit-PatchSet: 5 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 13 Jul 2022 19:13:45 +0000 Gerrit-HasComments: Yes
