Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18712 )
Change subject: KUDU-2671 Make WebUI compatible with custom hash schema ...................................................................... Patch Set 8: Code-Review+1 (9 comments) http://gerrit.cloudera.org:8080/#/c/18712/8/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/18712/8/src/kudu/common/partition.cc@1039 PS8, Line 1039: KuduPartialRow upper(&schema); nit: move this closer to line 1048 where it's used? http://gerrit.cloudera.org:8080/#/c/18712/8/src/kudu/common/partition.cc@1040 PS8, Line 1040: HashSchema hash_schema = GetHashSchemaForRange(lower_bound.ToString()); nit: move this closer to line 1070 where it's used? http://gerrit.cloudera.org:8080/#/c/18712/8/src/kudu/common/partition.cc@1071 PS8, Line 1071: auto & style nit: stick the ampersand to the type, not to the variable http://gerrit.cloudera.org:8080/#/c/18712/8/src/kudu/common/partition.cc@1215 PS8, Line 1215: } : : if (entry.empty()) { Semantically, this should always be if/else regardless of the 'entry' emptiness, right? With that, it would be easier for understanding if replacing 'if (entry.empty())' with just 'else' (and it saves a few CPU instructions as well). http://gerrit.cloudera.org:8080/#/c/18712/8/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/18712/8/src/kudu/master/master-test.cc@1453 PS8, Line 1453: FLAGS_enable_per_range_hash_schemas = true; Could you please re-base this patch on the top of the master branch in the git repo? This no longer needed since --enable_per_range_hash_schemas=true by default. http://gerrit.cloudera.org:8080/#/c/18712/8/src/kudu/master/master-test.cc@1502 PS8, Line 1502: k++ I'm not sure I understand why 'k' is needed when there is 'j' already? http://gerrit.cloudera.org:8080/#/c/18712/8/src/kudu/master/master-test.cc@1529 PS8, Line 1529: ColumnSchemaPB * style nit here and below: stick the asterisk to the type http://gerrit.cloudera.org:8080/#/c/18712/8/src/kudu/master/master-test.cc@1540 PS8, Line 1540: AlterTableRequestPB::Step * style nit here and below: stick the asterisk to the type http://gerrit.cloudera.org:8080/#/c/18712/8/src/kudu/master/master-test.cc@1552 PS8, Line 1552: auto & style nit here and below: stick the ampersand to the type, not to the variable -- To view, visit http://gerrit.cloudera.org:8080/18712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8b8d90f70c39f13b838e858c870e08dacbdfcd3 Gerrit-Change-Number: 18712 Gerrit-PatchSet: 8 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 14 Jul 2022 17:19:57 +0000 Gerrit-HasComments: Yes
