Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18712 )
Change subject: KUDU-2671 Make WebUI compatible with custom hash schema ...................................................................... Patch Set 6: (10 comments) http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/client/flex_partitioning_client-test.cc File src/kudu/client/flex_partitioning_client-test.cc: http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/client/flex_partitioning_client-test.cc@573 PS6, Line 573: DefaultAndCustomHashSchemas nit: it seems this doesn't reflect the name of the scenario; is it intended? http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/client/flex_partitioning_client-test.cc@626 PS6, Line 626: tables.front()->GetAllTablets(&tablets); Should we add a check on the size of 'tables' before trying to access its first element? http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/client/flex_partitioning_client-test.cc@627 PS6, Line 627: Should we add a check on the size of 'tablets' before trying to access its elements? http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/common/partition.cc@1032 PS6, Line 1032: nit: misaligned indent http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/master/master-test.cc@1448 PS6, Line 1448: * style nit here and below: stick the asterisk to the type http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/master/master-test.cc@1477 PS6, Line 1477: tables.front()->GetAllTablets(&tablets); Should we check for non-emptiness (or exact size) of 'tables' before accessing its first element? http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/master/master-test.cc@1496 PS6, Line 1496: { Should we add checks on the number of elements in 'tablets' before accessing its elements? http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/master/master-test.cc@1584 PS6, Line 1584: tables.front()->GetAllTablets(&tablets); Should we also add ASSERT_GT(tables.size(), 0) or ASSERT_FALSE(tables.empty()) before accessing tables.front()? http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/master/master-test.cc@1585 PS6, Line 1585: Should we add a check for the size of 'tablets' before trying to access its elements? http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/master/master_path_handlers.cc File src/kudu/master/master_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/master/master_path_handlers.cc@476 PS6, Line 476: nit: misaligned indent -- To view, visit http://gerrit.cloudera.org:8080/18712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8b8d90f70c39f13b838e858c870e08dacbdfcd3 Gerrit-Change-Number: 18712 Gerrit-PatchSet: 6 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 13 Jul 2022 20:35:49 +0000 Gerrit-HasComments: Yes
