Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18712 )
Change subject: KUDU-2671 Make WebUI compatible with custom hash schema ...................................................................... Patch Set 7: (16 comments) http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/client/flex_partitioning_client-test.cc File src/kudu/client/flex_partitioning_client-test.cc: http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/client/flex_partitioning_client-test.cc@573 PS6, Line 573: TabletServerWebUI"; > nit: it seems this doesn't reflect the name of the scenario; is it intended Fixed it. http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/client/flex_partitioning_client-test.cc@626 PS6, Line 626: vector<scoped_refptr<TabletInfo>> tablets; > Should we add a check on the size of 'tables' before trying to access its f Done http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/client/flex_partitioning_client-test.cc@627 PS6, Line 627: tables.front()->GetAllTablets(&tablets); > Should we add a check on the size of 'tablets' before trying to access its Done http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/common/partition.cc@1032 PS6, Line 1032: > nit: misaligned indent Done http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/common/partition.cc@1060 PS6, Line 1060: upper > Should this be 'upper' instead? Done http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/common/partition.cc@1062 PS6, Line 1062: lower > Should this be 'lower' instead? Done http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/common/partition.cc@1069 PS6, Line 1069: hash > hash Done http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/common/partition.cc@1069 PS6, Line 1069: schema infor > schema Done http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/common/partition.cc@1195 PS6, Line 1195: : if (idx_ptr) { > Is it possible to use binary search instead of linear iteration here? The Done http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/master/master-test.cc@1448 PS6, Line 1448: * > style nit here and below: stick the asterisk to the type Done http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/master/master-test.cc@1477 PS6, Line 1477: > Should we check for non-emptiness (or exact size) of 'tables' before access Done http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/master/master-test.cc@1496 PS6, Line 1496: ")\""); > Did you miss this one? The check is done a few lines above in https://gerrit.cloudera.org/#/c/18712/7/src/kudu/master/master-test.cc@1480 http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/master/master-test.cc@1496 PS6, Line 1496: ")\""); > Should we add checks on the number of elements in 'tablets' before accessin Done http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/master/master-test.cc@1584 PS6, Line 1584: CatalogManager::ScopedLeaderSharedLock l(master_->catalog_manager()); > Should we also add ASSERT_GT(tables.size(), 0) or ASSERT_FALSE(tables.empty Added ASSERT_EQ(tables.size, 1) http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/master/master-test.cc@1585 PS6, Line 1585: master_->catalog_manager()->GetAllTables(&tables); > Should we add a check for the size of 'tablets' before trying to access its Done http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/master/master_path_handlers.cc File src/kudu/master/master_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/master/master_path_handlers.cc@476 PS6, Line 476: > nit: misaligned indent Done -- To view, visit http://gerrit.cloudera.org:8080/18712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8b8d90f70c39f13b838e858c870e08dacbdfcd3 Gerrit-Change-Number: 18712 Gerrit-PatchSet: 7 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 14 Jul 2022 14:38:03 +0000 Gerrit-HasComments: Yes
