Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18712 )
Change subject: KUDU-2671 Make WebUI compatible with custom hash schema ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/master/master-test.cc@1496 PS6, Line 1496: ")\""); > Should we add checks on the number of elements in 'tablets' before accessin Did you miss this one? http://gerrit.cloudera.org:8080/#/c/18712/7/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/18712/7/src/kudu/master/master-test.cc@1476 PS7, Line 1476: tables.size(), 1 here and elsewhere: the expected value comes first in ASSERT_XXX -- that way it's easier to read error messages if assertion triggers -- To view, visit http://gerrit.cloudera.org:8080/18712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8b8d90f70c39f13b838e858c870e08dacbdfcd3 Gerrit-Change-Number: 18712 Gerrit-PatchSet: 7 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 14 Jul 2022 05:17:54 +0000 Gerrit-HasComments: Yes
