Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18712 )
Change subject: KUDU-2671 Make WebUI compatible with custom hash schema ...................................................................... Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/common/partition.cc@1060 PS6, Line 1060: lower Should this be 'upper' instead? http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/common/partition.cc@1062 PS6, Line 1062: upper Should this be 'lower' instead? http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/common/partition.cc@1069 PS6, Line 1069: Hash hash http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/common/partition.cc@1069 PS6, Line 1069: partitioning schema http://gerrit.cloudera.org:8080/#/c/18712/6/src/kudu/common/partition.cc@1195 PS6, Line 1195: for (const auto& range : ranges_with_custom_hash_schemas_) { : if (range.lower == partition.begin_.range_key()) { Is it possible to use binary search instead of linear iteration here? The `hash_schema_idx_by_encoded_range_start_` member field is a tree dictionary built to complement ranges_with_custom_hash_schemas_ to perform exactly that sort of lookup. -- To view, visit http://gerrit.cloudera.org:8080/18712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8b8d90f70c39f13b838e858c870e08dacbdfcd3 Gerrit-Change-Number: 18712 Gerrit-PatchSet: 6 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 13 Jul 2022 20:16:19 +0000 Gerrit-HasComments: Yes
