Abhishek Chennaka has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18712 )

Change subject: KUDU-2671  Make WebUI compatible with custom hash schema
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/18712/5/src/kudu/common/partition.cc
File src/kudu/common/partition.cc:

http://gerrit.cloudera.org:8080/#/c/18712/5/src/kudu/common/partition.cc@1195
PS5, Line 1195: range_schema
> nit: 'range_schema' usually means range partitioning schema, so it's a bit
Done


http://gerrit.cloudera.org:8080/#/c/18712/5/src/kudu/common/partition.cc@1197
PS5, Line 1197:  Hash Schema
> Could we drop this part?  The header of the column already provides the 'ha
Done


http://gerrit.cloudera.org:8080/#/c/18712/5/src/kudu/common/partition.cc@1219
PS5, Line 1219:  Hash Schema
> Could we drop this part?  The header of the column already provides the 'ha
Done



--
To view, visit http://gerrit.cloudera.org:8080/18712
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8b8d90f70c39f13b838e858c870e08dacbdfcd3
Gerrit-Change-Number: 18712
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 13 Jul 2022 19:44:56 +0000
Gerrit-HasComments: Yes

Reply via email to