Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18712 )
Change subject: KUDU-2671 Make WebUI compatible with custom hash schema ...................................................................... Patch Set 9: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/18712/8/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/18712/8/src/kudu/common/partition.cc@1040 PS8, Line 1040: // Decode the lower and upper bounds > The DecodeRangeKey() below is setting this to remainder of the composite ke My comment was about 'hash_schema'. Is it used anywhere in this scope before line 1069 in PS9? http://gerrit.cloudera.org:8080/#/c/18712/9/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/18712/9/src/kudu/common/partition.cc@1214 PS9, Line 1214: } : : else { I guess LINT target isn't happy about 'else {' at a separate line: move it to be at line 1214 after the closing brace '}' http://gerrit.cloudera.org:8080/#/c/18712/8/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/18712/8/src/kudu/master/master-test.cc@1502 PS8, Line 1502: HASH > We reset j but not k. We need k to get the index range [0-3]. Using j alone nit: ah, OK -- I thought that using 2*i + j would make it simple enough. Feel free to keep 'k' if that's more natural. But could you move the increment of the 'k' to the line 1511 then? Something like tablets[k++]->id(), ... -- To view, visit http://gerrit.cloudera.org:8080/18712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8b8d90f70c39f13b838e858c870e08dacbdfcd3 Gerrit-Change-Number: 18712 Gerrit-PatchSet: 9 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 14 Jul 2022 19:40:45 +0000 Gerrit-HasComments: Yes
