Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18712 )
Change subject: KUDU-2671 Make WebUI compatible with custom hash schema ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/18712/8/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/18712/8/src/kudu/common/partition.cc@1040 PS8, Line 1040: // Decode the lower and upper bounds > My comment was about 'hash_schema'. Is it used anywhere in this scope befo No it isn't, but the value of lower_bound is changed after line 1043, so calling GetHashSchemaForRange(lower_bound.ToString()) after line 1043 returns table wide hash schema always. http://gerrit.cloudera.org:8080/#/c/18712/9/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/18712/9/src/kudu/common/partition.cc@1214 PS9, Line 1214: } : : else { > I guess LINT target isn't happy about 'else {' at a separate line: move it Ah, yes. Fixed it now. http://gerrit.cloudera.org:8080/#/c/18712/8/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/18712/8/src/kudu/master/master-test.cc@1502 PS8, Line 1502: HASH > nit: ah, OK -- I thought that using 2*i + j would make it simple enough. F Done -- To view, visit http://gerrit.cloudera.org:8080/18712 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8b8d90f70c39f13b838e858c870e08dacbdfcd3 Gerrit-Change-Number: 18712 Gerrit-PatchSet: 9 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 14 Jul 2022 20:15:34 +0000 Gerrit-HasComments: Yes
