srowen commented on a change in pull request #32253:
URL: https://github.com/apache/spark/pull/32253#discussion_r617099199
##########
File path: mllib/pom.xml
##########
@@ -142,20 +142,20 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>dev.ludovic.netlib</groupId>
+ <artifactId>blas</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>dev.ludovic.netlib</groupId>
+ <artifactId>lapack</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>dev.ludovic.netlib</groupId>
+ <artifactId>arpack</artifactId>
+ </dependency>
+
</dependencies>
- <profiles>
Review comment:
What do your libraries pull in that this profile might have? it's
disabled on purpose as we can't include what it pulls in in the release itself.
(We also probably need to leave the profile empty at least to avoid bulid
errors on a missing profile)
##########
File path: pom.xml
##########
@@ -172,6 +172,7 @@
<fasterxml.jackson.version>2.12.2</fasterxml.jackson.version>
<snappy.version>1.1.8.2</snappy.version>
<netlib.java.version>1.1.2</netlib.java.version>
+ <netlib.ludovic.dev.version>1.0.10</netlib.ludovic.dev.version>
Review comment:
(Will need to be 1.1.0 I suppose, when it's ready)
##########
File path: project/SparkBuild.scala
##########
@@ -294,7 +294,7 @@ object SparkBuild extends PomBuild {
javaOptions ++= {
val versionParts = System.getProperty("java.version").split("[+.\\-]+",
3)
var major = versionParts(0).toInt
- if (major >= 16) Seq("--add-modules=jdk.incubator.vector") else Seq.empty
+ if (major >= 16)
Seq("--add-modules=jdk.incubator.vector,jdk.incubator.foreign",
"-Dforeign.restricted=warn") else Seq.empty
Review comment:
I assume the same, that these flags are required to use the vectorized
code, but, that's on someone who's experimenting with Java 16 at this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
