luhenry commented on a change in pull request #32253:
URL: https://github.com/apache/spark/pull/32253#discussion_r617325396
##########
File path: project/SparkBuild.scala
##########
@@ -294,7 +294,7 @@ object SparkBuild extends PomBuild {
javaOptions ++= {
val versionParts = System.getProperty("java.version").split("[+.\\-]+",
3)
var major = versionParts(0).toInt
- if (major >= 16) Seq("--add-modules=jdk.incubator.vector") else Seq.empty
+ if (major >= 16)
Seq("--add-modules=jdk.incubator.vector,jdk.incubator.foreign",
"-Dforeign.restricted=warn") else Seq.empty
Review comment:
Yes, to use the code relying on the Vector API, one would need to pass
`--add-modules=jdk.incubator.vector`. Otherwise, it will fall back to pure
JDK8-compatible code. And the `--add-modules=jdk.incubator.foreign
-Dforeign.restricted=warn` is for a native-wrapper BLAS implementation based on
the [Foreign Linker API](https://openjdk.java.net/jeps/389). If that's not
available, it automatically falls back to the `com.github.fommil` native
wrappers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
