luhenry commented on a change in pull request #32253:
URL: https://github.com/apache/spark/pull/32253#discussion_r617343950
##########
File path: mllib/pom.xml
##########
@@ -142,20 +142,20 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>dev.ludovic.netlib</groupId>
+ <artifactId>blas</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>dev.ludovic.netlib</groupId>
+ <artifactId>lapack</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>dev.ludovic.netlib</groupId>
+ <artifactId>arpack</artifactId>
+ </dependency>
+
</dependencies>
- <profiles>
Review comment:
It only pulls `com.github.fommil.netlib`. The long term goal is to get
rid of this dependency but it's going to require quite a lot of work still.
What I don't understand is how can Spark work today if
`com.github.fommil.netlib` is not installed? Are there other packages that can
be dropped in place and which can seamlessly replace it?
`com.github.fommil.netlib` is unconditionally added as a dependency in
[graphx/pom.xml](https://github.com/apache/spark/blob/master/graphx/pom.xml#L63),
and that is why Spark functions even when `-Pnetlib-lgpl` isn't defined. (The
package is going to be downloaded, the jar is going to be passed to the
compiler, and it's going to be on the classpath when running tests and
benchmarks).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
