pan3793 commented on code in PR #52741:
URL: https://github.com/apache/spark/pull/52741#discussion_r2464361691
##########
sql/connect/client/jdbc/src/main/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectDatabaseMetaData.scala:
##########
@@ -24,29 +24,23 @@ import org.apache.spark.util.VersionUtils
class SparkConnectDatabaseMetaData(conn: SparkConnectConnection) extends
DatabaseMetaData {
- override def allProceduresAreCallable: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def allProceduresAreCallable: Boolean = false
- override def allTablesAreSelectable: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def allTablesAreSelectable: Boolean = false
Review Comment:
for methods `allProceduresAreCallable` and `allTablesAreSelectable`,
Databricks JDBC v1.0.10-oss returns `true`, while I think they are unknown,
according to the javadocs, we should return `false` instead.
```
@return {@code true} if so; {@code false} otherwise
```
BTW, Trino JDBC v477 returns `false` too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
