pan3793 commented on code in PR #52741: URL: https://github.com/apache/spark/pull/52741#discussion_r2464367941
########## sql/connect/client/jdbc/src/main/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectDatabaseMetaData.scala: ########## @@ -112,76 +96,55 @@ class SparkConnectDatabaseMetaData(conn: SparkConnectConnection) extends Databas override def getExtraNameCharacters: String = "" - override def supportsAlterTableWithAddColumn: Boolean = - throw new SQLFeatureNotSupportedException + override def supportsAlterTableWithAddColumn: Boolean = true - override def supportsAlterTableWithDropColumn: Boolean = - throw new SQLFeatureNotSupportedException + override def supportsAlterTableWithDropColumn: Boolean = true Review Comment: Databricks JDBC v1.0.10-oss returns `false` for `supportsAlterTableWithAddColumn` and `supportsAlterTableWithDropColumn`, but obviously, Spark SQL supports those SQL syntax. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
