pan3793 commented on code in PR #52741:
URL: https://github.com/apache/spark/pull/52741#discussion_r2464365885
##########
sql/connect/client/jdbc/src/main/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectDatabaseMetaData.scala:
##########
@@ -60,35 +54,25 @@ class SparkConnectDatabaseMetaData(conn:
SparkConnectConnection) extends Databas
override def getDriverMinorVersion: Int =
VersionUtils.minorVersion(SPARK_VERSION)
- override def usesLocalFiles: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def usesLocalFiles: Boolean = false
- override def usesLocalFilePerTable: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def usesLocalFilePerTable: Boolean = false
- override def supportsMixedCaseIdentifiers: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsMixedCaseIdentifiers: Boolean = false
- override def storesUpperCaseIdentifiers: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def storesUpperCaseIdentifiers: Boolean = false
- override def storesLowerCaseIdentifiers: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def storesLowerCaseIdentifiers: Boolean = false
- override def storesMixedCaseIdentifiers: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def storesMixedCaseIdentifiers: Boolean = false
Review Comment:
Databricks JDBC v1.0.10-oss returns `true`, but this depends on the catalog
implementation, it's out of scope for the Spark project. thus it's unknown,
should return `false`
```
/**
* Retrieves whether this database treats mixed case unquoted SQL
identifiers as
* case insensitive and stores them in mixed case.
*
* @return {@code true} if so; {@code false} otherwise
* @throws SQLException if a database access error occurs
*/
boolean storesMixedCaseIdentifiers() throws SQLException;
```
##########
sql/connect/client/jdbc/src/main/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectDatabaseMetaData.scala:
##########
@@ -60,35 +54,25 @@ class SparkConnectDatabaseMetaData(conn:
SparkConnectConnection) extends Databas
override def getDriverMinorVersion: Int =
VersionUtils.minorVersion(SPARK_VERSION)
- override def usesLocalFiles: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def usesLocalFiles: Boolean = false
- override def usesLocalFilePerTable: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def usesLocalFilePerTable: Boolean = false
- override def supportsMixedCaseIdentifiers: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsMixedCaseIdentifiers: Boolean = false
- override def storesUpperCaseIdentifiers: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def storesUpperCaseIdentifiers: Boolean = false
- override def storesLowerCaseIdentifiers: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def storesLowerCaseIdentifiers: Boolean = false
- override def storesMixedCaseIdentifiers: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def storesMixedCaseIdentifiers: Boolean = false
- override def supportsMixedCaseQuotedIdentifiers: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def supportsMixedCaseQuotedIdentifiers: Boolean = false
Review Comment:
same as `override def storesMixedCaseIdentifiers: Boolean`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
