pan3793 commented on code in PR #52741:
URL: https://github.com/apache/spark/pull/52741#discussion_r2464363519
##########
sql/connect/client/jdbc/src/main/scala/org/apache/spark/sql/connect/client/jdbc/SparkConnectDatabaseMetaData.scala:
##########
@@ -24,29 +24,23 @@ import org.apache.spark.util.VersionUtils
class SparkConnectDatabaseMetaData(conn: SparkConnectConnection) extends
DatabaseMetaData {
- override def allProceduresAreCallable: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def allProceduresAreCallable: Boolean = false
- override def allTablesAreSelectable: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def allTablesAreSelectable: Boolean = false
override def getURL: String = conn.url
override def getUserName: String = conn.spark.client.configuration.userName
override def isReadOnly: Boolean = false
- override def nullsAreSortedHigh: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def nullsAreSortedHigh: Boolean = false
- override def nullsAreSortedLow: Boolean =
- throw new SQLFeatureNotSupportedException
+ override def nullsAreSortedLow: Boolean = false
Review Comment:
Databricks JDBC v1.0.10-oss returns `true`, but Spark SQL supports both
`NULLS FIRST` and `NULLS LAST`
the javadoc say
```
In an ascending order, if this method returns true, NULL values will appear
at the beginning.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
