LuciferYang commented on PR #58489: URL: https://github.com/apache/spark/pull/58489#issuecomment-5548581915
**5. The mode selection in makeSnapshotSources has no test, and the method is private** `resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala:203` `makeSnapshotSources` is `private`, while the sibling `makeExecutorPodsAllocator` in the same file is `private[k8s]` for testability, and `KubernetesClusterManagerSuite` never references it or `enableInformer`. So the core wiring of this PR (which pair of sources the flag selects) has no coverage, and the informer-mode sources are never run through `KubernetesClusterSchedulerBackend`'s start/stop; a wrong branch or a missing listerExecutor would pass every existing test. Could you make it `private[k8s]` and add a test asserting the selected source types per flag value? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
