LuciferYang commented on PR #58489: URL: https://github.com/apache/spark/pull/58489#issuecomment-5548584207
**10. The new config toggle lands ~90 lines away from its family, and this PR splits the legacy family too** `resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala:684` `KUBERNETES_EXECUTOR_ENABLE_INFORMER` lands at line 579 (between POD_DELETION_COST and ALLOCATION_BATCH_SIZE), while its semantic siblings `ENABLE_API_POLLING`/`ENABLE_API_WATCHER` and the two new interval configs sit ~90 lines further down. The two new intervals are also inserted between the legacy toggles and `API_POLLING_INTERVAL`, so this PR splits the legacy family that used to be contiguous as well. Moving the toggle down next to the two intervals, and placing the new intervals after `API_POLLING_INTERVAL`, would keep both families together. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
