LuciferYang commented on PR #58489:
URL: https://github.com/apache/spark/pull/58489#issuecomment-5548581424

   **4. The three new user-facing configs are undocumented**
   
   
`resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala:579`
   
   The three new user-facing configs 
(`spark.kubernetes.executor.enableInformer`,
   `listerPollingInterval`, `informerResyncInterval`) have no entries anywhere 
under docs/, while
   the closest precedent `spark.kubernetes.executor.apiPollingInterval` is 
documented in the config
   table in docs/running-on-kubernetes.md. The mutual exclusion with the two 
legacy switches
   currently lives only in the config doc string, so users can't discover the 
switch or the
   migration notes from the docs; it's also worth noting there that the 
informer path requires
   both list and watch permissions on pods. Could you add the three entries to
   running-on-kubernetes.md?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to