LuciferYang commented on PR #58489: URL: https://github.com/apache/spark/pull/58489#issuecomment-5548583740
**9. The three new test suites diverge from the conventions of the neighboring suites** `resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsInformerSnapshotSourceSuite.scala:62` A few conventions diverge from the neighboring suites: all three use the deprecated `MockitoAnnotations.initMocks` while every existing suite here uses `openMocks(this).close()`; the `Mockito.spy[InformerManager]` in the informer suite uses no spy feature (the lister suite just calls new); `with MockitoSugar` is unused; `handlerCaptor` is a class-level val instead of being rebuilt in beforeEach; InformerManagerSuite has a redundant `import org.mockito.Mockito.verify` (the wildcard import already provides it); and the five-line label-filter mock chain is copy-pasted verbatim in all three suites, which would suit a small shared helper. Also, "getInformer should throw if the informer has not been initialized" actually exercises the init→start→stop path rather than a fresh manager. None of this blocks — fine as a quick cleanup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
