LuciferYang commented on PR #58489:
URL: https://github.com/apache/spark/pull/58489#issuecomment-5548583299
**8. start() has no double-start guard, and a misleading INFO fires on every
normal startup**
`resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsInformerSnapshotSource.scala:35`
Neither new source's `start()` has the double-start guard the legacy ones
have ("Cannot start
the watcher twice." / "Cannot start polling more than once."); starting the
informer source
twice would add a second handler and duplicate events, and a second lister
start would overwrite
and leak the first pollingFuture. Also, since the informer source runs the
informer first and
the lister source then sees `isRunning=true`, the `logInfo("Informer is
already running.")` in
`InformerManager` fires on every normal startup and reads like something
went wrong. Adding the
`require` guards and demoting that log to debug would match the existing
sources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
