LuciferYang commented on PR #58489: URL: https://github.com/apache/spark/pull/58489#issuecomment-5548584607
**11. The four new types are public with no annotation, inconsistent with adjacent types** `resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsSnapshotSource.scala:24` `ExecutorPodsSnapshotSource`, `InformerManager`, and the two new sources are all public with no annotation, while the types they sit next to differ: `ExecutorPodsSnapshotsStore` is `private[spark]`, and the two legacy sources carry `@Stable @DeveloperApi` on the classes and `@Since` on the methods. The new trait now sits in the public hierarchy of two @DeveloperApi classes without being @DeveloperApi itself, and `InformerManager` is pure internal wiring with no need to be public. Marking the trait @DeveloperApi and narrowing InformerManager to private[spark] (or the whole group) would avoid widening the API surface first and paying a breaking change to shrink it later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
