Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/8758#discussion_r40796335
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerArguments.scala
---
@@ -48,7 +48,11 @@ private[history] class HistoryServerArguments(conf:
SparkConf, args: Array[Strin
case Nil =>
case _ =>
- printUsageAndExit(1)
+ logWarning("Setting log directory through the command line is
deprecated as of " +
+ "Spark 1.1.0. Please set this through
spark.history.fs.logDirectory instead.")
+ conf.set("spark.history.fs.logDirectory", args.head)
--- End diff --
Why is this necessary? Looking at the current script, no option is passed
to the history server at all. Anybody who worked around the script needed to
use the `-d` argument. So this is basically removing the check for invalid
command lines, which can lead to confusing behavior (e.g. `java HistoryServer
blah -d directory` will set the directory to `blah` with your code, instead of
telling the user his command line arguments make no sense).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
