Github user rekhajoshm commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144604656
Thanks for your comments @vanzin !
However that does not seem an accurate assessment.Before this patch, the
script accepted only first parameter and set it to logDirectory.It did not care
if user set it to blah.It did not care if âproperties or -d were passed
because it did not accept that way of args. But savvy users knew that absence
to be a functionality disconnect.
The essence of this patch is to remove the disconnect in HSArguments and
script while maintaining backward compatibility.Anycase FsHistoryProvider
validates blah is not really a blah.Users who use straight up directory will
continue to do so, users who want to set properties file will do so now. And
there can be permutations , but unharmful.With user education/documentation,
one or more of this option can be discarded gradually.Please approve @vanzin
@srowen .Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
