Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144749562
Hi, me again. Looking at the code once more, I think it's ok if you want to
make this change in the scala code and not the shell script (so, e.g., you can
unit test it), but it cannot be done in the current spot. Basically, you need
something like this:
if (args.length == 1) {
// Print deprecation warning, set log dir.
} else {
parse(args.toList)
}
That way the existing command-line parsing is not broken. With your change,
something like "--properties-file foo blah --dir /path" will successfully be
parsed, and the log directory will be set to "blah", which is not what should
happen, since that's either an invalid command line, or the directory should be
set to "/path". (I vote for invalid command line.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
