Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144706624
Yeah, the current script does blindly 'pass' the first arg as an
environment variable. It never parsed any args at all to the arg-parsing code,
which seems like an oversight. Instead it sent a dummy (?) argument 1 for some
reason -- is this historical?
So I generally agree with plumbing through the arguments to the argument
parsing code. By the way, don't we need to remove that "1" argument then?
From there it seemed straightforward to attempt to retain backwards
compatibility for the script, such that passing just a dir as the single arg
still works (and generates a warning). This formulation would in fact stop at
the first such argument.
I would not be against just removing support for this naked argument, as it
has been long since deprecated, if anyone felt strongly about it.
Aside from the "1" issue, this LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
