Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/8758#issuecomment-144742060
Hmm, I think I get what you're trying to do. You're trying to implement the
script's command line handling in `HistoryServerArguments` (the old `if [ $# !=
0 ]; then` code you're removing). I don't think you should do that.
Instead, the script itself should handle this backwards compatibility, much
like it did before. Instead of setting an env variable, it can add command line
arguments to the history server.
But the change in `HistoryServerArguments` is broken the way it is now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
