#19586: Add is_cayley_graph
-------------------------------------+-------------------------------------
       Reporter:  jaanos             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.10
      Component:  graph theory       |   Resolution:
       Keywords:  Cayley graphs      |    Merged in:
  groups                             |    Reviewers:
        Authors:  Janoš Vidali       |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  4aaf3014fee5bb08d861636908d6733047d4a869
  u/jaanos/add_is_cayley_graph       |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by dimpase):

 Replying to [comment:33 jaanos]:
 > Hi!
 >
 > > as a switch to `libgap` will happen sooner or later, optimising for
 not reading GAP output
 > > does not seem to be that important.
 >
 > I see. But should I do anything about it at this point?
 >
 > > this ceritainly looks better, but again, I don't like the counter-
 intuitive parameters of `is_cayley()` and weird sort of output (a pair)
 that you currently have. In particular the latter.
 >
 > I have modelled both input and output of `is_cayley` after methods such
 as `is_chordal` and `is_circulant`.

 not all silly designs in Sage should be copied...
 Looks like someone didn't know, or forgot, about `None`

 > I guess we could be even more specific and have the function return only
 the group or only the generators if requested - or maybe
 `cayley_graph_group` could do that,

 only the generators? Why? it's one quick function call away from the
 group, why would you
 do this in library code? In particular, as you are computing the group,
 not its generators, in the first place.

 > and `is_cayley` would then simply call `cayley_graph_group` without
 requesting either.e.
 sure.

--
Ticket URL: <http://trac.sagemath.org/ticket/19586#comment:34>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to