#19586: Add is_cayley_graph
-------------------------------------+-------------------------------------
Reporter: jaanos | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.10
Component: graph theory | Resolution:
Keywords: Cayley graphs | Merged in:
groups | Reviewers:
Authors: Janoš Vidali | Work issues:
Report Upstream: N/A | Commit:
Branch: | 95dfa64264bb0e6ec9122e5ce458a5000d48bc3d
u/jaanos/add_is_cayley_graph | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by ncohen):
> Sorry about the inactivity, I have been pretty busy. Also, I was
probably too quick to judge that a more low-level GAP procedure could be
done without too much trouble.
>
> Would it be OK to accept this as is, and then possibly improve the
search for transitive subgroups in another ticket?
No, all the code has to be reviewed. I expect it to be as clean as the
part I reviewed, yet somebody has to do check it. I cannot tell about the
code, but the name 'has_transitive_subgroup', for instance, sounds
misleading. It does not mention any kind of 'order', so by just lookig at
the function's name you would not understand how it could return anything
different from `.is_transitive`. That's also the kind of things a reviewer
should look at, besides the GAP technicalities.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/19586#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
