#9343: upgrade pari to version 2.4.3
----------------------------------------------------------------------------+
   Reporter:  was                                                           |   
    Owner:  tbd       
       Type:  enhancement                                                   |   
   Status:  new       
   Priority:  major                                                         |   
Milestone:  sage-4.5.2
  Component:  packages                                                      |   
 Keywords:            
     Author:  Robert Bradshaw, John Cremona, Jeroen Demeyer, William Stein  |   
 Upstream:  N/A       
   Reviewer:                                                                |   
   Merged:            
Work_issues:                                                                |  
----------------------------------------------------------------------------+

Comment(by drkirkby):

 Have the other issues that are circumvented by hacks to spkg-install been
 reported upstream? Such as:

 {{{
 # These two are needed so that Sage can catch pari's error signals.
 cp "$PATCHED/init.c"  src/language/init.c
 cp "$PATCHED/mp.c"    src/kernel/gmp/mp.c
 }}}

 Then's these this not very clearly documented patch
 {{{
 cp "$PATCHED/get_dlld" config/
 }}}

 And another, this time a bit better documented, though no trac number.
 {{{
 # mabshoff: This patch is to get around problem in PPC 32-bit Linux build
 # (but it is ok on any other machine)
 cp "$PATCHED/get_dlcflags" config/
 }}}
 (That is probably the -fPIC issue which will soon be able to be removed)

 {{{
 # pjeremy: fix for FreeBSD: #7825
 cp "$PATCHED/get_kernel" config/
 }}}

 Then this.
 {{{
 # cwitty: disable -rpath
 cp "$PATCHED/get_ld" config/
 }}}

 And another.
 {{{
 # This is needed or there are weird locale problems involving rpath
 # with building Sage.
 LC_ALL=C
 export LC_ALL
 LANG=C
 export LANG
 }}}

 And another

 {{{
     if [ "$UNAME" = "CYGWIN" ]; then
         # There are weird bugs in PARI's build process on Windows XP
         # under Cygwin.
         # Passing in this extra flag gets around the bug.
         $MAKE GMPINCLUDE=-I$SAGE_LOCAL/include EXTRADLLDFLAGS=-lgmp gp
     else
         $MAKE gp
     fi
 }}}

 And another


 {{{
         # Also another patch since paripriv.h won't compile right on OS X
         # when used by client Sage code.  So we replace it by a slightly
         # modified version.
         cp -pf "$PATCHED/paripriv.h" "$SAGE_LOCAL/include/pari/paripriv.h"
 }}}

 That's a lot of patches to one program. How many of these issues have been
 raised? Personally, I would be very tempted to remove these, and find what
 fails. Otherwise maintenance of the package is going to be very difficult.

 Dave

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9343#comment:110>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to