#11900: Serious regression caused by #9138
-------------------------------------------------+--------------------------
   Reporter:  SimonKing                          |          Owner:  tbd         
                 
       Type:  defect                             |         Status:  
needs_review                 
   Priority:  critical                           |      Milestone:  sage-4.8    
                 
  Component:  performance                        |       Keywords:  categories 
regression        
Work_issues:                                     |       Upstream:  N/A         
                 
   Reviewer:  Jeroen Demeyer, Nicolas M. Thiéry  |         Author:  Simon King, 
Nicolas M. Thiéry
     Merged:                                     |   Dependencies:  #9138 
#11911                 
-------------------------------------------------+--------------------------
Changes (by newvalueoldvalue):

  * status:  needs_work => needs_review
  * work_issues:  Laurent series rings are fields. CFF is a field. =>
  * author:  Simon King => Simon King, Nicolas M. Thiéry


Comment:

 Finally I have posted a combined patch that also includes the recent ideas
 on _meet_, adds several doctests and fixes some of the missing calls to
 `__init__` of base classes I was mentioning.

 It also comprises Nicolas' review patch, with the only exception that I am
 now not using a separate function for computing the category of a homset.

 If I see that correctly, all new stuff is backed up by doc tests. I did a
 complete test ''without'' using the review patch. I'm testing the latest
 patch version now, but I think it is "needs review"!

 I think Nicolas is an author as well: He provided the original
 implementation of Category_singleton.

 Apply trac11900_category_speedup_combined.patch

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11900#comment:156>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to