#11900: Serious regression caused by #9138
-------------------------------------------------+--------------------------
Reporter: SimonKing | Owner: tbd
Type: defect | Status:
needs_review
Priority: critical | Milestone: sage-4.8
Component: performance | Keywords: categories
regression
Work_issues: | Upstream: N/A
Reviewer: Jeroen Demeyer, Nicolas M. Thiéry | Author: Simon King,
Nicolas M. Thiéry
Merged: | Dependencies: #9138
#11911
-------------------------------------------------+--------------------------
Comment(by nthiery):
I have been through the patch, and have a *preliminary* reviewer patch
which I am about to upload. There are still a couple things I'd like to do
before posting my final reviewer patch:
- Avoid introducing new EXAMPLE instead of EXAMPLES
- use check=True/False instead of category_checked=False/True, for
consistency with other similar use cases in Sage
(please argue if you prefer check_category rather than just check)
- Look again at is_Field, and in particular document the behaviour
- Finish removing some duplication in the __init__ method of Ring/...
- Revert the changes to the FiniteCategories (if that's alright with you,
this will be done by stripping the combined patch, rather than undoing the
changes in the reviewer patch)
- I forgot what we had discussed about CartesianProducts.base: whether we
should drop this method for the time being, or keep it.
By the way: I am not keen on calling one() in the initialization, as
calculating one() may be very costly. In general, in our former
experience with MuPAD-Combinat and Sage, creating elements (with
an_element, ...) early in the initialization has been a repeated
source of problems. When it is about sanity check, this can be
postponed to the TestSuite.
However, this ticket contains a lot of urgent and good stuff, and get
soon into Sage, so this comment is for a later ticket.
I created another followup ticket: #12099
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11900#comment:163>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
