#11900: Serious regression caused by #9138
-------------------------------------------------+--------------------------
Reporter: SimonKing | Owner: tbd
Type: defect | Status:
needs_review
Priority: critical | Milestone: sage-4.8
Component: performance | Keywords: categories
regression
Work_issues: | Upstream: N/A
Reviewer: Jeroen Demeyer, Nicolas M. Thiéry | Author: Simon King,
Nicolas M. Thiéry
Merged: | Dependencies: #9138
#11911
-------------------------------------------------+--------------------------
Comment(by nthiery):
Replying to [comment:159 SimonKing]:
> I have updated the patch. It now includes the doctest fixes for the
residue fields, and in particular it runs the full test suite for residue
fields now.
>
> One question, though: The residue field example comprises two different
kind of residue fields. The category of the first (called k in the
example) is just `Fields()`. The category of the other is the more
complicated one, with quotients etc. It could be a good idea to see why
that happens. But not here...
>
> Apply trac11900_category_speedup_combined.patch
Thanks for all your work! It sounds good from your description. I'll try
to review the patch by the end of this week.
Ah sorry, one more thing I should have though about earlier: all the
Finite* categories will be refactored in the upcoming 10963, where will
inherit from something else. To avoid a lot of trivial rebasing, do you
mind if we postpone their singletonification to that later ticket?
If you agree, let me know if you prefer to strip those hunks out of the
patch yourself, or let me do it.
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11900#comment:160>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
