#362: Problem with certain Ogg bitrates on rev7337
------------------------+---------------------------------------------------
 Reporter:  humanclay   |       Owner:  admin      
     Type:  Bugs        |      Status:  new        
 Priority:  1           |   Milestone:  NEAR FUTURE
Component:  Liquidsoap  |     Version:  0.9.2+svn  
 Keywords:              |         Mac:  1          
    Linux:  1           |      Netbsd:  1          
    Other:  1           |     Freebsd:  1          
------------------------+---------------------------------------------------

Comment(by mrpingouin):

 Replying to [comment:9 humanclay]:
 > Perhaps a patch that would remove this restriction? :-)

 Here's the simplest possible patch: it sets -2 as the default for all
 vorbis (non-cbr) encoders. Don't put a quality setting and you should get
 what you want.
 {{{
 Index: src/lang/lang_encoders.ml
 ===================================================================
 --- src/lang/lang_encoders.ml   (revision 7351)
 +++ src/lang/lang_encoders.ml   (working copy)
 @@ -212,7 +212,7 @@
  let mk_vorbis params =
    let defaults =
      { Encoder.Vorbis.
 -        mode = Encoder.Vorbis.VBR 2. ;
 +        mode = Encoder.Vorbis.VBR (-2.) ;
          channels = 2 ;
          samplerate = 44100 ;
      }
 }}}

 > Or is a long-term solution just around the corner?

 It's good that you remind me, I'll take care of making it possible to pass
 negative numbers. I might also lift the restriction to [0..1] that we
 currently have, but this story won't be finished before Romain comes back
 from holidays, he's more knowledgeable than me on that issue (I didn't
 even know liq was running on several implementations of vorbis).

-- 
Ticket URL: <http://savonet.rastageeks.org/ticket/362#comment:10>
Savonet <http://savonet.rastageeks.org/>
Let's program our stream !
------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate 
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the 
lucky parental unit.  See the prize list and enter to win: 
http://p.sf.net/sfu/thinkgeek-promo
_______________________________________________
Savonet-trac mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/savonet-trac

Reply via email to