Re: Review Request 42792: Fix compile error in container logger tests.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42792/#review116333
---


Ship it!




Ship It!

- Klaus Ma


On Jan. 26, 2016, 4:12 p.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42792/
> ---
> 
> (Updated Jan. 26, 2016, 4:12 p.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-4508
> https://issues.apache.org/jira/browse/MESOS-4508
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use unsigned value when comparing with kilobytes.
> 
> 
> Diffs
> -
> 
>   src/tests/container_logger_tests.cpp 
> ce551cbdb89ffb1fead3a58f2d0a1bd27f20f305 
> 
> Diff: https://reviews.apache.org/r/42792/diff/
> 
> 
> Testing
> ---
> 
> make check on OSX and Ubuntu 15.04
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

[Bernd Mathiske]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review116330
---




src/tests/fetcher_cache_tests.cpp (line 196)


Good idea, but then we need to set checkpointing to true for the recovery 
test below.



src/tests/fetcher_cache_tests.cpp (line 599)


const



src/tests/fetcher_cache_tests.cpp (line 713)


const


- Bernd Mathiske


On Jan. 24, 2016, 7:01 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> ---
> 
> (Updated Jan. 24, 2016, 7:01 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4486
> https://issues.apache.org/jira/browse/MESOS-4486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCacheTest.Local* test cases.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 2747b72ba49c9fde04e556b649601b037517283e 
> 
> Diff: https://reviews.apache.org/r/42696/diff/
> 
> 
> Testing
> ---
> 
> Before apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2524 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
> ```
> 
> 
> After apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (873 ms)
> [   OK ] FetcherCacheTest.LocalCached (1609 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Review Request 42794: URL query string order is defined.

[Abhishek Dasgupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42794/
---

Review request for mesos, Jan Schlicht and Vinod Kone.


Bugs: MESOS-3317
https://issues.apache.org/jira/browse/MESOS-3317


Repository: mesos


Description
---

URL query string order is defined.


Diffs
-

  3rdparty/libprocess/src/http.cpp 762da9a9038fc0a81156b5c03b556084df1bd7e0 
  3rdparty/libprocess/src/tests/http_tests.cpp 
66d185e3fd8a165d8a98d3d2752e756f8de3499b 

Diff: https://reviews.apache.org/r/42794/diff/


Testing
---

The following test cases in http_test.cpp have been modified -
HTTPTest.QueryEncodeDecode to check generated query strings in URL to be 
according alphabatic order.
URLTest.Stringification to check generated query strings in URL to be according 
alphabatic order.


Thanks,

Abhishek Dasgupta

Re: Review Request 42594: Introduced framework registry operations.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42594/#review116340
---



Patch looks great!

Reviews applied: [42591, 42594]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 26, 2016, 7:54 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42594/
> ---
> 
> (Updated Jan. 26, 2016, 7:54 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-1719
> https://issues.apache.org/jira/browse/MESOS-1719
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Introduced framework registry operations.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 3a7e18232323a1c051bcc97915484b1195fffe58 
> 
> Diff: https://reviews.apache.org/r/42594/diff/
> 
> 
> Testing
> ---
> 
> Make && Make check successfully!
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 42516: Add support for user-defined networks.

[Ezra Silvera]

> On Jan. 24, 2016, 6:58 a.m., Shuai Lin wrote:
> > src/docker/docker.cpp, line 519
> > 
> >
> > typo, s/sempty/empty :)

good catch. thanks :-)


- Ezra


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/#review116010
---


On Jan. 24, 2016, 6:42 a.m., Ezra Silvera wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42516/
> ---
> 
> (Updated Jan. 24, 2016, 6:42 a.m.)
> 
> 
> Review request for mesos and TimothyIL TimothyIL.
> 
> 
> Bugs: MESOS-4369
> https://issues.apache.org/jira/browse/MESOS-4369
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Signed-off-by: Ezra Silvera 
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247 
>   include/mesos/v1/mesos.proto 0501dfa27ed610666226953591a902eac4c295f8 
>   src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e 
> 
> Diff: https://reviews.apache.org/r/42516/diff/
> 
> 
> Testing
> ---
> 
> Using Swarm running on Mesos create a network with "docker  network create 
> --driver=bridge myNetwork"   and then create a container on that network:  
> "docker run --net=myNetwork"
> 
> 
> Thanks,
> 
> Ezra Silvera
> 
>

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42186/#review116556
---



Patch looks great!

Reviews applied: [42181, 42843, 42844, 42185, 42186]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 27, 2016, 4:14 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42186/
> ---
> 
> (Updated Jan. 27, 2016, 4:14 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4255
> https://issues.apache.org/jira/browse/MESOS-4255
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_recovery_tests.cpp 6683a081ac231f1e275a3cdb8ee841da430a9f66 
> 
> Diff: https://reviews.apache.org/r/42186/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 42685: Added roles validation to master.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42685/
---

(Updated Jan. 27, 2016, 1:26 p.m.)


Review request for mesos, Benjamin Bannier and Vinod Kone.


Bugs: MESOS-4364
https://issues.apache.org/jira/browse/MESOS-4364


Repository: mesos


Description
---

Validated either role or roles in FrameworkInfo can be set,
but never both.


Diffs (updated)
-

  src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422 
  src/tests/role_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 

Diff: https://reviews.apache.org/r/42685/diff/


Testing
---

make check


Thanks,

Qian Zhang

Re: Review Request 42685: Added roles validation to master.

[Qian Zhang]

> On Jan. 26, 2016, 9:32 a.m., Benjamin Bannier wrote:
> > src/master/master.cpp, lines 1980-1983
> > 
> >
> > This should probably be replaced with `strings::join("'", 
> > frameworkInfo.roles())` which could be used directly when creating the 
> > `Error` below.
> 
> Benjamin Bannier wrote:
> I meant `strings::join(",", frameworkInfo.roles())` of course, sorry.

Agree and fixed, thanks Ben!


> On Jan. 26, 2016, 9:32 a.m., Benjamin Bannier wrote:
> > src/master/master.cpp, lines 2250-2253
> > 
> >
> > Use `strings::join`, w/o introducing a named var.

Agree and fixed, thanks Ben!


> On Jan. 26, 2016, 9:32 a.m., Benjamin Bannier wrote:
> > src/tests/role_tests.cpp, lines 97-98
> > 
> >
> > This constructor seems to be deprecated (even though it is used above). 
> > Instead you should be able to use
> > 
> > MesosSchedulerDriver driver(
> > , frameworkInfo, master.get(), false);

Agree and fixed, thanks Ben!


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42685/#review116243
---


On Jan. 27, 2016, 1:26 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42685/
> ---
> 
> (Updated Jan. 27, 2016, 1:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Vinod Kone.
> 
> 
> Bugs: MESOS-4364
> https://issues.apache.org/jira/browse/MESOS-4364
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Validated either role or roles in FrameworkInfo can be set,
> but never both.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 9ee56277c8a472be9e683d5db505becfb5f7c422 
>   src/tests/role_tests.cpp fc3a72894631279460ee7971a4627d73c3d8c351 
> 
> Diff: https://reviews.apache.org/r/42685/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 42791: Added link to Http Endpoints doc in home.md.

[Joerg Schad]

> On Jan. 26, 2016, 8:44 a.m., Joerg Schad wrote:
> > docs/home.md, line 17
> > 
> >
> > With https://issues.apache.org/jira/browse/MESOS-4295 we changed the 
> > link structure [label](file.md). I.e. s/endpoints/ /endpoints.md
> 
> Kevin Klues wrote:
> Even if there is no endpoints.md file?  It is a folder with a bunch of 
> .md files inside of it.

I see.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42791/#review116327
---


On Jan. 26, 2016, 7:49 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42791/
> ---
> 
> (Updated Jan. 26, 2016, 7:49 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added link to Http Endpoints doc in home.md.
> 
> 
> Diffs
> -
> 
>   docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec 
> 
> Diff: https://reviews.apache.org/r/42791/diff/
> 
> 
> Testing
> ---
> 
> Documentation is live here:
> http://c99.millennium.berkeley.edu/documentation/latest/
> http://c99.millennium.berkeley.edu/documentation/latest/endpoints
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42516: Add support for user-defined networks.

[Ezra Silvera]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42516/
---

(Updated Jan. 27, 2016, 7:05 a.m.)


Review request for mesos and TimothyIL TimothyIL.


Changes
---

fix type smpty-->empty


Bugs: MESOS-4369
https://issues.apache.org/jira/browse/MESOS-4369


Repository: mesos


Description
---

Signed-off-by: Ezra Silvera 


Diffs (updated)
-

  include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247 
  include/mesos/v1/mesos.proto 0501dfa27ed610666226953591a902eac4c295f8 
  src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e 

Diff: https://reviews.apache.org/r/42516/diff/


Testing
---

Using Swarm running on Mesos create a network with "docker  network create 
--driver=bridge myNetwork"   and then create a container on that network:  
"docker run --net=myNetwork"


Thanks,

Ezra Silvera

Re: Review Request 42791: Added link to Http Endpoints doc in home.md.

[Joerg Schad]

> On Jan. 26, 2016, 8:48 a.m., Joerg Schad wrote:
> > docs/home.md, line 12
> > 
> >
> > FYI: The links from 
> > http://c99.millennium.berkeley.edu/documentation/latest/endpoints don't 
> > seem to work for me... e.g.
> > http://c99.millennium.berkeley.edu/documentation/latest/version/
> 
> Kevin Klues wrote:
> I don't know how you generated the link for: 
> http://c99.millennium.berkeley.edu/documentation/latest/version/
> It should be 
> http://c99.millennium.berkeley.edu/documentation/latest/version/endpoints/version
> which is correct on the site.

That is the link which I get from 
http://c99.millennium.berkeley.edu/documentation/latest/endpoints for version.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42791/#review116329
---


On Jan. 26, 2016, 7:49 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42791/
> ---
> 
> (Updated Jan. 26, 2016, 7:49 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added link to Http Endpoints doc in home.md.
> 
> 
> Diffs
> -
> 
>   docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec 
> 
> Diff: https://reviews.apache.org/r/42791/diff/
> 
> 
> Testing
> ---
> 
> Documentation is live here:
> http://c99.millennium.berkeley.edu/documentation/latest/
> http://c99.millennium.berkeley.edu/documentation/latest/endpoints
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42791: Added link to Http Endpoints doc in home.md.

[Kevin Klues]

> On Jan. 26, 2016, 8:48 a.m., Joerg Schad wrote:
> > docs/home.md, line 12
> > 
> >
> > FYI: The links from 
> > http://c99.millennium.berkeley.edu/documentation/latest/endpoints don't 
> > seem to work for me... e.g.
> > http://c99.millennium.berkeley.edu/documentation/latest/version/
> 
> Kevin Klues wrote:
> I don't know how you generated the link for: 
> http://c99.millennium.berkeley.edu/documentation/latest/version/
> It should be 
> http://c99.millennium.berkeley.edu/documentation/latest/version/endpoints/version
> which is correct on the site.
> 
> Joerg Schad wrote:
> That is the link which I get from 
> http://c99.millennium.berkeley.edu/documentation/latest/endpoints for version.

Strange...

With:
http://c99.millennium.berkeley.edu/documentation/latest/endpoints
I get the same as you.

But with:
http://c99.millennium.berkeley.edu/documentation/latest/endpoints/
(notice the / at the end) I get the correct links

Will look into it.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42791/#review116329
---


On Jan. 26, 2016, 7:49 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42791/
> ---
> 
> (Updated Jan. 26, 2016, 7:49 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added link to Http Endpoints doc in home.md.
> 
> 
> Diffs
> -
> 
>   docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec 
> 
> Diff: https://reviews.apache.org/r/42791/diff/
> 
> 
> Testing
> ---
> 
> Documentation is live here:
> http://c99.millennium.berkeley.edu/documentation/latest/
> http://c99.millennium.berkeley.edu/documentation/latest/endpoints
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42836: Quota: Only used scalars for lay-away calculations.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42836/
---

(Updated Jan. 27, 2016, 4:04 a.m.)


Review request for mesos and Michael Park.


Changes
---

simplified arithmetic.


Bugs: MESOS-4505
https://issues.apache.org/jira/browse/MESOS-4505


Repository: mesos


Description
---

Also used cached values from update sorter API.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.cpp 
fa9939700ff44911b9d149a391677b3eb07577ae 

Diff: https://reviews.apache.org/r/42836/diff/


Testing
---

make check
callgrind with optimized build


Thanks,

Joris Van Remoortere

Re: Review Request 42186: Added tests for recovery for HTTP based executors.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42186/
---

(Updated Jan. 27, 2016, 4:14 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Added another test for recovery mode `cleanup`


Bugs: MESOS-4255
https://issues.apache.org/jira/browse/MESOS-4255


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/tests/slave_recovery_tests.cpp 6683a081ac231f1e275a3cdb8ee841da430a9f66 

Diff: https://reviews.apache.org/r/42186/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 42836: Quota: Only used scalars for lay-away calculations.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42836/#review116533
---


Ship it!




Ship It!

- Michael Park


On Jan. 27, 2016, 4:04 a.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42836/
> ---
> 
> (Updated Jan. 27, 2016, 4:04 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4505
> https://issues.apache.org/jira/browse/MESOS-4505
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Also used cached values from update sorter API.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> fa9939700ff44911b9d149a391677b3eb07577ae 
> 
> Diff: https://reviews.apache.org/r/42836/diff/
> 
> 
> Testing
> ---
> 
> make check
> callgrind with optimized build
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Review Request 42844: Drop `404 NotFound` responses in the executor library.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42844/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-4255
https://issues.apache.org/jira/browse/MESOS-4255


Repository: mesos


Description
---

Previously, we did not use to drop `404 NotFound` responses in the library and 
send `Event::Error` to executor. However, this can be trigerred upon an agent 
restart when it has not yet set up HTTP routes.


Diffs
-

  src/executor/executor.cpp 92334ffb8af83b1c86c44bd406147893c7c6daa3 

Diff: https://reviews.apache.org/r/42844/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Review Request 42843: Ensure `ServiceUnavailable` is not received for `Subscribe` calls.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42843/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-4255
https://issues.apache.org/jira/browse/MESOS-4255


Repository: mesos


Description
---

The agent does not return an `ServiceUnavailable` response for `Subscribe` 
calls. Added a `CHECK` to ensure this.


Diffs
-

  src/executor/executor.cpp 92334ffb8af83b1c86c44bd406147893c7c6daa3 

Diff: https://reviews.apache.org/r/42843/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 42185: Added an example executor based on the new V1 API.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42185/
---

(Updated Jan. 27, 2016, 4:13 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Modified the example executor to retry `Subscribe` calls.


Bugs: MESOS-4255
https://issues.apache.org/jira/browse/MESOS-4255


Repository: mesos


Description
---

This change adds a custom executor based on the new executor library.


Diffs (updated)
-

  src/Makefile.am bdb34020043f64c07721b3e8b29b221e5b99 
  src/examples/test_http_executor.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/42185/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 42806: Added the fetcher plugin module interface.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42806/#review116537
---



Patch looks great!

Reviews applied: [42806]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 27, 2016, 2:55 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42806/
> ---
> 
> (Updated Jan. 27, 2016, 2:55 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-3926
> https://issues.apache.org/jira/browse/MESOS-3926
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added the fetcher plugin module interface.
> 
> 
> Diffs
> -
> 
>   include/mesos/module/fetcher_plugin.hpp PRE-CREATION 
>   src/Makefile.am bdb34020043f64c07721b3e8b29b221e5b99 
>   src/examples/test_fetcher_plugin_module.cpp PRE-CREATION 
>   src/module/manager.cpp a53f71b9965f7ab85aadb6c0c7af18de958faf38 
>   src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8 
>   src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e 
>   src/uri/fetcher.hpp 5bc9703b76457413b5841710e0313f8bfa9047a1 
>   src/uri/fetcher.cpp dfda732348fec3b686cf82b55ad94fda4829469b 
> 
> Diff: https://reviews.apache.org/r/42806/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

[haosdent huang]

> On Jan. 26, 2016, 9:18 a.m., Bernd Mathiske wrote:
> > src/tests/fetcher_cache_tests.cpp, line 196
> > 
> >
> > Good idea, but then we need to set checkpointing to true for the 
> > recovery test below.

@bernd, thank you very much. Could you help review again?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review116330
---


On Jan. 27, 2016, 3:04 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> ---
> 
> (Updated Jan. 27, 2016, 3:04 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4486
> https://issues.apache.org/jira/browse/MESOS-4486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCacheTest.Local* test cases.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 2747b72ba49c9fde04e556b649601b037517283e 
> 
> Diff: https://reviews.apache.org/r/42696/diff/
> 
> 
> Testing
> ---
> 
> Before apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2524 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
> ```
> 
> 
> After apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (873 ms)
> [   OK ] FetcherCacheTest.LocalCached (1609 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
> ```
> 
> Also test the recovery test manually:
> 
> ```
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review116547
---



Patch looks great!

Reviews applied: [42696]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 27, 2016, 3:04 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> ---
> 
> (Updated Jan. 27, 2016, 3:04 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4486
> https://issues.apache.org/jira/browse/MESOS-4486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCacheTest.Local* test cases.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 2747b72ba49c9fde04e556b649601b037517283e 
> 
> Diff: https://reviews.apache.org/r/42696/diff/
> 
> 
> Testing
> ---
> 
> Before apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2524 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
> ```
> 
> 
> After apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (873 ms)
> [   OK ] FetcherCacheTest.LocalCached (1609 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
> ```
> 
> Also test the recovery test manually:
> 
> ```
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42755: Added documentation for labeled reserved resources.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42755/#review116317
---


Ship it!




Ship It!

- Guangya Liu


On 一月 25, 2016, 11:02 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42755/
> ---
> 
> (Updated 一月 25, 2016, 11:02 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation for labeled reserved resources.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md 8d2d33a6518c73542cbfb3a5ee36da1c00c6ff1a 
> 
> Diff: https://reviews.apache.org/r/42755/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 39060: Create master detector per url & not per framework.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39060/#review116314
---


Ship it!





src/sched/sched.cpp (line 167)


i think we can call this `instance`, and name the internal static 
`singleton`?



src/sched/sched.cpp (line 1777)


i don't think we need this extra new line.


- Joris Van Remoortere


On Jan. 5, 2016, 9:01 a.m., Mandeep Chadha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39060/
> ---
> 
> (Updated Jan. 5, 2016, 9:01 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3595
> https://issues.apache.org/jira/browse/MESOS-3595
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> If the number of framework created exceeds the lib process
> threads then during master failover the zookeeper updates can
> cause deadlock.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp 049c041286f3167e79cc5ea8a9e0bf8d42569832 
>   src/sched/sched.cpp 44eb4f50e8ed84297268d94a3a0320c843ff6d8c 
>   src/tests/mesos.hpp a4811b0d8dee33ff2ca4968f532ce64b7ea95249 
> 
> Diff: https://reviews.apache.org/r/39060/diff/
> 
> 
> Testing
> ---
> 
> make check successful 
> Created 100 framework instances on a 24 CPU machine. Master failover detected 
> by the framework process and continue to work as expected.
> 
> 
> Thanks,
> 
> Mandeep Chadha
> 
>

Re: Review Request 42791: Added link to Http Endpoints doc in home.md.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42791/#review116329
---




docs/home.md (line 12)


FYI: The links from 
http://c99.millennium.berkeley.edu/documentation/latest/endpoints don't seem to 
work for me... e.g.
http://c99.millennium.berkeley.edu/documentation/latest/version/


- Joerg Schad


On Jan. 26, 2016, 7:49 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42791/
> ---
> 
> (Updated Jan. 26, 2016, 7:49 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added link to Http Endpoints doc in home.md.
> 
> 
> Diffs
> -
> 
>   docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec 
> 
> Diff: https://reviews.apache.org/r/42791/diff/
> 
> 
> Testing
> ---
> 
> Documentation is live here:
> http://c99.millennium.berkeley.edu/documentation/latest/
> http://c99.millennium.berkeley.edu/documentation/latest/endpoints
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42754: Added support for labels to resource reservations.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42754/#review116304
---




src/tests/reservation_endpoints_tests.cpp (line 782)


why does the offerResources contain the labeledResources2? The 
labeledResources2 should be filtered when allocate?



src/tests/resources_tests.cpp (line 833)


s/dynamic reservation./dynamic reservation without labels.



src/tests/resources_tests.cpp (line 839)


s/dynamic reservation, and labels./dynamic reservation with labels.



src/tests/resources_tests.cpp (line 1592)


s/Dynamically reserved./Dynamically reserved without labels.



src/tests/resources_tests.cpp (line 1666)


Can you please add more test cases to make two reservations with different 
labels and validate that they are not addable?



src/tests/resources_tests.cpp (lines 1687 - 1689)


Can you please add a new test cases named as `SubtractionWithLabels` to 
validate subtractable and nont subtractable?


- Guangya Liu


On 一月 25, 2016, 11:02 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42754/
> ---
> 
> (Updated 一月 25, 2016, 11:02 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4479
> https://issues.apache.org/jira/browse/MESOS-4479
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Labels are free-form key-value pairs that can be used to associate
> metadata with reserved resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247 
>   include/mesos/type_utils.hpp 16f9cda83edd5064527b89e94392a7a54411 
>   include/mesos/v1/mesos.hpp b294f022345dc892c0581622c5b389efbde911a9 
>   include/mesos/v1/mesos.proto 0501dfa27ed610666226953591a902eac4c295f8 
>   src/common/resources.cpp 0fcf86014ab5c9908a1cdb3a57b7c5e70acd7737 
>   src/common/type_utils.cpp 76f48f6a1f5467db032ded8acd296d03353b4172 
>   src/tests/mesos.hpp 5a737a6490060b0194db097990b327c9921221f4 
>   src/tests/reservation_endpoints_tests.cpp 
> 35c093567b07a11ca6eee85e2ff91894a460a7af 
>   src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23 
>   src/v1/mesos.cpp 9264752c6b82eaa844ce356b879f92d562ed4e45 
>   src/v1/resources.cpp 126e5a2f567d2e281da3f99bc485f7960567eee5 
> 
> Diff: https://reviews.apache.org/r/42754/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.

[Artem Harutyunyan]

> On Jan. 25, 2016, 4:36 p.m., Jie Yu wrote:
> > src/tests/disk_quota_tests.cpp, lines 132-133
> > 
> >
> > Can you add a simple DiskUsageCollectorTest here to test the exclude 
> > path?

`du` excludes symlinks anyway, so what exactly do we want to test here?


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41818/#review116224
---


On Jan. 26, 2016, 12:13 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41818/
> ---
> 
> (Updated Jan. 26, 2016, 12:13 a.m.)
> 
> 
> Review request for Artem Harutyunyan and Jie Yu.
> 
> 
> Bugs: MESOS-4281
> https://issues.apache.org/jira/browse/MESOS-4281
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Handled quota when volumes are bind mounted into the sandbox.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/posix/disk.hpp 
> 31808c1e8199fbf2cea36c273860fdbf0a2388f8 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> 248c34adb63907911d89bed5b1519682a852bb2d 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 5bb85034c22caef64054c1629f6fd55d227e48b1 
>   src/tests/disk_quota_tests.cpp 1577cf71c4d1fbad11e2ec939c4ceae2d5b25f97 
> 
> Diff: https://reviews.apache.org/r/41818/diff/
> 
> 
> Testing
> ---
> 
> sudo mesos-tests.sh
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 42791: Added link to Http Endpoints doc in home.md.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42791/#review116327
---




docs/home.md (line 17)


With https://issues.apache.org/jira/browse/MESOS-4295 we changed the link 
structure [label](file.md). I.e. s/endpoints/ /endpoints.md


- Joerg Schad


On Jan. 26, 2016, 7:49 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42791/
> ---
> 
> (Updated Jan. 26, 2016, 7:49 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added link to Http Endpoints doc in home.md.
> 
> 
> Diffs
> -
> 
>   docs/home.md dea6ec2605662dbd4b10d69b2bf8f35af50389ec 
> 
> Diff: https://reviews.apache.org/r/42791/diff/
> 
> 
> Testing
> ---
> 
> Documentation is live here:
> http://c99.millennium.berkeley.edu/documentation/latest/
> http://c99.millennium.berkeley.edu/documentation/latest/endpoints
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42278: Fixed volume paths for command tasks with image.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42278/#review116326
---



Patch looks great!

Reviews applied: [42379, 42277, 42278]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 26, 2016, 6:37 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42278/
> ---
> 
> (Updated Jan. 26, 2016, 6:37 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Bugs: MESOS-4285
> https://issues.apache.org/jira/browse/MESOS-4285
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed volume paths for command tasks with image.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 356d311fdf97b2c4663c60e13ede7cdb71a264c7 
>   src/slave/slave.cpp 1f4c8368feb0ce19963577582ce745acfb21aa9f 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 496275a73601664b51155ef1373d8d46b9069613 
> 
> Diff: https://reviews.apache.org/r/42278/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Re: Review Request 42735: Make bash scripts portable.

[David Forsythe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42735/
---

(Updated Jan. 26, 2016, 8:42 a.m.)


Review request for mesos, Artem Harutyunyan and Ian Downes.


Summary (updated)
-

Make bash scripts portable.


Bugs: MESOS-4502
https://issues.apache.org/jira/browse/MESOS-4502


Repository: mesos


Description (updated)
---

Make bash scripts portable.


Diffs
-

  support/atexit.sh 90696a2d426ff013d1aaec7800c6dc880bc2a00c 
  support/coverage.sh df81f9a45d043d506f47e9d6fac6893bf044144a 
  support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 
  support/hooks/commit-msg d173dfdf380b08a9b349589dfd33c53b3cdccc60 
  support/release.sh 633bbace091bddd582b9fcef5d35b331a0f169f0 
  support/tag.sh 9d37c81a13cb0c281f4a53884c6c55e09c341d85 
  support/vote.sh 218a38512d4dc8e160d975a99c577e4411879eee 

Diff: https://reviews.apache.org/r/42735/diff/


Testing
---


Thanks,

David Forsythe

Review Request 42792: Fix compile error in container logger tests.

[Jian Qiu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42792/
---

Review request for mesos and Joseph Wu.


Bugs: MESOS-4508
https://issues.apache.org/jira/browse/MESOS-4508


Repository: mesos


Description
---

Use unsigned value when comparing with kilobytes.


Diffs
-

  src/tests/container_logger_tests.cpp ce551cbdb89ffb1fead3a58f2d0a1bd27f20f305 

Diff: https://reviews.apache.org/r/42792/diff/


Testing
---

make check on OSX and Ubuntu 15.04


Thanks,

Jian Qiu

Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41818/
---

(Updated Jan. 26, 2016, 12:13 a.m.)


Review request for Artem Harutyunyan and Jie Yu.


Bugs: MESOS-4281
https://issues.apache.org/jira/browse/MESOS-4281


Repository: mesos


Description
---

Handled quota when volumes are bind mounted into the sandbox.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/posix/disk.hpp 
31808c1e8199fbf2cea36c273860fdbf0a2388f8 
  src/slave/containerizer/mesos/isolators/posix/disk.cpp 
248c34adb63907911d89bed5b1519682a852bb2d 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
5bb85034c22caef64054c1629f6fd55d227e48b1 
  src/tests/disk_quota_tests.cpp 1577cf71c4d1fbad11e2ec939c4ceae2d5b25f97 

Diff: https://reviews.apache.org/r/41818/diff/


Testing
---

sudo mesos-tests.sh


Thanks,

Artem Harutyunyan

Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.

[Artem Harutyunyan]

> On Jan. 25, 2016, 4:36 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/posix/disk.cpp, line 205
> > 
> >
> > can you do the following?
> > 
> > ```
> > info->paths[path].usage = collector.usage(
> > path,
> > (path == info->directory) ? excludes : {}));
> > ```

`{}` causes a compilation error, but I did re-introduce the ternary operator 
back.


> On Jan. 25, 2016, 4:36 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/posix/disk.cpp, line 388
> > 
> >
> > Please put `{` in a new line.

The body of the constructor is empty again so `{}` will remain on the same line.


> On Jan. 25, 2016, 4:36 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/posix/disk.cpp, lines 393-400
> > 
> >
> > You can just do
> > ```
> > foreach (const string& exclude, excludes) {
> >   argv.push_back("--exclude");
> >   argv.push_back(exclude);
> > }
> > ```

Thanks! This looks much nicer.


> On Jan. 25, 2016, 4:36 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/posix/disk.cpp, line 461
> > 
> >
> > You can create the argv first based on 'path' and 'excludes' in Entry.

I am not sure I understand this one.


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41818/#review116224
---


On Jan. 26, 2016, 12:13 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41818/
> ---
> 
> (Updated Jan. 26, 2016, 12:13 a.m.)
> 
> 
> Review request for Artem Harutyunyan and Jie Yu.
> 
> 
> Bugs: MESOS-4281
> https://issues.apache.org/jira/browse/MESOS-4281
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Handled quota when volumes are bind mounted into the sandbox.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/posix/disk.hpp 
> 31808c1e8199fbf2cea36c273860fdbf0a2388f8 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> 248c34adb63907911d89bed5b1519682a852bb2d 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 5bb85034c22caef64054c1629f6fd55d227e48b1 
>   src/tests/disk_quota_tests.cpp 1577cf71c4d1fbad11e2ec939c4ceae2d5b25f97 
> 
> Diff: https://reviews.apache.org/r/41818/diff/
> 
> 
> Testing
> ---
> 
> sudo mesos-tests.sh
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 42735: Make commit-msg hook portable.

[David Forsythe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42735/
---

(Updated Jan. 26, 2016, 8:40 a.m.)


Review request for mesos, Artem Harutyunyan and Ian Downes.


Changes
---

Update other bash scripts.


Bugs: MESOS-4502
https://issues.apache.org/jira/browse/MESOS-4502


Repository: mesos


Description
---

Make commit-msg hook portable.


Diffs (updated)
-

  support/atexit.sh 90696a2d426ff013d1aaec7800c6dc880bc2a00c 
  support/coverage.sh df81f9a45d043d506f47e9d6fac6893bf044144a 
  support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 
  support/hooks/commit-msg d173dfdf380b08a9b349589dfd33c53b3cdccc60 
  support/release.sh 633bbace091bddd582b9fcef5d35b331a0f169f0 
  support/tag.sh 9d37c81a13cb0c281f4a53884c6c55e09c341d85 
  support/vote.sh 218a38512d4dc8e160d975a99c577e4411879eee 

Diff: https://reviews.apache.org/r/42735/diff/


Testing
---


Thanks,

David Forsythe

Re: Review Request 42735: Make commit-msg hook portable.

[David Forsythe]

> On Jan. 25, 2016, 9:52 p.m., Ian Downes wrote:
> > Can you please fix the other bash Linux-isms in this patch while you're at 
> > it?
> > ```
> > [1350][idownes:mesos]$ git grep "!\/bin\/bash"
> > support/atexit.sh:#!/bin/bash
> > support/coverage.sh:#!/bin/bash
> > support/docker_build.sh:#!/bin/bash
> > support/hooks/commit-msg:#!/bin/bash
> > support/release.sh:#!/bin/bash
> > support/tag.sh:#!/bin/bash
> > support/vote.sh:#!/bin/bash
> > ```

Sure thing.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42735/#review116182
---


On Jan. 25, 2016, 8:07 p.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42735/
> ---
> 
> (Updated Jan. 25, 2016, 8:07 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Ian Downes.
> 
> 
> Bugs: MESOS-4502
> https://issues.apache.org/jira/browse/MESOS-4502
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Make commit-msg hook portable.
> 
> 
> Diffs
> -
> 
>   support/hooks/commit-msg d173dfdf380b08a9b349589dfd33c53b3cdccc60 
> 
> Diff: https://reviews.apache.org/r/42735/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Forsythe
> 
>

Re: Review Request 42792: Fix compile error in container logger tests.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42792/#review116350
---



Patch looks great!

Reviews applied: [42792]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 26, 2016, 8:12 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42792/
> ---
> 
> (Updated Jan. 26, 2016, 8:12 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-4508
> https://issues.apache.org/jira/browse/MESOS-4508
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use unsigned value when comparing with kilobytes.
> 
> 
> Diffs
> -
> 
>   src/tests/container_logger_tests.cpp 
> ce551cbdb89ffb1fead3a58f2d0a1bd27f20f305 
> 
> Diff: https://reviews.apache.org/r/42792/diff/
> 
> 
> Testing
> ---
> 
> make check on OSX and Ubuntu 15.04
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 41092: CMake: Added CMake file for agent executable build.

[Diana Arroyo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41092/
---

(Updated Jan. 26, 2016, 1:54 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Joseph Wu.


Changes
---

Cleanup code.


Bugs: MESOS-3843
https://issues.apache.org/jira/browse/MESOS-3843


Repository: mesos


Description
---

Added CMake file for agent executable build.


Diffs (updated)
-

  src/slave/CMakeLists.txt PRE-CREATION 
  src/slave/cmake/SlaveConfigure.cmake fbdfdaa27fbd8c7429861eea5baf401a221f748b 

Diff: https://reviews.apache.org/r/41092/diff/


Testing
---

Tested on Ubuntu and OSX.


Thanks,

Diana Arroyo

Review Request 42797: Fix expire CERN GPG key link.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42797/
---

Review request for mesos, Adam B and Timothy Chen.


Bugs: MESOS-4511
https://issues.apache.org/jira/browse/MESOS-4511


Repository: mesos


Description
---

Fix expire CERN GPG key link.


Diffs
-

  docs/getting-started.md 7177f9d5ae33dbabf0ed1bb1b9870873906e1a56 

Diff: https://reviews.apache.org/r/42797/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 42794: URL query string order is defined.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42794/#review116355
---



Patch looks great!

Reviews applied: [42794]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 26, 2016, 10:55 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42794/
> ---
> 
> (Updated Jan. 26, 2016, 10:55 a.m.)
> 
> 
> Review request for mesos, Jan Schlicht and Vinod Kone.
> 
> 
> Bugs: MESOS-3317
> https://issues.apache.org/jira/browse/MESOS-3317
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> URL query string order is defined.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/http.cpp 762da9a9038fc0a81156b5c03b556084df1bd7e0 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> 66d185e3fd8a165d8a98d3d2752e756f8de3499b 
> 
> Diff: https://reviews.apache.org/r/42794/diff/
> 
> 
> Testing
> ---
> 
> The following test cases in http_test.cpp have been modified -
> HTTPTest.QueryEncodeDecode to check generated query strings in URL to be 
> according alphabatic order.
> URLTest.Stringification to check generated query strings in URL to be 
> according alphabatic order.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 42794: URL query string order is defined.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42794/#review116362
---




3rdparty/libprocess/src/http.cpp (line 787)


Renaming this to `sortedQuery` better reflects the property of this map.



3rdparty/libprocess/src/http.cpp (line 788)


The size of `query` is know here, please reserve it for `_query`:

```cpp
_query.reserve(query.size());
```



3rdparty/libprocess/src/http.cpp (lines 789 - 791)


Please add a comment above this statement to explain what's happening here. 
I.e. "Adding `query` to a map will sort them alphabetically by their fields".



3rdparty/libprocess/src/http.cpp (line 790)


Why not use `map::emplace` here, to avoid unnecessary copies?


- Jan Schlicht


On Jan. 26, 2016, 11:55 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42794/
> ---
> 
> (Updated Jan. 26, 2016, 11:55 a.m.)
> 
> 
> Review request for mesos, Jan Schlicht and Vinod Kone.
> 
> 
> Bugs: MESOS-3317
> https://issues.apache.org/jira/browse/MESOS-3317
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> URL query string order is defined.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/http.cpp 762da9a9038fc0a81156b5c03b556084df1bd7e0 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> 66d185e3fd8a165d8a98d3d2752e756f8de3499b 
> 
> Diff: https://reviews.apache.org/r/42794/diff/
> 
> 
> Testing
> ---
> 
> The following test cases in http_test.cpp have been modified -
> HTTPTest.QueryEncodeDecode to check generated query strings in URL to be 
> according alphabatic order.
> URLTest.Stringification to check generated query strings in URL to be 
> according alphabatic order.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 42477: Corrected example in quota user doc.

[Alexander Rukletsov]

> On Jan. 22, 2016, 4:34 p.m., Bernd Mathiske wrote:
> > docs/quota.md, line 166
> > 
> >
> > Please explain what this seemingly redundant field is doing.
> 
> Guangya Liu wrote:
> I think this is because the current Quota can only works for unreserved 
> and non revocable resources. There is indeed a document 
> https://github.com/apache/mesos/blob/master/docs/quota.md for this, make 
> sense?
> 
> Joerg Schad wrote:
> We use the default Resource protobuf message which includes an optional 
> default field  
> ```optional string role = 6 [default = "*"];``` 
> (https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L563). 
> Note this is the status endpoint, i.e. this field is not used to specify 
> quota.

I agree with Bernd that printing out this field is misleading. Why we do so in 
the first place? Because that's how JSON is rendered from protobuf by default. 
Is this is a good reason not to care about it? Probably not. Moreover, we have 
a family of `model()` functions that specify how certain protobufs should be 
rendered in JSON (including `Resource`).

I think we can fix the current issue (this patch documents what is actually 
being returned) and file a separate ticket for more consistent rendering of 
`QuotaStatus`. Does it sound right, fellas?


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42477/#review115854
---


On Jan. 22, 2016, 3:43 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42477/
> ---
> 
> (Updated Jan. 22, 2016, 3:43 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van 
> Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/quota.md 208bfa06a9fc50843439bab9a041ccb557657b5d 
> 
> Diff: https://reviews.apache.org/r/42477/diff/
> 
> 
> Testing
> ---
> 
> None: Not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 42476: Introduced protobuf for set quota requests.

[Alexander Rukletsov]

> On Jan. 19, 2016, 8:37 a.m., Joerg Schad wrote:
> > include/mesos/quota/quota.proto, line 56
> > 
> >
> > I feel that optimizing here (with = 16) is more confusing than helpful, 
> > especially as this protobuf is mostly used as the schema for the json 
> > request.
> 
> Joris Van Remoortere wrote:
> What are we optimizing here? Room for more fields?

Yep, future fields.

"Tag numbers 1-15 require one less byte to encode than higher numbers, so as an 
optimization you can decide to use those tags for the commonly used or repeated 
elements, leaving tags 16 and higher for less-commonly used optional elements. 
Each element in a repeated field requires re-encoding the tag number, so 
repeated fields are particularly good candidates for this optimization."

https://developers.google.com/protocol-buffers/docs/cpptutorial?hl=en


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42476/#review115127
---


On Jan. 22, 2016, 3:43 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42476/
> ---
> 
> (Updated Jan. 22, 2016, 3:43 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, Joerg Schad, and Joris 
> Van Remoortere.
> 
> 
> Bugs: MESOS-4410
> https://issues.apache.org/jira/browse/MESOS-4410
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/quota.md 208bfa06a9fc50843439bab9a041ccb557657b5d 
>   include/mesos/quota/quota.proto 338412ee967e14aa1957a47f4a50f2e19e4eca79 
>   src/master/quota_handler.cpp aa06cbc83d2c467c2422f1d27bb9507998953c44 
>   src/tests/master_quota_tests.cpp 7d07be355b9323f2a7f27f84020a6ecc7f061140 
>   src/tests/role_tests.cpp 979391306e2427aaa63a5df32704913f79e20e36 
> 
> Diff: https://reviews.apache.org/r/42476/diff/
> 
> 
> Testing
> ---
> 
> make check on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 42476: Introduced protobuf for set quota requests.

[Alexander Rukletsov]

> On Jan. 25, 2016, 8:40 a.m., Joris Van Remoortere wrote:
> > include/mesos/quota/quota.proto, line 56
> > 
> >
> > I don't get the `16` as per Joerg's comment.

Commented on above.


> On Jan. 25, 2016, 8:40 a.m., Joris Van Remoortere wrote:
> > src/master/quota_handler.cpp, line 68
> > 
> >
> > Can you augment the `QuotaInfo` validation function with the new role 
> > validation introduced?

Sure.


> On Jan. 25, 2016, 8:40 a.m., Joris Van Remoortere wrote:
> > src/master/quota_handler.cpp, lines 67-69
> > 
> >
> > Please keep this function a general use one. Users of it should not 
> > need to create a `QuotaRequest` in order to construct a `QuotaInfo`.

I think we agreed to have `*Request` and `*Info` protobufs for request and 
storage respectively, and a converion function. If someone wants to construct 
`QuotaInfo`, why not doing it manually?


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42476/#review116062
---


On Jan. 22, 2016, 3:43 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42476/
> ---
> 
> (Updated Jan. 22, 2016, 3:43 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, Joerg Schad, and Joris 
> Van Remoortere.
> 
> 
> Bugs: MESOS-4410
> https://issues.apache.org/jira/browse/MESOS-4410
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/quota.md 208bfa06a9fc50843439bab9a041ccb557657b5d 
>   include/mesos/quota/quota.proto 338412ee967e14aa1957a47f4a50f2e19e4eca79 
>   src/master/quota_handler.cpp aa06cbc83d2c467c2422f1d27bb9507998953c44 
>   src/tests/master_quota_tests.cpp 7d07be355b9323f2a7f27f84020a6ecc7f061140 
>   src/tests/role_tests.cpp 979391306e2427aaa63a5df32704913f79e20e36 
> 
> Diff: https://reviews.apache.org/r/42476/diff/
> 
> 
> Testing
> ---
> 
> make check on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 42477: Corrected example in quota user doc.

[Bernd Mathiske]

> On Jan. 22, 2016, 8:34 a.m., Bernd Mathiske wrote:
> > docs/quota.md, line 166
> > 
> >
> > Please explain what this seemingly redundant field is doing.
> 
> Guangya Liu wrote:
> I think this is because the current Quota can only works for unreserved 
> and non revocable resources. There is indeed a document 
> https://github.com/apache/mesos/blob/master/docs/quota.md for this, make 
> sense?
> 
> Joerg Schad wrote:
> We use the default Resource protobuf message which includes an optional 
> default field  
> ```optional string role = 6 [default = "*"];``` 
> (https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L563). 
> Note this is the status endpoint, i.e. this field is not used to specify 
> quota.
> 
> Alexander Rukletsov wrote:
> I agree with Bernd that printing out this field is misleading. Why we do 
> so in the first place? Because that's how JSON is rendered from protobuf by 
> default. Is this is a good reason not to care about it? Probably not. 
> Moreover, we have a family of `model()` functions that specify how certain 
> protobufs should be rendered in JSON (including `Resource`).
> 
> I think we can fix the current issue (this patch documents what is 
> actually being returned) and file a separate ticket for more consistent 
> rendering of `QuotaStatus`. Does it sound right, fellas?

I agree with Alex.


- Bernd


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42477/#review115854
---


On Jan. 22, 2016, 7:43 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42477/
> ---
> 
> (Updated Jan. 22, 2016, 7:43 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van 
> Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/quota.md 208bfa06a9fc50843439bab9a041ccb557657b5d 
> 
> Diff: https://reviews.apache.org/r/42477/diff/
> 
> 
> Testing
> ---
> 
> None: Not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 41092: CMake: Added CMake file for agent executable build.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41092/#review116371
---



Patch looks great!

Reviews applied: [40951, 41090, 41092]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 26, 2016, 1:54 p.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41092/
> ---
> 
> (Updated Jan. 26, 2016, 1:54 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3843
> https://issues.apache.org/jira/browse/MESOS-3843
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added CMake file for agent executable build.
> 
> 
> Diffs
> -
> 
>   src/slave/CMakeLists.txt PRE-CREATION 
>   src/slave/cmake/SlaveConfigure.cmake 
> fbdfdaa27fbd8c7429861eea5baf401a221f748b 
> 
> Diff: https://reviews.apache.org/r/41092/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu and OSX.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 42477: Corrected example in quota user doc.

[Alexander Rukletsov]

> On Jan. 22, 2016, 4:34 p.m., Bernd Mathiske wrote:
> > docs/quota.md, line 166
> > 
> >
> > Please explain what this seemingly redundant field is doing.
> 
> Guangya Liu wrote:
> I think this is because the current Quota can only works for unreserved 
> and non revocable resources. There is indeed a document 
> https://github.com/apache/mesos/blob/master/docs/quota.md for this, make 
> sense?
> 
> Joerg Schad wrote:
> We use the default Resource protobuf message which includes an optional 
> default field  
> ```optional string role = 6 [default = "*"];``` 
> (https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L563). 
> Note this is the status endpoint, i.e. this field is not used to specify 
> quota.
> 
> Alexander Rukletsov wrote:
> I agree with Bernd that printing out this field is misleading. Why we do 
> so in the first place? Because that's how JSON is rendered from protobuf by 
> default. Is this is a good reason not to care about it? Probably not. 
> Moreover, we have a family of `model()` functions that specify how certain 
> protobufs should be rendered in JSON (including `Resource`).
> 
> I think we can fix the current issue (this patch documents what is 
> actually being returned) and file a separate ticket for more consistent 
> rendering of `QuotaStatus`. Does it sound right, fellas?
> 
> Bernd Mathiske wrote:
> I agree with Alex.

Filed https://issues.apache.org/jira/browse/MESOS-4512. Dropping the issue.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42477/#review115854
---


On Jan. 22, 2016, 3:43 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42477/
> ---
> 
> (Updated Jan. 22, 2016, 3:43 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van 
> Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/quota.md 208bfa06a9fc50843439bab9a041ccb557657b5d 
> 
> Diff: https://reviews.apache.org/r/42477/diff/
> 
> 
> Testing
> ---
> 
> None: Not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 42476: Introduced protobuf for set quota requests.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42476/
---

(Updated Jan. 26, 2016, 4:33 p.m.)


Review request for mesos, Bernd Mathiske, Ben Mahler, Joerg Schad, and Joris 
Van Remoortere.


Changes
---

Added role validation.


Bugs: MESOS-4410
https://issues.apache.org/jira/browse/MESOS-4410


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  docs/quota.md 208bfa06a9fc50843439bab9a041ccb557657b5d 
  include/mesos/quota/quota.proto 338412ee967e14aa1957a47f4a50f2e19e4eca79 
  src/master/quota.cpp 698150487da71e9dcd907d471067d62ff8a201b4 
  src/master/quota_handler.cpp aa06cbc83d2c467c2422f1d27bb9507998953c44 
  src/tests/master_quota_tests.cpp 7d07be355b9323f2a7f27f84020a6ecc7f061140 
  src/tests/role_tests.cpp 979391306e2427aaa63a5df32704913f79e20e36 

Diff: https://reviews.apache.org/r/42476/diff/


Testing
---

make check on Mac OS 10.10.4


Thanks,

Alexander Rukletsov

Review Request 42803: Fixed sign mismatched comparison in ContainerLoggerTest.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42803/
---

Review request for mesos, Joseph Wu and Jan Schlicht.


Bugs: MESOS-4513
https://issues.apache.org/jira/browse/MESOS-4513


Repository: mesos


Description
---

see summary.


Diffs
-

  src/tests/container_logger_tests.cpp ce551cbdb89ffb1fead3a58f2d0a1bd27f20f305 

Diff: https://reviews.apache.org/r/42803/diff/


Testing
---

make check (gcc-4.9)


Thanks,

Till Toenshoff

Re: Review Request 42803: Fixed sign mismatched comparison in ContainerLoggerTest.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42803/#review116375
---


Ship it!




Ship It!

- Jan Schlicht


On Jan. 26, 2016, 5:47 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42803/
> ---
> 
> (Updated Jan. 26, 2016, 5:47 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Jan Schlicht.
> 
> 
> Bugs: MESOS-4513
> https://issues.apache.org/jira/browse/MESOS-4513
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> see summary.
> 
> 
> Diffs
> -
> 
>   src/tests/container_logger_tests.cpp 
> ce551cbdb89ffb1fead3a58f2d0a1bd27f20f305 
> 
> Diff: https://reviews.apache.org/r/42803/diff/
> 
> 
> Testing
> ---
> 
> make check (gcc-4.9)
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 42797: Fix expire CERN GPG key link.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42797/#review116377
---



Patch looks great!

Reviews applied: [42797]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 26, 2016, 2:13 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42797/
> ---
> 
> (Updated Jan. 26, 2016, 2:13 p.m.)
> 
> 
> Review request for mesos, Adam B and Timothy Chen.
> 
> 
> Bugs: MESOS-4511
> https://issues.apache.org/jira/browse/MESOS-4511
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix expire CERN GPG key link.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 7177f9d5ae33dbabf0ed1bb1b9870873906e1a56 
> 
> Diff: https://reviews.apache.org/r/42797/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42803: Fixed sign mismatched comparison in ContainerLoggerTest.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42803/#review116381
---


Ship it!




I wish clang had included `-Wsign-compare` in `-Wall`.

- Anand Mazumdar


On Jan. 26, 2016, 4:47 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42803/
> ---
> 
> (Updated Jan. 26, 2016, 4:47 p.m.)
> 
> 
> Review request for mesos, Joseph Wu and Jan Schlicht.
> 
> 
> Bugs: MESOS-4513
> https://issues.apache.org/jira/browse/MESOS-4513
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> see summary.
> 
> 
> Diffs
> -
> 
>   src/tests/container_logger_tests.cpp 
> ce551cbdb89ffb1fead3a58f2d0a1bd27f20f305 
> 
> Diff: https://reviews.apache.org/r/42803/diff/
> 
> 
> Testing
> ---
> 
> make check (gcc-4.9)
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 42762: Improved performance of 'roles::validate'.

[Benjamin Bannier]

> On Jan. 26, 2016, 3:14 a.m., Anand Mazumdar wrote:
> > LGTM. Puzzled me for a bit at why the temporary is being constructed 
> > (assuming the correct `operator==` for `const char*` was being invoked) 
> > till I looked up here:
> > 
> > https://github.com/gcc-mirror/gcc/blob/master/libstdc%2B%2B-v3/include/bits/basic_string.h#L2468
> > 
> > ```
> >  Determines the effective length rlen of the strings to compare as the 
> > smallest of size() and the length of a string constructed from @a __s. 
> > ```

Maybe I am too dense, but I think this comment is misleading, see the impl 
https://github.com/gcc-mirror/gcc/blob/master/libstdc++-v3/include/bits/basic_string.tcc#L1390.
 Nothing there seems to construct a temporary string. What could cause 
different performance for `string` and `const char*` is that the length of a 
`const char*` might need to be calculated at runtime (technically a compiler 
could use the known length of the literal to make this a nop since this is all 
implemented in headers, 
https://code.woboq.org/gcc/include/c++/5.2.0/bits/char_traits.h.html#__gnu_cxx::char_traits::length).
 The actual comparsion is just a `memcmp` 
(https://code.woboq.org/gcc/include/c++/5.2.0/bits/char_traits.h.html#__gnu_cxx::char_traits::length).


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42762/#review116256
---


On Jan. 26, 2016, 1:10 a.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42762/
> ---
> 
> (Updated Jan. 26, 2016, 1:10 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This validation is used inside resource math which in turn is used
> heavily in the code base.
> The temporary string allocations caused a significant performance
> degradation in this critical path.
> 
> 
> Diffs
> -
> 
>   src/common/roles.cpp 5be807018ff84174cf0cabb933f6828d458d3846 
> 
> Diff: https://reviews.apache.org/r/42762/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 40553: Enable mesos tests installation.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review116385
---



Could you please rebase? This doesn't apply for me with `9e0528e`.

- Benjamin Bannier


On Jan. 22, 2016, 11:12 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> ---
> 
> (Updated Jan. 22, 2016, 11:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
> 
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
> 
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests \
> --build_dir=/none \
> --source_dir=/none
> 
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
> 
> 
> Diffs
> -
> 
>   Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
>   configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320 
>   src/Makefile.am 19bf3a7c2e43ca04ed6e6d506e052de5537f7c2f 
>   src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab 
>   src/tests/balloon_framework_test.sh 
> 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
>   src/tests/containerizer/launch_tests.cpp 
> c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
>   src/tests/containerizer/memory_test_helper.cpp 
> 4a3de2e3c887aa6afc604588850e1386f92d8c11 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 677fcc1c654f83ad3e60e0f6172a1a1e4a1045b1 
>   src/tests/containerizer/ns_tests.cpp 
> 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
>   src/tests/containerizer/port_mapping_tests.cpp 
> fab16f697f90abc11d681222f10f518d70da908b 
>   src/tests/environment.cpp 4de46bc48b245a4c5e89b0343578b0d31883a0ac 
>   src/tests/event_call_framework_test.sh 
> 9d1211552734afbf15b376f8c4629bae8a2065af 
>   src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
>   src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
>   src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22 
>   src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475 
>   src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
>   src/tests/no_executor_framework_test.sh 
> aebdc8c380abb2d041d6fc74dfac5a111c15267e 
>   src/tests/oversubscription_tests.cpp 
> 6f43103e81303015fb614653e3bfece55009d1bf 
>   src/tests/persistent_volume_framework_test.sh 
> 84f02847a8d89400512d8a5714d33fb29cf5b03a 
>   src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
>   src/tests/slave_tests.cpp e943ab99baf3d74679a5da89a89f6a4b7ead 
>   src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
>   src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
>   src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 
> 
> Diff: https://reviews.apache.org/r/40553/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 42751: Tweaked some resource test cases.

[Neil Conway]

> On Jan. 26, 2016, 6:37 a.m., Guangya Liu wrote:
> > src/tests/resources_tests.cpp, line 1603
> > 
> >
> > Why do you update here?

The goal of this test is to validate that two resources with different 
`ReservationInfo` are treated as distinct (not equal). If the roles are also 
different, then the resources will be considered distinct for that reason 
instead.


> On Jan. 26, 2016, 6:37 a.m., Guangya Liu wrote:
> > src/tests/resources_tests.cpp, lines 1672-1673
> > 
> >
> > Is this useful? I think that we already covered the `same` contain case 
> > in `EXPECT_TRUE((r1 + r2).contains(r1 + r2));`

I think it is useful, yes: the checks involving the `+` operator depend on 
`operator+` being implemented correctly.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42751/#review116289
---


On Jan. 25, 2016, 10:59 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42751/
> ---
> 
> (Updated Jan. 25, 2016, 10:59 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We should check that two reservations with the same role but different
> principals are considered distinct.
> 
> 
> Diffs
> -
> 
>   src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23 
> 
> Diff: https://reviews.apache.org/r/42751/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Review Request 42806: Added the fetcher plugin module interface.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42806/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-3926
https://issues.apache.org/jira/browse/MESOS-3926


Repository: mesos


Description
---

Added the fetcher plugin module interface.


Diffs
-

  include/mesos/module/fetcher_plugin.hpp PRE-CREATION 
  src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 
  src/examples/test_fetcher_plugin_module.cpp PRE-CREATION 
  src/module/manager.cpp a53f71b9965f7ab85aadb6c0c7af18de958faf38 
  src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8 
  src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e 
  src/uri/fetcher.hpp 5bc9703b76457413b5841710e0313f8bfa9047a1 
  src/uri/fetcher.cpp dfda732348fec3b686cf82b55ad94fda4829469b 

Diff: https://reviews.apache.org/r/42806/diff/


Testing
---

make check -j4


Thanks,

Shuai Lin

Re: Review Request 42806: Added the fetcher plugin module interface.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42806/
---

(Updated Jan. 26, 2016, 5:56 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Add a "external_" prefix to external fetcher plugin to avoid name confliction 
with builtin plugins.


Bugs: MESOS-3926
https://issues.apache.org/jira/browse/MESOS-3926


Repository: mesos


Description (updated)
---

Review: https://reviews.apache.org/r/42806


Diffs (updated)
-

  include/mesos/module/fetcher_plugin.hpp PRE-CREATION 
  src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 
  src/examples/test_fetcher_plugin_module.cpp PRE-CREATION 
  src/module/manager.cpp a53f71b9965f7ab85aadb6c0c7af18de958faf38 
  src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8 
  src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e 
  src/uri/fetcher.hpp 5bc9703b76457413b5841710e0313f8bfa9047a1 
  src/uri/fetcher.cpp dfda732348fec3b686cf82b55ad94fda4829469b 

Diff: https://reviews.apache.org/r/42806/diff/


Testing
---

make check -j4


Thanks,

Shuai Lin

Re: Review Request 42806: Added the fetcher plugin module interface.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42806/
---

(Updated Jan. 26, 2016, 5:56 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-3926
https://issues.apache.org/jira/browse/MESOS-3926


Repository: mesos


Description (updated)
---

Added the fetcher plugin module interface.


Diffs
-

  include/mesos/module/fetcher_plugin.hpp PRE-CREATION 
  src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 
  src/examples/test_fetcher_plugin_module.cpp PRE-CREATION 
  src/module/manager.cpp a53f71b9965f7ab85aadb6c0c7af18de958faf38 
  src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8 
  src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e 
  src/uri/fetcher.hpp 5bc9703b76457413b5841710e0313f8bfa9047a1 
  src/uri/fetcher.cpp dfda732348fec3b686cf82b55ad94fda4829469b 

Diff: https://reviews.apache.org/r/42806/diff/


Testing
---

make check -j4


Thanks,

Shuai Lin

Re: Review Request 42806: Added the fetcher plugin module interface.

[Shuai Lin]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42806/
---

(Updated Jan. 26, 2016, 5:58 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-3926
https://issues.apache.org/jira/browse/MESOS-3926


Repository: mesos


Description
---

Added the fetcher plugin module interface.


Diffs
-

  include/mesos/module/fetcher_plugin.hpp PRE-CREATION 
  src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 
  src/examples/test_fetcher_plugin_module.cpp PRE-CREATION 
  src/module/manager.cpp a53f71b9965f7ab85aadb6c0c7af18de958faf38 
  src/tests/module.hpp 4b32f29f2ce76100433621a5cb6b8cc87c9b38f8 
  src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e 
  src/uri/fetcher.hpp 5bc9703b76457413b5841710e0313f8bfa9047a1 
  src/uri/fetcher.cpp dfda732348fec3b686cf82b55ad94fda4829469b 

Diff: https://reviews.apache.org/r/42806/diff/


Testing (updated)
---

make check


Thanks,

Shuai Lin

Re: Review Request 42794: URL query string order is defined.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42794/#review116392
---




3rdparty/libprocess/src/http.cpp (lines 787 - 791)


Instead of manually iterating, just create the `map` directly from the 
`hashmap` values, e.g.,

const map _query{query.begin(), query.end()};

(rename `_query` as you see fit). This removes most of the issues Jan 
raised.


- Benjamin Bannier


On Jan. 26, 2016, 11:55 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42794/
> ---
> 
> (Updated Jan. 26, 2016, 11:55 a.m.)
> 
> 
> Review request for mesos, Jan Schlicht and Vinod Kone.
> 
> 
> Bugs: MESOS-3317
> https://issues.apache.org/jira/browse/MESOS-3317
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> URL query string order is defined.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/http.cpp 762da9a9038fc0a81156b5c03b556084df1bd7e0 
>   3rdparty/libprocess/src/tests/http_tests.cpp 
> 66d185e3fd8a165d8a98d3d2752e756f8de3499b 
> 
> Diff: https://reviews.apache.org/r/42794/diff/
> 
> 
> Testing
> ---
> 
> The following test cases in http_test.cpp have been modified -
> HTTPTest.QueryEncodeDecode to check generated query strings in URL to be 
> according alphabatic order.
> URLTest.Stringification to check generated query strings in URL to be 
> according alphabatic order.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Re: Review Request 42476: Introduced protobuf for set quota requests.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42476/#review116400
---



Patch looks great!

Reviews applied: [42477, 42476]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 26, 2016, 4:33 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42476/
> ---
> 
> (Updated Jan. 26, 2016, 4:33 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, Joerg Schad, and Joris 
> Van Remoortere.
> 
> 
> Bugs: MESOS-4410
> https://issues.apache.org/jira/browse/MESOS-4410
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/quota.md 208bfa06a9fc50843439bab9a041ccb557657b5d 
>   include/mesos/quota/quota.proto 338412ee967e14aa1957a47f4a50f2e19e4eca79 
>   src/master/quota.cpp 698150487da71e9dcd907d471067d62ff8a201b4 
>   src/master/quota_handler.cpp aa06cbc83d2c467c2422f1d27bb9507998953c44 
>   src/tests/master_quota_tests.cpp 7d07be355b9323f2a7f27f84020a6ecc7f061140 
>   src/tests/role_tests.cpp 979391306e2427aaa63a5df32704913f79e20e36 
> 
> Diff: https://reviews.apache.org/r/42476/diff/
> 
> 
> Testing
> ---
> 
> make check on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 42754: Added support for labels to resource reservations.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42754/
---

(Updated Jan. 26, 2016, 6:34 p.m.)


Review request for mesos and Michael Park.


Changes
---

Improved unit tests per review comments.


Bugs: MESOS-4479
https://issues.apache.org/jira/browse/MESOS-4479


Repository: mesos


Description
---

Labels are free-form key-value pairs that can be used to associate
metadata with reserved resources.


Diffs (updated)
-

  include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247 
  include/mesos/type_utils.hpp 16f9cda83edd5064527b89e94392a7a54411 
  include/mesos/v1/mesos.hpp b294f022345dc892c0581622c5b389efbde911a9 
  include/mesos/v1/mesos.proto 0501dfa27ed610666226953591a902eac4c295f8 
  src/common/resources.cpp 0fcf86014ab5c9908a1cdb3a57b7c5e70acd7737 
  src/common/type_utils.cpp 76f48f6a1f5467db032ded8acd296d03353b4172 
  src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b 
  src/tests/reservation_endpoints_tests.cpp 
35c093567b07a11ca6eee85e2ff91894a460a7af 
  src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23 
  src/v1/mesos.cpp 9264752c6b82eaa844ce356b879f92d562ed4e45 
  src/v1/resources.cpp 126e5a2f567d2e281da3f99bc485f7960567eee5 

Diff: https://reviews.apache.org/r/42754/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 42754: Added support for labels to resource reservations.

[Neil Conway]

> On Jan. 26, 2016, 8:03 a.m., Guangya Liu wrote:
> > src/tests/reservation_endpoints_tests.cpp, line 782
> > 
> >
> > why does the offerResources contain the labeledResources2? The 
> > labeledResources2 should be filtered when allocate?

Sorry, I'm not sure what you mean. Can you clarify?


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42754/#review116304
---


On Jan. 26, 2016, 6:34 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42754/
> ---
> 
> (Updated Jan. 26, 2016, 6:34 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4479
> https://issues.apache.org/jira/browse/MESOS-4479
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Labels are free-form key-value pairs that can be used to associate
> metadata with reserved resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247 
>   include/mesos/type_utils.hpp 16f9cda83edd5064527b89e94392a7a54411 
>   include/mesos/v1/mesos.hpp b294f022345dc892c0581622c5b389efbde911a9 
>   include/mesos/v1/mesos.proto 0501dfa27ed610666226953591a902eac4c295f8 
>   src/common/resources.cpp 0fcf86014ab5c9908a1cdb3a57b7c5e70acd7737 
>   src/common/type_utils.cpp 76f48f6a1f5467db032ded8acd296d03353b4172 
>   src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b 
>   src/tests/reservation_endpoints_tests.cpp 
> 35c093567b07a11ca6eee85e2ff91894a460a7af 
>   src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23 
>   src/v1/mesos.cpp 9264752c6b82eaa844ce356b879f92d562ed4e45 
>   src/v1/resources.cpp 126e5a2f567d2e281da3f99bc485f7960567eee5 
> 
> Diff: https://reviews.apache.org/r/42754/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42787: Fixed whitespace errors in help strings for mesos/src.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42787/#review116402
---


Ship it!




Ship It!

- Neil Conway


On Jan. 26, 2016, 7:41 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42787/
> ---
> 
> (Updated Jan. 26, 2016, 7:41 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously some of the help strings included a blank space at the end of
> some of their lines of text. This was causing problems when using these
> strings to generate .md files and then attempting to commit them back to
> the repo.
> 
> This commit removes this unnecessary whitespace.
> 
> 
> Diffs
> -
> 
>   src/master/http.cpp 12c1fe5a514903f657911302e8770e9b245fdbb7 
>   src/master/registrar.cpp c46cc064413c02e22d48a47a17f8d3df2546c9c9 
>   src/slave/http.cpp 0ba2e82fd8ce58508f364aff761d50dc4f264f65 
> 
> Diff: https://reviews.apache.org/r/42787/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42788: Fixed whitespace errors in help strings for 3rdparty/libprocess.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42788/#review116403
---


Ship it!




Ship It!

- Neil Conway


On Jan. 26, 2016, 7:41 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42788/
> ---
> 
> (Updated Jan. 26, 2016, 7:41 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously some of the help strings includes a blank space at the end of
> some of their lines of text. This was causing problems when using these
> strings to generate .md files and then attempting to commit them back to
> the repo.
> 
> This commit removes this unnecessary whitespace.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/metrics/metrics.cpp 
> 985fb5fcf3201ca767e6defc72a10b412ffd20a1 
> 
> Diff: https://reviews.apache.org/r/42788/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.

[Artem Harutyunyan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41818/
---

(Updated Jan. 26, 2016, 10:48 a.m.)


Review request for mesos, Artem Harutyunyan and Jie Yu.


Bugs: MESOS-4281
https://issues.apache.org/jira/browse/MESOS-4281


Repository: mesos


Description
---

Handled quota when volumes are bind mounted into the sandbox.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/posix/disk.hpp 
31808c1e8199fbf2cea36c273860fdbf0a2388f8 
  src/slave/containerizer/mesos/isolators/posix/disk.cpp 
248c34adb63907911d89bed5b1519682a852bb2d 
  src/tests/containerizer/filesystem_isolator_tests.cpp 
5bb85034c22caef64054c1629f6fd55d227e48b1 
  src/tests/disk_quota_tests.cpp 1577cf71c4d1fbad11e2ec939c4ceae2d5b25f97 

Diff: https://reviews.apache.org/r/41818/diff/


Testing
---

sudo mesos-tests.sh


Thanks,

Artem Harutyunyan

Re: Review Request 39781: Update ModuleTest to not assume dynamic dlopen search.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39781/
---

(Updated Jan. 26, 2016, 7:24 p.m.)


Review request for mesos, Benjamin Bannier, Kapil Arya, Niklas Nielsen, and 
Till Toenshoff.


Changes
---

Rebased onto master.


Bugs: MESOS-3725
https://issues.apache.org/jira/browse/MESOS-3725


Repository: mesos


Description
---

Update ModuleTest to not assume dynamic dlopen search.


Diffs (updated)
-

  src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 

Diff: https://reviews.apache.org/r/39781/diff/


Testing
---

make check


Thanks,

James Peach

Re: Review Request 39780: Update OversubscriptionTest to not assume dynamic dlopen search.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39780/
---

(Updated Jan. 26, 2016, 7:24 p.m.)


Review request for mesos, Benjamin Bannier, Kapil Arya, Niklas Nielsen, and 
Till Toenshoff.


Changes
---

Rebased onto master.


Bugs: MESOS-3725
https://issues.apache.org/jira/browse/MESOS-3725


Repository: mesos


Description
---

Update OversubscriptionTest to not assume dynamic dlopen search.


Diffs (updated)
-

  src/tests/oversubscription_tests.cpp 6f43103e81303015fb614653e3bfece55009d1bf 

Diff: https://reviews.apache.org/r/39780/diff/


Testing
---

make check


Thanks,

James Peach

Re: Review Request 39782: Add a comment for os::libraries::setPaths.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39782/
---

(Updated Jan. 26, 2016, 7:24 p.m.)


Review request for mesos, Benjamin Bannier, Kapil Arya, Niklas Nielsen, and 
Till Toenshoff.


Changes
---

Rebased onto master.


Bugs: MESOS-3725
https://issues.apache.org/jira/browse/MESOS-3725


Repository: mesos


Description
---

Add a comment for os::libraries::setPaths.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
ed3bb2c5ab035d8c0bbf9f44baa2b0b8fb1f79b6 

Diff: https://reviews.apache.org/r/39782/diff/


Testing
---

No code changes.


Thanks,

James Peach

Re: Review Request 42792: Fix compile error in container logger tests.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42792/#review116427
---



Sorry about that.  Till already committed an identical patch.  
https://reviews.apache.org/r/42803/

- Joseph Wu


On Jan. 26, 2016, 12:12 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42792/
> ---
> 
> (Updated Jan. 26, 2016, 12:12 a.m.)
> 
> 
> Review request for mesos and Joseph Wu.
> 
> 
> Bugs: MESOS-4508
> https://issues.apache.org/jira/browse/MESOS-4508
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use unsigned value when comparing with kilobytes.
> 
> 
> Diffs
> -
> 
>   src/tests/container_logger_tests.cpp 
> ce551cbdb89ffb1fead3a58f2d0a1bd27f20f305 
> 
> Diff: https://reviews.apache.org/r/42792/diff/
> 
> 
> Testing
> ---
> 
> make check on OSX and Ubuntu 15.04
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Re: Review Request 42790: Added documentation for all http endpoints.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42790/#review116423
---



Instead of committing these auto-generated files, it might be better to 
consider adding `mesos-endpoint-docs` to the website generating Rakefile.

- Joseph Wu


On Jan. 25, 2016, 11:42 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42790/
> ---
> 
> (Updated Jan. 25, 2016, 11:42 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These .md files were auto generated using mesos-endpoints-help.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/files/browse.json/index.md PRE-CREATION 
>   docs/endpoints/files/browse.md PRE-CREATION 
>   docs/endpoints/files/debug.json/index.md PRE-CREATION 
>   docs/endpoints/files/debug.md PRE-CREATION 
>   docs/endpoints/files/download.json/index.md PRE-CREATION 
>   docs/endpoints/files/download.md PRE-CREATION 
>   docs/endpoints/files/read.json/index.md PRE-CREATION 
>   docs/endpoints/files/read.md PRE-CREATION 
>   docs/endpoints/index.md PRE-CREATION 
>   docs/endpoints/logging/toggle.md PRE-CREATION 
>   docs/endpoints/master/api/v1/scheduler.md PRE-CREATION 
>   docs/endpoints/master/create-volumes.md PRE-CREATION 
>   docs/endpoints/master/destroy-volumes.md PRE-CREATION 
>   docs/endpoints/master/flags.md PRE-CREATION 
>   docs/endpoints/master/frameworks.md PRE-CREATION 
>   docs/endpoints/master/health.md PRE-CREATION 
>   docs/endpoints/master/machine/down.md PRE-CREATION 
>   docs/endpoints/master/machine/up.md PRE-CREATION 
>   docs/endpoints/master/maintenance/schedule.md PRE-CREATION 
>   docs/endpoints/master/maintenance/status.md PRE-CREATION 
>   docs/endpoints/master/observe.md PRE-CREATION 
>   docs/endpoints/master/quota.md PRE-CREATION 
>   docs/endpoints/master/redirect.md PRE-CREATION 
>   docs/endpoints/master/reserve.md PRE-CREATION 
>   docs/endpoints/master/roles.json/index.md PRE-CREATION 
>   docs/endpoints/master/roles.md PRE-CREATION 
>   docs/endpoints/master/slaves.md PRE-CREATION 
>   docs/endpoints/master/state-summary.md PRE-CREATION 
>   docs/endpoints/master/state.json/index.md PRE-CREATION 
>   docs/endpoints/master/state.md PRE-CREATION 
>   docs/endpoints/master/tasks.json/index.md PRE-CREATION 
>   docs/endpoints/master/tasks.md PRE-CREATION 
>   docs/endpoints/master/teardown.md PRE-CREATION 
>   docs/endpoints/master/unreserve.md PRE-CREATION 
>   docs/endpoints/metrics/snapshot.md PRE-CREATION 
>   docs/endpoints/monitor/statistics.json/index.md PRE-CREATION 
>   docs/endpoints/monitor/statistics.md PRE-CREATION 
>   docs/endpoints/profiler/start.md PRE-CREATION 
>   docs/endpoints/profiler/stop.md PRE-CREATION 
>   docs/endpoints/registrar/registry.md PRE-CREATION 
>   docs/endpoints/slave/api/v1/executor.md PRE-CREATION 
>   docs/endpoints/slave/flags.md PRE-CREATION 
>   docs/endpoints/slave/health.md PRE-CREATION 
>   docs/endpoints/slave/state.json/index.md PRE-CREATION 
>   docs/endpoints/slave/state.md PRE-CREATION 
>   docs/endpoints/system/stats.json/index.md PRE-CREATION 
>   docs/endpoints/version.md PRE-CREATION 
>   site/Rakefile 0ce4b7975f95ab6930f0b2674191930df9ab5b20 
> 
> Diff: https://reviews.apache.org/r/42790/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42790: Added documentation for all http endpoints.

[Greg Mann]

> On Jan. 26, 2016, 7:37 p.m., Joseph Wu wrote:
> > Instead of committing these auto-generated files, it might be better to 
> > consider adding `mesos-endpoint-docs` to the website generating Rakefile.

Perhaps it's good to have a static copy of the files committed to the repo, so 
that a user who clones it has access to the docs without building and running 
the executable first?


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42790/#review116423
---


On Jan. 26, 2016, 7:42 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42790/
> ---
> 
> (Updated Jan. 26, 2016, 7:42 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> These .md files were auto generated using mesos-endpoints-help.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/files/browse.json/index.md PRE-CREATION 
>   docs/endpoints/files/browse.md PRE-CREATION 
>   docs/endpoints/files/debug.json/index.md PRE-CREATION 
>   docs/endpoints/files/debug.md PRE-CREATION 
>   docs/endpoints/files/download.json/index.md PRE-CREATION 
>   docs/endpoints/files/download.md PRE-CREATION 
>   docs/endpoints/files/read.json/index.md PRE-CREATION 
>   docs/endpoints/files/read.md PRE-CREATION 
>   docs/endpoints/index.md PRE-CREATION 
>   docs/endpoints/logging/toggle.md PRE-CREATION 
>   docs/endpoints/master/api/v1/scheduler.md PRE-CREATION 
>   docs/endpoints/master/create-volumes.md PRE-CREATION 
>   docs/endpoints/master/destroy-volumes.md PRE-CREATION 
>   docs/endpoints/master/flags.md PRE-CREATION 
>   docs/endpoints/master/frameworks.md PRE-CREATION 
>   docs/endpoints/master/health.md PRE-CREATION 
>   docs/endpoints/master/machine/down.md PRE-CREATION 
>   docs/endpoints/master/machine/up.md PRE-CREATION 
>   docs/endpoints/master/maintenance/schedule.md PRE-CREATION 
>   docs/endpoints/master/maintenance/status.md PRE-CREATION 
>   docs/endpoints/master/observe.md PRE-CREATION 
>   docs/endpoints/master/quota.md PRE-CREATION 
>   docs/endpoints/master/redirect.md PRE-CREATION 
>   docs/endpoints/master/reserve.md PRE-CREATION 
>   docs/endpoints/master/roles.json/index.md PRE-CREATION 
>   docs/endpoints/master/roles.md PRE-CREATION 
>   docs/endpoints/master/slaves.md PRE-CREATION 
>   docs/endpoints/master/state-summary.md PRE-CREATION 
>   docs/endpoints/master/state.json/index.md PRE-CREATION 
>   docs/endpoints/master/state.md PRE-CREATION 
>   docs/endpoints/master/tasks.json/index.md PRE-CREATION 
>   docs/endpoints/master/tasks.md PRE-CREATION 
>   docs/endpoints/master/teardown.md PRE-CREATION 
>   docs/endpoints/master/unreserve.md PRE-CREATION 
>   docs/endpoints/metrics/snapshot.md PRE-CREATION 
>   docs/endpoints/monitor/statistics.json/index.md PRE-CREATION 
>   docs/endpoints/monitor/statistics.md PRE-CREATION 
>   docs/endpoints/profiler/start.md PRE-CREATION 
>   docs/endpoints/profiler/stop.md PRE-CREATION 
>   docs/endpoints/registrar/registry.md PRE-CREATION 
>   docs/endpoints/slave/api/v1/executor.md PRE-CREATION 
>   docs/endpoints/slave/flags.md PRE-CREATION 
>   docs/endpoints/slave/health.md PRE-CREATION 
>   docs/endpoints/slave/state.json/index.md PRE-CREATION 
>   docs/endpoints/slave/state.md PRE-CREATION 
>   docs/endpoints/system/stats.json/index.md PRE-CREATION 
>   docs/endpoints/version.md PRE-CREATION 
>   site/Rakefile 0ce4b7975f95ab6930f0b2674191930df9ab5b20 
> 
> Diff: https://reviews.apache.org/r/42790/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/
---

(Updated Jan. 26, 2016, 7:49 p.m.)


Review request for mesos, Jie Yu and Michael Park.


Changes
---

Updated for non-linux build.


Bugs: MESOS-191
https://issues.apache.org/jira/browse/MESOS-191


Repository: mesos


Description
---

Multiple Disk: Added persistent volumes tests for `MOUNT` type.


Diffs (updated)
-

  src/tests/persistent_volume_tests.cpp 
cbf2bcedd5b4c14107d3b50a74f161aa9395d7d0 
  src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23 

Diff: https://reviews.apache.org/r/42684/diff/


Testing
---

sudo make check


Thanks,

Joris Van Remoortere

Re: Review Request 42810: Added the CgroupInfo protobuf. The agent can use this message to reflect any cgroup configuration that might have been applied to a container.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42810/
---

(Updated Jan. 26, 2016, 7:52 p.m.)


Review request for mesos and Jie Yu.


Summary (updated)
-

Added the CgroupInfo protobuf. The agent can use this message to reflect any 
cgroup configuration that might have been applied to a container.


Bugs: MESOS-4488
https://issues.apache.org/jira/browse/MESOS-4488


Repository: mesos


Description
---

Added the CgroupInfo protobuf. The agent can use this message to reflect any 
cgroup configuration that might have been applied to a container.


Diffs (updated)
-

  include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b 
  include/mesos/v1/mesos.proto c3244e87f9351c71312d2eace7a49bcac926fafd 

Diff: https://reviews.apache.org/r/42810/diff/


Testing
---

make


Thanks,

Avinash sridharan

Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41818/#review116441
---



Patch looks great!

Reviews applied: [41704, 41705, 41818]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 26, 2016, 6:48 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41818/
> ---
> 
> (Updated Jan. 26, 2016, 6:48 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Jie Yu.
> 
> 
> Bugs: MESOS-4281
> https://issues.apache.org/jira/browse/MESOS-4281
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Handled quota when volumes are bind mounted into the sandbox.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/posix/disk.hpp 
> 31808c1e8199fbf2cea36c273860fdbf0a2388f8 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> 248c34adb63907911d89bed5b1519682a852bb2d 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 5bb85034c22caef64054c1629f6fd55d227e48b1 
>   src/tests/disk_quota_tests.cpp 1577cf71c4d1fbad11e2ec939c4ceae2d5b25f97 
> 
> Diff: https://reviews.apache.org/r/41818/diff/
> 
> 
> Testing
> ---
> 
> sudo mesos-tests.sh
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 40851: Windows:[1/2] Updated zookeeper-3.4.5.patch to fix VS2015 build.

[M Lawindi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40851/
---

(Updated Jan. 26, 2016, 8:18 p.m.)


Review request for mesos, Alex Naparu, Dario Bazan, Daniel Pravat, Alex 
Clemmer, and M Lawindi.


Repository: mesos


Description
---

Windows:[1/2] Updated zookeeper-3.4.5.patch to fix VS2015 build.


Diffs (updated)
-

  3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da 

Diff: https://reviews.apache.org/r/40851/diff/


Testing
---

- Applied patch to original zookeeper 3.4.5
- Successfully opened 2015 solution in VS2015
- Cli and Zookeeper build successfully


Thanks,

M Lawindi

Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/
---

(Updated Jan. 26, 2016, 8:20 p.m.)


Review request for mesos, Jie Yu and Michael Park.


Changes
---

fixed non-linux compilation issue.


Bugs: MESOS-191
https://issues.apache.org/jira/browse/MESOS-191


Repository: mesos


Description
---

Multiple Disk: Added persistent volumes tests for `MOUNT` type.


Diffs (updated)
-

  src/tests/persistent_volume_tests.cpp 
cbf2bcedd5b4c14107d3b50a74f161aa9395d7d0 
  src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23 

Diff: https://reviews.apache.org/r/42684/diff/


Testing
---

sudo make check


Thanks,

Joris Van Remoortere

Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41818/#review116424
---


Fix it, then Ship it!





src/tests/disk_quota_tests.cpp (lines 144 - 147)


This should be wrapped with ifdef linux. I fixed it for you.


- Jie Yu


On Jan. 26, 2016, 6:48 p.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41818/
> ---
> 
> (Updated Jan. 26, 2016, 6:48 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Jie Yu.
> 
> 
> Bugs: MESOS-4281
> https://issues.apache.org/jira/browse/MESOS-4281
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Handled quota when volumes are bind mounted into the sandbox.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/posix/disk.hpp 
> 31808c1e8199fbf2cea36c273860fdbf0a2388f8 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> 248c34adb63907911d89bed5b1519682a852bb2d 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 5bb85034c22caef64054c1629f6fd55d227e48b1 
>   src/tests/disk_quota_tests.cpp 1577cf71c4d1fbad11e2ec939c4ceae2d5b25f97 
> 
> Diff: https://reviews.apache.org/r/41818/diff/
> 
> 
> Testing
> ---
> 
> sudo mesos-tests.sh
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

[Anand Mazumdar]

> On Jan. 25, 2016, 9:58 p.m., Vinod Kone wrote:
> > src/executor/executor.cpp, line 361
> > 
> >
> > dont you want to set `subscribe` and `nonSubscribe` to None()?

As per our discussion, we don't set them to `None()` since we need them later 
when `_recoveryTimeout` is invoked.


> On Jan. 25, 2016, 9:58 p.m., Vinod Kone wrote:
> > src/executor/executor.cpp, line 368
> > 
> >
> > Why is this outside the `if (state == CONNECTED)` block? I'm guessing 
> > you don't want to fire multiple delays one for subscribe disconnection and 
> > nonSubscribe disconnection for example?
> > 
> > If yes, you might just want to do the below at the top of this method.
> > 
> > ```
> > if (state == DISCONNECTED) {
> >   return;
> > }
> > ```
> > 
> > and merge this if block with the one at #352.

Fixed. Previously, we used to fire 2 retries for both the 
subscribe/non-subscribe connections. Thanks for noticing it. As per our 
discussion, now we retry inside the `backoff` function instead of 
`disconnected` only once per disconnection.


> On Jan. 25, 2016, 9:58 p.m., Vinod Kone wrote:
> > src/executor/executor.cpp, line 299
> > 
> >
> > Maybe mention when state transitions from/to CONNECTED/DISCONNECTED?

We mention them when we define the `enum`. Let me know if that is not enough.


- Anand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41283/#review116179
---


On Jan. 22, 2016, 1:36 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41283/
> ---
> 
> (Updated Jan. 22, 2016, 1:36 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-3550
> https://issues.apache.org/jira/browse/MESOS-3550
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces the implementation for the executor library. 
> 
> This uses the new HTTP Connection interface to ensure calls are properly 
> pipelined.
> 
> `connected` -> Callback invoked when a TCP connection is established with the 
> agent for the `Subscribe` call.
> `disconnected` -> When the `Subscribe` TCP connection is interrupted possibly 
> due to an agent restart.
> `received` -> When the executor receives events from the agent upon 
> subscribing.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1 
>   src/executor/executor.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41283/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 41283: V1 Executor Library over HTTP

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41283/
---

(Updated Jan. 26, 2016, 8:33 p.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
---

Review comments from Vinod


Summary (updated)
-

V1 Executor Library over HTTP


Bugs: MESOS-3550
https://issues.apache.org/jira/browse/MESOS-3550


Repository: mesos


Description (updated)
---

V1 Executor Library over HTTP


Diffs (updated)
-

  src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1 
  src/executor/executor.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41283/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 42786: Exposed the global 'help' process and added getter functions to it.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42786/#review116432
---




3rdparty/libprocess/include/process/help.hpp (line 111)


Returning a raw pointer here is unfortunate. I wonder if it would be better 
to return the map by value (since performance is unlikely to matter for most 
callers), or else return a `shared_ptr`.



3rdparty/libprocess/src/help.cpp (line 104)


Should just be `string`, not `std::string`.


- Neil Conway


On Jan. 26, 2016, 7:40 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42786/
> ---
> 
> (Updated Jan. 26, 2016, 7:40 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, there was no way to extract the help strings from the help
> process once they had been installed into it.  The only way to get at
> them was to visit the http endpoint they were associated with and pull
> it from there.
> 
> This commit adds API calls to the process::Help class to get at these
> strings more easily.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/help.hpp 
> 2e76a6a5b1069abce879374a88cea65036873f1d 
>   3rdparty/libprocess/include/process/process.hpp 
> 1e4126f1082c24debd9d713b490d18f5ed83f0be 
>   3rdparty/libprocess/src/help.cpp 2f718b9e160113518fb4a0260db916cb2242dbae 
> 
> Diff: https://reviews.apache.org/r/42786/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Review Request 42820: Fixed logrotate ContainerLogger on Centos6.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42820/
---

Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till 
Toenshoff.


Bugs: MESOS-4515
https://issues.apache.org/jira/browse/MESOS-4515


Repository: mesos


Description
---

The `logrotate --version` flag is actually a very recent addition (3.9.1).  The 
`--help` flag is more likely to be present on a supported 
system-with-logrotate, given logrotate's usage of popopt.


Diffs
-

  src/slave/container_loggers/lib_logrotate.hpp 
5f79fd8797d9ce0de0b2c12ba2dad61f83a11e02 
  src/slave/container_loggers/logrotate.hpp 
fd9c071bbd4c07ad8728c63c42fd63c0bba2573f 

Diff: https://reviews.apache.org/r/42820/diff/


Testing
---

make check on OSX & Centos6


Thanks,

Joseph Wu

Re: Review Request 42789: Added support file to autogenerate docs from endpoint help strings.

[Neil Conway]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42789/#review116436
---




support/endpoint-docs.cpp (line 80)


Should probably add `using std::string;`



support/endpoint-docs.cpp (line 86)


Typo in comment.



support/endpoint-docs.cpp (line 87)


Comment should end in a period.



support/endpoint-docs.cpp (line 103)


Better to use `foreach` or a range-based `for`, probably.



support/endpoint-docs.cpp (line 150)


Typo



support/endpoint-docs.cpp (line 160)


This comment is confusing.



support/endpoint-docs.cpp (line 177)


If the string's length is < 5 characters, seems like this would overflow 
and throw an exception.



support/endpoint-docs.cpp (line 251)


Comment should end in a period.



support/endpoint-docs.cpp (line 267)


Comment should end in a period.



support/endpoint-docs.cpp (line 328)


Comment should end in a period.



support/endpoint-docs.cpp (line 383)


Comment should end in a period.


- Neil Conway


On Jan. 26, 2016, 7:41 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42789/
> ---
> 
> (Updated Jan. 26, 2016, 7:41 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> After building mesos from source, an executable called
> mesos-endpoint-docs will be created in build/src. Invoke this executable
> with the flag --dirname=../docs/endpoints to autogenerate documentation
> for all endpoint strings and install it into the proper location.  In a
> subsequent commit we will add a link to this directory in home.md.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 
>   support/endpoint-docs.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42789/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42476: Introduced protobuf for set quota requests.

[Alexander Rukletsov]

> On Jan. 19, 2016, 8:37 a.m., Joerg Schad wrote:
> > include/mesos/quota/quota.proto, line 56
> > 
> >
> > I feel that optimizing here (with = 16) is more confusing than helpful, 
> > especially as this protobuf is mostly used as the schema for the json 
> > request.
> 
> Joris Van Remoortere wrote:
> What are we optimizing here? Room for more fields?
> 
> Alexander Rukletsov wrote:
> Yep, future fields.
> 
> "Tag numbers 1-15 require one less byte to encode than higher numbers, so 
> as an optimization you can decide to use those tags for the commonly used or 
> repeated elements, leaving tags 16 and higher for less-commonly used optional 
> elements. Each element in a repeated field requires re-encoding the tag 
> number, so repeated fields are particularly good candidates for this 
> optimization."
> 
> https://developers.google.com/protocol-buffers/docs/cpptutorial?hl=en

After an offline conversation with Joris we decided not to introduce this 
optimization.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42476/#review115127
---


On Jan. 26, 2016, 4:33 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42476/
> ---
> 
> (Updated Jan. 26, 2016, 4:33 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, Joerg Schad, and Joris 
> Van Remoortere.
> 
> 
> Bugs: MESOS-4410
> https://issues.apache.org/jira/browse/MESOS-4410
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   docs/quota.md 208bfa06a9fc50843439bab9a041ccb557657b5d 
>   include/mesos/quota/quota.proto 338412ee967e14aa1957a47f4a50f2e19e4eca79 
>   src/master/quota.cpp 698150487da71e9dcd907d471067d62ff8a201b4 
>   src/master/quota_handler.cpp aa06cbc83d2c467c2422f1d27bb9507998953c44 
>   src/tests/master_quota_tests.cpp 7d07be355b9323f2a7f27f84020a6ecc7f061140 
>   src/tests/role_tests.cpp 979391306e2427aaa63a5df32704913f79e20e36 
> 
> Diff: https://reviews.apache.org/r/42476/diff/
> 
> 
> Testing
> ---
> 
> make check on Mac OS 10.10.4
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 40851: Windows:[1/2] Updated zookeeper-3.4.5.patch to fix VS2015 build.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40851/#review116447
---



Bad patch!

Reviews applied: [39850, 39851, 39852, 39888, 39889, 40102, 40851]

Failed command: ./support/apply-review.sh -n -r 40851

Error:
 ..
2016-01-26 20:47:03 URL:https://reviews.apache.org/r/40851/diff/raw/ 
[27690/27690] -> "40851.patch" [1]
40851.patch:211: trailing whitespace.
 
40851.patch:286: trailing whitespace.
-lock xadd dword ptr [eax], ecx; 
40851.patch:287: trailing whitespace.
-   lock xadd dword ptr [eax], ebx; 
40851.patch:288: trailing whitespace.
-mov result, ecx; // result = ebx;
40851.patch:290: trailing whitespace.
- return result;
warning: 5 lines add whitespace errors.
3rdparty/zookeeper-3.4.5.patch:202: trailing whitespace.
+ 
3rdparty/zookeeper-3.4.5.patch:277: trailing whitespace.
+-lock xadd dword ptr [eax], ecx; 
3rdparty/zookeeper-3.4.5.patch:278: trailing whitespace.
+-   lock xadd dword ptr [eax], ebx; 
3rdparty/zookeeper-3.4.5.patch:279: trailing whitespace.
+-mov result, ecx; // result = ebx;
3rdparty/zookeeper-3.4.5.patch:281: trailing whitespace.
+- return result;

Full log: https://builds.apache.org/job/mesos-reviewbot/11058/console

- Mesos ReviewBot


On Jan. 26, 2016, 8:18 p.m., M Lawindi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40851/
> ---
> 
> (Updated Jan. 26, 2016, 8:18 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Dario Bazan, Daniel Pravat, Alex 
> Clemmer, and M Lawindi.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows:[1/2] Updated zookeeper-3.4.5.patch to fix VS2015 build.
> 
> 
> Diffs
> -
> 
>   3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da 
> 
> Diff: https://reviews.apache.org/r/40851/diff/
> 
> 
> Testing
> ---
> 
> - Applied patch to original zookeeper 3.4.5
> - Successfully opened 2015 solution in VS2015
> - Cli and Zookeeper build successfully
> 
> 
> Thanks,
> 
> M Lawindi
> 
>

Re: Review Request 42476: Introduced protobuf for set quota requests.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42476/
---

(Updated Jan. 26, 2016, 8:48 p.m.)


Review request for mesos, Bernd Mathiske, Ben Mahler, Joerg Schad, and Joris 
Van Remoortere.


Changes
---

Addressed issues.


Bugs: MESOS-4410
https://issues.apache.org/jira/browse/MESOS-4410


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  docs/quota.md 208bfa06a9fc50843439bab9a041ccb557657b5d 
  include/mesos/quota/quota.proto 338412ee967e14aa1957a47f4a50f2e19e4eca79 
  src/master/quota.hpp 9ac390777946047978a00aa59082e78ce3997441 
  src/master/quota.cpp 698150487da71e9dcd907d471067d62ff8a201b4 
  src/master/quota_handler.cpp aa06cbc83d2c467c2422f1d27bb9507998953c44 
  src/tests/master_quota_tests.cpp 7d07be355b9323f2a7f27f84020a6ecc7f061140 
  src/tests/role_tests.cpp 979391306e2427aaa63a5df32704913f79e20e36 

Diff: https://reviews.apache.org/r/42476/diff/


Testing
---

make check on Mac OS 10.10.4


Thanks,

Alexander Rukletsov

Review Request 42821: Cleaned up namespace-qualified identifiers.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42821/
---

Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/master/quota.cpp 698150487da71e9dcd907d471067d62ff8a201b4 

Diff: https://reviews.apache.org/r/42821/diff/


Testing
---

make check on Mac OS 10.10.4


Thanks,

Alexander Rukletsov

Re: Review Request 42820: Fixed logrotate ContainerLogger on Centos6.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42820/#review116450
---




src/slave/container_loggers/lib_logrotate.hpp (line 104)


hmmm .. why can't we just use `os::access` here to find out if we have 
permissions to read the file?


- Anand Mazumdar


On Jan. 26, 2016, 8:36 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42820/
> ---
> 
> (Updated Jan. 26, 2016, 8:36 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-4515
> https://issues.apache.org/jira/browse/MESOS-4515
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The `logrotate --version` flag is actually a very recent addition (3.9.1).  
> The `--help` flag is more likely to be present on a supported 
> system-with-logrotate, given logrotate's usage of popopt.
> 
> 
> Diffs
> -
> 
>   src/slave/container_loggers/lib_logrotate.hpp 
> 5f79fd8797d9ce0de0b2c12ba2dad61f83a11e02 
>   src/slave/container_loggers/logrotate.hpp 
> fd9c071bbd4c07ad8728c63c42fd63c0bba2573f 
> 
> Diff: https://reviews.apache.org/r/42820/diff/
> 
> 
> Testing
> ---
> 
> make check on OSX & Centos6
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41283/
---

(Updated Jan. 26, 2016, 9:19 p.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
---

Updated Summary/Description back again.


Summary (updated)
-

Introduced an Executor Library based on the new executor HTTP API.


Bugs: MESOS-3550
https://issues.apache.org/jira/browse/MESOS-3550


Repository: mesos


Description (updated)
---

This change introduces the implementation for the executor library. 

This uses the new HTTP Connection interface to ensure calls are properly 
pipelined. 

`connected` -> Callback invoked when a TCP connection is established with the 
agent for the Subscribe call.
`disconnected` -> When the Subscribe TCP connection is interrupted possibly due 
to an agent restart.
`received` -> When the executor receives events from the agent upon subscribing.


Diffs
-

  src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1 
  src/executor/executor.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/41283/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 42786: Exposed the global 'help' process and added getter functions to it.

[Greg Mann]

> On Jan. 26, 2016, 8:34 p.m., Neil Conway wrote:
> > 3rdparty/libprocess/include/process/help.hpp, line 111
> > 
> >
> > Returning a raw pointer here is unfortunate. I wonder if it would be 
> > better to return the map by value (since performance is unlikely to matter 
> > for most callers), or else return a `shared_ptr`.

Also, since I don't imagine we want anyone modifying the helps through this 
pointer, perhaps it should be a `shared_ptr`-to-const.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42786/#review116432
---


On Jan. 26, 2016, 7:40 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42786/
> ---
> 
> (Updated Jan. 26, 2016, 7:40 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Previously, there was no way to extract the help strings from the help
> process once they had been installed into it.  The only way to get at
> them was to visit the http endpoint they were associated with and pull
> it from there.
> 
> This commit adds API calls to the process::Help class to get at these
> strings more easily.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/help.hpp 
> 2e76a6a5b1069abce879374a88cea65036873f1d 
>   3rdparty/libprocess/include/process/process.hpp 
> 1e4126f1082c24debd9d713b490d18f5ed83f0be 
>   3rdparty/libprocess/src/help.cpp 2f718b9e160113518fb4a0260db916cb2242dbae 
> 
> Diff: https://reviews.apache.org/r/42786/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42789: Added support file to autogenerate docs from endpoint help strings.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42789/#review116417
---



Thanks for writing this, Kevin! I'm going to extend it to output the 
configuration flags documentation to disk. For this reason, I wonder if you 
could give the file a more generic name?


support/endpoint-docs.cpp (line 91)


Perhaps use a more descriptive name for this typedef?



support/endpoint-docs.cpp (line 102)


You can omit the `void` parameter here, and below.



support/endpoint-docs.cpp (line 150)


s/standad/standard/



support/endpoint-docs.cpp (line 211)


Could use `foreach ( ... )` here, and below.


- Greg Mann


On Jan. 26, 2016, 7:41 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42789/
> ---
> 
> (Updated Jan. 26, 2016, 7:41 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Greg Mann, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> After building mesos from source, an executable called
> mesos-endpoint-docs will be created in build/src. Invoke this executable
> with the flag --dirname=../docs/endpoints to autogenerate documentation
> for all endpoint strings and install it into the proper location.  In a
> subsequent commit we will add a link to this directory in home.md.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 
>   support/endpoint-docs.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42789/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42684: Multiple Disk: Added persistent volumes tests for `MOUNT` type.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42684/#review116453
---



Patch looks great!

Reviews applied: [42470, 42471, 42472, 42473, 42474, 42503, 42683, 42504, 
42593, 42505, 42506, 42684]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 26, 2016, 8:20 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42684/
> ---
> 
> (Updated Jan. 26, 2016, 8:20 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Michael Park.
> 
> 
> Bugs: MESOS-191
> https://issues.apache.org/jira/browse/MESOS-191
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Multiple Disk: Added persistent volumes tests for `MOUNT` type.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> cbf2bcedd5b4c14107d3b50a74f161aa9395d7d0 
>   src/tests/resources_tests.cpp 54a4fa88bfdcff3c0a7e89cbf3a1674c954b7f23 
> 
> Diff: https://reviews.apache.org/r/42684/diff/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 41818: Handled quota when volumes are bind mounted into the sandbox.

[Artem Harutyunyan]

> On Jan. 26, 2016, 12:26 p.m., Jie Yu wrote:
> > src/tests/disk_quota_tests.cpp, lines 144-147
> > 
> >
> > This should be wrapped with ifdef linux. I fixed it for you.

Thanks Jie, there is a ticket to make sure we handle excludes correctly on Mac 
OS https://issues.apache.org/jira/browse/MESOS-4516.


- Artem


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41818/#review116424
---


On Jan. 26, 2016, 10:48 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41818/
> ---
> 
> (Updated Jan. 26, 2016, 10:48 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Jie Yu.
> 
> 
> Bugs: MESOS-4281
> https://issues.apache.org/jira/browse/MESOS-4281
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Handled quota when volumes are bind mounted into the sandbox.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/posix/disk.hpp 
> 31808c1e8199fbf2cea36c273860fdbf0a2388f8 
>   src/slave/containerizer/mesos/isolators/posix/disk.cpp 
> 248c34adb63907911d89bed5b1519682a852bb2d 
>   src/tests/containerizer/filesystem_isolator_tests.cpp 
> 5bb85034c22caef64054c1629f6fd55d227e48b1 
>   src/tests/disk_quota_tests.cpp 1577cf71c4d1fbad11e2ec939c4ceae2d5b25f97 
> 
> Diff: https://reviews.apache.org/r/41818/diff/
> 
> 
> Testing
> ---
> 
> sudo mesos-tests.sh
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>

Re: Review Request 42711: Included reserved resources in the role sorter for DRF.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42711/
---

(Updated Jan. 26, 2016, 9:56 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Addressed Joris' comments.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
2d01034f43c3653f6233792ee6614fa311249e5c 
  src/master/allocator/mesos/hierarchical.cpp 
fa9939700ff44911b9d149a391677b3eb07577ae 
  src/tests/hierarchical_allocator_tests.cpp 
7d5eed4dd4ad2d23e925d5cac73675752b016086 

Diff: https://reviews.apache.org/r/42711/diff/


Testing
---

`make check`


Thanks,

Michael Park

Re: Review Request 42738: Included reserved resources in the quota role sorter for DRF.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42738/
---

(Updated Jan. 26, 2016, 10:02 p.m.)


Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
2d01034f43c3653f6233792ee6614fa311249e5c 
  src/master/allocator/mesos/hierarchical.cpp 
fa9939700ff44911b9d149a391677b3eb07577ae 

Diff: https://reviews.apache.org/r/42738/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 41283: Introduced an Executor Library based on the new executor HTTP API.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41283/#review116455
---


Fix it, then Ship it!




Looking good. Just some minor things.


src/executor/executor.cpp (lines 353 - 355)


Move this to #364.

How about:

// NOTE: We will be here if either subscribe or non-subscribe connection is 
disconnected. We explicitly
// disconnect both the connections here for simplicity.



src/executor/executor.cpp (line 430)


just do 

```
// Ignore if this timeout is for a stale connection.
if (connections != _connections) {
   return;
}
```

to be consistent with what you did in `disconnected(()`


- Vinod Kone


On Jan. 26, 2016, 9:19 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41283/
> ---
> 
> (Updated Jan. 26, 2016, 9:19 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-3550
> https://issues.apache.org/jira/browse/MESOS-3550
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change introduces the implementation for the executor library. 
>   
> This uses the new HTTP Connection interface to ensure calls are properly 
> pipelined.   
>   
> `connected` -> Callback invoked when a TCP connection is established with the 
> agent for the Subscribe call.
> `disconnected` -> When the Subscribe TCP connection is interrupted possibly 
> due to an agent restart.
> `received` -> When the executor receives events from the agent upon 
> subscribing.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1 
>   src/executor/executor.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41283/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 42810: Added the CgroupInfo protobuf.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42810/
---

(Updated Jan. 26, 2016, 10:05 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4488
https://issues.apache.org/jira/browse/MESOS-4488


Repository: mesos


Description
---

Added the CgroupInfo protobuf. The agent can use this message to reflect any 
cgroup configuration that might have been applied to a container.


Diffs
-

  include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b 
  include/mesos/v1/mesos.proto c3244e87f9351c71312d2eace7a49bcac926fafd 

Diff: https://reviews.apache.org/r/42810/diff/


Testing
---

make


Thanks,

Avinash sridharan

Re: Review Request 42741: Included reserved resources in stage 1 of allocation.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42741/
---

(Updated Jan. 26, 2016, 10:10 p.m.)


Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.cpp 
fa9939700ff44911b9d149a391677b3eb07577ae 

Diff: https://reviews.apache.org/r/42741/diff/


Testing
---


Thanks,

Michael Park

Review Request 42828: Updated ReviewBot to tee build output to a file.

[Vinod Kone]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42828/
---

Review request for mesos and Michael Park.


Bugs: MESOS-1469 and MESOS-4478
https://issues.apache.org/jira/browse/MESOS-1469
https://issues.apache.org/jira/browse/MESOS-4478


Repository: mesos


Description
---

This fixes 2 issues

1) Stream output to the console when build is in progress. 
https://issues.apache.org/jira/browse/MESOS-1469

2) Make sure the full build output (and not just truncated build output) is 
output to the console. This was a bug introduced while fixing 
https://issues.apache.org/jira/browse/MESOS-4478


Diffs
-

  support/verify_reviews.py 251d57ec050b087f13b3f5e0d8f421fe8eb76787 

Diff: https://reviews.apache.org/r/42828/diff/


Testing
---

?  mesos git:(vinod/review_bot_tee_output) 
BUILD_URL=https://builds.apache.org/job/mesos-reviewbot/10980/ 
./support/verify_reviews.py vinod kone 1
git rev-parse HEAD
Checking if review: 41092 needs verification
Latest diff timestamp: 2016-01-26 13:53:35
Verifying review 41092
Dependent review: https://reviews.apache.org/api/review-requests/41090/ 
Dependent review: https://reviews.apache.org/api/review-requests/40951/ 
Applying review 41092
./support/apply-review.sh -n -r 41092
+ : ubuntu:14.04
+ : gcc
+ : --verbose
+++ dirname ./support/docker_build.sh
++ cd ./support/..
++ pwd
+ MESOS_DIRECTORY=/Users/vinodkone/workspace/mesos
+ cd /Users/vinodkone/workspace/mesos
+ DOCKERFILE=Dockerfile
+ rm -f Dockerfile
+ case $OS in
+ append_dockerfile 'FROM ubuntu:14.04'
+ echo FROM ubuntu:14.04
+ append_dockerfile 'RUN rm -rf /var/lib/apt/lists/*'
+ echo RUN rm -rf '/var/lib/apt/lists/*'
+ append_dockerfile 'RUN apt-get update'
+ echo RUN apt-get update
+ append_dockerfile 'RUN apt-get -y install build-essential clang git maven 
autoconf libtool'
+ echo RUN apt-get -y install build-essential clang git maven autoconf libtool
+ append_dockerfile 'RUN apt-get -y install openjdk-7-jdk python-dev 
python-boto libcurl4-nss-dev libsasl2-dev libapr1-dev libsvn-dev libevent-dev 
libev-dev'
+ echo RUN apt-get -y install openjdk-7-jdk python-dev python-boto 
libcurl4-nss-dev libsasl2-dev libapr1-dev libsvn-dev libevent-dev libev-dev
+ append_dockerfile 'RUN adduser --disabled-password --gecos '\'''\'' mesos'
+ echo RUN adduser --disabled-password --gecos ''\'''\''' mesos
+ append_dockerfile 'ENV GTEST_FILTER -FsTest.FileSystemTableRead'
+ echo ENV GTEST_FILTER -FsTest.FileSystemTableRead
+ append_dockerfile 'ENV GTEST_OUTPUT xml:report.xml'
+ echo ENV GTEST_OUTPUT xml:report.xml
+ case $COMPILER in
+ append_dockerfile 'ENV CC gcc'
+ echo ENV CC gcc
+ append_dockerfile 'ENV CXX g++'
+ echo ENV CXX g++
+ append_dockerfile 'WORKDIR mesos'
+ echo WORKDIR mesos
+ append_dockerfile 'COPY . /mesos/'
+ echo COPY . /mesos/
+ append_dockerfile 'RUN chown -R mesos /mesos'
+ echo RUN chown -R mesos /mesos
+ append_dockerfile 'USER mesos'
+ echo USER mesos
+ append_dockerfile 'CMD ./bootstrap && ./configure --verbose && 
DISTCHECK_CONFIGURE_FLAGS="--verbose" GLOG_v=1 MESOS_VERBOSE=1 make -j8 
distcheck'
+ echo CMD ./bootstrap '&&' ./configure --verbose '&&' 
'DISTCHECK_CONFIGURE_FLAGS="--verbose"' GLOG_v=1 MESOS_VERBOSE=1 make -j8 
distcheck
++ date +%s
+ TAG=mesos-1453845969-21946
+ docker build --no-cache=true -t mesos-1453845969-21946 .
./support/docker_build.sh: line 117: docker: command not found
Posting review: Bad patch!

Reviews applied: [40951, 41090, 41092]

Failed command: ['bash', '-c', 'set -o pipefail; export OS=ubuntu:14.04;export 
CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh 2>&1 | 
tee build_41092']

Error:
 ..
+ : ubuntu:14.04
+ : gcc
+ : --verbose
+++ dirname ./support/docker_build.sh
++ cd ./support/..
++ pwd
+ MESOS_DIRECTORY=/Users/vinodkone/workspace/mesos
+ cd /Users/vinodkone/workspace/mesos
+ DOCKERFILE=Dockerfile
+ rm -f Dockerfile
+ case $OS in
+ append_dockerfile 'FROM ubuntu:14.04'
+ echo FROM ubuntu:14.04
+ append_dockerfile 'RUN rm -rf /var/lib/apt/lists/*'
+ echo RUN rm -rf '/var/lib/apt/lists/*'
+ append_dockerfile 'RUN apt-get update'
+ echo RUN apt-get update
+ append_dockerfile 'RUN apt-get -y install build-essential clang git maven 
autoconf libtool'
+ echo RUN apt-get -y install build-essential clang git maven autoconf libtool
+ append_dockerfile 'RUN apt-get -y install openjdk-7-jdk python-dev 
python-boto libcurl4-nss-dev libsasl2-dev libapr1-dev libsvn-dev libevent-dev 
libev-dev'
+ echo RUN apt-get -y install openjdk-7-jdk python-dev python-boto 
libcurl4-nss-dev libsasl2-dev libapr1-dev libsvn-dev libevent-dev libev-dev
+ append_dockerfile 'RUN adduser --disabled-password --gecos '\'''\'' mesos'
+ echo RUN adduser --disabled-password --gecos ''\'''\''' mesos
+ append_dockerfile 'ENV GTEST_FILTER -FsTest.FileSystemTableRead'
+ echo ENV GTEST_FILTER 

Re: Review Request 42711: Included reserved resources in the role sorter for DRF.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42711/#review116459
---


Ship it!




Ship It!

- Joris Van Remoortere


On Jan. 26, 2016, 9:56 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42711/
> ---
> 
> (Updated Jan. 26, 2016, 9:56 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 2d01034f43c3653f6233792ee6614fa311249e5c 
>   src/master/allocator/mesos/hierarchical.cpp 
> fa9939700ff44911b9d149a391677b3eb07577ae 
>   src/tests/hierarchical_allocator_tests.cpp 
> 7d5eed4dd4ad2d23e925d5cac73675752b016086 
> 
> Diff: https://reviews.apache.org/r/42711/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 42738: Included reserved resources in the quota role sorter for DRF.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42738/
---

(Updated Jan. 26, 2016, 10:29 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Addressed Joris' comments.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
2d01034f43c3653f6233792ee6614fa311249e5c 
  src/master/allocator/mesos/hierarchical.cpp 
fa9939700ff44911b9d149a391677b3eb07577ae 

Diff: https://reviews.apache.org/r/42738/diff/


Testing
---


Thanks,

Michael Park

Re: Review Request 42711: Included reserved resources in the role sorter for DRF.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42711/
---

(Updated Jan. 26, 2016, 10:34 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Addressed Guangya's comment.


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
2d01034f43c3653f6233792ee6614fa311249e5c 
  src/master/allocator/mesos/hierarchical.cpp 
fa9939700ff44911b9d149a391677b3eb07577ae 
  src/tests/hierarchical_allocator_tests.cpp 
7d5eed4dd4ad2d23e925d5cac73675752b016086 

Diff: https://reviews.apache.org/r/42711/diff/


Testing
---

`make check`


Thanks,

Michael Park