Hi All,
ShellBinPkg is the remaining binary package in Edk2 repo. We plan to delete
ShellBinPkg from edk2/master, and keep source ShellPkg only in edk2 repo.
Before the deletion, I will update the existing consumers in Edk2 and
Edk2Platforms to use ShellPkg directly.
If you have any concern pl
Hi Laszlo,
Thanks for helping fix it.
Reviewed-by: Bi Dandan
Thanks,
Dandan
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Thursday, February 21, 2019 6:41 PM
> To: edk2-devel@lists.01.org
> Cc: Bi, Dandan ; Wu, Hao A ;
> Wang, Jian
February 20, 2019 9:19 AM
> To: Bi, Dandan
> Cc: Wu, Hao A ; Ni, Ray ; edk2-
> de...@lists.01.org
> Subject: Re: [edk2] [patch 2/2] MdeModulePkg/BmBoot: Report status when
> fail to load/start boot option
>
> Hi Dandan,
>
> On 02/15/19 09:51, Dandan Bi wrote:
> >
> -Original Message-
> From: Zeng, Star
> Sent: Friday, February 15, 2019 5:25 PM
> To: Bi, Dandan ; edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Michael Turner
> ; Max Knutsen
> ; Gao, Liming ; Zeng,
> Star
> Subject: RE: [edk2] [patch V2] MdeModulePkg/ReportS
This patch is also available at
https://github.com/dandanbi/edk2/commit/e5c432b2d5083c0bbadbf773d460a9c22d36b267
Thanks,
Dandan
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Dandan Bi
> Sent: Thursday, February 14, 2019 10:39 AM
> To: ed
Hi Nikita,
I have one comment here, could you help to verify this patch series with VS
tool chain build before commit the patches?
Thanks,
Dandan
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Nikita Leshenko
> Sent: Thursday, January 31
Reviewed-by: Bi Dandan
Thanks,
Dandan
> -Original Message-
> From: Hsueh, Hong-chihX
> Sent: Wednesday, January 30, 2019 9:20 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
> ; Bi, Dandan ; Laszlo Ersek
>
> Subject: [PATCH] MdePkg/Bas
nks,
Dandan
> -Original Message-
> From: Hsueh, Hong-chihX
> Sent: Tuesday, January 29, 2019 2:41 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D ; Gao, Liming
> ; Bi, Dandan ; Laszlo Ersek
>
> Subject: [PATCH] MdePkg/BasePeCoffLib: skip runtime relocation if
>
Reviewed-by: Bi Dandan
Thanks,
Dandan
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ard Biesheuvel
> Sent: Friday, January 25, 2019 4:12 PM
> To: edk2-devel@lists.01.org
> Cc: Bi, Dandan ; Gao, Liming
> S
Reviewed-by: Bi Dandan
Thanks,
Dandan
> -Original Message-
> From: Zeng, Star
> Sent: Friday, January 25, 2019 9:23 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star ; Wang, Jian J ;
> Wu, Hao A ; Ard Biesheuvel
> ; Bi, Dandan
> Subject: [PATCH] MdeModulePkg V
anuary 19, 2019 2:30 AM
> To: edk2-devel-01 ; Bi, Dandan
> ; Gao, Liming
> Cc: Leif Lindholm ; Ard Biesheuvel
> ; Laszlo Ersek ; Kinney,
> Michael D ; xen-devel de...@lists.xenproject.org>
> Subject: Unable to boot Linux with master EDK2
>
> Hi all,
>
> I am t
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Leif Lindholm
> Sent: Tuesday, January 08, 2019 5:51 PM
> To: Laszlo Ersek
> Cc: Ni, Ray ; tr...@konsulko.com; AKASHI Takahiro
> ; Wu, Hao A ; Heinrich
> Schuchardt ; edk2-devel@lists.01.org; Al
Reviewed-by: Bi Dandan
Thanks,
Dandan
> -Original Message-
> From: Wu, Hao A
> Sent: Friday, January 4, 2019 10:42 AM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Bi, Dandan ;
> Wang, Jian J ; Ni, Ray
> Subject: [PATCH] MdeModulePkg/SdMmcPciHcDxe: Fix VS20
Hi Star,
Thank you for your suggestion.
I will send a new patch with your suggestion.
Thanks,
Dandan
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, January 1, 2019 9:17 PM
> To: Bi, Dandan ; edk2-devel@lists.01.org
> Cc: Wu, Hao A ; Vladimir Olovyannikov
>
Hi Liming,
Some minor comments inline.
Thanks,
Dandan
> -Original Message-
> From: Gao, Liming
> Sent: Wednesday, December 5, 2018 11:59 AM
> To: edk2-devel@lists.01.org
> Cc: Bi, Dandan
> Subject: [Patch] ModuleWriteGuide: Add notes to define library instance
> m
Reviewed-by: Bi Dandan
Thanks,
Dandan
> -Original Message-
> From: Gao, Liming
> Sent: Thursday, November 29, 2018 9:18 AM
> To: edk2-devel@lists.01.org
> Cc: Bi, Dandan ; Zeng, Star
> Subject: [Patch] MdeModulePkg: Correct PCD name in MdeModule
Reviewed-by: Bi Dandan
Thanks,
Dandan
> -Original Message-
> From: Gao, Liming
> Sent: Saturday, November 10, 2018 10:16 PM
> To: edk2-devel@lists.01.org
> Cc: Bi, Dandan
> Subject: [Patch] Revert "MdeModulePkg/DisplayEngine: Remove useless
> NULL ptr c
> Sent: Thursday, November 8, 2018 9:56 PM
> To: Bi, Dandan ; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Kinney, Michael D
>
> Subject: RE: [patch] MdePkg: Fix incorrect check for DisplayOnly text format
> in AcpiEx
>
> Reviewed-by: Liming Gao
>
> > -----Original Mes
Reviewed-by: Bi Dandan
Thanks,
Dandan
> -Original Message-
> From: Wang, Jian J
> Sent: Saturday, October 27, 2018 10:13 AM
> To: edk2-devel@lists.01.org
> Cc: Bi, Dandan ; Zeng, Star
> Subject: [PATCH] MdeModulePkg/Core: correct one coding sty
> -Original Message-
> From: Ni, Ruiyu
> Sent: Tuesday, October 9, 2018 10:07 AM
> To: Laszlo Ersek ; Bi, Dandan ;
> edk2-devel@lists.01.org
> Cc: Gao, Liming ; Zeng, Star
> Subject: Re: [edk2] [patch] MdeModulePkg/HiiDB: Fix incorrect structure
> convention for ch
Hi Laszlo,
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Laszlo Ersek
> Sent: Monday, October 08, 2018 7:55 PM
> To: Bi, Dandan ; edk2-devel@lists.01.org
> Cc: Ni, Ruiyu ; Kinney, Michael D
> ; Gao, Liming
> Subjec
Hi Laszlo,
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Monday, October 08, 2018 8:19 PM
> To: Bi, Dandan ; edk2-devel@lists.01.org
> Cc: Zeng, Star ; Gao, Liming
> Subject: Re: [edk2] [patch] MdeModulePkg/HiiDB: Fix incorrect structur
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Wu, Jiaxin
Sent: Monday, October 8, 2018 11:03 AM
To: edk2-devel@lists.01.org
Cc: Carsey, Jaben ; Fu, Siyuan ;
Ye, Ting ; Bi, Dandan ; Wu, Jiaxin
Subject: [Patch 0/2] Correct comments to align with the input parameter
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Wu, Jiaxin
Sent: Monday, October 8, 2018 11:08 AM
To: edk2-devel@lists.01.org
Cc: Fu, Siyuan ; Ye, Ting ; Bi, Dandan
; Wu, Jiaxin
Subject: [Patch] MdeModulePkg/Tcp4Dxe: Remove the trailing white space in one
line.
Cc
Reviewed-by: Dandan Bi
Thanks,
Dandan
> -Original Message-
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Eric Dong
> Sent: Saturday, September 29, 2018 9:38 AM
> To: edk2-devel@lists.01.org
> Cc: Bi, Dandan ; Laszlo Ersek
> S
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Wu, Jiaxin
Sent: Monday, September 17, 2018 11:14 AM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Fu, Siyuan ; Bi, Dandan
; Wu, Jiaxin
Subject: [Patch] MdeModulePkg/Ip4Dxe: Refine the coding style.
Ref: https
...@gmail.com]
Sent: Friday, September 7, 2018 11:57 PM
To: Bi, Dandan
Cc: Laszlo Ersek ; edk2-devel@lists.01.org; af...@apple.com
Subject: Re: [edk2] Performance enabling of Event handler
Hi
Yes it is included in same module (both event handler and function handler),
and I’m not perf_start and
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Wang, Jian J
Sent: Saturday, September 8, 2018 11:24 AM
To: edk2-devel ; edk2-devel@lists.01.org
Cc: Bi, Dandan
Subject: RE: [edk2] [PATCH] UefiCpuPkg/CpuDxe: fix ECC reported issues
Forgot to mention the BZ info:
https
Reviewed-by: Dandan Bi
One minor comment that please remove the additional " Signed-off-by: Zhang,
Chao B ",
which can't pass the PatchCheck script.
Thanks,
Dandan
-Original Message-
From: Zhang, Chao B
Sent: Friday, September 7, 2018 4:50 PM
To: edk2-devel@lists.01.org
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Ni, Ruiyu
Sent: Friday, September 7, 2018 6:13 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan
Subject: [PATCH] UefiCpuPkg/PeiCpuException: Fix coding style issue
Contributed-under: TianoCore Contribution Agreement 1.1
for each module.
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of prabin ca
Sent: Friday, September 7, 2018 10:30 AM
To: Laszlo Ersek
Cc: Bi, Dandan ; edk2-devel@lists.01.org; af...@apple.com
Subject: Re: [edk2] Performance
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Zeng, Star
Sent: Wednesday, September 5, 2018 10:01 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Bi, Dandan ; Gao,
Liming ; Wang, Jian J ; Fu, Siyuan
; Wu, Jiaxin
Subject: [PATCH] MdeModulePkg: Remove trailing white
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Zeng, Star
Sent: Tuesday, September 4, 2018 9:18 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Bi, Dandan ; Gao,
Liming ; Wang, Jian J
Subject: [PATCH] MdeModulePkg PeiCore: Fix VS2012 build failure
fwvol.c(1572
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Ni, Ruiyu
Sent: Monday, September 3, 2018 10:24 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan
Subject: [PATCH] EmulatorPkg/PlatformBmLib: Fix GCC build failure
Some local variables are initialized but never used.
GCC
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Zeng, Star
Sent: Thursday, August 23, 2018 11:36 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Gao, Liming ; Bi,
Dandan ; Kinney, Michael D
Subject: [PATCH V2 2/2] MdeModulePkg: Update SMBIOS PCDs to 3.2.0
REF: https
istent with current comments style.
With this update, Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Zeng, Star
Sent: Thursday, August 23, 2018 11:36 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Gao, Liming ; Bi,
Dandan ; Kinney, Michael D
Subject: [PATCH V2 1/2]
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Ni, Ruiyu
Sent: Monday, August 6, 2018 2:30 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan
Subject: [PATCH] ShellPkg/acpi: Fix XCODE5 X64 build failure
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by
Hi Prabin,
Here is a simple introduction of current performance infrastructure in latest
Edk2 code base.
Hope it can have some help when you enable it.
https://github.com/dandanbi/edk2/wiki/Performance-Infrastructure
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-deve
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng
Sent: Monday, July 30, 2018 5:45 PM
To: edk2-devel@lists.01.org
Cc: Kinney, Michael D ; Bi, Dandan
; Gao, Liming ; Zeng, Star
; Chen, Hesheng
this one.
Sorry for any inconvenience.
Thanks,
Dandan
From: Alexei Fedorov [mailto:alexei.fedo...@arm.com]
Sent: Monday, July 30, 2018 4:28 PM
To: Bi, Dandan ; edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Carsey, Jaben
Subject: Re: [patch 3/4] ShellPkg/UefiShellAcpiViewCommandLib: Fix VS build
fa
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Zhang, Chao B
Sent: Saturday, July 28, 2018 1:35 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan
Subject: [Patch] SecurityPkgDSC: Fix 2 DSC build error
Error is caused by SHA384/SHA512 hash lib change in.
Cc: Bi Dandan
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Zeng, Star
Sent: Thursday, July 26, 2018 6:17 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Yao, Jiewen ; Bi,
Dandan
Subject: [PATCH 1/6] MdeModulePkg CapsuleApp: Fix VS2012 build failure caused
by 5410502
The build
Sure.
I will add the comments before commit it.
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Thursday, July 19, 2018 8:04 PM
To: Bi, Dandan ; edk2-devel@lists.01.org
Cc: Dong, Eric
Subject: Re: [edk2] [patch
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Thomas
Palmer
Sent: Wednesday, July 4, 2018 12:46 AM
To: edk2-devel@lists.01.org
Cc: Dong, Eric ; Zeng, Star
Subject: [edk2] [PATCH 1/1] MdeModulePkg/DisplayE
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng
Sent: Monday, July 2, 2018 5:42 PM
To: edk2-devel@lists.01.org
Cc: Wu, Hao A ; Bi, Dandan ; Zeng,
Star
Subject: [edk2] [PATCH] MdeModulePkg
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng
Sent: Monday, July 2, 2018 4:57 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan ; Gao, Liming ; Zeng,
Star
Subject: [edk2] [PATCH] MdeModulePkg
Reviewed-by: Dandan Bi
Thanks for helping fix it.
Thanks,
Dandan
-Original Message-
From: dann frazier [mailto:da...@debian.org]
Sent: Wednesday, June 27, 2018 6:05 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan ; Gao, Liming ; Ni,
Ruiyu
Subject: [PATCH] ShellPkg/dp: Correct case of
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Ni, Ruiyu
Sent: Monday, June 11, 2018 10:37 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan
Subject: [PATCH] MdeModulePkg/AtaAtapiPassThru: Fix VS2010/VS2012 build failure
The patch doesn't have functionality impact.
Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Alexei
Fedorov
Sent: Tuesday, June 05, 2018 5:13 PM
To: Bi, Dandan ; edk2-devel@lists.01.org
Cc: Carsey, Jaben ; Ni, Ruiyu
Subject: Re: [edk2] [patch 2/2] ShellPkg/UefiShellAcpiViewCommandLib: Fix ECC
issues
Hi
the value may be
non-zero. That's the difference. It may impact the code to parse the table.
Thanks,
Dandan
-Original Message-
From: Zeng, Star
Sent: Friday, May 25, 2018 10:45 AM
To: Bi, Dandan ; Ard Biesheuvel
; Laszlo Ersek
Cc: Dong, Eric ; edk2-devel@lists.01.org; Gao, Liming
will impact the tool to parse the contents.
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ard
Biesheuvel
Sent: Thursday, May 24, 2018 8:54 PM
To: Laszlo Ersek
Cc: Dong, Eric ; edk2-devel@lists.01.org; Gao, Liming
; Bi, Dandan
Reviewed-by: Dandan Bi
And these changes are in SecurityPkg not MdePkg.
Please update the package name in the subject of the patch before commit.
Thanks,
Dandan
-Original Message-
From: Dong, Eric
Sent: Tuesday, May 22, 2018 1:51 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan
Subject
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Dong, Eric
Sent: Tuesday, May 22, 2018 1:51 PM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan
Subject: [Patch 1/2] MdePkg/TcgStorage*.h: Fixed ECC reported issues.
Cc: Dandan Bi
Contributed-under: TianoCore Contribution
be handled in PEI phase(32bit), that's the main reason why
we allocate it below 4G.
Thanks,
Dandan
-Original Message-
From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
Sent: Wednesday, May 2, 2018 12:27 AM
To: Bi, Dandan ; Leif Lindholm
Cc: edk2-devel@lists.01.org; Zeng,
Hi Ray,
Thanks for your suggestion. But we have committed this patch yesterday. :(
I will pay more attention to the commit message in the future work.
Thanks,
Dandan
-Original Message-
From: Ni, Ruiyu
Sent: Thursday, May 10, 2018 11:34 AM
To: Gary Lin ; Bi, Dandan
Cc: edk2-devel
Thanks for your test work.
I have created a V2 patch which make the code logic more clean. Would you mind
to try the V2 patch in your environment?
Thanks,
Dandan
-Original Message-
From: Gary Lin [mailto:g...@suse.com]
Sent: Wednesday, May 9, 2018 10:32 AM
To: Bi, Dandan
Cc: edk2
Yes. We have submitted patch to fix it. Sorry for the inconvenience.
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Gary Lin
Sent: Tuesday, May 8, 2018 5:46 PM
To: Bi, Dandan
Cc: edk2-devel@lists.01.org; Dong, Eric ; Gao, Liming
Thanks for the updating. These changes make sense.
Reviewed-by: Dandan Bi for this patch series.
But the Spec seems not to be clear enough.
When looking into details about the "progress" parameter in EFI HII
Configuration Routing Protocol and EFI_HII_CONFIG_ACCESS_PROTOCOL.
Description of "pr
: Kinney, Michael D ; Bi, Dandan
; edk2-devel@lists.01.org
Cc: Dong, Eric
Subject: Re: [edk2] [patch] UefiCpuPkg/PiSmmCpuDxeSmm: Add "extern" keyword for
"gPatchxxx"
On 04/12/18 18:47, Kinney, Michael D wrote:
> Laszlo,
>
> I think I would rather see the ECC tool fixed
Good suggestion. Thanks Star.
I will cover them in V2 patches.
Thanks,
Dandan
-Original Message-
From: Zeng, Star
Sent: Thursday, April 12, 2018 2:03 PM
To: Bi, Dandan ; Kinney, Michael D
; edk2-devel@lists.01.org
Cc: Dong, Eric ; Gao, Liming ; Zeng,
Star
Subject: RE: [edk2] [patch 0
There is no need to update UEFI spec, just implementation related. It has no
impact to the modules which do not care these two events.
Thanks,
Dandan
-Original Message-
From: Tim Lewis [mailto:tim.le...@insyde.com]
Sent: Thursday, April 12, 2018 11:49 AM
To: Bi, Dandan ; Kinney
if it
make you confused.
I will add them in the commit messages of V2 patches.
Thanks,
Dandan
-Original Message-
From: Bi, Dandan
Sent: Thursday, April 12, 2018 11:17 AM
To: Kinney, Michael D ; edk2-devel@lists.01.org
Cc: Dong, Eric ; Gao, Liming ; Bi,
Dandan
Subject: RE: [edk2] [patc
ifications. Which is not a correct behavior.
Thanks,
Dandan
-Original Message-
From: Kinney, Michael D
Sent: Thursday, April 12, 2018 9:44 AM
To: Bi, Dandan ; edk2-devel@lists.01.org; Kinney, Michael
D
Cc: Dong, Eric ; Gao, Liming
Subject: RE: [edk2] [patch 0/3] MdeModulePkg/UiApp: Sign
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Zeng, Star
Sent: Sunday, April 8, 2018 9:29 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Bi, Dandan ; Yao,
Jiewen ; Kinney, Michael D
Subject: [PATCH] MdeModulePkg/Gcd: Suppress incorrect compiler/analyzer warnings
It
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Liming
Gao
Sent: Friday, March 16, 2018 9:09 AM
To: edk2-devel@lists.01.org
Cc: Kinney, Michael D
Subject: [edk2] [Patch] MdePkg BaseStackCheckLib: Correct sty
.org; Bi, Dandan
Subject: Re: [edk2] [PATCH 1/5] MdePkg/SPI: Change function definitions to
match their descriptions.
Hey Dandan,
Thanks for your reply.
I issued updates for the current headers because I saw activity in
edk2-platforms to implement these incomplete protocols and because I
Hi Marvin,
Thank you very much for your contribution. Could you hold this patch series?
Since current SPI header files follow PI1.6 spec.
For this case, we should submit an ECR to update the PI spec firstly. After the
ECR has been approved by PIWG, then we can send patch to update them.
Since
Thank you star. I will update them before committing the patches.
Thanks,
Dandan
-Original Message-
From: Zeng, Star
Sent: Friday, February 9, 2018 4:31 PM
To: Bi, Dandan ; edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Dong, Eric ; Gao,
Liming ; Laszlo Ersek ; Wei, David
; Zeng, Star
Hi Laszlo,
Thanks for your comments. I will update the commit message.
Regards,
Dandan
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Wednesday, February 7, 2018 4:17 PM
To: Zeng, Star ; Bi, Dandan ;
edk2-devel@lists.01.org
Cc: Ni, Ruiyu
Subject: Re: [patch
Thank you star. I will add comment before commit the patch.
Regards,
Dandan
-Original Message-
From: Zeng, Star
Sent: Wednesday, February 7, 2018 9:45 AM
To: Bi, Dandan ; edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Laszlo Ersek (ler...@redhat.com)
; Zeng, Star
Subject: RE: [patch
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Zhang,
Chao B
Sent: Saturday, February 3, 2018 11:12 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan ; Zhang, Chao B
Subject: [edk2] [PATCH] SecurityPkg: Add
, Star
Sent: Thursday, January 25, 2018 12:59 PM
To: Bi, Dandan ; edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Laszlo Ersek ; Dong,
Eric ; Gao, Liming ; Zeng, Star
Subject: RE: [edk2] [patch 0/3] Remove the useless pref codes
Could we also remove the related definitions in
MdeModulePkg\Include\Guid
patches if I need to reference it.
Thanks,
Dandan
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Wednesday, January 24, 2018 11:45 PM
To: Bi, Dandan ; edk2-devel@lists.01.org
Cc: Dong, Eric ; Gao, Liming
Subject: Re: [patch] UefiCpuPkg/S3Resume: Add more perf enrt
Hi,
(1) If you want the string can only be set with the one in STR_STRING_CHECK,
you can add following codes within the string opcode:
inconsistentif prompt = STRING_TOKEN(STR_INVALID_IQN),
pushthis != stringref(STRING_TOKEN(STR_STRING_CHECK))
endif;
(2) If you want t
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Wang, Jian J
Sent: Thursday, January 11, 2018 9:02 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan ; Dong, Eric ; Laszlo
Ersek
Subject: [PATCH] UefiCpuPkg/MpInitLib: fix 32-bit build error
Cc: Dandan Bi
Cc: Eric Dong
Cc
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Wang, Fan
Sent: Monday, December 25, 2017 10:46 AM
To: edk2-devel@lists.01.org
Cc: Wang, Fan ; Bi, Dandan
Subject: [Patch] MdeModulePkg/NetLib: Refine coding style for API
NetLibDetectMediaWaitTimeout
From: Wang Fan
Cc
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Wang, Jian J
Sent: Monday, December 25, 2017 9:07 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan ; Zeng, Star ; Dong,
Eric
Subject: [PATCH 2/4] MdeModulePkg/Core: Coding style clean-up
Cc: Dandan Bi
Cc: Star Zeng
Cc
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Wang, Jian J
Sent: Monday, December 25, 2017 9:07 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan ; Dong, Eric ; Laszlo
Ersek
Subject: [PATCH 4/4] UefiCpuPkg: Update code to use new structure field names
Due to coding style
M
To: edk2-devel@lists.01.org
Cc: Bi, Dandan ; Dong, Eric ; Laszlo
Ersek
Subject: [PATCH 3/4] UefiCpuPkg/UefiCpuPkg.uni: Add missing string definition
for new PCDs
Cc: Dandan Bi
Cc: Eric Dong
Cc: Laszlo Ersek
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: J
**/
VOID
EFIAPI
AsmWriteTr (
IN UINT16 Selector
);
With this update, Reviewed-by: Dandan Bi
Regards,
Dandan
-Original Message-
From: Wang, Jian J
Sent: Monday, December 25, 2017 9:07 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan ; Zeng, Star ; Dong,
Eric
Subject: [PATCH 1/4] MdePkg
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Zeng, Star
Sent: Tuesday, December 12, 2017 4:16 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Bi, Dandan ; Yao,
Jiewen
Subject: [PATCH] MdeModulePkg PiSmmIpl: Add missing update to the prototype
It is missing to
Hi Pankaj Bansal,
Current SPI header files follow PI 1.6 Spec, if you find any issue in PI spec,
current process is to raise them to PIWG for discussion firstly, then PIWG will
discuss the issue and decide whether update the spec, at last update the code
if needed.
Thanks,
Dandan
-Origi
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Zeng, Star
Sent: Friday, December 1, 2017 9:20 AM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Bi, Dandan ; Yao,
Jiewen
Subject: [PATCH] IntelSiliconPkg: Update MicrocodeUpdate build path in dsc
That was missed in
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jian J
Wang
Sent: Thursday, November 23, 2017 9:19 AM
To: edk2-devel@lists.01.org
Cc: Bi, Dandan ; Dong, Eric ; Zeng,
Star
Subject: [edk2] [PATCH
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Wang, Jian J
Sent: Wednesday, November 8, 2017 10:12 AM
To: edk2-devel@lists.01.org
Cc: Gao, Liming ; Bi, Dandan
Subject: [PATCH v3 3/3] IntelFrameworkModulePkg: Fix misuses of AllocateCopyPool
> v3:
>No u
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Zeng, Star
Sent: Monday, November 6, 2017 8:51 PM
To: edk2-devel@lists.01.org
Cc: Zeng, Star ; Bi, Dandan ; Yao,
Jiewen
Subject: [PATCH] MdeModulePkg VarCheckHiiLib: Fix typo "0x02%x" to be "0x%02x"
Hi Star,
Thanks for your comments.
Yes, you are right. I will update the patch based on your comments.
Regards,
Dandan
-Original Message-
From: Zeng, Star
Sent: Friday, November 3, 2017 2:04 PM
To: Bi, Dandan ; edk2-devel@lists.01.org
Cc: Dong, Eric ; Gao, Liming ; Zeng,
Star
Reviewed-by: Dandan Bi
Thank you,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Marvin
Häuser
Sent: Tuesday, October 31, 2017 8:12 AM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Bi, Dandan ; Kinney,
Michael D ; Gao, Liming
Subject
Reviewed-by: Dandan Bi
-Original Message-
From: Wang, Jian J
Sent: Thursday, October 12, 2017 9:04 AM
To: edk2-devel@lists.01.org
Cc: Laszlo Ersek ; Gao, Liming ; Bi,
Dandan
Subject: [PATCH] IntelFrameworkModulePkg/LegacyBiosDxe: Fix GCC5 build warning
Cc: Laszlo Ersek
Cc: Liming
Reviewed-by: Bi Dandan
Thanks,
Dandan
-Original Message-
From: Chen, Chen A
Sent: Tuesday, October 10, 2017 10:09 AM
To: edk2-devel@lists.01.org
Cc: Chen, Chen A ; Bi, Dandan ;
Zhang, Chao B
Subject: [PATCH] SecurityPkg/SecureBootConfigImpl.c: Fix coding style issue.
Fix coding
_DATALfReadData;
3. You could use patch check tool in BaseTools/Scripts/PatchCheck.py to verify
the format of your updates.
Thanks,
Dandan
-Original Message-
From: Bi, Dandan
Sent: Friday, September 15, 2017 4:22 PM
To: Ni, Ruiyu ; Marvin Häuser ;
edk2-devel@lists.01.org
Cc: K
@lists.01.org
Cc: Kinney, Michael D ; Gao, Liming
; Bi, Dandan
Subject: RE: [PATCH v1] MdePkg: Add definitions for the SPI protocols
introduced in UEFI PI 1.6.
Marvin,
Thank you for your contribution. We will need some time to review the
definitions against PI Spec.
If there is a need to post V2
Hi Laszlo,
When do you plan to push this patch? IA32 build is blocked for this issue now.
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo
Ersek
Sent: Sunday, September 10, 2017 8:13 AM
To: edk2-devel-01
Cc: Ni, Ruiyu ; Don
uestion will be untouched with this call.
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Wim
Vervoorn
Sent: Friday, August 25, 2017 5:08 PM
To: Bi, Dandan ; edk2-devel@lists.01.org
Subject: Re: [edk2] HiiSetToDefaults behavior
Hello Dand
Hi Wim Vervoorn,
Current behavior of HiiSetToDefaults():
1. For Question has the specified type default value, will set the default
value to storage for the Question.
2. For Question without the specified type default, other type default value
can be shared.(such as: standard default doesn't ex
Hi Wim Vervoorn,
Thanks for reporting this issue. It's a bug of current code and your solution
can fix it correctly.
But when the storage is NameValueType, for string opcode, current code also
calculate the string length incorrectly, the length should not include the
trailing terminator and st
When the driver is loaded, LoadImage() installs EFI_HII_PACKAGE_LIST_PROTOCOL on
the image handle if the image contains HII resource.
So you can get the image package list through HiiPackageListProtocol,
And then add the image package list to HII database through NewPackageList API
in Database Pr
Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: Wu, Jiaxin
Sent: Tuesday, August 8, 2017 3:25 PM
To: edk2-devel@lists.01.org
Cc: Ye, Ting ; Bi, Dandan ; Wu, Jiaxin
Subject: [Patch] NetworkPkg/HttpBootDxe: Refine the coding style.
Cc: Ye Ting
Cc: Bi Dandan
Star, thanks for detecting that. Reviewed-by: Dandan Bi
Thanks,
Dandan
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Star Zeng
Sent: Thursday, June 29, 2017 10:45 PM
To: edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Bi, Dandan ; Zeng,
Star
Subject
Yes. I will remove it before checking in the codes. Thanks.
Regards,
Dandan
-Original Message-
From: Zeng, Star
Sent: Monday, June 19, 2017 12:55 PM
To: Bi, Dandan ; edk2-devel@lists.01.org
Cc: Ni, Ruiyu ; Gao, Liming ; Zeng,
Star
Subject: RE: [edk2] [PATCH v2 4/8] MdePkg
1 - 100 of 162 matches
Mail list logo
