> On April 29, 2017, 3:35 a.m., Aravindan Vijayan wrote:
> > Ship It!
>
> Masahiro Tanaka wrote:
> Thank you! Could you commit it?
>
> Aravindan Vijayan wrote:
> Done. Please close the review and the jira.
Thank
iew173621
---
On April 17, 2017, 9:40 a.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57687/#review173540
---
Could anyone review this?
- Masahiro Tanaka
On 4月 17, 2017, 9
iew173361
---
On 4月 20, 2017, 11:59 p.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58575/#review173189
---
Could anyone review this?
- Masahiro Tanaka
On April 20, 2017
-metrics-storm-sink.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/11419//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/11419//console
This message is automatically generated.
Thanks,
Masahiro Tanaka
//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/11023//console
This message is automatically generated.
Thanks,
Masahiro Tanaka
/job/Ambari-trunk-test-patch/11398//console
This message is automatically generated.
Thanks,
Masahiro Tanaka
g/r/57687/#review171728
---
On April 9, 2017, 4:03 p.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
------
On April 9, 2017, 4:03 p.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57687/
> ---
//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/11023//console
This message is automatically generated.
Thanks,
Masahiro Tanaka
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57687/#review171285
-------
On March 16, 2017, 9:55 p.m., Masahiro Tanaka wrote:
>
> --
line97>
> >
> > Does this config need to be deleted from existing clusters? Which stack
> > versions does this affect?
> >
> > If so, you can mark the property as , which will also cause
> > Ambari to delete it during EU/RU
>
> Masahiro Tanak
--------
On 3月 16, 2017, 9:55 p.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57687/
> --
in ambari-server.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/11023//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/11023//console
This message is automatically generated.
Thanks,
Masahiro Tanaka
-patch/10063//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/10063//console
This message is automatically generated.
Thanks,
Masahiro Tanaka
://builds.apache.org/job/Ambari-trunk-test-patch/9963//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/9963//console
This message is automatically generated.
Thanks,
Masahiro Tanaka
sit:
https://reviews.apache.org/r/55369/#review161098
-------
On Jan. 10, 2017, 2:23 p.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55369/
> -
-patch/9963//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/9963//console
This message is automatically generated.
Thanks,
Masahiro Tanaka
iew158128
---
On 12月 6, 2016, 9:06 a.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
---
manually tested
Thanks,
Masahiro Tanaka
generated e-mail. To reply, visit:
https://reviews.apache.org/r/53506/#review155181
---
On Nov. 6, 2016, 10:23 a.m., Masahiro Tanaka wrote:
>
> ---
> This is an automaticall
eviews.apache.org/r/53506/#review155046
---
On Nov. 6, 2016, 10:23 a.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To re
on centos7, replaced HostInfo.py and recheck
host.
Thanks,
Masahiro Tanaka
iew148370
---
On 9月 9, 2016, 10:21 a.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
iew149208
---
On 9月 9, 2016, 10:21 a.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
/Ambari-trunk-test-patch/8623//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/8623//console
This message is automatically generated.
Thanks,
Masahiro Tanaka
patch/8623//console
This message is automatically generated.
Thanks,
Masahiro Tanaka
is because somehow I
created ambari-metrics-grafana-2.1.0.0-0.noarch.rpm (actually it doesn't do
anything), put it in my private repository, and installed it via Ambari.
If ambari-metrics-grafana-2.0.0.0-1.x86_64.rpm is in repository, there is no
problem.
- Masahiro Tanaka
On Aug. 15, 2016, 3:06
> On July 27, 2016, 10:56 p.m., Nate Cole wrote:
> > Ship It!
>
> Masahiro Tanaka wrote:
> Thank you for reviewing. Could you commit it?
>
> Nate Cole wrote:
> Should it be committed to trunk?
>
> Masahiro Tanaka wrote:
> Yes, please. I adde
> On Aug. 5, 2016, 3:02 p.m., Masahiro Tanaka wrote:
> > Thank you for reviewing! Could anyone commit this?
>
> Jayush Luniya wrote:
> Done. Please close review request.
Thnak you!
- Masahiro
---
This is an autom
:
https://builds.apache.org/job/Ambari-trunk-test-patch/7805//console
This message is automatically generated.
Thanks,
Masahiro Tanaka
rver/audit/AuditLoggerDefaultImpl.java
ea6524f
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ambari.json.j2
5f751bf
Diff: https://reviews.apache.org/r/50653/diff/
Testing
---
mvn clean test
Thanks,
Masahiro Tanaka
t
Thanks,
Masahiro Tanaka
t
Thanks,
Masahiro Tanaka
The 'X' stands for the ISO timezone representation.
> >
> > I think grok supports ISO timezone format as well. Can you confirm that
> > grok patterns do not support iso 8061 timezone format?
> >
> > If it doesn't than go ahead and change for X t
The 'X' stands for the ISO timezone representation.
> >
> > I think grok supports ISO timezone format as well. Can you confirm that
> > grok patterns do not support iso 8061 timezone format?
> >
> > If it doesn't than go ahead and change for X t
P_ISO8601:logtime},%{SPACE}%{GREEDYDATA:log_message}
```
- Masahiro
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50653/#review144381
------
a
ea6524f
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ambari.json.j2
5f751bf
Diff: https://reviews.apache.org/r/50653/diff/
Testing
---
mvn clean test
Thanks,
Masahiro Tanaka
output:
https://builds.apache.org/job/Ambari-trunk-test-patch/7913//console
This message is automatically generated.
```
& manual test
Thanks,
Masahiro Tanaka
---
mvn clean test
See screenshot on JIRA
Thanks,
Masahiro Tanaka
/services/TEZ/configuration/tez-site.xml
d719322
Diff: https://reviews.apache.org/r/50171/diff/
Testing
---
mvn clean test
See screenshot on JIRA
Thanks,
Masahiro Tanaka
-defaults.xml
c53dcd7
ambari-server/src/main/resources/common-services/SPARK/1.5.2/configuration/spark-thrift-sparkconf.xml
67120d3
Diff: https://reviews.apache.org/r/50170/diff/
Testing
---
mvn clean test
Thanks,
Masahiro Tanaka
ttps://builds.apache.org/job/Ambari-trunk-test-patch/7768//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/7768//console
This message is automatically generated.
```
Thanks,
Masahiro Tanaka
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49930/#review142255
---
Thanks Juanjo Marron and Aravindan Vijayan!
- Masahiro Tanaka
> On July 12, 2016, 6:51 a.m., Masahiro Tanaka wrote:
> > Should I UpgradeCatalog250.java as we are readying to release Ambari2.4.0?
>
> Jonathan Hurley wrote:
> That depends; there's no Fix Version on this Jira, so I don't know if
> it's only going into t
Thanks,
Masahiro Tanaka
g/r/48309/#review141866
---
On July 12, 2016, 3:33 a.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
that.
- Masahiro
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49935/#review141861
---
On July 12, 2016, 9:19 a.m., Mas
://reviews.apache.org/r/49935/diff/
Testing
---
mvn clean test && manual test
I think Hadoop QA result is unrelated to this patch
Thanks,
Masahiro Tanaka
/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/status.py
fa4e8a4
Diff: https://reviews.apache.org/r/49930/diff/
Testing
---
mvn clean test
Thanks,
Masahiro Tanaka
Ambari2.4.0?
- Masahiro Tanaka
On July 11, 2016, 9:50 p.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
This message is automatically generated.
```
Thanks,
Masahiro Tanaka
Masahiro
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48972/#review141703
---
On July 8, 2016, 8:20 p.m., Masahiro Tanaka wrote:
>
> ---
> This i
atch/7768//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/7768//console
This message is automatically generated.
```
Thanks,
Masahiro Tanaka
-test-patch/7768//console
This message is automatically generated.
```
Thanks,
Masahiro Tanaka
ur json, not dotted names. Match for
> > consistency.
>
> Masahiro Tanaka wrote:
> Thank you for reviewing! I checked other `alerts.json` which uses
> `parameters` attributes, and they use dotted name (see
> [this](https://github.com/apache/ambari/blob/trunk/ambari-server/src/mai
---
On July 8, 2016, 8:20 p.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48972/
> ---
://builds.apache.org/job/Ambari-trunk-test-patch/7427//console
This message is automatically generated.
```
Thanks,
Masahiro Tanaka
tests in ambari-server.
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/7710//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/7710//console
This message is automatically generated.
Thanks,
Masahiro Tanaka
unk-test-patch/7426//console
This message is automatically generated.
```
Core test fails seems unrelated to this patch
Thanks,
Masahiro Tanaka
tch/7426//console
This message is automatically generated.
```
Core test fails seems unrelated to this patch
Thanks,
Masahiro Tanaka
/params_linux.py
Diffs (updated)
-
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
6d304d4
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hadoop-metrics2-hbase.properties-GANGLIA-RS.j2
dcec3d4
Diff: https://reviews.apache.org/r/48628/diff/
Testing
---
mvn clean test && manual test
Thanks,
Masahiro Tanaka
esponse? In this case, ZK will response with `imok` ...
> > we should probably check that value if it's OK.
>
> Masahiro Tanaka wrote:
> yes, but if the code checks the response, I don't know how to write test
> codes.
>
> Jonathan Hurley wrote:
> You can mock
esponse? In this case, ZK will response with `imok` ...
> > we should probably check that value if it's OK.
yes, but if the code checks the response, I don't know how to write test codes.
On July 4, 2016, 10:58 p.m., Masahiro Tanaka wrote:
> > What about existing clusters? We
> On June 25, 2016, 10:29 p.m., Nate Cole wrote:
> > Latest patch still seems like forced solution. Why not just allow the
> > alert definition to provide "data" attribute (or whatever) in json that
> > port_alert can use?
>
> Masahiro Tanaka wrote:
&
results:
https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console
This message is automatically generated.
```
Thanks,
Masahiro Tanaka
s.
- Masahiro
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48628/#review139719
---
On June 13, 2016, 10:24 a.m., Masahi
(snip)
```
and update some other related codes.Thanks for suggestion.
- Masahiro
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48972/#review139466
---
On June 25, 2016, 1:54 p.m., Masahiro Tanaka wr
to follw the idea.
- Masahiro
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48972/#review139457
---
On June 25, 2016, 1
de specific workarounds into the alerts framework. It's
> > not maintainable.
>
> Masahiro Tanaka wrote:
> Thank you for reviewing Jonathan! I'll update the patch to respond to
> your comment.
I adde a new property `port_alert_socket_commands` in `ambari-agent.ini` to
specif
audit warnings.
+1 core tests. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/Ambari-trunk-test-patch/7427//testReport/
Console output:
https://builds.apache.org/job/Ambari-trunk-test-patch/7427//console
This message is automatically generated.
```
Thanks,
Masahiro
ps://reviews.apache.org/r/48972/#review138843
---
On 6月 20, 2016, 10:29 p.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail.
iew138187
---
On June 17, 2016, 12:18 a.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
,
Masahiro Tanaka
is patch
Thanks,
Masahiro Tanaka
iew138067
---
On June 16, 2016, 3:55 a.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
e.
Diffs
-
ambari-common/src/main/python/resource_management/libraries/functions/get_user_call_output.py
016161c
Diff: https://reviews.apache.org/r/48829/diff/
Testing
---
mvn clean test && manual test
Thanks,
Masahiro Tanaka
> On June 13, 2016, 1:53 p.m., Andrew Onischuk wrote:
> > Ship It!
>
> Masahiro Tanaka wrote:
> Thank you!
Could you commit it?
- Masahiro
---
This is an automatically generated e-mail. To reply, visit:
https://
it:
https://reviews.apache.org/r/48607/#review137783
---
On 6月 16, 2016, 3:55 a.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:/
iew137073
---
On June 9, 2016, 11:49 p.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
we remove the check for firewalld?
>
> Masahiro Tanaka wrote:
> Thank you for reviewing.
> Acutually I didn't remove the check for firewalld. `systemctl is-active`
> can take multiple arguments.
> This is a sample output on CentOS7.2
>
> ```
> # system
we remove the check for firewalld?
>
> Masahiro Tanaka wrote:
> Thank you for reviewing.
> Acutually I didn't remove the check for firewalld. `systemctl is-active`
> can take multiple arguments.
> This is a sample output on CentOS7.2
>
> ```
> # system
we remove the check for firewalld?
>
> Masahiro Tanaka wrote:
> Thank you for reviewing.
> Acutually I didn't remove the check for firewalld. `systemctl is-active`
> can take multiple arguments.
> This is a sample output on CentOS7.2
>
> ```
> # system
temctl is-active firewalld
active
```
- Masahiro
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48309/#review137283
---
On June 7, 2016,
ambari_jinja2.exceptions.UndefinedError: 'metric_collector_hosts' is undefined
```
We should define metric_collector_hosts in
ambari/ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
Diffs
-
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
05bad1c
Diff: https://reviews.apache.org/r/48628/diff/
Testing
---
mvn clean test && manual test
Thanks,
Masahiro Tanaka
6484285
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-ssl-server.xml
6f9c6dc
Diff: https://reviews.apache.org/r/48607/diff/
Testing
---
mvn clean test
Thanks,
Masahiro Tanaka
resource_management.libraries.functions.format import
format
Diffs
-
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
a4efd72
Diff: https://reviews.apache.org/r/48523/diff/
Testing
---
mvn clean test && manual test
Thanks,
Masahiro Tanaka
/site/apt/index.apt 7a4245b
Diff: https://reviews.apache.org/r/48396/diff/
Testing
---
This is a document fix.
Thanks,
Masahiro Tanaka
test
Thanks,
Masahiro Tanaka
.
- Masahiro Tanaka
On 5月 29, 2016, 2:55 a.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
Diffs
-
ambari-agent/src/main/python/ambari_agent/security.py 779b85c
Diff: https://reviews.apache.org/r/47705/diff/
Testing
---
mvn -fae clean install
Thanks,
Masahiro Tanaka
/
Testing
---
mvn clean test
Thanks,
Masahiro Tanaka
> On 4月 21, 2016, 12:25 a.m., Masahiro Tanaka wrote:
> > Thanks for the review Nate and Andrew!
> > Could you commit this?
>
> Andrew Onischuk wrote:
> before we can commit we need an apache jira for this change, and +1 from
> Hadoop QA.
>
> Do yo
> On 4月 21, 2016, 12:25 a.m., Masahiro Tanaka wrote:
> > Thanks for the review Nate and Andrew!
> > Could you commit this?
>
> Andrew Onischuk wrote:
> before we can commit we need an apache jira for this change, and +1 from
> Hadoop QA.
>
> Do yo
this?
- Masahiro Tanaka
On 4月 16, 2016, 7:02 p.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
, visit:
https://reviews.apache.org/r/45998/#review129732
---
On 4月 16, 2016, 7:02 p.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically gener
iew129706
---
On April 19, 2016, 11:52 p.m., Masahiro Tanaka wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45998/#review129700
---
Could anyone review this?
- Masahiro Tanaka
On 4月 16, 2016, 7
IVE/test_hive_service_check.py
6c4dc00
Diff: https://reviews.apache.org/r/45998/diff/
Testing
---
mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0
Thanks,
Masahiro Tanaka
1 - 100 of 101 matches
Mail list logo
