[Impala-ASF-CR] IMPALA-5695: restart first impalad() does not start impalad

2018-03-13 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9619 ) Change subject: IMPALA-5695: restart_first_impalad() does not start impalad .. Patch Set 1: If the .restart() method is broken, shouldn't

[Impala-ASF-CR] [DOCS] Changed to --use local tz for unix timestamp conversions

2018-03-13 Thread Alex Rodoni (Code Review)
Hello John Russell, Tim Armstrong, Anonymous Coward #381, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9620 to look at the new patch set (#3). Change subject: [DOCS] Changed to --use_local_tz_for_unix_timestamp_conversions

[Impala-ASF-CR] IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS

2018-03-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9564 ) Change subject: IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS .. IMPALA-6619: Incorrect partitions in RECOVER

[Impala-ASF-CR] IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS

2018-03-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9564 ) Change subject: IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS .. Patch Set 5: Verified+1 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-6479: Update DESCRIBE to respect column privileges

2018-03-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9276 ) Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges .. IMPALA-6479: Update DESCRIBE to respect col

[Impala-ASF-CR] IMPALA-6479: Update DESCRIBE to respect column privileges

2018-03-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9276 ) Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges .. Patch Set 5: Verified+1 -- To view, visit http://

[Impala-ASF-CR] [DOCS] Changed to --use local tz for unix timestamp conversions

2018-03-13 Thread Alex Rodoni (Code Review)
Hello John Russell, Tim Armstrong, Anonymous Coward #381, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9620 to look at the new patch set (#2). Change subject: [DOCS] Changed to --use_local_tz_for_unix_timestamp_conversions

[Impala-ASF-CR] [DOCS] Changed to --use local tz for unix timestamp conversions

2018-03-13 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9620 Change subject: [DOCS] Changed to --use_local_tz_for_unix_timestamp_conversions .. [DOCS] Changed to --use_local_tz_for_unix_timestamp_conv

[Impala-ASF-CR] IMPALA-6389: Make '\0' delimited text files work

2018-03-13 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9525 ) Change subject: IMPALA-6389: Make '\0' delimited text files work .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/9525/2/b

[Impala-ASF-CR] IMPALA-5695: restart first impalad() does not start impalad

2018-03-13 Thread anujphadke (Code Review)
anujphadke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9619 Change subject: IMPALA-5695: restart_first_impalad() does not start impalad .. IMPALA-5695: restart_first_impalad() does not start impalad

[Impala-ASF-CR] IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

2018-03-13 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8936 ) Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners .. Patch Set 12: (2 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-6654: [DOCS] Updated the Kudu/Sentry/Impala limitations

2018-03-13 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9618 ) Change subject: IMPALA-6654: [DOCS] Updated the Kudu/Sentry/Impala limitations .. IMPALA-6654: [DOCS] Updated the Kudu/Sentry/Impala limitat

[Impala-ASF-CR] IMPALA-6654: [DOCS] Updated the Kudu/Sentry/Impala limitations

2018-03-13 Thread Alex Rodoni (Code Review)
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9618 Change subject: IMPALA-6654: [DOCS] Updated the Kudu/Sentry/Impala limitations .. IMPALA-6654: [DOCS] Updated the Kudu/Sentry/Impala limita

[Impala-ASF-CR] IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

2018-03-13 Thread Pranay Singh (Code Review)
Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/8936 ) Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners .. Patch Set 12: > Uploaded patch set 12. Tim p

[Impala-ASF-CR] DRAFT IMPALA-5973: Provide query plan in JSON format.

2018-03-13 Thread Pranay Singh (Code Review)
Pranay Singh has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9614 Change subject: DRAFT IMPALA-5973: Provide query plan in JSON format. .. DRAFT IMPALA-5973: Provide query plan in JSON format. This is

[Impala-ASF-CR] IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

2018-03-13 Thread Pranay Singh (Code Review)
Hello anujphadke, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8936 to look at the new patch set (#12). Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

[Impala-ASF-CR] DRAFT IMPALA-5185: Skip pages based on Parquet::Statistics

2018-03-13 Thread Lars Volker (Code Review)
Lars Volker has restored this change. ( http://gerrit.cloudera.org:8080/7354 ) Change subject: DRAFT IMPALA-5185: Skip pages based on Parquet::Statistics .. Restored We'll want to discuss this as part of implementing page index

[Impala-ASF-CR] KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with SSL write()

2018-03-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9606 ) Change subject: KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with SSL_write() .. KUDU-2334: Fix OutboundT

[Impala-ASF-CR] KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with SSL write()

2018-03-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9606 ) Change subject: KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with SSL_write() .. Patch Set 1: Verified+1 -- To

[Impala-ASF-CR] IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries

2018-03-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9005 ) Change subject: IMPALA-6314: Add run time scalar subquery check for uncorrelated subqueries .. Patch Set 13: (4 comments) Backend cha

[Impala-ASF-CR] IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS

2018-03-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9564 ) Change subject: IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS .. Patch Set 5: Build started: https://jenkins.impala.i

[Impala-ASF-CR] IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS

2018-03-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9564 ) Change subject: IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS .. Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-03-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 18: Verified+1 -- To view, visit http://

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-03-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. IMPALA-5315: Cast to timestamp fails for YYY

[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.

2018-03-13 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9590 ) Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. Patch Set 4: Code-Review+

[Impala-ASF-CR] IMPALA-6479: Update DESCRIBE to respect column privileges

2018-03-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9276 ) Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges .. Patch Set 5: Build started: https://jenkins.impala

[Impala-ASF-CR] IMPALA-6479: Update DESCRIBE to respect column privileges

2018-03-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9276 ) Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-13 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 1: > I don't think we have any targeted perf tests for this at the > momen

[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.

2018-03-13 Thread Zoram Thanga (Code Review)
Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/9590 ) Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .. Patch Set 3: (1 comment) Thanks f

[Impala-ASF-CR] IMPALA-6498: test query profile thrift timestamps causes following tests to fail.

2018-03-13 Thread Zoram Thanga (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9590 to look at the new patch set (#4). Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. .

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 1: I don't think we have any targeted perf tests for this at the moment

[Impala-ASF-CR] IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS

2018-03-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/9564 ) Change subject: IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS .. IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS ALTER T

[Impala-ASF-CR] IMPALA-6479: Update DESCRIBE to respect column privileges

2018-03-13 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9276 ) Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges .. Patch Set 4: (2 comments) Updated comments. http://gerrit.

[Impala-ASF-CR] IMPALA-6479: Update DESCRIBE to respect column privileges

2018-03-13 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/9276 ) Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges .. IMPALA-6479: Update DESCRIBE to respect column privileges Modi

[Impala-ASF-CR] IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS

2018-03-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9564 ) Change subject: IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/9

[Impala-ASF-CR] IMPALA-6479: Update DESCRIBE to respect column privileges

2018-03-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9276 ) Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges .. Patch Set 4: (2 comments) lgtm after these final comments ht

[Impala-ASF-CR] IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

2018-03-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8936 ) Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners .. Patch Set 11: I also tried running exhaustiv

[Impala-ASF-CR] IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS

2018-03-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/9564 ) Change subject: IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS .. IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS ALTER T

[Impala-ASF-CR] IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS

2018-03-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9564 ) Change subject: IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS .. Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloud

[Impala-ASF-CR] IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

2018-03-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8936 ) Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners .. Patch Set 11: (12 comments) http://gerrit.c

[Impala-ASF-CR] IMPALA-6635: Add DECIMAL type to Kudu predicates

2018-03-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9578 ) Change subject: IMPALA-6635: Add DECIMAL type to Kudu predicates .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-6635: Add DECIMAL type to Kudu predicates

2018-03-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9578 ) Change subject: IMPALA-6635: Add DECIMAL type to Kudu predicates .. IMPALA-6635: Add DECIMAL type to Kudu predicates Th

[Impala-ASF-CR] IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS

2018-03-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/9564 ) Change subject: IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS .. IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS ALTER T

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866: Improve error reporting for scratch write errors .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-3916: [DOCS] Reserved keywords updated for Impala 3.0

2018-03-13 Thread Alex Rodoni (Code Review)
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9540 ) Change subject: IMPALA-3916: [DOCS] Reserved keywords updated for Impala 3.0 .. Patch Set 5: The current and future reserved words are no

[Impala-ASF-CR] IMPALA-3916: [DOCS] Reserved keywords updated for Impala 3.0

2018-03-13 Thread Alex Rodoni (Code Review)
Hello Greg Rahn, Tianyi Wang, John Russell, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9540 to look at the new patch set (#5). Change subject: IMPALA-3916: [DOCS] Reserved keywords updated for Impala 3.0 ..

[Impala-ASF-CR] :IMPALA-3916: [DOCS] Reserved keywords updated for Impala 3.0

2018-03-13 Thread Alex Rodoni (Code Review)
Hello Greg Rahn, Tianyi Wang, John Russell, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9540 to look at the new patch set (#4). Change subject: :IMPALA-3916: [DOCS] Reserved keywords updated for Impala 3.0 .

[Impala-ASF-CR] IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS

2018-03-13 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9564 ) Change subject: IMPALA-6619: Incorrect partitions in RECOVER PARTITIONS .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] IMPALA-6643: Add REFRESH METADATA fine-grained privilege

2018-03-13 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9589 ) Change subject: IMPALA-6643: Add REFRESH METADATA fine-grained privilege .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-6479: Update DESCRIBE to respect column privileges

2018-03-13 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9276 ) Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges .. Patch Set 1: (1 comment) Removed code for view. http://ger

[Impala-ASF-CR] IMPALA-6479: Update DESCRIBE to respect column privileges

2018-03-13 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/9276 ) Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges .. IMPALA-6479: Update DESCRIBE to respect column privileges Modi

[Impala-ASF-CR] IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

2018-03-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9403 ) Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner .. Patch Set 6: (4 comments) Only very min

[Impala-ASF-CR] IMPALA-6643: Add REFRESH METADATA fine-grained privilege

2018-03-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/9589 ) Change subject: IMPALA-6643: Add REFRESH METADATA fine-grained privilege .. IMPALA-6643: Add REFRESH METADATA fine-grained privilege With

[Impala-ASF-CR] KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with SSL write()

2018-03-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9606 ) Change subject: KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with SSL_write() .. Patch Set 1: Build started: htt

[Impala-ASF-CR] IMPALA-6479: Update DESCRIBE to respect column privileges

2018-03-13 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9276 ) Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges .. Patch Set 2: (7 comments) Fixed. http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-6479: Update DESCRIBE to respect column privileges

2018-03-13 Thread Adam Holley (Code Review)
Adam Holley has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/9276 ) Change subject: IMPALA-6479: Update DESCRIBE to respect column privileges .. IMPALA-6479: Update DESCRIBE to respect column privileges Modi

[Impala-ASF-CR] IMPALA-6643: Add REFRESH METADATA fine-grained privilege

2018-03-13 Thread Adam Holley (Code Review)
Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9589 ) Change subject: IMPALA-6643: Add REFRESH METADATA fine-grained privilege .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-03-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 18: Build started: https://jenkins.impala

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2018-03-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/7009 ) Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 18: Code-Review+2 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3

2018-03-13 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9300 ) Change subject: IMPALA-5690: Part 2: Upgrade thrift to 0.9.3-p3 .. Patch Set 8: (2 comments) Apologies for the slow review. http://ge

[Impala-ASF-CR] KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with SSL write()

2018-03-13 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9606 ) Change subject: KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with SSL_write() .. Patch Set 1: Code-Review+2 -- To view,

[Impala-ASF-CR] KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with SSL write()

2018-03-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9606 ) Change subject: KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with SSL_write() .. Patch Set 1: Clean cherry-pick. Did some b

[Impala-ASF-CR] KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with SSL write()

2018-03-13 Thread Michael Ho (Code Review)
Hello Sailesh Mukil, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/9606 to review the following change. Change subject: KUDU-2334: Fix OutboundTransfer::TransferStarted() to work with SSL_write() ...

[Impala-ASF-CR] IMPALA-6643: Add REFRESH METADATA fine-grained privilege

2018-03-13 Thread Fredy Wijaya (Code Review)
Fredy Wijaya has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/9589 ) Change subject: IMPALA-6643: Add REFRESH METADATA fine-grained privilege .. IMPALA-6643: Add REFRESH METADATA fine-grained privilege With

[Impala-ASF-CR] IMPALA-5980: Upgrade to LLVM 5.0.1

2018-03-13 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9584 ) Change subject: IMPALA-5980: Upgrade to LLVM 5.0.1 .. Patch Set 1: I don't think looking at cumulative time is quite sufficient unless we h

[Impala-ASF-CR] IMPALA-6635: Add DECIMAL type to Kudu predicates

2018-03-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9578 ) Change subject: IMPALA-6635: Add DECIMAL type to Kudu predicates .. Patch Set 3: Build started: https://jenkins.impala.io/job/g

[Impala-ASF-CR] IMPALA-6635: Add DECIMAL type to Kudu predicates

2018-03-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9578 ) Change subject: IMPALA-6635: Add DECIMAL type to Kudu predicates .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-6635: Add DECIMAL type to Kudu predicates

2018-03-13 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9578 ) Change subject: IMPALA-6635: Add DECIMAL type to Kudu predicates .. Patch Set 2: I ran the tests on my own instance this morning and it p

[Impala-ASF-CR] Consistently use Java 1.7 compiler.

2018-03-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9600 ) Change subject: Consistently use Java 1.7 compiler. .. Patch Set 1: Code-Review+1 (1 comment) I git grep'd myself and didn't see any o

[Impala-ASF-CR] Consistently use Java 1.7 compiler.

2018-03-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9600 ) Change subject: Consistently use Java 1.7 compiler. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/9600 T

[Impala-ASF-CR] Consistently use Java 1.7 compiler.

2018-03-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9600 Change subject: Consistently use Java 1.7 compiler. .. Consistently use Java 1.7 compiler. We use Java 1.7 in fe/pom.xml, where most o

[Impala-ASF-CR] Consistently use Java 1.7 compiler.

2018-03-13 Thread Philip Zeyliger (Code Review)
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9600 ) Change subject: Consistently use Java 1.7 compiler. .. Patch Set 1: https://jenkins.impala.io/job/gerrit-verify-dryrun-external/93/ w

[Impala-ASF-CR] IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

2018-03-13 Thread Pranay Singh (Code Review)
Hello anujphadke, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8936 to look at the new patch set (#11). Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

[Impala-ASF-CR] IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners

2018-03-13 Thread Pranay Singh (Code Review)
Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/8936 ) Change subject: IMPALA-3833: Fix invalid data handling in Sequence and RCFile scanners .. Patch Set 10: (1 comment) http://gerrit.clou

[Impala-ASF-CR] IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

2018-03-13 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9403 ) Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner .. Patch Set 4: (1 comment) http://gerri

[Impala-ASF-CR] IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

2018-03-13 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9403 ) Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner .. Patch Set 6: (7 comments) http://gerr

[Impala-ASF-CR] IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

2018-03-13 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Gabor Kaszab, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9403 to look at the new patch set (#6). Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner ..

[Impala-ASF-CR] IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

2018-03-13 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Gabor Kaszab, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9403 to look at the new patch set (#5). Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner ..

[Impala-ASF-CR] IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner

2018-03-13 Thread Csaba Ringhofer (Code Review)
Hello Lars Volker, Gabor Kaszab, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9403 to look at the new patch set (#4). Change subject: IMPALA-6324: Support reading RLE-encoded boolean values in Parquet scanner ..

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-13 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#11). Change subject: IMPALA-3866: Improve error reporting for scratch write errors

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-13 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 ) Change subject: IMPALA-3866: Improve error reporting for scratch write errors .. Patch Set 9: (6 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-3866: Improve error reporting for scratch write errors

2018-03-13 Thread Gabor Kaszab (Code Review)
Hello Attila Jeges, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/9420 to look at the new patch set (#9). Change subject: IMPALA-3866: Improve error reporting for scratch write errors .

[Impala-ASF-CR] IMPALA-6589: remove invalid DCHECK in parquet reader

2018-03-13 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/9556 ) Change subject: IMPALA-6589: remove invalid DCHECK in parquet reader .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.c