Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3208: max_row_size option
..
Patch Set 10:
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-3208: max_row_size option
..
Patch Set 10:
(1 comment)
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and
compression codec
..
Patch Set 7: Verified-1
Build failed:
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5809: Relax max_minidumps in breakpad test
..
IMPALA-5809: Relax max_minidumps in breakpad test
The change to address IMPALA-5769 added
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5809: Relax max_minidumps in breakpad test
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7716
To unsubscribe,
Alex Behm has posted comments on this change.
Change subject: MPALA-5776: Write partial tuple to the correct mempool
..
Patch Set 5: Code-Review+2
(1 comment)
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4833: Compute precise per-host reservation size, pt2
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7681
To unsubscribe,
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements
..
Patch Set 5: Code-Review+2
(4 comments)
Code looks fine but I think those (pre-existing) comments could
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5677: limit clean page memory consumption
..
IMPALA-5677: limit clean page memory consumption
Adds the following flag:
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5677: limit clean page memory consumption
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7653
To unsubscribe,
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5452: Rewrite test case to avoid 'pos'.
..
IMPALA-5452: Rewrite test case to avoid 'pos'.
The original test case accessed the 'pos'
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5452: Rewrite test case to avoid 'pos'.
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7708
To unsubscribe, visit
Taras Bobrovytsky has posted comments on this change.
Change subject: MPALA-5776: Write partial tuple to the correct mempool
..
Patch Set 5:
(1 comment)
Alex Behm has posted comments on this change.
Change subject: IMPALA-5531: Fix correctness issue in correlated aggregate
subqueries
..
Patch Set 1:
(4 comments)
Joe McDonnell has uploaded a new patch set (#2).
Change subject: IMPALA-5352: Age out unused file handles from the cache
..
IMPALA-5352: Age out unused file handles from the cache
Currently, a file handle in the file handle
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and
compression codec
..
Patch Set 7:
Build started:
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and
compression codec
..
Patch Set 7: Code-Review+2
--
To view, visit
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5809: Relax max_minidumps in breakpad test
..
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1093/
--
To view,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5809: Relax max_minidumps in breakpad test
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7716
To unsubscribe, visit
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
..
Patch Set 13: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1090/
--
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5602: Fix query optimization for kudu and datasource
tables
..
Patch Set 5: Code-Review+1
(1 comment)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5677: limit clean page memory consumption
..
Patch Set 7: Code-Review+2
A different test that is only built under ASAN failed.
--
To view, visit
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5677: limit clean page memory consumption
..
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1092/
--
To view,
Hello Impala Public Jenkins, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7653
to look at the new patch set (#7).
Change subject: IMPALA-5677: limit clean page memory consumption
Hello Matthew Jacobs, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7560
to look at the new patch set (#5).
Change subject: IMPALA-5602: Fix query optimization for kudu and datasource
tables
Bikramjeet Vig has posted comments on this change.
Change subject: IMPALA-5602: Fix query optimization for kudu and datasource
tables
..
Patch Set 3:
(13 comments)
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5677: limit clean page memory consumption
..
Patch Set 6: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1089/
--
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
..
Patch Set 1:
(4 comments)
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7716
to look at the new patch set (#3).
Change subject: IMPALA-5809: Relax max_minidumps in breakpad test
..
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5809: Relax max_minidumps in breakpad test
..
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7716/2//COMMIT_MSG
Commit
Lars Volker has uploaded a new patch set (#2).
Change subject: IMPALA-5809: Relax max_minidumps in breakpad test
..
IMPALA-5809: Relax max_minidumps in breakpad test
The change to address IMPALA-5769 added periodic cleaning for
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
..
Patch Set 2:
That's deliberate - preserve the last seen set of states. I could change
something to
Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7681
to look at the new patch set (#2).
Change subject: IMPALA-4833: Compute precise per-host reservation size, pt2
..
Lars Volker has posted comments on this change.
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
..
Patch Set 2:
> Presumably the query was a DDL statement, so there was no
> coordinator. Thanks for the
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-4833: Compute precise per-host reservation size, pt2
..
Patch Set 1:
> This looks good to me, but let's still discuss.
I made some notes from a
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
..
IMPALA-5811: Add 'backends' tab to query details pages
Add a 'backends' tab to query details pages
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
..
Patch Set 1:
Presumably the query was a DDL statement, so there was no coordinator. Thanks
for the
Impala Public Jenkins has submitted this change and it was merged.
Change subject: Propagate HAVE_PIPE2 compile time value to files that use it
..
Propagate HAVE_PIPE2 compile time value to files that use it
The HAVE_PIPE2 is
Impala Public Jenkins has posted comments on this change.
Change subject: Propagate HAVE_PIPE2 compile time value to files that use it
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7705
To
Matthew Jacobs has abandoned this change.
Change subject: IMPALA-5810: reduce minimum non-reservation memory
..
Abandoned
absorbed by https://gerrit.cloudera.org/#/c/7678/
--
To view, visit
Bharath Vissapragada has posted comments on this change.
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
..
Patch Set 1:
Great supportability change. Mind adding a screenshot of the newly added tab?
--
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5452: Rewrite test case to avoid 'pos'.
..
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1091/
--
To view,
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5644: Reject queries if min reservation is too large
..
Patch Set 4:
(2 comments)
Bikramjeet Vig has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7714
Change subject: IMPALA-5788: Fix agg node crash when grouping by
nondeterministic exprs
..
IMPALA-5788: Fix agg node crash when
Lars Volker has abandoned this change.
Change subject: Python profile decoding tools
..
Abandoned
Wrong change
--
To view, visit http://gerrit.cloudera.org:8080/7715
To unsubscribe, visit
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7716
Change subject: IMPALA-5809: Relax max_minidumps in breakpad test
..
IMPALA-5809: Relax max_minidumps in breakpad test
The change to
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7715
Change subject: Python profile decoding tools
..
Python profile decoding tools
Change-Id: I48d4d82649857f648344bb94e42d2f5d51383606
---
A
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5644: Reject queries if min reservation is too large
..
Patch Set 4:
(8 comments)
Pranay Singh has posted comments on this change.
Change subject: IMPALA-5108:idle_session_timeout kicks in later than expected
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7712/1//COMMIT_MSG
Commit Message:
Lars Volker has posted comments on this change.
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
..
Patch Set 1:
I tried this on my local machine while a query was running and hit a segfault
in
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5810: reduce minimum non-reservation memory
..
Patch Set 1:
works for me
--
To view, visit http://gerrit.cloudera.org:8080/7710
To unsubscribe, visit
Pranay Singh has uploaded a new patch set (#2).
Change subject: IMPALA-5108:idle_session_timeout kicks in later than expected
..
IMPALA-5108:idle_session_timeout kicks in later than expected
Fix: The issue was caused because
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4786: Clean up how ImpalaServers are created
..
Patch Set 1:
(1 comment)
Pranay Singh has uploaded a new patch set (#2).
Change subject: IMPALA-5108:idle_session_timeout kicks in later than expected
..
IMPALA-5108:idle_session_timeout kicks in later than expected
Fix: The issue was caused because
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-4786: Clean up how ImpalaServers are created
..
IMPALA-4786: Clean up how ImpalaServers are created
ImpalaServer had to be created via an awkward
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5810: reduce minimum non-reservation memory
..
Patch Set 1: Code-Review+1
Since I'm touching this code as well in https://gerrit.cloudera.org/#/c/7678/
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5108:idle_session_timeout kicks in later than expected
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7712/1//COMMIT_MSG
Commit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3208: max_row_size option
..
Patch Set 10:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7629/10/common/thrift/PlanNodes.thrift
File
Pranay Singh has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7712
Change subject: IMPALA-5108:idle_session_timeout kicks in later than expected
..
IMPALA-5108:idle_session_timeout kicks in later than
Henry Robinson has posted comments on this change.
Change subject: (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode
..
Patch Set 2:
Thanks for the review, btw - I'm working on some ergonomic improvements before
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5810: reduce minimum non-reservation memory
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7710
To unsubscribe, visit
Dan Hecht has posted comments on this change.
Change subject: IMPALA-5644: Reject queries if min reservation is too large
..
Patch Set 4:
(7 comments)
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7711
Change subject: IMPALA-5811: Add 'backends' tab to query details pages
..
IMPALA-5811: Add 'backends' tab to query details pages
Add a
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-3208: max_row_size option
..
Patch Set 10:
(3 comments)
Starting with my first high level question as I may be missing something
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5452: Rewrite test case to avoid 'pos'.
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7708
To unsubscribe, visit
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7710
Change subject: IMPALA-5810: reduce minimum non-reservation memory
..
IMPALA-5810: reduce minimum non-reservation memory
See JIRA for
Alex Behm has uploaded a new patch set (#3).
Change subject: IMPALA-5452: Rewrite test case to avoid 'pos'.
..
IMPALA-5452: Rewrite test case to avoid 'pos'.
The original test case accessed the 'pos' field of nested
Alex Behm has posted comments on this change.
Change subject: IMPALA-5452: Rewrite test case to avoid 'pos'.
..
Patch Set 1:
(1 comment)
Alex Behm has uploaded a new patch set (#2).
Change subject: IMPALA-5452: Rewrite test case to avoid 'pos'.
..
IMPALA-5452: Rewrite test case to avoid 'pos'.
The original test case accessed the 'pos' field of nested
Pranay Singh has posted comments on this change.
Change subject: IMPALA-5108:idle_session_timeout kicks in later than expected
..
Patch Set 1:
(5 comments)
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5602: Fix query optimization for kudu and datasource
tables
..
Patch Set 4: Code-Review+1
(2 comments)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5602: Fix query optimization for kudu and datasource
tables
..
Patch Set 4:
also it looks like this needs a rebase
--
To view, visit
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and
compression codec
..
Patch Set 6: Code-Review+2
--
To view, visit
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5602: Fix query optimization for kudu and datasource
tables
..
Patch Set 4: Code-Review+1
(4 comments)
Let's see if Alex and or Tim want to take
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5452: Rewrite test case to avoid 'pos'.
..
Patch Set 1:
(1 comment)
Henry Robinson has posted comments on this change.
Change subject: IMPALA-5108:idle_session_timeout kicks in later than expected
..
Patch Set 1:
(5 comments)
Alex Behm has posted comments on this change.
Change subject: MPALA-5776: Write partial tuple to the correct mempool
..
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7639/5/be/src/exec/hdfs-text-scanner.cc
File
Pranay Singh has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7709
Change subject: IMPALA-5108:idle_session_timeout kicks in later than expected
..
IMPALA-5108:idle_session_timeout kicks in later than
Alex Behm has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7708
Change subject: IMPALA-5452: Rewrite test case to avoid 'pos'.
..
IMPALA-5452: Rewrite test case to avoid 'pos'.
The original test case
Hello Michael Ho,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5719
to look at the new patch set (#13).
Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build
..
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5681: release reservation from blocking operators
..
Patch Set 9: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7619
To
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5681: release reservation from blocking operators
..
IMPALA-5681: release reservation from blocking operators
When an in-memory blocking
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5641: mem-estimate should never be less than
mem-reservation
..
Patch Set 2: Code-Review+1
carry +1
--
To view, visit
Hello Impala Public Jenkins, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7653
to look at the new patch set (#6).
Change subject: IMPALA-5677: limit clean page memory consumption
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5677: limit clean page memory consumption
..
Patch Set 6: Code-Review+2
Rebase caused a compilation error in unit test
--
To view, visit
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5796: CTAS for Kudu fails with expr rewrite
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7666
To unsubscribe,
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5796: CTAS for Kudu fails with expr rewrite
..
IMPALA-5796: CTAS for Kudu fails with expr rewrite
When an expr rewrite occurs, we
Dimitris Tsirogiannis has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7706
Change subject: IMPALA-5531: Fix correctness issue in correlated aggregate
subqueries
..
IMPALA-5531: Fix correctness issue in
Impala Public Jenkins has posted comments on this change.
Change subject: Propagate HAVE_PIPE2 compile time value to files that use it
..
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1088/
--
Henry Robinson has posted comments on this change.
Change subject: Propagate HAVE_PIPE2 compile time value to files that use it
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7705
To
Sailesh Mukil has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7705
Change subject: Propagate HAVE_PIPE2 compile time value to files that use it
..
Propagate HAVE_PIPE2 compile time value to files that
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5677: limit clean page memory consumption
..
Patch Set 5: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1087/
--
Tianyi Wang has posted comments on this change.
Change subject: IMPALA-5573: Add decimal codegen in text scanner
..
Patch Set 8:
LLVM still cannot find symbols with static linking, which I haven't tested
before.
--
To view,
Thomas Tauber-Marshall has posted comments on this change.
Change subject: IMPALA-5749: coordinator race hits DCHECK
'num_remaining_backends_ > 0'
..
Patch Set 4: Code-Review+1
Carrying forward +1
--
To view, visit
Thomas Tauber-Marshall has posted comments on this change.
Change subject: IMPALA-5749: coordinator race hits DCHECK
'num_remaining_backends_ > 0'
..
Patch Set 4:
(4 comments)
> (3 comments)
>
> Thanks - this seems a lot
Hello Henry Robinson, Michael Ho, Sailesh Mukil,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7577
to look at the new patch set (#4).
Change subject: IMPALA-5749: coordinator race hits DCHECK
'num_remaining_backends_ > 0'
Matthew Jacobs has posted comments on this change.
Change subject: Bump Kudu version to b198ed8
..
Patch Set 1:
> > corresponding Impala change?
>
> This was included in the toolchain bump Lars did:
>
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool
reservations
..
Patch Set 7:
PS7 includes the proposed changes. I manually tested and it produces the
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool
reservations
..
Patch Set 6:
Yeah what Henry is saying makes sense, although I think it's good to make
Hello Joe McDonnell,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7380
to look at the new patch set (#7).
Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool
reservations
1 - 100 of 120 matches
Mail list logo
