[kudu-CR] [java] KUDU-2013 re-acquire authn token if expired

2017-06-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [java] KUDU-2013 re-acquire authn token if expired .. Patch Set 1: (21 comments) Thank you for the review. I'll address the major points in the next patch rev

[kudu-CR] [java] separating Connection

2017-06-26 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7146 to look at the new patch set (#14). Change subject: [java] separating Connection .. [java] separating Connection T

[kudu-CR] [java] KUDU-2013 re-acquire authn token if expired

2017-06-26 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7250 to look at the new patch set (#2). Change subject: [java] KUDU-2013 re-acquire authn token if expired .. [java] KUD

[kudu-CR] [java] separating Connection

2017-06-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [java] separating Connection .. Patch Set 10: (7 comments) http://gerrit.cloudera.org:8080/#/c/7146/13//COMMIT_MSG Commit Message: Line 11: The TabletClient ha

[kudu-CR] alter table-test and delete table-itest may conflict on master ports

2017-06-26 Thread Mike Percy (Code Review)
Mike Percy has abandoned this change. Change subject: alter_table-test and delete_table-itest may conflict on master ports .. Abandoned Superseded by https://gerrit.cloudera.org/7274 -- To view, visit http://gerrit.cloudera.

[kudu-CR] [java] update dependencies and clean up some deprecate method usage

2017-06-26 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java] update dependencies and clean up some deprecate method usage .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7276/5/java/kudu-client/src/m

[kudu-CR] [java] update dependencies and clean up some deprecate method usage

2017-06-26 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java] update dependencies and clean up some deprecate method usage .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/7276/5/java/kudu-client/src/

[kudu-CR] mini cluster: Test infrastructure improvements

2017-06-26 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: mini cluster: Test infrastructure improvements .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/6959/3/src/kudu/integration-tests/mini_cluster-ites

[kudu-CR] mini cluster: Test infrastructure improvements

2017-06-26 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6959 to look at the new patch set (#4). Change subject: mini cluster: Test infrastructure improvements .. mini cluster:

[kudu-CR] [java] update dependencies and clean up some deprecate method usage

2017-06-26 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7276 to look at the new patch set (#5). Change subject: [java] update dependencies and clean up some deprecate method usage

[kudu-CR] [java] update dependencies and clean up some deprecate method usage

2017-06-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: [java] update dependencies and clean up some deprecate method usage .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7276/3/java/kudu-client/src/m

[kudu-CR] WIP: Add gradle build

2017-06-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: WIP: Add gradle build .. Patch Set 2: (3 comments) I am happy to add extremely thorough comments to the build. http://gerrit.cloudera.org:8080/#/c/7258/2/java/bu

[kudu-CR] TabletReplica: Move Init() logic to Start()

2017-06-26 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7194 to look at the new patch set (#3). Change subject: TabletReplica: Move Init() logic to Start() .. TabletReplica: Mo

[kudu-CR] consensus: Get rid of RaftConsensus::Create()

2017-06-26 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7192 to look at the new patch set (#4). Change subject: consensus: Get rid of RaftConsensus::Create() .. consensus: Get

[kudu-CR] TabletReplica: Move Init() logic to Start()

2017-06-26 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: TabletReplica: Move Init() logic to Start() .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/7194/2/src/kudu/tablet/tablet.h File src/kudu/tablet/t

[kudu-CR] Create ConsensusMetadataManager

2017-06-26 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7191 to look at the new patch set (#5). Change subject: Create ConsensusMetadataManager .. Create ConsensusMetadataManag

[kudu-CR] threadpool: per-token metrics

2017-06-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: threadpool: per-token metrics .. Patch Set 7: Verified+1 Overriding Jenkins, another instance of KUDU-2029. -- To view, visit http://gerrit.cloudera.org:8080/7149

[kudu-CR] [java] update dependencies and clean up some deprecate method usage

2017-06-26 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java] update dependencies and clean up some deprecate method usage .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7276/3/java/kudu-client/src/m

[kudu-CR] [java] update dependencies and clean up some deprecate method usage

2017-06-26 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java] update dependencies and clean up some deprecate method usage .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7276/3/java/kudu-client/src/m

[kudu-CR] [java] update dependencies and clean up some deprecate method usage

2017-06-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: [java] update dependencies and clean up some deprecate method usage .. Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/7276/3/java/kudu-client/src/

[kudu-CR] [java] update dependencies and clean up some deprecate method usage

2017-06-26 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7276 to look at the new patch set (#4). Change subject: [java] update dependencies and clean up some deprecate method usage

[kudu-CR] consensus: Don't mark dirty when clearing the leader UUID

2017-06-26 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: consensus: Don't mark dirty when clearing the leader UUID .. Patch Set 2: overriding flaky jenkins -- To view, visit http://gerrit.cloudera.org:8080/7193 To unsub

[kudu-CR] consensus: Don't mark dirty when clearing the leader UUID

2017-06-26 Thread Mike Percy (Code Review)
Mike Percy has submitted this change and it was merged. Change subject: consensus: Don't mark dirty when clearing the leader UUID .. consensus: Don't mark dirty when clearing the leader UUID There is no reason to mark the table

[kudu-CR] consensus: Don't mark dirty when clearing the leader UUID

2017-06-26 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: consensus: Don't mark dirty when clearing the leader UUID .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7193 To unsubscribe, visit h

[kudu-CR] consensus: Get rid of RaftConsensus::Create()

2017-06-26 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7192 to look at the new patch set (#3). Change subject: consensus: Get rid of RaftConsensus::Create() .. consensus: Get

[kudu-CR] consensus: Get rid of RaftConsensus::Create()

2017-06-26 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: consensus: Get rid of RaftConsensus::Create() .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/7192/2//COMMIT_MSG Commit Message: PS2, Line 12: si

[kudu-CR] Rename MiniCluster to InternalMiniCluster

2017-06-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Rename MiniCluster to InternalMiniCluster .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7272 To unsubscribe, visit http://gerrit.

[kudu-CR] Add mustache as a dependency

2017-06-26 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: Add mustache as a dependency .. Add mustache as a dependency Mustache is a popular template engine. The version added by this commit is a C++ implementati

[kudu-CR] WIP: Add gradle build

2017-06-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: WIP: Add gradle build .. Patch Set 2: (3 comments) Just getting the lay of the land. I would appreciate many more code comments, even on very basic and perhaps ob

[kudu-CR] Use dynamic bind address for internal + external mini clusters

2017-06-26 Thread Mike Percy (Code Review)
Hello Adar Dembo, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7274 to look at the new patch set (#4). Change subject: Use dynamic bind address for internal + external mini clusters .

[kudu-CR] Use dynamic bind address for internal + external mini clusters

2017-06-26 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Use dynamic bind address for internal + external mini clusters .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7274/1/src/kudu/integration-tests/mi

[kudu-CR] [java] remove unused scalamock dependency

2017-06-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: [java] remove unused scalamock dependency .. Patch Set 2: No, thats my fault. I made the patches all separate in case on took longer to review. So no matter what

[kudu-CR] [java] remove unused scalamock dependency

2017-06-26 Thread Grant Henke (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7292 to look at the new patch set (#2). Change subject: [java] remove unused scalamock dependency .. [java]

[kudu-CR] Rename MiniCluster to InternalMiniCluster

2017-06-26 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Rename MiniCluster to InternalMiniCluster .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7272/2//COMMIT_MSG Commit Message: PS2, Line 7: Rename M

[kudu-CR] Rename MiniCluster to InternalMiniCluster

2017-06-26 Thread Mike Percy (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7272 to look at the new patch set (#3). Change subject: Rename MiniCluster to InternalMiniCluster .. Rename

[kudu-CR] disk failure: coordinate error handling

2017-06-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: disk failure: coordinate error handling .. Patch Set 15: (16 comments) http://gerrit.cloudera.org:8080/#/c/7029/15/src/kudu/fs/block_manager.h File src/kudu/fs/blo

[kudu-CR] Create ConsensusMetadataManager

2017-06-26 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7191 to look at the new patch set (#3). Change subject: Create ConsensusMetadataManager .. Create ConsensusMetadataManag

[kudu-CR] Create ConsensusMetadataService

2017-06-26 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Create ConsensusMetadataService .. Patch Set 2: (19 comments) http://gerrit.cloudera.org:8080/#/c/7191/2/src/kudu/consensus/consensus_meta_service-test.cc File src

[kudu-CR] WIP: Add gradle build

2017-06-26 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: WIP: Add gradle build .. Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/7258/2/java/gradle/dependencies.gradle File java/gradle/dependencies.gradle

[kudu-CR] mini tablet server: support multiple data dirs

2017-06-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: mini_tablet_server: support multiple data dirs .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/7211/6//COMMIT_MSG Commit Message: Line 7: mini_ta

[kudu-CR] tests: allow Wait calls for non-default tables

2017-06-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tests: allow Wait calls for non-default tables .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7244 To unsubscribe, visit http://ge

[kudu-CR] external mini cluster: allow more flags on restart

2017-06-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: external_mini_cluster: allow more flags on restart .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7242/4/src/kudu/integration-tests/external_mini_

[kudu-CR] block manager-test: don't inject EIO in destructor

2017-06-26 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: block_manager-test: don't inject EIO in destructor .. block_manager-test: don't inject EIO in destructor BlockManagerTest uses FLAGS_env_inject_eio to inje

[kudu-CR] KUDU-1863: improve overall safety of graceful server shutdown

2017-06-26 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7183 to look at the new patch set (#4). Change subject: KUDU-1863: improve overall safety of graceful server shutdown ..

[kudu-CR] Use dynamic bind address for internal + external mini clusters

2017-06-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Use dynamic bind address for internal + external mini clusters .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7274/1/src/kudu/integration-test

[kudu-CR] Use dynamic bind address for internal + external mini clusters

2017-06-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Use dynamic bind address for internal + external mini clusters .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7274/1/src/kudu/integration-tests

[kudu-CR] KUDU-1863: improve overall safety of graceful server shutdown

2017-06-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1863: improve overall safety of graceful server shutdown .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7183/2//COMMIT_MSG Commit Message: L

[kudu-CR] tool: print usage information when arguments fail to parse

2017-06-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tool: print usage information when arguments fail to parse .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7301/2/src/kudu/tools/tool

[kudu-CR] kserver: introduce KuduServer class

2017-06-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: kserver: introduce KuduServer class .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7239 To unsubscribe, visit http://gerrit.cloud

[kudu-CR] disk failure: coordinate error handling

2017-06-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: disk failure: coordinate error handling .. Patch Set 15: (6 comments) http://gerrit.cloudera.org:8080/#/c/7029/15/src/kudu/fs/fs_manager.h File src/kudu/fs/fs_man

[kudu-CR] tool: print usage information when arguments fail to parse

2017-06-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#2). Change subject: tool: print usage information when arguments fail to parse .. tool: print usage information when arguments fail to parse This changes the output when the user forget

[kudu-CR] tools: add a tool to extract an arbitrary block to stdout

2017-06-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: tools: add a tool to extract an arbitrary block to stdout .. tools: add a tool to extract an arbitrary block to stdout This allows a block to be dumped to

[kudu-CR] tools: add a tool to summarize data size on a tablet or tablets

2017-06-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: tools: add a tool to summarize data size on a tablet or tablets .. tools: add a tool to summarize data size on a tablet or tablets This adds 'kudu local_r

[kudu-CR] tools: add a tool to extract an arbitrary block to stdout

2017-06-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tools: add a tool to extract an arbitrary block to stdout .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7260/2/src/kudu/tools/tool

[kudu-CR] disk failure: make DataDirManager failure-aware

2017-06-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: disk failure: make DataDirManager failure-aware .. Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/7028/11/src/kudu/fs/data_dirs.cc File src/kudu/f

[kudu-CR] tools: refactor table-printing code a bit

2017-06-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: tools: refactor table-printing code a bit .. tools: refactor table-printing code a bit This changes the table-printing code to use a class and add some ex

[kudu-CR] WIP KUDU-1943: Add BlockTransaction to Block Manager

2017-06-26 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7207 to look at the new patch set (#8). Change subject: WIP KUDU-1943: Add BlockTransaction to Block Manager .. WIP KUDU

[kudu-CR] server: move apply pool into KuduServer

2017-06-26 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6984 to look at the new patch set (#12). Change subject: server: move apply_pool into KuduServer ...

[kudu-CR] kserver: introduce KuduServer class

2017-06-26 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7239 to look at the new patch set (#2). Change subject: kserver: introduce KuduServer class .. kserver: introduce KuduSe

[kudu-CR] threadpool: per-token metrics

2017-06-26 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7149 to look at the new patch set (#6). Change subject: threadpool: per-token metrics .. threadpool: per-token metrics

[kudu-CR] threadpool: token-based task sequencing

2017-06-26 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6874 to look at the new patch set (#13). Change subject: threadpool: token-based task sequencing

[kudu-CR] consensus: consolidate Raft thread pools

2017-06-26 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6946 to look at the new patch set (#14). Change subject: consensus: consolidate Raft thread pools .. consensus: consolid

[kudu-CR] KUDU-1863: improve overall safety of graceful server shutdown

2017-06-26 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7183 to look at the new patch set (#3). Change subject: KUDU-1863: improve overall safety of graceful server shutdown ..

[kudu-CR] server: consolidate tablet prepare pools

2017-06-26 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7150 to look at the new patch set (#5). Change subject: server: consolidate tablet prepare pools .. server: consolidate

[kudu-CR] tools: add a tool to summarize data size on a tablet or tablets

2017-06-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tools: add a tool to summarize data size on a tablet or tablets .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5727 To unsubscribe

[kudu-CR] server: consolidate tablet prepare pools

2017-06-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: server: consolidate tablet prepare pools .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7150/4/src/kudu/kserver/kserver.cc File src/kudu/kserver/k

[kudu-CR] tool: print usage information when arguments fail to parse

2017-06-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/7301 Change subject: tool: print usage information when arguments fail to parse .. tool: print usage information when arguments fail to parse T

[kudu-CR] tools: add a tool to summarize data size on a tablet or tablets

2017-06-26 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5727 to look at the new patch set (#4). Change subject: tools: add a tool to summarize data size on a tablet or tablets .

[kudu-CR] [java] remove unused scalamock dependency

2017-06-26 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java] remove unused scalamock dependency .. Patch Set 1: ah sorry I think I merged in the wrong order -- To view, visit http://gerrit.cloudera.org:8080/7292 To

[kudu-CR] [java] remove log4j from compile and provided scope

2017-06-26 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: [java] remove log4j from compile and provided scope .. [java] remove log4j from compile and provided scope Removes log4j and slf4j-log4j12 from provided a

[kudu-CR] consensus: consolidate Raft thread pools

2017-06-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: consensus: consolidate Raft thread pools .. Patch Set 13: (3 comments) http://gerrit.cloudera.org:8080/#/c/6946/13/src/kudu/consensus/raft_consensus.cc File src/ku

[kudu-CR] KUDU-1929: [rpc] Allow using encrypted private keys for TLS

2017-06-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6635 To unsubscribe,

[kudu-CR] [java] KUDU-2013 re-acquire authn token if expired

2017-06-26 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java] KUDU-2013 re-acquire authn token if expired .. Patch Set 1: (21 comments) http://gerrit.cloudera.org:8080/#/c/7250/1//COMMIT_MSG Commit Message: PS1, Line

[kudu-CR] KUDU-1929: [rpc] Allow using encrypted private keys for TLS

2017-06-26 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6635 To unsubscribe, v

[kudu-CR] tools: add a tool to extract an arbitrary block to stdout

2017-06-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tools: add a tool to extract an arbitrary block to stdout .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7260 To unsubscribe, visi

[kudu-CR] Add mustache as a dependency

2017-06-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add mustache as a dependency .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7298 To unsubscribe, visit http://gerrit.cloudera.org:

[kudu-CR] KUDU-1863: improve overall safety of graceful server shutdown

2017-06-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1863: improve overall safety of graceful server shutdown .. Patch Set 2: (10 comments) http://gerrit.cloudera.org:8080/#/c/7183/2//COMMIT_MSG Commit Message:

[kudu-CR] tools: add a tool to extract an arbitrary block to stdout

2017-06-26 Thread Todd Lipcon (Code Review)
Hello Adar Dembo, Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7260 to look at the new patch set (#3). Change subject: tools: add a tool to extract an arbitrary block to stdout

[kudu-CR] KUDU-1929: [rpc] Allow using encrypted private keys for TLS

2017-06-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/6635/6/src/kudu/rpc/rpc-test.cc File

[kudu-CR] KUDU-1929: [rpc] Allow using encrypted private keys for TLS

2017-06-26 Thread Sailesh Mukil (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6635 to look at the new patch set (#8). Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS

[kudu-CR] WIP: Add gradle build

2017-06-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: WIP: Add gradle build .. Patch Set 2: (11 comments) http://gerrit.cloudera.org:8080/#/c/7258/2/java/gradle/dependencies.gradle File java/gradle/dependencies.gradl

[kudu-CR] Add mustache as a dependency

2017-06-26 Thread Sam Okrent (Code Review)
Sam Okrent has posted comments on this change. Change subject: Add mustache as a dependency .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/7298/2//COMMIT_MSG Commit Message: Line 7: Add mustache as a depende

[kudu-CR] Add mustache as a dependency

2017-06-26 Thread Sam Okrent (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7298 to look at the new patch set (#4). Change subject: Add mustache as a dependency .. Add mustache as a d

[kudu-CR] Add mustache as a dependency

2017-06-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add mustache as a dependency .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7298/3/thirdparty/LICENSE.txt File thirdparty/LICENSE.txt: Line 246:

[kudu-CR] tools: refactor table-printing code a bit

2017-06-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tools: refactor table-printing code a bit .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7259 To unsubscribe, visit http://gerrit.

[kudu-CR] tools: add a tool to extract an arbitrary block to stdout

2017-06-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tools: add a tool to extract an arbitrary block to stdout .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7260/2/src/kudu/tools/tool_

[kudu-CR] WIP KUDU-1943: Add BlockTransaction to Block Manager

2017-06-26 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: WIP KUDU-1943: Add BlockTransaction to Block Manager .. Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/7207/5/src/kudu/fs/block_manager.h File src/kudu

[kudu-CR] WIP KUDU-1943: Add BlockTransaction to Block Manager

2017-06-26 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7207 to look at the new patch set (#7). Change subject: WIP KUDU-1943: Add BlockTransaction to Block Manager .. WIP KUDU

[kudu-CR] Add mustache as a dependency

2017-06-26 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Add mustache as a dependency .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7298 To unsubscribe, visit http://gerrit.cloudera.org

[kudu-CR] tools: add a tool to summarize data size on a tablet or tablets

2017-06-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: tools: add a tool to summarize data size on a tablet or tablets .. Patch Set 3: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/5727/2/src/kudu/tool

[kudu-CR] KUDU-1929: [rpc] Allow using encrypted private keys for TLS

2017-06-26 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1929: [rpc] Allow using encrypted private keys for TLS .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6635/6/src/kudu/rpc/rpc-test.cc File s

[kudu-CR] [java-client] separating Connection

2017-06-26 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java-client] separating Connection .. Patch Set 13: (9 comments) http://gerrit.cloudera.org:8080/#/c/7146/13//COMMIT_MSG Commit Message: Line 11: The TabletClie

[kudu-CR] Add mustache as a dependency

2017-06-26 Thread Sam Okrent (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7298 to look at the new patch set (#3). Change subject: Add mustache as a dependency .. Add mustache as a dependency Mu

[kudu-CR] tools: add a tool to summarize data size on a tablet or tablets

2017-06-26 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5727 to look at the new patch set (#3). Change subject: tools: add a tool to summarize data size on a tablet or tablets .

[kudu-CR] tools: add a tool to extract an arbitrary block to stdout

2017-06-26 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7260 to look at the new patch set (#2). Change subject: tools: add a tool to extract an arbitrary block to stdout

[kudu-CR] tools: refactor table-printing code a bit

2017-06-26 Thread Todd Lipcon (Code Review)
Hello Will Berkeley, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7259 to look at the new patch set (#2). Change subject: tools: refactor table-printing code a bit .. tool

[kudu-CR] tools: add a tool to extract an arbitrary block to stdout

2017-06-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tools: add a tool to extract an arbitrary block to stdout .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7260/1/src/kudu/tools/kudu-tool-test.cc

[kudu-CR] tools: add a tool to summarize data size on a tablet or tablets

2017-06-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tools: add a tool to summarize data size on a tablet or tablets .. Patch Set 2: (14 comments) http://gerrit.cloudera.org:8080/#/c/5727/2/src/kudu/tools/kudu-tool-

[kudu-CR] Add mustache as a dependency

2017-06-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add mustache as a dependency .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7298/2/thirdparty/build-definitions.sh File thirdparty/build-definitio

[kudu-CR] Add mustache as a dependency

2017-06-26 Thread Sam Okrent (Code Review)
Sam Okrent has posted comments on this change. Change subject: Add mustache as a dependency .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7298/2/src/kudu/server/default-path-handlers.cc File src/kudu/server/d

  1   2   >