[jira] [Commented] (HADOOP-15261) Upgrade commons-io from 2.4 to 2.5
[ https://issues.apache.org/jira/browse/HADOOP-15261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541280#comment-17541280 ] Masatake Iwasaki commented on HADOOP-15261: --- and branch-2.10.2. > Upgrade commons-io from 2.4 to 2.5 > -- > > Key: HADOOP-15261 > URL: https://issues.apache.org/jira/browse/HADOOP-15261 > Project: Hadoop Common > Issue Type: Bug > Components: minikdc >Affects Versions: 3.0.0-alpha3 >Reporter: PandaMonkey >Assignee: PandaMonkey >Priority: Major > Fix For: 3.1.0, 2.10.2 > > Attachments: 347.patch, hadoop.txt > > > Hi, after analyzing hadoop-common-project\hadoop-minikdc\pom.xml, we found > that Hadoop depends on org.apache.kerby:kerb-simplekdc 1.0.1, which > transitivity introduced commons-io:2.5. > At the same time, hadoop directly depends on a older version of > commons-io:2.4. By further look into the source code, these two versions of > commons-io have many different features. The dependency conflict problem > brings high risks of "NotClassDefFoundError:" or "NoSuchMethodError" issues > at runtime. Please notice this problem. Maybe upgrading commons-io from 2.4 > to 2.5 is a good choice. Hope this report can help you. Thanks! > -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-15261) Upgrade commons-io from 2.4 to 2.5
[ https://issues.apache.org/jira/browse/HADOOP-15261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masatake Iwasaki updated HADOOP-15261: -- Fix Version/s: 2.10.2 (was: 2.10.3) > Upgrade commons-io from 2.4 to 2.5 > -- > > Key: HADOOP-15261 > URL: https://issues.apache.org/jira/browse/HADOOP-15261 > Project: Hadoop Common > Issue Type: Bug > Components: minikdc >Affects Versions: 3.0.0-alpha3 >Reporter: PandaMonkey >Assignee: PandaMonkey >Priority: Major > Fix For: 3.1.0, 2.10.2 > > Attachments: 347.patch, hadoop.txt > > > Hi, after analyzing hadoop-common-project\hadoop-minikdc\pom.xml, we found > that Hadoop depends on org.apache.kerby:kerb-simplekdc 1.0.1, which > transitivity introduced commons-io:2.5. > At the same time, hadoop directly depends on a older version of > commons-io:2.4. By further look into the source code, these two versions of > commons-io have many different features. The dependency conflict problem > brings high risks of "NotClassDefFoundError:" or "NoSuchMethodError" issues > at runtime. Please notice this problem. Maybe upgrading commons-io from 2.4 > to 2.5 is a good choice. Hope this report can help you. Thanks! > -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] iwasakims merged pull request #4350: YARN-11162 Set the zk acl for nodes created by YARN's ZKConfigurationStore.
iwasakims merged PR #4350: URL: https://github.com/apache/hadoop/pull/4350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] saintstack commented on pull request #4347: HDFS-16586. Purge FsDatasetAsyncDiskService threadgroup; it causes BP…
saintstack commented on PR #4347: URL: https://github.com/apache/hadoop/pull/4347#issuecomment-1135393905 Running above tests in a loop locally w/ the PR in place pass. Let me push a non-change to get a new test run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4350: YARN-11162 Set the zk acl for nodes created by YARN's ZKConfigurationStore.
hadoop-yetus commented on PR #4350:
URL: https://github.com/apache/hadoop/pull/4350#issuecomment-1135374251
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 37s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 40m 54s | | trunk passed |
| +1 :green_heart: | compile | 1m 22s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | compile | 1m 14s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 1m 10s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 21s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 16s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 1m 1s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 2m 25s | | trunk passed |
| +1 :green_heart: | shadedclient | 21m 40s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 0s | | the patch passed |
| +1 :green_heart: | compile | 1m 5s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javac | 1m 5s | | the patch passed |
| +1 :green_heart: | compile | 0m 58s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 0m 58s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 47s | | the patch passed |
| +1 :green_heart: | mvnsite | 1m 0s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 49s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 0m 46s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 2m 3s | | the patch passed |
| +1 :green_heart: | shadedclient | 21m 3s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 97m 55s | |
hadoop-yarn-server-resourcemanager in the patch passed. |
| +1 :green_heart: | asflicense | 0m 50s | | The patch does not
generate ASF License warnings. |
| | | 200m 56s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4350/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/4350 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux f39576824849 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24
17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / b9b927af1d95d51bdc6775d2c0ac7d2855139670 |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4350/1/testReport/ |
| Max. process+thread count | 980 (vs. ulimit of 5500) |
| modules | C:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
U:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
|
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4350/1/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the
[GitHub] [hadoop] jianghuazhu opened a new pull request, #4351: HDFS-16592.Fix typo for BalancingPolicy.
jianghuazhu opened a new pull request, #4351: URL: https://github.com/apache/hadoop/pull/4351 ### Description of PR Fixed some typos related to BalancingPolicy. ### How was this patch tested? Not too stressful for testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-15261) Upgrade commons-io from 2.4 to 2.5
[ https://issues.apache.org/jira/browse/HADOOP-15261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masatake Iwasaki updated HADOOP-15261: -- Fix Version/s: 2.10.3 > Upgrade commons-io from 2.4 to 2.5 > -- > > Key: HADOOP-15261 > URL: https://issues.apache.org/jira/browse/HADOOP-15261 > Project: Hadoop Common > Issue Type: Bug > Components: minikdc >Affects Versions: 3.0.0-alpha3 >Reporter: PandaMonkey >Assignee: PandaMonkey >Priority: Major > Fix For: 3.1.0, 2.10.3 > > Attachments: 347.patch, hadoop.txt > > > Hi, after analyzing hadoop-common-project\hadoop-minikdc\pom.xml, we found > that Hadoop depends on org.apache.kerby:kerb-simplekdc 1.0.1, which > transitivity introduced commons-io:2.5. > At the same time, hadoop directly depends on a older version of > commons-io:2.4. By further look into the source code, these two versions of > commons-io have many different features. The dependency conflict problem > brings high risks of "NotClassDefFoundError:" or "NoSuchMethodError" issues > at runtime. Please notice this problem. Maybe upgrading commons-io from 2.4 > to 2.5 is a good choice. Hope this report can help you. Thanks! > -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-15261) Upgrade commons-io from 2.4 to 2.5
[ https://issues.apache.org/jira/browse/HADOOP-15261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17541249#comment-17541249 ] Masatake Iwasaki commented on HADOOP-15261: --- cherry-picked to branch-2.10. > Upgrade commons-io from 2.4 to 2.5 > -- > > Key: HADOOP-15261 > URL: https://issues.apache.org/jira/browse/HADOOP-15261 > Project: Hadoop Common > Issue Type: Bug > Components: minikdc >Affects Versions: 3.0.0-alpha3 >Reporter: PandaMonkey >Assignee: PandaMonkey >Priority: Major > Fix For: 3.1.0, 2.10.3 > > Attachments: 347.patch, hadoop.txt > > > Hi, after analyzing hadoop-common-project\hadoop-minikdc\pom.xml, we found > that Hadoop depends on org.apache.kerby:kerb-simplekdc 1.0.1, which > transitivity introduced commons-io:2.5. > At the same time, hadoop directly depends on a older version of > commons-io:2.4. By further look into the source code, these two versions of > commons-io have many different features. The dependency conflict problem > brings high risks of "NotClassDefFoundError:" or "NoSuchMethodError" issues > at runtime. Please notice this problem. Maybe upgrading commons-io from 2.4 > to 2.5 is a good choice. Hope this report can help you. Thanks! > -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] jianghuazhu commented on pull request #4342: HDFS-16588.Backport HDFS-16584 to branch-3.3 and other active old branches.
jianghuazhu commented on PR #4342: URL: https://github.com/apache/hadoop/pull/4342#issuecomment-1135344334 Thanks @tomscut . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] prasad-acit commented on pull request #4241: HDFS-16563. Namenode WebUI prints sensitive information on Token expiry
prasad-acit commented on PR #4241: URL: https://github.com/apache/hadoop/pull/4241#issuecomment-1135308790 Thanks @steveloughran for the review. @jojochuang can you please review the latest? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on pull request #4349: HDFS-16590. Fix Junit Test Deprecated assertThat
slfan1989 commented on PR #4349: URL: https://github.com/apache/hadoop/pull/4349#issuecomment-1135291345 Hi, @Hexiaoqiao please help to review the code , thank you very match! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on pull request #4336: YARN-11137. Improve log message in FederationClientInterceptor
slfan1989 commented on PR #4336: URL: https://github.com/apache/hadoop/pull/4336#issuecomment-1135272894 Hi, @goiri please help to review the code , thank you very match! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] omalley opened a new pull request, #4350: YARN-11162 Set the zk acl for nodes created by YARN's ZKConfigurationStore.
omalley opened a new pull request, #4350: URL: https://github.com/apache/hadoop/pull/4350 Set the zk acl for nodes created by Yarn's ZKConfigurationStore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 opened a new pull request, #4349: HDFS-16590. Fix Junit Test Deprecated assertThat
slfan1989 opened a new pull request, #4349: URL: https://github.com/apache/hadoop/pull/4349 JIRA: HDFS-16590. Fix Junit Test Deprecated assertThat -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773810=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773810
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 23:37
Start Date: 23/May/22 23:37
Worklog Time Spent: 10m
Work Description: slfan1989 commented on PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1135241796
Hi, @dannycjones Thanks a lot for your suggestions for the code, I'll keep
improving it, I think this should really be changed to HDFS-JIRA.
Issue Time Tracking
---
Worklog Id: (was: 773810)
Time Spent: 4h 10m (was: 4h)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
> a related issue will be resolved in HDFS-16590.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773809=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773809
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 23:37
Start Date: 23/May/22 23:37
Worklog Time Spent: 10m
Work Description: slfan1989 commented on PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1135241795
Hi, @dannycjones Thanks a lot for your suggestions for the code, I'll keep
improving it, I think this should really be changed to HDFS-JIRA.
Issue Time Tracking
---
Worklog Id: (was: 773809)
Time Spent: 4h (was: 3h 50m)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
> a related issue will be resolved in HDFS-16590.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on pull request #4334: HADOOP-18248. Fix Junit Test Deprecated assertThat.
slfan1989 commented on PR #4334: URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1135241796 Hi, @dannycjones Thanks a lot for your suggestions for the code, I'll keep improving it, I think this should really be changed to HDFS-JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on pull request #4334: HADOOP-18248. Fix Junit Test Deprecated assertThat.
slfan1989 commented on PR #4334: URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1135241795 Hi, @dannycjones Thanks a lot for your suggestions for the code, I'll keep improving it, I think this should really be changed to HDFS-JIRA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773808=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773808
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 23:35
Start Date: 23/May/22 23:35
Worklog Time Spent: 10m
Work Description: slfan1989 commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879939590
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/test/java/org/apache/hadoop/yarn/service/TestYarnNativeServices.java:
##
@@ -917,7 +917,8 @@ private void checkEachCompInstancesInOrder(Component
component, String
int i = 0;
for (String s : instances) {
- assertThat(s).isEqualTo(component.getName() + "-" + i);
+ assertThat(s,
+ CoreMatchers.containsString(component.getName() + "-" + i));
Review Comment:
I think your suggestion is correct and should be changed to equal.
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/test/java/org/apache/hadoop/yarn/service/TestYarnNativeServices.java:
##
@@ -917,7 +917,8 @@ private void checkEachCompInstancesInOrder(Component
component, String
int i = 0;
for (String s : instances) {
- assertThat(s).isEqualTo(component.getName() + "-" + i);
+ assertThat(s,
+ CoreMatchers.containsString(component.getName() + "-" + i));
Review Comment:
I think your suggestion is correct and should be changed to equal.
Issue Time Tracking
---
Worklog Id: (was: 773808)
Time Spent: 3h 50m (was: 3h 40m)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
> a related issue will be resolved in HDFS-16590.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4334: HADOOP-18248. Fix Junit Test Deprecated assertThat.
slfan1989 commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879939590
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/test/java/org/apache/hadoop/yarn/service/TestYarnNativeServices.java:
##
@@ -917,7 +917,8 @@ private void checkEachCompInstancesInOrder(Component
component, String
int i = 0;
for (String s : instances) {
- assertThat(s).isEqualTo(component.getName() + "-" + i);
+ assertThat(s,
+ CoreMatchers.containsString(component.getName() + "-" + i));
Review Comment:
I think your suggestion is correct and should be changed to equal.
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/test/java/org/apache/hadoop/yarn/service/TestYarnNativeServices.java:
##
@@ -917,7 +917,8 @@ private void checkEachCompInstancesInOrder(Component
component, String
int i = 0;
for (String s : instances) {
- assertThat(s).isEqualTo(component.getName() + "-" + i);
+ assertThat(s,
+ CoreMatchers.containsString(component.getName() + "-" + i));
Review Comment:
I think your suggestion is correct and should be changed to equal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773807=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773807
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 23:34
Start Date: 23/May/22 23:34
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1135240105
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 37s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 60 new or modified test files. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 14m 36s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 24m 41s | | trunk passed |
| +1 :green_heart: | compile | 22m 44s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | compile | 20m 24s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 4m 25s | | trunk passed |
| +1 :green_heart: | mvnsite | 15m 59s | | trunk passed |
| +1 :green_heart: | javadoc | 13m 50s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 13m 50s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 21m 30s | | trunk passed |
| +1 :green_heart: | shadedclient | 23m 57s | | branch has no errors
when building and testing our client artifacts. |
| -0 :warning: | patch | 24m 28s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 33s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 7m 34s | | the patch passed |
| +1 :green_heart: | compile | 22m 14s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| -1 :x: | javac | 22m 14s |
[/results-compile-javac-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4334/6/artifact/out/results-compile-javac-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt)
| root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 4 new + 2458 unchanged - 451
fixed = 2462 total (was 2909) |
| +1 :green_heart: | compile | 20m 47s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| -1 :x: | javac | 20m 47s |
[/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4334/6/artifact/out/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt)
| root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 4 new + 2256
unchanged - 451 fixed = 2260 total (was 2707) |
| -1 :x: | blanks | 0m 0s |
[/blanks-eol.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4334/6/artifact/out/blanks-eol.txt)
| The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix
<>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | checkstyle | 4m 20s | | root: The patch generated
0 new + 688 unchanged - 2 fixed = 688 total (was 690) |
| +1 :green_heart: | mvnsite | 15m 56s | | the patch passed |
| +1 :green_heart: | javadoc | 13m 45s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 13m 47s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 23m 17s | | the patch passed |
| +1 :green_heart: | shadedclient | 22m 12s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 4m 4s | | hadoop-auth in the patch
passed. |
| +1 :green_heart: | unit | 18m 29s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | unit |
[GitHub] [hadoop] hadoop-yetus commented on pull request #4334: HADOOP-18248. Fix Junit Test Deprecated assertThat.
hadoop-yetus commented on PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1135240105
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 37s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 60 new or modified test files. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 14m 36s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 24m 41s | | trunk passed |
| +1 :green_heart: | compile | 22m 44s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | compile | 20m 24s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 4m 25s | | trunk passed |
| +1 :green_heart: | mvnsite | 15m 59s | | trunk passed |
| +1 :green_heart: | javadoc | 13m 50s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 13m 50s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 21m 30s | | trunk passed |
| +1 :green_heart: | shadedclient | 23m 57s | | branch has no errors
when building and testing our client artifacts. |
| -0 :warning: | patch | 24m 28s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 33s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 7m 34s | | the patch passed |
| +1 :green_heart: | compile | 22m 14s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| -1 :x: | javac | 22m 14s |
[/results-compile-javac-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4334/6/artifact/out/results-compile-javac-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt)
| root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 4 new + 2458 unchanged - 451
fixed = 2462 total (was 2909) |
| +1 :green_heart: | compile | 20m 47s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| -1 :x: | javac | 20m 47s |
[/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4334/6/artifact/out/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt)
| root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 4 new + 2256
unchanged - 451 fixed = 2260 total (was 2707) |
| -1 :x: | blanks | 0m 0s |
[/blanks-eol.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4334/6/artifact/out/blanks-eol.txt)
| The patch has 1 line(s) that end in blanks. Use git apply --whitespace=fix
<>. Refer https://git-scm.com/docs/git-apply |
| +1 :green_heart: | checkstyle | 4m 20s | | root: The patch generated
0 new + 688 unchanged - 2 fixed = 688 total (was 690) |
| +1 :green_heart: | mvnsite | 15m 56s | | the patch passed |
| +1 :green_heart: | javadoc | 13m 45s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 13m 47s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 23m 17s | | the patch passed |
| +1 :green_heart: | shadedclient | 22m 12s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 4m 4s | | hadoop-auth in the patch
passed. |
| +1 :green_heart: | unit | 18m 29s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | unit | 253m 34s | | hadoop-hdfs in the patch
passed. |
| +1 :green_heart: | unit | 4m 0s | | hadoop-hdfs-nfs in the patch
passed. |
| +1 :green_heart: | unit | 5m 58s | | hadoop-yarn-common in the patch
passed. |
| +1 :green_heart: | unit | 24m 39s | | hadoop-yarn-server-nodemanager
in the patch passed. |
| +1 :green_heart: | unit | 22m 31s | | hadoop-distcp in the patch
passed. |
|
[GitHub] [hadoop] hadoop-yetus commented on pull request #4347: HDFS-16586. Purge FsDatasetAsyncDiskService threadgroup; it causes BP…
hadoop-yetus commented on PR #4347:
URL: https://github.com/apache/hadoop/pull/4347#issuecomment-1135151393
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 8s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
_ branch-3.3 Compile Tests _ |
| +1 :green_heart: | mvninstall | 39m 18s | | branch-3.3 passed |
| +1 :green_heart: | compile | 1m 26s | | branch-3.3 passed |
| +1 :green_heart: | checkstyle | 1m 6s | | branch-3.3 passed |
| +1 :green_heart: | mvnsite | 1m 36s | | branch-3.3 passed |
| +1 :green_heart: | javadoc | 1m 45s | | branch-3.3 passed |
| +1 :green_heart: | spotbugs | 3m 40s | | branch-3.3 passed |
| +1 :green_heart: | shadedclient | 28m 51s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 19s | | the patch passed |
| +1 :green_heart: | compile | 1m 12s | | the patch passed |
| +1 :green_heart: | javac | 1m 12s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 48s | | the patch passed |
| +1 :green_heart: | mvnsite | 1m 19s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 24s | | the patch passed |
| +1 :green_heart: | spotbugs | 3m 31s | | the patch passed |
| +1 :green_heart: | shadedclient | 28m 11s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| -1 :x: | unit | 211m 45s |
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4347/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
| hadoop-hdfs in the patch passed. |
| +1 :green_heart: | asflicense | 1m 2s | | The patch does not
generate ASF License warnings. |
| | | 326m 33s | | |
| Reason | Tests |
|---:|:--|
| Failed junit tests | hadoop.hdfs.TestRollingUpgrade |
| | hadoop.hdfs.server.datanode.TestBPOfferService |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4347/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/4347 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux b1d7a7baac52 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24
17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | branch-3.3 / 45e867e5f09841dca584708398510021245653ed |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4347/1/testReport/ |
| Max. process+thread count | 2521 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4347/1/console |
| versions | git=2.17.1 maven=3.6.0 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-15327) Upgrade MR ShuffleHandler to use Netty4
[
https://issues.apache.org/jira/browse/HADOOP-15327?focusedWorklogId=773736=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773736
]
ASF GitHub Bot logged work on HADOOP-15327:
---
Author: ASF GitHub Bot
Created on: 23/May/22 21:07
Start Date: 23/May/22 21:07
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on PR #3259:
URL: https://github.com/apache/hadoop/pull/3259#issuecomment-1135138992
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 2s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 4 new or modified test files. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 14m 32s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 24m 27s | | trunk passed |
| +1 :green_heart: | compile | 22m 52s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | compile | 20m 29s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 4m 23s | | trunk passed |
| +1 :green_heart: | mvnsite | 8m 1s | | trunk passed |
| +1 :green_heart: | javadoc | 7m 4s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 6m 35s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +0 :ok: | spotbugs | 1m 12s | |
branch/hadoop-client-modules/hadoop-client-runtime no spotbugs output file
(spotbugsXml.xml) |
| +1 :green_heart: | shadedclient | 21m 49s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 35s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 6m 28s | | the patch passed |
| +1 :green_heart: | compile | 22m 12s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| -1 :x: | javac | 22m 12s |
[/results-compile-javac-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3259/7/artifact/out/results-compile-javac-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt)
| root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 1 new + 2908 unchanged - 0
fixed = 2909 total (was 2908) |
| +1 :green_heart: | compile | 20m 34s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| -1 :x: | javac | 20m 34s |
[/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3259/7/artifact/out/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt)
| root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 1 new + 2706
unchanged - 0 fixed = 2707 total (was 2706) |
| -1 :x: | blanks | 0m 0s |
[/blanks-eol.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3259/7/artifact/out/blanks-eol.txt)
| The patch has 25 line(s) that end in blanks. Use git apply --whitespace=fix
<>. Refer https://git-scm.com/docs/git-apply |
| -0 :warning: | checkstyle | 4m 16s |
[/results-checkstyle-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3259/7/artifact/out/results-checkstyle-root.txt)
| root: The patch generated 84 new + 132 unchanged - 12 fixed = 216 total
(was 144) |
| +1 :green_heart: | mvnsite | 8m 5s | | the patch passed |
| +1 :green_heart: | xml | 0m 3s | | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 6m 47s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 6m 39s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| -1 :x: | spotbugs | 4m 51s |
[/new-spotbugs-hadoop-mapreduce-project_hadoop-mapreduce-client.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3259/7/artifact/out/new-spotbugs-hadoop-mapreduce-project_hadoop-mapreduce-client.html)
| hadoop-mapreduce-project/hadoop-mapreduce-client generated 1
[GitHub] [hadoop] hadoop-yetus commented on pull request #3259: HADOOP-15327. Upgrade MR ShuffleHandler to use Netty4
hadoop-yetus commented on PR #3259:
URL: https://github.com/apache/hadoop/pull/3259#issuecomment-1135138992
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 2s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 4 new or modified test files. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 14m 32s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 24m 27s | | trunk passed |
| +1 :green_heart: | compile | 22m 52s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | compile | 20m 29s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 4m 23s | | trunk passed |
| +1 :green_heart: | mvnsite | 8m 1s | | trunk passed |
| +1 :green_heart: | javadoc | 7m 4s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 6m 35s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +0 :ok: | spotbugs | 1m 12s | |
branch/hadoop-client-modules/hadoop-client-runtime no spotbugs output file
(spotbugsXml.xml) |
| +1 :green_heart: | shadedclient | 21m 49s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 35s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 6m 28s | | the patch passed |
| +1 :green_heart: | compile | 22m 12s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| -1 :x: | javac | 22m 12s |
[/results-compile-javac-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3259/7/artifact/out/results-compile-javac-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt)
| root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 with JDK Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 1 new + 2908 unchanged - 0
fixed = 2909 total (was 2908) |
| +1 :green_heart: | compile | 20m 34s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| -1 :x: | javac | 20m 34s |
[/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3259/7/artifact/out/results-compile-javac-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt)
| root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 1 new + 2706
unchanged - 0 fixed = 2707 total (was 2706) |
| -1 :x: | blanks | 0m 0s |
[/blanks-eol.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3259/7/artifact/out/blanks-eol.txt)
| The patch has 25 line(s) that end in blanks. Use git apply --whitespace=fix
<>. Refer https://git-scm.com/docs/git-apply |
| -0 :warning: | checkstyle | 4m 16s |
[/results-checkstyle-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3259/7/artifact/out/results-checkstyle-root.txt)
| root: The patch generated 84 new + 132 unchanged - 12 fixed = 216 total
(was 144) |
| +1 :green_heart: | mvnsite | 8m 5s | | the patch passed |
| +1 :green_heart: | xml | 0m 3s | | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 6m 47s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 6m 39s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| -1 :x: | spotbugs | 4m 51s |
[/new-spotbugs-hadoop-mapreduce-project_hadoop-mapreduce-client.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3259/7/artifact/out/new-spotbugs-hadoop-mapreduce-project_hadoop-mapreduce-client.html)
| hadoop-mapreduce-project/hadoop-mapreduce-client generated 1 new + 0
unchanged - 0 fixed = 1 total (was 0) |
| -1 :x: | spotbugs | 2m 8s |
[/new-spotbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3259/7/artifact/out/new-spotbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.html)
|
[GitHub] [hadoop] goiri commented on a diff in pull request #4340: HDFS-15878 RBF: Flaky test TestRouterWebHDFSContractCreate>AbstractCo…
goiri commented on code in PR #4340:
URL: https://github.com/apache/hadoop/pull/4340#discussion_r879861484
##
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractCreateTest.java:
##
@@ -568,13 +568,13 @@ protected void validateSyncableSemantics(final FileSystem
fs,
in.close();
} catch (FileNotFoundException e) {
- // that's OK if it's an object store, but not if its a real
- // FS
- if (!isSupported(IS_BLOBSTORE)) {
+ // that's OK if it's an object store or some file systems that newly
created files
+ // are not immediately visible, but not if its a real FS
+ if (!isSupported(IS_BLOBSTORE) &&
!isSupported(CREATE_VISIBILITY_DELAYED)) {
throw e;
} else {
LOG.warn(
-"Output file was not created; this is an object store with
different"
+"Output file was not created; this is an object store or a
file system with different"
Review Comment:
Split this line for 100 chars.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4348: HDFS-16586. Purge FsDatasetAsyncDiskService threadgroup; it causes BP…
hadoop-yetus commented on PR #4348:
URL: https://github.com/apache/hadoop/pull/4348#issuecomment-1135126626
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 6m 3s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
_ branch-3.2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 32m 30s | | branch-3.2 passed |
| +1 :green_heart: | compile | 1m 10s | | branch-3.2 passed |
| +1 :green_heart: | checkstyle | 1m 2s | | branch-3.2 passed |
| +1 :green_heart: | mvnsite | 1m 22s | | branch-3.2 passed |
| +1 :green_heart: | javadoc | 1m 11s | | branch-3.2 passed |
| +1 :green_heart: | spotbugs | 3m 24s | | branch-3.2 passed |
| +1 :green_heart: | shadedclient | 17m 48s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 11s | | the patch passed |
| +1 :green_heart: | compile | 1m 1s | | the patch passed |
| +1 :green_heart: | javac | 1m 1s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 47s | | the patch passed |
| +1 :green_heart: | mvnsite | 1m 9s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 53s | | the patch passed |
| +1 :green_heart: | spotbugs | 3m 4s | | the patch passed |
| +1 :green_heart: | shadedclient | 18m 30s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| -1 :x: | unit | 201m 43s |
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4348/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
| hadoop-hdfs in the patch passed. |
| +1 :green_heart: | asflicense | 0m 57s | | The patch does not
generate ASF License warnings. |
| | | 291m 16s | | |
| Reason | Tests |
|---:|:--|
| Failed junit tests | hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA |
| | hadoop.hdfs.TestRollingUpgrade |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4348/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/4348 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux bc9880ce7cf2 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24
17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | branch-3.2 / 11e1e017c11a6da0f77bbcfaeeb744c8887117fd |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4348/1/testReport/ |
| Max. process+thread count | 2110 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4348/1/console |
| versions | git=2.17.1 maven=3.6.0 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18249) Fix getUri() in HttpRequest has been deprecated
[
https://issues.apache.org/jira/browse/HADOOP-18249?focusedWorklogId=773688=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773688
]
ASF GitHub Bot logged work on HADOOP-18249:
---
Author: ASF GitHub Bot
Created on: 23/May/22 19:22
Start Date: 23/May/22 19:22
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on PR #4335:
URL: https://github.com/apache/hadoop/pull/4335#issuecomment-1135052951
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 45s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 1s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 69m 17s | | trunk passed |
| +1 :green_heart: | compile | 1m 27s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | compile | 1m 18s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 1m 6s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 26s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 9s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 1m 29s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 3m 25s | | trunk passed |
| +1 :green_heart: | shadedclient | 22m 11s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 14s | | the patch passed |
| +1 :green_heart: | compile | 1m 18s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javac | 1m 18s | |
hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 0 new +
942 unchanged - 15 fixed = 942 total (was 957) |
| +1 :green_heart: | compile | 1m 10s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 1m 10s | |
hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 0 new
+ 921 unchanged - 15 fixed = 921 total (was 936) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 51s | |
hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 29 unchanged - 2
fixed = 29 total (was 31) |
| +1 :green_heart: | mvnsite | 1m 18s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 51s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 1m 20s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 3m 7s | | the patch passed |
| +1 :green_heart: | shadedclient | 21m 43s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 247m 58s | | hadoop-hdfs in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 49s | | The patch does not
generate ASF License warnings. |
| | | 382m 56s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4335/3/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/4335 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 48519d5b0afd 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3
10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / e042521a78fd6d06e4c231c0cc9e6a76f4b481af |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
/usr/lib/jvm/java-8-openjdk-amd64:Private
[GitHub] [hadoop] hadoop-yetus commented on pull request #4335: HADOOP-18249. Fix getUri() in HttpRequest has been deprecated.
hadoop-yetus commented on PR #4335:
URL: https://github.com/apache/hadoop/pull/4335#issuecomment-1135052951
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 45s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 1s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 69m 17s | | trunk passed |
| +1 :green_heart: | compile | 1m 27s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | compile | 1m 18s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 1m 6s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 26s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 9s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 1m 29s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 3m 25s | | trunk passed |
| +1 :green_heart: | shadedclient | 22m 11s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 14s | | the patch passed |
| +1 :green_heart: | compile | 1m 18s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javac | 1m 18s | |
hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 0 new +
942 unchanged - 15 fixed = 942 total (was 957) |
| +1 :green_heart: | compile | 1m 10s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 1m 10s | |
hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 0 new
+ 921 unchanged - 15 fixed = 921 total (was 936) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 51s | |
hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 29 unchanged - 2
fixed = 29 total (was 31) |
| +1 :green_heart: | mvnsite | 1m 18s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 51s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 1m 20s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 3m 7s | | the patch passed |
| +1 :green_heart: | shadedclient | 21m 43s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 247m 58s | | hadoop-hdfs in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 49s | | The patch does not
generate ASF License warnings. |
| | | 382m 56s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4335/3/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/4335 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 48519d5b0afd 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3
10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / e042521a78fd6d06e4c231c0cc9e6a76f4b481af |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4335/3/testReport/ |
| Max. process+thread count | 3866 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4335/3/console |
| versions | git=2.25.1 maven=3.6.3
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773647=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773647
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 18:35
Start Date: 23/May/22 18:35
Worklog Time Spent: 10m
Work Description: steveloughran commented on PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1135009677
> Sorry for disturbing you during the holiday.
you didn't, i was offline. just that you seemed to worrying too much that i
hadn't commented
Issue Time Tracking
---
Worklog Id: (was: 773647)
Time Spent: 3.5h (was: 3h 20m)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
> a related issue will be resolved in HDFS-16590.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #4334: HADOOP-18248. Fix Junit Test Deprecated assertThat.
steveloughran commented on PR #4334: URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1135009677 > Sorry for disturbing you during the holiday. you didn't, i was offline. just that you seemed to worrying too much that i hadn't commented -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] saintstack opened a new pull request, #4348: HDFS-16586. Purge FsDatasetAsyncDiskService threadgroup; it causes BP…
saintstack opened a new pull request, #4348: URL: https://github.com/apache/hadoop/pull/4348 ### Description of PR Remove the ThreadGroup used by executor factories; they are unused and ThreadGroups auto-destroy when their Thread-member count goes to zero. This behavior is incompatible with the configuration we have on the per-volume executor which is set to let all threads die if no use inside the keepalive time. Signed-off-by: Hexiaoqiao [hexiaoq...@apache.org](mailto:hexiaoq...@apache.org) Backport to branch-3.2. ### How was this patch tested? By running a downstream test that was failing when this PR was not in place. ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] saintstack opened a new pull request, #4347: HDFS-16586. Purge FsDatasetAsyncDiskService threadgroup; it causes BP…
saintstack opened a new pull request, #4347: URL: https://github.com/apache/hadoop/pull/4347 …… (#4338) * HDFS-16586. Purge FsDatasetAsyncDiskService threadgroup; it causes BPServiceActor IllegalThreadStateException 'fatal exception and exit' ### Description of PR Remove the ThreadGroup used by executor factories; they are unused and ThreadGroups auto-destroy when their Thread-member count goes to zero. This behavior is incompatible with the configuration we have on the per-volume executor which is set to let all threads die if no use inside the keepalive time. Signed-off-by: Hexiaoqiao Backport to branch-3.3. ### How was this patch tested? By running a downstream test that was failing when this PR was not in place. ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] saintstack opened a new pull request, #4346: HDFS-16586. Purge FsDatasetAsyncDiskService threadgroup
saintstack opened a new pull request, #4346: URL: https://github.com/apache/hadoop/pull/4346 ### Description of PR Remove the ThreadGroup used by executor factories; they are unused and ThreadGroups auto-destroy when their Thread-member count goes to zero. This behavior is incompatible with the configuration we have on the per-volume executor which is set to let all threads die if no use inside the keepalive time. Backport from trunk. ### How was this patch tested? By running a downstream test that was broken w/o this PR ### For code changes: - [x] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] saintstack closed pull request #4346: HDFS-16586. Purge FsDatasetAsyncDiskService threadgroup
saintstack closed pull request #4346: HDFS-16586. Purge FsDatasetAsyncDiskService threadgroup URL: https://github.com/apache/hadoop/pull/4346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] saintstack commented on pull request #4338: HDFS-16586. Purge FsDatasetAsyncDiskService threadgroup; it causes BP…
saintstack commented on PR #4338: URL: https://github.com/apache/hadoop/pull/4338#issuecomment-1134839571 Thank you for the review @Hexiaoqiao Let me put up backports... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] saintstack merged pull request #4338: HDFS-16586. Purge FsDatasetAsyncDiskService threadgroup; it causes BP…
saintstack merged PR #4338: URL: https://github.com/apache/hadoop/pull/4338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Resolved] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
fanshilun resolved HADOOP-18248.
Resolution: Duplicate
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
> a related issue will be resolved in HDFS-16590.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
fanshilun updated HADOOP-18248:
---
Description:
javac will give a warning for compilation, as follows:
org.junit.Assert.assertThat Deprecated. use
org.hamcrest.MatcherAssert.assertThat()
{code:java}
TestIncrementalBrVariations.java:141:4:[deprecation] assertThat(T,Matcher) in Assert has been deprecated {code}
a related issue will be resolved in HDFS-16590.
was:
javac will give a warning for compilation, as follows:
org.junit.Assert.assertThat Deprecated. use
org.hamcrest.MatcherAssert.assertThat()
{code:java}
TestIncrementalBrVariations.java:141:4:[deprecation] assertThat(T,Matcher) in Assert has been deprecated {code}
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
> a related issue will be resolved in HDFS-16590.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18244) Fix Hadoop-Common JavaDoc Error on branch-3.3
[ https://issues.apache.org/jira/browse/HADOOP-18244?focusedWorklogId=773501=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773501 ] ASF GitHub Bot logged work on HADOOP-18244: --- Author: ASF GitHub Bot Created on: 23/May/22 14:05 Start Date: 23/May/22 14:05 Worklog Time Spent: 10m Work Description: slfan1989 commented on PR #4327: URL: https://github.com/apache/hadoop/pull/4327#issuecomment-1134722720 Hi, @steveloughran, please help to review the code, thank you very match! Issue Time Tracking --- Worklog Id: (was: 773501) Time Spent: 50m (was: 40m) > Fix Hadoop-Common JavaDoc Error on branch-3.3 > - > > Key: HADOOP-18244 > URL: https://issues.apache.org/jira/browse/HADOOP-18244 > Project: Hadoop Common > Issue Type: Improvement > Components: common >Affects Versions: 3.3.0, 3.3.1, 3.3.2, 3.3.3 >Reporter: fanshilun >Assignee: fanshilun >Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > Fix Hadoop-Common JavaDoc Error on branch-3.3. -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on pull request #4327: HADOOP-18244. Fix Hadoop-Common JavaDoc Error on branch-3.3
slfan1989 commented on PR #4327: URL: https://github.com/apache/hadoop/pull/4327#issuecomment-1134722720 Hi, @steveloughran, please help to review the code, thank you very match! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] jianghuazhu commented on pull request #4342: HDFS-16588.Backport HDFS-16584 to branch-3.3 and other active old branches.
jianghuazhu commented on PR #4342: URL: https://github.com/apache/hadoop/pull/4342#issuecomment-1134699164 Here are some failing unit tests such as: org.apache.hadoop.hdfs.TestDFSUpgradeFromImage org.apache.hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks org.apache.hadoop.hdfs.TestBlockStoragePolicy It looks like these failures have little to do with the code I submitted. @Hexiaoqiao @tomscut , can you help review this pr? Thank you very much. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-18233) Possible race condition with TemporaryAWSCredentialsProvider
[
https://issues.apache.org/jira/browse/HADOOP-18233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17540963#comment-17540963
]
Steve Loughran commented on HADOOP-18233:
-
going to close as invalid, it's not our code. glad all is good your side.
> Possible race condition with TemporaryAWSCredentialsProvider
>
>
> Key: HADOOP-18233
> URL: https://issues.apache.org/jira/browse/HADOOP-18233
> Project: Hadoop Common
> Issue Type: Bug
> Components: auth, fs/s3
>Affects Versions: 3.3.1
> Environment: spark v3.2.0
> hadoop-aws v3.3.1
> java version 1.8.0_265 via zulu-8
>Reporter: Jason Sleight
>Priority: Major
>
> I'm in the process of upgrading spark+hadoop versions for my workflows and
> observing a weird behavior regression. I'm setting
> {code:java}
> spark.hadoop.fs.s3a.aws.credentials.provider=org.apache.hadoop.fs.s3a.TemporaryAWSCredentialsProvider
> spark.hadoop.fs.s3.impl=org.apache.hadoop.fs.s3a.S3AFileSystem
> spark.sql.catalogImplementation=hive
> spark.hadoop.aws.region=us-west-2
> ...many other things, I think these might be the relevant ones though...{code}
> in Spark config and I'm observing some non-fatal warnings/exceptions (see
> below for some examples). The warnings/exceptions randomly appear for some
> tasks, which causes them to fail, but then when Spark retries the task it
> will succeed. The initial tasks don't always fail either, just sometimes.
> I also found that if I switch to a SimpleAWSCredentials and use static keys,
> then I don't see any issues.
> My old setup was spark v3.0.2 with hadoop-aws v3.2.1 which also does not have
> these warnings/exceptions.
> From reading some other tickets I thought perhaps adding
> {code:java}
> spark.sql.hive.metastore.sharedPrefixes=com.amazonaws {code}
> would help, but it did not.
> Appreciate any suggestions for how to proceed or debug further :)
>
> Example stack traces:
> First one for an s3 read
> {code:java}
> WARN TaskSetManager: Lost task 27.0 in stage 4.0 (TID 29) ( executor
> 13): java.nio.file.AccessDeniedException:
> s3a://bucket/path/to/part.snappy.parquet:
> org.apache.hadoop.fs.s3a.CredentialInitializationException: Provider
> TemporaryAWSCredentialsProvider has no credentials
> at org.apache.hadoop.fs.s3a.S3AUtils.translateException(S3AUtils.java:206)
> at org.apache.hadoop.fs.s3a.S3AUtils.translateException(S3AUtils.java:170)
> at
> org.apache.hadoop.fs.s3a.S3AFileSystem.s3GetFileStatus(S3AFileSystem.java:3289)
> at
> org.apache.hadoop.fs.s3a.S3AFileSystem.innerGetFileStatus(S3AFileSystem.java:3185)
> at
> org.apache.hadoop.fs.s3a.S3AFileSystem.getFileStatus(S3AFileSystem.java:3053)
> at
> org.apache.parquet.hadoop.util.HadoopInputFile.fromPath(HadoopInputFile.java:39)
> at
> org.apache.spark.sql.execution.datasources.parquet.ParquetFooterReader.readFooter(ParquetFooterReader.java:39)
> at
> org.apache.spark.sql.execution.datasources.parquet.ParquetFileFormat.footerFileMetaData$lzycompute$1(ParquetFileFormat.scala:268)
> at
> org.apache.spark.sql.execution.datasources.parquet.ParquetFileFormat.footerFileMetaData$1(ParquetFileFormat.scala:267)
> at
> org.apache.spark.sql.execution.datasources.parquet.ParquetFileFormat.$anonfun$buildReaderWithPartitionValues$2(ParquetFileFormat.scala:270)
> at
> org.apache.spark.sql.execution.datasources.FileScanRDD$$anon$1.org$apache$spark$sql$execution$datasources$FileScanRDD$$anon$$readCurrentFile(FileScanRDD.scala:116)
> at
> org.apache.spark.sql.execution.datasources.FileScanRDD$$anon$1.nextIterator(FileScanRDD.scala:164)
> at
> org.apache.spark.sql.execution.datasources.FileScanRDD$$anon$1.hasNext(FileScanRDD.scala:93)
> at
> org.apache.spark.sql.execution.FileSourceScanExec$$anon$1.hasNext(DataSourceScanExec.scala:522)
> at
> org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage7.columnartorow_nextBatch_0$(Unknown
> Source)
> at
> org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage7.processNext(Unknown
> Source)
> at
> org.apache.spark.sql.execution.BufferedRowIterator.hasNext(BufferedRowIterator.java:43)
> at
> org.apache.spark.sql.execution.WholeStageCodegenExec$$anon$1.hasNext(WholeStageCodegenExec.scala:759)
> at scala.collection.Iterator$$anon$10.hasNext(Iterator.scala:460)
> at
> org.apache.spark.shuffle.sort.BypassMergeSortShuffleWriter.write(BypassMergeSortShuffleWriter.java:140)
> at
> org.apache.spark.shuffle.ShuffleWriteProcessor.write(ShuffleWriteProcessor.scala:59)
> at
> org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:99)
> at
> org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:52)
> at
[jira] [Resolved] (HADOOP-18233) Possible race condition with TemporaryAWSCredentialsProvider
[
https://issues.apache.org/jira/browse/HADOOP-18233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran resolved HADOOP-18233.
-
Resolution: Cannot Reproduce
> Possible race condition with TemporaryAWSCredentialsProvider
>
>
> Key: HADOOP-18233
> URL: https://issues.apache.org/jira/browse/HADOOP-18233
> Project: Hadoop Common
> Issue Type: Bug
> Components: auth, fs/s3
>Affects Versions: 3.3.1
> Environment: spark v3.2.0
> hadoop-aws v3.3.1
> java version 1.8.0_265 via zulu-8
>Reporter: Jason Sleight
>Priority: Major
>
> I'm in the process of upgrading spark+hadoop versions for my workflows and
> observing a weird behavior regression. I'm setting
> {code:java}
> spark.hadoop.fs.s3a.aws.credentials.provider=org.apache.hadoop.fs.s3a.TemporaryAWSCredentialsProvider
> spark.hadoop.fs.s3.impl=org.apache.hadoop.fs.s3a.S3AFileSystem
> spark.sql.catalogImplementation=hive
> spark.hadoop.aws.region=us-west-2
> ...many other things, I think these might be the relevant ones though...{code}
> in Spark config and I'm observing some non-fatal warnings/exceptions (see
> below for some examples). The warnings/exceptions randomly appear for some
> tasks, which causes them to fail, but then when Spark retries the task it
> will succeed. The initial tasks don't always fail either, just sometimes.
> I also found that if I switch to a SimpleAWSCredentials and use static keys,
> then I don't see any issues.
> My old setup was spark v3.0.2 with hadoop-aws v3.2.1 which also does not have
> these warnings/exceptions.
> From reading some other tickets I thought perhaps adding
> {code:java}
> spark.sql.hive.metastore.sharedPrefixes=com.amazonaws {code}
> would help, but it did not.
> Appreciate any suggestions for how to proceed or debug further :)
>
> Example stack traces:
> First one for an s3 read
> {code:java}
> WARN TaskSetManager: Lost task 27.0 in stage 4.0 (TID 29) ( executor
> 13): java.nio.file.AccessDeniedException:
> s3a://bucket/path/to/part.snappy.parquet:
> org.apache.hadoop.fs.s3a.CredentialInitializationException: Provider
> TemporaryAWSCredentialsProvider has no credentials
> at org.apache.hadoop.fs.s3a.S3AUtils.translateException(S3AUtils.java:206)
> at org.apache.hadoop.fs.s3a.S3AUtils.translateException(S3AUtils.java:170)
> at
> org.apache.hadoop.fs.s3a.S3AFileSystem.s3GetFileStatus(S3AFileSystem.java:3289)
> at
> org.apache.hadoop.fs.s3a.S3AFileSystem.innerGetFileStatus(S3AFileSystem.java:3185)
> at
> org.apache.hadoop.fs.s3a.S3AFileSystem.getFileStatus(S3AFileSystem.java:3053)
> at
> org.apache.parquet.hadoop.util.HadoopInputFile.fromPath(HadoopInputFile.java:39)
> at
> org.apache.spark.sql.execution.datasources.parquet.ParquetFooterReader.readFooter(ParquetFooterReader.java:39)
> at
> org.apache.spark.sql.execution.datasources.parquet.ParquetFileFormat.footerFileMetaData$lzycompute$1(ParquetFileFormat.scala:268)
> at
> org.apache.spark.sql.execution.datasources.parquet.ParquetFileFormat.footerFileMetaData$1(ParquetFileFormat.scala:267)
> at
> org.apache.spark.sql.execution.datasources.parquet.ParquetFileFormat.$anonfun$buildReaderWithPartitionValues$2(ParquetFileFormat.scala:270)
> at
> org.apache.spark.sql.execution.datasources.FileScanRDD$$anon$1.org$apache$spark$sql$execution$datasources$FileScanRDD$$anon$$readCurrentFile(FileScanRDD.scala:116)
> at
> org.apache.spark.sql.execution.datasources.FileScanRDD$$anon$1.nextIterator(FileScanRDD.scala:164)
> at
> org.apache.spark.sql.execution.datasources.FileScanRDD$$anon$1.hasNext(FileScanRDD.scala:93)
> at
> org.apache.spark.sql.execution.FileSourceScanExec$$anon$1.hasNext(DataSourceScanExec.scala:522)
> at
> org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage7.columnartorow_nextBatch_0$(Unknown
> Source)
> at
> org.apache.spark.sql.catalyst.expressions.GeneratedClass$GeneratedIteratorForCodegenStage7.processNext(Unknown
> Source)
> at
> org.apache.spark.sql.execution.BufferedRowIterator.hasNext(BufferedRowIterator.java:43)
> at
> org.apache.spark.sql.execution.WholeStageCodegenExec$$anon$1.hasNext(WholeStageCodegenExec.scala:759)
> at scala.collection.Iterator$$anon$10.hasNext(Iterator.scala:460)
> at
> org.apache.spark.shuffle.sort.BypassMergeSortShuffleWriter.write(BypassMergeSortShuffleWriter.java:140)
> at
> org.apache.spark.shuffle.ShuffleWriteProcessor.write(ShuffleWriteProcessor.scala:59)
> at
> org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:99)
> at
> org.apache.spark.scheduler.ShuffleMapTask.runTask(ShuffleMapTask.scala:52)
> at org.apache.spark.scheduler.Task.run(Task.scala:131)
> at
>
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773486=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773486
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 13:38
Start Date: 23/May/22 13:38
Worklog Time Spent: 10m
Work Description: slfan1989 commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879468528
##
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/HadoopTestBase.java:
##
@@ -105,4 +107,8 @@ public static void nameTestThread() {
public void nameThreadToMethod() {
Thread.currentThread().setName("JUnit-" + getMethodName());
}
+
+ public static void assertThat(T actual, Matcher matcher) {
+MatcherAssert.assertThat("", actual, matcher);
+ }
Review Comment:
Thanks, i will fix it.
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsTestWithTimeout.java:
##
@@ -126,4 +128,8 @@ protected boolean validateContent(AzureBlobFileSystem fs,
Path path,
}
+ public static void assertThat(String reason, T actual, Matcher matcher) {
+MatcherAssert.assertThat(reason, actual, matcher);
+ }
Review Comment:
Thanks, i will fix it.
Issue Time Tracking
---
Worklog Id: (was: 773486)
Time Spent: 3h 10m (was: 3h)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4334: HADOOP-18248. Fix Junit Test Deprecated assertThat.
slfan1989 commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879468528
##
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/HadoopTestBase.java:
##
@@ -105,4 +107,8 @@ public static void nameTestThread() {
public void nameThreadToMethod() {
Thread.currentThread().setName("JUnit-" + getMethodName());
}
+
+ public static void assertThat(T actual, Matcher matcher) {
+MatcherAssert.assertThat("", actual, matcher);
+ }
Review Comment:
Thanks, i will fix it.
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsTestWithTimeout.java:
##
@@ -126,4 +128,8 @@ protected boolean validateContent(AzureBlobFileSystem fs,
Path path,
}
+ public static void assertThat(String reason, T actual, Matcher matcher) {
+MatcherAssert.assertThat(reason, actual, matcher);
+ }
Review Comment:
Thanks, i will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773487=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773487
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 13:39
Start Date: 23/May/22 13:39
Worklog Time Spent: 10m
Work Description: slfan1989 closed pull request #4334: HADOOP-18248. Fix
Junit Test Deprecated assertThat.
URL: https://github.com/apache/hadoop/pull/4334
Issue Time Tracking
---
Worklog Id: (was: 773487)
Time Spent: 3h 20m (was: 3h 10m)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 closed pull request #4334: HADOOP-18248. Fix Junit Test Deprecated assertThat.
slfan1989 closed pull request #4334: HADOOP-18248. Fix Junit Test Deprecated assertThat. URL: https://github.com/apache/hadoop/pull/4334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773484=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773484
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 13:38
Start Date: 23/May/22 13:38
Worklog Time Spent: 10m
Work Description: slfan1989 commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879467790
##
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractFSContractTestBase.java:
##
@@ -400,4 +402,12 @@ protected String generateAndLogErrorListing(Path src, Path
dst) throws
}
return destDirLS;
}
+
+ public static void assertThat(T actual, Matcher matcher) {
+assertThat("", actual, matcher);
+ }
+
+ public static void assertThat(String reason, T actual, Matcher matcher) {
+MatcherAssert.assertThat(reason, actual, matcher);
+ }
Review Comment:
Thank you for your suggestion, I will continue to improve the code.
Issue Time Tracking
---
Worklog Id: (was: 773484)
Time Spent: 3h (was: 2h 50m)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran opened a new pull request, #4345: ongoing patches to branch3.3.3
steveloughran opened a new pull request, #4345: URL: https://github.com/apache/hadoop/pull/4345 ### Description of PR ### How was this patch tested? ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4334: HADOOP-18248. Fix Junit Test Deprecated assertThat.
slfan1989 commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879467790
##
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractFSContractTestBase.java:
##
@@ -400,4 +402,12 @@ protected String generateAndLogErrorListing(Path src, Path
dst) throws
}
return destDirLS;
}
+
+ public static void assertThat(T actual, Matcher matcher) {
+assertThat("", actual, matcher);
+ }
+
+ public static void assertThat(String reason, T actual, Matcher matcher) {
+MatcherAssert.assertThat(reason, actual, matcher);
+ }
Review Comment:
Thank you for your suggestion, I will continue to improve the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773483=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773483
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 13:36
Start Date: 23/May/22 13:36
Worklog Time Spent: 10m
Work Description: slfan1989 commented on PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1134690674
> > Hi, @steveloughran please help me to review the code, thank you very
much!
> > lwe have these things called "holidays" and "weekends". do not take the
fact that i didn't review the change personally.
>
> it's mostly an HDFS source change. you need an hdfs jira for that bit of
the patch.
>
> for hadoop common, why not move it to assertj the way we are doing for new
code
Thanks for your suggestion, I will re-submit a HDFS JIRA and make some
adjustments to the code. Sorry for disturbing you
during the holiday.
Issue Time Tracking
---
Worklog Id: (was: 773483)
Time Spent: 2h 50m (was: 2h 40m)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on pull request #4334: HADOOP-18248. Fix Junit Test Deprecated assertThat.
slfan1989 commented on PR #4334: URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1134690674 > > Hi, @steveloughran please help me to review the code, thank you very much! > > lwe have these things called "holidays" and "weekends". do not take the fact that i didn't review the change personally. > > it's mostly an HDFS source change. you need an hdfs jira for that bit of the patch. > > for hadoop common, why not move it to assertj the way we are doing for new code Thanks for your suggestion, I will re-submit a HDFS JIRA and make some adjustments to the code. Sorry for disturbing you during the holiday. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773477=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773477
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 13:25
Start Date: 23/May/22 13:25
Worklog Time Spent: 10m
Work Description: steveloughran commented on PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1134678711
> Hi, @steveloughran please help me to review the code, thank you very much!
lwe have these things called "holidays" and "weekends". do not take the fact
that i didn't review the change personally.
it's mostly an HDFS source change. you need an hdfs jira for that bit of the
patch.
for hadoop common, why not move it to assertj the way we are doing for new
code
Issue Time Tracking
---
Worklog Id: (was: 773477)
Time Spent: 2h 40m (was: 2.5h)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #4334: HADOOP-18248. Fix Junit Test Deprecated assertThat.
steveloughran commented on PR #4334: URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1134678711 > Hi, @steveloughran please help me to review the code, thank you very much! lwe have these things called "holidays" and "weekends". do not take the fact that i didn't review the change personally. it's mostly an HDFS source change. you need an hdfs jira for that bit of the patch. for hadoop common, why not move it to assertj the way we are doing for new code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4342: HDFS-16588.Backport HDFS-16584 to branch-3.3 and other active old branches.
hadoop-yetus commented on PR #4342:
URL: https://github.com/apache/hadoop/pull/4342#issuecomment-1134677171
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 5m 37s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ branch-3.3 Compile Tests _ |
| +1 :green_heart: | mvninstall | 38m 3s | | branch-3.3 passed |
| +1 :green_heart: | compile | 1m 27s | | branch-3.3 passed |
| +1 :green_heart: | checkstyle | 1m 7s | | branch-3.3 passed |
| +1 :green_heart: | mvnsite | 1m 38s | | branch-3.3 passed |
| +1 :green_heart: | javadoc | 1m 44s | | branch-3.3 passed |
| +1 :green_heart: | spotbugs | 3m 44s | | branch-3.3 passed |
| +1 :green_heart: | shadedclient | 28m 48s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 20s | | the patch passed |
| +1 :green_heart: | compile | 1m 14s | | the patch passed |
| +1 :green_heart: | javac | 1m 14s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 48s | | the patch passed |
| +1 :green_heart: | mvnsite | 1m 21s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 26s | | the patch passed |
| +1 :green_heart: | spotbugs | 3m 31s | | the patch passed |
| +1 :green_heart: | shadedclient | 27m 58s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| -1 :x: | unit | 212m 1s |
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4342/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
| hadoop-hdfs in the patch passed. |
| +1 :green_heart: | asflicense | 0m 57s | | The patch does not
generate ASF License warnings. |
| | | 329m 59s | | |
| Reason | Tests |
|---:|:--|
| Failed junit tests | hadoop.hdfs.TestDFSUpgradeFromImage |
| | hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks |
| | hadoop.hdfs.TestBlockStoragePolicy |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4342/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/4342 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 7add28a902ec 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24
17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | branch-3.3 / c7be6e7e03291acc92b8cf96ea0989a08f6e8a83 |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4342/1/testReport/ |
| Max. process+thread count | 2284 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs U:
hadoop-hdfs-project/hadoop-hdfs |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4342/1/console |
| versions | git=2.17.1 maven=3.6.0 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18249) Fix getUri() in HttpRequest has been deprecated
[
https://issues.apache.org/jira/browse/HADOOP-18249?focusedWorklogId=773462=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773462
]
ASF GitHub Bot logged work on HADOOP-18249:
---
Author: ASF GitHub Bot
Created on: 23/May/22 12:51
Start Date: 23/May/22 12:51
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on PR #4335:
URL: https://github.com/apache/hadoop/pull/4335#issuecomment-1134637894
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 43s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 37m 10s | | trunk passed |
| +1 :green_heart: | compile | 1m 30s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | compile | 1m 23s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 1m 6s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 34s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 8s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 1m 27s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 3m 31s | | trunk passed |
| +1 :green_heart: | shadedclient | 22m 2s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 18s | | the patch passed |
| +1 :green_heart: | compile | 1m 17s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javac | 1m 17s | |
hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 0 new +
942 unchanged - 15 fixed = 942 total (was 957) |
| +1 :green_heart: | compile | 1m 11s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 1m 11s | |
hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 0 new
+ 921 unchanged - 15 fixed = 921 total (was 936) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 0m 51s |
[/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4335/2/artifact/out/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt)
| hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 29 unchanged -
2 fixed = 30 total (was 31) |
| +1 :green_heart: | mvnsite | 1m 16s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 50s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 1m 20s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 3m 7s | | the patch passed |
| +1 :green_heart: | shadedclient | 21m 43s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| -1 :x: | unit | 248m 16s |
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4335/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
| hadoop-hdfs in the patch passed. |
| +1 :green_heart: | asflicense | 0m 51s | | The patch does not
generate ASF License warnings. |
| | | 351m 26s | | |
| Reason | Tests |
|---:|:--|
| Failed junit tests |
hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaPlacement |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4335/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/4335 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname |
[GitHub] [hadoop] hadoop-yetus commented on pull request #4335: HADOOP-18249. Fix getUri() in HttpRequest has been deprecated.
hadoop-yetus commented on PR #4335:
URL: https://github.com/apache/hadoop/pull/4335#issuecomment-1134637894
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 43s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 37m 10s | | trunk passed |
| +1 :green_heart: | compile | 1m 30s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | compile | 1m 23s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 1m 6s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 34s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 8s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 1m 27s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 3m 31s | | trunk passed |
| +1 :green_heart: | shadedclient | 22m 2s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 18s | | the patch passed |
| +1 :green_heart: | compile | 1m 17s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javac | 1m 17s | |
hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 generated 0 new +
942 unchanged - 15 fixed = 942 total (was 957) |
| +1 :green_heart: | compile | 1m 11s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 1m 11s | |
hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 generated 0 new
+ 921 unchanged - 15 fixed = 921 total (was 936) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 0m 51s |
[/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4335/2/artifact/out/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt)
| hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 29 unchanged -
2 fixed = 30 total (was 31) |
| +1 :green_heart: | mvnsite | 1m 16s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 50s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 1m 20s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 3m 7s | | the patch passed |
| +1 :green_heart: | shadedclient | 21m 43s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| -1 :x: | unit | 248m 16s |
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4335/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
| hadoop-hdfs in the patch passed. |
| +1 :green_heart: | asflicense | 0m 51s | | The patch does not
generate ASF License warnings. |
| | | 351m 26s | | |
| Reason | Tests |
|---:|:--|
| Failed junit tests |
hadoop.hdfs.server.datanode.fsdataset.impl.TestLazyPersistReplicaPlacement |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4335/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/4335 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 542e1a9e3d5b 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3
10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / deeb9c8100869b0172143df16cf5603ac413f948 |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Private
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773459=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773459
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 12:39
Start Date: 23/May/22 12:39
Worklog Time Spent: 10m
Work Description: dannycjones commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879390284
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsTestWithTimeout.java:
##
@@ -126,4 +128,8 @@ protected boolean validateContent(AzureBlobFileSystem fs,
Path path,
}
+ public static void assertThat(String reason, T actual, Matcher matcher) {
+MatcherAssert.assertThat(reason, actual, matcher);
+ }
Review Comment:
Please add a short JavaDoc explaining why its here and when/if we can remove.
Something like
"Override `assertThat` introduced by extending JUnit `Assertions` in base
test class. If extending `Assertions` is removed, we can elimiate this method
and import directly."
Issue Time Tracking
---
Worklog Id: (was: 773459)
Time Spent: 2.5h (was: 2h 20m)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773458=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773458
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 12:39
Start Date: 23/May/22 12:39
Worklog Time Spent: 10m
Work Description: dannycjones commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879406416
##
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractFSContractTestBase.java:
##
@@ -400,4 +402,12 @@ protected String generateAndLogErrorListing(Path src, Path
dst) throws
}
return destDirLS;
}
+
+ public static void assertThat(T actual, Matcher matcher) {
+assertThat("", actual, matcher);
+ }
+
+ public static void assertThat(String reason, T actual, Matcher matcher) {
+MatcherAssert.assertThat(reason, actual, matcher);
+ }
Review Comment:
similar to another comment: Please add a short JavaDoc explaining why they
are here and when we should remove them.
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsTestWithTimeout.java:
##
@@ -126,4 +128,8 @@ protected boolean validateContent(AzureBlobFileSystem fs,
Path path,
}
+ public static void assertThat(String reason, T actual, Matcher matcher) {
+MatcherAssert.assertThat(reason, actual, matcher);
+ }
Review Comment:
Please add a short JavaDoc explaining why its here.
Something like
"Override `assertThat` introduced by extending JUnit `Assertions` in base
test class. If extending `Assertions` is removed, we can elimiate this method
and import directly."
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/test/java/org/apache/hadoop/yarn/service/TestYarnNativeServices.java:
##
@@ -917,7 +917,8 @@ private void checkEachCompInstancesInOrder(Component
component, String
int i = 0;
for (String s : instances) {
- assertThat(s).isEqualTo(component.getName() + "-" + i);
+ assertThat(s,
+ CoreMatchers.containsString(component.getName() + "-" + i));
Review Comment:
I'm not sure if there's any side effects here, we are changing the test.
Can we stick with equals?
```suggestion
assertThat(s, CoreMatchers.equalTo(component.getName() + "-" + i));
```
##
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/HadoopTestBase.java:
##
@@ -105,4 +107,8 @@ public static void nameTestThread() {
public void nameThreadToMethod() {
Thread.currentThread().setName("JUnit-" + getMethodName());
}
+
+ public static void assertThat(T actual, Matcher matcher) {
+MatcherAssert.assertThat("", actual, matcher);
+ }
Review Comment:
similar to another comment: Please add a short JavaDoc explaining why its
here and when we should remove it.
Issue Time Tracking
---
Worklog Id: (was: 773458)
Time Spent: 2h 20m (was: 2h 10m)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] dannycjones commented on a diff in pull request #4334: HADOOP-18248. Fix Junit Test Deprecated assertThat.
dannycjones commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879406416
##
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractFSContractTestBase.java:
##
@@ -400,4 +402,12 @@ protected String generateAndLogErrorListing(Path src, Path
dst) throws
}
return destDirLS;
}
+
+ public static void assertThat(T actual, Matcher matcher) {
+assertThat("", actual, matcher);
+ }
+
+ public static void assertThat(String reason, T actual, Matcher matcher) {
+MatcherAssert.assertThat(reason, actual, matcher);
+ }
Review Comment:
similar to another comment: Please add a short JavaDoc explaining why they
are here and when we should remove them.
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsTestWithTimeout.java:
##
@@ -126,4 +128,8 @@ protected boolean validateContent(AzureBlobFileSystem fs,
Path path,
}
+ public static void assertThat(String reason, T actual, Matcher matcher) {
+MatcherAssert.assertThat(reason, actual, matcher);
+ }
Review Comment:
Please add a short JavaDoc explaining why its here.
Something like
"Override `assertThat` introduced by extending JUnit `Assertions` in base
test class. If extending `Assertions` is removed, we can elimiate this method
and import directly."
##
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/test/java/org/apache/hadoop/yarn/service/TestYarnNativeServices.java:
##
@@ -917,7 +917,8 @@ private void checkEachCompInstancesInOrder(Component
component, String
int i = 0;
for (String s : instances) {
- assertThat(s).isEqualTo(component.getName() + "-" + i);
+ assertThat(s,
+ CoreMatchers.containsString(component.getName() + "-" + i));
Review Comment:
I'm not sure if there's any side effects here, we are changing the test.
Can we stick with equals?
```suggestion
assertThat(s, CoreMatchers.equalTo(component.getName() + "-" + i));
```
##
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/HadoopTestBase.java:
##
@@ -105,4 +107,8 @@ public static void nameTestThread() {
public void nameThreadToMethod() {
Thread.currentThread().setName("JUnit-" + getMethodName());
}
+
+ public static void assertThat(T actual, Matcher matcher) {
+MatcherAssert.assertThat("", actual, matcher);
+ }
Review Comment:
similar to another comment: Please add a short JavaDoc explaining why its
here and when we should remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] dannycjones commented on a diff in pull request #4334: HADOOP-18248. Fix Junit Test Deprecated assertThat.
dannycjones commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879390284
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/AbstractAbfsTestWithTimeout.java:
##
@@ -126,4 +128,8 @@ protected boolean validateContent(AzureBlobFileSystem fs,
Path path,
}
+ public static void assertThat(String reason, T actual, Matcher matcher) {
+MatcherAssert.assertThat(reason, actual, matcher);
+ }
Review Comment:
Please add a short JavaDoc explaining why its here and when/if we can remove.
Something like
"Override `assertThat` introduced by extending JUnit `Assertions` in base
test class. If extending `Assertions` is removed, we can elimiate this method
and import directly."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18242) ABFS Rename Failure when tracking metadata is in incomplete state
[
https://issues.apache.org/jira/browse/HADOOP-18242?focusedWorklogId=773448=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773448
]
ASF GitHub Bot logged work on HADOOP-18242:
---
Author: ASF GitHub Bot
Created on: 23/May/22 12:06
Start Date: 23/May/22 12:06
Worklog Time Spent: 10m
Work Description: mehakmeet commented on PR #4331:
URL: https://github.com/apache/hadoop/pull/4331#issuecomment-1134588998
> Also, need to check if this is the only error code that corresponds to
this issue, if the tracking metadata is in an incomplete state, can we not see
other 404s too?
@snvijaya please provide some info on this if you could. Thanks.
Issue Time Tracking
---
Worklog Id: (was: 773448)
Time Spent: 40m (was: 0.5h)
> ABFS Rename Failure when tracking metadata is in incomplete state
> -
>
> Key: HADOOP-18242
> URL: https://issues.apache.org/jira/browse/HADOOP-18242
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/azure
>Reporter: Mehakmeet Singh
>Assignee: Mehakmeet Singh
>Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> If a node in the datacenter crashes while processing an operation,
> occasionally it can leave the Storage-internal blob tracking metadata in an
> incomplete state. We expect this to happen occasionally, and so all API’s
> are designed in such a way that if this incomplete state is observed on a
> blob, the situation is resolved before the current operation proceeds.
> However, this incident has exposed a bug specifically with the Rename API,
> where the incomplete state fails to resolve, leading to this incorrect
> failure. As a temporary mitigation, if any other operation is performed on
> this blob – GetBlobProperties, GetBlob, GetFileProperties, SetFileProperties,
> etc – it should resolve the incomplete state, and rename will no longer hit
> this issue.
> StackTrace:
> {code:java}
> 2022-03-22 17:52:19,789 DEBUG [regionserver/euwukwlss-hg50:16020.logRoller]
> services.AbfsClient: HttpRequest:
> 404,RenameDestinationParentPathNotFound,cid=ef5cbf0f-5d4a-4630-8a59-3d559077fc24,rid=35fef164-101f-000b-1b15-3ed81800,sent=0,recv=212,PUT,https://euwqdaotdfdls03.dfs.core.windows.net/eykbssc/apps/hbase/data/oldWALs/euwukwlss-hg50.tdf.qa%252C16020%252C1647949929877.1647967939315?timeout=90
>{code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] mehakmeet commented on pull request #4331: HADOOP-18242. ABFS Rename Failure when tracking metadata is in an incomplete state
mehakmeet commented on PR #4331: URL: https://github.com/apache/hadoop/pull/4331#issuecomment-1134588998 > Also, need to check if this is the only error code that corresponds to this issue, if the tracking metadata is in an incomplete state, can we not see other 404s too? @snvijaya please provide some info on this if you could. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773445=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773445
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 12:02
Start Date: 23/May/22 12:02
Worklog Time Spent: 10m
Work Description: slfan1989 commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879374438
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemFlush.java:
##
@@ -400,7 +400,7 @@ private void validate(InputStream stream, byte[]
writeBuffer, boolean isEqual)
writeBuffer,
readBuffer);
} else {
-assertThat(
+ org.hamcrest.MatcherAssert.assertThat(
Review Comment:
I will fix it.
Issue Time Tracking
---
Worklog Id: (was: 773445)
Time Spent: 2h (was: 1h 50m)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773446=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773446
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 12:02
Start Date: 23/May/22 12:02
Worklog Time Spent: 10m
Work Description: slfan1989 commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879374438
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemFlush.java:
##
@@ -400,7 +400,7 @@ private void validate(InputStream stream, byte[]
writeBuffer, boolean isEqual)
writeBuffer,
readBuffer);
} else {
-assertThat(
+ org.hamcrest.MatcherAssert.assertThat(
Review Comment:
Thank you, I will fix it.
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java:
##
@@ -82,8 +82,13 @@
import static org.apache.hadoop.hdfs.server.namenode.AclTestHelpers.aclEntry;
import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.CoreMatchers.not;
-import static org.junit.Assert.*;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.assertFalse;
Review Comment:
OK, I will fix it.
Issue Time Tracking
---
Worklog Id: (was: 773446)
Time Spent: 2h 10m (was: 2h)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4334: HADOOP-18248. Fix Junit Test Deprecated assertThat.
slfan1989 commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879374438
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemFlush.java:
##
@@ -400,7 +400,7 @@ private void validate(InputStream stream, byte[]
writeBuffer, boolean isEqual)
writeBuffer,
readBuffer);
} else {
-assertThat(
+ org.hamcrest.MatcherAssert.assertThat(
Review Comment:
I will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4334: HADOOP-18248. Fix Junit Test Deprecated assertThat.
slfan1989 commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879374438
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemFlush.java:
##
@@ -400,7 +400,7 @@ private void validate(InputStream stream, byte[]
writeBuffer, boolean isEqual)
writeBuffer,
readBuffer);
} else {
-assertThat(
+ org.hamcrest.MatcherAssert.assertThat(
Review Comment:
Thank you, I will fix it.
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java:
##
@@ -82,8 +82,13 @@
import static org.apache.hadoop.hdfs.server.namenode.AclTestHelpers.aclEntry;
import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.CoreMatchers.not;
-import static org.junit.Assert.*;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.assertFalse;
Review Comment:
OK, I will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4344: HADOOP-18251. Fix failure of extracting JIRA id from commit message in git_jira_fix_version_check.py.
hadoop-yetus commented on PR #4344:
URL: https://github.com/apache/hadoop/pull/4344#issuecomment-113451
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 36s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 14m 40s | | Maven dependency ordering for branch |
| +1 :green_heart: | shadedclient | 21m 31s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 32s | | Maven dependency ordering for patch |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | pylint | 0m 6s | | No new issues. |
| +1 :green_heart: | shadedclient | 19m 11s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 50s | | The patch does not
generate ASF License warnings. |
| | | 59m 21s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4344/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/4344 |
| Optional Tests | dupname asflicense codespell pylint |
| uname | Linux 4a6979d8ec56 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 5bcb6bdc22ae7a19189908eda68eb1ac345bf361 |
| Max. process+thread count | 543 (vs. ulimit of 5500) |
| modules | C: U: |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4344/1/console |
| versions | git=2.25.1 maven=3.6.3 pylint=2.6.0 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18251) Fix failure of extracting JIRA id from commit message in git_jira_fix_version_check.py
[
https://issues.apache.org/jira/browse/HADOOP-18251?focusedWorklogId=773427=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773427
]
ASF GitHub Bot logged work on HADOOP-18251:
---
Author: ASF GitHub Bot
Created on: 23/May/22 11:18
Start Date: 23/May/22 11:18
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on PR #4344:
URL: https://github.com/apache/hadoop/pull/4344#issuecomment-113451
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 36s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 14m 40s | | Maven dependency ordering for branch |
| +1 :green_heart: | shadedclient | 21m 31s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 32s | | Maven dependency ordering for patch |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | pylint | 0m 6s | | No new issues. |
| +1 :green_heart: | shadedclient | 19m 11s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 50s | | The patch does not
generate ASF License warnings. |
| | | 59m 21s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4344/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/4344 |
| Optional Tests | dupname asflicense codespell pylint |
| uname | Linux 4a6979d8ec56 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 5bcb6bdc22ae7a19189908eda68eb1ac345bf361 |
| Max. process+thread count | 543 (vs. ulimit of 5500) |
| modules | C: U: |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4344/1/console |
| versions | git=2.25.1 maven=3.6.3 pylint=2.6.0 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
Issue Time Tracking
---
Worklog Id: (was: 773427)
Time Spent: 20m (was: 10m)
> Fix failure of extracting JIRA id from commit message in
> git_jira_fix_version_check.py
> --
>
> Key: HADOOP-18251
> URL: https://issues.apache.org/jira/browse/HADOOP-18251
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
>Reporter: Masatake Iwasaki
>Assignee: Masatake Iwasaki
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> git_jira_fix_version_check.py is confused by commit message like
> {{"YARN-1151. Ability to configure auxiliary services from HDFS-based JAR
> files."}} which contains both {{YARN-}} and {{{}HDFS-{}}}. The latter
> {{HDFS-}} is unexpectedly picked as JIRA issue id then 404 is thrown on
> accessing invalid URL like
> "https://issues.apache.org/jira/rest/api/2/issue/HDFS-;.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-18250) Fix newInstance() in Class has been deprecated
[ https://issues.apache.org/jira/browse/HADOOP-18250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17540898#comment-17540898 ] Steve Loughran commented on HADOOP-18250: - tag with hadoop version, scope (build?), *and java version*. as it's not deprecated in java8 > Fix newInstance() in Class has been deprecated > -- > > Key: HADOOP-18250 > URL: https://issues.apache.org/jira/browse/HADOOP-18250 > Project: Hadoop Common > Issue Type: Improvement >Reporter: fanshilun >Assignee: fanshilun >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4343: Update ojAlgo to latest version (v51.3.0)
hadoop-yetus commented on PR #4343:
URL: https://github.com/apache/hadoop/pull/4343#issuecomment-1134520874
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 38s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 36m 45s | | trunk passed |
| +1 :green_heart: | compile | 0m 40s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | compile | 0m 39s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | mvnsite | 0m 44s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 48s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 0m 41s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | shadedclient | 60m 30s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 22s | | the patch passed |
| +1 :green_heart: | compile | 0m 22s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javac | 0m 22s | | the patch passed |
| +1 :green_heart: | compile | 0m 21s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 0m 21s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | mvnsite | 0m 24s | | the patch passed |
| +1 :green_heart: | xml | 0m 2s | | The patch has no ill-formed XML
file. |
| +1 :green_heart: | javadoc | 0m 22s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 0m 22s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | shadedclient | 21m 8s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 0m 27s | | hadoop-project in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 46s | | The patch does not
generate ASF License warnings. |
| | | 87m 0s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4343/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/4343 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient codespell xml |
| uname | Linux bbc79b5ceca0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / f18275bd5a4bc7413214429a620aadf359e80a60 |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4343/1/testReport/ |
| Max. process+thread count | 700 (vs. ulimit of 5500) |
| modules | C: hadoop-project U: hadoop-project |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4343/1/console |
| versions | git=2.25.1 maven=3.6.3 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For
[jira] [Reopened] (HADOOP-17992) Disable JIRA plugin for YETUS on Hadoop
[
https://issues.apache.org/jira/browse/HADOOP-17992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Masatake Iwasaki reopened HADOOP-17992:
---
> Disable JIRA plugin for YETUS on Hadoop
> ---
>
> Key: HADOOP-17992
> URL: https://issues.apache.org/jira/browse/HADOOP-17992
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
>Affects Versions: 2.10.2
>Reporter: Gautham Banasandra
>Assignee: Gautham Banasandra
>Priority: Critical
> Labels: pull-request-available
> Fix For: 2.10.2
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I’ve been noticing an issue with Jenkins CI where a file jira-json goes
> missing all of a sudden – jenkins / hadoop-multibranch / PR-3588 / #2
> (apache.org)
> {code}
> [2021-10-27T17:52:58.787Z] Processing:
> https://github.com/apache/hadoop/pull/3588
> [2021-10-27T17:52:58.787Z] GITHUB PR #3588 is being downloaded from
> [2021-10-27T17:52:58.787Z]
> https://api.github.com/repos/apache/hadoop/pulls/3588
> [2021-10-27T17:52:58.787Z] JSON data at Wed Oct 27 17:52:55 UTC 2021
> [2021-10-27T17:52:58.787Z] Patch data at Wed Oct 27 17:52:56 UTC 2021
> [2021-10-27T17:52:58.787Z] Diff data at Wed Oct 27 17:52:56 UTC 2021
> [2021-10-27T17:52:59.814Z] awk: cannot open
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-3588/centos-7/out/jira-json
> (No such file or directory)
> [2021-10-27T17:52:59.814Z] ERROR: https://github.com/apache/hadoop/pull/3588
> issue status is not matched with "Patch Available".
> [2021-10-27T17:52:59.814Z]
> {code}
> This causes the pipeline run to fail. I’ve seen this in my multiple attempts
> to re-run the CI on my PR –
> # After 45 minutes – [jenkins / hadoop-multibranch / PR-3588 / #1
> (apache.org)|https://ci-hadoop.apache.org/blue/organizations/jenkins/hadoop-multibranch/detail/PR-3588/1/pipeline/]
> # After 1 minute – [jenkins / hadoop-multibranch / PR-3588 / #2
> (apache.org)|https://ci-hadoop.apache.org/blue/organizations/jenkins/hadoop-multibranch/detail/PR-3588/2/pipeline/]
> # After 17 minutes – [jenkins / hadoop-multibranch / PR-3588 / #3
> (apache.org)|https://ci-hadoop.apache.org/blue/organizations/jenkins/hadoop-multibranch/detail/PR-3588/3/pipeline/]
> The hadoop-multibranch pipeline doesn't use ASF JIRA, thus, we're disabling
> the *jira* plugin to fix this issue.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Resolved] (HADOOP-17992) Disable JIRA plugin for YETUS on Hadoop
[
https://issues.apache.org/jira/browse/HADOOP-17992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Masatake Iwasaki resolved HADOOP-17992.
---
Resolution: Duplicate
Since the commit log of [#3623|https://github.com/apache/hadoop/pull/3623] is
mentioning HADOOP-17988 instead of HADOOP-17992, I changed the resolution to
"Duplicate" and removed "Fix Version/s" in order to avoid confusing
releasedocmaker.
> Disable JIRA plugin for YETUS on Hadoop
> ---
>
> Key: HADOOP-17992
> URL: https://issues.apache.org/jira/browse/HADOOP-17992
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
>Affects Versions: 2.10.2
>Reporter: Gautham Banasandra
>Assignee: Gautham Banasandra
>Priority: Critical
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I’ve been noticing an issue with Jenkins CI where a file jira-json goes
> missing all of a sudden – jenkins / hadoop-multibranch / PR-3588 / #2
> (apache.org)
> {code}
> [2021-10-27T17:52:58.787Z] Processing:
> https://github.com/apache/hadoop/pull/3588
> [2021-10-27T17:52:58.787Z] GITHUB PR #3588 is being downloaded from
> [2021-10-27T17:52:58.787Z]
> https://api.github.com/repos/apache/hadoop/pulls/3588
> [2021-10-27T17:52:58.787Z] JSON data at Wed Oct 27 17:52:55 UTC 2021
> [2021-10-27T17:52:58.787Z] Patch data at Wed Oct 27 17:52:56 UTC 2021
> [2021-10-27T17:52:58.787Z] Diff data at Wed Oct 27 17:52:56 UTC 2021
> [2021-10-27T17:52:59.814Z] awk: cannot open
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-3588/centos-7/out/jira-json
> (No such file or directory)
> [2021-10-27T17:52:59.814Z] ERROR: https://github.com/apache/hadoop/pull/3588
> issue status is not matched with "Patch Available".
> [2021-10-27T17:52:59.814Z]
> {code}
> This causes the pipeline run to fail. I’ve seen this in my multiple attempts
> to re-run the CI on my PR –
> # After 45 minutes – [jenkins / hadoop-multibranch / PR-3588 / #1
> (apache.org)|https://ci-hadoop.apache.org/blue/organizations/jenkins/hadoop-multibranch/detail/PR-3588/1/pipeline/]
> # After 1 minute – [jenkins / hadoop-multibranch / PR-3588 / #2
> (apache.org)|https://ci-hadoop.apache.org/blue/organizations/jenkins/hadoop-multibranch/detail/PR-3588/2/pipeline/]
> # After 17 minutes – [jenkins / hadoop-multibranch / PR-3588 / #3
> (apache.org)|https://ci-hadoop.apache.org/blue/organizations/jenkins/hadoop-multibranch/detail/PR-3588/3/pipeline/]
> The hadoop-multibranch pipeline doesn't use ASF JIRA, thus, we're disabling
> the *jira* plugin to fix this issue.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-17992) Disable JIRA plugin for YETUS on Hadoop
[
https://issues.apache.org/jira/browse/HADOOP-17992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Masatake Iwasaki updated HADOOP-17992:
--
Fix Version/s: (was: 2.10.2)
> Disable JIRA plugin for YETUS on Hadoop
> ---
>
> Key: HADOOP-17992
> URL: https://issues.apache.org/jira/browse/HADOOP-17992
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
>Affects Versions: 2.10.2
>Reporter: Gautham Banasandra
>Assignee: Gautham Banasandra
>Priority: Critical
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I’ve been noticing an issue with Jenkins CI where a file jira-json goes
> missing all of a sudden – jenkins / hadoop-multibranch / PR-3588 / #2
> (apache.org)
> {code}
> [2021-10-27T17:52:58.787Z] Processing:
> https://github.com/apache/hadoop/pull/3588
> [2021-10-27T17:52:58.787Z] GITHUB PR #3588 is being downloaded from
> [2021-10-27T17:52:58.787Z]
> https://api.github.com/repos/apache/hadoop/pulls/3588
> [2021-10-27T17:52:58.787Z] JSON data at Wed Oct 27 17:52:55 UTC 2021
> [2021-10-27T17:52:58.787Z] Patch data at Wed Oct 27 17:52:56 UTC 2021
> [2021-10-27T17:52:58.787Z] Diff data at Wed Oct 27 17:52:56 UTC 2021
> [2021-10-27T17:52:59.814Z] awk: cannot open
> /home/jenkins/jenkins-home/workspace/hadoop-multibranch_PR-3588/centos-7/out/jira-json
> (No such file or directory)
> [2021-10-27T17:52:59.814Z] ERROR: https://github.com/apache/hadoop/pull/3588
> issue status is not matched with "Patch Available".
> [2021-10-27T17:52:59.814Z]
> {code}
> This causes the pipeline run to fail. I’ve seen this in my multiple attempts
> to re-run the CI on my PR –
> # After 45 minutes – [jenkins / hadoop-multibranch / PR-3588 / #1
> (apache.org)|https://ci-hadoop.apache.org/blue/organizations/jenkins/hadoop-multibranch/detail/PR-3588/1/pipeline/]
> # After 1 minute – [jenkins / hadoop-multibranch / PR-3588 / #2
> (apache.org)|https://ci-hadoop.apache.org/blue/organizations/jenkins/hadoop-multibranch/detail/PR-3588/2/pipeline/]
> # After 17 minutes – [jenkins / hadoop-multibranch / PR-3588 / #3
> (apache.org)|https://ci-hadoop.apache.org/blue/organizations/jenkins/hadoop-multibranch/detail/PR-3588/3/pipeline/]
> The hadoop-multibranch pipeline doesn't use ASF JIRA, thus, we're disabling
> the *jira* plugin to fix this issue.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-16947) Stale record should be remove when MutableRollingAverages generating aggregate data.
[
https://issues.apache.org/jira/browse/HADOOP-16947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Masatake Iwasaki updated HADOOP-16947:
--
Fix Version/s: 2.10.2
> Stale record should be remove when MutableRollingAverages generating
> aggregate data.
>
>
> Key: HADOOP-16947
> URL: https://issues.apache.org/jira/browse/HADOOP-16947
> Project: Hadoop Common
> Issue Type: Bug
>Reporter: Haibin Huang
>Assignee: Haibin Huang
>Priority: Major
> Fix For: 3.3.1, 3.4.0, 2.10.2, 3.2.3
>
> Attachments: HADOOP-16947-001.patch, HADOOP-16947-002.patch,
> HADOOP-16947-003.patch, HADOOP-16947-004.patch, HADOOP-16947-005.patch,
> HADOOP-16947-006.patch, HADOOP-16947-007.patch, HADOOP-16947-008.patch,
> HADOOP-16947-009.patch, HADOOP-16947-010.patch, HADOOP-16947-011.patch,
> HADOOP-16947-012.patch, HADOOP-16947-branch-3.1.001.patch,
> HADOOP-16947-branch-3.2.001.patch, HDFS-14783-001.patch,
> HDFS-14783-002.patch, HDFS-14783-003.patch, HDFS-14783-004.patch,
> HDFS-14783-005.patch
>
>
> SlowPeersReport is generated by the SampleStat between tow dn, so it can
> present on nn's jmx like this:
> {code:java}
> "SlowPeersReport" :[{"SlowNode":"dn2","ReportingNodes":["dn1"]}]
> {code}
> In each period, MutableRollingAverages will do a rollOverAvgs(), it will
> generate a SumAndCount object which is based on SampleStat, and store it in a
> LinkedBlockingDeque, the deque will be used to generate
> SlowPeersReport. And the old member of deque won't be removed until the queue
> is full. However, if dn1 don't send any packet to dn2 in the last of
> 36*300_000 ms, the deque will be filled with an old member, because the
> number of last SampleStat never change.I think these old SampleStats should
> be considered as expired message and ignore them when generating a new
> SlowPeersReport.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] tomscut commented on pull request #4219: HDFS-16557. BootstrapStandby failed because of checking gap for inprogress EditLogInputStream
tomscut commented on PR #4219: URL: https://github.com/apache/hadoop/pull/4219#issuecomment-1134494753 > Thanks @tomscut for your report. Similar with [HDFS-14806](https://issues.apache.org/jira/browse/HDFS-14806) ? Thanks @ZanderXu for your comments. Setting DFS_HA_TAILEDITS_INPROGRESS_KEY to false could solve the problem. But if we correct the logic of judging in-progress EditLogInputStream, it seems more reasonable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-12077) Provide a multi-URI replication Inode for ViewFs
[ https://issues.apache.org/jira/browse/HADOOP-12077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Masatake Iwasaki updated HADOOP-12077: -- Fix Version/s: 2.10.2 (was: 2.10.1) > Provide a multi-URI replication Inode for ViewFs > > > Key: HADOOP-12077 > URL: https://issues.apache.org/jira/browse/HADOOP-12077 > Project: Hadoop Common > Issue Type: New Feature > Components: fs >Reporter: Gera Shegalov >Assignee: Gera Shegalov >Priority: Major > Fix For: 3.0.0-beta1, 2.10.2 > > Attachments: HADOOP-12077.001.patch, HADOOP-12077.002.patch, > HADOOP-12077.003.patch, HADOOP-12077.004.patch, HADOOP-12077.005.patch, > HADOOP-12077.006.patch, HADOOP-12077.007.patch, HADOOP-12077.008.patch, > HADOOP-12077.009.patch, HADOOP-12077.010.patch > > > This JIRA is to provide simple "replication" capabilities for applications > that maintain logically equivalent paths in multiple locations for caching or > failover (e.g., S3 and HDFS). We noticed a simple common HDFS usage pattern > in our applications. They host their data on some logical cluster C. There > are corresponding HDFS clusters in multiple datacenters. When the application > runs in DC1, it prefers to read from C in DC1, and the applications prefers > to failover to C in DC2 if the application is migrated to DC2 or when C in > DC1 is unavailable. New application data versions are created > periodically/relatively infrequently. > In order to address many common scenarios in a general fashion, and to avoid > unnecessary code duplication, we implement this functionality in ViewFs (our > default FileSystem spanning all clusters in all datacenters) in a project > code-named Nfly (N as in N datacenters). Currently each ViewFs Inode points > to a single URI via ChRootedFileSystem. Consequently, we introduce a new type > of links that points to a list of URIs that are each going to be wrapped in > ChRootedFileSystem. A typical usage: > /nfly/C/user->/DC1/C/user,/DC2/C/user,... This collection of > ChRootedFileSystem instances is fronted by the Nfly filesystem object that is > actually used for the mount point/Inode. Nfly filesystems backs a single > logical path /nfly/C/user//path by multiple physical paths. > Nfly filesystem supports setting minReplication. As long as the number of > URIs on which an update has succeeded is greater than or equal to > minReplication exceptions are only logged but not thrown. Each update > operation is currently executed serially (client-bandwidth driven parallelism > will be added later). > A file create/write: > # Creates a temporary invisible _nfly_tmp_file in the intended chrooted > filesystem. > # Returns a FSDataOutputStream that wraps output streams returned by 1 > # All writes are forwarded to each output stream. > # On close of stream created by 2, all n streams are closed, and the files > are renamed from _nfly_tmp_file to file. All files receive the same mtime > corresponding to the client system time as of beginning of this step. > # If at least minReplication destinations has gone through steps 1-4 without > failures the transaction is considered logically committed, otherwise a > best-effort attempt of cleaning up the temporary files is attempted. > As for reads, we support a notion of locality similar to HDFS /DC/rack/node. > We sort Inode URIs using NetworkTopology by their authorities. These are > typically host names in simple HDFS URIs. If the authority is missing as is > the case with the local file:/// the local host name is assumed > InetAddress.getLocalHost(). This makes sure that the local file system is > always the closest one to the reader in this approach. For our Hadoop 2 hdfs > URIs that are based on nameservice ids instead of hostnames it is very easy > to adjust the topology script since our nameservice ids already contain the > datacenter. As for rack and node we can simply output any string such as > /DC/rack-nsid/node-nsid, since we only care about datacenter-locality for > such filesystem clients. > There are 2 policies/additions to the read call path that makes it more > expensive, but improve user experience: > - readMostRecent - when this policy is enabled, Nfly first checks mtime for > the path under all URIs, sorts them from most recent to least recent. Nfly > then sorts the set of most recent URIs topologically in the same manner as > described above. > - repairOnRead - when readMostRecent is enabled Nfly already has to RPC all > underlying destinations. With repairOnRead, Nfly filesystem would > additionally attempt to refresh destinations with the path missing or a stale > version of the path using the nearest available most recent destination. -- This message was sent by
[jira] [Updated] (HADOOP-18251) Fix failure of extracting JIRA id from commit message in git_jira_fix_version_check.py
[
https://issues.apache.org/jira/browse/HADOOP-18251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Masatake Iwasaki updated HADOOP-18251:
--
Status: Patch Available (was: Open)
> Fix failure of extracting JIRA id from commit message in
> git_jira_fix_version_check.py
> --
>
> Key: HADOOP-18251
> URL: https://issues.apache.org/jira/browse/HADOOP-18251
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
>Reporter: Masatake Iwasaki
>Assignee: Masatake Iwasaki
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> git_jira_fix_version_check.py is confused by commit message like
> {{"YARN-1151. Ability to configure auxiliary services from HDFS-based JAR
> files."}} which contains both {{YARN-}} and {{{}HDFS-{}}}. The latter
> {{HDFS-}} is unexpectedly picked as JIRA issue id then 404 is thrown on
> accessing invalid URL like
> "https://issues.apache.org/jira/rest/api/2/issue/HDFS-;.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18251) Fix failure of extracting JIRA id from commit message in git_jira_fix_version_check.py
[
https://issues.apache.org/jira/browse/HADOOP-18251?focusedWorklogId=773409=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773409
]
ASF GitHub Bot logged work on HADOOP-18251:
---
Author: ASF GitHub Bot
Created on: 23/May/22 10:17
Start Date: 23/May/22 10:17
Worklog Time Spent: 10m
Work Description: iwasakims opened a new pull request, #4344:
URL: https://github.com/apache/hadoop/pull/4344
https://issues.apache.org/jira/browse/HADOOP-18251
git_jira_fix_version_check.py is confused by commit message like "YARN-1151.
Ability to configure auxiliary services from HDFS-based JAR files." which
contains both {{YARN-}} and {{HDFS-}}. The latter {{HDFS-}} is unexpectedly
picked as JIRA issue id then 404 is throwed on acceccing invalid URL like
"https://issues.apache.org/jira/rest/api/2/issue/HDFS-;.
```
Traceback (most recent call last):
File
"/home/centos/srcs/hadoop/dev-support/git-jira-validation/git_jira_fix_version_check.py",
line 87, in
issue = jira.issue(ACTUAL_PROJECT_JIRA + JIRA_NUM)
File "/home/centos/venv/lib64/python3.6/site-packages/jira/client.py",
line 1404, in issue
issue.find(id, params=params)
File "/home/centos/venv/lib64/python3.6/site-packages/jira/resources.py",
line 288, in find
self._load(url, params=params)
File "/home/centos/venv/lib64/python3.6/site-packages/jira/resources.py",
line 458, in _load
r = self._session.get(url, headers=headers, params=params)
File
"/home/centos/venv/lib64/python3.6/site-packages/jira/resilientsession.py",
line 195, in get
return self.__verb("GET", str(url), **kwargs)
File
"/home/centos/venv/lib64/python3.6/site-packages/jira/resilientsession.py",
line 189, in __verb
raise_on_error(response, verb=verb, **kwargs)
File
"/home/centos/venv/lib64/python3.6/site-packages/jira/resilientsession.py",
line 70, in raise_on_error
**kwargs,
jira.exceptions.JIRAError: JiraError HTTP 404 url:
https://issues.apache.org/jira/rest/api/2/issue/HDFS-
text: Issue Does Not Exist
```
If commit message contains multiple match on
'HADOOP-|HDFS-|YARN-|MAPREDUCE-', choosing the first one should be the fix.
Issue Time Tracking
---
Worklog Id: (was: 773409)
Remaining Estimate: 0h
Time Spent: 10m
> Fix failure of extracting JIRA id from commit message in
> git_jira_fix_version_check.py
> --
>
> Key: HADOOP-18251
> URL: https://issues.apache.org/jira/browse/HADOOP-18251
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
>Reporter: Masatake Iwasaki
>Assignee: Masatake Iwasaki
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> git_jira_fix_version_check.py is confused by commit message like
> {{"YARN-1151. Ability to configure auxiliary services from HDFS-based JAR
> files."}} which contains both {{YARN-}} and {{{}HDFS-{}}}. The latter
> {{HDFS-}} is unexpectedly picked as JIRA issue id then 404 is thrown on
> accessing invalid URL like
> "https://issues.apache.org/jira/rest/api/2/issue/HDFS-;.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-18251) Fix failure of extracting JIRA id from commit message in git_jira_fix_version_check.py
[
https://issues.apache.org/jira/browse/HADOOP-18251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated HADOOP-18251:
Labels: pull-request-available (was: )
> Fix failure of extracting JIRA id from commit message in
> git_jira_fix_version_check.py
> --
>
> Key: HADOOP-18251
> URL: https://issues.apache.org/jira/browse/HADOOP-18251
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
>Reporter: Masatake Iwasaki
>Assignee: Masatake Iwasaki
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> git_jira_fix_version_check.py is confused by commit message like
> {{"YARN-1151. Ability to configure auxiliary services from HDFS-based JAR
> files."}} which contains both {{YARN-}} and {{{}HDFS-{}}}. The latter
> {{HDFS-}} is unexpectedly picked as JIRA issue id then 404 is thrown on
> accessing invalid URL like
> "https://issues.apache.org/jira/rest/api/2/issue/HDFS-;.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] iwasakims opened a new pull request, #4344: HADOOP-18251. Fix failure of extracting JIRA id from commit message in git_jira_fix_version_check.py.
iwasakims opened a new pull request, #4344:
URL: https://github.com/apache/hadoop/pull/4344
https://issues.apache.org/jira/browse/HADOOP-18251
git_jira_fix_version_check.py is confused by commit message like "YARN-1151.
Ability to configure auxiliary services from HDFS-based JAR files." which
contains both {{YARN-}} and {{HDFS-}}. The latter {{HDFS-}} is unexpectedly
picked as JIRA issue id then 404 is throwed on acceccing invalid URL like
"https://issues.apache.org/jira/rest/api/2/issue/HDFS-;.
```
Traceback (most recent call last):
File
"/home/centos/srcs/hadoop/dev-support/git-jira-validation/git_jira_fix_version_check.py",
line 87, in
issue = jira.issue(ACTUAL_PROJECT_JIRA + JIRA_NUM)
File "/home/centos/venv/lib64/python3.6/site-packages/jira/client.py",
line 1404, in issue
issue.find(id, params=params)
File "/home/centos/venv/lib64/python3.6/site-packages/jira/resources.py",
line 288, in find
self._load(url, params=params)
File "/home/centos/venv/lib64/python3.6/site-packages/jira/resources.py",
line 458, in _load
r = self._session.get(url, headers=headers, params=params)
File
"/home/centos/venv/lib64/python3.6/site-packages/jira/resilientsession.py",
line 195, in get
return self.__verb("GET", str(url), **kwargs)
File
"/home/centos/venv/lib64/python3.6/site-packages/jira/resilientsession.py",
line 189, in __verb
raise_on_error(response, verb=verb, **kwargs)
File
"/home/centos/venv/lib64/python3.6/site-packages/jira/resilientsession.py",
line 70, in raise_on_error
**kwargs,
jira.exceptions.JIRAError: JiraError HTTP 404 url:
https://issues.apache.org/jira/rest/api/2/issue/HDFS-
text: Issue Does Not Exist
```
If commit message contains multiple match on
'HADOOP-|HDFS-|YARN-|MAPREDUCE-', choosing the first one should be the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Commented] (HADOOP-18251) Fix failure of extracting JIRA id from commit message in git_jira_fix_version_check.py
[
https://issues.apache.org/jira/browse/HADOOP-18251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17540875#comment-17540875
]
Masatake Iwasaki commented on HADOOP-18251:
---
{noformat}
Traceback (most recent call last):
File
"/home/centos/srcs/hadoop/dev-support/git-jira-validation/git_jira_fix_version_check.py",
line 87, in
issue = jira.issue(ACTUAL_PROJECT_JIRA + JIRA_NUM)
File "/home/centos/venv/lib64/python3.6/site-packages/jira/client.py", line
1404, in issue
issue.find(id, params=params)
File "/home/centos/venv/lib64/python3.6/site-packages/jira/resources.py",
line 288, in find
self._load(url, params=params)
File "/home/centos/venv/lib64/python3.6/site-packages/jira/resources.py",
line 458, in _load
r = self._session.get(url, headers=headers, params=params)
File
"/home/centos/venv/lib64/python3.6/site-packages/jira/resilientsession.py",
line 195, in get
return self.__verb("GET", str(url), **kwargs)
File
"/home/centos/venv/lib64/python3.6/site-packages/jira/resilientsession.py",
line 189, in __verb
raise_on_error(response, verb=verb, **kwargs)
File
"/home/centos/venv/lib64/python3.6/site-packages/jira/resilientsession.py",
line 70, in raise_on_error
**kwargs,
jira.exceptions.JIRAError: JiraError HTTP 404 url:
https://issues.apache.org/jira/rest/api/2/issue/HDFS-
text: Issue Does Not Exist
{noformat}
> Fix failure of extracting JIRA id from commit message in
> git_jira_fix_version_check.py
> --
>
> Key: HADOOP-18251
> URL: https://issues.apache.org/jira/browse/HADOOP-18251
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
>Reporter: Masatake Iwasaki
>Assignee: Masatake Iwasaki
>Priority: Minor
>
> git_jira_fix_version_check.py is confused by commit message like
> {{"YARN-1151. Ability to configure auxiliary services from HDFS-based JAR
> files."}} which contains both {{YARN-}} and {{{}HDFS-{}}}. The latter
> {{HDFS-}} is unexpectedly picked as JIRA issue id then 404 is thrown on
> accessing invalid URL like
> "https://issues.apache.org/jira/rest/api/2/issue/HDFS-;.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] apete opened a new pull request, #4343: Update ojAlgo to latest version (v51.3.0)
apete opened a new pull request, #4343: URL: https://github.com/apache/hadoop/pull/4343 ### Description of PR You're using a very old version of ojAlgo, and there has been significant improvements to the solvers over the years. ### How was this patch tested? 1. Code compiles without any changes 2. The unit test works ### For code changes: - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773371=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773371
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 09:09
Start Date: 23/May/22 09:09
Worklog Time Spent: 10m
Work Description: slfan1989 commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879203139
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemFlush.java:
##
@@ -418,7 +418,7 @@ private void validate(FileSystem fs, Path path, byte[]
writeBuffer, boolean isEq
assertArrayEquals(
String.format("Bytes read do not match bytes written to %1$s",
filePath), writeBuffer, readBuffer);
} else {
-assertThat(
+ org.hamcrest.MatcherAssert.assertThat(
Review Comment:
Hi, @dannycjones ,Thank you very much for your help reviewing the code, I
will fix it.
Issue Time Tracking
---
Worklog Id: (was: 773371)
Time Spent: 1h 50m (was: 1h 40m)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on a diff in pull request #4334: HADOOP-18248. Fix Junit Test Deprecated assertThat.
slfan1989 commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879203139
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemFlush.java:
##
@@ -418,7 +418,7 @@ private void validate(FileSystem fs, Path path, byte[]
writeBuffer, boolean isEq
assertArrayEquals(
String.format("Bytes read do not match bytes written to %1$s",
filePath), writeBuffer, readBuffer);
} else {
-assertThat(
+ org.hamcrest.MatcherAssert.assertThat(
Review Comment:
Hi, @dannycjones ,Thank you very much for your help reviewing the code, I
will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Created] (HADOOP-18251) Fix failure of extracting JIRA id from commit message in git_jira_fix_version_check.py
Masatake Iwasaki created HADOOP-18251:
-
Summary: Fix failure of extracting JIRA id from commit message in
git_jira_fix_version_check.py
Key: HADOOP-18251
URL: https://issues.apache.org/jira/browse/HADOOP-18251
Project: Hadoop Common
Issue Type: Bug
Components: build
Reporter: Masatake Iwasaki
Assignee: Masatake Iwasaki
git_jira_fix_version_check.py is confused by commit message like {{"YARN-1151.
Ability to configure auxiliary services from HDFS-based JAR files."}} which
contains both {{YARN-}} and {{{}HDFS-{}}}. The latter {{HDFS-}} is unexpectedly
picked as JIRA issue id then 404 is thrown on accessing invalid URL like
"https://issues.apache.org/jira/rest/api/2/issue/HDFS-;.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773350=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773350
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 08:39
Start Date: 23/May/22 08:39
Worklog Time Spent: 10m
Work Description: dannycjones commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879160238
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemFlush.java:
##
@@ -400,7 +400,7 @@ private void validate(InputStream stream, byte[]
writeBuffer, boolean isEqual)
writeBuffer,
readBuffer);
} else {
-assertThat(
+ org.hamcrest.MatcherAssert.assertThat(
Review Comment:
Indentation here looks off, I think we want to keep the original indentation.
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemFlush.java:
##
@@ -418,7 +418,7 @@ private void validate(FileSystem fs, Path path, byte[]
writeBuffer, boolean isEq
assertArrayEquals(
String.format("Bytes read do not match bytes written to %1$s",
filePath), writeBuffer, readBuffer);
} else {
-assertThat(
+ org.hamcrest.MatcherAssert.assertThat(
Review Comment:
Indentation here looks off, I think we want to keep the original indentation.
Issue Time Tracking
---
Worklog Id: (was: 773350)
Time Spent: 1h 40m (was: 1.5h)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] dannycjones commented on a diff in pull request #4334: HADOOP-18248. Fix Junit Test Deprecated assertThat.
dannycjones commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879160238
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemFlush.java:
##
@@ -400,7 +400,7 @@ private void validate(InputStream stream, byte[]
writeBuffer, boolean isEqual)
writeBuffer,
readBuffer);
} else {
-assertThat(
+ org.hamcrest.MatcherAssert.assertThat(
Review Comment:
Indentation here looks off, I think we want to keep the original indentation.
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemFlush.java:
##
@@ -418,7 +418,7 @@ private void validate(FileSystem fs, Path path, byte[]
writeBuffer, boolean isEq
assertArrayEquals(
String.format("Bytes read do not match bytes written to %1$s",
filePath), writeBuffer, readBuffer);
} else {
-assertThat(
+ org.hamcrest.MatcherAssert.assertThat(
Review Comment:
Indentation here looks off, I think we want to keep the original indentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773347=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773347
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 08:37
Start Date: 23/May/22 08:37
Worklog Time Spent: 10m
Work Description: dannycjones commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879160238
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemFlush.java:
##
@@ -400,7 +400,7 @@ private void validate(InputStream stream, byte[]
writeBuffer, boolean isEqual)
writeBuffer,
readBuffer);
} else {
-assertThat(
+ org.hamcrest.MatcherAssert.assertThat(
Review Comment:
Indentation here looks off, I think we want to keep the original.
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java:
##
@@ -82,8 +82,13 @@
import static org.apache.hadoop.hdfs.server.namenode.AclTestHelpers.aclEntry;
import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.CoreMatchers.not;
-import static org.junit.Assert.*;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.assertFalse;
Review Comment:
Please move these below the `org.hamcrest` import.
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemFlush.java:
##
@@ -418,7 +418,7 @@ private void validate(FileSystem fs, Path path, byte[]
writeBuffer, boolean isEq
assertArrayEquals(
String.format("Bytes read do not match bytes written to %1$s",
filePath), writeBuffer, readBuffer);
} else {
-assertThat(
+ org.hamcrest.MatcherAssert.assertThat(
Review Comment:
Indentation here looks off, I think we want to keep the original.
Issue Time Tracking
---
Worklog Id: (was: 773347)
Time Spent: 1.5h (was: 1h 20m)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] dannycjones commented on a diff in pull request #4334: HADOOP-18248. Fix Junit Test Deprecated assertThat.
dannycjones commented on code in PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#discussion_r879160238
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemFlush.java:
##
@@ -400,7 +400,7 @@ private void validate(InputStream stream, byte[]
writeBuffer, boolean isEqual)
writeBuffer,
readBuffer);
} else {
-assertThat(
+ org.hamcrest.MatcherAssert.assertThat(
Review Comment:
Indentation here looks off, I think we want to keep the original.
##
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java:
##
@@ -82,8 +82,13 @@
import static org.apache.hadoop.hdfs.server.namenode.AclTestHelpers.aclEntry;
import static org.hamcrest.CoreMatchers.is;
import static org.hamcrest.CoreMatchers.not;
-import static org.junit.Assert.*;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.assertFalse;
Review Comment:
Please move these below the `org.hamcrest` import.
##
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemFlush.java:
##
@@ -418,7 +418,7 @@ private void validate(FileSystem fs, Path path, byte[]
writeBuffer, boolean isEq
assertArrayEquals(
String.format("Bytes read do not match bytes written to %1$s",
filePath), writeBuffer, readBuffer);
} else {
-assertThat(
+ org.hamcrest.MatcherAssert.assertThat(
Review Comment:
Indentation here looks off, I think we want to keep the original.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #4341: YARN-10487. Support getQueueUserAcls, listReservations, getApplicationAttempts, getContainerReport, getContainers, getResourceTypeInfo A
hadoop-yetus commented on PR #4341:
URL: https://github.com/apache/hadoop/pull/4341#issuecomment-1134352642
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 57s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 39m 37s | | trunk passed |
| +1 :green_heart: | compile | 0m 40s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | compile | 0m 37s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 0m 38s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 43s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 46s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 0m 35s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 1m 9s | | trunk passed |
| +1 :green_heart: | shadedclient | 23m 34s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 26s | | the patch passed |
| +1 :green_heart: | compile | 0m 28s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javac | 0m 28s | | the patch passed |
| +1 :green_heart: | compile | 0m 25s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 0m 25s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 18s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 28s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 24s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 0m 22s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 0m 53s | | the patch passed |
| +1 :green_heart: | shadedclient | 23m 3s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| -1 :x: | unit | 2m 51s |
[/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4341/1/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-router.txt)
| hadoop-yarn-server-router in the patch passed. |
| +1 :green_heart: | asflicense | 0m 42s | | The patch does not
generate ASF License warnings. |
| | | 101m 13s | | |
| Reason | Tests |
|---:|:--|
| Failed junit tests | hadoop.yarn.server.router.TestRouterMetrics |
| | hadoop.yarn.server.router.clientrm.TestFederationClientInterceptor |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4341/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/4341 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux f52c719b0782 4.15.0-166-generic #174-Ubuntu SMP Wed Dec 8
19:07:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 3a5fb503f6f2186adf6bf02dcc74ba1fb1ebd4a6 |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4341/1/testReport/ |
| Max. process+thread count | 1007 (vs. ulimit of 5500) |
| modules | C:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router |
| Console output |
[GitHub] [hadoop] jianghuazhu opened a new pull request, #4342: HDFS-16588.Backport HDFS-16584 to branch-3.3 and other active old branches.
jianghuazhu opened a new pull request, #4342: URL: https://github.com/apache/hadoop/pull/4342 ### Description of PR This issue has been dealt with in trunk and needs to be backported again to branch 3.3 or another active branch. This is the purpose of this pr. Details: HDFS-16588 ### How was this patch tested? This can be based on the tests of branch-3.3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-18249) Fix getUri() in HttpRequest has been deprecated
[
https://issues.apache.org/jira/browse/HADOOP-18249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
fanshilun updated HADOOP-18249:
---
Description:
When reading the code, I found that the method used has been deprecated due to
the upgrade of the netty component. The main methods are as follows:
io.netty.handler.codec.http#HttpRequest
@Deprecated
HttpMethod getMethod();
Deprecated. Use method() instead.
@Deprecated
String getUri()
Deprecated. Use uri() instead.
io.netty.handler.codec.http#DefaultHttpResponse
@Deprecated
public HttpResponseStatus getStatus()
{ return this.status(); }
Deprecated. Use status() instead.
WebHdfsHandler.java:125:35:[deprecation] getUri() in HttpRequest has been
deprecated
HostRestrictingAuthorizationFilterHandler.java:200:27:[deprecation] getUri() in
HttpRequest has been deprecated
was:
When reading the code, I found that the method used has been deprecated due to
the upgrade of the netty component. The main methods are as follows:
io.netty.handler.codec.http#HttpRequest
@Deprecated
HttpMethod getMethod();
Deprecated. Use method() instead.
@Deprecated
String getUri()
Deprecated. Use uri() instead.
io.netty.handler.codec.http#DefaultHttpResponse
@Deprecated
public HttpResponseStatus getStatus() {
return this.status();
}
Deprecated. Use status() instead.
WebHdfsHandler.java:125:35:[deprecation] getUri() in HttpRequest has been
deprecated
HostRestrictingAuthorizationFilterHandler.java:200:27:[deprecation] getUri() in
HttpRequest has been deprecated
> Fix getUri() in HttpRequest has been deprecated
> ---
>
> Key: HADOOP-18249
> URL: https://issues.apache.org/jira/browse/HADOOP-18249
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Attachments: getUri() deprecated -1.png
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When reading the code, I found that the method used has been deprecated due
> to the upgrade of the netty component. The main methods are as follows:
> io.netty.handler.codec.http#HttpRequest
> @Deprecated
> HttpMethod getMethod();
> Deprecated. Use method() instead.
> @Deprecated
> String getUri()
> Deprecated. Use uri() instead.
> io.netty.handler.codec.http#DefaultHttpResponse
> @Deprecated
> public HttpResponseStatus getStatus()
> { return this.status(); }
> Deprecated. Use status() instead.
>
> WebHdfsHandler.java:125:35:[deprecation] getUri() in HttpRequest has been
> deprecated
> HostRestrictingAuthorizationFilterHandler.java:200:27:[deprecation] getUri()
> in HttpRequest has been deprecated
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Updated] (HADOOP-18249) Fix getUri() in HttpRequest has been deprecated
[
https://issues.apache.org/jira/browse/HADOOP-18249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
fanshilun updated HADOOP-18249:
---
Description:
When reading the code, I found that the method used has been deprecated due to
the upgrade of the netty component. The main methods are as follows:
io.netty.handler.codec.http#HttpRequest
@Deprecated
HttpMethod getMethod();
Deprecated. Use method() instead.
@Deprecated
String getUri()
Deprecated. Use uri() instead.
io.netty.handler.codec.http#DefaultHttpResponse
@Deprecated
public HttpResponseStatus getStatus() {
return this.status();
}
Deprecated. Use status() instead.
WebHdfsHandler.java:125:35:[deprecation] getUri() in HttpRequest has been
deprecated
HostRestrictingAuthorizationFilterHandler.java:200:27:[deprecation] getUri() in
HttpRequest has been deprecated
was:
WebHdfsHandler.java:125:35:[deprecation] getUri() in HttpRequest has been
deprecated
HostRestrictingAuthorizationFilterHandler.java:200:27:[deprecation] getUri() in
HttpRequest has been deprecated
> Fix getUri() in HttpRequest has been deprecated
> ---
>
> Key: HADOOP-18249
> URL: https://issues.apache.org/jira/browse/HADOOP-18249
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Attachments: getUri() deprecated -1.png
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When reading the code, I found that the method used has been deprecated due
> to the upgrade of the netty component. The main methods are as follows:
> io.netty.handler.codec.http#HttpRequest
> @Deprecated
> HttpMethod getMethod();
> Deprecated. Use method() instead.
> @Deprecated
> String getUri()
> Deprecated. Use uri() instead.
> io.netty.handler.codec.http#DefaultHttpResponse
> @Deprecated
> public HttpResponseStatus getStatus() {
> return this.status();
> }
> Deprecated. Use status() instead.
>
> WebHdfsHandler.java:125:35:[deprecation] getUri() in HttpRequest has been
> deprecated
> HostRestrictingAuthorizationFilterHandler.java:200:27:[deprecation] getUri()
> in HttpRequest has been deprecated
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] zhengchenyu commented on pull request #4314: YARN-11153. Make proxy server support yarn federation.
zhengchenyu commented on PR #4314: URL: https://github.com/apache/hadoop/pull/4314#issuecomment-1134269618 @goiri Can you help me review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18248) Fix Junit Test Deprecated assertThat
[
https://issues.apache.org/jira/browse/HADOOP-18248?focusedWorklogId=773305=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773305
]
ASF GitHub Bot logged work on HADOOP-18248:
---
Author: ASF GitHub Bot
Created on: 23/May/22 07:02
Start Date: 23/May/22 07:02
Worklog Time Spent: 10m
Work Description: slfan1989 commented on PR #4334:
URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1134261746
Hi, @steveloughran please help me to review the code, thank you very much!
Issue Time Tracking
---
Worklog Id: (was: 773305)
Time Spent: 1h 20m (was: 1h 10m)
> Fix Junit Test Deprecated assertThat
>
>
> Key: HADOOP-18248
> URL: https://issues.apache.org/jira/browse/HADOOP-18248
> Project: Hadoop Common
> Issue Type: Improvement
>Affects Versions: 3.4.0
>Reporter: fanshilun
>Assignee: fanshilun
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> javac will give a warning for compilation, as follows:
> org.junit.Assert.assertThat Deprecated. use
> org.hamcrest.MatcherAssert.assertThat()
> {code:java}
> TestIncrementalBrVariations.java:141:4:[deprecation]
> assertThat(T,Matcher) in Assert has been deprecated {code}
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
-
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 commented on pull request #4334: HADOOP-18248. Fix Junit Test Deprecated assertThat.
slfan1989 commented on PR #4334: URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1134261746 Hi, @steveloughran please help me to review the code, thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[GitHub] [hadoop] slfan1989 opened a new pull request, #4341: YARN-10487. Support getQueueUserAcls, listReservations, getApplicationAttempts, getContainerReport, getContainers, getResourceTypeInfo API
slfan1989 opened a new pull request, #4341: URL: https://github.com/apache/hadoop/pull/4341 JIRA: YARN-10487. Support getQueueUserAcls, listReservations, getApplicationAttempts, getContainerReport, getContainers, getResourceTypeInfo API's for Federation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
