[jira] [Work logged] (HADOOP-18357) Retarget solution file to VS2019
[ https://issues.apache.org/jira/browse/HADOOP-18357?focusedWorklogId=796050=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796050 ] ASF GitHub Bot logged work on HADOOP-18357: --- Author: ASF GitHub Bot Created on: 28/Jul/22 12:08 Start Date: 28/Jul/22 12:08 Worklog Time Spent: 10m Work Description: GauthamBanasandra commented on PR #4616: URL: https://github.com/apache/hadoop/pull/4616#issuecomment-1198055884 The vcxproj and solution files automatically get retargeted due to -https://github.com/apache/hadoop/blob/95a85875d0038a73f7e6c2cdb6efdc5132d63beb/hadoop-common-project/hadoop-common/pom.xml#L844-L923 I'm able to build the trunk on Windows without this PR -  Closing this PR since these changes are not needed. Issue Time Tracking --- Worklog Id: (was: 796050) Time Spent: 2h 50m (was: 2h 40m) > Retarget solution file to VS2019 > > > Key: HADOOP-18357 > URL: https://issues.apache.org/jira/browse/HADOOP-18357 > Project: Hadoop Common > Issue Type: Bug > Components: common >Affects Versions: 3.4.0 > Environment: Windows 10 >Reporter: Gautham Banasandra >Assignee: Gautham Banasandra >Priority: Major > Labels: libhdfscpp, pull-request-available > Time Spent: 2h 50m > Remaining Estimate: 0h > > The Visual Studio version used by winutils and native components in Hadoop > common are quite old. We need to retarget the solution and vcxproj files to > use the latest version (Visual Studio 2019 as of this writing). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18357) Retarget solution file to VS2019
[ https://issues.apache.org/jira/browse/HADOOP-18357?focusedWorklogId=796051=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796051 ] ASF GitHub Bot logged work on HADOOP-18357: --- Author: ASF GitHub Bot Created on: 28/Jul/22 12:08 Start Date: 28/Jul/22 12:08 Worklog Time Spent: 10m Work Description: GauthamBanasandra closed pull request #4616: HADOOP-18357. Retarget solution file to VS2019 URL: https://github.com/apache/hadoop/pull/4616 Issue Time Tracking --- Worklog Id: (was: 796051) Time Spent: 3h (was: 2h 50m) > Retarget solution file to VS2019 > > > Key: HADOOP-18357 > URL: https://issues.apache.org/jira/browse/HADOOP-18357 > Project: Hadoop Common > Issue Type: Bug > Components: common >Affects Versions: 3.4.0 > Environment: Windows 10 >Reporter: Gautham Banasandra >Assignee: Gautham Banasandra >Priority: Major > Labels: libhdfscpp, pull-request-available > Time Spent: 3h > Remaining Estimate: 0h > > The Visual Studio version used by winutils and native components in Hadoop > common are quite old. We need to retarget the solution and vcxproj files to > use the latest version (Visual Studio 2019 as of this writing). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18357) Retarget solution file to VS2019
[ https://issues.apache.org/jira/browse/HADOOP-18357?focusedWorklogId=796048=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796048 ] ASF GitHub Bot logged work on HADOOP-18357: --- Author: ASF GitHub Bot Created on: 28/Jul/22 12:06 Start Date: 28/Jul/22 12:06 Worklog Time Spent: 10m Work Description: GauthamBanasandra commented on code in PR #4616: URL: https://github.com/apache/hadoop/pull/4616#discussion_r932136279 ## hadoop-common-project/hadoop-common/src/main/native/native.vcxproj: ## @@ -39,12 +37,14 @@ false true Unicode +v142 Review Comment: This is amazing. Thanks for sharing this @goiri . I'm able to confirm that while building the `hadoop-common-project` module, the vcxproj and solution files automatically get upgraded to the appropriate Visual Studio version. All thanks to https://github.com/apache/hadoop/blob/95a85875d0038a73f7e6c2cdb6efdc5132d63beb/hadoop-common-project/hadoop-common/pom.xml#L844-L923 ``` [INFO] - Issue Time Tracking --- Worklog Id: (was: 796048) Time Spent: 2h 40m (was: 2.5h) > Retarget solution file to VS2019 > > > Key: HADOOP-18357 > URL: https://issues.apache.org/jira/browse/HADOOP-18357 > Project: Hadoop Common > Issue Type: Bug > Components: common >Affects Versions: 3.4.0 > Environment: Windows 10 >Reporter: Gautham Banasandra >Assignee: Gautham Banasandra >Priority: Major > Labels: libhdfscpp, pull-request-available > Time Spent: 2h 40m > Remaining Estimate: 0h > > The Visual Studio version used by winutils and native components in Hadoop > common are quite old. We need to retarget the solution and vcxproj files to > use the latest version (Visual Studio 2019 as of this writing). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18357) Retarget solution file to VS2019
[ https://issues.apache.org/jira/browse/HADOOP-18357?focusedWorklogId=795823=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795823 ] ASF GitHub Bot logged work on HADOOP-18357: --- Author: ASF GitHub Bot Created on: 27/Jul/22 20:25 Start Date: 27/Jul/22 20:25 Worklog Time Spent: 10m Work Description: goiri commented on code in PR #4616: URL: https://github.com/apache/hadoop/pull/4616#discussion_r931549627 ## hadoop-common-project/hadoop-common/src/main/native/native.vcxproj: ## @@ -39,12 +37,14 @@ false true Unicode +v142 Review Comment: Take a look at HADOOP-14667 Specially: `MSBuild Solution files are converted to the version of VS at build time` If this makes sense, we go with this. Issue Time Tracking --- Worklog Id: (was: 795823) Time Spent: 2.5h (was: 2h 20m) > Retarget solution file to VS2019 > > > Key: HADOOP-18357 > URL: https://issues.apache.org/jira/browse/HADOOP-18357 > Project: Hadoop Common > Issue Type: Bug > Components: common >Affects Versions: 3.4.0 > Environment: Windows 10 >Reporter: Gautham Banasandra >Assignee: Gautham Banasandra >Priority: Major > Labels: libhdfscpp, pull-request-available > Time Spent: 2.5h > Remaining Estimate: 0h > > The Visual Studio version used by winutils and native components in Hadoop > common are quite old. We need to retarget the solution and vcxproj files to > use the latest version (Visual Studio 2019 as of this writing). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18357) Retarget solution file to VS2019
[ https://issues.apache.org/jira/browse/HADOOP-18357?focusedWorklogId=795822=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795822 ] ASF GitHub Bot logged work on HADOOP-18357: --- Author: ASF GitHub Bot Created on: 27/Jul/22 20:24 Start Date: 27/Jul/22 20:24 Worklog Time Spent: 10m Work Description: goiri commented on code in PR #4616: URL: https://github.com/apache/hadoop/pull/4616#discussion_r931549627 ## hadoop-common-project/hadoop-common/src/main/native/native.vcxproj: ## @@ -39,12 +37,14 @@ false true Unicode +v142 Review Comment: Take a look at HADOOP-14667 If this makes sense, we go with this. Issue Time Tracking --- Worklog Id: (was: 795822) Time Spent: 2h 20m (was: 2h 10m) > Retarget solution file to VS2019 > > > Key: HADOOP-18357 > URL: https://issues.apache.org/jira/browse/HADOOP-18357 > Project: Hadoop Common > Issue Type: Bug > Components: common >Affects Versions: 3.4.0 > Environment: Windows 10 >Reporter: Gautham Banasandra >Assignee: Gautham Banasandra >Priority: Major > Labels: libhdfscpp, pull-request-available > Time Spent: 2h 20m > Remaining Estimate: 0h > > The Visual Studio version used by winutils and native components in Hadoop > common are quite old. We need to retarget the solution and vcxproj files to > use the latest version (Visual Studio 2019 as of this writing). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18357) Retarget solution file to VS2019
[ https://issues.apache.org/jira/browse/HADOOP-18357?focusedWorklogId=795628=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795628 ] ASF GitHub Bot logged work on HADOOP-18357: --- Author: ASF GitHub Bot Created on: 27/Jul/22 12:15 Start Date: 27/Jul/22 12:15 Worklog Time Spent: 10m Work Description: GauthamBanasandra commented on code in PR #4616: URL: https://github.com/apache/hadoop/pull/4616#discussion_r930987990 ## hadoop-common-project/hadoop-common/src/main/native/native.vcxproj: ## @@ -39,12 +37,14 @@ false true Unicode +v142 Review Comment: > why would we add it now? The compilation fails without the `PlatformToolset` when compiled with Visual Studio 2019 (I'm not sure about VS2010). I'm fine with documenting running the retarget command as a pre-requisite, if we don't want to add the `PlatformToolset` here. Issue Time Tracking --- Worklog Id: (was: 795628) Time Spent: 2h (was: 1h 50m) > Retarget solution file to VS2019 > > > Key: HADOOP-18357 > URL: https://issues.apache.org/jira/browse/HADOOP-18357 > Project: Hadoop Common > Issue Type: Bug > Components: common >Affects Versions: 3.4.0 > Environment: Windows 10 >Reporter: Gautham Banasandra >Assignee: Gautham Banasandra >Priority: Major > Labels: libhdfscpp, pull-request-available > Time Spent: 2h > Remaining Estimate: 0h > > The Visual Studio version used by winutils and native components in Hadoop > common are quite old. We need to retarget the solution and vcxproj files to > use the latest version (Visual Studio 2019 as of this writing). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18357) Retarget solution file to VS2019
[ https://issues.apache.org/jira/browse/HADOOP-18357?focusedWorklogId=795629=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795629 ] ASF GitHub Bot logged work on HADOOP-18357: --- Author: ASF GitHub Bot Created on: 27/Jul/22 12:15 Start Date: 27/Jul/22 12:15 Worklog Time Spent: 10m Work Description: GauthamBanasandra commented on code in PR #4616: URL: https://github.com/apache/hadoop/pull/4616#discussion_r930987990 ## hadoop-common-project/hadoop-common/src/main/native/native.vcxproj: ## @@ -39,12 +37,14 @@ false true Unicode +v142 Review Comment: > why would we add it now? The compilation fails without the `PlatformToolset` when compiled with Visual Studio 2019 (I'm not sure about VS2010). I'm fine with documenting running the retarget command as a pre-requisite step prior to running the `mvn install` command, if we don't want to add the `PlatformToolset` here. Issue Time Tracking --- Worklog Id: (was: 795629) Time Spent: 2h 10m (was: 2h) > Retarget solution file to VS2019 > > > Key: HADOOP-18357 > URL: https://issues.apache.org/jira/browse/HADOOP-18357 > Project: Hadoop Common > Issue Type: Bug > Components: common >Affects Versions: 3.4.0 > Environment: Windows 10 >Reporter: Gautham Banasandra >Assignee: Gautham Banasandra >Priority: Major > Labels: libhdfscpp, pull-request-available > Time Spent: 2h 10m > Remaining Estimate: 0h > > The Visual Studio version used by winutils and native components in Hadoop > common are quite old. We need to retarget the solution and vcxproj files to > use the latest version (Visual Studio 2019 as of this writing). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18357) Retarget solution file to VS2019
[ https://issues.apache.org/jira/browse/HADOOP-18357?focusedWorklogId=795451=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795451 ] ASF GitHub Bot logged work on HADOOP-18357: --- Author: ASF GitHub Bot Created on: 26/Jul/22 22:10 Start Date: 26/Jul/22 22:10 Worklog Time Spent: 10m Work Description: goiri commented on code in PR #4616: URL: https://github.com/apache/hadoop/pull/4616#discussion_r930453553 ## hadoop-common-project/hadoop-common/src/main/native/native.vcxproj: ## @@ -39,12 +37,14 @@ false true Unicode +v142 Review Comment: Given that we didn't have the target before; why would we add it now? Issue Time Tracking --- Worklog Id: (was: 795451) Time Spent: 1h 50m (was: 1h 40m) > Retarget solution file to VS2019 > > > Key: HADOOP-18357 > URL: https://issues.apache.org/jira/browse/HADOOP-18357 > Project: Hadoop Common > Issue Type: Bug > Components: common >Affects Versions: 3.4.0 > Environment: Windows 10 >Reporter: Gautham Banasandra >Assignee: Gautham Banasandra >Priority: Major > Labels: libhdfscpp, pull-request-available > Time Spent: 1h 50m > Remaining Estimate: 0h > > The Visual Studio version used by winutils and native components in Hadoop > common are quite old. We need to retarget the solution and vcxproj files to > use the latest version (Visual Studio 2019 as of this writing). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18357) Retarget solution file to VS2019
[ https://issues.apache.org/jira/browse/HADOOP-18357?focusedWorklogId=795386=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795386 ] ASF GitHub Bot logged work on HADOOP-18357: --- Author: ASF GitHub Bot Created on: 26/Jul/22 18:30 Start Date: 26/Jul/22 18:30 Worklog Time Spent: 10m Work Description: GauthamBanasandra commented on code in PR #4616: URL: https://github.com/apache/hadoop/pull/4616#discussion_r930293301 ## hadoop-common-project/hadoop-common/src/main/native/native.vcxproj: ## @@ -39,12 +37,14 @@ false true Unicode +v142 Review Comment: I ran the retarget command from `VS2019 command prompt`, thus the retarget tool added the PlatformToolset version corresponding to VS2019. The retarget command would take care of inserting the right version based on Visual Studio command prompt that we choose. Please also note that the subsequent `mvn install` command must be run from the same command prompt. Issue Time Tracking --- Worklog Id: (was: 795386) Time Spent: 1h 40m (was: 1.5h) > Retarget solution file to VS2019 > > > Key: HADOOP-18357 > URL: https://issues.apache.org/jira/browse/HADOOP-18357 > Project: Hadoop Common > Issue Type: Bug > Components: common >Affects Versions: 3.4.0 > Environment: Windows 10 >Reporter: Gautham Banasandra >Assignee: Gautham Banasandra >Priority: Major > Labels: libhdfscpp, pull-request-available > Time Spent: 1h 40m > Remaining Estimate: 0h > > The Visual Studio version used by winutils and native components in Hadoop > common are quite old. We need to retarget the solution and vcxproj files to > use the latest version (Visual Studio 2019 as of this writing). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18357) Retarget solution file to VS2019
[ https://issues.apache.org/jira/browse/HADOOP-18357?focusedWorklogId=795370=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795370 ] ASF GitHub Bot logged work on HADOOP-18357: --- Author: ASF GitHub Bot Created on: 26/Jul/22 17:56 Start Date: 26/Jul/22 17:56 Worklog Time Spent: 10m Work Description: goiri commented on code in PR #4616: URL: https://github.com/apache/hadoop/pull/4616#discussion_r930262338 ## hadoop-common-project/hadoop-common/src/main/native/native.vcxproj: ## @@ -39,12 +37,14 @@ false true Unicode +v142 Review Comment: So how does it know which VS version to be scoped to? Issue Time Tracking --- Worklog Id: (was: 795370) Time Spent: 1.5h (was: 1h 20m) > Retarget solution file to VS2019 > > > Key: HADOOP-18357 > URL: https://issues.apache.org/jira/browse/HADOOP-18357 > Project: Hadoop Common > Issue Type: Bug > Components: common >Affects Versions: 3.4.0 > Environment: Windows 10 >Reporter: Gautham Banasandra >Assignee: Gautham Banasandra >Priority: Major > Labels: libhdfscpp, pull-request-available > Time Spent: 1.5h > Remaining Estimate: 0h > > The Visual Studio version used by winutils and native components in Hadoop > common are quite old. We need to retarget the solution and vcxproj files to > use the latest version (Visual Studio 2019 as of this writing). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18357) Retarget solution file to VS2019
[ https://issues.apache.org/jira/browse/HADOOP-18357?focusedWorklogId=795365=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795365 ] ASF GitHub Bot logged work on HADOOP-18357: --- Author: ASF GitHub Bot Created on: 26/Jul/22 17:45 Start Date: 26/Jul/22 17:45 Worklog Time Spent: 10m Work Description: GauthamBanasandra commented on code in PR #4616: URL: https://github.com/apache/hadoop/pull/4616#discussion_r930252453 ## hadoop-common-project/hadoop-common/src/main/native/native.vcxproj: ## @@ -39,12 +37,14 @@ false true Unicode +v142 Review Comment: @goiri I checked on the current trunk. There's no `PlatformToolset` or `v100` defined anywhere -   Issue Time Tracking --- Worklog Id: (was: 795365) Time Spent: 1h 20m (was: 1h 10m) > Retarget solution file to VS2019 > > > Key: HADOOP-18357 > URL: https://issues.apache.org/jira/browse/HADOOP-18357 > Project: Hadoop Common > Issue Type: Bug > Components: common >Affects Versions: 3.4.0 > Environment: Windows 10 >Reporter: Gautham Banasandra >Assignee: Gautham Banasandra >Priority: Major > Labels: libhdfscpp, pull-request-available > Time Spent: 1h 20m > Remaining Estimate: 0h > > The Visual Studio version used by winutils and native components in Hadoop > common are quite old. We need to retarget the solution and vcxproj files to > use the latest version (Visual Studio 2019 as of this writing). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18357) Retarget solution file to VS2019
[ https://issues.apache.org/jira/browse/HADOOP-18357?focusedWorklogId=794997=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794997 ] ASF GitHub Bot logged work on HADOOP-18357: --- Author: ASF GitHub Bot Created on: 25/Jul/22 17:48 Start Date: 25/Jul/22 17:48 Worklog Time Spent: 10m Work Description: goiri commented on code in PR #4616: URL: https://github.com/apache/hadoop/pull/4616#discussion_r929146402 ## hadoop-common-project/hadoop-common/src/main/native/native.vcxproj: ## @@ -39,12 +37,14 @@ false true Unicode +v142 Review Comment: Can we check if it was inherited from somewhere else? This may trigger inconsistencies. Issue Time Tracking --- Worklog Id: (was: 794997) Time Spent: 1h 10m (was: 1h) > Retarget solution file to VS2019 > > > Key: HADOOP-18357 > URL: https://issues.apache.org/jira/browse/HADOOP-18357 > Project: Hadoop Common > Issue Type: Bug > Components: common >Affects Versions: 3.4.0 > Environment: Windows 10 >Reporter: Gautham Banasandra >Assignee: Gautham Banasandra >Priority: Major > Labels: libhdfscpp, pull-request-available > Time Spent: 1h 10m > Remaining Estimate: 0h > > The Visual Studio version used by winutils and native components in Hadoop > common are quite old. We need to retarget the solution and vcxproj files to > use the latest version (Visual Studio 2019 as of this writing). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18357) Retarget solution file to VS2019
[ https://issues.apache.org/jira/browse/HADOOP-18357?focusedWorklogId=794988=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794988 ] ASF GitHub Bot logged work on HADOOP-18357: --- Author: ASF GitHub Bot Created on: 25/Jul/22 17:24 Start Date: 25/Jul/22 17:24 Worklog Time Spent: 10m Work Description: GauthamBanasandra commented on code in PR #4616: URL: https://github.com/apache/hadoop/pull/4616#discussion_r929126701 ## hadoop-common-project/hadoop-common/src/main/native/native.vcxproj.filters: ## @@ -48,19 +46,16 @@ Source Files - - Source Files - - + Source Files - + Review Comment: These changes were automatically made by Visual Studio when I ran the retarget command. The `lz4` library was removed in https://github.com/apache/hadoop/pull/2576. The author didn't remove them from Visual Studio, so I removed them - https://github.com/apache/hadoop/commit/44910b53f383f8ab092b7f9889fbf353e057d3f7. But I forgot to remove them from `native.vcxproj.filters` file (the current file). When I retargeted the native project, Visual Studio was smart enough to detect that these files don't exist and has removed them for us. Issue Time Tracking --- Worklog Id: (was: 794988) Time Spent: 1h (was: 50m) > Retarget solution file to VS2019 > > > Key: HADOOP-18357 > URL: https://issues.apache.org/jira/browse/HADOOP-18357 > Project: Hadoop Common > Issue Type: Bug > Components: common >Affects Versions: 3.4.0 > Environment: Windows 10 >Reporter: Gautham Banasandra >Assignee: Gautham Banasandra >Priority: Major > Labels: libhdfscpp, pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > The Visual Studio version used by winutils and native components in Hadoop > common are quite old. We need to retarget the solution and vcxproj files to > use the latest version (Visual Studio 2019 as of this writing). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18357) Retarget solution file to VS2019
[ https://issues.apache.org/jira/browse/HADOOP-18357?focusedWorklogId=794987=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794987 ] ASF GitHub Bot logged work on HADOOP-18357: --- Author: ASF GitHub Bot Created on: 25/Jul/22 17:18 Start Date: 25/Jul/22 17:18 Worklog Time Spent: 10m Work Description: GauthamBanasandra commented on code in PR #4616: URL: https://github.com/apache/hadoop/pull/4616#discussion_r929121380 ## hadoop-common-project/hadoop-common/src/main/native/native.vcxproj: ## @@ -142,16 +140,16 @@ /D HADOOP_ISAL_LIBRARY=L\"isa-l.dll\" - - - - - - - - - - + Review Comment: Sure, I'll create a separate PR for formatting changes. Issue Time Tracking --- Worklog Id: (was: 794987) Time Spent: 50m (was: 40m) > Retarget solution file to VS2019 > > > Key: HADOOP-18357 > URL: https://issues.apache.org/jira/browse/HADOOP-18357 > Project: Hadoop Common > Issue Type: Bug > Components: common >Affects Versions: 3.4.0 > Environment: Windows 10 >Reporter: Gautham Banasandra >Assignee: Gautham Banasandra >Priority: Major > Labels: libhdfscpp, pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > The Visual Studio version used by winutils and native components in Hadoop > common are quite old. We need to retarget the solution and vcxproj files to > use the latest version (Visual Studio 2019 as of this writing). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18357) Retarget solution file to VS2019
[ https://issues.apache.org/jira/browse/HADOOP-18357?focusedWorklogId=794986=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794986 ] ASF GitHub Bot logged work on HADOOP-18357: --- Author: ASF GitHub Bot Created on: 25/Jul/22 17:17 Start Date: 25/Jul/22 17:17 Worklog Time Spent: 10m Work Description: GauthamBanasandra commented on code in PR #4616: URL: https://github.com/apache/hadoop/pull/4616#discussion_r929120970 ## hadoop-common-project/hadoop-common/src/main/native/native.vcxproj: ## @@ -39,12 +37,14 @@ false true Unicode +v142 Review Comment: I think the old number should've been `v100`. I'm not sure why it wasn't defined. Visual Studio automatically added this when I ran the command to retarget the project files. Issue Time Tracking --- Worklog Id: (was: 794986) Time Spent: 40m (was: 0.5h) > Retarget solution file to VS2019 > > > Key: HADOOP-18357 > URL: https://issues.apache.org/jira/browse/HADOOP-18357 > Project: Hadoop Common > Issue Type: Bug > Components: common >Affects Versions: 3.4.0 > Environment: Windows 10 >Reporter: Gautham Banasandra >Assignee: Gautham Banasandra >Priority: Major > Labels: libhdfscpp, pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > The Visual Studio version used by winutils and native components in Hadoop > common are quite old. We need to retarget the solution and vcxproj files to > use the latest version (Visual Studio 2019 as of this writing). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18357) Retarget solution file to VS2019
[
https://issues.apache.org/jira/browse/HADOOP-18357?focusedWorklogId=794838=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794838
]
ASF GitHub Bot logged work on HADOOP-18357:
---
Author: ASF GitHub Bot
Created on: 25/Jul/22 11:03
Start Date: 25/Jul/22 11:03
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on PR #4616:
URL: https://github.com/apache/hadoop/pull/4616#issuecomment-1193903760
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 47s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 14m 54s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 28m 37s | | trunk passed |
| +1 :green_heart: | compile | 25m 8s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | compile | 21m 48s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | mvnsite | 2m 53s | | trunk passed |
| +1 :green_heart: | javadoc | 2m 19s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 1m 52s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | shadedclient | 121m 47s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 28s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 29s | | the patch passed |
| +1 :green_heart: | compile | 24m 40s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | cc | 24m 40s | | the patch passed |
| +1 :green_heart: | golang | 24m 40s | | the patch passed |
| +1 :green_heart: | javac | 24m 40s | | the patch passed |
| +1 :green_heart: | compile | 21m 46s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | cc | 21m 46s | | the patch passed |
| +1 :green_heart: | golang | 21m 46s | | the patch passed |
| +1 :green_heart: | javac | 21m 46s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | mvnsite | 2m 51s | | the patch passed |
| +1 :green_heart: | javadoc | 2m 7s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 1m 52s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | shadedclient | 36m 16s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 18m 48s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | unit | 87m 53s | | hadoop-hdfs-native-client in
the patch passed. |
| +1 :green_heart: | asflicense | 1m 16s | | The patch does not
generate ASF License warnings. |
| | | 317m 1s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4616/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/4616 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient codespell detsecrets cc golang |
| uname | Linux 9cdedda7801d 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24
17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 8d02105f440983dccb3596fe71a971503188b53e |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4616/2/testReport/ |
| Max.
[jira] [Work logged] (HADOOP-18357) Retarget solution file to VS2019
[ https://issues.apache.org/jira/browse/HADOOP-18357?focusedWorklogId=794640=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794640 ] ASF GitHub Bot logged work on HADOOP-18357: --- Author: ASF GitHub Bot Created on: 24/Jul/22 17:16 Start Date: 24/Jul/22 17:16 Worklog Time Spent: 10m Work Description: goiri commented on code in PR #4616: URL: https://github.com/apache/hadoop/pull/4616#discussion_r928287817 ## hadoop-common-project/hadoop-common/src/main/native/native.vcxproj.filters: ## @@ -48,19 +46,16 @@ Source Files - - Source Files - - + Source Files - + Review Comment: Why are we changing this? ## hadoop-common-project/hadoop-common/src/main/native/native.vcxproj: ## @@ -39,12 +37,14 @@ false true Unicode +v142 Review Comment: What was the old number and where was it defined? ## hadoop-common-project/hadoop-common/src/main/native/native.vcxproj: ## @@ -142,16 +140,16 @@ /D HADOOP_ISAL_LIBRARY=L\"isa-l.dll\" - - - - - - - - - - + Review Comment: Can we avoid these changes? Issue Time Tracking --- Worklog Id: (was: 794640) Time Spent: 20m (was: 10m) > Retarget solution file to VS2019 > > > Key: HADOOP-18357 > URL: https://issues.apache.org/jira/browse/HADOOP-18357 > Project: Hadoop Common > Issue Type: Bug > Components: common >Affects Versions: 3.4.0 > Environment: Windows 10 >Reporter: Gautham Banasandra >Assignee: Gautham Banasandra >Priority: Major > Labels: libhdfscpp, pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > The Visual Studio version used by winutils and native components in Hadoop > common are quite old. We need to retarget the solution and vcxproj files to > use the latest version (Visual Studio 2019 as of this writing). -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org
[jira] [Work logged] (HADOOP-18357) Retarget solution file to VS2019
[
https://issues.apache.org/jira/browse/HADOOP-18357?focusedWorklogId=794564=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-794564
]
ASF GitHub Bot logged work on HADOOP-18357:
---
Author: ASF GitHub Bot
Created on: 23/Jul/22 23:07
Start Date: 23/Jul/22 23:07
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on PR #4616:
URL: https://github.com/apache/hadoop/pull/4616#issuecomment-1193201607
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 39s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
_ trunk Compile Tests _ |
| +0 :ok: | mvndep | 15m 17s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 25m 41s | | trunk passed |
| +1 :green_heart: | compile | 23m 20s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | compile | 20m 50s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | mvnsite | 3m 26s | | trunk passed |
| +1 :green_heart: | javadoc | 2m 50s | | trunk passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 2m 26s | | trunk passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | shadedclient | 115m 14s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 35s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 1m 31s | | the patch passed |
| +1 :green_heart: | compile | 22m 28s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | cc | 22m 28s | | the patch passed |
| +1 :green_heart: | golang | 22m 28s | | the patch passed |
| +1 :green_heart: | javac | 22m 28s | | the patch passed |
| +1 :green_heart: | compile | 20m 45s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | cc | 20m 45s | | the patch passed |
| +1 :green_heart: | golang | 20m 45s | | the patch passed |
| +1 :green_heart: | javac | 20m 45s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | mvnsite | 3m 24s | | the patch passed |
| +1 :green_heart: | javadoc | 2m 39s | | the patch passed with JDK
Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 2m 28s | | the patch passed with JDK
Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | shadedclient | 33m 35s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 18m 46s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | unit | 33m 34s | | hadoop-hdfs-native-client in
the patch passed. |
| +1 :green_heart: | asflicense | 1m 34s | | The patch does not
generate ASF License warnings. |
| | | 250m 54s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4616/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/4616 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient codespell detsecrets cc golang |
| uname | Linux 410758acc5e5 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 62f6e669e24cc1f85776ee12ed67d5ac5d5f8c3a |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4616/1/testReport/ |
| Max.
