Re: [DISCUSS] Reformat the newlines separator of all source files

2021-05-31 Thread Ian Luo
+1. Dubbo 3.0 is a chance to fix this particular issue completely.

-Ian.

On Sat, May 22, 2021 at 4:35 PM Albumen Kevin  wrote:

> Hi community,
>
> In apache/dubbo, there are a great amount of source files using CR LF
> newline format due to Windows System.
>
> If contributors change these files, the git and IDE will
> automatically reformat the files to LF newline format as default.
>
> It is possible for users to prevent this. That is setting `git config
> --global core.autocrlf false`[1], but this will cause
> IDE to warn users to remove this setting[2]. I have tried to create a
> patch[3] for this, but it just works for new contributors,
> who clone the repo after this pr.
>
> Git best practices recommend that all the files in repo are using LF
> newline format and not only Git client in Windows but
> Intellij IDEA has already made this action default for many years.
>
> There is a solution that is reformatting all source files at once and
> adding a restricted code format checker to prevent users
> from submitting CR LF newline format files. But this will cause that we
> cannot easily track the source file's history previous
> version by git blame[4]. In the file's history, there will be a node that
> changes all lines, but we can still find the real previous
> version by finding the reformatting commit's parent, which is the real
> version of the history. The reformatting commit will be
> a little like the pr[5][6] in dubbo-samples when removing golang samples.
>
> What do you think about this? Shall we make such a change to make all
> source files more cleaner.
>
> [1] https://git-scm.com/book/en/v2/Customizing-Git-Git-Configuration
> [2]
>
> https://blog.jetbrains.com/idea/2012/10/better-line-endings-managing-in-intellij-idea-12/
> [3] https://github.com/apache/dubbo/pull/7229
> [4] https://git-scm.com/docs/git-blame
> [5]
>
> https://github.com/apache/dubbo-samples/commit/19f02c2dc8a95cf18de33077bd1967ab048f462f
> [6]
>
> https://github.com/apache/dubbo-samples/commits/19f02c2dc8a95cf18de33077bd1967ab048f462f/dubbo-samples-annotation/src/main/java/org/apache/dubbo/samples/annotation/api/GreetingService.java
>
> Thanks,
> Albumen Kevin
>


Re: [Suggention] Join Open Source Promotion Plan - Summer 2021

2021-05-08 Thread Ian Luo
+1, I think it is a good opportunity to introduce Apache Dubbo to
university students.

-Ian.

On Sat, May 8, 2021 at 3:17 PM Albumen Kevin  wrote:

> Hi, community
>
> I have noticed that there is an awesome activity, called Open Source
> Promotion Plan - Summer 2021,
> for college students to join the open source software community. It aims to
> encourage college students
> to actively participate in the development and maintenance of open source
> software and promote the
> vigorous development of an excellent open source software community.
>
> I think we can join them and at the same time bring more contributors and
> activity to the community.
>
> The website of Summer 2021:https://summer.iscas.ac.cn/#/homepage
> The help website of Summer 2021: https://summer.iscas.ac.cn/#/help
>
>
> Albumen
>


Re: [VOTE] Release Apache Dubbo 3.0.0.preview RC1

2021-03-22 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..

Regards,
-Ian.

On Sat, Mar 20, 2021 at 1:20 AM Jun Liu  wrote:

> Hello Dubbo Community,
>
> This is a call for a vote to release Apache Dubbo version 3.0.0.preview.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo/3.0.0.preview/
>
> The staging repo:
> https://repository.apache.org/content/repositories/orgapachedubbo-1157
>
> Git tag for the release:
> https://github.com/apache/dubbo/tree/3.0.0.preview
>
> Hash for the release tag:
> 95b776385ee8dcaca91568c11765e73d9b29b861
>
> Release Notes:
> https://github.com/apache/dubbo/releases/tag/3.0.0.preview
>
> The artifacts have been signed with Key: 28681CB1, which can be found in
> the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until the necessary number
> of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo Team
>


Re: [VOTE] Release Apache Dubbo API Docs 2.7.8.2 RC2

2021-03-22 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..

Regards,
-Ian.

On Tue, Mar 23, 2021 at 10:55 AM ranke  wrote:

> Hello Community,
>
> This is a call for vote to release Apache Dubbo API Docs version 2.7.8.2.
> Dubbo API Docs is currently existing as a submodule of the
> apache/dubbo-spi-extensions[1] project, the Apache release package contains
> only the API Docs source code.
>
> The release candidates:
>
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-spi-extensions/dubbo-api-docs/2.7.8.2/
>
> The staging repo:
> https://repository.apache.org/content/repositories/orgapachedubbo-1163
>
> Git tag for the release:
> https://github.com/apache/dubbo-spi-extensions/tree/v2.7.8.2
>
> Hash for the release tag:
> b5823267a240cbb1c70a337f6ca95adc6b49e267
>
> Release Notes:
> https://github.com/apache/dubbo-spi-extensions/releases/tag/v2.7.8.2
>
> The artifacts have been signed with Key 21C12FEAC580F98D, which can be
> found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> 1.
> https://github.com/apache/dubbo-spi-extensions/tree/v2.7.8.2/dubbo-api-docs
>
> Thanks,
> The Apache Dubbo Team
>


Re: [VOTE] Release Apache Dubbo Spring Boot 2.7.9 RC1

2021-03-18 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..

Regards,
-Ian.

On Fri, Mar 12, 2021 at 10:41 PM Albumen Kevin  wrote:

> Hello Dubbo Community,
>
> This is a call for a vote to release Apache Dubbo Spring Boot version
> 2.7.9.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-spring-boot/2.7.9/
>
> The staging repo:
> https://repository.apache.org/content/repositories/orgapachedubbo-1154/
>
> Git tag for the release:
> https://github.com/apache/dubbo-spring-boot-project/releases/tag/2.7.9
>
> Hash for the release tag:
> 88cc365674fc211551c537a00fbf9fa4df15d110
>
> Release Notes:
> https://github.com/apache/dubbo-spring-boot-project/releases/tag/2.7.9
>
> The artifacts have been signed with Key: 2B249EDD, which can be found in
> the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until the necessary number
> of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo Team
>


Re: [Discuss] Merge apache/dubbo-spring-boot-project into apache/dubbo

2021-03-14 Thread Ian Luo
Agree, it is a good idea to move it into spring package.

Regards,
-Ian.

On Thu, Mar 11, 2021 at 3:42 PM Gong Dewei  wrote:

> HiAll,
>
>
> This discussion is about merging apache/dubbo-spring-boot-project into
> apache/dubbo project.
>
>
> The code of dubbo spring-boot is relatively small[1], but its processing
> logic is very close to the dubbo-config-spring module. Separating the two
> projects is prone to version compatibility issues[2], and it also increases
> the work of development and testing [3].
>
>
> The benefits of the merger can be foreseen:
> 1. Simplify the testing workflow (github actions) of apache/dubbo 
> apache/dubbo-samples.
> 2. There is no need to release dubbo-spring-boot-* separately to avoid the
> problem of component version mismatch
> 3. The development and testing related to dubbo spring is more efficient.
>
>
> Any ideas?
>
>
>
> [1]https://github.com/apache/dubbo-spring-boot-project
> [2]https://github.com/apache/dubbo/issues/7347
> [3]
> https://github.com/apache/dubbo/blob/master/.github/workflows/build-and-test.yml
> ;
>   
> https://github.com/apache/dubbo-samples/blob/master/.github/workflows/dubbo-2.yml
>
> Gong Dewei
>  


Re: [VOTE] Release Apache dubbo-go-hessian2 v1.9.0 RC1

2021-03-14 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because.

-Ian.


On Sun, Mar 14, 2021 at 10:44 PM wongoo  wrote:

> Hello Dubbo/Dubbogo Community,
>
>  This is a call for a vote to release Apache dubbo-go-hessian2 version
> v1.9.0 RC1.
>
>  The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go-hessian2/v1.9.0-rc1/
>  Git tag for the release:
> https://github.com/apache/dubbo-go-hessian2/tree/1.9
>  Hash for the release tag: d829b56bf3e56a2f424ef4555eb15ec8b131b3c9
>  Release Notes:
> https://github.com/apache/dubbo-go-hessian2/blob/1.9/CHANGE.md
>  The artifacts have been signed with Key :7DB68550D366E4C0, which can be
> found in the keys file:
>  https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
>  The vote will be open for at least 72 hours or until a necessary number of
> votes are reached.
>
>  Please vote accordingly:
>  [ ] +1 approve
>  [ ] +0 no opinion
>  [ ] -1 disapprove with the reason
>
>  Thanks,
>  The Apache Dubbo-go Team
>


Re: [VOTE] Accept the donation of dubbo-go-pixiu

2021-03-14 Thread Ian Luo
+1 to accept. Glad to see another dubbo-go side project.

Cheers,
-Ian.

On Sat, Mar 13, 2021 at 7:24 PM wongoo  wrote:

> Hi All,
>
> This is a formal vote to donate dubbogo/dubbo-go-pixiu[1] to apache.
>
> dubbo-go-pixiu is a gateway based on dubbo-go. It provides a general
> solution that supports calling dubbo services through other protocols. At
> present, it supports HTTP and gRPC[developing].
>
> All contributors[3] agree to donate it to the Dubbo community, and have
> already signed the ICLA. In the discussion[2], the community also supports
> the donation.
>
>
> Please vote:
> [ ] +1 Accept
> [ ] +0 No Opinion
> [ ] -1 Reject because...
>
>
> [1] https://github.com/dubbogo/dubbo-go-pixiu/
> [2]
>
> https://lists.apache.org/thread.html/r765a243e534ff36f524227776a8ab7c067678d1952141a4cf461200c%40%3Cdev.dubbo.apache.org%3E
> [3] pixiu contributors:
> - williamfeng323, ICLA signed
> - mark4z, ICLA signed
> - xiaoliu10, ICLA signed
> - oaoit, ICLA signed
> - xianlezheng, ICLA signed
> - ztelur, ICLA signed
> - zhangshen023, ICLA signed
> - cityiron/IronCity, dubbo commiter
> - zouyx, dubbo PMC
> - pantianying, dubbo commiter
> - AlexStocks, dubbo PMC
>
> --
> Regards,
> Wongoo
>


Re: [VOTE] Release Apache dubbo-go-hessian2 v1.9.0 RC1

2021-03-14 Thread Ian Luo
Pls. ignore. I reply to the wrong thread.

-Ian.

On Mon, Mar 15, 2021 at 10:31 AM Ian Luo  wrote:

> +1, glad to see another dubbo-go side project.
>
> Thanks,
> -Ian.
>
> On Sun, Mar 14, 2021 at 10:44 PM wongoo  wrote:
>
>> Hello Dubbo/Dubbogo Community,
>>
>>  This is a call for a vote to release Apache dubbo-go-hessian2 version
>> v1.9.0 RC1.
>>
>>  The release candidates:
>> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go-hessian2/v1.9.0-rc1/
>>  Git tag for the release:
>> https://github.com/apache/dubbo-go-hessian2/tree/1.9
>>  Hash for the release tag: d829b56bf3e56a2f424ef4555eb15ec8b131b3c9
>>  Release Notes:
>> https://github.com/apache/dubbo-go-hessian2/blob/1.9/CHANGE.md
>>  The artifacts have been signed with Key :7DB68550D366E4C0, which can be
>> found in the keys file:
>>  https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>>
>>  The vote will be open for at least 72 hours or until a necessary number
>> of
>> votes are reached.
>>
>>  Please vote accordingly:
>>  [ ] +1 approve
>>  [ ] +0 no opinion
>>  [ ] -1 disapprove with the reason
>>
>>  Thanks,
>>  The Apache Dubbo-go Team
>>
>


Re: [VOTE] Release Apache dubbo-go-hessian2 v1.9.0 RC1

2021-03-14 Thread Ian Luo
+1, glad to see another dubbo-go side project.

Thanks,
-Ian.

On Sun, Mar 14, 2021 at 10:44 PM wongoo  wrote:

> Hello Dubbo/Dubbogo Community,
>
>  This is a call for a vote to release Apache dubbo-go-hessian2 version
> v1.9.0 RC1.
>
>  The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go-hessian2/v1.9.0-rc1/
>  Git tag for the release:
> https://github.com/apache/dubbo-go-hessian2/tree/1.9
>  Hash for the release tag: d829b56bf3e56a2f424ef4555eb15ec8b131b3c9
>  Release Notes:
> https://github.com/apache/dubbo-go-hessian2/blob/1.9/CHANGE.md
>  The artifacts have been signed with Key :7DB68550D366E4C0, which can be
> found in the keys file:
>  https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
>  The vote will be open for at least 72 hours or until a necessary number of
> votes are reached.
>
>  Please vote accordingly:
>  [ ] +1 approve
>  [ ] +0 no opinion
>  [ ] -1 disapprove with the reason
>
>  Thanks,
>  The Apache Dubbo-go Team
>


Re: [DISCUSSION] donate dubbo-go-pixiu to Dubbo community

2021-03-09 Thread Ian Luo
+1. I believe it is a strong add-on to dubbo eco system.

Thanks,
-Ian.

On Wed, Mar 10, 2021 at 10:33 AM wongoo  wrote:

> Hello Dubbo community,
>
> I would like to initiate a discussion about donating dubbo-go-pixiu to the
> Dubbo community.
>
> We are developing the dubbo-go-pixiu, a gateway based on dubbo-go, which
> provides a general solution that supports calling dubbo services through
> other protocols. At present, it supports HTTP and gRPC[developing].
>
> The development of dubbo-go-pixiu is driven by the dubbo-go community, all
> contributors agree to donate it to Dubbo community, and we have signed the
> ICLA. The source code is available here:
> https://github.com/dubbogo/dubbo-go-pixiu.
>
> --
> Regards,
> Wongoo
>


Re: [ANN] Welcome new committer Heqing Jiang

2021-03-05 Thread Ian Luo
Congratulations

On Sat, Jan 30, 2021 at 12:46 AM Jun Liu  wrote:

> Hi, Community,
>
> On behalf of the Dubbo PPMC, I am pleased to announce that Heqing Jiang[1]
> have been voted in as new Dubbo committer.
>
> Please join me to say congratulations to him!
>
> Heqing, would you please briefly introduce yourself to the community?
>
> 1. https://github.com/AlbumenJ
>
> Best regards,
> Jun.


Re: 回复: [VOTE] Release Apache Dubbo API Docs 2.7.8.2 RC1

2021-03-05 Thread Ian Luo
参考下这篇文档:
https://dubbo.apache.org/zh/docs/contribution-guidelines/contributor/mailing-list-subscription-guide_dev/

On Mon, Mar 1, 2021 at 8:31 PM Brooks  wrote:

>
> 如何退订邮件组,说了很多次了呀
>
>
>
>
>
>
>
>
>
>
>
>
> 在2021年02月23 14时40分,"ranke"<213...@qq.com>写道:
>
> At present, api docs is developed based on dubbo 2.7.8, so "x" in
> "x.x.x.y" is the same as dubbo. "y" are bug fix.
>
>
>
>
> --原始邮件--
> 发件人: "YunKun Huang" 发送时间: 2021年2月23日(星期二) 中午1:34
> 收件人: "dev" 主题: Re: [VOTE] Release Apache Dubbo API Docs 2.7.8.2 RC1
>
>
>
> Why use version 2.7.8.2?
> Currently dubbo is at 2.7.9, and previous version is 2.7.8
>
> On Fri, Feb 19, 2021 at 2:49 PM Jun Liu  
>  Hello Community,
> 
>  This is a call for vote to release Apache Dubbo API Docs version
> 2.7.8.2. Dubbo API Docs is currently existing as a submodule of the
> apache/dubbo-spi-extensions[1] project, the Apache release package contains
> only the API Docs source code.
> 
>  The release candidates:
> 
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-spi-extensions/dubbo-api-docs/2.7.8.2/
> 
> 
> ;
>  Git tag for the release:
>  https://github.com/apache/dubbo-spi-extensions/tree/v2.7.8.2
>  ;
>  Hash for the release tag:
>  e8b4c4ae164df8e12fcfddd174e2b1ab2e8d9e11
> 
>  Release Notes:
>  https://github.com/apache/dubbo-spi-extensions/releases/tag/v2.7.8.2
> 
> ;
>  The artifacts have been signed with Key 28681CB1, which can be
>  found in the keys file:
>  https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> 
>  The vote will be open for at least 72 hours or until necessary number
> of
>  votes are reached.
> 
>  Please vote accordingly:
> 
>  [ ] +1 approve
>  [ ] +0 no opinion
>  [ ] -1 disapprove with the reason
> 
>  1.
> https://github.com/apache/dubbo-spi-extensions/tree/v2.7.8.2/dubbo-api-docs
> 
> 
> ;
>  Thanks,
>  The Apache Dubbo Team
>
>
>


Re: [Discuss] Disable Travis CI for apache/dubbo

2021-03-05 Thread Ian Luo
+1 to switch to GitHub action.

-Ian.

On Fri, Mar 5, 2021 at 2:59 PM Albumen Kevin  wrote:

> Hi community,
>
>
> So far, we have enable two kinds of CI/CD platform , Travis CI and
>
> GitHub Actions, for Dubbo. GitHub actions works fine for Dubbo
>
> in 2.6.x[1], 2.7.x[2] and 3.x[3] versions.
>
> In 2.7.x and 3.x versions, both unit test and integration test[4], based
>
> on apache/dubbo-samples, are introduced to guarantee the stability
>
> of the snapshot version.
>
>
> There are some benefits can be provided by GitHub Actions now:
>
>
> - More powerful ecosystem
>
> - Easy integration with more GitHub activity
>
> - Can be launched at any time because it is no need
>
>for us to share the concurrency limit with all projects.
>
>Also the concurrency limit for each project looks enough for us.
>
>
> I am wondering if we could disable Travis CI for now which function
>
> can be completely replaced with GitHub Actions?
>
>
> [1] https://github.com/apache/dubbo/actions/runs/623019397
>
> [2] https://github.com/apache/dubbo/actions/runs/620506574
>
> [3] https://github.com/apache/dubbo/actions/runs/620213136
>
> [4] https://github.com/apache/dubbo/runs/2029991040
>


Re: How to handle 404 links to dubbo website

2021-01-26 Thread Ian Luo
Pls. use 404 since we don't have full control to the gateway.

Thanks,
-Ian.

On Mon, Jan 25, 2021 at 3:35 PM YunKun Huang  wrote:

> hey,
>
> Since there are some changes in the dubbo website, most of the urls are
> changed.
> For users coming from search engines, I believe search engines
> already update most of urls, so it should be ok for them.
> But for users coming from blogs/articles, because reference links will not
> automatically updated; When visit old style url, it will show a Not Found
> page.
>
> I have two ideas about this:
>  + build a custom 404 page and redirect users to this page. so they can go
> to the homepage and use the search function to find what they want.
>  + use htaccess to redirect all old style url to new url, it will have
> better user experience but I'm not sure how much work it needs.
>
> If anyone has experience with related stuff, could you please give some
> suggestions?
>
> Thanks
> Yunkun
>


Re: 请教dubbo文档问题

2021-01-26 Thread Ian Luo
Now it's moved to here: http://dubbo.apache.org/zh/docs/v2.7/dev/source/

-Ian.

On Wed, Jan 27, 2021 at 10:20 AM 597690494 <597690...@qq.com> wrote:

> 您好!
> 请问一下怎么之前的源码分析文档搬到哪去了,还有保存吗?就是之前的dubbo中文文档地址,
> 现在http://dubbo.apache.org/zh/docs/v2.7/dev/checklist/ 这个地址上看不见了。


Re: [Suggest] dubbo website from http to https

2021-01-26 Thread Ian Luo
+1. It should not be difficult to switch to https.

-Ian.

On Wed, Jan 27, 2021 at 11:06 AM YunKun Huang  wrote:

> Not sure. If we all agree with this (use https instead of http), I can see
> the following things we can do by ourselves
>
> 1.update all links in dubbo website to use https
> 2.add a htaccess file to redirect all http request to https
>
> I also noticed there is a link in the github repo description, not sure if
> that one needs infra to update.
>
> If there is no opposition, we can start with the first two things.
>
>
> On Tue, Jan 26, 2021 at 11:21 PM Jun Liu  wrote:
>
> > Hi, YunKun
> >
> > Do you mean we need to resort to infra team for help?
> >
> > Jun
> >
> > > On Jan 26, 2021, at 4:17 PM, YunKun Huang  wrote:
> > >
> > > I don't think we need a CA. because https://dubbo.apache.org works
> well
> > at
> > > this moment.
> > >
> > > Maybe we only need to add some configuration to the website to make
> > > redirection works.
> > >
> > > On Tue, Jan 26, 2021 at 10:21 AM YiXian Zou 
> > wrote:
> > >
> > >> Hi,
> > >>   Can it[1][2] help you?
> > >>   But I think you need a CA for https, do you have?
> > >>
> > >> [1]:https://blog.mimvp.com/article/20403.html
> > >> [2]:
> > https://www.ssl.com/zh-CN/how-to/redirect-http-to-https-with-apache/
> > >>
> > >> YunKun Huang  于2021年1月25日周一 下午3:23写道:
> > >>
> > >>> hey all,
> > >>>
> > >>> I noticed dubbo website[1] supports both http and https
> > >>> + http://dubbo.apache.org/
> > >>> + https://dubbo.apache.org/
> > >>>
> > >>> I'm not sure how the website server is configured but I suggest to
> > >> redirect
> > >>> all requests to https. It can be done by adding .htaccess[2] file in
> > the
> > >>> root folder.
> > >>>
> > >>> Any thoughts?
> > >>>
> > >>> [1] https://github.com/apache/dubbo-website
> > >>> [2] https://httpd.apache.org/docs/current/howto/htaccess.html
> > >>>
> > >>
> >
> >
>


Re: [ANN] Welcome a new Committer Cityiron

2021-01-19 Thread Ian Luo
Congratulations and welcome :)

Cheers,
-Ian.

On Tue, Jan 19, 2021 at 11:30 AM joezou  wrote:

> Hi, Community,
>
> On behalf of  the Dubbo PMC, Iam pleased to announce that cityiron[1] has
> been voted in as a new Dubbo committer.
>
> Please join me to say congratulations to him.
>
> Cityiron, would you please briefly introduce yourself to the community?
>
> 1.https://github.com/cityiron
>
> Thanks and Regards,
> Joe.
>


Re: [Brand issue] ASF Navigation Links in website

2020-11-17 Thread Ian Luo
Ming, we aware of this issue, and it's still under construction. We will
make it online as soon as possible.

Thanks,
-Ian.

On Tue, Nov 17, 2020 at 5:15 PM Ming Wen  wrote:

> hello, dubbo community,
> According to ASF Website Navigation Links Policy[1], `License`
> `Sponsorship` `Security` etc. links should appear on every page especially
> the homepage.
> But none of these links on dubbo's website[2].
> please take a look.
>
> [1] http://www.apache.org/foundation/marks/pmcs#navigation
> [2] http://dubbo.apache.org/
>
> Thanks,
> Ming Wen, Apache APISIX PMC Chair
> Twitter: _WenMing
>


Re: Github Action for apache/dubbo CI

2020-11-16 Thread Ian Luo
Nice job :)


On Mon, Nov 16, 2020 at 7:12 PM YunKun Huang  wrote:

> AlbumenJ did lots of work to make unit test works with Github Action.
>
> I have merged PR (https://github.com/apache/dubbo/pull/6726) into master.
> Let's see how it goes and we can decide if we want to disable travis ci in
> the future.
>
> On Thu, Nov 12, 2020 at 11:06 AM YiXian Zou  wrote:
>
> > Hi Yunkun
> >  Github Action is awesome.  We had used it in  Dubbo-go project.
> >  If use Travis CI would wait more than 30 minutes from 15:00  to
> 18:00
> > before run , but Github Action would not and no other problems so far.
> >  So you can tried it.
> >
> > YunKun Huang  于2020年11月12日周四 上午10:44写道:
> >
> > > hey team,
> > >
> > > There is a PR for adding github action for apache/dubbo repo:
> > > https://github.com/apache/dubbo/pull/6726
> > >
> > > We are using travis ci at this moment and comparing with Github
> > Action[1],
> > > I can see some benefits to moving to Github Action:
> > >
> > > 1.Move powerful ecosystem
> > > 2.Easy integration with more github activity
> > >
> > > There are some discussions about GitHub Actions Concurrency Limits for
> > > Apache projects[2]. it may become an issue when we add more github
> action
> > > for different github activity, but from my personal view, it should be
> ok
> > > at this stage.
> > >
> > > I suggest to try github action now and keep travis ci at same time. We
> > can
> > > try for example one month to see if things work well.
> > >
> > > [1] Github Action: https://github.com/features/actions
> > > [2] GitHub Actions Concurrency Limits for Apache projects:
> > > https://www.mail-archive.com/builds@apache.org/msg07478.html
> > >
> >
>


Re: [GitHub] [dubbo-go-samples] zouyx merged pull request #2: Test: v1.5.3

2020-10-20 Thread Ian Luo
got it, pls. ignore. Thanks YunKun for configuring it.

-Ian.

On Wed, Oct 21, 2020 at 12:50 PM Ian Luo  wrote:

> How to disable it?
>
> On Tue, Oct 20, 2020 at 7:22 PM YunKun Huang  wrote:
>
>> Notification configuration has updated to send those info to
>> notifcation@dev
>> channel
>>
>> On Fri, Oct 16, 2020 at 10:57 AM GitBox  wrote:
>>
>> >
>> > zouyx merged pull request #2:
>> > URL: https://github.com/apache/dubbo-go-samples/pull/2
>> >
>> >
>> >
>> >
>> >
>> > 
>> > This is an automated message from the Apache Git Service.
>> > To respond to the message, please log on to GitHub and use the
>> > URL above to go to the specific comment.
>> >
>> > For queries about this service, please contact Infrastructure at:
>> > us...@infra.apache.org
>> >
>> >
>> >
>>
>


Re: [GitHub] [dubbo-go-samples] zouyx merged pull request #2: Test: v1.5.3

2020-10-20 Thread Ian Luo
How to disable it?

On Tue, Oct 20, 2020 at 7:22 PM YunKun Huang  wrote:

> Notification configuration has updated to send those info to
> notifcation@dev
> channel
>
> On Fri, Oct 16, 2020 at 10:57 AM GitBox  wrote:
>
> >
> > zouyx merged pull request #2:
> > URL: https://github.com/apache/dubbo-go-samples/pull/2
> >
> >
> >
> >
> >
> > 
> > This is an automated message from the Apache Git Service.
> > To respond to the message, please log on to GitHub and use the
> > URL above to go to the specific comment.
> >
> > For queries about this service, please contact Infrastructure at:
> > us...@infra.apache.org
> >
> >
> >
>


Re: [VOTE]: Release Apache dubbo-go v1.5.2-rc1

2020-10-12 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because.

-Ian.

On Sun, Sep 27, 2020 at 9:45 AM joezou  wrote:

> Hello Dubbo/Dubbogo Community,
>
>   This is a call for vote to release Apache dubbo-go version v1.5.2-rc1.
>
>   The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.5.2-rc1/
>
>   Git tag for the release:
> https://github.com/apache/dubbo-go/releases/tag/v1.5.2-rc1
>
>   Hash for the release tag: 2f1d1e50390a06f4f63c783adfd40be235987159
>
>   Release Notes: https://github.com/apache/dubbo-go/blob/1.5/CHANGE.md
>
>   The artifacts have been signed with Key :4B87D4B65EEFB515, which can be
> found in the keys file: https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
>   The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
>  Please vote accordingly:
>  [ ] +1 approve
>  [ ] +0 no opinion
>  [ ] -1 disapprove with the reason
>
>  Thanks,
>  The Apache Dubbo-go Team
>


Re: Roadmap of Dubbo Python project

2020-10-12 Thread Ian Luo
Tien Dat,

Unfortunately Dubbo community don't have many python developers, therefore
there's no clear roadmap yet for this project. You may need to ping its
original author @RitterHou [1] who may have the answer you need.

Regards,
-Ian.

1. https://github.com/RitterHou


On Tue, Oct 6, 2020 at 10:17 PM Tien Dat PHAN  wrote:

> Dear experts,
>
> We are using Dubbo as our main service registry.
> We are trying to access to the service registry from Zeppelin notebook, on
> which the main language is Python.
> And we found this nice project on Github that provides Python client for
> accessing Dubbo: https://github.com/apache/dubbo-python
> We just saw that this project is fairly inactive. Does the community plan
> any roadmap on this project? Or does it exist alternative project, that is
> currently active, which provides the similar functionality?
>
> Best regards
> Tien Dat PHAN
>
>


Re: [VOTE]: Move dubbo-go samples out of dubbo-samples

2020-09-30 Thread Ian Luo
+1 to approve.

On Tue, Sep 29, 2020 at 12:13 AM joezou  wrote:

> Hello Dubbo/Dubbogo Community,
>
> This is a call for a vote to move dubbo-go samples[1] out of
> dubbo-samples[2] , migrate to a new project which is called
> dubbo-go-samples.
>
> Now dubbo-samples include java and golang samples.For samples is great ,but
> it is not good for managing integration testing for both versions.
>
> Besides we want to add integration testing based on dubbo-go-samples from
> now on ,but dubbo-samples[2] of java took a long time for integration
> testing each time, close to 30 minutes [3]. Now more than 20 golang
> samples, if take 1 minute for a sample, expect more than 20 minutes.
>
> So we want to be independent of dubbo-samples.
>
>
> [1]:https://github.com/apache/dubbo-samples/tree/master/golang
> [2]:https://github.com/apache/dubbo-samples
> [3]:https://travis-ci.org/github/apache/dubbo-samples/builds/730989552
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo Team
>


Re: [Brand issue] microservices summit link in website

2020-08-26 Thread Ian Luo
Ming,

Would you mind to quote where this action is prohibited from apache's
policy so that we can avoid the potential risk in the future?

Thanks,
-Ian.


On Wed, Aug 26, 2020 at 4:10 PM jun liu  wrote:

> > According to Apache Project Website Branding Policy[1],
> > I think adding commercial company link in the main navigation bar does
> not
> > meet the policy of the apache brand.
>
> I read this page before, still, I don’t see why this volatiles the Apache
> rule. I think Apache Dubbo can attend this conference and is free to put it
> in the homepage or in a blog hosted by the website. It’s an open summit
> with some open topics.
>
> Please correct me if I am wrong. BTW, I have removed the summit link from
> the website to avoid further risks before this is clear.
>
> Jun
>
> > On Aug 20, 2020, at 6:13 PM, Ming Wen  wrote:
> >
> > Hi, Jun,
> > According to Apache Project Website Branding Policy[1],
> > I think adding commercial company link in the main navigation bar does
> not
> > meet the policy of the apache brand.
> >
> > [1] http://www.apache.org/foundation/marks/pmcs
> >
> > Thanks,
> > Ming Wen, Apache APISIX & Apache SkyWalking
> > Twitter: _WenMing
> >
> >
> > Jun Liu  于2020年8月20日周四 下午2:22写道:
> >
> >> Hi, Ming
> >>
> >> I don’t think it’s a brand issue, we just want people to notice the
> "Dubbo
> >> 3.0 topic” more easily as we just had this topic on this summit. Dubbo
> 3.0
> >> is considered as our next major version, so we want developers to know
> more
> >> about it and get involved in the Roadmap[1] discuss, this submit is a
> great
> >> chance for us to spread this concept out as it’s very likely to have a
> wide
> >> audience in China.
> >>
> >> I think it doesn’t matter who is the sponsor or organizer of this
> summit,
> >> the Dubbo 3.0 topic has been discussed in here[2]
> >>
> >> 1.
> >>
> https://lists.apache.org/thread.html/r80eb7a40ae91790c7ea99cef76e2081e06de6dbdd1c33f850530b833%40%3Cdev.dubbo.apache.org%3E
> >> 2.
> >>
> https://lists.apache.org/thread.html/r5fec24516ecf426b1653e9e953055e1989a32ce0a4ede541d674ff8f%40%3Cdev.dubbo.apache.org%3E
> >>
> >> Jun
> >>
> >>> On Aug 19, 2020, at 9:33 PM, Ming Wen  wrote:
> >>>
> >>> hello, dubbo community,
> >>> I found a new link to the microservice summit[1] on the homepage of
> >> dubbo's
> >>> website[2],
> >>> and was introduced by this commit[3].
> >>> This summit is hosted by Alibaba Cloud, so I want to know whether this
> >>> change has passed the community discussion?
> >>>
> >>> [1] https://developer.aliyun.com/topic/microservices2020#/
> >>> [2] http://dubbo.apache.org/en-us/index.html
> >>> [3]
> >>>
> >>
> https://github.com/apache/dubbo-website/commit/17e5e47ad666a892ad3892bd9f0b72cafc4f46c2
> >>>
> >>> Thanks,
> >>> Ming Wen, Apache APISIX & Apache SkyWalking
> >>> Twitter: _WenMing
> >>
> >>
>
>


Re: [VOTE]: Release Apache dubbo-go v1.5.1

2020-08-26 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..

-Ian.


On Mon, Aug 24, 2020 at 12:32 AM joezou  wrote:

> Hello Dubbo/Dubbogo Community,
>
>   This is a call for vote to release Apache dubbo-go version v1.5.1.
>
>   The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.5.1/
>
>   Git tag for the release:
> https://github.com/apache/dubbo-go/releases/tag/v1.5.1
>
>   Hash for the release tag: 292850223fae4ed73506810efb179ac969fcbf5b
>
>   Release Notes: https://github.com/apache/dubbo-go/blob/1.5/CHANGE.md
>
>   The artifacts have been signed with Key :4B87D4B65EEFB515, which can be
> found in the keys file: https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
>   The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
>  Please vote accordingly:
>  [ ] +1 approve
>  [ ] +0 no opinion
>  [ ] -1 disapprove with the reason
>
>  Thanks,
>  The Apache Dubbo-go Team
>


Re: [VOTE] Release Apache Dubbo 2.6.9 RC1

2020-07-22 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..

Regards,
-Ian.

On Fri, Jul 17, 2020 at 2:15 PM Jun Liu  wrote:

> Hello Dubbo Community,
>
> This is a call for vote to release Apache Dubbo version 2.6.9.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo/2.6.9/
>
> Git tag for the release:
> https://github.com/apache/dubbo/releases/tag/dubbo-2.6.9
>
> Hash for the release tag:
> d895bf15d0dda6a69c552c6b06d5e452692bef53
>
> Release Notes:
> https://github.com/apache/dubbo/releases/tag/dubbo-2.6.9
>
> The artifacts have been signed with Key: 28681CB1, which can be found in
> the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo Team
>
>


Re: [VOTE]: Release Apache dubbo-go v1.5.0 RC1

2020-07-22 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..

Regards,
-Ian.

On Thu, Jul 16, 2020 at 1:44 AM 方银城  wrote:

> Hello Dubbo/Dubbogo Community,
>
>   This is a call for vote to release Apache dubbo-go version v1.5.0 RC1.
>
>   The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.5.0-rc1/
>
>   Git tag for the release:
> https://github.com/apache/dubbo-go/releases/tag/v1.5.0-rc1
>
>   Hash for the release tag: 57d7b5bd0005f3230e3236e0111fb05dab22cc4e
>
>   Release Notes: https://github.com/apache/dubbo-go/blob/1.5/CHANGE.md
>
>   The artifacts have been signed with Key :5862908F9A627BAA, which can be
> found in the keys file: https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
>   The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
>  Please vote accordingly:
>  [ ] +1 approve
>  [ ] +0 no opinion
>  [ ] -1 disapprove with the reason
>
>  Thanks,
>  The Apache Dubbo-go Team
>


Re: [VOTE] Release Apache Dubbo-Hessian-Lite 3.2.9 RC1

2020-07-22 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[x] Is there any 3rd party code contained inside the release? If so:
  [ ] Does the software have a compatible license?
  [ ] Are all software licenses mentioned in LICENSE?
  [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
  Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ] Have relevant parts of those NOTICE files been added to this NOTICE
file?
[ ] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..

Regards,
-Ian.

On Fri, Jul 17, 2020 at 11:37 AM Jun Liu  wrote:

> Hello Dubbo Community,
>
> This is a call for a vote to release Apache Dubbo-hessian-lite version
> 3.2.9
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-hessian-lite/
>
> Git tag for the release:
> https://github.com/apache/dubbo-hessian-lite/tree/v3.2.9
>
> The hash for the release tag:
> 6ebfa92ecad6bb6c4ab412c26382596e7b2bbada
>
> Release Notes:
> https://github.com/apache/dubbo-hessian-lite/releases/tag/v3.2.9
>
> The artifacts have been signed with Key: 28681CB1, which can be found in
> the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until the necessary number
> of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo Team
>


Re: [VOTE]: Accept dubbogo/getty donation

2020-07-20 Thread Ian Luo
Justin,

Would you mind shine some light on this particular issue? I am not sure if
a IP clearance report is necessary.

Thanks,
-Ian.


On Mon, Jul 20, 2020 at 9:39 PM stocks alex  wrote:

> Hi guys, I have sent out my SGA last Saturday. And What's more, I have got
> enough vote tickets, What should I do now?
>
> Ian Luo  于2020年7月15日周三 下午10:20写道:
>
> > +1
> >
> > On Wed, Jul 15, 2020 at 10:48 AM Jun Liu  wrote:
> >
> > > I think it’s better if can sort out all the IP CLEARANCE things before
> > > reach consensus on this vote.
> > >
> > > Jun
> > >
> > > > On Jul 13, 2020, at 10:13 PM, Justin Mclean <
> jus...@classsoftware.com>
> > > wrote:
> > > >
> > > > Hi,
> > > >
> > > >> I know what u mean. However, this is a vote email. If we completed
> the
> > > vote
> > > >> process, and then we start to sign the ICLA OR  SGA as I know.
> > > >
> > > > IMO it would be better if these issues were sorted out before a vote
> is
> > > called - but that is up to the PPMC to work out.
> > > >
> > > > Thanks,
> > > > Justin
> > > >
> > >
> > >
> >
>


Re: [DISCUSSION] Define the next generation Dubbo - Dubbo 3.0

2020-07-20 Thread Ian Luo
>
> + Define Dubbo ecosystem
> Currently Dubbo is big and there are many related repos, some of them don't
> have updates for a long time.
> It's better to have a clean understanding here. to define what Dubbo can
> provide and will continually maintain.


Agree, this becomes a challenge to all of us. I believe a clear roadmap can
attract more people to join us to build them better other than dubbo java
and dubbo go. At the same moment I am thinking if it is a good idea to move
some extension impls out from the main repo, and keep them one
separated repo named 'dubbo-extensions' so we can boost the speed from the
perspective of both development and build.

+ Roadmap and release plan
> For Dubbo 3.0, when there is a clean picture what it should look like. We
> need a roadmap.
> And also for each version, exclude bug fixes, what kind of feature will
> include and what may include.
> This can help users to know what's happening to Dubbo and what's the next
> step, so they can make better plans for their own stuff, like version
> upgrading.


+1. First of all, for this time we need to define a clear target for
version 3.0, and summarize it not only in this mailing list, but also post
it on GitHub, so that peoples can understand better what dubbo 3.0 is, and
I agree it is a good idea to keep posting the update by weekly or monthly
so that everyone know how the project proceeds, no matter they involve
themselves in the project or not.

+ Integration with other project/systems
> My understanding for Cloud Native, there are many great projects in the
> ecosystem. Dubbo is a PRC framework and many of Cloud features can be
> implemented with other projects/systems,
> maybe we can discuss what project/systems can Dubbo work together with,
> maybe for monitoring, service discovery, tracing, router and more.


+1, there are two things out of my brain right now with regarding to what
we should support for Cloud Native, one is service discovery in K8s, and
the second is direct xDS support in order to make Dubbo work better with
other sidecar in service mesh.

Regards,
-Ian.


On Fri, Jul 17, 2020 at 1:20 PM YunKun Huang  wrote:

> hey,
>
> Cloud Native friendly sounds good. but how to define it? What dubbo needs
> change to achieve this?
>
> I would like to add more topic for Dubbo 3.0
>
> + Define Dubbo ecosystem
> Currently Dubbo is big and there are many related repos, some of them don't
> have updates for a long time.
> It's better to have a clean understanding here. to define what Dubbo can
> provide and will continually maintain.
>
> + Roadmap and release plan
> For Dubbo 3.0, when there is a clean picture what it should look like. We
> need a roadmap.
> And also for each version, exclude bug fixes, what kind of feature will
> include and what may include.
> This can help users to know what's happening to Dubbo and what's the next
> step, so they can make better plans for their own stuff, like version
> upgrading.
>
> + Integration with other project/systems
> My understanding for Cloud Native, there are many great projects in the
> ecosystem. Dubbo is a PRC framework and many of Cloud features can be
> implemented with other projects/systems,
> maybe we can discuss what project/systems can Dubbo work together with,
> maybe for monitoring, service discovery, tracing, router and more.
>
> Yunkun
>
>
> On Thu, Jul 16, 2020 at 7:37 PM Jun Liu  wrote:
>
> > Hi, Folks
> >
> > I would like to initiate a discussion about Dubbo 3.0.
> >
> > Recently, I was thinking about the next generation Dubbo, focusing on
> > supporting larger-scale cluster with millions of instances, adapting to
> > cloud native infrastructures, working with Service Mesh, etc.. I also
> > noticed that many developers in the community are also discussing this
> > topic on GitHub and other occasions recently. Most users want to make
> their
> > Dubbo based micro-services Cloud Native, this requires the change of
> Dubbo
> > framework itself.
> >
> > In my mind, the key word of Dubbo 3.0 should be Cloud Native, we should
> > focus on making a plan to create a more Cloud Native friendly RPC
> > framework. Approximately in 2018, the community had a discussion on
> > defining Dubbo 3.0, which is mostly restricted the theme of Reactive
> > Stream. But today, when talking about Dubbo 3.0 again, i think Reactive
> > Stream is still an important topic, but we should think much broader.
> >
> > I am just trying to give out some of my own thoughts on Dubbo 3.0. Hope
> to
> > hear more from you.
> >
> > Jun
> >
> >
>


Re: [VOTE]: Accept dubbogo/getty donation

2020-07-15 Thread Ian Luo
+1

On Wed, Jul 15, 2020 at 10:48 AM Jun Liu  wrote:

> I think it’s better if can sort out all the IP CLEARANCE things before
> reach consensus on this vote.
>
> Jun
>
> > On Jul 13, 2020, at 10:13 PM, Justin Mclean 
> wrote:
> >
> > Hi,
> >
> >> I know what u mean. However, this is a vote email. If we completed the
> vote
> >> process, and then we start to sign the ICLA OR  SGA as I know.
> >
> > IMO it would be better if these issues were sorted out before a vote is
> called - but that is up to the PPMC to work out.
> >
> > Thanks,
> > Justin
> >
>
>


Re: [VOTE]: Accept dubbogo/getty donation

2020-07-12 Thread Ian Luo
+1 to accept. I believe all major contributors all come from dubbo
comitter, but Alex, pls. double check.

Thanks,
-Ian.

On Sun, Jul 12, 2020 at 12:51 PM stocks alex  wrote:

> Hi guys,
>
> This is a formal vote to bring dubbogo/getty[1], which is depended
> by apache/dubbo-go, to Apache Dubbo project.
>
> What's more, the copyright of this repo is owned by myself and it has been
> written since 2016.
>
> Please vote:
>
> [ ] +1 Accept
> [ ] +0 No Opinion
> [ ] -1 Reject because...
>
> [1] https://github.com/dubbogo/getty
>


Re: Offline document

2020-07-08 Thread Ian Luo
Sushi,

If you prefer the offline doc, you could build one from the scratch. Pls.
follow the build instruction of dubbo-website [1], and feel free to drop me
any further question if anything blocks you from building it.

Regards,
-Ian.

1.  https://github.com/apache/dubbo-website



On Thu, Jul 2, 2020 at 1:22 PM sushixiang  wrote:

> Hi everyone, I want to know does Dubbo have offline document?


Re: [VOTE] Release Apache Dubbo-Hessian-Lite 3.2.8 RC1

2020-07-02 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[x] Is there any 3rd party code contained inside the release? If so:
  [ ] Does the software have a compatible license?
  [ ] Are all software licenses mentioned in LICENSE?
  [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
  Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ] Have relevant parts of those NOTICE files been added to this NOTICE
file?
[ ] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..

Regards,
-Ian.


On Mon, Jun 29, 2020 at 6:34 PM Jun Liu  wrote:

> Hello Dubbo Community,
>
> This is a call for a vote to release Apache Dubbo-hessian-lite version
> 3.2.8
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-hessian-lite/
>
> Git tag for the release:
> https://github.com/apache/dubbo-hessian-lite/tree/v3.2.8
>
> The hash for the release tag:
> ae090564e1f0ee759c7253c66266f838d57640c8
>
> Release Notes:
> https://github.com/apache/dubbo-hessian-lite/releases/tag/V3.2.8
>
> The artifacts have been signed with Key: 28681CB1, which can be found in
> the KEYS file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until the necessary number
> of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo Team
>
>


Re: [VOTE]: Release Apache Dubbo Spring Boot 2.7.7 [RC1]

2020-06-02 Thread Ian Luo
Everything looks good except for the "Copyright 2018-2019 The Apache
Software Foundation" in NOTICE file. I suggest we should fix it in this
release.

-1 binding.

-Ian.


On Fri, May 29, 2020 at 3:01 PM Mercy Ma  wrote:

> Hi, All
>
> This is a call for a vote to release Apache Dubbo Spring Boot version
> 2.7.7.
>
> The release candidates (there will be only source release in this version):
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-spring-boot/2.7.7/ <
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-spring-boot/2.7.7/>
>
> Git tag for the release:
> https://github.com/apache/dubbo-spring-boot-project/tree/2.7.7 <
> https://github.com/apache/dubbo-spring-boot-project/tree/2.7.7>
>
> Hash for the release tag:
> 2dc6e372b921019d40be713152f76c14b81bfdb8
>
> Release Notes:
> https://github.com/apache/dubbo-spring-boot-project/releases/tag/2.7.7 <
> https://github.com/apache/dubbo-spring-boot-project/releases/tag/2.7.7>
>
> The artifacts have been signed with Key: 28681CB1, which can be
> found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS <
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS>
>
> The vote will be open for at least 72 hours or until the necessary number
> of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo Team
>


Re: .asf.yaml file

2020-05-19 Thread Ian Luo
Has this been done for dubbo-go, Alex?

Thanks,
-Ian.

On Wed, Apr 29, 2020 at 12:41 PM stocks alex  wrote:

> Hi, Mr Huang,
>
> Thank you so much for your pr. I got so much noisy mail too. It is really a
> noise for our community.
>
> Thanks again.
>
> YunKun Huang  于2020年4月29日周三 上午10:29写道:
>
> > hey,
> >
> > recently somehow gitbox send all pull request activity for dubbo-go
> > project to dev channel maillist,
> > it cause much noise and it's better to have those in notification
> channel.
> >
> > According to this wiki:
> >
> https://cwiki.apache.org/confluence/display/INFRA/.asf.yaml+features+for+git+repositories#id-.asf.yamlfeaturesforgitrepositories-Notificationsettingsforrepositories
> > we can use .asf.yaml file to control this, I already commit a change to
> > dubbo-go repo.
> >
> > If this works well, I suggest all dubbo projects should check their own
> > configuration. (link https://gitbox.apache.org/schemes.cgi?dubbo-go) and
> > create .asf.yaml file if necessary
> >
>


Re: dubbo-build-tools?

2020-05-19 Thread Ian Luo
Not sure, haven't not had chance to look into the details. Would you mind
to fire an issue on GitHub and ping the original author, @mercyblitz?

Thanks,
-Ian.

On Sun, May 17, 2020 at 9:06 PM YunKun Huang  wrote:

> why we need a new subproject for this?
> can rat-plugin or checkstyle-plugin meet the requirements?
>
> it's so weird that there is a subproject with version 1.0.0 and include in
> dubbo-all project.
> do we need this one deploy to repo? what's the version strategry for this
> project?
>
> On Sat, May 16, 2020 at 12:52 AM Ian Luo  wrote:
>
> > Correct. This change is introduced to make sure all files should have a
> > intended ASF header.
> >
> > -Ian.
> >
> > On Tue, Apr 28, 2020 at 11:10 AM Kevin Albumen 
> > wrote:
> >
> > > Hello,
> > >
> > > According to the git history, the dubbo-build-tools is created by
> #6060<
> > > https://github.com/apache/dubbo/pull/6060>, and its role is to
> provide a
> > > checkstyle-header.txt<
> > >
> >
> https://github.com/apache/dubbo/blob/master/dubbo-build-tools/src/main/resources/checkstyle-header.txt
> > >
> > > file.
> > > This file will provide a template to make files consistent when
> checking
> > > ASF license header for java files.
> > >
> > > 
> > > 发件人: YunKun Huang 
> > > 发送时间: 2020年4月28日 10:12
> > > 收件人: Dubbo Dev Group 
> > > 主题: dubbo-build-tools?
> > >
> > > hey,
> > >
> > > I notice our snapshot deployment job fail recently (
> > >
> > >
> >
> https://builds.apache.org/job/Apache%20Dubbo/job/apache-dubbo-snapshot-deployment/1036/consoleFull
> > > ),
> > > but travis ci is passing.
> > >
> > > According to jenkins log, it looks like there is a new module named `
> > > dubbo-build-tools` which fail snapshot deployment process.
> > >
> > > Does anyone have idea about this? what's the purpose of this?
> > >
> >
>


Re: dubbo-build-tools?

2020-05-15 Thread Ian Luo
Correct. This change is introduced to make sure all files should have a
intended ASF header.

-Ian.

On Tue, Apr 28, 2020 at 11:10 AM Kevin Albumen  wrote:

> Hello,
>
> According to the git history, the dubbo-build-tools is created by #6060<
> https://github.com/apache/dubbo/pull/6060>, and its role is to provide a
> checkstyle-header.txt<
> https://github.com/apache/dubbo/blob/master/dubbo-build-tools/src/main/resources/checkstyle-header.txt>
> file.
> This file will provide a template to make files consistent when checking
> ASF license header for java files.
>
> 
> 发件人: YunKun Huang 
> 发送时间: 2020年4月28日 10:12
> 收件人: Dubbo Dev Group 
> 主题: dubbo-build-tools?
>
> hey,
>
> I notice our snapshot deployment job fail recently (
>
> https://builds.apache.org/job/Apache%20Dubbo/job/apache-dubbo-snapshot-deployment/1036/consoleFull
> ),
> but travis ci is passing.
>
> According to jenkins log, it looks like there is a new module named `
> dubbo-build-tools` which fail snapshot deployment process.
>
> Does anyone have idea about this? what's the purpose of this?
>


Re: [VOTE] Release Apache Dubbo 2.7.7

2020-05-15 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[x] Is there any 3rd party code contained inside the release? If so:
  [ ] Does the software have a compatible license?
  [ ] Are all software licenses mentioned in LICENSE?
  [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
  Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ] Have relevant parts of those NOTICE files been added to this NOTICE
file?
[ ] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..

Regards,
-Ian.


On Tue, May 12, 2020 at 5:09 PM Hengyunabc Chen 
wrote:

> Hello Dubbo Community,
>
> This is a call for vote to release Apache Dubbo version 2.7.7.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo/2.7.7/
>
> The staging repo:
> https://repository.apache.org/content/repositories/orgapachedubbo-1118/
>
> Git tag for the release:
> https://github.com/apache/dubbo/releases/tag/dubbo-2.7.7
>
> Hash for the release tag:
> 96de4d9edaa15432e1f67b2d62dab8da9bfb96a1
>
> Release Notes:
> https://github.com/apache/dubbo/releases/tag/dubbo-2.7.7
>
> The artifacts have been signed with Key : 908A54D9, which can be found in
> the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo Team
>


Re: [ANN] Welcome a new committer Patrick Jiang (baze)

2020-05-15 Thread Ian Luo
congratulations, and welcome to dubbo community :)

Cheers,
-Ian.

On Sat, May 9, 2020 at 12:45 PM stocks alex  wrote:

> Hello, guys,
>
> On behalf of the Apache Dubbo PMC, it is my honor to announce that Patrick
> Jiang[1] has been voted in as a new Dubbo committer.
>
> Please join me to say congratulations to him!
>
> Patrick, would you give us a briefly introduce of yourself to the
> community?
>
> 1. https://github.com/Patrick0308
>
> Yours,
> Alex.
>


Re: [GitHub] [dubbo-go] hxmhlt commented on issue #467: tps limit leaky bucket implementation

2020-04-24 Thread Ian Luo
@YunKun Huang  has this been addressed?

Thanks,
-Ian.

On Wed, Apr 22, 2020 at 5:31 PM Yunkun Huang  wrote:

> Those notification should not go to @dev maillist.
>
> Could someone have a look?
>
> On 2020/04/22 09:04:20, GitBox  wrote:
> >
> > hxmhlt commented on issue #467:
> > URL: https://github.com/apache/dubbo-go/pull/467#issuecomment-617651532
> >
> >
> >问个问题,漏桶限流算法不是有开源的吗?自己造轮子有必要吗
> >
> >
> > 
> > This is an automated message from the Apache Git Service.
> > To respond to the message, please log on to GitHub and use the
> > URL above to go to the specific comment.
> >
> > For queries about this service, please contact Infrastructure at:
> > us...@infra.apache.org
> >
> >
> >
>


Re: [DISCUSS] Speed up the building process of the project

2020-04-24 Thread Ian Luo
+1 to move out extra plugins into separated repo.

-Ian.

On Thu, Apr 23, 2020 at 5:26 PM YunKun Huang  wrote:

> I checked travis ci, currently master branch build time is around 15~25
> minutes. For my view, it's not a big number.
>
> for 1. I think it's really depends on how we treat those SPI extensions, if
> they are not part of core feature, yes let's do this. but we need find a
> way to handle release process between different repos and also handle
> different issue in different repo.
>
> for 2. if some plugins are unnecessary, we need considering remove them
> instead of disable them.
>
> if only consider reducing build time, how are about multiple threads build?
> we can run multi CI  build at same time.
> Also if build in your own PC, we can special project when exec maven
> command
>
> On Thu, Apr 23, 2020 at 11:36 AM Jun Liu  wrote:
>
> > Hi,
> >
> > The building time of the whole Dubbo project is going out of control,
> with
> > one local construction cost nearly 10 minutes. I think there are two
> > reasons in essence:
> >
> > 1. Now the Dubbo project is becoming larger and larger, with too many SPI
> > extension implementations. We should consider moving those extensions to
> a
> > sub project, for example a new project named "apache/dubbo-ecosystem”.
> >
> > 2. Disable some unnecessary plug-ins to speed up the local build
> >
> > What do you think?
> >
> > Jun
> >
> >
>


Re: [VOTE] Release Apache dubbo-go v1.4.0 RC2

2020-04-17 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[x] Is there any 3rd party code contained inside the release? If so:
  [ ] Does the software have a compatible license?
  [ ] Are all software licenses mentioned in LICENSE?
  [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
  Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ] Have relevant parts of those NOTICE files been added to this NOTICE
file?
[ ] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..

Regards,
-Ian.

On Thu, Apr 16, 2020 at 2:25 PM wongoo  wrote:

> Hello Dubbo/Dubbogo Community,
>
>  This is a call for vote to release Apache dubbo-go version v1.4.0 RC2.
>
>  The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.4.0-rc2/
>  Git tag for the release: https://github.com/apache/dubbo-go/tree/1.4
>  Hash for the release tag: 320e307b92edb5466ad55db10342ad3eee95c982
>  Release Notes: https://github.com/apache/dubbo-go/blob/1.4/CHANGE.md
>  The artifacts have been signed with Key :7DB68550D366E4C0, which can be
> found in the keys file:
>  https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
>  The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
>  Please vote accordingly:
>  [ ] +1 approve
>  [ ] +0 no opinion
>  [ ] -1 disapprove with the reason
>
>  Thanks,
>  The Apache Dubbo-go Team
>


Re: Updating the exported services on the fly with DubboBootstrap

2020-04-13 Thread Ian Luo
Not sure if org.apache.dubbo.registry.integration.RegistryProtocolListener
satisfies your scenarios, pls. check it out.

-Ian.


On Thu, Apr 9, 2020 at 3:32 PM Tien Dat PHAN  wrote:

> Dear HaopengZH,
>
> Thanks for your advice.
> Just wanted to make it clear for me. I can extending the listener
> interface and implement a new listener in my Java project, OR I have to
> change the Dubbo 2.7.6 original code to add this new listener?
>
> Best regards
> Tien Dat PHAN
>
> On 2020/04/09 06:44:09, HaopengZH <15071228...@163.com> wrote:
> > dubbo support disable services at consumer side at now,you want to
> disable special service ,I think you need change the original code ,add a
> listener to listen the configurator's changes
> > At 2020-04-08 23:50:46, "Tien Dat PHAN"  wrote:
> > >Dear experts,
> > >
> > >We are using Dubbo 2.7.6.
> > >The DubboBootstrap is the newest way of managing the exported APIs and
> the API references.
> > >For our use case, we have several different APIs to be exported. Each
> API exposes a specific service from one or several components of our
> cluster.
> > >During the runtime, we have health check threads to check the health of
> the underlying components. Accordingly, we would like to un-export the
> exported APIs using the unhealthy component (without un-exporting the other
> APIs using heathy components). Upon the components health status is back to
> good, we also would like to re-export the corresponding APIs.
> > >
> > >So far, we could not find a proper way to handle this use case with
> DubboBootstrap.
> > >With DubboBootstrap, the initialization (including exporting services)
> is only invoked when starting the Bootstrap. And a
> DubboBootstrap.getInstance().stop() will simply stop every services.
> > >We could not find a way to update a targeted service after starting the
> DubboBootstrap.
> > >
> > >Do you have any experience regarding this aspect?
> > >We will highly appreciate if you can enlighten us with your expertise.
> > >
> > >Best regards
> > >Tien Dat PHAN
> >
>


Re: [VOTE] Release Apache Dubbo 2.7.6 RC3

2020-03-27 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[x] Is there any 3rd party code contained inside the release? If so:
  [ ] Does the software have a compatible license?
  [ ] Are all software licenses mentioned in LICENSE?
  [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
  Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ] Have relevant parts of those NOTICE files been added to this NOTICE
file?
[ ] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..

I noticed that there are a coupld of 'THIRD-PARTY.propertis' which are left
by maven tool chain, but I believe this issue is minor and could be fixed
in the next release.

dubbo-all/src/license/THIRD-PARTY.properties
dubbo-compatible/src/license/THIRD-PARTY.properties
dubbo-config/dubbo-config-api/src/license/THIRD-PARTY.properties
dubbo-config/dubbo-config-spring/src/license/THIRD-PARTY.properties
dubbo-demo/dubbo-demo-annotation/dubbo-demo-annotation-consumer/src/license/THIRD-PARTY.properties
dubbo-demo/dubbo-demo-annotation/dubbo-demo-annotation-provider/src/license/THIRD-PARTY.properties
dubbo-demo/dubbo-demo-xml/dubbo-demo-xml-provider/src/license/THIRD-PARTY.properties
dubbo-demo/dubbo-demo-xml/dubbo-demo-xml-consumer/src/license/THIRD-PARTY.properties
dubbo-filter/dubbo-filter-validation/src/license/THIRD-PARTY.properties
dubbo-registry/dubbo-registry-eureka/src/license/THIRD-PARTY.properties
dubbo-registry/dubbo-registry-sofa/src/license/THIRD-PARTY.properties
dubbo-rpc/dubbo-rpc-http/src/license/THIRD-PARTY.properties
dubbo-rpc/dubbo-rpc-rest/src/license/THIRD-PARTY.properties
dubbo-rpc/dubbo-rpc-xml/src/license/THIRD-PARTY.properties
dubbo-rpc/dubbo-rpc-webservice/src/license/THIRD-PARTY.properties
dubbo-rpc/dubbo-rpc-thrift/src/license/THIRD-PARTY.properties

Regards,
-Ian.

On Tue, Mar 24, 2020 at 8:33 PM Liujie Qin  wrote:

> Hello Dubbo Community,
>
> This is a call for vote to release Apache Dubbo version 2.7.6.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo/2.7.6/
>
> The staging repo:
> https://repository.apache.org/content/repositories/orgapachedubbo-1094
>
> Git tag for the release:
> https://github.com/apache/dubbo/tree/dubbo-2.7.6
>
> Hash for the release tag:
> af4cff2846bdfb9f105bf32b988616a4ed40a072
>
> Release Notes:
> https://github.com/apache/dubbo/releases/tag/dubbo-2.7.6
>
> The artifacts have been signed with Key : D8FFB831, which can be found in
> the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo Team
>


Re: [VOTE] Release Apache Dubbo-Hessian-Lite 3.2.7 RC2

2020-03-27 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[x] Is there any 3rd party code contained inside the release? If so:
  [ ] Does the software have a compatible license?
  [ ] Are all software licenses mentioned in LICENSE?
  [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
  Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ] Have relevant parts of those NOTICE files been added to this NOTICE
file?
[ ] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..

Regards,
-Ian

On Fri, Mar 27, 2020 at 5:26 PM Jun Liu  wrote:

> Hello Dubbo Community,
>
> This is a call for vote to release Apache Dubbo-hessian-lite version 3.2.7
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-hessian-lite/
>
> Git tag for the release:
> https://github.com/apache/dubbo-hessian-lite/tree/v3.2.7
>
> Hash for the release tag:
> 2ac26a54f926211501686dd57b0cfc6294cf031d
>
> Release Notes:
> https://github.com/apache/dubbo-hessian-lite/releases/tag/v3.2.7
>
> The artifacts have been signed with Key: D8FFB831, which can be found in
> the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until the necessary number
> of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo Team
>


Re: [VOTE] Release Apache Dubbo-Hessian-Lite 3.2.7 RC1

2020-03-23 Thread Ian Luo
>
> Looks fine for that file. What about the other 3rd party files/files
> without headers?I think someone needs to go through the files and check
> that all files have the correct headers.


Will go through all files completely before next vote.

-Ian.

On Mon, Mar 23, 2020 at 2:39 PM Justin Mclean 
wrote:

> Hi,
>
> > Unless we know where that other file come from [1] I would still be -1.
>
> Looks fine for that file. What about the other 3rd party files/files
> without headers?I think someone needs to go through the files and check
> that all files have the correct headers.
>
> Thanks,
> Justin
>
>
>


Re: [VOTE] Release Apache Dubbo 2.7.6 RC2

2020-03-22 Thread Ian Luo
Justin,

That may be the case but why does it have that copyright line? To me that
> implies this files come from somewhere else, if that is the case we need to
> know where they come form if if they were modified by the Dubbo team.
>

Very good question, we are trying to contact the original author for the
same question.

Thanks,
-Ian.


On Sat, Mar 21, 2020 at 8:15 AM Justin Mclean 
wrote:

> Hi,
>
> > It does have the different license header than others, but I think it is
> > fine. Pls. let me know if it is a show stopper for the current release.
>
> See ASF header policy [1] ("note that there should be no copyright notice
> in the header") and policy on 3rd party files [2].
>
> > These files are originally made by Dubbo team.
>
> That may be the case but why does it have that copyright line? To me that
> implies this files come from somewhere else, if that is the case we need to
> know where they come form if if they were modified by the Dubbo team.
>
> Thanks,
> Justin
>
> 1. https://www.apache.org/legal/src-headers.html#headers
> 2. https://www.apache.org/legal/src-headers.html#3party


Re: [VOTE] Release Apache Dubbo-Hessian-Lite 3.2.7 RC1

2020-03-22 Thread Ian Luo
>
> The hessian-lite module has already exist long before Dubbo joined ASF,  I
> am not sure if the original developers who did this still active in the
> mailing list, so it’s hard to tell the whole story. But I think at least
> something is sure about why we need to maintain a separate copy:
> 1. The Caucho Hessian community[1], we’ve seen its activity in a very low
> level for a really long time. To meet requirements we do have to maintain a
> copy inside our community.
> 2. Hessian works as a serialization protocol in Dubbo and has been widely
> used by users. It’s the core part of an RPC framework, most users will stay
> on Hessian and won’t change.


Justin, I totally agree with the reasons Jun gave above. We are not the
original developers who made the decision to tailor Hessian library instead
of contribute back, but after I take a brief at the release history of
Hessian 4 [1], I guess I would make the similar decision.

If it is legally fine (I think it is perfectly allowed), I suggest we have
to live with the current situation. What we could change in the future is
we should gracefully retire hessian-lite library and encourage Dubbo users
to depend on the official Hessian 4 release.

My conclusion is, this particular issue should not block the current
release and the future potential releases.

Thanks,
-Ian.


1. https://mvnrepository.com/artifact/com.caucho/hessian


On Mon, Mar 23, 2020 at 10:25 AM Jun Liu  wrote:

> Hi
>
> > - NOTICE is missing
>
>
> From what I can see now, we need an NOTICE file, inside which we should
> mention the codes copy of of the Caucho Hessian Project. Do you think would
> that change be enough for the next round of release?
>
> > It would be good to know more the history here and why this was done,
> where there talks with the Caucho and they gave permission to do this? Or
> are some of those developers involved here?
>
> The hessian-lite module has already exist long before Dubbo joined ASF,  I
> am not sure if the original developers who did this still active in the
> mailing list, so it’s hard to tell the whole story. But I think at least
> something is sure about why we need to maintain a separate copy:
> 1. The Caucho Hessian community[1], we’ve seen its activity in a very low
> level for a really long time. To meet requirements we do have to maintain a
> copy inside our community.
> 2. Hessian works as a serialization protocol in Dubbo and has been widely
> used by users. It’s the core part of an RPC framework, most users will stay
> on Hessian and won’t change.
>
> >  are some of those developers involved here?
>
> I remember Xin Wang in our community has tried to contact the Caucho
> Hessian community for some reasons months ago. Maybe he can give more
> information on that.
>
> 1. http://hessian.caucho.com/
>
> Jun
>
> > On Mar 20, 2020, at 11:49 AM, Justin Mclean 
> wrote:
> >
> > Hi,
> >
> > -1 (binding) as the release is missing a NOTICE file and files missing
> ASF headers
> >
> > I checked:
> > - signature and hashes are fine
> > - LICENSE exists
> > - NOTICE is missing
> > - no unexpected binary files
> > - some files are ASF headers or unknown licensed 3rd party code e.g. [1]
> (I just check a couple of file not all and found this)
> > - can compile from source
> >
> > Is there any reason for the large number of files copyright "Copyright
> (c) 2001-2008 Caucho Technology, Inc”? Was s software grant looked into?
> >
> > Thanks,
> > Justin
> >
> > 1.
> dubbo-hessian-lite-3.2.7-source-release/src/test/java/com/alibaba/com/caucho/hessian/io/writereplace/Hessian2WriteReplaceTest.java
>
>


Re: [VOTE] Release Apache Dubbo-Hessian-Lite 3.2.7 RC1

2020-03-22 Thread Ian Luo
Justin,

Unless we know where that other file come from [1] I would still be -1.


For this particular file[1], it was originally authored by Song [2] and
merged by Zhu [3]. It is in fact a unit test file and I am pretty sure Sun
is the original author but apparently he and Zhu forgot to add ASF header
in it. If you are interested in the history, you could dig into this pull
request [4] and this commit [5].

I believe it should be sufficient once we follow up by adding an
appropriate ASF header for this file. What do you think, Justin?

Thanks,
-Ian.

1.
dubbo-hessian-lite-3.2.7-source-release/src/test/java/com/alibaba/com/caucho/hessian/io/writereplace/Hessian2WriteReplaceTest.java
2. https://github.com/nobodyiam
3. https://github.com/diecui1202
4. https://github.com/apache/dubbo/pull/2032
5. https://github.com/apache/dubbo-hessian-lite/commit/891c2b03


On Mon, Mar 23, 2020 at 10:50 AM Justin Mclean 
wrote:

> Hi,
>
> > From what I can see now, we need an NOTICE file, inside which we should
> mention the codes copy of of the Caucho Hessian Project.
>
> The NOTICE file doesn’t need to mention that unless headers have been
> removed from any files that come from Caucho Hessian, for  that to happen
> we would need a software grant.
>
> > Do you think would that change be enough for the next round of release?
>
> Unless we know where that other file come from [1] I would still be -1.
>
> Thanks,
> Justin
>
> 1.
> dubbo-hessian-lite-3.2.7-source-release/src/test/java/com/alibaba/com/caucho/hessian/io/writereplace/Hessian2WriteReplaceTest.java


Re: [VOTE] Release Apache dubbo-go v1.4.0 RC1

2020-03-20 Thread Ian Luo
I double checked and echo Justin's vote. In order to avoid this from
happening again, I believe we should make sure it's guarded by tooling,
like dubbo java project does [1]. I filed an issue [2] to track this.

Regards,
-Ian.


1. https://github.com/apache/dubbo/blob/master/licenseCheck.sh
2. https://github.com/apache/dubbo-go/issues/435

On Fri, Mar 20, 2020 at 11:39 AM Justin Mclean 
wrote:

> Hi,
>
> Sorry but it’s -1 binding form me as there are files missing ASF headers
> or 3rd party code of unknown licensing in the release
>
> I checked:
> - signatures and hashes are fine
> - LICENSE and NOTICE are fine
> - no unexpected bins art files
> - source files are missing ASF headers [1][2][3][4]
> - can compile from source
>
> Thanks,
> Justin
>
>
> 1. dubbo-go-v1.4.0/common/extension/auth.go
> 2. dubbo-go-v1.4.0/config/interfaces/config_reader.go
> 3. dubbo-go-v1.4.0/filter/filter_impl/active_filter_test.go
> 4. dubbo-go-v1.4.0/protocol/rpc_status_test.go
>
>
>


Re: [VOTE] Release Apache Dubbo-Hessian-Lite 3.2.7 RC1

2020-03-20 Thread Ian Luo
Justin,

hessian-lite is an tailored copy from Caucho's Hessian library. I don't
believe a software grant is necessary since it is licensed under ASF 1.1. I
believe we have the right to modify and contribute freely as long as we
mention it in the LICENSE file

For the hessian-lite submodule:
>
> The Apache Software License, Version 1.1
>
>  Copyright (c) 2001-2004 Caucho Technology, Inc.  All rights reserved.
>
>
Regards,
-Ian.


On Fri, Mar 20, 2020 at 11:49 AM Justin Mclean 
wrote:

> Hi,
>
> -1 (binding) as the release is missing a NOTICE file and files missing ASF
> headers
>
> I checked:
> - signature and hashes are fine
> - LICENSE exists
> - NOTICE is missing
> - no unexpected binary files
> - some files are ASF headers or unknown licensed 3rd party code e.g. [1]
> (I just check a couple of file not all and found this)
> - can compile from source
>
> Is there any reason for the large number of files copyright "Copyright (c)
> 2001-2008 Caucho Technology, Inc”? Was s software grant looked into?
>
> Thanks,
> Justin
>
> 1.
> dubbo-hessian-lite-3.2.7-source-release/src/test/java/com/alibaba/com/caucho/hessian/io/writereplace/Hessian2WriteReplaceTest.java


Re: [VOTE] Release Apache Dubbo 2.7.6 RC2

2020-03-20 Thread Ian Luo
Justin,

I randomly pick HttpUtils to quick check. It has the license header shown
below:

/*
 * Copyright (C) 2018 the original author or authors.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *  https://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

It does have the different license header than others, but I think it is
fine. Pls. let me know if it is a show stopper for the current release.
These files are originally made by Dubbo team. We can change the license
header to be consistent with the official one at any time.

Let me know your suggestion.

Thanks,
-Ian.


On Fri, Mar 20, 2020 at 12:04 PM Justin Mclean 
wrote:

> Hi,
>
> -1 (binding) as code has incorrect headers
>
> I checked:
> - signatures and hashes fine
> - LICENSE and NOTICE are file
> - No unexpected binary files
> - Looks like these files [1][2][3] have incorrect header or may not be ASF
> files, and may need to be mentioned in LICENSE. Where did they come from?
> - I didn’t try compiling
>
> Thanks,
> Justin
>
> 1.
> ./dubbo-common/src/main/java/org/apache/dubbo/common/utils/HttpUtils.java
> 2.
> ./dubbo-metadata/dubbo-metadata-processor/src/test/java/org/apache/dubbo/metadata/rest/User.java
> 3.
> ./dubbo-metadata/dubbo-metadata-api/src/test/java/org/apache/dubbo/metadata/rest/User.java
>
>


Re: [ANN] Welcome a new committer Zouyx

2020-03-08 Thread Ian Luo
Congratulations :)

-Ian.

On Fri, Feb 21, 2020 at 11:01 AM stocks alex  wrote:

> Hi, Community,
>
> On behalf of the Dubbo PMC, I am pleased to announce that zouyx[1] has been
> voted in as a new Dubbo committer.
>
> Please join me to say congratulations to him!
>
> Zouyx, would you please briefly introduce yourself to the community?
>
> 1. https://github.com/zouyx
>
> Yours,
> Alex.
>


Re: [VOTE] Release Apache dubbo-go-hessian2 v1.4.0 RC1

2020-03-08 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[x] Is there any 3rd party code contained inside the release? If so:
  [ ] Does the software have a compatible license?
  [ ] Are all software licenses mentioned in LICENSE?
  [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
  Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ] Have relevant parts of those NOTICE files been added to this NOTICE
file?
[ ] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..

Regards,
-Ian.

On Fri, Mar 6, 2020 at 4:04 PM 望哥  wrote:

> Hello Dubbo/Dubbogo Community,
>
>  This is a call for vote to release Apache dubbo-go-hessian2 version v1.4.0
> RC1.
>
>  The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go-hessian2/v1.4.0-rc1/
>  Git tag for the release:
> https://github.com/apache/dubbo-go-hessian2/tree/1.4
>  Hash for the release tag: 4c31e88c35afe84c0321d9f12f036e6d3c8962d0
>  Release Notes:
> https://github.com/apache/dubbo-go-hessian2/blob/1.4/CHANGE.md
>  The artifacts have been signed with Key :7DB68550D366E4C0, which can be
> found in the keys file:
>  https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
>  The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
>  Please vote accordingly:
>  [ ] +1 approve
>  [ ] +0 no opinion
>  [ ] -1 disapprove with the reason
>
>  Thanks,
>  The Apache Dubbo-go Team
>


Re: [VOTE] Release Apache Dubbo 2.7.6 RC1

2020-03-08 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release.

I noticed the file name 'apache-dubbo-2.7.6-source-release.zip.sha512'
should be 'apache-dubbo-2.7.6-zip.sha512', but I think it is fine.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[x] Is there any 3rd party code contained inside the release? If so:
  [ ] Does the software have a compatible license?
  [ ] Are all software licenses mentioned in LICENSE?
  [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
  Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ] Have relevant parts of those NOTICE files been added to this NOTICE
file?
[ ] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..

Regards,
-Ian.

On Wed, Mar 4, 2020 at 5:12 PM Liujie Qin  wrote:

> Hello Dubbo Community,
>
> This is a call for vote to release Apache Dubbo version 2.7.6.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo/2.7.6/
>
> The staging repo:
> https://repository.apache.org/content/repositories/orgapachedubbo-1069
>
> Git tag for the release:
> https://github.com/apache/dubbo/tree/dubbo-2.7.6
>
> Hash for the release tag:
> 75218a9a7abd55a4bb2be5d65a413c329712caee
>
> Release Notes:
> https://github.com/apache/dubbo/releases/tag/dubbo-2.7.6
>
> The artifacts have been signed with Key : D8FFB831, which can be found in
> the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo Team
>


Re: [VOTE] Release Apache Dubbo 2.6.8 RC3

2020-03-08 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[x] Is there any 3rd party code contained inside the release? If so:
  [ ] Does the software have a compatible license?
  [ ] Are all software licenses mentioned in LICENSE?
  [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
  Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ] Have relevant parts of those NOTICE files been added to this NOTICE
file?
[ ] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..

Regards,
-Ian.


On Mon, Mar 2, 2020 at 6:10 PM Jun Liu  wrote:

> Hello Dubbo Community,
>
> This is a call for vote to release Apache Dubbo version 2.6.8.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo/2.6.8/
>
> Git tag for the release:
> https://github.com/apache/dubbo/tree/dubbo-2.6.8
>
> Hash for the release tag:
> 5a6a069986f3627f2d50720c50024df31a3dc38a
>
> Release Notes:
> Backport some changes from 2.7 to 2.6
>
> The artifacts have been signed with Key: 28681CB1, which can be
> found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo Team
>


Re: [VOTE]: Release Apache dubbo-go v1.3.0 RC3

2020-02-28 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release.

Though I vote +1, you still own us a cancellation email to explain where
the flaw is in RC2 :)

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[x] Is there any 3rd party code contained inside the release? If so:
  [ ] Does the software have a compatible license?
  [ ] Are all software licenses mentioned in LICENSE?
  [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
  Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ] Have relevant parts of those NOTICE files been added to this NOTICE
file?
[ ] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..

Regards,
-Ian.


On Mon, Feb 24, 2020 at 9:07 PM 方银城  wrote:

> Hello Dubbo/Dubbogo Community,
>
>   This is a call for vote to release Apache dubbo-go version v1.3.0 RC3.
>
>   The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.3.0-rc3/
>
>   Git tag for the release: https://github.com/apache/dubbo-go/tree/v1.3.0
>
>   Hash for the release tag: 082cc62be11ae4ad3b04dfd0cbcca5dd2df1992d
>
>   Release Notes: https://github.com/apache/dubbo-go/blob/1.3/CHANGE.md
>
>   The artifacts have been signed with Key :F6C6A49DB4A11314, which can be
> found in the keys file: https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
>   The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
>  Please vote accordingly:
>  [ ] +1 approve
>  [ ] +0 no opinion
>  [ ] -1 disapprove with the reason
>
>  Thanks,
>  The Apache Dubbo-go Team
>


Re: [VOTE] Release Apache Dubbo 2.6.8 RC2

2020-02-28 Thread Ian Luo
-1 disapprove with the reason.

Everything looks good except for the following two minor issues:

1. Lots of .flattened-pom.xml which are unexpected.
2. In NOTICE, 2018-2020 should be used instead of 2018-2019.

Regards,
-Ian.


On Wed, Feb 26, 2020 at 10:09 PM Jun Liu  wrote:

> Hello Dubbo Community,
>
> This is a call for vote to release Apache Dubbo version 2.6.8.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo/2.6.8/ <
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo/2.6.8/>
>
> Git tag for the release:
> https://github.com/apache/dubbo/tree/dubbo-2.6.8 <
> https://github.com/apache/dubbo/tree/dubbo-2.6.8>
>
> Hash for the release tag:
> 8c2141cd1c08cc4335ee68527fb1127ed51dacd3
>
> Release Notes:
> Backport some changes from 2.7 to 2.6
>
> The artifacts have been signed with Key: 28681CB1, which can be
> found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS <
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS>
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo Team


Re: [VOTE]: Release Apache dubbo-go v1.3.0 RC3

2020-02-28 Thread Ian Luo
+1, a email to cancel RC2 is required.

-Ian.

On Fri, Feb 28, 2020 at 11:49 AM Jun Liu  wrote:

> > On Feb 22, 2020, at 5:29 PM, 方银城  wrote:
> >
> > Hello Dubbo/Dubbogo Community,
> >
> > The release dubbo-go v1.3.0 RC2 vote finished, We’ve received 3 +1
> > (binding) votes.
> >
> > +1 binding, stocks alex
> > +1 binding, Justin Mclean
> > +1 binding, Jun Liu
> >
> > The vote and result thread:
> >
> https://lists.apache.org/thread.html/r231968fc47eb0ace8696bbca0724349583f0262b857373dfe4054f36%40
> > 
> >
> >
> > The vote passed. Thanks all.
> > I will proceed with the formal release later.
>
> I think we need a mail for announce RC2 as cancelled and give the reason.
>
> Jun
>
> > On Feb 26, 2020, at 11:06 PM, 方银城  wrote:
> >
> > Because we modified something according to some suggestions of RC2
> voting.
> >
> > Jun Liu  于2020年2月26日周三 下午2:54写道:
> >
> >> Why do we need an RC3 voting, I saw v1.3.0 has been announced as passed
> >> with RC2?
> >>
> >> Jun
> >>
> >>> On Feb 24, 2020, at 9:07 PM, 方银城  wrote:
> >>>
> >>> Hello Dubbo/Dubbogo Community,
> >>>
> >>> This is a call for vote to release Apache dubbo-go version v1.3.0 RC3.
> >>>
> >>> The release candidates:
> >>> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.3.0-rc3/
> >>>
> >>> Git tag for the release:
> https://github.com/apache/dubbo-go/tree/v1.3.0
> >>>
> >>> Hash for the release tag: 082cc62be11ae4ad3b04dfd0cbcca5dd2df1992d
> >>>
> >>> Release Notes: https://github.com/apache/dubbo-go/blob/1.3/CHANGE.md
> >>>
> >>> The artifacts have been signed with Key :F6C6A49DB4A11314, which can be
> >>> found in the keys file:
> >> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> >>>
> >>> The vote will be open for at least 72 hours or until necessary number
> of
> >>> votes are reached.
> >>>
> >>> Please vote accordingly:
> >>> [ ] +1 approve
> >>> [ ] +0 no opinion
> >>> [ ] -1 disapprove with the reason
> >>>
> >>> Thanks,
> >>> The Apache Dubbo-go Team
> >>
> >>
>
>


Re: [VOTE]: Release Apache dubbo-go v1.3.0 RC1

2020-01-21 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[x] Is there any 3rd party code contained inside the release? If so:
  [ ] Does the software have a compatible license?
  [ ] Are all software licenses mentioned in LICENSE?
  [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
  Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ] Have relevant parts of those NOTICE files been added to this NOTICE
file?
[ ] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?

The year in NOTICE should be 2020.

Is the issue minor?
[v] Yes [] No [] Unsure


Could it possibly be fixed in the next release?
[v] Yes [ ] No [ ] Unsure

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..

Regards,
-Ian.

On Sat, Jan 18, 2020 at 11:52 PM 方银城  wrote:

> Hello Dubbo/Dubbogo Community,
>
>   This is a call for vote to release Apache dubbo-go version v1.3.0 RC1.
>
>   The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.3.0-rc1/
>
>   Git tag for the release: https://github.com/apache/dubbo-go/tree/1.3.0
>
>   Hash for the release tag: 1147a82c2f62d92764a98ef998ad2ad2b17928eb
>
>   Release Notes: https://github.com/apache/dubbo-go/blob/1.3/CHANGE.md
>
>   The artifacts have been signed with Key :5862908F9A627BAA, which can be
> found in the keys file: https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
>   The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
>  Please vote accordingly:
>  [ ] +1 approve
>  [ ] +0 no opinion
>  [ ] -1 disapprove with the reason
>
>  Thanks,
>  The Apache Dubbo-go Team
>


Re: [VOTE]: Release Apache dubbo-js v3.0.0-rc6

2020-01-13 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[x] Is there any 3rd party code contained inside the release? If so:
  [ ] Does the software have a compatible license?
  [ ] Are all software licenses mentioned in LICENSE?
  [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
  Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ] Have relevant parts of those NOTICE files been added to this NOTICE
file?
[ ] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?


Is the issue minor?
[ ] Yes [] No [] Unsure


Could it possibly be fixed in the next release?
[] Yes [ ] No [ ] Unsure

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..

Regards,
-Ian

On Mon, Jan 13, 2020 at 2:49 PM 胡锋  wrote:

> Hello Dubbo/Dubbojs Community,
>
> This is a call for vote to release Apache dubbo-js version v3.0.0-rc6.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-js/3.0.0-rc6/
>
> Git tag for the release:
> https://github.com/apache/dubbo-js/blob/v3.0.0/CHANGE.md
>
> Hash for the release tag:
> a614527f2b7a00e4f0231d221a67574274d88cf2
>
> The artifacts have been signed with Key :35F44C444B811C10, which can be
> found in the keys file:
>
>  https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
>  The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
>
>  Please vote accordingly:
>
>  [ ] +1 approve
>
>  [ ] +0 no opinion
>
>  [ ] -1 disapprove with the reason
>
>
>  Thanks,
>
>  The Apache Dubbo-js Team
>


Re: [VOTE]: Release Apache dubbo-js v3.0.0-rc5

2020-01-10 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[x] Is there any 3rd party code contained inside the release? If so:
  [ ] Does the software have a compatible license?
  [ ] Are all software licenses mentioned in LICENSE?
  [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
  Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ] Have relevant parts of those NOTICE files been added to this NOTICE
file?
[ ] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?


Is the issue minor?
[ ] Yes [] No [] Unsure


Could it possibly be fixed in the next release?
[] Yes [ ] No [ ] Unsure

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..

Regards,
-Ian.

On Fri, Jan 10, 2020 at 2:05 PM 胡锋  wrote:

> Hello Dubbo/Dubbojs Community,
>
> This is a call for vote to release Apache dubbo-js version v3.0.0-rc5.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-js/3.0.0-rc5/
>
> Git tag for the release:
> https://github.com/apache/dubbo-js/blob/v3.0.0/CHANGE.md
>
> Hash for the release tag:
> 14811493f68126b438c9a776e0ccb95b95cfab3f
>
> The artifacts have been signed with Key :35F44C444B811C10, which can be
> found in the keys file:
>
>  https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
>  The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
>
>  Please vote accordingly:
>
>  [ ] +1 approve
>
>  [ ] +0 no opinion
>
>  [ ] -1 disapprove with the reason
>
>
>  Thanks,
>
>  The Apache Dubbo-js Team
>


Re: [VOTE]: Release Apache dubbo-js v3.0.0-rc4

2020-01-07 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[x] Is there any 3rd party code contained inside the release? If so:
  [ ] Does the software have a compatible license?
  [ ] Are all software licenses mentioned in LICENSE?
  [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
  Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ] Have relevant parts of those NOTICE files been added to this NOTICE
file?
[ ] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?


Is the issue minor?
[ ] Yes [] No [] Unsure


Could it possibly be fixed in the next release?
[] Yes [ ] No [ ] Unsure

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..

Regards,
-Ian.


On Mon, Jan 6, 2020 at 2:14 PM 胡锋  wrote:

> Hello Dubbo/Dubbojs Community,
>
> This is a call for vote to release Apache dubbo-js version v3.0.0-rc4.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-js/3.0.0-rc4/
>
> Git tag for the release:
> https://github.com/apache/dubbo-js/blob/v3.0.0/CHANGE.md
>
> Hash for the release tag:
> 14811493f68126b438c9a776e0ccb95b95cfab3f
>
> The artifacts have been signed with Key :35F44C444B811C10, which can be
> found in the keys file:
>
>  https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
>  The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
>
>  Please vote accordingly:
>
>  [ ] +1 approve
>
>  [ ] +0 no opinion
>
>  [ ] -1 disapprove with the reason
>
>
>  Thanks,
>
>  The Apache Dubbo-js Team
>


Re: [VOTE] Release Apache Dubbo 2.7.5 RC3

2019-12-25 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[x] Is there any 3rd party code contained inside the release? If so:
  [ ] Does the software have a compatible license?
  [ ] Are all software licenses mentioned in LICENSE?
  [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
  Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ] Have relevant parts of those NOTICE files been added to this NOTICE
file?
[ ] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?


Is the issue minor?
[ ] Yes [] No [] Unsure


Could it possibly be fixed in the next release?
[] Yes [ ] No [ ] Unsure

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..

Regards,
-Ian.

On Tue, Dec 24, 2019 at 11:06 AM Jun Liu  wrote:

> Hello Dubbo Community,
>
> This is a call for vote to release Apache Dubbo version 2.7.5.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo/2.7.5/RC3
>
> The staging repo:
> https://repository.apache.org/content/repositories/orgapachedubbo-1053
> https://repository.apache.org/content/repositories/orgapachedubbo-1054
>
> Git tag for the release:
> https://github.com/apache/dubbo/tree/dubbo-2.7.5
>
> Hash for the release tag:
> 5ae160ad7b6b1ec67dad14bce819e5d27353cf21
>
> Release Notes:
> https://github.com/apache/dubbo/blob/2.7.5-release/CHANGES.md#275
>
> The artifacts have been signed with Key: 28681CB1, which can be
> found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo Team
>
>


Re: [VOTE]: Release Apache dubbo-js v3.0.0-rc3

2019-12-25 Thread Ian Luo
I checked the following items. I vote -1 (binding) to this release since I
found a couple of binaries and eclipse files from the source zip file.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[x] Is there any 3rd party code contained inside the release? If so:
  [ ] Does the software have a compatible license?
  [ ] Are all software licenses mentioned in LICENSE?
  [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
  Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ] Have relevant parts of those NOTICE files been added to this NOTICE
file?
[ ] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?

a couple of binaries (.class files) are found in this distribution. I also
found a couple of eclipse files (.project and .settings)


Is the issue minor?
[ ] Yes [x] No [] Unsure


Could it possibly be fixed in the next release?
[x] Yes [ ] No [ ] Unsure

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..

Regards,
-Ian.

On Wed, Dec 25, 2019 at 11:34 PM 胡锋  wrote:

> Hello Dubbo/Dubbojs Community,
>
> This is a call for vote to release Apache dubbo-js version v3.0.0-rc3.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-js/3.0.0-rc3/
>
> Git tag for the release:
> https://github.com/apache/dubbo-js/blob/v3.0.0/CHANGE.md
>
> Hash for the release tag:
> 91d365bf42891fc3f9bcad27be04ef57386684e8
>
> The artifacts have been signed with Key :35F44C444B811C10, which can be
> found in the keys file:
>
>  https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
>  The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
>
>  Please vote accordingly:
>
>  [ ] +1 approve
>
>  [ ] +0 no opinion
>
>  [ ] -1 disapprove with the reason
>
>
>  Thanks,
>
>  The Apache Dubbo-js Team
>


Re: [VOTE]: Release Apache dubbo-js v3.0.0-rc2

2019-12-19 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[x] Is there any 3rd party code contained inside the release? If so:
  [ ] Does the software have a compatible license?
  [ ] Are all software licenses mentioned in LICENSE?
  [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
  Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ] Have relevant parts of those NOTICE files been added to this NOTICE
file?
[ ] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?

1.
java/dubbo-demo/dubbo-demo-api/src/main/java/org/apache/dubbo/demo/DemoProvider.java
doesn't have ASF license

2. a couple of .DS_Store files are found which should not be packaged.


Is the issue minor?
[ ] Yes [ ] No [x] Unsure


Could it possibly be fixed in the next release?
[x] Yes [ ] No [ ] Unsure

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..

I found two minor issues which I believe they are not show-stopper and can
be fixed in the next release.

Regards,
-Ian.


On Thu, Dec 19, 2019 at 1:15 PM 胡锋  wrote:

> Hello Dubbo/Dubbojs Community,
>
> This is a call for vote to release Apache dubbo-js version v3.0.0-rc2.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-js/3.0.0-rc2/
>
> Git tag for the release:
> https://github.com/apache/dubbo-js/blob/v3.0.0/CHANGE.md
>
> Hash for the release tag:
> 1f8b7f0ef660186fe6ce452c57e8b1960801f005
>
> The artifacts have been signed with Key :35F44C444B811C10, which can be
> found in the keys file:
>
>  https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
>  The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
>
>  Please vote accordingly:
>
>  [ ] +1 approve
>
>  [ ] +0 no opinion
>
>  [ ] -1 disapprove with the reason
>
>
>  Thanks,
>
>  The Apache Dubbo-js Team
>


Re: 麻烦review这个pr

2019-12-10 Thread Ian Luo
Didn't realize this pull request has not been handled yet. I will find time
to look into it in this week. Sorry about that.

-Ian.

On Tue, Oct 29, 2019 at 11:33 PM 老胡 <2372554...@qq.com> wrote:

> 各位大神好!
> 写了一个字节码的代理实现,目的是为了提高性能. pr地址是:
> https://github.com/apache/dubbo/pull/5146 . 麻烦大神们review. 这个pr十分重要哈. 精力有限
> 只能一个pr一个pr来哈.


Re: [VOTE]: Release Apache dubbo-js v3.0.0

2019-12-02 Thread Ian Luo
Hu,

Would you mind to start a new thread for the release vote once the new
release candidate is ready?

Thanks,
-Ian.

On Mon, Dec 2, 2019 at 7:44 PM 胡锋  wrote:

> let me fixed it.
>
> Ian Luo  于2019年12月2日周一 下午7:26写道:
>
> > -1
> >
> > I didn't thoroughly check, but it looks like the filename is a
> showstopper.
> > I think the filename should be apache-dubbo-js-3.0.0 instead of
> > dubbo-js-3.0.0.
> >
> > Regards,
> > -Ian.
> >
> >
> >
> > On Sun, Nov 17, 2019 at 1:28 AM hufeng@apache  wrote:
> >
> > > Hello Dubbo/Dubbojs Community,
> > >
> > >  This is a call for vote to release Apache dubbo-js version v3.0.0.
> > >
> > > The release candidates:
> > > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-js/3.0.0/
> > >
> > > Git tag for the release:
> > > https://github.com/apache/dubbo-js/blob/v3.0.0/CHANGE.md
> > >
> > > Hash for the release tag:
> > > 2ac8091de299abbeaf133152eefd89eed873b551
> > >
> > > The artifacts have been signed with Key :35F44C444B811C10, which can be
> > > found in the keys file:
> > >
> > >  https://dist.apache.org/repos/dist/dev/dubbo/KEYS
> > >
> > >
> > >  The vote will be open for at least 72 hours or until necessary number
> of
> > > votes are reached.
> > >
> > >
> > >  Please vote accordingly:
> > >
> > >  [ ] +1 approve
> > >
> > >  [ ] +0 no opinion
> > >
> > >  [ ] -1 disapprove with the reason
> > >
> > >
> > >
> > >  Thanks,
> > >
> > >  The Apache Dubbo-js Team
> > >
> >
>


Re: [VOTE]: Release Apache dubbo-js v3.0.0

2019-12-02 Thread Ian Luo
-1

I didn't thoroughly check, but it looks like the filename is a showstopper.
I think the filename should be apache-dubbo-js-3.0.0 instead of
dubbo-js-3.0.0.

Regards,
-Ian.



On Sun, Nov 17, 2019 at 1:28 AM hufeng@apache  wrote:

> Hello Dubbo/Dubbojs Community,
>
>  This is a call for vote to release Apache dubbo-js version v3.0.0.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-js/3.0.0/
>
> Git tag for the release:
> https://github.com/apache/dubbo-js/blob/v3.0.0/CHANGE.md
>
> Hash for the release tag:
> 2ac8091de299abbeaf133152eefd89eed873b551
>
> The artifacts have been signed with Key :35F44C444B811C10, which can be
> found in the keys file:
>
>  https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
>
>  The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
>
>  Please vote accordingly:
>
>  [ ] +1 approve
>
>  [ ] +0 no opinion
>
>  [ ] -1 disapprove with the reason
>
>
>
>  Thanks,
>
>  The Apache Dubbo-js Team
>


Re: "dubbo-php-framework" rewrite notification

2019-12-02 Thread Ian Luo
Great job, would you mind to send pull request so that other folks
familiar with PHP can start code review?

Thanks,
-Ian.

On Mon, Dec 2, 2019 at 11:34 AM Jinxi Wang  wrote:

> Administrators:
> According to the experience of a period of time, and feedback from "github
> Issues" and the original author's suggestions, I rewritten
> "dubbo-php-framework". Now this framework lacks a dedicated maintainer to
> ensure vitality if it can I hope to be this maintainer. Rewritten code:
> https://github.com/crazyxman/dubbo-php-framework. Both the change log and
> the wiki are complete in the README.
>
>
> Thank you for your reply
>
>


Re: [VOTE]: Release Apache dubbo-go v1.2.0 RC1

2019-11-14 Thread Ian Luo
I checked the following items. I vote +1 (binding) to this release.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[x] Is there any 3rd party code contained inside the release? If so:
  [ ] Does the software have a compatible license?
  [ ] Are all software licenses mentioned in LICENSE?
  [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
  Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ] Have relevant parts of those NOTICE files been added to this NOTICE
file?
[ ] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?

Is the issue minor?
[ ] Yes [ ] No [ ] Unsure

Could it possibly be fixed in the next release?
[ ] Yes [ ] No [ ] Unsure

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because..

-Ian.


On Fri, Nov 1, 2019 at 7:39 PM xinming he  wrote:

> Hello Dubbo/Dubbogo Community,
>
>
>  This is a call for vote to release Apache dubbo-go version v1.2.0 RC1.
>
>
>  The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/v1.2.0-rc1/
>
>
>  Git tag for the release:
> https://github.com/apache/dubbo-go/tree/v1.2.0-rc01
>
>
>  Hash for the release tag: 11878c4d265a08013da96c5eb93aa60cdc29b0d1
>
>
>  Release Notes: https://github.com/apache/dubbo-go/blob/1.2/CHANGE.md
>
>
>  The artifacts have been signed with Key :E070AA783CB866D7, which can be
> found in the keys file:
>
>  https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
>
>  The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
>
>  Please vote accordingly:
>
>  [ ] +1 approve
>
>  [ ] +0 no opinion
>
>  [ ] -1 disapprove with the reason
>
>
>
>  Thanks,
>
>  The Apache Dubbo-go Team
>


Re: [VOTE] Accept RitterHou/python-dubbo donation

2019-11-08 Thread Ian Luo
Hi folks,

I am glad to inform you that this project has been transferred successfully
into apache group. You can access it via
https://github.com/apache/dubbo-python2.

Cheers,
-Ian.


On Fri, Oct 25, 2019 at 10:58 AM Ian Luo  wrote:

> Hi folks,
>
> I filed INFRA-19338 ticket [1] to track this task.
>
> Regards,
> -Ian.
>
> 1. https://issues.apache.org/jira/browse/INFRA-19338
>
> On Fri, Oct 25, 2019 at 10:50 AM Ian Luo  wrote:
>
>> Sure. Then I will file a infra ticket to ask move in this project as
>> 'dubbo-python2'
>>
>> -Ian.
>>
>> On Wed, Oct 23, 2019 at 4:21 PM Derobukal  wrote:
>>
>>> HI, lan
>>>
>>> I am agreeing with Jason, a new name is a good idea, like `dubbo-py` or
>>> `dubbo-python2` or something else.
>>>
>>>
>>> regards,
>>>
>>> Derobukal
>>>
>>


Re: [VOTE]: Release Apache Dubbo Spring Boot 2.7.4.1 [RC1]

2019-11-01 Thread Ian Luo
Mercy,

I don't believe this will block the release, but as Justin points it out,
it does remind me we should host these articles to dubbo's website. What do
you think?

Thanks,
-Ian.

On Wed, Oct 30, 2019 at 5:26 PM Mercy Ma  wrote:

> These links come from my Github blog, it's appeared a long time. Could they
> leave there?
>
> Kind regards,
> Mercy
>
> On Wed, Oct 30, 2019 at 4:58 PM Justin Mclean 
> wrote:
>
> > Hi,
> >
> > I notice the documentation refers to external non-Apache websites is
> there
> > a reason for this?
> >
> > 5. [Dubbo Annotation-Driven (Chinese)](
> >
> https://github.com/mercyblitz/blogs/blob/master/java/dubbo/Dubbo-Annotation-Driven.md
> > )
> > 6. [Dubbo Externalized Configuration (Chinese)](
> >
> https://github.com/mercyblitz/blogs/blob/master/java/dubbo/Dubbo-Externalized-Configuration.md
> > )
> >
> > Thanks,
> > Justin
>
>
>
> --
>
> *Mercy Ma*
> GMail:mercybl...@gmail.com
> Yahoo: mercy.bl...@yahoo.com
> Wetchat: mercyblitz-1985
> Twitter : @mercyblitz 
> Blog: https://mercyblitz.github.io/
>


Re: Hi Dubbo folks, I want to help!!

2019-10-29 Thread Ian Luo
James, glad to know :) You may start from 'New Contributor Guide' [1].

Regards,
-Ian.

http://dubbo.apache.org/zh-cn/docs/developers/contributor-guide/new-contributor-guide_dev.html

On Tue, Oct 29, 2019 at 2:54 PM 徐浩喆  wrote:

> Hi Dubbo devs, I would love to help with the project!
>
>
> Thanks
> James


Re: [VOTE]: Release Apache Dubbo 2.7.4.1 [RC1]

2019-10-24 Thread Ian Luo
I checked the following items. I vote +1 to this release.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[v] Is there any 3rd party code contained inside the release? If so:
  [v] Does the software have a compatible license?
  [v] Are all software licenses mentioned in LICENSE?
  [v] Is the full text of the licenses (or pointers to it) in LICENSE?
  Is any of this code Apache licensed? Do they have NOTICE files? If so:
[v] Have relevant parts of those NOTICE files been added to this NOTICE
file?
[v] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?

Is the issue minor?
[ ] Yes [ ] No [ ] Unsure

Could it possibly be fixed in the next release?
[ ] Yes [ ] No [ ] Unsure

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because...

Thanks,
-Ian.

On Tue, Oct 22, 2019 at 8:54 PM Jun Liu  wrote:

> Hello Dubbo Community,
>
> This is a call for vote to release Apache Dubbo version 2.7.4.1.
>
> The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/2.7.4.1/
>
> The staging repo:
> https://repository.apache.org/content/repositories/orgapachedubbo-1046
>
> Git tag for the release:
> https://github.com/apache/dubbo/tree/dubbo-2.7.4.1
>
> Hash for the release tag:
> 7957e268fbdf8cb214c8205f57f778e388366f48
>
> Release Notes:
> https://github.com/apache/dubbo/blob/dubbo-2.7.4.1/CHANGES.md#2741
>
> The artifacts have been signed with Key: 28681CB1, which can be
> found in the keys file:
> https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
> The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Dubbo Team
>


Re: [VOTE] Accept RitterHou/python-dubbo donation

2019-10-24 Thread Ian Luo
Sure. Then I will file a infra ticket to ask move in this project as
'dubbo-python2'

-Ian.

On Wed, Oct 23, 2019 at 4:21 PM Derobukal  wrote:

> HI, lan
>
> I am agreeing with Jason, a new name is a good idea, like `dubbo-py` or
> `dubbo-python2` or something else.
>
>
> regards,
>
> Derobukal
>


Re: [VOTE]: Release Apache dubbo-go-hessian2 v1.3.0 RC1

2019-10-24 Thread Ian Luo
I checked the following items. I vote +1 to this release.

[v]  Are release files in correct location?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[x] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[x] License information is not mentioned in NOTICE?
[x] Is there any 3rd party code contained inside the release? If so:
  [ ] Does the software have a compatible license?
  [ ] Are all software licenses mentioned in LICENSE?
  [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
  Is any of this code Apache licensed? Do they have NOTICE files? If so:
[ ] Have relevant parts of those NOTICE files been added to this NOTICE
file?
[ ] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?

Is the issue minor?
[ ] Yes [ ] No [ ] Unsure

Could it possibly be fixed in the next release?
[ ] Yes [ ] No [ ] Unsure

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because...

Thanks,
-Ian.


On Tue, Oct 22, 2019 at 10:40 AM 望哥  wrote:

> Hello Dubbo/Dubbogo Community,
>
>  This is a call for vote to release Apache dubbo-go-hessian2 version v1.3.0
> RC1.
>
>  The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go-hessian2/v1.3.0-rc1/
>  Git tag for the release:
> https://github.com/apache/dubbo-go-hessian2/tree/v1.3.0
>  Hash for the release tag: 0ef010e9ccf4fea50b122e43ba2c0ba62a260fcb
>  Release Notes:
> https://github.com/apache/dubbo-go-hessian2/blob/v1.3.0/CHANGE.md
>  The artifacts have been signed with Key :7DB68550D366E4C0, which can be
> found in the keys file:
>  https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>
>  The vote will be open for at least 72 hours or until necessary number of
> votes are reached.
>
>  Please vote accordingly:
>  [ ] +1 approve
>  [ ] +0 no opinion
>  [ ] -1 disapprove with the reason
>
>  Thanks,
>  The Apache Dubbo-go Team
>


Re: [VOTE] Accept RitterHou/python-dubbo donation

2019-10-23 Thread Ian Luo
Hi Folks,

I think I have finished all steps to move this project into apache group
except for the last one step. Before I begins, I'd like to discuss with you
that if it is appropriate to replace the existing dubbo-python [1] entirely
with this new implementation, which is much better, from my own opinion.
BTW, in case of you have not realized, the existing dubbo-python [1] is
also donated from Qianmi too.

Regards,
-Ian.


1. https://github.com/apache/dubbo-python

On Thu, Oct 17, 2019 at 5:17 PM Ian Luo  wrote:

> Hi,
>
> After waiting more than 72 hours, the vote has passed with: 5 +2
> binding vote and no -1 binding vote.
>
> +1 binding: Yuhang Xiu, Minxuan Zhuang, Xin Wang, Mercy Ma, Ian Luo
> +1 non-binding: Yuhao Bi, Zhechao Zheng
>
>
> Regards,
> -Ian.
>
> On Tue, Sep 24, 2019 at 2:34 PM 郑泽超  wrote:
>
>> +1 accept.
>> It is a good news for pythoner~
>>
>


Re: [VOTE] Accept RitterHou/python-dubbo donation

2019-10-23 Thread Ian Luo
Justin,

SGA has already submitted.

-Ian.

On Thu, Oct 17, 2019 at 7:17 PM Justin Mclean 
wrote:

> Hi,
>
> Who owns the copyright on this code? I assume it is Qianmi? If so we would
> need a SGA from them.
>
> Thanks,
> Justin
>
>
>


Re: [VOTE] Accept RitterHou/python-dubbo donation

2019-10-17 Thread Ian Luo
Hi,

After waiting more than 72 hours, the vote has passed with: 5 +2
binding vote and no -1 binding vote.

+1 binding: Yuhang Xiu, Minxuan Zhuang, Xin Wang, Mercy Ma, Ian Luo
+1 non-binding: Yuhao Bi, Zhechao Zheng


Regards,
-Ian.

On Tue, Sep 24, 2019 at 2:34 PM 郑泽超  wrote:

> +1 accept.
> It is a good news for pythoner~
>


Re: Document versioning

2019-10-10 Thread Ian Luo
Yunkun, if different directories do not do the trick, you may need to
consider to file an issue at docsite's project [1] to discuss.

Regards,
-Ian.

1. https://github.com/txd-team/docsite

On Thu, Oct 10, 2019 at 9:29 PM YunKun Huang  wrote:

> hey all,
>
> Dubbo website provides document for dubbo project. It using docsite[1] to
> generate html pages. It using markdown format.
>
> There is one issue for this way is document always the latest version,
> ideally document should provide to user with version. for example [2][3]
>
> Not sure if docsite support this feature? there are also some other choice
> like asciidoctor[4], but I'm sure how much effect it requires to do
> migration work.
>
> Any thoughts?
>
>
> [1]:https://github.com/txd-team/docsite/issues
> [2]:https://docs.spring.io/spring-boot/docs/
> [3]:https://hibernate.org/orm/documentation/5.4/
> [4]:https://asciidoctor.org
>


Re: Github action for dubbo-website deployment

2019-09-27 Thread Ian Luo
Yunkun,

I've merged your PR. Let me know whether you know how to disable Jenkins
job on apache side.

Thanks,
-Ian.


On Fri, Sep 27, 2019 at 5:47 PM Yunkun Huang  wrote:

> hey all,
>
> Currently dubbo-website is using apache jenkins to do website deployment.
> because the resource limitation, sometime apache jenkins is not very stable
> and we need wait available executor to do deployment. Also for apache
> jenkins, only people have access can view configuration.
>
> Github action is Github built-in CI service and it has built-in write
> access for repo. and configuration file is in .github/workflow folder.
>
> I try to use github action to do dubbo-website deployment work. refer to
> PR: https://github.com/apache/dubbo-website/pull/480. it can meet our
> requirement. (auto build and deploy to asf-site branch)
>
> There is how deployment logs look like:
> https://github.com/htynkn/dubbo-website/runs/238553250
>
> I suggest we disable apache jenkins deployment job and switch to github
> action to do website deployment.
>
>
>


Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC1]

2019-09-27 Thread Ian Luo
Victory, as the release manager for this release, would you mind to cover
all questions Justin raised in this thread?

Thanks,
-Ian.

On Fri, Sep 27, 2019 at 5:33 PM Justin Mclean 
wrote:

> HI,
>
> > I believe there's no show stopper. Let's continue to vote the release.
>
> They are not but I’m still waiting an answer to my other questions, which
> may be? Anyone?
>
> Thanks,
> Justin
>
>


Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC1]

2019-09-27 Thread Ian Luo
Are you particularly referring to
https://github.com/alibaba/spring-context-support? Then I'd like to leave
this to Mercy Ma.

-Ian.

On Fri, Sep 27, 2019 at 5:36 PM Justin Mclean 
wrote:

> HI,
>
> To repeat my questions:
>
> It’s strange these files have an ASF header when they are in a non ASF
> repo which is licensed under a non ASF license. What the story behind these
> files?
>
> PR#3 says "Add some code from other places”, what other places did this
> code come from? If this is the case, where other people involved in writing
> that code? What license was it under?
>
> Thanks,
> Justin


Re: Question about "mata-data-report"

2019-09-27 Thread Ian Luo
Dear Yufei,

Thanks for subscribing @dev first, and welcome :)

>
> One thing worth noted is that the official website’s documentation doesn’t
> include the English version user guide for meta-data-report column, but the
> Chinese version include it.However, the Chinese version doesn’t update the
> Redis and zookeeper configuration tutorial information in this
> meta-data-report column


Would you mind to file an issue on https://github.com/apache/dubbo-website?
Thank you very much for pointing this out.

In fact, the provider(Assumed it is the property of one provider A), the
> interesting thing is that  no matter what I did to the Redis, for example,
> change the   value which is what  the provider A’key corresponds to, or
> delete the value of the provider A .It didn’t change as time goes by.
> Theoretically, it should be updated or restored due to the mechanism of the
> “cycle-report” and “retry-period”. But the meta-data do imported to Redis
> when the provider was started.


It looks like a bug, would you mind to file an issue on GitHub? We can
follow up to investigate.

>
> The next question is about the significance of the properties concerning
> with the “metadata-report”. As we all know, the meta-data contains some
> “useless” data” which have no influence on the operation of dubbo. So why
> do we still store them in  the meta-data registry? I want to know the
> consequence if we just totally ignore these meta-data.Can dubbo still run
> smoothly?  What defect will be triggered?


With regarding to 'useless data', would you mind to clarify the concreate
property? It is pretty safe to ignore the whole meta-data if you don't use
'service test' on Dubbo Admin.

 Cheers,
-Ian.



On Tue, Sep 24, 2019 at 7:10 PM 郑宇飞 
wrote:

> Dear Mr or Mrs:
> First of all, it's a great honor to subscribe to dubbo, and I'm
> sorry to disturb you at such a time.Sorry for my awkward English. Here are
> some questions I would like to ask:
> Let me first describe the scenario: dubbo 2.7.3
> auto-configuration(version 2.7.3 has already included Dubbo-all
> dependency),registry: zookeeper(curator) , meta-data-registry - Redis (One
> thing worth noted is that the official website’s documentation doesn’t
> include the English version user guide for meta-data-report column, but the
> Chinese version include it.However, the Chinese version doesn’t update the
> Redis and zookeeper configuration tutorial information in this
> meta-data-report column) run on Spring-boot 2.x
> The first question is about the Redis meta-data-report: No matter
> how I change the properties concerning with the meta-data-report, the Redis
> doesn’t update the new info.For example, we use the default configuration
> value, that is
> “dubbo.metadata-report.address=redis://127.0.0.1:
> dubbo.metadata-report.retry-times=100   ##default值100
> dubbo.metadata-report.retry-period=3000##default值3000
> dubbo.metadata-report.cycle-report=true   ##default值true”
> In fact, the provider(Assumed it is the property of one provider A), the
> interesting thing is that  no matter what I did to the Redis, for example,
> change the   value which is what  the provider A’key corresponds to, or
> delete the value of the provider A .It didn’t change as time goes by.
> Theoretically, it should be updated or restored due to the mechanism of the
> “cycle-report” and “retry-period”. But the meta-data do imported to Redis
> when the provider was started.
>
>
>
> The next question is about the significance of the properties concerning
> with the “metadata-report”. As we all know, the meta-data contains some
> “useless” data” which have no influence on the operation of dubbo. So why
> do we still store them in  the meta-data registry? I want to know the
> consequence if we just totally ignore these meta-data.Can dubbo still run
> smoothly?  What defect will be triggered?
>
>
>
>
>
>   Developer: YufeiZheng,China
>
>
>


Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC1]

2019-09-27 Thread Ian Luo
I believe there's no show stopper. Let's continue to vote the release.

-Ian.

On Fri, Sep 27, 2019 at 5:16 PM victory  wrote:

> Looking through the code I found a few other minor things that may need to
> be updated:
> - References to internal JIRA
> http://code.alibabatech.com/jira/browse/DUBBO-XXX that I cannot access.
> - Reference to this URL [2]
> - Reference to this URL [3] in tests. This gives a 404 so I’m not sure if
> those test pass. there are also there reference to http://dubbo.io.
>
> All of above problem exist for a long time and it is used for testcase.  So
> I think the problem can be optimized in next release.
> I have posted two new issues for new release :
> https://github.com/apache/dubbo/issues/5118
> https://github.com/apache/dubbo/issues/511
> 9
>
>
>
>
> Mercy  于2019年9月26日周四 下午3:37写道:
>
> >
> > > If you are the only contributor (which seems to be the case) that would
> > be one way of dealing with it. The Dubbo LICENSE file would need to
> change
> > if that was done.
> >
> > Yes, I'm the only one contriubtor of this project and its LICENSE file
> > has been changed to be "Apache License 2.0" :
> >
> > https://github.com/alibaba/spring-context-support/blob/master/LICENSE
> >
> >
> > Is it fine?
> >
> >
> > Kind regards,
> >
> > Mercy
> >
> >
>
> --
>
> Best Regard!
> cvitory
>


Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC1]

2019-09-25 Thread Ian Luo
@Mercy,

Is it possible to reimplement
https://github.com/alibaba/spring-context-support/blob/1.0.2/src/main/java/com/alibaba/spring/util/AnnotationUtils.java
so
that alibaba/spirng-context-support will not bother us any longer?

Thanks,
-Ian.


On Thu, Sep 26, 2019 at 11:40 AM Mercy Ma  wrote:

> Hi Justin Mclean,
>
> I'm the author of https://github.com/alibaba/spring-context-support, could
> I change the LICENSE of this project to be "Apache License 2.0" to resolve
> this issue?
>
> Kind regards,
> Mercy Ma
>
> On Thu, Sep 26, 2019 at 11:16 AM Justin Mclean 
> wrote:
>
> > Hi,
> >
> > -1 binding (due to Category X software being included).
> >
> > I checked:
> > - signatures and hashes fine
> > - LICENSE is OK (see below)
> > - NOTICE is fine
> > - There are a couple of files that are missing ASF headers e.g. [1]
> > - There are no unexpected binary files
> > - can compile from source
> >
> > This file [4] includes code cloned from here [5] which is under a GPL
> > license. [6] This license is not compatible with the ALv2 and is Category
> > X. [7] The same issue exists with this file [8]. It looks like other
> files
> > in that util directory have also been copied from [9]. it’s strange these
> > files have an ASF header when they are in a non ASF repo which is
> licensed
> > under a non ASF license. Given a good explanation for this and those file
> > are correctly licensed I’ll change my vote. What the story behind these
> > files?
> >
> > It would be better if the MIT license text was included in the LICENSE or
> > it included a local pointer to the text. Information at a URL can change
> > over time.
> >
> > Looking through the code I found a few other minor things that may need
> to
> > be updated:
> > - References to internal JIRA
> > http://code.alibabatech.com/jira/browse/DUBBO-XXX that I cannot access.
> > - Reference to this URL [2]
> > - Reference to this URL [3] in tests. This gives a 404 so I’m not sure if
> > those test pass. there are also there reference to http://dubbo.io.
> >
> > Thanks,
> > Justin
> >
> > 1. ./apache-dubbo-2.7.4-src/licenseCheck.sh
> > 2. http://b2b-doc.alibaba-inc.com/display/RC/dubbo_devguide.htm
> > 3. http://dubbo.io/logo.png
> > 4.
> >
> ./apache-dubbo-2.7.4-src/dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/util/AnnotationUtils.java
> > 5.
> >
> https://github.com/alibaba/spring-context-support/blob/1.0.2/src/main/java/com/alibaba/spring/util/AnnotationUtils.java
> > 6. https://github.com/alibaba/spring-context-support/blob/1.0.2/LICENSE
> > 7. https://apache.org/legal/resolved.html#category-x
> > 8.
> >
> ./apache-dubbo-2.7.4-src/dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/util/ClassUtils.java
> > 9.
> >
> https://github.com/alibaba/spring-context-support/tree/1.0.2/src/main/java/com/alibaba/spring/util
>
>
>
> --
>
> *Mercy Ma*
> GMail:mercybl...@gmail.com
> Yahoo: mercy.bl...@yahoo.com
> Wetchat: mercyblitz-1985
> Twitter : @mercyblitz 
> Blog: https://mercyblitz.github.io/
>


Re: Customize the target content to be hashed with Consistent hash load balance

2019-09-25 Thread Ian Luo
Dear Tphan,

Would you mind to subscribe this mailing list, otherwise the mailing list
administrator will approve every email you send to this address, which you
may not realize.

If you don't know how to do it, pls. follow here. [1]

Ian.

1.
http://dubbo.apache.org/en-us/docs/developers/contributor-guide/mailing-list-subscription-guide_dev.html



On Wed, Sep 25, 2019 at 7:50 AM Tien Dat PHAN  wrote:

> Hi Jason,
>
> I just had some time looking back at this thread.
> I just realized that it may be useful if we apply the consistent hash
> algorithm on simply the hashCode() of the first parameters. I think it
> would be better compare to use the toString() method.
>
> With that, users can override the hashCode() method of their own objects.
>
> What do you think?
>
> Best regards
> Tien Dat PHAN
>
> On 2019/06/12 11:56:25, Jason Joo  wrote:
> > Hi, Dat
> >
> > Stand at the point of DUBBO maybe it is too complex to support a grammar
> as EL expressions like 'param[0].url' due to invokers are so dynamic in
> same invocation group.
> >
> > So I think taking an obvious and special partition/hashing parameter is
> acceptable for me instead of taking it as a kind of duplicated information.
> >
> > Again if you have better ideas it could be welcome in community.
> >
> >
> > best regards,
> >
> > Jason
> >
> > > On Jun 12, 2019, at 19:34, tphan@gmail.com wrote:
> > >
> > > Hi Jason,
> > >
> > > Thanks for sharing your opinion :)
> > > This is actually what we are currently doing, for now, as we do not
> find a better solution for this yet.
> > >
> > > Best
> > > Dat
> > >
> > > On 2019/06/12 08:28:32, Jason Joo  wrote:
> > >> Hi, Tien
> > >>
> > >> Agree to you that it will break the principle of design if overriding
> toString().
> > >> Currently consist hash of load balance only support specifying which
> argument(s) can take charge in it but not support specify certain property
> of a parameter to do so.
> > >>
> > >> For better understanding maybe add a parameter like
> > >>
> > >>> MyResponse getResponse(String partitionKey, MyRequestParams params);
> > >>
> > >>
> > >> may be more easy.
> > >>
> > >> It's only my opinion.
> > >>
> > >>
> > >> best regards,
> > >>
> > >> Jason
> > >>
> > >>> On Jun 12, 2019, at 15:31, tphan@gmail.com wrote:
> > >>>
> > >>> Dear Jason,
> > >>>
> > >>> I am aware of that.
> > >>> However, as the MyRequestParams has multiple fields, we would like
> to avoid implementing the toString method that return a string containing
> only the URI field.
> > >>> This would break the purpose of the toString method.
> > >>>
> > >>> Do you know any other approaches/work around for this?
> > >>>
> > >>> Best
> > >>> Dat
> > >>>
> > >>> On 2019/06/12 00:56:42, Jason Joo  wrote:
> >  Hi, Tien
> > 
> >  Consistent hash is relying mainly the object's "toString()"
> protocol. So pls make sure your objects have a unique and stable toString()
> method and it will be ok.
> > 
> >  best regards,
> > 
> >  Jason
> > 
> > > On Jun 11, 2019, at 16:58, tphan@gmail.com wrote:
> > >
> > > Dear experts,
> > >
> > > We are using Dubbo to export our services. For data load
> balancing, we would like to use the consistent hash load balancer.
> > > For the default usage of this load balancer, we can define either
> one or several parameters of the consumed method to be used as the hashing
> data.
> > > We wonder if it is possible to target the hashing on the field of
> an object passed as the param.
> > > For instance, the method interface is as follows:
> > >
> > > MyResponse getResponse(MyRequestParams params);
> > >
> > > The object params has a field named URI, which we would like to
> apply the hash algorithm upon.
> > > Of course, we can modify our method to:
> > >
> > > MyResponse getResponse(String uri, MyRequestParams params);
> > >
> > > But this really is contradictory with the design goal of
> MyRequestParam object (which is defined to wrap all our request params into
> one object)
> > >
> > > Best regards
> > > Tien Dat PHAN
> > 
> > 
> > >>
> > >>
> >
> >
>


[VOTE] Accept RitterHou/python-dubbo donation

2019-09-23 Thread Ian Luo
Hi All,

This is a formal vote to bring RitterHou/python-dubbo[1], which is donated
by Qianmi, to Apache Dubbo project.

Please vote:

[ ] +1 Accept
[ ] +0 No Opinion
[ ] -1 Reject because...


[1] https://github.com/RitterHou/python-dubbo


Re: HTTPS for dubbo website

2019-09-18 Thread Ian Luo
Yunkun, would you mind to file an infra ticket [1]?

Thanks,
-Ian.

1.
https://issues.apache.org/jira/projects/INFRA/issues/INFRA-18825?filter=allopenissues

On Tue, Sep 10, 2019 at 3:42 PM YunKun Huang  wrote:

> hey all,
>
> I find for dubbo website, both url works:
> 1.http://dubbo.apache.org
> 2.https://dubbo.apache.org
>
> Ideally, when user access http website, it should redirect https website.
> Anyone knows how to modify this?
>
> Another thing is in github repo[1], in description section, it still using
> http link. I guess this one can ask help from infra team.
>
>
> [1] https://github.com/apache/dubbo-website
>


Re: Passing Java 8 Predicate

2019-09-18 Thread Ian Luo
Phan, are you saying to support the predicate type on the remote interface?
Honestly speaking we have not had chance to think through it carefully, I
suggest you to file an issue [1] to describe it in details.

Thanks,
-Ian.

1. https://github.com/apache/dubbo/issues

On Tue, Sep 17, 2019 at 4:11 PM Tien Dat PHAN  wrote:

> Dear experts
>
> We are currently using Dubbo for exposing our APIs.
> One of our APIs has a Java Predicate as the input parameter.
>
> We just wonder if Dubbo supports Java Predicate for now? (as far as we
> tried, it did not seem to work)
> And if it is planned in the future to support JAVA Predicate as parameters
> of exposed APIs?
>
> Best regards
> Tien Dat PHAN
>


Re: [VOTE]: Release Apache dubbo-go v1.1.0 RC2

2019-09-18 Thread Ian Luo
+1

I checked the following items:

[v]  Are release files in correct location?
[v] Do release files have the word incubating in their name?
[v] Are the digital signature and hashes correct?
[v] Do LICENSE and NOTICE files exists?
[v] Is the LICENSE and NOTICE text correct?
[v] Is the NOTICE year correct?
[v] Un-included software dependencies are not mentioned in LICENSE or
NOTICE?
[v] License information is not mentioned in NOTICE?
[x] Is there any 3rd party code contained inside the release? If so:
 [ ] Does the software have a compatible license?
 [ ] Are all software licenses mentioned in LICENSE?
 [ ] Is the full text of the licenses (or pointers to it) in LICENSE?
 Is any of this code Apache licensed? Do they have NOTICE files? If so:
 [ ] Have relevant parts of those NOTICE files been added to this
NOTICE file?
[v] Do all source files have ASF headers?
[v] Do the contents of the release match with what's tagged in version
control?
[x] Are there any unexpected binary files in the release?
[v] Can you compile from source? Are the instruction clear?

On my mac laptop, I could compile successfully but there's one failed unit
test against net.go. I believe this issue [1] can be fixed with [2] in the
next release.

Is the issue minor?
[v] Yes [ ] No [ ] Unsure

Could it possibly be fixed in the next release?
[v] Yes [ ] No [ ] Unsure

I vote with:
[v] +1 release the software
[ ] +0 not sure if it should be released
[ ] -1 don’t release the software because...

Regards,
-Ian.

1. https://github.com/apache/dubbo-go/issues/207
2. https://github.com/apache/dubbo-go/pull/209


On Sat, Sep 7, 2019 at 6:54 PM stocks alex  wrote:

> Hello Dubbo/Dubbogo Community,
>
>  This is a call for vote to release Apache Dubbo-go version v1.1.0 RC2.
>  The release candidates:
> https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/1.1.0/
>  Git tag for the release:
>  https://github.com/apache/dubbo-go/tree/1.1
>  Hash for the release tag:
>  1747ef485b1bf9e264116b0f73b36ecf452445e4
>  Release Notes:
>  https://github.com/apache/dubbo-go/blob/1.1/CHANGE.md
>  The artifacts have been signed with Key :0D963B35B7F1E689, which can be
>  found in the keys file:
>  https://dist.apache.org/repos/dist/dev/dubbo/KEYS
>  The vote will be open for at least 72 hours or until necessary number of
>  votes are reached.
>  Please vote accordingly:
>  [ ] +1 approve
>  [ ] +0 no opinion
>  [ ] -1 disapprove with the reason
>  Thanks,
>  The Apache Dubbo-go Team
>


Re: [VOTE]: Release Apache dubbo-go v1.1.0 RC2

2019-09-09 Thread Ian Luo
Alex,

Since Justin suggests you to put all artifacts in RC2 directory, you may
not consider this email as an official vote, but I did spend a little time
on sanity check against your second release.

For the source code, it looks fine except for one file:
protocol/mock/mock_invoker.go doesn't have apache license header though
it's generated by tools. You may consider to add one.

Thanks,
-Ian.

On Sat, Sep 7, 2019 at 10:53 PM stocks alex  wrote:

> To Mr Justin Mclean,
>
> Thx for your good advice. I will do it as your suggestion.
>
> Justin Mclean  于2019年9月7日周六 下午10:31写道:
>
> > Hi,
> >
> > > This is a call for vote to release Apache Dubbo-go version v1.1.0 RC2.
> > > The release candidates:
> > > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/1.1.0/
> >
> > Please don’t overwrite the exacting artefact being voted on as we then
> > have no way of knowing which they voted on. They could also be cached and
> > people get the wrong ones. It’s best to make a RC1, RC2 etc etc directory
> > and put the release in that.
> >
> > Thanks,
> > Justin
>


Re: 关于贡献Python的原生dubbo协议客户端给dubbo开源社区

2019-09-09 Thread Ian Luo
Loop in Derobukal.

For SGA submission, pls. refer to this guide [1].

Thanks,
-Ian.

1.
http://dubbo.apache.org/en-us/docs/developers/contributor-guide/software-donation-guide_dev.html

On Mon, Sep 9, 2019 at 10:17 PM Ian Luo  wrote:

> Sounds great, and thanks for qianmi.com again :)
>
> Would you mind to submit SGA [1] and ICLA [2] by following the
> instructions?
>
> Regards,
> -Ian.
>
> 1. https://www.apache.org/licenses/software-grant-template.pdf
> 2.
> http://dubbo.apache.org/en-us/docs/developers/contributor-guide/cla-signing-guide_dev.html
>
>
>
> On Mon, Sep 9, 2019 at 9:42 PM Derobukal  wrote:
>
>>
>> dubbo的原生Python客户端由千米网工程效率组开发,旨在帮助Python工程调用Java工程的dubbo接口获取数据,在千米网内部取得了良好的实践。
>>
>> 千米网同时实现了基于JSONRpc(已经贡献给dubbo开源社区)和基于原生的dubbo协议的这两个Python客户端,这两个组件在公司内部均被广泛使用。
>>
>> 目前已将原生dubbo协议的客户端开源,原生dubbo协议客户端组件项目地址:
>> https://github.com/RitterHou/python-dubbo
>>
>


Re: 关于贡献Python的原生dubbo协议客户端给dubbo开源社区

2019-09-09 Thread Ian Luo
Sounds great, and thanks for qianmi.com again :)

Would you mind to submit SGA [1] and ICLA [2] by following the instructions?

Regards,
-Ian.

1. https://www.apache.org/licenses/software-grant-template.pdf
2.
http://dubbo.apache.org/en-us/docs/developers/contributor-guide/cla-signing-guide_dev.html



On Mon, Sep 9, 2019 at 9:42 PM Derobukal  wrote:

>
> dubbo的原生Python客户端由千米网工程效率组开发,旨在帮助Python工程调用Java工程的dubbo接口获取数据,在千米网内部取得了良好的实践。
>
> 千米网同时实现了基于JSONRpc(已经贡献给dubbo开源社区)和基于原生的dubbo协议的这两个Python客户端,这两个组件在公司内部均被广泛使用。
>
> 目前已将原生dubbo协议的客户端开源,原生dubbo协议客户端组件项目地址:
> https://github.com/RitterHou/python-dubbo
>


Re: CLAassistant comments

2019-09-09 Thread Ian Luo
Just for your information, I've filed
https://issues.apache.org/jira/browse/INFRA-19007, and hope infra team will
fix it soon.

Regards,
-Ian.

On Mon, Sep 9, 2019 at 9:43 PM Ian Luo  wrote:

> I also noticed this recently which is in fact quite inappropriate. I will
> file a INFRA ticket to disable it.
>
> Regards,
> -Ian.
>
>
> On Mon, Sep 9, 2019 at 9:43 AM Huxing Zhang  wrote:
>
>> Hi,
>>
>> Recently I received lots of emails from CLAassistant asking to sign CLA
>> from Alibaba/Dubbo.
>> There is no need to sign such CLA for Apache Project.
>> Is anyone aware of what is going on here?
>>
>> On Fri, Sep 6, 2019 at 6:30 PM CLAassistant 
>> wrote:
>>
>> > [image: CLA assistant check]
>> > <https://cla-assistant.io/alibaba/dubbo?pullRequest=3497>
>> > Thank you for your submission, we really appreciate it. Like many open
>> > source projects, we ask that you sign our Contributor License Agreement
>> > <https://cla-assistant.io/alibaba/dubbo?pullRequest=3497> before we can
>> > accept your contribution.
>> > You have signed the CLA already but the status is still pending? Let us
>> > recheck <https://cla-assistant.io/check/alibaba/dubbo?pullRequest=3497>
>> > it.
>> >
>> > —
>> > You are receiving this because you commented.
>> > Reply to this email directly, view it on GitHub
>> > <
>> https://github.com/apache/dubbo/pull/3497?email_source=notifications_token=ABBRR6IIEM4UJLXTUJ4EEXDQIIWKTA5CNFSM4GYALM62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6COANY#issuecomment-528801847
>> >,
>> > or mute the thread
>> > <
>> https://github.com/notifications/unsubscribe-auth/ABBRR6PQIW33ION2C6LA6YTQIIWKTANCNFSM4GYALM6Q
>> >
>> > .
>> >
>>
>>
>> --
>> Best Regards!
>> Huxing
>>
>


[ANN] Welcome new committer Yincheng Fang

2019-09-09 Thread Ian Luo
Hi, Community,

On behalf of the Dubbo PPMC, I am pleased to announce that Yincheng Fang,
whose github id is fangyc, has been voted in as a new Dubbo committer.

Please join me to say congratulations to him!

Yincheng, would you please briefly introduce yourself to the community?

Best regards,
Ian.


  1   2   3   4   5   6   7   8   >