[GitHub] mzorro opened a new pull request #1562: typo fix

[GitBox]

mzorro opened a new pull request #1562: typo fix
URL: https://github.com/apache/incubator-dubbo/pull/1562
 
 
   fix some typos.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #1562: typo fix

[GitBox]

codecov-io commented on issue #1562: typo fix
URL: https://github.com/apache/incubator-dubbo/pull/1562#issuecomment-379448004
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1562?src=pr&el=h1) 
Report
   > Merging 
[#1562](https://codecov.io/gh/apache/incubator-dubbo/pull/1562?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/20aa3f0b2f5785c80c71f8e8d3d2d3522cb92c2e?src=pr&el=desc)
 will **decrease** coverage by `0.02%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1562/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0)](https://codecov.io/gh/apache/incubator-dubbo/pull/1562?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1562  +/-   ##
   ==
   - Coverage   32.16%   32.14%   -0.03% 
   ==
 Files 682  682  
 Lines   3304833048  
 Branches 6597 6597  
   ==
   - Hits1062910622   -7 
   - Misses  2053120532   +1 
   - Partials 1888 1894   +6
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1562?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[.../exchange/support/header/HeaderExchangeServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1562/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvZXhjaGFuZ2Uvc3VwcG9ydC9oZWFkZXIvSGVhZGVyRXhjaGFuZ2VTZXJ2ZXIuamF2YQ==)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1562/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=)
 | `83.33% <0%> (-5.56%)` | :arrow_down: |
   | 
[...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1562/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DaGFubmVsV3JhcHBlZEludm9rZXIuamF2YQ==)
 | `41.66% <0%> (-4.17%)` | :arrow_down: |
   | 
[...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1562/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh)
 | `51.89% <0%> (-3.8%)` | :arrow_down: |
   | 
[.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1562/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9maWx0ZXIvRnV0dXJlRmlsdGVyLmphdmE=)
 | `54.54% <0%> (-2.03%)` | :arrow_down: |
   | 
[...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1562/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DYWxsYmFja1NlcnZpY2VDb2RlYy5qYXZh)
 | `78.67% <0%> (-1.48%)` | :arrow_down: |
   | 
[.../alibaba/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1562/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==)
 | `38% <0%> (-0.46%)` | :arrow_down: |
   | 
[...libaba/com/caucho/hessian/util/IdentityIntMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1562/diff?src=pr&el=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL3V0aWwvSWRlbnRpdHlJbnRNYXAuamF2YQ==)
 | `30.95% <0%> (+5.95%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1562?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1562?src=pr&el=footer).
 Last update 
[20aa3f0...efb93e1](https://codecov.io/gh/apache/incubator-dubbo/pull/1562?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] binarySortTree opened a new issue #24: 打包失败

[GitBox]

binarySortTree opened a new issue #24: 打包失败
URL: https://github.com/apache/incubator-dubbo-ops/issues/24
 
 
   命令行进入incubator-dubbo-ops-master目录，然后执行mvn package，结果显示打包失败：
   
![20180407164745](https://user-images.githubusercontent.com/29702355/38453136-7449c1b0-3a83-11e8-890f-e5f08d879db4.png)
   
   加上-X选项后，出错信息如下：
   
![20180407164840](https://user-images.githubusercontent.com/29702355/38453174-ec28782a-3a83-11e8-8ede-c407f4f2edf7.png)
   
   请问一下，该怎么解决？
   
   我的环境：
   maven:3.5.0
   jdk:1.8.0_162  64位，
   win7
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #1555: replace vars by Constants.

[GitBox]

codecov-io commented on issue #1555: replace vars by Constants.
URL: https://github.com/apache/incubator-dubbo/pull/1555#issuecomment-379465423
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1555?src=pr&el=h1) 
Report
   > Merging 
[#1555](https://codecov.io/gh/apache/incubator-dubbo/pull/1555?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/20aa3f0b2f5785c80c71f8e8d3d2d3522cb92c2e?src=pr&el=desc)
 will **decrease** coverage by `0.03%`.
   > The diff coverage is `37.5%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1555/graphs/tree.svg?token=VnEIkiFQT0&src=pr&width=650&height=150)](https://codecov.io/gh/apache/incubator-dubbo/pull/1555?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1555  +/-   ##
   ==
   - Coverage   32.16%   32.12%   -0.04% 
   ==
 Files 682  682  
 Lines   3304833048  
 Branches 6597 6597  
   ==
   - Hits1062910618  -11 
   - Misses  2053120534   +3 
   - Partials 1888 1896   +8
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1555?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...n/java/com/alibaba/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1555/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZy5qYXZh)
 | `39.43% <37.5%> (ø)` | :arrow_up: |
   | 
[...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1555/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=)
 | `77.77% <0%> (-11.12%)` | :arrow_down: |
   | 
[...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1555/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DaGFubmVsV3JhcHBlZEludm9rZXIuamF2YQ==)
 | `41.66% <0%> (-4.17%)` | :arrow_down: |
   | 
[...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1555/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh)
 | `51.89% <0%> (-3.8%)` | :arrow_down: |
   | 
[.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1555/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh)
 | `73.14% <0%> (-2.78%)` | :arrow_down: |
   | 
[.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1555/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9maWx0ZXIvRnV0dXJlRmlsdGVyLmphdmE=)
 | `54.54% <0%> (-2.03%)` | :arrow_down: |
   | 
[...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1555/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==)
 | `55.22% <0%> (-1.5%)` | :arrow_down: |
   | 
[...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1555/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DYWxsYmFja1NlcnZpY2VDb2RlYy5qYXZh)
 | `78.67% <0%> (-1.48%)` | :arrow_down: |
   | 
[.../alibaba/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1555/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==)
 | `38% <0%> (-0.46%)` | :arrow_down: |
   | 
[...ba/dubbo/rpc/protocol/hessian/HessianProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1555/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1oZXNzaWFuL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcnBjL3Byb3RvY29sL2hlc3NpYW4vSGVzc2lhblByb3RvY29sLmphdmE=)
 | `63.07% <0%> (+3.07%)` | :arrow_up: |
   | ... and [1 
more](https://codecov.io/gh/apache/incubator-dubbo/pull/1555/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1555?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs

[GitHub] mercyblitz closed pull request #97: update readme

[GitBox]

mercyblitz closed pull request #97: update readme
URL: https://github.com/apache/incubator-dubbo-spring-boot-project/pull/97
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/README.md b/README.md
index 1f120a7d..c73c07c3 100644
--- a/README.md
+++ b/README.md
@@ -1,13 +1,13 @@
 # Dubbo Spring Boot Project
 
-[Dubbo](https://github.com/alibaba/dubbo) Spring Boot Project makes it easy to 
create [Spring Boot](https://github.com/spring-projects/spring-boot/) 
application using Dubbo as RPC Framework. What's more, it aslo provides 
+[Apache Dubbo(incubating)](https://github.com/apache/incubator-dubbo) Spring 
Boot Project makes it easy to create [Spring 
Boot](https://github.com/spring-projects/spring-boot/) application using Dubbo 
as RPC Framework. What's more, it aslo provides 
 
 * [auto-configure features](dubbo-spring-boot-autoconfigure) (e.g., 
annotation-driven, auto configuration, externalized configuration).
 * [production-ready features](dubbo-spring-boot-actuator) (e.g., security, 
health checks, externalized configuration).
 
 
 
-> Dubbo *|ˈdʌbəʊ|* is a high-performance, java based 
[RPC](https://en.wikipedia.org/wiki/Remote_procedure_call) framework 
open-sourced by Alibaba. As in many RPC systems, dubbo is based around the idea 
of defining a service, specifying the methods that can be called remotely with 
their parameters and return types. On the server side, the server implements 
this interface and runs a dubbo server to handle client calls. On the client 
side, the client has a stub that provides the same methods as the server.
+> Apache Dubbo(incubating) is a high-performance, java based 
[RPC](https://en.wikipedia.org/wiki/Remote_procedure_call) framework 
open-sourced by Alibaba. As in many RPC systems, dubbo is based around the idea 
of defining a service, specifying the methods that can be called remotely with 
their parameters and return types. On the server side, the server implements 
this interface and runs a dubbo server to handle client calls. On the client 
side, the client has a stub that provides the same methods as the server.
 
 
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #1555: SerivceAnnotationBeanPostProcessor bug and replace ServiceConfig vars by Constants.

[GitBox]

codecov-io commented on issue #1555: SerivceAnnotationBeanPostProcessor bug and 
replace ServiceConfig vars by Constants.
URL: https://github.com/apache/incubator-dubbo/pull/1555#issuecomment-379465423
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1555?src=pr&el=h1) 
Report
   > Merging 
[#1555](https://codecov.io/gh/apache/incubator-dubbo/pull/1555?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/20aa3f0b2f5785c80c71f8e8d3d2d3522cb92c2e?src=pr&el=desc)
 will **decrease** coverage by `0.04%`.
   > The diff coverage is `44.44%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1555/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0)](https://codecov.io/gh/apache/incubator-dubbo/pull/1555?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1555  +/-   ##
   ==
   - Coverage   32.16%   32.11%   -0.05% 
   ==
 Files 682  682  
 Lines   3304833048  
 Branches 6597 6597  
   ==
   - Hits1062910615  -14 
   - Misses  2053120535   +4 
   - Partials 1888 1898  +10
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1555?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...annotation/ServiceAnnotationBeanPostProcessor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1555/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2JlYW5zL2ZhY3RvcnkvYW5ub3RhdGlvbi9TZXJ2aWNlQW5ub3RhdGlvbkJlYW5Qb3N0UHJvY2Vzc29yLmphdmE=)
 | `84.84% <100%> (ø)` | :arrow_up: |
   | 
[...n/java/com/alibaba/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1555/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZy5qYXZh)
 | `39.43% <37.5%> (ø)` | :arrow_up: |
   | 
[...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1555/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=)
 | `57.5% <0%> (-8.75%)` | :arrow_down: |
   | 
[...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1555/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DaGFubmVsV3JhcHBlZEludm9rZXIuamF2YQ==)
 | `41.66% <0%> (-4.17%)` | :arrow_down: |
   | 
[...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1555/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh)
 | `51.89% <0%> (-3.8%)` | :arrow_down: |
   | 
[...ba/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1555/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlTZXJ2ZXIuamF2YQ==)
 | `67.85% <0%> (-3.58%)` | :arrow_down: |
   | 
[...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1555/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==)
 | `55.22% <0%> (-1.5%)` | :arrow_down: |
   | 
[...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1555/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DYWxsYmFja1NlcnZpY2VDb2RlYy5qYXZh)
 | `78.67% <0%> (-1.48%)` | :arrow_down: |
   | 
[...baba/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1555/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDbGllbnQuamF2YQ==)
 | `57.97% <0%> (-1.45%)` | :arrow_down: |
   | 
[.../alibaba/dubbo/config/AbstractInterfaceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1555/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvQWJzdHJhY3RJbnRlcmZhY2VDb25maWcuamF2YQ==)
 | `38% <0%> (-0.46%)` | :arrow_down: |
   | ... and [1 
more](https://codecov.io/gh/apache/incubator-dubbo/pull/1555/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report a

[GitHub] eonezhang opened a new issue #1563: http2 support?

[GitBox]

eonezhang opened a new issue #1563: http2 support?
URL: https://github.com/apache/incubator-dubbo/issues/1563
 
 
   as netty 4.1.x add default support for http2, and dubbo also support 
protocol extension, is any plan to support http1/2 transport without containers 
such as jetty.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kimmking commented on issue #1560: Dubbo multi-protocol， dubbo & webservice protocol to publish service，when startup fail to init webservice bean

[GitBox]

kimmking commented on issue #1560: Dubbo multi-protocol， dubbo & webservice 
protocol to publish service，when startup fail to init webservice bean
URL: 
https://github.com/apache/incubator-dubbo/issues/1560#issuecomment-379479046
 
 
   @rongmin you can use the latest version by packaging from the master code.
   1. then you can add ws protocol to a xml file just like:

incubator-dubbo\dubbo-test\dubbo-test-`examples\src\main\java\com\alibaba\dubbo\examples\generic\generic-provider.xml`
   
   `
   
   
   
   
   
   
   
   
   
   
   
   `
   2. run  
`git\incubator-dubbo\dubbo-test\dubbo-test-examples\src\main\java\com\alibaba\dubbo\examples\generic\GenericProvider.java`
  as an application in your IDE.
   3. and then visit a WSDL from URL:
   
http://192.168.123.102:10880/com.alibaba.dubbo.examples.generic.api.IUserService?WSDL
   4. you will find WS work well, the ref CXF version is 3.0.4 now.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kimmking commented on issue #1560: Dubbo multi-protocol， dubbo & webservice protocol to publish service，when startup fail to init webservice bean

[GitBox]

kimmking commented on issue #1560: Dubbo multi-protocol， dubbo & webservice 
protocol to publish service，when startup fail to init webservice bean
URL: 
https://github.com/apache/incubator-dubbo/issues/1560#issuecomment-379479046
 
 
   @rongmin you can use the latest version by packaging from the master code.
   1. then you can add ws protocol to a xml file just like:

incubator-dubbo\dubbo-test\dubbo-test-`examples\src\main\java\com\alibaba\dubbo\examples\generic\generic-provider.xml`
   
   `
   
   
   
   
   
   
   
   
   
   
   
   `
   2. run  
`git\incubator-dubbo\dubbo-test\dubbo-test-examples\src\main\java\com\alibaba\dubbo\examples\generic\GenericProvider.java`
  as an application in your IDE.
   3. and then visit a WSDL from URL:
   
http://192.168.123.102:10880/com.alibaba.dubbo.examples.generic.api.IUserService?WSDL
   4. you will find WS work well, the ref CXF version is 3.0.14 now.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kimmking opened a new pull request #1564: update CXF to latest version and add test case for webservice protocol

[GitBox]

kimmking opened a new pull request #1564: update CXF to latest version and add 
test case for webservice protocol
URL: https://github.com/apache/incubator-dubbo/pull/1564
 
 
   ## What is the purpose of the change
   
   update CXF to latest version 3.2.4 and add test case for webservice protocol
   
   ## Brief changelog
   
   update CXF to latest version 3.2.4 and add test case for webservice protocol
   
   ## Verifying this change
   
   1.Running test case
   2.Verifying #1560


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kimmking commented on issue #1560: Dubbo multi-protocol， dubbo & webservice protocol to publish service，when startup fail to init webservice bean

[GitBox]

kimmking commented on issue #1560: Dubbo multi-protocol， dubbo & webservice 
protocol to publish service，when startup fail to init webservice bean
URL: 
https://github.com/apache/incubator-dubbo/issues/1560#issuecomment-379483154
 
 
   generic test case is not a good demo,
   I update CXF to 3.2.4 and add a demo for it.
   #1564 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kimmking commented on issue #1560: Dubbo multi-protocol， dubbo & webservice protocol to publish service，when startup fail to init webservice bean

[GitBox]

kimmking commented on issue #1560: Dubbo multi-protocol， dubbo & webservice 
protocol to publish service，when startup fail to init webservice bean
URL: 
https://github.com/apache/incubator-dubbo/issues/1560#issuecomment-379483154
 
 
   generic test case is not a good demo,
   I update CXF to 3.2.4 and add a demo for it: #1564 
   
   
![_20180408003210](https://user-images.githubusercontent.com/807508/38457669-80c7921c-3ac6-11e8-82bd-500481d660f1.png)
   
![_20180408004433](https://user-images.githubusercontent.com/807508/38457670-81431522-3ac6-11e8-82ad-fb880dbcdf2e.png)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kimmking commented on issue #1560: Dubbo multi-protocol， dubbo & webservice protocol to publish service，when startup fail to init webservice bean

[GitBox]

kimmking commented on issue #1560: Dubbo multi-protocol， dubbo & webservice 
protocol to publish service，when startup fail to init webservice bean
URL: 
https://github.com/apache/incubator-dubbo/issues/1560#issuecomment-379483154
 
 
   generic test case is not a good demo,
   I update CXF to 3.2.4 and add a demo for it: #1564 
   
   As a WebService by SoapUI:
   
![_20180408003210](https://user-images.githubusercontent.com/807508/38457669-80c7921c-3ac6-11e8-82bd-500481d660f1.png)
   
   As a RPC by dubbo-rpc:
   
![_20180408004433](https://user-images.githubusercontent.com/807508/38457670-81431522-3ac6-11e8-82ad-fb880dbcdf2e.png)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #1564: update CXF to latest version and add test case for webservice protocol

[GitBox]

codecov-io commented on issue #1564: update CXF to latest version and add test 
case for webservice protocol
URL: https://github.com/apache/incubator-dubbo/pull/1564#issuecomment-379484796
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1564?src=pr&el=h1) 
Report
   > Merging 
[#1564](https://codecov.io/gh/apache/incubator-dubbo/pull/1564?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/20aa3f0b2f5785c80c71f8e8d3d2d3522cb92c2e?src=pr&el=desc)
 will **decrease** coverage by `0.09%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1564/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0)](https://codecov.io/gh/apache/incubator-dubbo/pull/1564?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master#1564 +/-   ##
   =
   - Coverage   32.17%   32.08%   -0.1% 
   =
 Files 682  686  +4 
 Lines   3304833084 +36 
 Branches 6597 6599  +2 
   =
   - Hits1063410615 -19 
   - Misses  2052520576 +51 
   - Partials 1889 1893  +4
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1564?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[.../dubbo/examples/webservice/WebserviceProvider.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1564/diff?src=pr&el=tree#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWV4YW1wbGVzL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZXhhbXBsZXMvd2Vic2VydmljZS9XZWJzZXJ2aWNlUHJvdmlkZXIuamF2YQ==)
 | `0% <0%> (ø)` | |
   | 
[...ubbo/examples/webservice/impl/UserServiceImpl.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1564/diff?src=pr&el=tree#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWV4YW1wbGVzL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZXhhbXBsZXMvd2Vic2VydmljZS9pbXBsL1VzZXJTZXJ2aWNlSW1wbC5qYXZh)
 | `0% <0%> (ø)` | |
   | 
[.../dubbo/examples/webservice/WebserviceConsumer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1564/diff?src=pr&el=tree#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWV4YW1wbGVzL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZXhhbXBsZXMvd2Vic2VydmljZS9XZWJzZXJ2aWNlQ29uc3VtZXIuamF2YQ==)
 | `0% <0%> (ø)` | |
   | 
[...bo/rpc/protocol/webservice/WebServiceProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1564/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy13ZWJzZXJ2aWNlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcnBjL3Byb3RvY29sL3dlYnNlcnZpY2UvV2ViU2VydmljZVByb3RvY29sLmphdmE=)
 | `0% <0%> (ø)` | :arrow_up: |
   | 
[...om/alibaba/dubbo/examples/webservice/api/User.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1564/diff?src=pr&el=tree#diff-ZHViYm8tdGVzdC9kdWJiby10ZXN0LWV4YW1wbGVzL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZXhhbXBsZXMvd2Vic2VydmljZS9hcGkvVXNlci5qYXZh)
 | `0% <0%> (ø)` | |
   | 
[...libaba/com/caucho/hessian/util/IdentityIntMap.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1564/diff?src=pr&el=tree#diff-aGVzc2lhbi1saXRlL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvY29tL2NhdWNoby9oZXNzaWFuL3V0aWwvSWRlbnRpdHlJbnRNYXAuamF2YQ==)
 | `25% <0%> (-5.96%)` | :arrow_down: |
   | 
[...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1564/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9DaGFubmVsV3JhcHBlZEludm9rZXIuamF2YQ==)
 | `41.66% <0%> (-4.17%)` | :arrow_down: |
   | 
[...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1564/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh)
 | `51.89% <0%> (-3.8%)` | :arrow_down: |
   | 
[.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1564/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh)
 | `73.14% <0%> (-2.78%)` | :arrow_down: |
   | 
[.../dubbo/rpc/protocol/dubbo/filter/FutureFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1564/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby9maWx0ZXIvRnV0dXJlRmlsdGVyLmphdmE=)
 | `54.54% <0%> (-2.03%)` | :arrow_down: |
   | ... and [7 
more](https://codecov.io/gh/apache/incubator-dubbo/pull/1564/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1564?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (im

[GitHub] htynkn commented on a change in pull request #1564: update CXF to latest version and add test case for webservice protocol

[GitBox]

htynkn commented on a change in pull request #1564: update CXF to latest 
version and add test case for webservice protocol
URL: https://github.com/apache/incubator-dubbo/pull/1564#discussion_r179932240
 
 

 ##
 File path: dubbo-rpc/dubbo-rpc-webservice/pom.xml
 ##
 @@ -43,10 +43,12 @@
 
 org.apache.cxf
 cxf-rt-frontend-simple
+3.2.4
 
 
 org.apache.cxf
 cxf-rt-transports-http
+3.2.4
 
 Review comment:
   version is managed in here: 
https://github.com/apache/incubator-dubbo/blob/master/dependencies-bom/pom.xml#L184
   You may like to update it in dependencies-bom project


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] CoderDade commented on issue #1533: 在Dubbo的Filter里面无法拿到隐式传参的参数（I can't get the attachment in Dubbo Filter）？

[GitBox]

CoderDade commented on issue #1533: 在Dubbo的Filter里面无法拿到隐式传参的参数（I can't get the 
attachment in Dubbo Filter）？
URL: 
https://github.com/apache/incubator-dubbo/issues/1533#issuecomment-379512794
 
 
   @techyang 2.5.7


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] diecui1202 commented on issue #1503: ServiceBean.getSpringContext() is null

[GitBox]

diecui1202 commented on issue #1503:  ServiceBean.getSpringContext()  is null
URL: 
https://github.com/apache/incubator-dubbo/issues/1503#issuecomment-379513106
 
 
   @hengyuanabc will check this problem in his hands-on working.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] diecui1202 commented on issue #1503: ServiceBean.getSpringContext() is null

[GitBox]

diecui1202 commented on issue #1503:  ServiceBean.getSpringContext()  is null
URL: 
https://github.com/apache/incubator-dubbo/issues/1503#issuecomment-379513106
 
 
   @duanling will check this problem in his hands-on working.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] diecui1202 commented on issue #1503: ServiceBean.getSpringContext() is null

[GitBox]

diecui1202 commented on issue #1503:  ServiceBean.getSpringContext()  is null
URL: 
https://github.com/apache/incubator-dubbo/issues/1503#issuecomment-379513106
 
 
   @hengyunabc will check this problem in his hands-on working.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] diecui1202 commented on issue #1501: local mock not work according by the user manual

[GitBox]

diecui1202 commented on issue #1501: local mock not work according by the user 
manual
URL: 
https://github.com/apache/incubator-dubbo/issues/1501#issuecomment-379513750
 
 
   @vangoleo The user book has not been corrected. Please commit a PR under 
https://github.com/apache/incubator-dubbo-docs
   
   After finish that, please ask committer to close this issue please.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] beiwei30 closed pull request #1562: typo fix

[GitBox]

beiwei30 closed pull request #1562: typo fix
URL: https://github.com/apache/incubator-dubbo/pull/1562
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/exchange/support/header/HeaderExchangeServer.java
 
b/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/exchange/support/header/HeaderExchangeServer.java
index 6d77a1822a..67b9ff2e20 100644
--- 
a/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/exchange/support/header/HeaderExchangeServer.java
+++ 
b/dubbo-remoting/dubbo-remoting-api/src/main/java/com/alibaba/dubbo/remoting/exchange/support/header/HeaderExchangeServer.java
@@ -54,7 +54,7 @@
 true));
 private final Server server;
 // heartbeat timer
-private ScheduledFuture heatbeatTimer;
+private ScheduledFuture heartbeatTimer;
 // heartbeat timeout (ms), default value is 0 , won't execute a heartbeat.
 private int heartbeat;
 private int heartbeatTimeout;
@@ -70,7 +70,7 @@ public HeaderExchangeServer(Server server) {
 if (heartbeatTimeout < heartbeat * 2) {
 throw new IllegalStateException("heartbeatTimeout < 
heartbeatInterval * 2");
 }
-startHeatbeatTimer();
+startHeartbeatTimer();
 }
 
 public Server getServer() {
@@ -134,7 +134,7 @@ private void sendChannelReadOnlyEvent() {
 if (channel.isConnected())
 channel.send(request, 
getUrl().getParameter(Constants.CHANNEL_READONLYEVENT_SENT_KEY, true));
 } catch (RemotingException e) {
-logger.warn("send connot write messge error.", e);
+logger.warn("send cannot write message error.", e);
 }
 }
 }
@@ -205,7 +205,7 @@ public void reset(URL url) {
 if (h != heartbeat || t != heartbeatTimeout) {
 heartbeat = h;
 heartbeatTimeout = t;
-startHeatbeatTimer();
+startHeartbeatTimer();
 }
 }
 } catch (Throwable t) {
@@ -232,10 +232,10 @@ public void send(Object message, boolean sent) throws 
RemotingException {
 server.send(message, sent);
 }
 
-private void startHeatbeatTimer() {
+private void startHeartbeatTimer() {
 stopHeartbeatTimer();
 if (heartbeat > 0) {
-heatbeatTimer = scheduled.scheduleWithFixedDelay(
+heartbeatTimer = scheduled.scheduleWithFixedDelay(
 new HeartBeatTask(new HeartBeatTask.ChannelProvider() {
 public Collection getChannels() {
 return Collections.unmodifiableCollection(
@@ -248,14 +248,14 @@ private void startHeatbeatTimer() {
 
 private void stopHeartbeatTimer() {
 try {
-ScheduledFuture timer = heatbeatTimer;
+ScheduledFuture timer = heartbeatTimer;
 if (timer != null && !timer.isCancelled()) {
 timer.cancel(true);
 }
 } catch (Throwable t) {
 logger.warn(t.getMessage(), t);
 } finally {
-heatbeatTimer = null;
+heartbeatTimer = null;
 }
 }
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] beiwei30 closed pull request #1388: Remove unnecessary StringBuilder

[GitBox]

beiwei30 closed pull request #1388: Remove unnecessary StringBuilder
URL: https://github.com/apache/incubator-dubbo/pull/1388
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/merger/ArrayMerger.java
 
b/dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/merger/ArrayMerger.java
index 873138974f..443a51f2b0 100644
--- 
a/dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/merger/ArrayMerger.java
+++ 
b/dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/merger/ArrayMerger.java
@@ -34,9 +34,7 @@
 if (item != null && item.getClass().isArray()) {
 totalLen += Array.getLength(item);
 } else {
-throw new IllegalArgumentException(
-new StringBuilder(32).append(i + 1)
-.append("th argument is not an 
array").toString());
+throw new IllegalArgumentException(i + 1 + "th argument is not 
an array");
 }
 }
 
diff --git 
a/dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/support/MergeableClusterInvoker.java
 
b/dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/support/MergeableClusterInvoker.java
index 62372108f8..048d25594b 100644
--- 
a/dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/support/MergeableClusterInvoker.java
+++ 
b/dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/support/MergeableClusterInvoker.java
@@ -99,21 +99,14 @@ public Result call() throws Exception {
 try {
 Result r = future.get(timeout, TimeUnit.MILLISECONDS);
 if (r.hasException()) {
-log.error(new StringBuilder(32).append("Invoke ")
-
.append(getGroupDescFromServiceKey(entry.getKey()))
-.append(" failed: ")
-
.append(r.getException().getMessage()).toString(),
+log.error("Invoke " + 
getGroupDescFromServiceKey(entry.getKey()) + 
+" failed: " + 
r.getException().getMessage(), 
 r.getException());
 } else {
 resultList.add(r);
 }
 } catch (Exception e) {
-throw new RpcException(new StringBuilder(32)
-.append("Failed to invoke service ")
-.append(entry.getKey())
-.append(": ")
-.append(e.getMessage()).toString(),
-e);
+throw new RpcException("Failed to invoke service " + 
entry.getKey() + ": " + e.getMessage(), e);
 }
 }
 
@@ -133,13 +126,8 @@ public Result call() throws Exception {
 try {
 method = returnType.getMethod(merger, returnType);
 } catch (NoSuchMethodException e) {
-throw new RpcException(new StringBuilder(32)
-.append("Can not merge result because missing method [ 
")
-.append(merger)
-.append(" ] in class [ ")
-.append(returnType.getClass().getName())
-.append(" ]")
-.toString());
+throw new RpcException("Can not merge result because missing 
method [ " + merger + " ] in class [ " + 
+returnType.getClass().getName() + " ]");
 }
 if (!Modifier.isPublic(method.getModifiers())) {
 method.setAccessible(true);
@@ -157,11 +145,7 @@ public Result call() throws Exception {
 }
 }
 } catch (Exception e) {
-throw new RpcException(
-new StringBuilder(32)
-.append("Can not merge result: ")
-.append(e.getMessage()).toString(),
-e);
+throw new RpcException("Can not merge result: " + 
e.getMessage(), e);
 }
 } else {
 Merger resultMerger;
@@ -203,8 +187,7 @@ public void destroy() {
 private String getGroupDescFromServiceKey(String key) {
 int index = key.indexOf("/");
 if (index > 0) {
-return new StringBuilder(32).append("group [ ")
-.append(key.substring(0, index)).append(" ]").toString();
+return "group [ " + key.substring(0, index) + " ]";
 }
 return key;
 }
diff --git 
a/dubbo-cluster/src/test/java/com/alibaba/dubbo/rpc/cluster/support/MergeableClusterInvokerTest.java
 
b/dubbo-cluster/src/tes

[GitHub] beiwei30 commented on a change in pull request #1388: Remove unnecessary StringBuilder

[GitBox]

beiwei30 commented on a change in pull request #1388: Remove unnecessary 
StringBuilder
URL: https://github.com/apache/incubator-dubbo/pull/1388#discussion_r179933003
 
 

 ##
 File path: 
dubbo-cluster/src/main/java/com/alibaba/dubbo/rpc/cluster/merger/ArrayMerger.java
 ##
 @@ -34,9 +34,7 @@
 if (item != null && item.getClass().isArray()) {
 totalLen += Array.getLength(item);
 } else {
-throw new IllegalArgumentException(
-new StringBuilder(32).append(i + 1)
-.append("th argument is not an 
array").toString());
+throw new IllegalArgumentException(i + 1 + "th argument is not 
an array");
 
 Review comment:
   agree. I will accept the change, but will submit a supplementary change 
because it's safer by doing this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mercyblitz commented on issue #99: How to Generic reference

[GitBox]

mercyblitz commented on issue #99: How to Generic reference
URL: 
https://github.com/apache/incubator-dubbo-spring-boot-project/issues/99#issuecomment-379514543
 
 
   How to reference "fzjh" Bean?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mercyblitz closed issue #98: how to configure multiple protocols

[GitBox]

mercyblitz closed issue #98: how to configure multiple protocols
URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/98
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mercyblitz commented on issue #98: how to configure multiple protocols

[GitBox]

mercyblitz commented on issue #98: how to configure multiple protocols
URL: 
https://github.com/apache/incubator-dubbo-spring-boot-project/issues/98#issuecomment-379514595
 
 
   ```properties
   dubbo.protocols[hessian].id = hessian
   dubbo.protocols[hessian].name = hessian
   dubbo.protocols[hessian].port = 12346
   dubbo.protocols[hessian].status = server
   ```
   Does not work...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mercyblitz commented on issue #95: idea调试模式项目启动不起来，正常启动没问题

[GitBox]

mercyblitz commented on issue #95: idea调试模式项目启动不起来，正常启动没问题
URL: 
https://github.com/apache/incubator-dubbo-spring-boot-project/issues/95#issuecomment-379514654
 
 
   Which project you start in IDEA?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mercyblitz closed issue #63: Replace META-INF/spring-configuration-metadata.json manually

[GitBox]

mercyblitz closed issue #63: Replace 
META-INF/spring-configuration-metadata.json manually
URL: https://github.com/apache/incubator-dubbo-spring-boot-project/issues/63
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] celesky commented on issue #1544: dubbo能否支持netty4?

[GitBox]

celesky commented on issue #1544: dubbo能否支持netty4?
URL: 
https://github.com/apache/incubator-dubbo/issues/1544#issuecomment-379514741
 
 
   原来搞it的也有低级喷子和键盘侠，佩服啊


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] beiwei30 commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP

[GitBox]

beiwei30 commented on issue #1508: feature required: set registrydirectory to 
AP when implementation is CP
URL: 
https://github.com/apache/incubator-dubbo/issues/1508#issuecomment-379514920
 
 
   dubbo already considered this scenario:
   
   ```java
   if (invokerUrls.isEmpty() && this.cachedInvokerUrls != null) {
   invokerUrls.addAll(this.cachedInvokerUrls);
   } else {
   this.cachedInvokerUrls = new HashSet();
   this.cachedInvokerUrls.addAll(invokerUrls);//Cached invoker 
urls, convenient for comparison
   }
   if (invokerUrls.isEmpty()) {
   return;
   }
   ```
   
   if the addresses from the register center is empty, then the cached address 
list `cachedInvokerUrls` will be used. 
   
   feel free to reopen this issue if you do not agree.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] beiwei30 closed issue #1508: feature required: set registrydirectory to AP when implementation is CP

[GitBox]

beiwei30 closed issue #1508: feature required: set registrydirectory to AP when 
implementation is CP
URL: https://github.com/apache/incubator-dubbo/issues/1508
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] empireaaron opened a new issue #1565: dubbo最佳实践案例，全自动开源框架Emsite

[GitBox]

empireaaron opened a new issue #1565: dubbo最佳实践案例，全自动开源框架Emsite
URL: https://github.com/apache/incubator-dubbo/issues/1565
 
 
   
望dubbo团队快速完成到apache顶级项目的升级，申请做dubbo的最佳使用示范项目：https://gitee.com/hackempire/emsite-parent


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ralf0131 opened a new issue #9: Update the legacy links in docs

[GitBox]

ralf0131 opened a new issue #9: Update the legacy links in docs
URL: https://github.com/apache/incubator-dubbo-docs/issues/9
 
 
   Some of the links in doc link to unavailable resource, e.g.
   
   * http://dubbo.io/books/dubbo-admin-book-en/install/provider-demo.html
   * http://code.alibabatech.com/schema/dubbo
   
   We need to cleanup these dead links.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ralf0131 commented on issue #9: Update the legacy links in docs

[GitBox]

ralf0131 commented on issue #9: Update the legacy links in docs
URL: 
https://github.com/apache/incubator-dubbo-docs/issues/9#issuecomment-379515134
 
 
   If you do a search in the root dir
   
   ```sh
   fgrep -rin dubbo.io **/*.md
   fgrep -rin alibabatech **/*.md
   ```
   
   You can find lots of dead links.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cvictory commented on issue #1426: fix isShutdown always return true

[GitBox]

cvictory commented on issue #1426: fix isShutdown always return true
URL: https://github.com/apache/incubator-dubbo/pull/1426#issuecomment-379515269
 
 
   Review the commit , change isShutdown to isTerminated. 
   
   * java.util.concurrent.ExecutorService#isShutdown will return true , after 
invoking shutdown or shutdownNow.
   * java.util.concurrent.ExecutorService#isTerminated will return true, after 
all tasks have completed execution.
   
   It is correct about this modification.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ralf0131 commented on issue #1565: dubbo最佳实践案例申请，全自动开源框架Emsite

[GitBox]

ralf0131 commented on issue #1565: dubbo最佳实践案例申请，全自动开源框架Emsite
URL: 
https://github.com/apache/incubator-dubbo/issues/1565#issuecomment-379515348
 
 
   Hi, welcome!
   
   Would you please update the title and description using English? Dubbo is a 
global community and we would like the issue to be seen by people all over the 
world.
   
   Questions like this are expected to be asked in the mailing list, you can 
[subscribe](https://github.com/apache/incubator-dubbo/issues/1393) and ask 
there.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cvictory commented on issue #1444: [Dubbo-RpcContext] Simplify check consumer side in RpcContext

[GitBox]

cvictory commented on issue #1444: [Dubbo-RpcContext] Simplify check consumer 
side in RpcContext
URL: https://github.com/apache/incubator-dubbo/pull/1444#issuecomment-379515681
 
 
   where is the usage of isProviderSide and isConsumerSide?
   I cannot judge whether it is right.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] skykong1981 commented on issue #1387: [dubbo-cache] A method level cache implementation for dubbo.

[GitBox]

skykong1981 commented on issue #1387: [dubbo-cache] A method level cache 
implementation for dubbo.
URL: https://github.com/apache/incubator-dubbo/pull/1387#issuecomment-379516277
 
 
   @lovepoem @diecui1202 Sorry. I'm very busy with my recent work in company. 
I'll fix it when company work done. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: List volume and issue tracking

[Ian Luo]

I think this can be solved by distinguishing github notifications from
regular dev@dubbo.apache.org traffic.  For github notifications, including
issue and pull request, the update message should only go to the interested
parties who are involved in this particular topic, but @dev should never be
the audience.

I guess @dev mail list is configured in 'Settings -> Integrations &
Services -> Email' for github.com/apache/inclubator-dubbo* projects. I am
not sure who I should contact therefore I am here cc-ing
us...@infra.apache.org.

I suggest to remove @dev mail list from github subscription list.

Thanks,
-Ian.



On Tue, Apr 3, 2018 at 5:55 PM, Huxing Zhang  wrote:

> Hi,
>
> I am +1 on split the traffic of @dev list.
>
> The issue appears after migrating repo to ASF. I use
> "label:asf-dubbo-dev -[github]" to filter out them. :(
>
> On Tue, Apr 3, 2018 at 5:06 PM, Yong Zhu  wrote:
> > I have the same feeling.
> >
> > IMO, all the issue emails should be sent to iss...@dubbo.apache.org, all
>
> +1. All issues and the comments should go there.
>
> > the PR emails should be sent to comm...@dubbo.apache.org. How do you
> think?
>
> -1. commit@ are used when code are committed to repo, I don't think
> PRs should go there.
> Once a PR is accepted, a message will be sent to commit@
>
> My suggestion is PRs and the comments should go to issues@, or we can
> create a new list prs@.
>
> > and who can help to fix this?
> >
> > And I think we should use github issues, and move all the Jira issues to
> > github.
> >
> > 2018-04-03 16:43 GMT+08:00 Mark Thomas :
> >
> >> All,
> >>
> >> I've been away for just over a week and come back to find over 300
> >> unread emails on the dev list.
> >>
> >> A large proportion of these messages are comments on pull requests? Is
> >> dev@ the right list for those?
> >>
> >> Another large proportion appear to be comments on issues? Is dev@ the
> >> right list for those?
> >>
> >> Generally, the recommendation is to split into multiple lists based on
> >> audience rather than topic. For some projects it therefore makes sense
> >> to have all dev related traffic going to a single list. For others,
> >> particularly large projects, it makes sense to split the dev traffic.
> >>
> >> The project appears to be using GitHub issues and Jira. That is
> >> confusing. I'd recommend that you select one issue tracker and stick to
> it.
>
> There was discussion[1] on the mailing list and the community has
> decided to use github issues.
> My understanding is that currently JIRA is only used for GSOC ideas
> and track existing issues prior to that decision.
> I am +0 on migrating the existing JIRA issues to github issues.
>
> >>
> >> Finally, the github issues seem to be a mix of bugs and support
> >> questions. Is that the way the podling wants to use github issues?
>
> People get used to ask questions by creating an issue before joining ASF.
> The PPMC are trying to tell users to use mailing list to ask questions
> by leaving message on the issues, so does the website.
> But I think it will take some time.
>
> >>
> >> I have no view on what the 'right' answers to the above questions are.
> >> I'm asking them to get the podling thinking about the issues. What, if
> >> anything, to do about any of the above is for the podling to decide.
> >>
> >>
> >> Mark
> >>
>
>
> [1] https://lists.apache.org/thread.html/c8ca0bf3bff8f0ee236567bba2a387
> 6c4d8b91a28a94948be4cb74b8@%3Cdev.dubbo.apache.org%3E
> --
> Best Regards！
> Huxing
>

[GitHub] HouZhiHouJue commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP

[GitBox]

HouZhiHouJue commented on issue #1508: feature required: set registrydirectory 
to AP when implementation is CP
URL: 
https://github.com/apache/incubator-dubbo/issues/1508#issuecomment-379516916
 
 
   but when register center lost all provider instance , invokerUrls will not 
be empty,it has one element and the protocol is Constants.EMPTY_PROTOCOL,so the 
code may not be right.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] HouZhiHouJue commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP

[GitBox]

HouZhiHouJue commented on issue #1508: feature required: set registrydirectory 
to AP when implementation is CP
URL: 
https://github.com/apache/incubator-dubbo/issues/1508#issuecomment-379516916
 
 
   but when register center lost all provider instance , invokerUrls will not 
be empty,it has one element and the protocol is Constants.EMPTY_PROTOCOL,so the 
code may not be right.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] beiwei30 commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP

[GitBox]

beiwei30 commented on issue #1508: feature required: set registrydirectory to 
AP when implementation is CP
URL: 
https://github.com/apache/incubator-dubbo/issues/1508#issuecomment-379517349
 
 
   with which registry center did you experience the problem? we may need to 
discuss this further.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] HouZhiHouJue commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP

[GitBox]

HouZhiHouJue commented on issue #1508: feature required: set registrydirectory 
to AP when implementation is CP
URL: 
https://github.com/apache/incubator-dubbo/issues/1508#issuecomment-379516916
 
 
   when register center is zookeeper, the invokerUrls will not be empty,it has 
one element and the protocol is Constants.EMPTY_PROTOCOL,so the code may not be 
right.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nzomkxia opened a new pull request #10: update dubbo docs address in readme

[GitBox]

nzomkxia opened a new pull request #10: update dubbo docs address in readme
URL: https://github.com/apache/incubator-dubbo-docs/pull/10
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nzomkxia closed pull request #10: update dubbo docs address in readme

[GitBox]

nzomkxia closed pull request #10: update dubbo docs address in readme
URL: https://github.com/apache/incubator-dubbo-docs/pull/10
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/README.md b/README.md
index 857323f..6334c9e 100644
--- a/README.md
+++ b/README.md
@@ -1,19 +1,17 @@
-# A collection of dubbo docs
+# A collection of Apache Dubbo (incubating) docs
 
-* [Dubbo user manual(English)](http://dubbo.io/books/dubbo-user-book-en/) or 
[Dubbo用户手册(中文)](http://dubbo.io/books/dubbo-user-book/) - Describe how to use 
Dubbo and all features of Dubbo concretely.
-* [Dubbo developer guide(English)](http://dubbo.io/books/dubbo-dev-book-en/) 
or [Dubbo开发手册(中文)](http://dubbo.io/books/dubbo-dev-book/) - Detailly introduce 
the design principal, extension mechanisms, code conventions, version control 
and building project, etc.
-* [Dubbo admin manual(English)](http://dubbo.io/books/dubbo-admin-book-en/) or 
[Dubbo管理手册(中文)](http://dubbo.io/books/dubbo-admin-book/) - Describe how to use 
Dubbo registry and admin-console.
+* [Dubbo user 
manual(English)](http://dubbo.apache.org/books/dubbo-user-book-en/) or 
[Dubbo用户手册(中文)](http://dubbo.apache.org/books/dubbo-user-book/) - Describe how 
to use Dubbo and all features of Dubbo concretely.
+* [Dubbo developer 
guide(English)](http://dubbo.apache.org/books/dubbo-dev-book-en/) or 
[Dubbo开发手册(中文)](http://dubbo.apache.org/books/dubbo-dev-book/) - Detailly 
introduce the design principal, extension mechanisms, code conventions, version 
control and building project, etc.
+* [Dubbo admin 
manual(English)](http://dubbo.apache.org/books/dubbo-admin-book-en/) or 
[Dubbo管理手册(中文)](http://dubbo.apache.org/books/dubbo-admin-book/) - Describe how 
to use Dubbo registry and admin-console.
 
 ## How to Visit (Publish Address):
 
-* The Chinese version is released under the `dubbo.io` domain, for example, 
you can visit User Mannual through http://dubbo.io/books/dubbo-user-book/.
-* The English version is published to `dubbo.io` as well, in addition, it is 
also published to `dubbo.gitbooks.io`. This way, you can visit the User Mannul 
through http://dubbo.io/books/dubbo-user-book-en/ or 
https://dubbo.gitbooks.io/user-book-en/.
+* The Chinese version is released under the `dubbo.apache.org` domain, for 
example, you can visit User Mannual through 
http://dubbo.apache.org/books/dubbo-user-book/.
+* The English version is published to `dubbo.apache.org` as well. This way, 
you can visit the User Mannul through 
http://dubbo.apache.org/books/dubbo-user-book-en/.
 
 ## How to Publish
 
 This repository only stores markdown sources, in order to be visited by users, 
it should be published everytime when there's an update. It will not be 
published automatically, so the committers need to publish mannually following 
rules below:
 
-* Publish to dubbo.io. You can find [the publish 
script](https://github.com/dubbo/dubbo.github.io/blob/master/script/deploy) 
stored in repo dubbo/dubbo.github.io(the official site), clone that repo and 
run the script, all resources will be published automatically to dubbo.io.
-* Publish to dubbo.gitbooks.io(only for english version). There's no publish 
script for this approach, what you need to do is merge the master branch to the 
corresponding branch. Because the gitbooks is watching the branches in this 
repo:gitbook-admin-en, gitbook-user-en, gitbook-dev-en, every change will be 
published automitically.
-
+* Publish to dubbo.apache.org. You can find [the publish 
script](https://github.com/apache/incubator-dubbo-website/blob/asf-site/script/deploy)
 stored in repo incubator-dubbo-website(the official site), clone that repo and 
run the script, all resources will be published automatically to 
dubbo.apache.org.
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] cvictory commented on issue #1522: 启动时检查依赖,无论我check设为true或者false，它都不检测直接启动成功

[GitBox]

cvictory commented on issue #1522: 启动时检查依赖,无论我check设为true或者false，它都不检测直接启动成功
URL: 
https://github.com/apache/incubator-dubbo/issues/1522#issuecomment-379517483
 
 
   @zeng54088  Is the issue ok ? And what is the reason?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] beiwei30 closed issue #1512: dubbo service register zookeeper very slow

[GitBox]

beiwei30 closed issue #1512: dubbo service register zookeeper very slow
URL: https://github.com/apache/incubator-dubbo/issues/1512
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] HouZhiHouJue commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP

[GitBox]

HouZhiHouJue commented on issue #1508: feature required: set registrydirectory 
to AP when implementation is CP
URL: 
https://github.com/apache/incubator-dubbo/issues/1508#issuecomment-379517607
 
 
   ` ChildListener zkListener = listeners.get(listener);
   
   if (zkListener == null) {
   
   listeners.putIfAbsent(listener, new ChildListener() {
   
   public void childChanged(String parentPath, 
List currentChilds) {
   
   ZookeeperRegistry.this.notify(url, listener, 
toUrlsWithEmpty(url, parentPath, currentChilds));
   
   }
   
   });
   
   zkListener = listeners.get(listener);
   
   }
   
   zkClient.create(path, false);
   
   List children = zkClient.addChildListener(path, 
zkListener);
   
   if (children != null) {
   
   urls.addAll(toUrlsWithEmpty(url, path, children));
   
   }`
   
   zookeeper ,sorry to did not say clearly at the beginning


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] HouZhiHouJue commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP

[GitBox]

HouZhiHouJue commented on issue #1508: feature required: set registrydirectory 
to AP when implementation is CP
URL: 
https://github.com/apache/incubator-dubbo/issues/1508#issuecomment-379517607
 
 
   ` ChildListener zkListener = listeners.get(listener);
   
   if (zkListener == null) {
   
   listeners.putIfAbsent(listener, new ChildListener() {
   
   public void childChanged(String parentPath, 
List currentChilds) {
   
   ZookeeperRegistry.this.notify(url, listener, 
toUrlsWithEmpty(url, parentPath, currentChilds));
   
   }
   
   });
   
   zkListener = listeners.get(listener);
   
   }
   
   zkClient.create(path, false);
   
   List children = zkClient.addChildListener(path, 
zkListener);
   
   if (children != null) {
   
   urls.addAll(toUrlsWithEmpty(url, path, children));
   
   }`
   
   
   `  
   private List toUrlsWithEmpty(URL consumer, String path, List 
providers) {
   
   List urls = toUrlsWithoutEmpty(consumer, providers);
   
   if (urls == null || urls.isEmpty()) {
   
   int i = path.lastIndexOf('/');
   
   String category = i < 0 ? path : path.substring(i + 1);
   
   URL empty = 
consumer.setProtocol(Constants.EMPTY_PROTOCOL).addParameter(Constants.CATEGORY_KEY,
 category);
   
   urls.add(empty);
   
   }
   
   return urls;
   }`
   
   zookeeper ,sorry to did not say clearly at the beginning


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] HouZhiHouJue commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP

[GitBox]

HouZhiHouJue commented on issue #1508: feature required: set registrydirectory 
to AP when implementation is CP
URL: 
https://github.com/apache/incubator-dubbo/issues/1508#issuecomment-379517607
 
 
   ` ChildListener zkListener = listeners.get(listener);
   
   if (zkListener == null) {
   
   listeners.putIfAbsent(listener, new ChildListener() {
   
   public void childChanged(String parentPath, 
List currentChilds) {
   
   ZookeeperRegistry.this.notify(url, listener, 
toUrlsWithEmpty(url, parentPath, currentChilds));
   
   }
   
   });
   
   zkListener = listeners.get(listener);
   
   }
   
   zkClient.create(path, false);
   
   List children = zkClient.addChildListener(path, 
zkListener);
   
   if (children != null) {
   
   urls.addAll(toUrlsWithEmpty(url, path, children));
   
   }`
   
   
   `  private List toUrlsWithEmpty(URL consumer, String path, List 
providers) {
   
   List urls = toUrlsWithoutEmpty(consumer, providers);
   
   if (urls == null || urls.isEmpty()) {
   
   int i = path.lastIndexOf('/');
   
   String category = i < 0 ? path : path.substring(i + 1);
   
   URL empty = 
consumer.setProtocol(Constants.EMPTY_PROTOCOL).addParameter(Constants.CATEGORY_KEY,
 category);
   
   urls.add(empty);
   
   }
   
   return urls;
   }`
   
   zookeeper ,sorry to did not say clearly at the beginning


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] HouZhiHouJue commented on issue #1508: feature required: set registrydirectory to AP when implementation is CP

[GitBox]

HouZhiHouJue commented on issue #1508: feature required: set registrydirectory 
to AP when implementation is CP
URL: 
https://github.com/apache/incubator-dubbo/issues/1508#issuecomment-379517607
 
 
   `
   
 ChildListener zkListener = listeners.get(listener);
   
   if (zkListener == null) {
   
   listeners.putIfAbsent(listener, new ChildListener() {
   
   public void childChanged(String parentPath, 
List currentChilds) {
   
   ZookeeperRegistry.this.notify(url, listener, 
toUrlsWithEmpty(url, parentPath, currentChilds));
   
   }
   
   });
   
   zkListener = listeners.get(listener);
   
   }
   
   zkClient.create(path, false);
   
   List children = zkClient.addChildListener(path, 
zkListener);
   
   if (children != null) {
   
   urls.addAll(toUrlsWithEmpty(url, path, children));
   
   }`
   
   
   `  
  
   
private List toUrlsWithEmpty(URL consumer, String path, 
List providers) {
   
 List urls = toUrlsWithoutEmpty(consumer, providers);
   
   if (urls == null || urls.isEmpty()) {
   
   int i = path.lastIndexOf('/');
   
   String category = i < 0 ? path : path.substring(i + 1);
   
   URL empty = 
consumer.setProtocol(Constants.EMPTY_PROTOCOL).addParameter(Constants.CATEGORY_KEY,
 category);
   
   urls.add(empty);
   
   }
   
   return urls;
   }`
   
   zookeeper ,sorry to did not say clearly at the beginning


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nzomkxia opened a new pull request #11: update dubbo book address

[GitBox]

nzomkxia opened a new pull request #11: update dubbo book address
URL: https://github.com/apache/incubator-dubbo-docs/pull/11
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mercyblitz commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

[GitBox]

mercyblitz commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo 
annotation bug]
URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179935101
 
 

 ##
 File path: 
dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/context/annotation/DubboClassPathBeanDefinitionScanner.java
 ##
 @@ -53,7 +53,7 @@ public 
DubboClassPathBeanDefinitionScanner(BeanDefinitionRegistry registry, bool
 public DubboClassPathBeanDefinitionScanner(BeanDefinitionRegistry 
registry, Environment environment,
ResourceLoader resourceLoader) {
 
-this(registry, false, environment, resourceLoader);
+this(registry, true, environment, resourceLoader);
 
 Review comment:
   @zonghaishang DO NOT implement , it will scan all `@Component` beans


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

[GitBox]

zonghaishang commented on a change in pull request #1550: [Dubbo-Fix 
EnableDubbo annotation bug]
URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179935223
 
 

 ##
 File path: 
dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/context/annotation/DubboClassPathBeanDefinitionScanner.java
 ##
 @@ -53,7 +53,7 @@ public 
DubboClassPathBeanDefinitionScanner(BeanDefinitionRegistry registry, bool
 public DubboClassPathBeanDefinitionScanner(BeanDefinitionRegistry 
registry, Environment environment,
ResourceLoader resourceLoader) {
 
-this(registry, false, environment, resourceLoader);
+this(registry, true, environment, resourceLoader);
 
 Review comment:
   
com.alibaba.dubbo.config.spring.beans.factory.annotation.ServiceAnnotationBeanPostProcessor#registerServiceBeans:
   
   ``` java
scanner.addExcludeFilter(new AnnotationTypeFilter(Component.class, false));
   scanner.addExcludeFilter(new AnnotationTypeFilter(Controller.class, false));
   scanner.addExcludeFilter(new AnnotationTypeFilter(Repository.class, false));
   ```
   
   I have filtered that, @EnableDubbo should support client scanning.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

[GitBox]

zonghaishang commented on a change in pull request #1550: [Dubbo-Fix 
EnableDubbo annotation bug]
URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179935223
 
 

 ##
 File path: 
dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/context/annotation/DubboClassPathBeanDefinitionScanner.java
 ##
 @@ -53,7 +53,7 @@ public 
DubboClassPathBeanDefinitionScanner(BeanDefinitionRegistry registry, bool
 public DubboClassPathBeanDefinitionScanner(BeanDefinitionRegistry 
registry, Environment environment,
ResourceLoader resourceLoader) {
 
-this(registry, false, environment, resourceLoader);
+this(registry, true, environment, resourceLoader);
 
 Review comment:
   
com.alibaba.dubbo.config.spring.beans.factory.annotation.ServiceAnnotationBeanPostProcessor#registerServiceBeans:
   
   ```
   scanner.addExcludeFilter(new AnnotationTypeFilter(Component.class, 
false));
   scanner.addExcludeFilter(new AnnotationTypeFilter(Controller.class, 
false));
   scanner.addExcludeFilter(new AnnotationTypeFilter(Repository.class, 
false));
   ```
   
   I have filtered that, @EnableDubbo should support client scanning.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

[GitBox]

zonghaishang commented on a change in pull request #1550: [Dubbo-Fix 
EnableDubbo annotation bug]
URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179935223
 
 

 ##
 File path: 
dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/context/annotation/DubboClassPathBeanDefinitionScanner.java
 ##
 @@ -53,7 +53,7 @@ public 
DubboClassPathBeanDefinitionScanner(BeanDefinitionRegistry registry, bool
 public DubboClassPathBeanDefinitionScanner(BeanDefinitionRegistry 
registry, Environment environment,
ResourceLoader resourceLoader) {
 
-this(registry, false, environment, resourceLoader);
+this(registry, true, environment, resourceLoader);
 
 Review comment:
   
com.alibaba.dubbo.config.spring.beans.factory.annotation.ServiceAnnotationBeanPostProcessor#registerServiceBeans:
   
   ``` java
   scanner.addExcludeFilter(new AnnotationTypeFilter(Component.class, false));
   scanner.addExcludeFilter(new AnnotationTypeFilter(Controller.class, false));
   scanner.addExcludeFilter(new AnnotationTypeFilter(Repository.class, false));
   ```
   
   I have filtered that, @EnableDubbo should support client scanning.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mercyblitz commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

[GitBox]

mercyblitz commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo 
annotation bug]
URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179935398
 
 

 ##
 File path: 
dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/ServiceAnnotationBeanPostProcessor.java
 ##
 @@ -98,13 +110,88 @@ public void 
postProcessBeanDefinitionRegistry(BeanDefinitionRegistry registry) t
 Set resolvedPackagesToScan = 
resolvePackagesToScan(packagesToScan);
 
 if (!CollectionUtils.isEmpty(resolvedPackagesToScan)) {
+
+// register @Service
 registerServiceBeans(resolvedPackagesToScan, registry);
+
+// register @Component
+registerComponentBeans(resolvedPackagesToScan, registry);
 } else {
 if (logger.isWarnEnabled()) {
 logger.warn("packagesToScan is empty , ServiceBean registry 
will be ignored!");
 }
 }
 
+/**
+ * The solution to consumers early references to unexposed services.
+ */
+deferConfiguationBeans();
+
+}
+
+/**
+ * Registers Beans whose classes was annotated {@link Component}
+ *
+ * @param packagesToScan The base packages to scan
+ * @param registry   {@link BeanDefinitionRegistry}
+ */
+private void registerComponentBeans(Set packagesToScan, 
BeanDefinitionRegistry registry) {
+
+DubboClassPathBeanDefinitionScanner scanner =
+new DubboClassPathBeanDefinitionScanner(registry, environment, 
resourceLoader);
+
+BeanNameGenerator beanNameGenerator = 
resolveBeanNameGenerator(registry);
+
+scanner.setBeanNameGenerator(beanNameGenerator);
+
+scanner.addExcludeFilter(new AnnotationTypeFilter(Controller.class, 
false));
 
 Review comment:
   It should not enumerate those Annotations,  for instance `@Configuration` 
will be scanned here


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mercyblitz commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

[GitBox]

mercyblitz commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo 
annotation bug]
URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179935444
 
 

 ##
 File path: 
dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/ReferenceAnnotationBeanPostProcessor.java
 ##
 @@ -60,7 +65,7 @@
  */
 public class ReferenceAnnotationBeanPostProcessor extends 
InstantiationAwareBeanPostProcessorAdapter
 implements MergedBeanDefinitionPostProcessor, PriorityOrdered, 
ApplicationContextAware, BeanClassLoaderAware,
-DisposableBean {
+DisposableBean, ApplicationListener {
 
 Review comment:
   If based on `ApplicationListener` , the `@Reference` 
fields will be null on `@PostConsturct` or other life-cycle methos 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ralf0131 commented on issue #606: 提供更优雅的异步方式实现

[GitBox]

ralf0131 commented on issue #606: 提供更优雅的异步方式实现 
URL: https://github.com/apache/incubator-dubbo/pull/606#issuecomment-379521045
 
 
   This pull request has conflict, please resolve it before we can merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ralf0131 commented on issue #639: fix:Activate上的before,after排序是有问题的，不起作用

[GitBox]

ralf0131 commented on issue #639: fix:Activate上的before,after排序是有问题的，不起作用
URL: https://github.com/apache/incubator-dubbo/pull/639#issuecomment-379521121
 
 
   Please resolve the conflict before we can merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xiaomaijiang commented on issue #1532: Upgrade Dubbo from 2.6.0 to 2.6.1 Faild

[GitBox]

xiaomaijiang commented on issue #1532: Upgrade Dubbo from 2.6.0 to 2.6.1 Faild
URL: 
https://github.com/apache/incubator-dubbo/issues/1532#issuecomment-379521572
 
 
   i remove all zk data ,but still has this error 
   ```
   Caused by: com.alibaba.dubbo.rpc.RpcException: Failed to register 
dubbo://192.168.202.1:20880/com.smart.sso.rpc.AuthenticationRpcService?anyhost=true&application=smart-sso-server&default.accepts=1000&default.threadpool=fixed&default.threads=100&default.timeout=1&dubbo=2.6.1&generic=false&interface=com.smart.sso.rpc.AuthenticationRpcService&methods=findAuthInfo,findPermissionList,validate&pid=51933&retries=0&revision=2.0.6&side=provider×tamp=1523165131451
 to zookeeper 
zookeeper://192.168.202.128:2181/com.alibaba.dubbo.registry.RegistryService?application=smart-sso-server&dubbo=2.6.1&interface=com.alibaba.dubbo.registry.RegistryService&pid=51933×tamp=1523165131446,
 cause: KeeperErrorCode = Unimplemented for /dubbo
at 
com.alibaba.dubbo.registry.zookeeper.ZookeeperRegistry.doRegister(ZookeeperRegistry.java:112)
at 
com.alibaba.dubbo.registry.support.FailbackRegistry.register(FailbackRegistry.java:130)
... 74 more
   Caused by: java.lang.IllegalStateException: KeeperErrorCode = Unimplemented 
for /dubbo
at 
com.alibaba.dubbo.remoting.zookeeper.curator.CuratorZookeeperClient.createPersistent(CuratorZookeeperClient.java:77)
at 
com.alibaba.dubbo.remoting.zookeeper.support.AbstractZookeeperClient.create(AbstractZookeeperClient.java:63)
at 
com.alibaba.dubbo.remoting.zookeeper.support.AbstractZookeeperClient.create(AbstractZookeeperClient.java:57)
at 
com.alibaba.dubbo.remoting.zookeeper.support.AbstractZookeeperClient.create(AbstractZookeeperClient.java:57)
at 
com.alibaba.dubbo.remoting.zookeeper.support.AbstractZookeeperClient.create(AbstractZookeeperClient.java:57)
at 
com.alibaba.dubbo.registry.zookeeper.ZookeeperRegistry.doRegister(ZookeeperRegistry.java:110)
... 75 more
   Caused by: org.apache.zookeeper.KeeperException$UnimplementedException: 
KeeperErrorCode = Unimplemented for /dubbo
at org.apache.zookeeper.KeeperException.create(KeeperException.java:103)
at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
at org.apache.zookeeper.ZooKeeper.create(ZooKeeper.java:1525)
at 
org.apache.curator.framework.imps.CreateBuilderImpl$17.call(CreateBuilderImpl.java:1181)
at 
org.apache.curator.framework.imps.CreateBuilderImpl$17.call(CreateBuilderImpl.java:1158)
at 
org.apache.curator.connection.StandardConnectionHandlingPolicy.callWithRetry(StandardConnectionHandlingPolicy.java:64)
at org.apache.curator.RetryLoop.callWithRetry(RetryLoop.java:100)
at 
org.apache.curator.framework.imps.CreateBuilderImpl.pathInForeground(CreateBuilderImpl.java:1155)
at 
org.apache.curator.framework.imps.CreateBuilderImpl.protectedPathInForeground(CreateBuilderImpl.java:605)
at 
org.apache.curator.framework.imps.CreateBuilderImpl.forPath(CreateBuilderImpl.java:595)
at 
org.apache.curator.framework.imps.CreateBuilderImpl.forPath(CreateBuilderImpl.java:573)
at 
org.apache.curator.framework.imps.CreateBuilderImpl.forPath(CreateBuilderImpl.java:49)
at 
com.alibaba.dubbo.remoting.zookeeper.curator.CuratorZookeeperClient.createPersistent(CuratorZookeeperClient.java:74)
... 80 more
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xiaomaijiang closed issue #1532: Upgrade Dubbo from 2.6.0 to 2.6.1 Faild

[GitBox]

xiaomaijiang closed issue #1532: Upgrade Dubbo from 2.6.0 to 2.6.1 Faild
URL: https://github.com/apache/incubator-dubbo/issues/1532
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xiaomaijiang commented on issue #1532: Upgrade Dubbo from 2.6.0 to 2.6.1 Faild

[GitBox]

xiaomaijiang commented on issue #1532: Upgrade Dubbo from 2.6.0 to 2.6.1 Faild
URL: 
https://github.com/apache/incubator-dubbo/issues/1532#issuecomment-379521769
 
 
   i change curator version...It work =。=
   ```
   
   org.apache.curator
   curator-framework
   2.12.0
   
   
   org.apache.curator
   curator-client
   2.12.0
   
   ```
   i think it shoud be write to the document


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kimmking commented on issue #1565: Dubbo best practice case application, fully automatic open source framework Emsite.

[GitBox]

kimmking commented on issue #1565: Dubbo best practice case application, fully 
automatic open source framework Emsite.
URL: 
https://github.com/apache/incubator-dubbo/issues/1565#issuecomment-379522424
 
 
   Thanks for a wonderful integration framework.
   But I guess the "best practices" were some principals from many production 
biz systems, those contained experience of using dubbo to design, development, 
testing, deployment and maintainance.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kimmking commented on issue #1565: Dubbo best practice case application, fully automatic open source framework Emsite.

[GitBox]

kimmking commented on issue #1565: Dubbo best practice case application, fully 
automatic open source framework Emsite.
URL: 
https://github.com/apache/incubator-dubbo/issues/1565#issuecomment-379522424
 
 
   Thanks for a wonderful integration framework.
   But I guess the "best practices" were some principals from many production 
biz system, those contained experience of using dubbo to design, development, 
testing, deployment and maintainance.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kimmking commented on issue #1565: Dubbo best practice case application, fully automatic open source framework Emsite.

[GitBox]

kimmking commented on issue #1565: Dubbo best practice case application, fully 
automatic open source framework Emsite.
URL: 
https://github.com/apache/incubator-dubbo/issues/1565#issuecomment-379522424
 
 
   Thanks for a wonderful integration framework.
   But I guess the "best practices" were some principals from many production 
biz systems, those contained experience of using dubbo to design, development, 
testing, deployment and maintenance.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] kimmking commented on issue #1565: Dubbo best practice case application, fully automatic open source framework Emsite.

[GitBox]

kimmking commented on issue #1565: Dubbo best practice case application, fully 
automatic open source framework Emsite.
URL: 
https://github.com/apache/incubator-dubbo/issues/1565#issuecomment-379522424
 
 
   Thanks for a wonderful integration framework.
   But I guess the "best practices" were some principals from many production 
biz systems, those contained experience of using dubbo to design, develop, 
test, deploy and maintain.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ralf0131 commented on issue #639: fix:Activate上的before,after排序是有问题的，不起作用

[GitBox]

ralf0131 commented on issue #639: fix:Activate上的before,after排序是有问题的，不起作用
URL: https://github.com/apache/incubator-dubbo/pull/639#issuecomment-379522657
 
 
   Hi, 
   
   Please update the title and description using English. Dubbo is a global 
community and we would like the PR to be reviewed by people all over the world.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ralf0131 commented on issue #606: 提供更优雅的异步方式实现

[GitBox]

ralf0131 commented on issue #606: 提供更优雅的异步方式实现 
URL: https://github.com/apache/incubator-dubbo/pull/606#issuecomment-379522767
 
 
   Hi,
   
   Please update the title and description using English. Dubbo is a global 
community and we would like the PR to be reviewed by people all over the world.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] HaoZhang6 commented on issue #1012: Wanted: who's using dubbo

[GitBox]

HaoZhang6 commented on issue #1012: Wanted: who's using dubbo
URL: 
https://github.com/apache/incubator-dubbo/issues/1012#issuecomment-379522858
 
 
   公司：上海烈熊网络技术有限公司
   地址：中国上海
   联系方式： t...@billbear.cn
   场景：统一RPC框架、服务治理框架


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

[GitBox]

zonghaishang commented on a change in pull request #1550: [Dubbo-Fix 
EnableDubbo annotation bug]
URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179936669
 
 

 ##
 File path: 
dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/ServiceAnnotationBeanPostProcessor.java
 ##
 @@ -98,13 +110,88 @@ public void 
postProcessBeanDefinitionRegistry(BeanDefinitionRegistry registry) t
 Set resolvedPackagesToScan = 
resolvePackagesToScan(packagesToScan);
 
 if (!CollectionUtils.isEmpty(resolvedPackagesToScan)) {
+
+// register @Service
 registerServiceBeans(resolvedPackagesToScan, registry);
+
+// register @Component
+registerComponentBeans(resolvedPackagesToScan, registry);
 } else {
 if (logger.isWarnEnabled()) {
 logger.warn("packagesToScan is empty , ServiceBean registry 
will be ignored!");
 }
 }
 
+/**
+ * The solution to consumers early references to unexposed services.
+ */
+deferConfiguationBeans();
+
+}
+
+/**
+ * Registers Beans whose classes was annotated {@link Component}
+ *
+ * @param packagesToScan The base packages to scan
+ * @param registry   {@link BeanDefinitionRegistry}
+ */
+private void registerComponentBeans(Set packagesToScan, 
BeanDefinitionRegistry registry) {
+
+DubboClassPathBeanDefinitionScanner scanner =
+new DubboClassPathBeanDefinitionScanner(registry, environment, 
resourceLoader);
+
+BeanNameGenerator beanNameGenerator = 
resolveBeanNameGenerator(registry);
+
+scanner.setBeanNameGenerator(beanNameGenerator);
+
+scanner.addExcludeFilter(new AnnotationTypeFilter(Controller.class, 
false));
 
 Review comment:
   Process discovery and @Component under the same service package.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

[GitBox]

zonghaishang commented on a change in pull request #1550: [Dubbo-Fix 
EnableDubbo annotation bug]
URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179936710
 
 

 ##
 File path: 
dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/ReferenceAnnotationBeanPostProcessor.java
 ##
 @@ -60,7 +65,7 @@
  */
 public class ReferenceAnnotationBeanPostProcessor extends 
InstantiationAwareBeanPostProcessorAdapter
 implements MergedBeanDefinitionPostProcessor, PriorityOrdered, 
ApplicationContextAware, BeanClassLoaderAware,
-DisposableBean {
+DisposableBean, ApplicationListener {
 
 Review comment:
   I think the default service delay reference can be solved， the default 
implementation references the service ahead of time, resulting in an NPE


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ralf0131 commented on issue #1555: SerivceAnnotationBeanPostProcessor bug and replace ServiceConfig vars by Constants.

[GitBox]

ralf0131 commented on issue #1555: SerivceAnnotationBeanPostProcessor bug and 
replace ServiceConfig vars by Constants.
URL: https://github.com/apache/incubator-dubbo/pull/1555#issuecomment-379524089
 
 
   I think this pull request contains two separated enhancement.
   
   1. SerivceAnnotationBeanPostProcessor bug 
   2. replace ServiceConfig vars by Constants
   
   If they are not related, please separate them into two pull request.
   For the SerivceAnnotationBeanPostProcessor bug fix, please make sure there 
is an issue describing what the bug is and if you can provide a test case to 
reproduce it, that will be better.  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] nzomkxia commented on issue #1507: Mirror improvement for test cases in dubbo-rpc-api module

[GitBox]

nzomkxia commented on issue #1507: Mirror improvement for test cases in 
dubbo-rpc-api module
URL: https://github.com/apache/incubator-dubbo/pull/1507#issuecomment-379524103
 
 
   all tests are passed


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] diecui1202 commented on issue #1500: not support java 10

[GitBox]

diecui1202 commented on issue #1500: not support java 10
URL: 
https://github.com/apache/incubator-dubbo/issues/1500#issuecomment-379524152
 
 
   I run the two test cases under Java 10, they're all ok. 
   
   And I also build dubbo under Java 10, there is a NullPointerException which 
is thrown by maven-javadoc-plugin. More details can be obtained from 
https://stackoverflow.com/questions/49460751/execution-attach-javadocs-of-goal-org-apache-maven-pluginsmaven-javadoc-plugin
   
   After upgrade maven-javadoc-plugin to 3.0.1-SNAPSHOT, the build process and 
all test cases pass. 
   
   @hank-whu So I can't repeat your problem. You can review it again and tell 
us if getting the same problem.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #1380: upgrade libthrift version and add nature thrift support option

[GitBox]

codecov-io commented on issue #1380: upgrade libthrift version and add nature 
thrift support option 
URL: https://github.com/apache/incubator-dubbo/pull/1380#issuecomment-367338110
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=h1) 
Report
   > Merging 
[#1380](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=desc) 
into 
[master](https://codecov.io/gh/apache/incubator-dubbo/commit/f4bd1b5f2cd54a7fd4944944f94d38bc5a2b1730?src=pr&el=desc)
 will **decrease** coverage by `2.61%`.
   > The diff coverage is `4.54%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#1380  +/-   ##
   ==
   - Coverage   32.16%   29.54%   -2.62% 
   ==
 Files 682  685   +3 
 Lines   3297235910+2938 
 Branches 6597 6990 +393 
   ==
   + Hits1060410610   +6 
   - Misses  2047323406+2933 
   + Partials 1895 1894   -1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[...java/com/alibaba/dubbo/demo/ThriftDemoService.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tZGVtby9kdWJiby1kZW1vLWFwaS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL2RlbW8vVGhyaWZ0RGVtb1NlcnZpY2UuamF2YQ==)
 | `0% <ø> (ø)` | |
   | 
[...om/alibaba/dubbo/demo/provider/ThriftProvider.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tZGVtby9kdWJiby1kZW1vLXByb3ZpZGVyL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZGVtby9wcm92aWRlci9UaHJpZnRQcm92aWRlci5qYXZh)
 | `0% <0%> (ø)` | |
   | 
[...onfig/spring/schema/DubboBeanDefinitionParser.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL3NjaGVtYS9EdWJib0JlYW5EZWZpbml0aW9uUGFyc2VyLmphdmE=)
 | `20.81% <0%> (-0.26%)` | :arrow_down: |
   | 
[...om/alibaba/dubbo/demo/provider/ThriftDemoImpl.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tZGVtby9kdWJiby1kZW1vLXByb3ZpZGVyL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vZGVtby9wcm92aWRlci9UaHJpZnREZW1vSW1wbC5qYXZh)
 | `0% <0%> (ø)` | |
   | 
[...alibaba/dubbo/rpc/protocol/thrift/ThriftCodec.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10aHJpZnQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvcHJvdG9jb2wvdGhyaWZ0L1RocmlmdENvZGVjLmphdmE=)
 | `3.23% <2.22%> (-0.11%)` | :arrow_down: |
   | 
[...n/java/com/alibaba/dubbo/config/ServiceConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvU2VydmljZUNvbmZpZy5qYXZh)
 | `39.53% <50%> (+0.09%)` | :arrow_up: |
   | 
[...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=)
 | `57.5% <0%> (-8.75%)` | :arrow_down: |
   | 
[.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh)
 | `73.14% <0%> (-2.78%)` | :arrow_down: |
   | ... and [5 
more](https://codecov.io/gh/apache/incubator-dubbo/pull/1380/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=footer).
 Last update 
[f4bd1b5...3e38f9c](https://codecov.io/gh/apache/incubator-dubbo/pull/1380?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.ap

Re: List volume and issue tracking

[Greg Stein]

Many projects choose this pattern:

dev@ -- the development community's discussions
commits@ -- commit emails
issues@ -- all emails related to issues (GitHub/Jira)
notifications@ -- PR notifications, etc

All GitHub activity is required to be delivered to an ASF mailing list. It
is up to the (P)PMC to choose which/how. But they cannot be sent to
/dev/null. The above pattern generally provides the right breakdown for
what information people what to monitor.

Cheers,
Greg Stein
Infrastructure Administrator, ASF


On Sat, Apr 7, 2018 at 10:22 PM, Ian Luo  wrote:

> I think this can be solved by distinguishing github notifications from
> regular dev@dubbo.apache.org traffic.  For github notifications,
> including issue and pull request, the update message should only go to the
> interested parties who are involved in this particular topic, but @dev
> should never be the audience.
>
> I guess @dev mail list is configured in 'Settings -> Integrations &
> Services -> Email' for github.com/apache/inclubator-dubbo* projects. I am
> not sure who I should contact therefore I am here cc-ing
> us...@infra.apache.org.
>
> I suggest to remove @dev mail list from github subscription list.
>
> Thanks,
> -Ian.
>
>
>
> On Tue, Apr 3, 2018 at 5:55 PM, Huxing Zhang  wrote:
>
>> Hi,
>>
>> I am +1 on split the traffic of @dev list.
>>
>> The issue appears after migrating repo to ASF. I use
>> "label:asf-dubbo-dev -[github]" to filter out them. :(
>>
>> On Tue, Apr 3, 2018 at 5:06 PM, Yong Zhu  wrote:
>> > I have the same feeling.
>> >
>> > IMO, all the issue emails should be sent to iss...@dubbo.apache.org,
>> all
>>
>> +1. All issues and the comments should go there.
>>
>> > the PR emails should be sent to comm...@dubbo.apache.org. How do you
>> think?
>>
>> -1. commit@ are used when code are committed to repo, I don't think
>> PRs should go there.
>> Once a PR is accepted, a message will be sent to commit@
>>
>> My suggestion is PRs and the comments should go to issues@, or we can
>> create a new list prs@.
>>
>> > and who can help to fix this?
>> >
>> > And I think we should use github issues, and move all the Jira issues to
>> > github.
>> >
>> > 2018-04-03 16:43 GMT+08:00 Mark Thomas :
>> >
>> >> All,
>> >>
>> >> I've been away for just over a week and come back to find over 300
>> >> unread emails on the dev list.
>> >>
>> >> A large proportion of these messages are comments on pull requests? Is
>> >> dev@ the right list for those?
>> >>
>> >> Another large proportion appear to be comments on issues? Is dev@ the
>> >> right list for those?
>> >>
>> >> Generally, the recommendation is to split into multiple lists based on
>> >> audience rather than topic. For some projects it therefore makes sense
>> >> to have all dev related traffic going to a single list. For others,
>> >> particularly large projects, it makes sense to split the dev traffic.
>> >>
>> >> The project appears to be using GitHub issues and Jira. That is
>> >> confusing. I'd recommend that you select one issue tracker and stick
>> to it.
>>
>> There was discussion[1] on the mailing list and the community has
>> decided to use github issues.
>> My understanding is that currently JIRA is only used for GSOC ideas
>> and track existing issues prior to that decision.
>> I am +0 on migrating the existing JIRA issues to github issues.
>>
>> >>
>> >> Finally, the github issues seem to be a mix of bugs and support
>> >> questions. Is that the way the podling wants to use github issues?
>>
>> People get used to ask questions by creating an issue before joining ASF.
>> The PPMC are trying to tell users to use mailing list to ask questions
>> by leaving message on the issues, so does the website.
>> But I think it will take some time.
>>
>> >>
>> >> I have no view on what the 'right' answers to the above questions are.
>> >> I'm asking them to get the podling thinking about the issues. What, if
>> >> anything, to do about any of the above is for the podling to decide.
>> >>
>> >>
>> >> Mark
>> >>
>>
>>
>> [1] https://lists.apache.org/thread.html/c8ca0bf3bff8f0ee236567b
>> ba2a3876c4d8b91a28a94948be4cb74b8@%3Cdev.dubbo.apache.org%3E
>> --
>> Best Regards！
>> Huxing
>>
>
>

[GitHub] zonghaishang commented on a change in pull request #1550: [Dubbo-Fix EnableDubbo annotation bug]

[GitBox]

zonghaishang commented on a change in pull request #1550: [Dubbo-Fix 
EnableDubbo annotation bug]
URL: https://github.com/apache/incubator-dubbo/pull/1550#discussion_r179936906
 
 

 ##
 File path: 
dubbo-config/dubbo-config-spring/src/main/java/com/alibaba/dubbo/config/spring/beans/factory/annotation/ReferenceAnnotationBeanPostProcessor.java
 ##
 @@ -60,7 +65,7 @@
  */
 public class ReferenceAnnotationBeanPostProcessor extends 
InstantiationAwareBeanPostProcessorAdapter
 implements MergedBeanDefinitionPostProcessor, PriorityOrdered, 
ApplicationContextAware, BeanClassLoaderAware,
-DisposableBean {
+DisposableBean, ApplicationListener {
 
 Review comment:
   I always think that @EnableDubbo (basepackage="com.xxx") since it supports 
packet scanning, should avoid having the user repeatedly configure the same 
@ComponentScan(basepackage="com.xxx").


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: List volume and issue tracking

[Huxing Zhang]

+1

This breakdown looks good to me.

On Sun, Apr 8, 2018 at 2:25 PM, Greg Stein  wrote:
> Many projects choose this pattern:
>
> dev@ -- the development community's discussions
> commits@ -- commit emails
> issues@ -- all emails related to issues (GitHub/Jira)
> notifications@ -- PR notifications, etc
>
> All GitHub activity is required to be delivered to an ASF mailing list. It
> is up to the (P)PMC to choose which/how. But they cannot be sent to
> /dev/null. The above pattern generally provides the right breakdown for
> what information people what to monitor.
>
> Cheers,
> Greg Stein
> Infrastructure Administrator, ASF
>
>
> On Sat, Apr 7, 2018 at 10:22 PM, Ian Luo  wrote:
>
>> I think this can be solved by distinguishing github notifications from
>> regular dev@dubbo.apache.org traffic.  For github notifications,
>> including issue and pull request, the update message should only go to the
>> interested parties who are involved in this particular topic, but @dev
>> should never be the audience.
>>
>> I guess @dev mail list is configured in 'Settings -> Integrations &
>> Services -> Email' for github.com/apache/inclubator-dubbo* projects. I am
>> not sure who I should contact therefore I am here cc-ing
>> us...@infra.apache.org.
>>
>> I suggest to remove @dev mail list from github subscription list.
>>
>> Thanks,
>> -Ian.
>>
>>
>>
>> On Tue, Apr 3, 2018 at 5:55 PM, Huxing Zhang  wrote:
>>
>>> Hi,
>>>
>>> I am +1 on split the traffic of @dev list.
>>>
>>> The issue appears after migrating repo to ASF. I use
>>> "label:asf-dubbo-dev -[github]" to filter out them. :(
>>>
>>> On Tue, Apr 3, 2018 at 5:06 PM, Yong Zhu  wrote:
>>> > I have the same feeling.
>>> >
>>> > IMO, all the issue emails should be sent to iss...@dubbo.apache.org,
>>> all
>>>
>>> +1. All issues and the comments should go there.
>>>
>>> > the PR emails should be sent to comm...@dubbo.apache.org. How do you
>>> think?
>>>
>>> -1. commit@ are used when code are committed to repo, I don't think
>>> PRs should go there.
>>> Once a PR is accepted, a message will be sent to commit@
>>>
>>> My suggestion is PRs and the comments should go to issues@, or we can
>>> create a new list prs@.
>>>
>>> > and who can help to fix this?
>>> >
>>> > And I think we should use github issues, and move all the Jira issues to
>>> > github.
>>> >
>>> > 2018-04-03 16:43 GMT+08:00 Mark Thomas :
>>> >
>>> >> All,
>>> >>
>>> >> I've been away for just over a week and come back to find over 300
>>> >> unread emails on the dev list.
>>> >>
>>> >> A large proportion of these messages are comments on pull requests? Is
>>> >> dev@ the right list for those?
>>> >>
>>> >> Another large proportion appear to be comments on issues? Is dev@ the
>>> >> right list for those?
>>> >>
>>> >> Generally, the recommendation is to split into multiple lists based on
>>> >> audience rather than topic. For some projects it therefore makes sense
>>> >> to have all dev related traffic going to a single list. For others,
>>> >> particularly large projects, it makes sense to split the dev traffic.
>>> >>
>>> >> The project appears to be using GitHub issues and Jira. That is
>>> >> confusing. I'd recommend that you select one issue tracker and stick
>>> to it.
>>>
>>> There was discussion[1] on the mailing list and the community has
>>> decided to use github issues.
>>> My understanding is that currently JIRA is only used for GSOC ideas
>>> and track existing issues prior to that decision.
>>> I am +0 on migrating the existing JIRA issues to github issues.
>>>
>>> >>
>>> >> Finally, the github issues seem to be a mix of bugs and support
>>> >> questions. Is that the way the podling wants to use github issues?
>>>
>>> People get used to ask questions by creating an issue before joining ASF.
>>> The PPMC are trying to tell users to use mailing list to ask questions
>>> by leaving message on the issues, so does the website.
>>> But I think it will take some time.
>>>
>>> >>
>>> >> I have no view on what the 'right' answers to the above questions are.
>>> >> I'm asking them to get the podling thinking about the issues. What, if
>>> >> anything, to do about any of the above is for the podling to decide.
>>> >>
>>> >>
>>> >> Mark
>>> >>
>>>
>>>
>>> [1] https://lists.apache.org/thread.html/c8ca0bf3bff8f0ee236567b
>>> ba2a3876c4d8b91a28a94948be4cb74b8@%3Cdev.dubbo.apache.org%3E
>>> --
>>> Best Regards！
>>> Huxing
>>>
>>
>>



-- 
Best Regards！
Huxing

Re: List volume and issue tracking

[shang zonghai]

I was also confused by a lot of mixed emails.

For this topic, I have the following suggestions:

1. All pull requests are sent to the current 
dev@dubbo.apache.org.

Pr contains final solution to problem solution or feature enhancement 
capabilities, all users and developers are more concerned.

2. All issues are only sent to 
is...@dubbo.apache.org.

Issue contains classmates or bug feedback for help, Developers are more 
concerned and give guidance and help.

3. Important content or discussion sent to 
dev@dubbo.apache.org.

For example, issues that need to be discussed when initiating a vote or related 
incubator project, but does not include issues on github.


Thanks,
yiji

Re: List volume and issue tracking

[Yong Zhu]

2018-04-08 14:36 GMT+08:00 Huxing Zhang :

> +1
>
> This breakdown looks good to me.
>

+1, It sounds good.


>
> On Sun, Apr 8, 2018 at 2:25 PM, Greg Stein  wrote:
> > Many projects choose this pattern:
> >
> > dev@ -- the development community's discussions
> > commits@ -- commit emails
> > issues@ -- all emails related to issues (GitHub/Jira)
> > notifications@ -- PR notifications, etc
> >
> > All GitHub activity is required to be delivered to an ASF mailing list.
> It
> > is up to the (P)PMC to choose which/how. But they cannot be sent to
> > /dev/null. The above pattern generally provides the right breakdown for
> > what information people what to monitor.
> >
> > Cheers,
> > Greg Stein
> > Infrastructure Administrator, ASF
> >
> >
> > On Sat, Apr 7, 2018 at 10:22 PM, Ian Luo  wrote:
> >
> >> I think this can be solved by distinguishing github notifications from
> >> regular dev@dubbo.apache.org traffic.  For github notifications,
> >> including issue and pull request, the update message should only go to
> the
> >> interested parties who are involved in this particular topic, but @dev
> >> should never be the audience.
> >>
> >> I guess @dev mail list is configured in 'Settings -> Integrations &
> >> Services -> Email' for github.com/apache/inclubator-dubbo* projects. I
> am
> >> not sure who I should contact therefore I am here cc-ing
> >> us...@infra.apache.org.
> >>
> >> I suggest to remove @dev mail list from github subscription list.
> >>
> >> Thanks,
> >> -Ian.
> >>
> >>
> >>
> >> On Tue, Apr 3, 2018 at 5:55 PM, Huxing Zhang  wrote:
> >>
> >>> Hi,
> >>>
> >>> I am +1 on split the traffic of @dev list.
> >>>
> >>> The issue appears after migrating repo to ASF. I use
> >>> "label:asf-dubbo-dev -[github]" to filter out them. :(
> >>>
> >>> On Tue, Apr 3, 2018 at 5:06 PM, Yong Zhu  wrote:
> >>> > I have the same feeling.
> >>> >
> >>> > IMO, all the issue emails should be sent to iss...@dubbo.apache.org,
> >>> all
> >>>
> >>> +1. All issues and the comments should go there.
> >>>
> >>> > the PR emails should be sent to comm...@dubbo.apache.org. How do you
> >>> think?
> >>>
> >>> -1. commit@ are used when code are committed to repo, I don't think
> >>> PRs should go there.
> >>> Once a PR is accepted, a message will be sent to commit@
> >>>
> >>> My suggestion is PRs and the comments should go to issues@, or we can
> >>> create a new list prs@.
> >>>
> >>> > and who can help to fix this?
> >>> >
> >>> > And I think we should use github issues, and move all the Jira
> issues to
> >>> > github.
> >>> >
> >>> > 2018-04-03 16:43 GMT+08:00 Mark Thomas :
> >>> >
> >>> >> All,
> >>> >>
> >>> >> I've been away for just over a week and come back to find over 300
> >>> >> unread emails on the dev list.
> >>> >>
> >>> >> A large proportion of these messages are comments on pull requests?
> Is
> >>> >> dev@ the right list for those?
> >>> >>
> >>> >> Another large proportion appear to be comments on issues? Is dev@
> the
> >>> >> right list for those?
> >>> >>
> >>> >> Generally, the recommendation is to split into multiple lists based
> on
> >>> >> audience rather than topic. For some projects it therefore makes
> sense
> >>> >> to have all dev related traffic going to a single list. For others,
> >>> >> particularly large projects, it makes sense to split the dev
> traffic.
> >>> >>
> >>> >> The project appears to be using GitHub issues and Jira. That is
> >>> >> confusing. I'd recommend that you select one issue tracker and stick
> >>> to it.
> >>>
> >>> There was discussion[1] on the mailing list and the community has
> >>> decided to use github issues.
> >>> My understanding is that currently JIRA is only used for GSOC ideas
> >>> and track existing issues prior to that decision.
> >>> I am +0 on migrating the existing JIRA issues to github issues.
> >>>
> >>> >>
> >>> >> Finally, the github issues seem to be a mix of bugs and support
> >>> >> questions. Is that the way the podling wants to use github issues?
> >>>
> >>> People get used to ask questions by creating an issue before joining
> ASF.
> >>> The PPMC are trying to tell users to use mailing list to ask questions
> >>> by leaving message on the issues, so does the website.
> >>> But I think it will take some time.
> >>>
> >>> >>
> >>> >> I have no view on what the 'right' answers to the above questions
> are.
> >>> >> I'm asking them to get the podling thinking about the issues. What,
> if
> >>> >> anything, to do about any of the above is for the podling to decide.
> >>> >>
> >>> >>
> >>> >> Mark
> >>> >>
> >>>
> >>>
> >>> [1] https://lists.apache.org/thread.html/c8ca0bf3bff8f0ee236567b
> >>> ba2a3876c4d8b91a28a94948be4cb74b8@%3Cdev.dubbo.apache.org%3E
> >>> --
> >>> Best Regards！
> >>> Huxing
> >>>
> >>
> >>
>
>
>
> --
> Best Regards！
> Huxing
>

If someaone have a usage question, what should he do?

[shengli cao]

Hi everyone:

 I found some issues in github are usage questions, such as
https://github.com/apache/incubator-dubbo/issues/1522 ,
https://github.com/apache/incubator-dubbo/issues/1523.

 I have some experience when I have some question about spring boot.
If you have some question about spring boot, you should :
 1. Ask the question in stackoverflow with tag 'spring-boot'.  Refer
to：
https://github.com/spring-projects/spring-boot/blob/master/CONTRIBUTING.adoc#using-github-issues
 2. Or you can join the gitter :gitter.im/spring-projects/spring-boot ,
then ask the question there.
 If you donot follow this rule and you ask the question in github
issue, your issue will be added label named "for: stackoverflow" and
closed. Such as :
https://github.com/spring-projects/spring-boot/issues/11907.

 As follow, I think we use GitHub issues to track bugs and
enhancements. The dubbo project can also follow this rule:
 1.  If you have a general usage question please ask on  stackoverflow.
 Our developer should  monitor the 'dubbo' tag.
 2. If he want have the answer quickly, he can join out gitter about
dubbo.
 3. We should close the issue in github about question, add a label
named 'stackoverflow' , and guide them to stackoverflow at that they can
ask the question.




-- 

Best Regard!
cvictory

Re: List volume and issue tracking

[Wang Xin]

+1，It’s good.
dev@ -- the development community's discussions
commits@ -- commit emails
issues@ -- all emails related to issues (GitHub/Jira)
notifications@ -- PR notifications, etc



Xin Wang
lovep...@hotmail.com



在 2018年4月8日，下午2:40，Yong Zhu mailto:diecui1...@gmail.com>> 
写道：

2018-04-08 14:36 GMT+08:00 Huxing Zhang 
mailto:hux...@apache.org>>:

+1

This breakdown looks good to me.


+1, It sounds good.



On Sun, Apr 8, 2018 at 2:25 PM, Greg Stein 
mailto:gst...@gmail.com>> wrote:
Many projects choose this pattern:

dev@ -- the development community's discussions
commits@ -- commit emails
issues@ -- all emails related to issues (GitHub/Jira)
notifications@ -- PR notifications, etc

All GitHub activity is required to be delivered to an ASF mailing list.
It
is up to the (P)PMC to choose which/how. But they cannot be sent to
/dev/null. The above pattern generally provides the right breakdown for
what information people what to monitor.

Cheers,
Greg Stein
Infrastructure Administrator, ASF


On Sat, Apr 7, 2018 at 10:22 PM, Ian Luo 
mailto:ian@gmail.com>> wrote:

I think this can be solved by distinguishing github notifications from
regular dev@dubbo.apache.org traffic.  For github 
notifications,
including issue and pull request, the update message should only go to
the
interested parties who are involved in this particular topic, but @dev
should never be the audience.

I guess @dev mail list is configured in 'Settings -> Integrations &
Services -> Email' for 
github.com/apache/inclubator-dubbo* 
projects. I
am
not sure who I should contact therefore I am here cc-ing
us...@infra.apache.org.

I suggest to remove @dev mail list from github subscription list.

Thanks,
-Ian.



On Tue, Apr 3, 2018 at 5:55 PM, Huxing Zhang 
mailto:hux...@apache.org>> wrote:

Hi,

I am +1 on split the traffic of @dev list.

The issue appears after migrating repo to ASF. I use
"label:asf-dubbo-dev -[github]" to filter out them. :(

On Tue, Apr 3, 2018 at 5:06 PM, Yong Zhu 
mailto:diecui1...@gmail.com>> wrote:
I have the same feeling.

IMO, all the issue emails should be sent to 
iss...@dubbo.apache.org,
all

+1. All issues and the comments should go there.

the PR emails should be sent to 
comm...@dubbo.apache.org. How do you
think?

-1. commit@ are used when code are committed to repo, I don't think
PRs should go there.
Once a PR is accepted, a message will be sent to commit@

My suggestion is PRs and the comments should go to issues@, or we can
create a new list prs@.

and who can help to fix this?

And I think we should use github issues, and move all the Jira
issues to
github.

2018-04-03 16:43 GMT+08:00 Mark Thomas 
mailto:ma...@apache.org>>:

All,

I've been away for just over a week and come back to find over 300
unread emails on the dev list.

A large proportion of these messages are comments on pull requests?
Is
dev@ the right list for those?

Another large proportion appear to be comments on issues? Is dev@
the
right list for those?

Generally, the recommendation is to split into multiple lists based
on
audience rather than topic. For some projects it therefore makes
sense
to have all dev related traffic going to a single list. For others,
particularly large projects, it makes sense to split the dev
traffic.

The project appears to be using GitHub issues and Jira. That is
confusing. I'd recommend that you select one issue tracker and stick
to it.

There was discussion[1] on the mailing list and the community has
decided to use github issues.
My understanding is that currently JIRA is only used for GSOC ideas
and track existing issues prior to that decision.
I am +0 on migrating the existing JIRA issues to github issues.


Finally, the github issues seem to be a mix of bugs and support
questions. Is that the way the podling wants to use github issues?

People get used to ask questions by creating an issue before joining
ASF.
The PPMC are trying to tell users to use mailing list to ask questions
by leaving message on the issues, so does the website.
But I think it will take some time.


I have no view on what the 'right' answers to the above questions
are.
I'm asking them to get the podling thinking about the issues. What,
if
anything, to do about any of the above is for the podling to decide.


Mark



[1] https://lists.apache.org/thread.html/c8ca0bf3bff8f0ee236567b
ba2a3876c4d8b91a28a94948be4cb74b8@%3Cdev.dubbo.apache.org%3E
--
Best Regards！
Huxing






--
Best Regards！
Huxing

[GitHub] zonghaishang commented on issue #1532: Upgrade Dubbo from 2.6.0 to 2.6.1 Faild

[GitBox]

zonghaishang commented on issue #1532: Upgrade Dubbo from 2.6.0 to 2.6.1 Faild
URL: 
https://github.com/apache/incubator-dubbo/issues/1532#issuecomment-379525705
 
 
   @xiaomaijiang 
   Here is default version: 
2.12.0


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Re: List volume and issue tracking

[wanhuhou]

+1
from Alimail 
Windows--发件人：Wang
 Xin日　期：2018年04月08日 
14:50:53收件人：dev@dubbo.apache.org抄　送：Ian 
Luo; us...@infra.apache.org主　题：Re: 
List volume and issue tracking+1，It’s good.
dev@ -- the development community's discussions
commits@ -- commit emails
issues@ -- all emails related to issues (GitHub/Jira)
notifications@ -- PR notifications, etc



Xin Wang
lovep...@hotmail.com



在 2018年4月8日，下午2:40，Yong Zhu mailto:diecui1...@gmail.com>> 
写道：

2018-04-08 14:36 GMT+08:00 Huxing Zhang 
mailto:hux...@apache.org>>:

+1

This breakdown looks good to me.


+1, It sounds good.



On Sun, Apr 8, 2018 at 2:25 PM, Greg Stein 
mailto:gst...@gmail.com>> wrote:
Many projects choose this pattern:

dev@ -- the development community's discussions
commits@ -- commit emails
issues@ -- all emails related to issues (GitHub/Jira)
notifications@ -- PR notifications, etc

All GitHub activity is required to be delivered to an ASF mailing list.
It
is up to the (P)PMC to choose which/how. But they cannot be sent to
/dev/null. The above pattern generally provides the right breakdown for
what information people what to monitor.

Cheers,
Greg Stein
Infrastructure Administrator, ASF


On Sat, Apr 7, 2018 at 10:22 PM, Ian Luo 
mailto:ian@gmail.com>> wrote:

I think this can be solved by distinguishing github notifications from
regular dev@dubbo.apache.org traffic.  For github 
notifications,
including issue and pull request, the update message should only go to
the
interested parties who are involved in this particular topic, but @dev
should never be the audience.

I guess @dev mail list is configured in 'Settings -> Integrations &
Services -> Email' for 
github.com/apache/inclubator-dubbo* 
projects. I
am
not sure who I should contact therefore I am here cc-ing
us...@infra.apache.org.

I suggest to remove @dev mail list from github subscription list.

Thanks,
-Ian.



On Tue, Apr 3, 2018 at 5:55 PM, Huxing Zhang 
mailto:hux...@apache.org>> wrote:

Hi,

I am +1 on split the traffic of @dev list.

The issue appears after migrating repo to ASF. I use
"label:asf-dubbo-dev -[github]" to filter out them. :(

On Tue, Apr 3, 2018 at 5:06 PM, Yong Zhu 
mailto:diecui1...@gmail.com>> wrote:
I have the same feeling.

IMO, all the issue emails should be sent to 
iss...@dubbo.apache.org,
all

+1. All issues and the comments should go there.

the PR emails should be sent to 
comm...@dubbo.apache.org. How do you
think?

-1. commit@ are used when code are committed to repo, I don't think
PRs should go there.
Once a PR is accepted, a message will be sent to commit@

My suggestion is PRs and the comments should go to issues@, or we can
create a new list prs@.

and who can help to fix this?

And I think we should use github issues, and move all the Jira
issues to
github.

2018-04-03 16:43 GMT+08:00 Mark Thomas 
mailto:ma...@apache.org>>:

All,

I've been away for just over a week and come back to find over 300
unread emails on the dev list.

A large proportion of these messages are comments on pull requests?
Is
dev@ the right list for those?

Another large proportion appear to be comments on issues? Is dev@
the
right list for those?

Generally, the recommendation is to split into multiple lists based
on
audience rather than topic. For some projects it therefore makes
sense
to have all dev related traffic going to a single list. For others,
particularly large projects, it makes sense to split the dev
traffic.

The project appears to be using GitHub issues and Jira. That is
confusing. I'd recommend that you select one issue tracker and stick
to it.

There was discussion[1] on the mailing list and the community has
decided to use github issues.
My understanding is that currently JIRA is only used for GSOC ideas
and track existing issues prior to that decision.
I am +0 on migrating the existing JIRA issues to github issues.


Finally, the github issues seem to be a mix of bugs and support
questions. Is that the way the podling wants to use github issues?

People get used to ask questions by creating an issue before joining
ASF.
The PPMC are trying to tell users to use mailing list to ask questions
by leaving message on the issues, so does the website.
But I think it will take some time.


I have no view on what the 'right' answers to the above questions
are.
I'm asking them to get the podling thinking about the issues. What,
if
anything, to do about any of the above is for the podling to decide.


Mark



[1] https://lists.apache.org/thread.html/c8ca0bf3bff8f0ee236567b
ba2a3876c4d8b91a28a94948be4cb74b8@%3Cdev.dubbo.apache.org%3E
--
Best Regards！
Huxing






--
Best Regards！
Huxing

[GitHub] tangdu commented on issue #1545: 怎样禁用qos-server，因为我是spark项目，一台服务器会启动多个，导致端口冲突

[GitBox]

tangdu commented on issue #1545: 怎样禁用qos-server，因为我是spark项目，一台服务器会启动多个，导致端口冲突
URL: 
https://github.com/apache/incubator-dubbo/issues/1545#issuecomment-379525709
 
 
   @8967 dubbo.application.qos.enable=false


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services