Re: Review Request 58986: LENS-1418: LensClient is not thread safe

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58986/#review173999
---




lens-client/src/main/java/org/apache/lens/client/LensClient.java
Line 161 (original), 169 (patched)
<https://reviews.apache.org/r/58986/#comment247094>

Are we clearing the statementMap at any point ?


- Puneet Gupta


On May 4, 2017, 8 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58986/
> ---
> 
> (Updated May 4, 2017, 8 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1418
> https://issues.apache.org/jira/browse/LENS-1418
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Using one lens client to fire two queries in two threads results in 
> discrepencies. LensClient has a {{Map<QueryHandle, LensStatement>}} and also 
> has a cached instance of {{LensStatement}}. When two threads fire queries, 
> both use the same statement object. {{LensStatement}} object in turn caches 
> {{LensQuery}} Object. So whichever thread fired query last is the last one to 
> set lens query inside statement causing 
> {{LensClient.getStatement().getQuery()}} to return that query object for all 
> threads.
> 
> 
> Diffs
> -
> 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java 
> e9367988fa780ed0ca3e2a2698226e43c011777f 
> 
> 
> Diff: https://reviews.apache.org/r/58986/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 58956: LENS-1417: Add filters in cli create schema command

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58956/#review173998
---


Ship it!




Ship It!

- Puneet Gupta


On May 4, 2017, 12:15 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58956/
> ---
> 
> (Updated May 4, 2017, 12:15 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1417
> https://issues.apache.org/jira/browse/LENS-1417
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> create schema command is useful but it calls create/update for all the schema 
> xml files. The following things will be useful:
> 
> * Option to specify entity type filter. e.g. create only cubes
> * Option to specify file name filter. e.g. create only entities having `x` in 
> their names
> * Reporting all Failures collectively at the end.
> 
> The general flow in cli is to run a command, then for subsequent runs of the 
> same command, one generally tends to use the command history and modify 
> existing commands. So although there already exists a way to solve for point 
> 2, but it involves writing another command. Having this filter will be 
> helpful.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java 
> 76cb8b90e206eea076cf32b87d97617a833c3f91 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 
> 60bd9e074848c8579f1ad4edcd8e4873f40c4843 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> cdd101bfa4b6ce77492e1626491e58e570be03af 
> 
> 
> Diff: https://reviews.apache.org/r/58956/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 58956: LENS-1417: Add filters in cli create schema command

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58956/#review173892
---




lens-regression/src/main/java/org/apache/lens/regression/util/Util.java
Lines 108 (patched)
<https://reviews.apache.org/r/58956/#comment246971>

Is this required ?


- Puneet Gupta


On May 4, 2017, 11:32 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58956/
> ---
> 
> (Updated May 4, 2017, 11:32 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1417
> https://issues.apache.org/jira/browse/LENS-1417
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> create schema command is useful but it calls create/update for all the schema 
> xml files. The following things will be useful:
> 
> * Option to specify entity type filter. e.g. create only cubes
> * Option to specify file name filter. e.g. create only entities having `x` in 
> their names
> * Reporting all Failures collectively at the end.
> 
> The general flow in cli is to run a command, then for subsequent runs of the 
> same command, one generally tends to use the command history and modify 
> existing commands. So although there already exists a way to solve for point 
> 2, but it involves writing another command. Having this filter will be 
> helpful.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java 
> 76cb8b90e206eea076cf32b87d97617a833c3f91 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 
> 60bd9e074848c8579f1ad4edcd8e4873f40c4843 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> cdd101bfa4b6ce77492e1626491e58e570be03af 
>   
> lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java
>  2370f3e8e2ce1dc4fa95cbce716355a7cf75a2d8 
>   lens-regression/src/main/java/org/apache/lens/regression/util/Util.java 
> 80ba912f43de4686f27732c54647a715f0514387 
> 
> 
> Diff: https://reviews.apache.org/r/58956/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Issue Comment Deleted] (LENS-1419) UnionCandidates getting pruned when only dim attributes projected

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1419:
---
Comment: was deleted

(was: +1)

> UnionCandidates getting pruned when only dim attributes projected
> -
>
> Key: LENS-1419
> URL: https://issues.apache.org/jira/browse/LENS-1419
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Attachments: LENS-1419.patch
>
>
> In current code there is a bug which prunes all UnionCandidates when only dim 
> attributes selected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1419) UnionCandidates getting pruned when only dim attributes projected

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996544#comment-15996544
 ] 

Puneet Gupta commented on LENS-1419:


+1

> UnionCandidates getting pruned when only dim attributes projected
> -
>
> Key: LENS-1419
> URL: https://issues.apache.org/jira/browse/LENS-1419
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Attachments: LENS-1419.patch
>
>
> In current code there is a bug which prunes all UnionCandidates when only dim 
> attributes selected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1419) UnionCandidates getting pruned when only dim attributes projected

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1419:
---
Status: Patch Available  (was: Open)

> UnionCandidates getting pruned when only dim attributes projected
> -
>
> Key: LENS-1419
> URL: https://issues.apache.org/jira/browse/LENS-1419
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Attachments: LENS-1419.patch
>
>
> In current code there is a bug which prunes all UnionCandidates when only dim 
> attributes selected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1419) UnionCandidates getting pruned when only dim attributes projected

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996543#comment-15996543
 ] 

Puneet Gupta commented on LENS-1419:


+1

> UnionCandidates getting pruned when only dim attributes projected
> -
>
> Key: LENS-1419
> URL: https://issues.apache.org/jira/browse/LENS-1419
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Sushil Mohanty
>Assignee: Sushil Mohanty
> Attachments: LENS-1419.patch
>
>
> In current code there is a bug which prunes all UnionCandidates when only dim 
> attributes selected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58956: LENS-1417: Add filters in cli create schema command

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58956/#review173870
---




lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java
Lines 62 (patched)
<https://reviews.apache.org/r/58956/#comment246960>

Should we make fileNameFilter case in-sensitive


- Puneet Gupta


On May 3, 2017, 10:53 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58956/
> ---
> 
> (Updated May 3, 2017, 10:53 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1417
> https://issues.apache.org/jira/browse/LENS-1417
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> create schema command is useful but it calls create/update for all the schema 
> xml files. The following things will be useful:
> 
> * Option to specify entity type filter. e.g. create only cubes
> * Option to specify file name filter. e.g. create only entities having `x` in 
> their names
> * Reporting all Failures collectively at the end.
> 
> The general flow in cli is to run a command, then for subsequent runs of the 
> same command, one generally tends to use the command history and modify 
> existing commands. So although there already exists a way to solve for point 
> 2, but it involves writing another command. Having this filter will be 
> helpful.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java 
> 76cb8b90e206eea076cf32b87d97617a833c3f91 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 
> 60bd9e074848c8579f1ad4edcd8e4873f40c4843 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> cdd101bfa4b6ce77492e1626491e58e570be03af 
> 
> 
> Diff: https://reviews.apache.org/r/58956/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[jira] [Updated] (LENS-1413) Estimates failing with Task rejection errors

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1413:
---
Fix Version/s: 2.7

> Estimates failing with Task rejection errors
> 
>
> Key: LENS-1413
> URL: https://issues.apache.org/jira/browse/LENS-1413
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Fix For: 2.7
>
> Attachments: LENS-1413.patch
>
>
> # Cancel estimates for other drivers when the estimate pool queue is full. 
> # Return the appropriate error message



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1413) Estimates failing with Task rejection errors

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15982667#comment-15982667
 ] 

Puneet Gupta commented on LENS-1413:


Committed. Thanks [~lavkesh]

> Estimates failing with Task rejection errors
> 
>
> Key: LENS-1413
> URL: https://issues.apache.org/jira/browse/LENS-1413
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Fix For: 2.7
>
> Attachments: LENS-1413.patch
>
>
> # Cancel estimates for other drivers when the estimate pool queue is full. 
> # Return the appropriate error message



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58604: Handle Estimates failing with task rejection errors

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58604/#review172619
---




lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
Lines 1716 (patched)
<https://reviews.apache.org/r/58604/#comment245704>

Not sure if logging the driver name makes sense. Also Should we log this as 
error or warning is debatable ?



lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
Lines 1722 (patched)
<https://reviews.apache.org/r/58604/#comment245702>

can we use for(RewriteEstimateRunnable r : runnables) instead ?



lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
Lines 1727 (patched)
<https://reviews.apache.org/r/58604/#comment245703>

Alsoe we can add a sugestion to "Please try again later".


- Puneet Gupta


On April 21, 2017, 7:25 a.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58604/
> ---
> 
> (Updated April 21, 2017, 7:25 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1413
> https://issues.apache.org/jira/browse/LENS-1413
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 1. Cancel estimates for other drivers when the estimate pool queue is full.
> 2. Return the appropriate error message
> 
> 
> Diffs
> -
> 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java
>  92724c6 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  c6fbeda 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> 7d8c977 
>   lens-server/src/test/resources/lens-site.xml 334a9c4 
> 
> 
> Diff: https://reviews.apache.org/r/58604/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

[jira] [Commented] (LENS-1391) Review comments for MaxCoveringFactResolver and LeastPartitionResolver On branch lens-1381

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972412#comment-15972412
 ] 

Puneet Gupta commented on LENS-1391:


[~lavkesh] please fix the checkstyle errors

> Review comments for MaxCoveringFactResolver and LeastPartitionResolver On 
> branch lens-1381
> --
>
> Key: LENS-1391
> URL: https://issues.apache.org/jira/browse/LENS-1391
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
> Attachments: LENS-1391.patch
>
>
> Reviews comments fixes for MaxCoveringFactResolver and LeastPartitionResolver



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 58496: Review comments on the MaxCoveringFactResolver

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58496/#review172174
---


Ship it!




Ship It!

- Puneet Gupta


On April 18, 2017, 6:41 a.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58496/
> ---
> 
> (Updated April 18, 2017, 6:41 a.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1391
> https://issues.apache.org/jira/browse/LENS-1391
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Comments and cleanup
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  1c0d356 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java
>  a9bd164 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java
>  34180d1 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> d95cf27 
>   
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java
>  064da01 
> 
> 
> Diff: https://reviews.apache.org/r/58496/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Review Request 58102: LENS-1381 : Support Fact to Fact Union

[Puneet Gupta]

> On March 31, 2017, 11:09 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java
> > Line 67 (original), 67 (patched)
> > 
> >
> > Why is this required? Can you add comment in code saying why we are 
> > creating FactPartition without containing?

Earlier this code was in AbridgedTimeRangeWriter. It was moved to FactPartition


- Puneet


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58102/#review170696
---


On April 5, 2017, 5:38 a.m., Sushil Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58102/
> ---
> 
> (Updated April 5, 2017, 5:38 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1381
> https://issues.apache.org/jira/browse/LENS-1381
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> This is a neew feature to support union across multiple facts.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/ToXMLString.java e74adc9 
>   lens-api/src/main/java/org/apache/lens/api/jaxb/LensJAXBContext.java 
> 14fc4aa 
>   lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java 
> PRE-CREATION 
>   lens-api/src/main/resources/cube-0.1.xsd 060eb43 
>   lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java 
> feabf9c 
>   
> lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java
>  b2568ff 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
> 896a7a1 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
>  087c203 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java 7717081 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 
> 1694b80 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java 
> PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java 
> bf6cc5c 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java
>  8681e90 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java 
> 9658100 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java
>  c8b8129 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 
> PRE-CREATION 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
>  PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateDim.java 
> 4dcdbcf 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 
> b42262d 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTable.java 
> e001ca4 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  bd6e27c 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  e9270ea 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 
> PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CheckTableNames.java 
> 8586262 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnLifetimeChecker.java 
> PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnResolver.java 
> 87e094a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> 125b432 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> b612173 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 
> fc96055 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultAliasDecider.java 
> 80ceae4 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java 
> c9993f3 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
>  cb26878 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
> 0ea0b1c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 
> 48af0c9 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java 
> 216ae52 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java 
> PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java 
> 7b865bf 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java
>  a53e994 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/LightestFactResolver.java 
> 97accbb 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java
>  45824fe 
>   

[jira] [Updated] (LENS-1407) "fact show timelines" should not report timeline outside of fact/storage validity period

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1407:
---
Summary: "fact show timelines" should not report timeline outside of 
fact/storage validity period  (was: Fact show timelines should not report 
timeline outside of fact/storage validity period)

> "fact show timelines" should not report timeline outside of fact/storage 
> validity period
> 
>
> Key: LENS-1407
> URL: https://issues.apache.org/jira/browse/LENS-1407
> Project: Apache Lens
>  Issue Type: Bug
>      Components: metadata
>Reporter: Puneet Gupta
>Priority: Minor
>
> Fact show timelines even reports missing partitions outside of fact/storage 
> start and end time. 
> This should not be the case . Partitions that do not fall within the storage 
> start and end time should not be considered.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (LENS-1407) Fact show timelines should not report timeline outside of fact/storage validity period

[Puneet Gupta (JIRA)]

Puneet Gupta created LENS-1407:
--

 Summary: Fact show timelines should not report timeline outside of 
fact/storage validity period
 Key: LENS-1407
 URL: https://issues.apache.org/jira/browse/LENS-1407
 Project: Apache Lens
  Issue Type: Bug
  Components: metadata
Reporter: Puneet Gupta
Priority: Minor


Fact show timelines even reports missing partitions outside of fact/storage 
start and end time. 

This should not be the case . Partitions that do not fall within the storage 
start and end time should not be considered.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57908: Xsd for virtual fact

[Puneet Gupta]

> On March 30, 2017, 5:26 a.m., Amareshwari Sriramadasu wrote:
> > lens-examples/src/main/resources/virtualfact1.xml
> > Lines 25-26 (patched)
> > 
> >
> > Should these be fields on cube or fields on fact? If fields from fact, 
> > then expresssions or join chains defined in cube, may not be getting used. 
> > I feel these should be from cube fields, to give users more control.

Will we validate this filter ? as in the fileds used in the filter are valid or 
not. If we are not validating the filter and just using it it the last phase 
(after candidate is picked and we are about to write the query for it) , user 
should be able to specify any fileds in the filter (cueb,fact,etc). 

Also the filter has no time specific validity. Say filter1 for time range 1  
and filter2 for time range 2. 

We can think about this further.


- Puneet


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57908/#review170530
---


On March 28, 2017, 7:22 a.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57908/
> ---
> 
> (Updated March 28, 2017, 7:22 a.m.)
> 
> 
> Review request for lens and Rajat Khandelwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Xsd for virtual fact
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/cube-0.1.xsd 060eb43 
>   lens-examples/src/main/resources/virtualfact1.xml PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57908/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

[jira] [Commented] (LENS-1397) Support query rewrite for separate table per update period in a storage

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15945001#comment-15945001
 ] 

Puneet Gupta commented on LENS-1397:


Taking patch from reviewboard and attaching

> Support query rewrite for separate table per update period in a storage
> ---
>
> Key: LENS-1397
> URL: https://issues.apache.org/jira/browse/LENS-1397
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>    Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Attachments: LENS-1397.03.patch
>
>
> Consider the case where a Storage S has three update periods and each update 
> period has a different table description "table_desc" as supported in 
> LENS-1386. 
> We should be able to rewrite queries for such storages 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1397) Support query rewrite for separate table per update period in a storage

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1397:
---
Status: Patch Available  (was: In Progress)

> Support query rewrite for separate table per update period in a storage
> ---
>
> Key: LENS-1397
> URL: https://issues.apache.org/jira/browse/LENS-1397
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>    Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Attachments: LENS-1397.03.patch
>
>
> Consider the case where a Storage S has three update periods and each update 
> period has a different table description "table_desc" as supported in 
> LENS-1386. 
> We should be able to rewrite queries for such storages 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 57949: LENS-1397: Support query rewrite for separate table per update period in a storage

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57949/
---

(Updated March 28, 2017, 11:12 a.m.)


Review request for lens.


Changes
---

Fixed Review comments


Bugs: LENS-1397
https://issues.apache.org/jira/browse/LENS-1397


Repository: lens


Description
---

Consider the case where a Storage S has three update periods and each update 
period has a different table description "table_desc" as supported in 
LENS-1386. 

We should be able to rewrite queries for such storages


Diffs (updated)
-

  
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
c8a2498ba25ee6c968fd8ca4169612cc3a2763fe 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java 
5bdbf74c4171badbefe5bc07e9ae557b100b0abb 
  lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 
095a2976db5c1d456b7ab3b4ca95b6cac9172172 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
 0b7d4002bb9390b364e1b4aeb78ae9f0eb523d25 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 6cb18e629011de17d8c12a0bac0fc6e9110c7186 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 
97a73a8059d816eb2f35b313f74c7a04aa60e49c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 
68449f667782c15802ed211b51a91f208471f058 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnLifetimeChecker.java 
24eb8f05d250dfecb41afc4a4eb8f031b90850d8 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
76031ecbadec307a12fe172f7b227b9f292e642f 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 
0e2ca821ba8eb7c3b4eeb029ac88422091781a48 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java 
17e202d5eeeaa75bc985372a05a8589ac9271626 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 
bcea7ed4d39639e66f699500f24b79dc280d3906 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
1daeea53955d121abfe94eaae2979bb1cbc8eca5 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java 
fa3ba8f982b35eb3c79afd76284b698f09558a4e 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 
4cae6f8074641574859b8d2782ac3afa11d6e441 
  lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAST.java 
bdd6376373b50c3e2c1606e69eeac75d186d6af2 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
e6e9f8f0f42471567611fe0e4629d5f9f87a471a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
22e2e09f2ee2c3fd7b970025a8155dda1ff4847d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionCandidate.java 
d97e7b8d499393a1cb5122126bd97637c1bd2b58 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 
2ca11819166c3b6de10d0ff63eed4eb4c501ff5b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/join/AutoJoinContext.java 
b5b0b30426bb9d5761108e4d09ace970e8b1b9d5 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/DateFactory.java 
3bdc047c37f3e4425277db579c80ceb1cb89a6b2 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
2d031f435fbd663f634ec1eeff58e1473e0173c5 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
2bf0554cd016cb581a1dcfa6220980a03d8777ff 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
 523a8768cc917bab95cf8f2bd9ff57a1a6f6e24c 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryMetrics.java 
46ee863e71a3444abbc1365243d6014017e30014 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 
cd7383bca91c072c30a5bc4207369288d7cb0a76 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java
 a6b8f889c26f38c2c94f35e2752b1779b6a1ec4d 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionQueries.java 
c2d5f7c3202d0472ff06c3065f359964c0f1217c 
  lens-cube/src/test/resources/schema/facts/testfact.xml 
a4c2c7810cf64a3d275d1bc532696dab69d1c705 


Diff: https://reviews.apache.org/r/57949/diff/3/

Changes: https://reviews.apache.org/r/57949/diff/2-3/


Testing
---


Thanks,

Puneet Gupta

Re: Review Request 57949: LENS-1397: Support query rewrite for separate table per update period in a storage

[Puneet Gupta]

> On March 27, 2017, 2:03 p.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
> > Line 279 (original), 280 (patched)
> > <https://reviews.apache.org/r/57949/diff/1/?file=1676420#file1676420line280>
> >
> > The existence of cubeql seems intentional. Can you explain why the 
> > change?

org.apache.lens.cube.parse.CandidateUtil#copyASTs is not copying getOrderByAST 
also.  So cubeql queryASt and stoarge candidate queryAST will have different 
OrderByAST object instances now.


> On March 27, 2017, 2:03 p.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java
> > Lines 937 (patched)
> > <https://reviews.apache.org/r/57949/diff/1/?file=1676425#file1676425line993>
> >
> > shouldn't we do max here instead of override?

This is being used in private context. 

I will add the below an explantion in code for reference.  

*CASE 1*
*If has Storage has single storage table* 
Storage start time = max(storage start time , fact start time)
Storage end time = min(storage end time , fact start time)

*CASE 2*
*If the Storage has multiple Storage Tables (one per update period)*
update Period start Time = Max(update start time, fact start time)
update Period end Time = Min(update end time, fact end time)
Stoarge start and end time is derived form the underlying update period start 
and end times.
Storage start time = min(update1 start time ,, updateN start time)
Storage end time = max(update1 end time ,, updateN end time)

*Note in Case 2 its assumed that the time range supported by different update 
periods are either overalpping(Example1) or form a continous chain(Eaxmple2) as 
illustrated in examples below

Example 1
A Storage has 2 Non Oevralpping but continuous Update Periods. 
MONTHLY with start time as now.month -13 months and end time as now.month 
-2months  and 
DAILY with start time as now.day and end time as now.month -2months
Then this Sorage will have an implied start time as now.month -13 month and end 
time as now.day

Example 2
A Storage has 2 Overlapping Update Periods.
MONTHLY with start time as now.month -13 months and end time as now.month 
-1months  and 
DAILY with start time as now.day and end time as now.month -2months
Then this Sorage will have an implied start time as now.month -13 month and end 
time as now.day


- Puneet


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57949/#review170168
-------


On March 27, 2017, 11:19 a.m., Puneet Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57949/
> ---
> 
> (Updated March 27, 2017, 11:19 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1397
> https://issues.apache.org/jira/browse/LENS-1397
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Consider the case where a Storage S has three update periods and each update 
> period has a different table description "table_desc" as supported in 
> LENS-1386. 
> 
> We should be able to rewrite queries for such storages
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
>  c8a2498ba25ee6c968fd8ca4169612cc3a2763fe 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java 
> 5bdbf74c4171badbefe5bc07e9ae557b100b0abb 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 
> 095a2976db5c1d456b7ab3b4ca95b6cac9172172 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
>  0b7d4002bb9390b364e1b4aeb78ae9f0eb523d25 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  6cb18e629011de17d8c12a0bac0fc6e9110c7186 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  97a73a8059d816eb2f35b313f74c7a04aa60e49c 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 
> 68449f667782c15802ed211b51a91f208471f058 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnLifetimeChecker.java 
> 24eb8f05d250dfecb41afc4a4eb8f031b90850d8 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> 76031ecbadec307a12fe172f7b227b9f292e642f 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 
> 0e2ca821ba8eb7c3b4eeb029ac88422091781a48 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/Defau

Re: Review Request 57908: Xsd for virtual fact

[Puneet Gupta]

> On March 27, 2017, 11:24 a.m., Rajat Khandelwal wrote:
> > lens-examples/src/main/resources/virtualfact1.xml
> > Lines 25 (patched)
> > 
> >
> > I think filter will only be where clauses. conditions on measures are 
> > part of having clauses. We can keep one more property for having clauses.
> 
> Amareshwari Sriramadasu wrote:
> Filters should be mandatory as well, can add one more XProperties with 
> mandatory filter properties.

Any more thoughts on how virtual fact will evolve in future? We can consider 
those to have the xsd defined in a generic way (and may be not have filter as 
mandatory element/property). Rajitha has captured some like hiding some columns 
in virtual fact or dropping some storages.


- Puneet


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57908/#review170154
---


On March 27, 2017, 9:55 a.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57908/
> ---
> 
> (Updated March 27, 2017, 9:55 a.m.)
> 
> 
> Review request for lens and Rajat Khandelwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Xsd for virtual fact
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/cube-0.1.xsd 060eb43 
>   lens-examples/src/main/resources/virtualfact1.xml PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57908/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

Re: Review Request 57908: Xsd for virtual fact

[Puneet Gupta]

> On March 27, 2017, 11:24 a.m., Rajat Khandelwal wrote:
> > lens-examples/src/main/resources/virtualfact1.xml
> > Lines 22 (patched)
> > 
> >
> > We need to make weight mandatory.

Shoudn't we keep this optional. It can be borrowed from parent in that case ?


- Puneet


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57908/#review170154
---


On March 27, 2017, 9:55 a.m., Rajitha R wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57908/
> ---
> 
> (Updated March 27, 2017, 9:55 a.m.)
> 
> 
> Review request for lens and Rajat Khandelwal.
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Xsd for virtual fact
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/cube-0.1.xsd 060eb43 
>   lens-examples/src/main/resources/virtualfact1.xml PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57908/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajitha R
> 
>

Re: Review Request 57949: LENS-1397: Support query rewrite for separate table per update period in a storage

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57949/
---

(Updated March 27, 2017, 11:19 a.m.)


Review request for lens.


Changes
---

Merged with lens-1381


Bugs: LENS-1397
https://issues.apache.org/jira/browse/LENS-1397


Repository: lens


Description
---

Consider the case where a Storage S has three update periods and each update 
period has a different table description "table_desc" as supported in 
LENS-1386. 

We should be able to rewrite queries for such storages


Diffs (updated)
-

  
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
c8a2498ba25ee6c968fd8ca4169612cc3a2763fe 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java 
5bdbf74c4171badbefe5bc07e9ae557b100b0abb 
  lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 
095a2976db5c1d456b7ab3b4ca95b6cac9172172 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
 0b7d4002bb9390b364e1b4aeb78ae9f0eb523d25 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 6cb18e629011de17d8c12a0bac0fc6e9110c7186 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 
97a73a8059d816eb2f35b313f74c7a04aa60e49c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 
68449f667782c15802ed211b51a91f208471f058 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnLifetimeChecker.java 
24eb8f05d250dfecb41afc4a4eb8f031b90850d8 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
76031ecbadec307a12fe172f7b227b9f292e642f 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 
0e2ca821ba8eb7c3b4eeb029ac88422091781a48 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java 
17e202d5eeeaa75bc985372a05a8589ac9271626 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 
bcea7ed4d39639e66f699500f24b79dc280d3906 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
1daeea53955d121abfe94eaae2979bb1cbc8eca5 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java 
fa3ba8f982b35eb3c79afd76284b698f09558a4e 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 
4cae6f8074641574859b8d2782ac3afa11d6e441 
  lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAST.java 
bdd6376373b50c3e2c1606e69eeac75d186d6af2 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
e6e9f8f0f42471567611fe0e4629d5f9f87a471a 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
22e2e09f2ee2c3fd7b970025a8155dda1ff4847d 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionCandidate.java 
d97e7b8d499393a1cb5122126bd97637c1bd2b58 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 
2ca11819166c3b6de10d0ff63eed4eb4c501ff5b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/join/AutoJoinContext.java 
b5b0b30426bb9d5761108e4d09ace970e8b1b9d5 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/DateFactory.java 
3bdc047c37f3e4425277db579c80ceb1cb89a6b2 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
2d031f435fbd663f634ec1eeff58e1473e0173c5 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
2bf0554cd016cb581a1dcfa6220980a03d8777ff 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
 523a8768cc917bab95cf8f2bd9ff57a1a6f6e24c 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryMetrics.java 
46ee863e71a3444abbc1365243d6014017e30014 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 
cd7383bca91c072c30a5bc4207369288d7cb0a76 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java
 a6b8f889c26f38c2c94f35e2752b1779b6a1ec4d 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionQueries.java 
c2d5f7c3202d0472ff06c3065f359964c0f1217c 
  lens-cube/src/test/resources/schema/facts/testfact.xml 
a4c2c7810cf64a3d275d1bc532696dab69d1c705 


Diff: https://reviews.apache.org/r/57949/diff/2/

Changes: https://reviews.apache.org/r/57949/diff/1-2/


Testing
---


Thanks,

Puneet Gupta

Review Request 57949: LENS-1397: Support query rewrite for separate table per update period in a storage

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57949/
---

Review request for lens.


Bugs: LENS-1397
https://issues.apache.org/jira/browse/LENS-1397


Repository: lens


Description
---

Consider the case where a Storage S has three update periods and each update 
period has a different table description "table_desc" as supported in 
LENS-1386. 

We should be able to rewrite queries for such storages


Diffs
-

  
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
78fb6d3a49ec7c5d407267d835bdfc83a6fd0cc2 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java 
5bdbf74c4171badbefe5bc07e9ae557b100b0abb 
  lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 
095a2976db5c1d456b7ab3b4ca95b6cac9172172 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
 0b7d4002bb9390b364e1b4aeb78ae9f0eb523d25 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 6cb18e629011de17d8c12a0bac0fc6e9110c7186 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java 
97a73a8059d816eb2f35b313f74c7a04aa60e49c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 
68449f667782c15802ed211b51a91f208471f058 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnLifetimeChecker.java 
24eb8f05d250dfecb41afc4a4eb8f031b90850d8 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
76031ecbadec307a12fe172f7b227b9f292e642f 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 
0e2ca821ba8eb7c3b4eeb029ac88422091781a48 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultQueryAST.java 
17e202d5eeeaa75bc985372a05a8589ac9271626 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 
bcea7ed4d39639e66f699500f24b79dc280d3906 
  lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
1daeea53955d121abfe94eaae2979bb1cbc8eca5 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java 
fa3ba8f982b35eb3c79afd76284b698f09558a4e 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 
4cae6f8074641574859b8d2782ac3afa11d6e441 
  lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAST.java 
bdd6376373b50c3e2c1606e69eeac75d186d6af2 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
25acb01a94b4103806eccac539d16bc1b12761dd 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
bc008ae6181490909605488a618029b8b6086f3c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionCandidate.java 
d97e7b8d499393a1cb5122126bd97637c1bd2b58 
  lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 
2ca11819166c3b6de10d0ff63eed4eb4c501ff5b 
  lens-cube/src/main/java/org/apache/lens/cube/parse/join/AutoJoinContext.java 
b5b0b30426bb9d5761108e4d09ace970e8b1b9d5 
  lens-cube/src/test/java/org/apache/lens/cube/metadata/DateFactory.java 
3bdc047c37f3e4425277db579c80ceb1cb89a6b2 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
94d4b40ee33fc8c81904d5979bc6cc8cfe599e24 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
2bf0554cd016cb581a1dcfa6220980a03d8777ff 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
 523a8768cc917bab95cf8f2bd9ff57a1a6f6e24c 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryMetrics.java 
46ee863e71a3444abbc1365243d6014017e30014 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java 
cd7383bca91c072c30a5bc4207369288d7cb0a76 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java
 a6b8f889c26f38c2c94f35e2752b1779b6a1ec4d 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionQueries.java 
c2d5f7c3202d0472ff06c3065f359964c0f1217c 


Diff: https://reviews.apache.org/r/57949/diff/1/


Testing
---


Thanks,

Puneet Gupta

Re: Review Request 57948: LENS-1397: Support query rewrite for separate table per update period in a storage

[Puneet Gupta]

s detected - recompiling the module!
[INFO] Compiling 119 source files to 
/d0/jenkins/workspace/Platform_Common_Job/lens-cube/target/classes
[WARNING] 
/d0/jenkins/workspace/Platform_Common_Job/lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java:
 Some input files use or override a deprecated API.
[WARNING] 
/d0/jenkins/workspace/Platform_Common_Job/lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java:
 Recompile with -Xlint:deprecation for details.
[WARNING] 
/d0/jenkins/workspace/Platform_Common_Job/lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java:
 Some input files use unchecked or unsafe operations.
[WARNING] 
/d0/jenkins/workspace/Platform_Common_Job/lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java:
 Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ 
lens-cube ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 2 resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ 
lens-cube ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 41 source files to 
/d0/jenkins/workspace/Platform_Common_Job/lens-cube/target/test-classes
[WARNING] 
/d0/jenkins/workspace/Platform_Common_Job/lens-cube/src/test/java/org/apache/lens/cube/metadata/TestDateUtil.java:
 
/d0/jenkins/workspace/Platform_Common_Job/lens-cube/src/test/java/org/apache/lens/cube/metadata/TestDateUtil.java
 uses or overrides a deprecated API.
[WARNING] 
/d0/jenkins/workspace/Platform_Common_Job/lens-cube/src/test/java/org/apache/lens/cube/metadata/TestDateUtil.java:
 Recompile with -Xlint:deprecation for details.
[INFO] 
[INFO] --- maven-surefire-plugin:2.15:test (default-test) @ lens-cube ---
[INFO] Surefire report directory: 
/d0/jenkins/workspace/Platform_Common_Job/lens-cube/target/surefire-reports

---
 T E S T S
---
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; 
support was removed in 8.0
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; 
support was removed in 8.0
Running TestSuite
Tests run: 418, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 299.41 sec - 
in TestSuite

Results :

Tests run: 418, Failures: 0, Errors: 0, Skipped: 0


Thanks,

Puneet Gupta

[jira] [Work started] (LENS-1397) Support query rewrite for separate table per update period in a storage

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-1397 started by Puneet Gupta.
--
> Support query rewrite for separate table per update period in a storage
> ---
>
> Key: LENS-1397
> URL: https://issues.apache.org/jira/browse/LENS-1397
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>    Reporter: Puneet Gupta
>Assignee: Puneet Gupta
>
> Consider the case where a Storage S has three update periods and each update 
> period has a different table description "table_desc" as supported in 
> LENS-1386. 
> We should be able to rewrite queries for such storages 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1400) Convert CubeTestSetup to setup using xml files instead of code

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902507#comment-15902507
 ] 

Puneet Gupta commented on LENS-1400:


This will be very helpful in writing new test cases and 
understanding/optimizing the current ones. Thanks [~prongs] 

> Convert CubeTestSetup to setup using xml files instead of code
> --
>
> Key: LENS-1400
> URL: https://issues.apache.org/jira/browse/LENS-1400
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: cube
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>
> To add more tests in cube module, one would need to create more schema 
> objects. Creating them in java is too difficult and hard to read for other 
> people. So I'll be converting them to xml based schema creation. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1401) FallBack Range not considered while doing TimeRange validation for facts and columns

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1401:
---
Component/s: (was: server)
 cube

> FallBack Range not considered while doing TimeRange validation for facts and 
> columns
> 
>
> Key: LENS-1401
> URL: https://issues.apache.org/jira/browse/LENS-1401
> Project: Apache Lens
>  Issue Type: Bug
>  Components: cube
>Reporter: Puneet Gupta
>
> There is a problem in query rewriting flow wrt to fallback time.
> Fallback is decided only in StorageTableResolution phase but until then the 
> user supplied TimeRange is used to validate facts and columns (and not 
> fallback range). If Fallback range is very different from actual time range 
> there can be a very obvious issue. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1397) Support query rewrite for separate table per update period in a storage

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1397:
---
Summary: Support query rewrite for separate table per update period in a 
storage  (was: Support query rewrite for separate table per update periods in a 
storage)

> Support query rewrite for separate table per update period in a storage
> ---
>
> Key: LENS-1397
> URL: https://issues.apache.org/jira/browse/LENS-1397
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>    Reporter: Puneet Gupta
>Assignee: Puneet Gupta
>
> Consider the case where a Storage S has three update periods and each update 
> period has a different table description "table_desc" as supported in 
> LENS-1386. 
> We should be able to rewrite queries for such storages 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (LENS-1397) Support query rewrite for separate table per update periods in a storage

[Puneet Gupta (JIRA)]

Puneet Gupta created LENS-1397:
--

 Summary: Support query rewrite for separate table per update 
periods in a storage
 Key: LENS-1397
 URL: https://issues.apache.org/jira/browse/LENS-1397
 Project: Apache Lens
  Issue Type: Sub-task
  Components: server
Reporter: Puneet Gupta
Assignee: Puneet Gupta


Consider the case where a Storage S has three update periods and each update 
period has a different table description "table_desc" as supported in 
LENS-1386. 

We should be able to rewrite queries for such storages 




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56842: LENS-1389: Back Merge with master and fix lens-cube tests

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56842/#review167053
---


Ship it!




Ship It!

- Puneet Gupta


On Feb. 28, 2017, 12:32 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56842/
> ---
> 
> (Updated Feb. 28, 2017, 12:32 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1389
> https://issues.apache.org/jira/browse/LENS-1389
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> This is causing test failure in lens-1381 branch.
> 
> 
> Diffs
> -
> 
>   checkstyle/src/main/resources/checkstyle-suppressions.xml PRE-CREATION 
>   checkstyle/src/main/resources/suppressions.xml 
> 06c49af718e00485d39c06d4f3943a8c663da498 
>   lens-api/src/main/resources/cube-0.1.xsd 
> f438f48f252305ba6a3691b0a98b1f40eff1f25b 
>   
> lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java
>  bdfa3a065bd24b507d26f3048dce42a58667be25 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
> adb6c9277805805e2ca271667d660bff26fafca6 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
>  aa2e9d1a379f299c6acfd062e9061c5b959e2cd1 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java 
> 771708132a7e9dfbcb1148329647a946425b9d42 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 
> 1694b8092e88fffcd3b96153cc1796bf3260df66 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> 53cf8af330c378eabc2da4ae88601227e0e21979 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 
> cd9f70552f2b5e463b490ec78de8384879eaf75c 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java 
> bf6cc5c3e6d8fc6521a5b0f1ef3e0212f0111c7a 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java
>  8681e90139e278e7e8f4489a162cf171edc98524 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java
>  c8b81298aab87dcce23446e036a903095eb518da 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
>  c36ce7097a8c3412ddaf23b4c08e0a0900a294c9 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTable.java 
> 5863c1ce1f8c6f55a27c09ae674a1cec2ad2a9b1 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  c7f2047b57ebc26244891d9bc48ad18ab0176fdd 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  2ab7f4bee68f05d46a625b50de90e07874d21b81 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 
> bdde27cd17af8e4fb50ad999692a3f928ab4d08a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CheckTableNames.java 
> 858626241df7347f138cd0a259530b31a39de3ab 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnLifetimeChecker.java 
> PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> e56193ccc311be38b2b5e03f5516c4c3bccd9e39 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> f052a2fd9b2f02653502951a98efa3d4003b9e0a 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 
> fc960555c98d42bfbe7835c2edb24564449ba602 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
>  bb290346b23c6a2088cacd7834bc8a2a3e96fc07 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
> 82113af4ea4f4ebf56712187389a8117aebeb595 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 
> 48af0c908fefdd331c2fe175292ff323a475735b 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java
>  4664cde1786c2e6217a0d7aa7a26d1cc248bf532 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 
> 0c6465ac725b0b801a34818e114bbfdd065e972d 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/QueriedPhraseContext.java 
> 832b7a4894696e2e91fae398ac607405bdc9f3b2 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> fca86ec88b1dd0507d21ca1b414dcc6fb68317e3 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
> 3029589ae1db24330aebb6eaa34aa127c3576a04 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 
> 87

Re: Review Request 56842: LENS-1389: Back Merge with master and fix lens-cube tests

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56842/#review167026
---




lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java (line 
1081)
<https://reviews.apache.org/r/56842/#comment239167>

Is this needed ?



lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java (line 
1145)
<https://reviews.apache.org/r/56842/#comment239168>

Suggestion: The change form public to package access can be done is a 
separate review . This will make things harder to review in fanal patch.



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
(line 338)
<https://reviews.apache.org/r/56842/#comment239169>

This logic looks wrong. Pleas re-check.



pom.xml (line 94)
<https://reviews.apache.org/r/56842/#comment239163>

Is this needed ? Can we do this separately if not mandatory for this patch.



lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java (line 106)
<https://reviews.apache.org/r/56842/#comment239164>

Should we break the loop here ?


- Puneet Gupta


On Feb. 28, 2017, 7:59 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56842/
> ---
> 
> (Updated Feb. 28, 2017, 7:59 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1389
> https://issues.apache.org/jira/browse/LENS-1389
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> This is causing test failure in lens-1381 branch.
> 
> 
> Diffs
> -
> 
>   checkstyle/src/main/resources/checkstyle-suppressions.xml PRE-CREATION 
>   checkstyle/src/main/resources/suppressions.xml 
> 06c49af718e00485d39c06d4f3943a8c663da498 
>   lens-api/src/main/resources/cube-0.1.xsd 
> f438f48f252305ba6a3691b0a98b1f40eff1f25b 
>   
> lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java
>  bdfa3a065bd24b507d26f3048dce42a58667be25 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
> adb6c9277805805e2ca271667d660bff26fafca6 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
>  aa2e9d1a379f299c6acfd062e9061c5b959e2cd1 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java 
> 771708132a7e9dfbcb1148329647a946425b9d42 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 
> 1694b8092e88fffcd3b96153cc1796bf3260df66 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> 53cf8af330c378eabc2da4ae88601227e0e21979 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 
> cd9f70552f2b5e463b490ec78de8384879eaf75c 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java 
> bf6cc5c3e6d8fc6521a5b0f1ef3e0212f0111c7a 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java
>  8681e90139e278e7e8f4489a162cf171edc98524 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java
>  c8b81298aab87dcce23446e036a903095eb518da 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
>  c36ce7097a8c3412ddaf23b4c08e0a0900a294c9 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTable.java 
> 5863c1ce1f8c6f55a27c09ae674a1cec2ad2a9b1 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  c7f2047b57ebc26244891d9bc48ad18ab0176fdd 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  2ab7f4bee68f05d46a625b50de90e07874d21b81 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java 
> bdde27cd17af8e4fb50ad999692a3f928ab4d08a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CheckTableNames.java 
> 858626241df7347f138cd0a259530b31a39de3ab 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnLifetimeChecker.java 
> PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> e56193ccc311be38b2b5e03f5516c4c3bccd9e39 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> f052a2fd9b2f02653502951a98efa3d4003b9e0a 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java 
> fc960555c98d42bfbe7835c2edb24564449ba602 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
>  bb290346b23c6a2088cacd7834bc8a2a3e96fc07 
>   lens-cube

[jira] [Commented] (LENS-1372) QueryRetryTest is flaky

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15887439#comment-15887439
 ] 

Puneet Gupta commented on LENS-1372:


Not sure how ctx can be null on restart. 
org.apache.lens.server.query.QueryExecutionServiceImpl#writeExternal is 
persisting all query contexts (QueryExecutionServiceImpl#allQueries)  before 
restart and restoring them after restart 
QueryExecutionServiceImpl#readExternal). 

Do we see any persistence failures in log  
(org.apache.lens.server.LensServices#stop, 
aorg.apache.lens.server.LensServices#persistLensServiceState) ?



> QueryRetryTest is flaky
> ---
>
> Key: LENS-1372
> URL: https://issues.apache.org/jira/browse/LENS-1372
> Project: Apache Lens
>  Issue Type: Test
>  Components: server, test
>Affects Versions: 2.7
>Reporter: Ted Yu
>Assignee: Rajat Khandelwal
>Priority: Minor
> Fix For: 2.7
>
>
> From 
> https://builds.apache.org/job/PreCommit-Lens-Build/1145/testReport/junit/org.apache.lens.server.query.retry/QueryRetryTest/testRestartWhileRetry/
>  :
> {code}
> java.lang.NullPointerException: null
>   at 
> org.apache.lens.server.query.retry.QueryRetryTest.testRestartWhileRetry(QueryRetryTest.java:201)
> {code}
> Here is related code:
> {code}
> ctx = getQueryService().getQueryContext(handle);
> while (!ctx.getStatus().finished()) {
> {code}
> The test should handle the case where status is null.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56842: LENS-1389: Back Merge with master and fix lens-cube tests

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56842/#review166852
---




lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
(lines 263 - 264)
<https://reviews.apache.org/r/56842/#comment238941>

Can we add comment for this part and improve the code readbility if 
possible.



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
(line 271)
<https://reviews.apache.org/r/56842/#comment238939>

Should we remove fact form all log.info in this for loop. 

"Skipping update period {} for storage candidate {}..."



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
(line 314)
<https://reviews.apache.org/r/56842/#comment238942>

When will "PART_COL_DOES_NOT_EXIST" cause be added ?


- Puneet Gupta


On Feb. 24, 2017, 1:48 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56842/
> ---
> 
> (Updated Feb. 24, 2017, 1:48 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1389
> https://issues.apache.org/jira/browse/LENS-1389
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> This is causing test failure in lens-1381 branch.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/cube-0.1.xsd 
> f438f48f252305ba6a3691b0a98b1f40eff1f25b 
>   
> lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java
>  bdfa3a065bd24b507d26f3048dce42a58667be25 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
> adb6c9277805805e2ca271667d660bff26fafca6 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
>  aa2e9d1a379f299c6acfd062e9061c5b959e2cd1 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java 
> 771708132a7e9dfbcb1148329647a946425b9d42 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> 53cf8af330c378eabc2da4ae88601227e0e21979 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 
> cd9f70552f2b5e463b490ec78de8384879eaf75c 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java 
> bf6cc5c3e6d8fc6521a5b0f1ef3e0212f0111c7a 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java
>  c8b81298aab87dcce23446e036a903095eb518da 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
>  c36ce7097a8c3412ddaf23b4c08e0a0900a294c9 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  c7f2047b57ebc26244891d9bc48ad18ab0176fdd 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  2ab7f4bee68f05d46a625b50de90e07874d21b81 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> e56193ccc311be38b2b5e03f5516c4c3bccd9e39 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> f052a2fd9b2f02653502951a98efa3d4003b9e0a 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
>  bb290346b23c6a2088cacd7834bc8a2a3e96fc07 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
> 82113af4ea4f4ebf56712187389a8117aebeb595 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 
> 48af0c908fefdd331c2fe175292ff323a475735b 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java
>  4664cde1786c2e6217a0d7aa7a26d1cc248bf532 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 
> 0c6465ac725b0b801a34818e114bbfdd065e972d 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/QueriedPhraseContext.java 
> 832b7a4894696e2e91fae398ac607405bdc9f3b2 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> fca86ec88b1dd0507d21ca1b414dcc6fb68317e3 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
> 3029589ae1db24330aebb6eaa34aa127c3576a04 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeChecker.java 
> e37db8b78cda74b56b9983c25b972066c21340f6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TrackDenormContext.java 
> PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 
> 8c81166de7d7293ea8754ba3391ea940424ad48f 
>   
> lens-cube/src/main/java/org/apache/lens/cube

Re: Review Request 56842: LENS-1389: Back Merge with master and fix lens-cube tests

[Puneet Gupta]

g/r/56842/#comment238660>

This is redundant.



lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
(line 836)
<https://reviews.apache.org/r/56842/#comment238668>

Should we delete the comment ?



lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java (line 
104)
<https://reviews.apache.org/r/56842/#comment238669>

should we delete this comment ?



lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java (line 
950)
<https://reviews.apache.org/r/56842/#comment238670>

should we delete this comment ?


- Puneet Gupta


On Feb. 23, 2017, 9:54 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56842/
> ---
> 
> (Updated Feb. 23, 2017, 9:54 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1389
> https://issues.apache.org/jira/browse/LENS-1389
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> This is causing test failure in lens-1381 branch.
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/resources/cube-0.1.xsd 
> f438f48f252305ba6a3691b0a98b1f40eff1f25b 
>   
> lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java
>  bdfa3a065bd24b507d26f3048dce42a58667be25 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
> adb6c9277805805e2ca271667d660bff26fafca6 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
>  aa2e9d1a379f299c6acfd062e9061c5b959e2cd1 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java 
> 771708132a7e9dfbcb1148329647a946425b9d42 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java 
> 53cf8af330c378eabc2da4ae88601227e0e21979 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 
> cd9f70552f2b5e463b490ec78de8384879eaf75c 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java 
> bf6cc5c3e6d8fc6521a5b0f1ef3e0212f0111c7a 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
>  c36ce7097a8c3412ddaf23b4c08e0a0900a294c9 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  c7f2047b57ebc26244891d9bc48ad18ab0176fdd 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  2ab7f4bee68f05d46a625b50de90e07874d21b81 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> e56193ccc311be38b2b5e03f5516c4c3bccd9e39 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> f052a2fd9b2f02653502951a98efa3d4003b9e0a 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
>  bb290346b23c6a2088cacd7834bc8a2a3e96fc07 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
> 82113af4ea4f4ebf56712187389a8117aebeb595 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 
> 48af0c908fefdd331c2fe175292ff323a475735b 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java
>  4664cde1786c2e6217a0d7aa7a26d1cc248bf532 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java 
> 0c6465ac725b0b801a34818e114bbfdd065e972d 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/QueriedPhraseContext.java 
> 832b7a4894696e2e91fae398ac607405bdc9f3b2 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> fca86ec88b1dd0507d21ca1b414dcc6fb68317e3 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
> 3029589ae1db24330aebb6eaa34aa127c3576a04 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeChecker.java 
> e37db8b78cda74b56b9983c25b972066c21340f6 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TrackDenormContext.java 
> PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java 
> 8c81166de7d7293ea8754ba3391ea940424ad48f 
>   
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java
>  9fecdbccbf188efd39d770662df3606cbf7d766e 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
>  e21dc2ac187318cbc52bd0e49cc8e7065236c4e0 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> 194ab7c6c4cfc540933dbc00e2daac504b28c7e5 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java
>  1a5bd0d1f227c9cc9affadb4c79d2d337ac47706 
>

Re: Review Request 56858: Review comment fixes for MaxCoveringFactResolver and LeastPartitionResolver

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56858/#review166635
---


Ship it!




- Puneet Gupta


On Feb. 21, 2017, 12:12 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56858/
> ---
> 
> (Updated Feb. 21, 2017, 12:12 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1391
> https://issues.apache.org/jira/browse/LENS-1391
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> MaxCoveringFactResolver and LeastPartitionResolver review comments
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  c7f2047 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java
>  153df24 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java
>  4664cde 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> fca86ec 
> 
> Diff: https://reviews.apache.org/r/56858/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

[jira] [Commented] (LENS-1393) Update the javax mail version to current

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877275#comment-15877275
 ] 

Puneet Gupta commented on LENS-1393:


+1

> Update the javax mail version to current
> 
>
> Key: LENS-1393
> URL: https://issues.apache.org/jira/browse/LENS-1393
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
>
> Sending mail with the older version of javax mail was causing threads to 
> stuck because of connection timeout to the mail server was not honored. 
> Updating to the new version solves the problem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56878: LENS-1394: Create DOAP file

[Puneet Gupta]

> On Feb. 21, 2017, 3:33 p.m., Puneet Gupta wrote:
> > doap_lens.rdf, line 37
> > <https://reviews.apache.org/r/56878/diff/1/?file=1640707#file1640707line37>
> >
> > Is this correct url for mailing list?
> 
> Rajat Khandelwal wrote:
> This is a link where mailing lists are mentioned. I copied the rdf file 
> from another project and replaced with corresponding values for our case.

ok


- Puneet


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56878/#review166170
---


On Feb. 21, 2017, 11:56 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56878/
> ---
> 
> (Updated Feb. 21, 2017, 11:56 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1394
> https://issues.apache.org/jira/browse/LENS-1394
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Create doap file for project to appear in projects.apache.org
> 
> 
> Diffs
> -
> 
>   doap_lens.rdf PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56878/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 56878: LENS-1394: Create DOAP file

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56878/#review166170
---




doap_lens.rdf (line 37)
<https://reviews.apache.org/r/56878/#comment238055>

Is this correct url for mailing list?



doap_lens.rdf (line 94)
<https://reviews.apache.org/r/56878/#comment238054>

This is a GA release



doap_lens.rdf (lines 99 - 100)
<https://reviews.apache.org/r/56878/#comment238056>

Can these be same ?

I think 

https://git-wip-us.apache.org/repos/asf/lens.git 
redirects to 
https://git-wip-us.apache.org/repos/asf?p=lens.git


- Puneet Gupta


On Feb. 21, 2017, 11:56 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56878/
> ---
> 
> (Updated Feb. 21, 2017, 11:56 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1394
> https://issues.apache.org/jira/browse/LENS-1394
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Create doap file for project to appear in projects.apache.org
> 
> 
> Diffs
> -
> 
>   doap_lens.rdf PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/56878/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 56858: Review comment fixes for MaxCoveringFactResolver and LeastPartitionResolver

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56858/#review166167
---




lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 
(line 122)
<https://reviews.apache.org/r/56858/#comment238052>

But null does not make sense. We should pass the incomplete partitions. 
Lets have an online discussion on this if you feel otherwise.

cubeql.addCandidatePruningMsg() actually adds the message at 
StorageCandidate Level .


- Puneet Gupta


On Feb. 21, 2017, 12:12 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56858/
> ---
> 
> (Updated Feb. 21, 2017, 12:12 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1391
> https://issues.apache.org/jira/browse/LENS-1391
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> MaxCoveringFactResolver and LeastPartitionResolver review comments
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  c7f2047 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java
>  153df24 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java
>  4664cde 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> fca86ec 
> 
> Diff: https://reviews.apache.org/r/56858/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

Re: Review Request 56858: Review comment fixes for MaxCoveringFactResolver and LeastPartitionResolver

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56858/#review166148
---




lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java 
(line 70)
<https://reviews.apache.org/r/56858/#comment238032>

This should be done at candidate level and not at storage candidate level. 
Candidate.getParticipatingPartitions().size()



lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 
(line 122)
<https://reviews.apache.org/r/56858/#comment238033>

passing null ? 
Should pass the incomplete partition details . This info will be stored in 
CandidateTablePruneCause#incompletePartitions and will be used for error 
message construction.



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
<https://reviews.apache.org/r/56858/#comment238034>

Older comments seem more readable. Can you check once.



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
<https://reviews.apache.org/r/56858/#comment238035>

Why this comment is dropped ?


- Puneet Gupta


On Feb. 21, 2017, 11:19 a.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56858/
> ---
> 
> (Updated Feb. 21, 2017, 11:19 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1391
> https://issues.apache.org/jira/browse/LENS-1391
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> MaxCoveringFactResolver and LeastPartitionResolver review comments
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  c7f2047 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java
>  153df24 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java
>  4664cde 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> fca86ec 
> 
> Diff: https://reviews.apache.org/r/56858/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

[jira] [Updated] (LENS-1392) Fix failing TestCases in org.apache.lens.server.query.QueryAPIErrorResponseTest

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1392:
---
Status: Patch Available  (was: In Progress)

> Fix  failing TestCases in 
> org.apache.lens.server.query.QueryAPIErrorResponseTest
> 
>
> Key: LENS-1392
> URL: https://issues.apache.org/jira/browse/LENS-1392
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Puneet Gupta
>    Assignee: Puneet Gupta
> Attachments: lens-1392.patch
>
>
> Failed tests:
> QueryAPIErrorResponseTest.testQueryColumnWithBothStartDateAndEndDate:209->testColUnAvailableInTimeRange:297
>  expected [dimfield8d6e29df822945c49ea03d3533806cca can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC and before Friday, January 30, 2015 
> 11:00:00 PM UTC. Please adjust the selected time range accordingly.] but 
> found [No fact table has the queried columns : 
> [dimfield8d6e29df822945c49ea03d3533806cca]]
> QueryAPIErrorResponseTest.testQueryColumnWithBothStartDateAndEndDate:209->testColUnAvailableInTimeRange:297
>  expected [dimfield16cc374b445443a6ae8fce39fad190d1 can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC and before Friday, January 30, 2015 
> 11:00:00 PM UTC. Please adjust the selected time range accordingly.] but 
> found [No fact table has the queried columns : 
> [dimfield16cc374b445443a6ae8fce39fad190d1]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyEndDate:245->testColUnAvailableInTimeRange:297
>  expected [dimfieldc7f0b34c257d4fde80dacaaf0d61d600 can only be queried 
> before Friday, January 30, 2015 11:00:00 PM UTC. Please adjust the selected 
> time range accordingly.] but found [No fact table has the queried columns : 
> [dimfieldc7f0b34c257d4fde80dacaaf0d61d600]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyEndDate:245->testColUnAvailableInTimeRange:297
>  expected [dimfield3931859c8fdf47a49beaadba222915d6 can only be queried 
> before Friday, January 30, 2015 11:00:00 PM UTC. Please adjust the selected 
> time range accordingly.] but found [No fact table has the queried columns : 
> [dimfield3931859c8fdf47a49beaadba222915d6]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyStartDate:227->testColUnAvailableInTimeRange:297
>  expected [dimfield4b536214dcf0413e9bd7190d9efa139b can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC. Please adjust the selected time 
> range accordingly.] but found [No fact table has the queried columns : 
> [dimfield4b536214dcf0413e9bd7190d9efa139b]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyStartDate:227->testColUnAvailableInTimeRange:297
>  expected [dimfield85771da365a44789a42fd8f800fbbe50 can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC. Please adjust the selected time 
> range accordingly.] but found [No fact table has the queried columns : 
> [dimfield85771da365a44789a42fd8f800fbbe50]]
> Tests run: 321, Failures: 6, Errors: 0, Skipped: 18



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1392) Fix failing TestCases in org.apache.lens.server.query.QueryAPIErrorResponseTest

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1392:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Fix  failing TestCases in 
> org.apache.lens.server.query.QueryAPIErrorResponseTest
> 
>
> Key: LENS-1392
> URL: https://issues.apache.org/jira/browse/LENS-1392
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Puneet Gupta
>    Assignee: Puneet Gupta
> Attachments: lens-1392.patch
>
>
> Failed tests:
> QueryAPIErrorResponseTest.testQueryColumnWithBothStartDateAndEndDate:209->testColUnAvailableInTimeRange:297
>  expected [dimfield8d6e29df822945c49ea03d3533806cca can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC and before Friday, January 30, 2015 
> 11:00:00 PM UTC. Please adjust the selected time range accordingly.] but 
> found [No fact table has the queried columns : 
> [dimfield8d6e29df822945c49ea03d3533806cca]]
> QueryAPIErrorResponseTest.testQueryColumnWithBothStartDateAndEndDate:209->testColUnAvailableInTimeRange:297
>  expected [dimfield16cc374b445443a6ae8fce39fad190d1 can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC and before Friday, January 30, 2015 
> 11:00:00 PM UTC. Please adjust the selected time range accordingly.] but 
> found [No fact table has the queried columns : 
> [dimfield16cc374b445443a6ae8fce39fad190d1]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyEndDate:245->testColUnAvailableInTimeRange:297
>  expected [dimfieldc7f0b34c257d4fde80dacaaf0d61d600 can only be queried 
> before Friday, January 30, 2015 11:00:00 PM UTC. Please adjust the selected 
> time range accordingly.] but found [No fact table has the queried columns : 
> [dimfieldc7f0b34c257d4fde80dacaaf0d61d600]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyEndDate:245->testColUnAvailableInTimeRange:297
>  expected [dimfield3931859c8fdf47a49beaadba222915d6 can only be queried 
> before Friday, January 30, 2015 11:00:00 PM UTC. Please adjust the selected 
> time range accordingly.] but found [No fact table has the queried columns : 
> [dimfield3931859c8fdf47a49beaadba222915d6]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyStartDate:227->testColUnAvailableInTimeRange:297
>  expected [dimfield4b536214dcf0413e9bd7190d9efa139b can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC. Please adjust the selected time 
> range accordingly.] but found [No fact table has the queried columns : 
> [dimfield4b536214dcf0413e9bd7190d9efa139b]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyStartDate:227->testColUnAvailableInTimeRange:297
>  expected [dimfield85771da365a44789a42fd8f800fbbe50 can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC. Please adjust the selected time 
> range accordingly.] but found [No fact table has the queried columns : 
> [dimfield85771da365a44789a42fd8f800fbbe50]]
> Tests run: 321, Failures: 6, Errors: 0, Skipped: 18



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (LENS-1392) Fix failing TestCases in org.apache.lens.server.query.QueryAPIErrorResponseTest

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875792#comment-15875792
 ] 

Puneet Gupta commented on LENS-1392:


Committed myself. 

> Fix  failing TestCases in 
> org.apache.lens.server.query.QueryAPIErrorResponseTest
> 
>
> Key: LENS-1392
> URL: https://issues.apache.org/jira/browse/LENS-1392
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Puneet Gupta
>    Assignee: Puneet Gupta
> Attachments: lens-1392.patch
>
>
> Failed tests:
> QueryAPIErrorResponseTest.testQueryColumnWithBothStartDateAndEndDate:209->testColUnAvailableInTimeRange:297
>  expected [dimfield8d6e29df822945c49ea03d3533806cca can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC and before Friday, January 30, 2015 
> 11:00:00 PM UTC. Please adjust the selected time range accordingly.] but 
> found [No fact table has the queried columns : 
> [dimfield8d6e29df822945c49ea03d3533806cca]]
> QueryAPIErrorResponseTest.testQueryColumnWithBothStartDateAndEndDate:209->testColUnAvailableInTimeRange:297
>  expected [dimfield16cc374b445443a6ae8fce39fad190d1 can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC and before Friday, January 30, 2015 
> 11:00:00 PM UTC. Please adjust the selected time range accordingly.] but 
> found [No fact table has the queried columns : 
> [dimfield16cc374b445443a6ae8fce39fad190d1]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyEndDate:245->testColUnAvailableInTimeRange:297
>  expected [dimfieldc7f0b34c257d4fde80dacaaf0d61d600 can only be queried 
> before Friday, January 30, 2015 11:00:00 PM UTC. Please adjust the selected 
> time range accordingly.] but found [No fact table has the queried columns : 
> [dimfieldc7f0b34c257d4fde80dacaaf0d61d600]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyEndDate:245->testColUnAvailableInTimeRange:297
>  expected [dimfield3931859c8fdf47a49beaadba222915d6 can only be queried 
> before Friday, January 30, 2015 11:00:00 PM UTC. Please adjust the selected 
> time range accordingly.] but found [No fact table has the queried columns : 
> [dimfield3931859c8fdf47a49beaadba222915d6]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyStartDate:227->testColUnAvailableInTimeRange:297
>  expected [dimfield4b536214dcf0413e9bd7190d9efa139b can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC. Please adjust the selected time 
> range accordingly.] but found [No fact table has the queried columns : 
> [dimfield4b536214dcf0413e9bd7190d9efa139b]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyStartDate:227->testColUnAvailableInTimeRange:297
>  expected [dimfield85771da365a44789a42fd8f800fbbe50 can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC. Please adjust the selected time 
> range accordingly.] but found [No fact table has the queried columns : 
> [dimfield85771da365a44789a42fd8f800fbbe50]]
> Tests run: 321, Failures: 6, Errors: 0, Skipped: 18



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (LENS-1392) Fix failing TestCases in org.apache.lens.server.query.QueryAPIErrorResponseTest

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1392:
---
Attachment: lens-1392.patch

Taking patch form review board and attaching 

https://reviews.apache.org/r/56877/

> Fix  failing TestCases in 
> org.apache.lens.server.query.QueryAPIErrorResponseTest
> 
>
> Key: LENS-1392
> URL: https://issues.apache.org/jira/browse/LENS-1392
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Puneet Gupta
>    Assignee: Puneet Gupta
> Attachments: lens-1392.patch
>
>
> Failed tests:
> QueryAPIErrorResponseTest.testQueryColumnWithBothStartDateAndEndDate:209->testColUnAvailableInTimeRange:297
>  expected [dimfield8d6e29df822945c49ea03d3533806cca can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC and before Friday, January 30, 2015 
> 11:00:00 PM UTC. Please adjust the selected time range accordingly.] but 
> found [No fact table has the queried columns : 
> [dimfield8d6e29df822945c49ea03d3533806cca]]
> QueryAPIErrorResponseTest.testQueryColumnWithBothStartDateAndEndDate:209->testColUnAvailableInTimeRange:297
>  expected [dimfield16cc374b445443a6ae8fce39fad190d1 can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC and before Friday, January 30, 2015 
> 11:00:00 PM UTC. Please adjust the selected time range accordingly.] but 
> found [No fact table has the queried columns : 
> [dimfield16cc374b445443a6ae8fce39fad190d1]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyEndDate:245->testColUnAvailableInTimeRange:297
>  expected [dimfieldc7f0b34c257d4fde80dacaaf0d61d600 can only be queried 
> before Friday, January 30, 2015 11:00:00 PM UTC. Please adjust the selected 
> time range accordingly.] but found [No fact table has the queried columns : 
> [dimfieldc7f0b34c257d4fde80dacaaf0d61d600]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyEndDate:245->testColUnAvailableInTimeRange:297
>  expected [dimfield3931859c8fdf47a49beaadba222915d6 can only be queried 
> before Friday, January 30, 2015 11:00:00 PM UTC. Please adjust the selected 
> time range accordingly.] but found [No fact table has the queried columns : 
> [dimfield3931859c8fdf47a49beaadba222915d6]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyStartDate:227->testColUnAvailableInTimeRange:297
>  expected [dimfield4b536214dcf0413e9bd7190d9efa139b can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC. Please adjust the selected time 
> range accordingly.] but found [No fact table has the queried columns : 
> [dimfield4b536214dcf0413e9bd7190d9efa139b]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyStartDate:227->testColUnAvailableInTimeRange:297
>  expected [dimfield85771da365a44789a42fd8f800fbbe50 can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC. Please adjust the selected time 
> range accordingly.] but found [No fact table has the queried columns : 
> [dimfield85771da365a44789a42fd8f800fbbe50]]
> Tests run: 321, Failures: 6, Errors: 0, Skipped: 18



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Review Request 56877: LENS-1392: Fix failing TestCases in org.apache.lens.server.query.QueryAPIErrorResponseTest

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56877/
---

Review request for lens.


Bugs: lens-1392
https://issues.apache.org/jira/browse/lens-1392


Repository: lens


Description
---

1. Fix for test failures in QueryAPIErrorResponseTest. 
2. Promoted JoinResolver and TimeRangeChecker above storageTableResolver 
CubeQueryRewriter#setupRewriters


Diffs
-

  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
4dd3d007e1629331bdffdbfc67801b3dbe573630 
  lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 
02e2f8b173848f1688cfaad1ba19483d5470ceed 
  lens-server/src/test/java/org/apache/lens/server/common/TestDataUtils.java 
040051955a9b83e4b4fd1ebb99194b46db569924 
  
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java
 567c92934fdaa58252ebe6726712dc76ac3edd0d 

Diff: https://reviews.apache.org/r/56877/diff/


Testing
---

QueryAPIErrorResponseTest Test cases


Thanks,

Puneet Gupta

[jira] [Work started] (LENS-1392) Fix failing TestCases in org.apache.lens.server.query.QueryAPIErrorResponseTest

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on LENS-1392 started by Puneet Gupta.
--
> Fix  failing TestCases in 
> org.apache.lens.server.query.QueryAPIErrorResponseTest
> 
>
> Key: LENS-1392
> URL: https://issues.apache.org/jira/browse/LENS-1392
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: server
>Reporter: Puneet Gupta
>    Assignee: Puneet Gupta
>
> Failed tests:
> QueryAPIErrorResponseTest.testQueryColumnWithBothStartDateAndEndDate:209->testColUnAvailableInTimeRange:297
>  expected [dimfield8d6e29df822945c49ea03d3533806cca can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC and before Friday, January 30, 2015 
> 11:00:00 PM UTC. Please adjust the selected time range accordingly.] but 
> found [No fact table has the queried columns : 
> [dimfield8d6e29df822945c49ea03d3533806cca]]
> QueryAPIErrorResponseTest.testQueryColumnWithBothStartDateAndEndDate:209->testColUnAvailableInTimeRange:297
>  expected [dimfield16cc374b445443a6ae8fce39fad190d1 can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC and before Friday, January 30, 2015 
> 11:00:00 PM UTC. Please adjust the selected time range accordingly.] but 
> found [No fact table has the queried columns : 
> [dimfield16cc374b445443a6ae8fce39fad190d1]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyEndDate:245->testColUnAvailableInTimeRange:297
>  expected [dimfieldc7f0b34c257d4fde80dacaaf0d61d600 can only be queried 
> before Friday, January 30, 2015 11:00:00 PM UTC. Please adjust the selected 
> time range accordingly.] but found [No fact table has the queried columns : 
> [dimfieldc7f0b34c257d4fde80dacaaf0d61d600]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyEndDate:245->testColUnAvailableInTimeRange:297
>  expected [dimfield3931859c8fdf47a49beaadba222915d6 can only be queried 
> before Friday, January 30, 2015 11:00:00 PM UTC. Please adjust the selected 
> time range accordingly.] but found [No fact table has the queried columns : 
> [dimfield3931859c8fdf47a49beaadba222915d6]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyStartDate:227->testColUnAvailableInTimeRange:297
>  expected [dimfield4b536214dcf0413e9bd7190d9efa139b can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC. Please adjust the selected time 
> range accordingly.] but found [No fact table has the queried columns : 
> [dimfield4b536214dcf0413e9bd7190d9efa139b]]
> QueryAPIErrorResponseTest.testQueryColumnWithOnlyStartDate:227->testColUnAvailableInTimeRange:297
>  expected [dimfield85771da365a44789a42fd8f800fbbe50 can only be queried after 
> Thursday, January 1, 2015 12:00:00 AM UTC. Please adjust the selected time 
> range accordingly.] but found [No fact table has the queried columns : 
> [dimfield85771da365a44789a42fd8f800fbbe50]]
> Tests run: 321, Failures: 6, Errors: 0, Skipped: 18



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (LENS-1392) Fix failing TestCases in org.apache.lens.server.query.QueryAPIErrorResponseTest

[Puneet Gupta (JIRA)]

Puneet Gupta created LENS-1392:
--

 Summary: Fix  failing TestCases in 
org.apache.lens.server.query.QueryAPIErrorResponseTest
 Key: LENS-1392
 URL: https://issues.apache.org/jira/browse/LENS-1392
 Project: Apache Lens
  Issue Type: Sub-task
  Components: server
Reporter: Puneet Gupta
Assignee: Puneet Gupta


Failed tests:
QueryAPIErrorResponseTest.testQueryColumnWithBothStartDateAndEndDate:209->testColUnAvailableInTimeRange:297
 expected [dimfield8d6e29df822945c49ea03d3533806cca can only be queried after 
Thursday, January 1, 2015 12:00:00 AM UTC and before Friday, January 30, 2015 
11:00:00 PM UTC. Please adjust the selected time range accordingly.] but found 
[No fact table has the queried columns : 
[dimfield8d6e29df822945c49ea03d3533806cca]]
QueryAPIErrorResponseTest.testQueryColumnWithBothStartDateAndEndDate:209->testColUnAvailableInTimeRange:297
 expected [dimfield16cc374b445443a6ae8fce39fad190d1 can only be queried after 
Thursday, January 1, 2015 12:00:00 AM UTC and before Friday, January 30, 2015 
11:00:00 PM UTC. Please adjust the selected time range accordingly.] but found 
[No fact table has the queried columns : 
[dimfield16cc374b445443a6ae8fce39fad190d1]]
QueryAPIErrorResponseTest.testQueryColumnWithOnlyEndDate:245->testColUnAvailableInTimeRange:297
 expected [dimfieldc7f0b34c257d4fde80dacaaf0d61d600 can only be queried before 
Friday, January 30, 2015 11:00:00 PM UTC. Please adjust the selected time range 
accordingly.] but found [No fact table has the queried columns : 
[dimfieldc7f0b34c257d4fde80dacaaf0d61d600]]
QueryAPIErrorResponseTest.testQueryColumnWithOnlyEndDate:245->testColUnAvailableInTimeRange:297
 expected [dimfield3931859c8fdf47a49beaadba222915d6 can only be queried before 
Friday, January 30, 2015 11:00:00 PM UTC. Please adjust the selected time range 
accordingly.] but found [No fact table has the queried columns : 
[dimfield3931859c8fdf47a49beaadba222915d6]]
QueryAPIErrorResponseTest.testQueryColumnWithOnlyStartDate:227->testColUnAvailableInTimeRange:297
 expected [dimfield4b536214dcf0413e9bd7190d9efa139b can only be queried after 
Thursday, January 1, 2015 12:00:00 AM UTC. Please adjust the selected time 
range accordingly.] but found [No fact table has the queried columns : 
[dimfield4b536214dcf0413e9bd7190d9efa139b]]
QueryAPIErrorResponseTest.testQueryColumnWithOnlyStartDate:227->testColUnAvailableInTimeRange:297
 expected [dimfield85771da365a44789a42fd8f800fbbe50 can only be queried after 
Thursday, January 1, 2015 12:00:00 AM UTC. Please adjust the selected time 
range accordingly.] but found [No fact table has the queried columns : 
[dimfield85771da365a44789a42fd8f800fbbe50]]
Tests run: 321, Failures: 6, Errors: 0, Skipped: 18



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56858: Review comment fixes for MaxCoveringFactResolver and LeastPartitionResolver

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56858/#review166126
---



1. Can you commnet on https://github.com/sushilmohanty/incubator-lens/pull/4 
and metion which all comments are resolved 
2. Can you run test cases for lens-cube


lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 (line 257)
<https://reviews.apache.org/r/56858/#comment238024>

Comment is redundant ?



lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java 
<https://reviews.apache.org/r/56858/#comment238027>

Removed ?



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
<https://reviews.apache.org/r/56858/#comment238028>

Removed ?



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
<https://reviews.apache.org/r/56858/#comment238029>

    Removed ?


- Puneet Gupta


On Feb. 20, 2017, 5:39 p.m., Lavkesh Lahngir wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56858/
> ---
> 
> (Updated Feb. 20, 2017, 5:39 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1391
> https://issues.apache.org/jira/browse/LENS-1391
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> MaxCoveringFactResolver and LeastPartitionResolver review comments
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  c7f2047b57ebc26244891d9bc48ad18ab0176fdd 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java
>  153df245cd2b79ee29991f98df36f57e4e029d2f 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java
>  4664cde1786c2e6217a0d7aa7a26d1cc248bf532 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> fca86ec88b1dd0507d21ca1b414dcc6fb68317e3 
> 
> Diff: https://reviews.apache.org/r/56858/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Lavkesh Lahngir
> 
>

[jira] [Updated] (LENS-1391) Review comments for MaxCoveringFactResolver and LeastPartitionResolver On branch lens-1381

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1391:
---
Summary: Review comments for MaxCoveringFactResolver and 
LeastPartitionResolver On branch lens-1381  (was: Review comments for 
MaxCoveringFactResolver and LeastPartitionResolver On brach lens-1381)

> Review comments for MaxCoveringFactResolver and LeastPartitionResolver On 
> branch lens-1381
> --
>
> Key: LENS-1391
> URL: https://issues.apache.org/jira/browse/LENS-1391
> Project: Apache Lens
>  Issue Type: Task
>  Components: server
>Reporter: Lavkesh Lahngir
>Assignee: Lavkesh Lahngir
>
> Reviews comments fixes for MaxCoveringFactResolver and LeastPartitionResolver



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Review Request 56842: LENS-1389: Valid Update periods for a storage candidate should not be bigger than query time range

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56842/#review166068
---




lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 (line 230)
<https://reviews.apache.org/r/56842/#comment237964>

Can we fix TODO



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java (line 
748)
<https://reviews.apache.org/r/56842/#comment237965>

Unused ?



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java (line 
751)
<https://reviews.apache.org/r/56842/#comment237966>

unused ?



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
(line 303)
<https://reviews.apache.org/r/56842/#comment237977>

can we update the message to replace fact with storage. 
Also can we log max interval in this message .



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
(line 305)
<https://reviews.apache.org/r/56842/#comment237978>

Should we rename QUERY_INTERVAL_BIGGER_THAN_MAX to 
UPDATE_PERIOD_BIGGER_THAN_MAX ?



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
(line 310)
<https://reviews.apache.org/r/56842/#comment237979>

It seems wrong to prune an undate period if it can not cover a time range . 
We shuld keep it if it can partially cover a time range. 

Example Month + Day can cover time Range . 
Month alone can not cover the time range.



lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
(line 313)
<https://reviews.apache.org/r/56842/#comment237980>

Should we call this QUERY_INTERVAL_SMALLER_THAN_UPDATE_PERIOD ?


- Puneet Gupta


On Feb. 20, 2017, 9:17 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56842/
> ---
> 
> (Updated Feb. 20, 2017, 9:17 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1389
> https://issues.apache.org/jira/browse/LENS-1389
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> This is causing test failure in lens-1381 branch.
> 
> 
> Diffs
> -
> 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java 
> 771708132a7e9dfbcb1148329647a946425b9d42 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java 
> bf6cc5c3e6d8fc6521a5b0f1ef3e0212f0111c7a 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  c7f2047b57ebc26244891d9bc48ad18ab0176fdd 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java 
> fca86ec88b1dd0507d21ca1b414dcc6fb68317e3 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 
> 3029589ae1db24330aebb6eaa34aa127c3576a04 
>   pom.xml 8ea64b77fff11d9f46be56437aed3b527bde0ff8 
> 
> Diff: https://reviews.apache.org/r/56842/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 56649: LENS-1387: Move Lens to java 8

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56649/#review165639
---




lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
<https://reviews.apache.org/r/56649/#comment237502>

Is this chnage required for java 8 ?


- Puneet Gupta


On Feb. 14, 2017, 10:09 a.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56649/
> ---
> 
> (Updated Feb. 14, 2017, 10:09 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1387
> https://issues.apache.org/jira/browse/LENS-1387
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Deprecating java7 and restricting lens to only compile with java 8 +
> 
> 
> Diffs
> -
> 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> 9b290832f2ae0072c5d1b3abd387d6e674ce72e7 
>   pom.xml 8ea64b77fff11d9f46be56437aed3b527bde0ff8 
> 
> Diff: https://reviews.apache.org/r/56649/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Java 8

[Puneet Gupta]

Then should we try building by setting source and target to 1.8 ?

1.7
1.7

Thanks,
Puneet Gupta

On Thu, Feb 9, 2017 at 4:27 PM, amareshwarisr . <amareshw...@gmail.com>
wrote:

> Yes - we have latest build passed as well :
> https://builds.apache.org/job/Lens-Commit-Java8/303/
>
> On Thu, Feb 9, 2017 at 3:21 PM, Rajat Khandelwal <rajatgupt...@gmail.com>
> wrote:
>
> > Yeah, I suppose. We have a build jenkins job for java8. I'll try running
> > tests on my local environment.
> >
> > On Thu, Feb 9, 2017 at 2:42 PM Puneet Gupta <puneet.gu...@inmobi.com>
> > wrote:
> >
> > > Can our code compile on Java 8 in current state ?
> > >
> > > Thanks,
> > > Puneet Gupta
> > >
> > > On Thu, Feb 9, 2017 at 2:41 PM, amareshwarisr . <amareshw...@gmail.com
> >
> > > wrote:
> > >
> > > > +1
> > > >
> > > > On Thu, Feb 9, 2017 at 12:25 PM, Rajat Khandelwal <pro...@apache.org
> >
> > > > wrote:
> > > >
> > > > > It's been 2 years since we said "Lens won't compile on Java 6
> > anymore".
> > > > > I've used Java 8 in other places and I like the new features and
> > > > > capabilities and I think we can make use of them to make our
> complex
> > > code
> > > > > smaller and easier to understand. To do that, we'd need to stop
> > > > supporting
> > > > > compilation on Java 7, which I believe is fine seeing as Java 7 has
> > > been
> > > > > EOL for a couple of years now.
> > > > >
> > > > > Thoughts?
> > > > >
> > > >
> > >
> > > --
> > > _
> > > The information contained in this communication is intended solely for
> > the
> > > use of the individual or entity to whom it is addressed and others
> > > authorized to receive it. It may contain confidential or legally
> > privileged
> > > information. If you are not the intended recipient you are hereby
> > notified
> > > that any disclosure, copying, distribution or taking any action in
> > reliance
> > > on the contents of this information is strictly prohibited and may be
> > > unlawful. If you have received this communication in error, please
> notify
> > > us immediately by responding to this email and then delete it from your
> > > system. The firm is neither liable for the proper and complete
> > transmission
> > > of the information contained in this communication nor for any delay in
> > its
> > > receipt.
> > >
> >
>

-- 
_
The information contained in this communication is intended solely for the 
use of the individual or entity to whom it is addressed and others 
authorized to receive it. It may contain confidential or legally privileged 
information. If you are not the intended recipient you are hereby notified 
that any disclosure, copying, distribution or taking any action in reliance 
on the contents of this information is strictly prohibited and may be 
unlawful. If you have received this communication in error, please notify 
us immediately by responding to this email and then delete it from your 
system. The firm is neither liable for the proper and complete transmission 
of the information contained in this communication nor for any delay in its 
receipt.

Re: Java 8

[Puneet Gupta]

Can our code compile on Java 8 in current state ?

Thanks,
Puneet Gupta

On Thu, Feb 9, 2017 at 2:41 PM, amareshwarisr . <amareshw...@gmail.com>
wrote:

> +1
>
> On Thu, Feb 9, 2017 at 12:25 PM, Rajat Khandelwal <pro...@apache.org>
> wrote:
>
> > It's been 2 years since we said "Lens won't compile on Java 6 anymore".
> > I've used Java 8 in other places and I like the new features and
> > capabilities and I think we can make use of them to make our complex code
> > smaller and easier to understand. To do that, we'd need to stop
> supporting
> > compilation on Java 7, which I believe is fine seeing as Java 7 has been
> > EOL for a couple of years now.
> >
> > Thoughts?
> >
>

-- 
_
The information contained in this communication is intended solely for the 
use of the individual or entity to whom it is addressed and others 
authorized to receive it. It may contain confidential or legally privileged 
information. If you are not the intended recipient you are hereby notified 
that any disclosure, copying, distribution or taking any action in reliance 
on the contents of this information is strictly prohibited and may be 
unlawful. If you have received this communication in error, please notify 
us immediately by responding to this email and then delete it from your 
system. The firm is neither liable for the proper and complete transmission 
of the information contained in this communication nor for any delay in its 
receipt.

Re: Report for the month of February

[Puneet Gupta]

+1

Thanks,
Puneet

On Wed, Feb 1, 2017 at 3:42 PM, Raju Bairishetti  wrote:

> +1. Looks good to me
>
> On Wed, Feb 1, 2017 at 5:59 PM, Jean-Baptiste Onofré 
> wrote:
>
> > It looks good to me too.
> >
> > Thanks !
> >
> > Regards
> > JB
> >
> >
> > On 02/01/2017 10:58 AM, Srikanth Sundarrajan wrote:
> >
> >> Report looks fine. Thanks
> >>
> >>
> >> Srikanth Sundarrajan
> >>
> >>
> >> 
> >> From: amareshwarisr . 
> >> Sent: Wednesday, February 1, 2017 3:25 PM
> >> To: dev
> >> Subject: Re: Report for the month of February
> >>
> >> Planning to post the report EOD. Let me know if anyone has comments.
> >>
> >> Thanks
> >>
> >> On Wed, Feb 1, 2017 at 12:44 PM, Rajat Khandelwal <
> rajatgupt...@gmail.com
> >> >
> >> wrote:
> >>
> >> +1
> >>>
> >>> On Wed, Feb 1, 2017 at 11:30 AM Amareshwari Sriramdasu <
> >>> amareshw...@apache.org> wrote:
> >>>
> >>> Hello Lens contributors,
> 
>  Have put up the report for the month here -
>  https://cwiki.apache.org/confluence/display/LENS/February%2C2017.
>  Please
>  review and post your comments.
> 
>  I see this quarter has the least engagement wrt mailing lists, jira
>  activity and commits. More details on putting this up in the report
> will
>  help.
> 
>  ---
>  ## JIRA activity:
> 
>   - 15 JIRA tickets created in the last 3 months
>   - 16 JIRA tickets closed/resolved in the last 3 months
>  ---
>  ## Mailing list activity:
> 
>   - dev@lens.apache.org:
>  - 401 emails sent to list (2402 in previous quarter)
> 
>   - u...@lens.apache.org:
>  - 2 emails sent to list (150 in previous quarter)
>  ---
> 
>  Thanks
>  Amareshwari
> 
> 
> >>>
> >>
> > --
> > Jean-Baptiste Onofré
> > jbono...@apache.org
> > http://blog.nanthrax.net
> > Talend - http://www.talend.com
> >
>
>
>
> --
>
> --
> Thanks,
> Raju Bairishetti,
> www.lazada.com
>

Re: Review Request 55715: Update error message for data completeness check

[Puneet Gupta]

> On Jan. 19, 2017, 2:06 p.m., Puneet Gupta wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java,
> >  line 151
> > <https://reviews.apache.org/r/55715/diff/1/?file=1608971#file1608971line151>
> >
> > Should we say  
> > 
> > "Data for the requested metrics is only partially available. Partially 
> > available metrics are : %s. Please try again later."

Data for the requested metrics is only partially complete. Partially complete 
metrics are : %s. Please try again later or rerun after removing incomplete 
metrics


- Puneet


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55715/#review162281
---


On Jan. 25, 2017, 6:29 a.m., Narayan Periwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55715/
> ---
> 
> (Updated Jan. 25, 2017, 6:29 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1384
> https://issues.apache.org/jira/browse/LENS-1384
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> We can make the error message for the data completeness check less verbose.
> New message can be something like -  Requested metrics are only partially 
> complete. Partially complete metrics: . Try 
> again later or remove metric and re-run report.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  2ad6e20 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> c9e7c29 
> 
> Diff: https://reviews.apache.org/r/55715/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>

Re: Review Request 55715: Update error message for data completeness check

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55715/#review162281
---




lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 (line 151)
<https://reviews.apache.org/r/55715/#comment233618>

Should we say  

"Data for the requested metrics is only partially available. Partially 
available metrics are : %s. Please try again later."



lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
 (line 154)
<https://reviews.apache.org/r/55715/#comment233619>

Are we logging the old more verbose message( metric - time - %completion) 
somewhere ? It would be required for debugging the issue or to answer user 
queries when they pour in .


- Puneet Gupta


On Jan. 19, 2017, 12:25 p.m., Narayan Periwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55715/
> ---
> 
> (Updated Jan. 19, 2017, 12:25 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1384
> https://issues.apache.org/jira/browse/LENS-1384
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> We can make the error message for the data completeness check less verbose.
> New message can be something like -  Requested metrics are only partially 
> complete. Partially complete metrics: . Try 
> again later or remove metric and re-run report.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
>  2ad6e20 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> c9e7c29 
> 
> Diff: https://reviews.apache.org/r/55715/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Narayan Periwal
> 
>

Re: Review Request 54057: LENS-1378 : Fix dimensions to query from DenormalizationResolver for expression fields

[Puneet Gupta]

> On Jan. 16, 2017, 8:37 a.m., Puneet Gupta wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java,
> >  lines 201-202
> > <https://reviews.apache.org/r/54057/diff/2/?file=1570253#file1570253line201>
> >
> > Should we make these datastructures local so that we don't need to 
> > reset them?
> 
> Amareshwari Sriramadasu wrote:
> Not doing this, we it would require a lot changes in existing code.

ok


- Puneet


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54057/#review161186
---


On Nov. 25, 2016, 6:16 a.m., Amareshwari Sriramadasu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54057/
> ---
> 
> (Updated Nov. 25, 2016, 6:16 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1378
> https://issues.apache.org/jira/browse/LENS-1378
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Fix is to add DenormalizationContext for each expression instead of being 
> part of main CubeQueryContext
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  e7fc557 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> e83ae76 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
>  40ed387 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
> 60dacdb 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/QueriedPhraseContext.java 
> 11eb8f7 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeChecker.java 
> 89b50f5 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TrackDenormContext.java 
> PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> 41ea83d 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java
>  f2bb485 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java 
> 6430ed1 
>   tools/conf/server/logback.xml 63ab23c 
> 
> Diff: https://reviews.apache.org/r/54057/diff/
> 
> 
> Testing
> ---
> 
> All cube tests passed
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>

Re: Review Request 54057: LENS-1378 : Fix dimensions to query from DenormalizationResolver for expression fields

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54057/#review161186
---




lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 
(lines 191 - 192)
<https://reviews.apache.org/r/54057/#comment232999>

Should we make these datastructures local so that we don't need to reset 
them?



lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 
(line 355)
<https://reviews.apache.org/r/54057/#comment233000>

Should we call this getNonReachableReferenceFields ?



lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 
(line 395)
<https://reviews.apache.org/r/54057/#comment232603>

Should we call this getORCreateAndGetDeNormCtx ?



lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
(line 284)
<https://reviews.apache.org/r/54057/#comment232998>

Can we add method level comments whereever possible.


- Puneet Gupta


On Nov. 25, 2016, 6:16 a.m., Amareshwari Sriramadasu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54057/
> ---
> 
> (Updated Nov. 25, 2016, 6:16 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1378
> https://issues.apache.org/jira/browse/LENS-1378
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Fix is to add DenormalizationContext for each expression instead of being 
> part of main CubeQueryContext
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  e7fc557 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> e83ae76 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
>  40ed387 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
> 60dacdb 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/QueriedPhraseContext.java 
> 11eb8f7 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeChecker.java 
> 89b50f5 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TrackDenormContext.java 
> PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> 41ea83d 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java
>  f2bb485 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java 
> 6430ed1 
>   tools/conf/server/logback.xml 63ab23c 
> 
> Diff: https://reviews.apache.org/r/54057/diff/
> 
> 
> Testing
> ---
> 
> All cube tests passed
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>

Re: Review Request 54057: LENS-1378 : Fix dimensions to query from DenormalizationResolver for expression fields

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54057/#review161691
---


Ship it!




Ship It!

- Puneet Gupta


On Nov. 25, 2016, 6:16 a.m., Amareshwari Sriramadasu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54057/
> ---
> 
> (Updated Nov. 25, 2016, 6:16 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1378
> https://issues.apache.org/jira/browse/LENS-1378
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Fix is to add DenormalizationContext for each expression instead of being 
> part of main CubeQueryContext
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  e7fc557 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
> e83ae76 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java
>  40ed387 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java 
> 60dacdb 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/QueriedPhraseContext.java 
> 11eb8f7 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeChecker.java 
> 89b50f5 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TrackDenormContext.java 
> PRE-CREATION 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> 41ea83d 
>   
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java
>  f2bb485 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java 
> 6430ed1 
>   tools/conf/server/logback.xml 63ab23c 
> 
> Diff: https://reviews.apache.org/r/54057/diff/
> 
> 
> Testing
> ---
> 
> All cube tests passed
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>

[jira] [Created] (LENS-1382) org.apache.lens.client.LensStatement#getAllQueryDetails is returning wrong result

[Puneet Gupta (JIRA)]

Puneet Gupta created LENS-1382:
--

 Summary: org.apache.lens.client.LensStatement#getAllQueryDetails 
is returning  wrong result
 Key: LENS-1382
 URL: https://issues.apache.org/jira/browse/LENS-1382
 Project: Apache Lens
  Issue Type: Bug
Reporter: Puneet Gupta
Assignee: Puneet Gupta
Priority: Minor


org.apache.lens.client.LensStatement#getAllQueryDetails is returning  
List instead of List 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1379) Session expiry is not working properly

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1379:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Session expiry is not working properly
> --
>
> Key: LENS-1379
> URL: https://issues.apache.org/jira/browse/LENS-1379
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Affects Versions: 2.6
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.7
>
> Attachments: LENS-1379.2.patch
>
>
> We are seeing session expiry is not working properly and found two reasons 
> for the same :
> * isActive method logic is not marking expired sessions as inactive.
> * Upon restart lastAccessTime is getting reset to restore time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1379) Session expiry is not working properly

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15792779#comment-15792779
 ] 

Puneet Gupta commented on LENS-1379:


Committed. Thanks [~amareshwari]

> Session expiry is not working properly
> --
>
> Key: LENS-1379
> URL: https://issues.apache.org/jira/browse/LENS-1379
> Project: Apache Lens
>  Issue Type: Bug
>  Components: server
>Affects Versions: 2.6
>Reporter: Amareshwari Sriramadasu
>Assignee: Amareshwari Sriramadasu
> Fix For: 2.7
>
> Attachments: LENS-1379.2.patch
>
>
> We are seeing session expiry is not working properly and found two reasons 
> for the same :
> * isActive method logic is not marking expired sessions as inactive.
> * Upon restart lastAccessTime is getting reset to restore time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 55077: LENS-1379 : Fix session expiry for sessions in which operations were done

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55077/#review160319
---


Ship it!




Ship It!

- Puneet Gupta


On Dec. 30, 2016, 9:33 a.m., Amareshwari Sriramadasu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55077/
> ---
> 
> (Updated Dec. 30, 2016, 9:33 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1379
> https://issues.apache.org/jira/browse/LENS-1379
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Fixes the logic checking for isActive() on a session
> 
> 
> Diffs
> -
> 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  21e2a62 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> 34c901c 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java
>  8c1bb7b 
> 
> Diff: https://reviews.apache.org/r/55077/diff/
> 
> 
> Testing
> ---
> 
> All server tests pass.
> 
> [INFO] --- maven-surefire-plugin:2.15:test (default-test) @ lens-server ---
> [INFO] Surefire report directory: 
> /Users/amareshwari.sr/workspace/lens/lens-server/target/surefire-reports
> 
> ---
>  T E S T S
> ---
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; 
> support was removed in 8.0
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; 
> support was removed in 8.0
> Running TestSuite
> Tests run: 328, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1,243.282 
> sec - in TestSuite
> 
> Results :
> 
> Tests run: 328, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>

Re: Review Request 55077: LENS-1379 : Fix session expiry for sessions in which operations were done

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55077/#review160270
---


Ship it!




Ship It!

- Puneet Gupta


On Dec. 29, 2016, 6:39 a.m., Amareshwari Sriramadasu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55077/
> ---
> 
> (Updated Dec. 29, 2016, 6:39 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1379
> https://issues.apache.org/jira/browse/LENS-1379
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Fixes the logic checking for isActive() on a session
> 
> 
> Diffs
> -
> 
>   
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java
>  21e2a62 
>   
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 
> 34c901c 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java
>  8c1bb7b 
> 
> Diff: https://reviews.apache.org/r/55077/diff/
> 
> 
> Testing
> ---
> 
> All server tests pass.
> 
> [INFO] --- maven-surefire-plugin:2.15:test (default-test) @ lens-server ---
> [INFO] Surefire report directory: 
> /Users/amareshwari.sr/workspace/lens/lens-server/target/surefire-reports
> 
> ---
>  T E S T S
> ---
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; 
> support was removed in 8.0
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; 
> support was removed in 8.0
> Running TestSuite
> Tests run: 328, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1,243.282 
> sec - in TestSuite
> 
> Results :
> 
> Tests run: 328, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>

[jira] [Commented] (LENS-1381) Support Fact to Fact Union

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15766896#comment-15766896
 ] 

Puneet Gupta commented on LENS-1381:


Created branch for initial changes 
refs/heads/lens-1381 [created] b6f0cc3d4

> Support Fact to Fact Union
> --
>
> Key: LENS-1381
> URL: https://issues.apache.org/jira/browse/LENS-1381
> Project: Apache Lens
>  Issue Type: New Feature
>    Reporter: Puneet Gupta
>    Assignee: Puneet Gupta
>
> Currently Lens supports Union-ing data across different storages in a single 
> Fact. With this JIRA Lens server will be able to Union Data Across Facts too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1381) Support Fact to Fact Union

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743976#comment-15743976
 ] 

Puneet Gupta commented on LENS-1381:


We are planning to create a feature branch for this since there will be lots of 
changes in the code. 

> Support Fact to Fact Union
> --
>
> Key: LENS-1381
> URL: https://issues.apache.org/jira/browse/LENS-1381
> Project: Apache Lens
>  Issue Type: New Feature
>    Reporter: Puneet Gupta
>    Assignee: Puneet Gupta
>
> Currently Lens supports Union-ing data across different storages in a single 
> Fact. With this JIRA Lens server will be able to Union Data Across Facts too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (LENS-1381) Support Fact to Fact Union

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta reassigned LENS-1381:
--

Assignee: Puneet Gupta

> Support Fact to Fact Union
> --
>
> Key: LENS-1381
> URL: https://issues.apache.org/jira/browse/LENS-1381
> Project: Apache Lens
>  Issue Type: New Feature
>    Reporter: Puneet Gupta
>    Assignee: Puneet Gupta
>
> Currently Lens supports Union-ing data across different storages in a single 
> Fact. With this JIRA Lens server will be able to Union Data Across Facts too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1381) Support Fact to Fact Union

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743967#comment-15743967
 ] 

Puneet Gupta commented on LENS-1381:


Design for this requirement :

*Current rewrite flow*
- Currently the rewrite flow relies on Set and 
Set<Set> which represents the participating Facts and 
combination of Facts(in case of join between 2 or more facts) that can answer 
the user query respectively.  

- Set is initially populated considering all the Facts will 
participate and the Set<Set> is created based on joins that are 
required to answer the query (with assumption that two two facts can be joined 
if they have the dimensions that are being queried by the user. After joining 
the facts, the queried measures which are split across facts are picked). Along 
the rewrite flow the above data structures are pruned based on column 
availability, data availability, storage validity, fact validity, cost,etc. In 
the last a final CandidateFact combination is picked from  
Set<Set>. 

- To write the rewritten query for the picked candidate combination, one of the 
following contexts are created 
-- SingleFactSingleStorageHQLContext or (Candidate combination has single fact 
and single storage)
-- SingleFactMultiStorageHQLContext or (Candidate combination has single fact 
and multiple storages within that fact  - Union Query)
-- MultiFactHQLContext  (Candidate combination has multiple facts - Join Query)

*New Flow*
# The new flow will work at Storage level and will use a list of 
StorageCandidates. Initially all Storages are candidates. 
# The list of StorageCandidates is pruned based on column availability, storage 
validity, fact validity, update period validity,etc
# The StorageCandidates are then grouped to ensure that a group can cover the 
entire time range queried by the user. Its possible for a group to have a 
single StorageCandidate incase this storage alone can fulfill the time ranges 
queried. If a group has more that one storages , then this group is represented 
as a UnionCandidate. 
# The groups created in step 3 ( UnionCandidates and StorageCandidates) are 
used to find a measure covering group such that members of this group cover all 
the measures queried by the user. Again its possible for this group to have a 
single member (which can be a StorageCandidate or a UnionCandidate) that can 
answer all the measures. If the group has more than one members, then  that 
group is represented as a JoinCandidate
# JoinCandidate, UnionCandidate and  StorageCandidate extend the same Candidate 
Interface. 
# The groups created in step 4 are further pruned based on data availability, 
cost ,etc  we pick a winning group (Candidate) 
# Query is then written for this winning Candidate


 



> Support Fact to Fact Union
> --
>
> Key: LENS-1381
> URL: https://issues.apache.org/jira/browse/LENS-1381
> Project: Apache Lens
>  Issue Type: New Feature
>Reporter: Puneet Gupta
>
> Currently Lens supports Union-ing data across different storages in a single 
> Fact. With this JIRA Lens server will be able to Union Data Across Facts too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (LENS-1381) Support Fact to Fact Union

[Puneet Gupta (JIRA)]

Puneet Gupta created LENS-1381:
--

 Summary: Support Fact to Fact Union
 Key: LENS-1381
 URL: https://issues.apache.org/jira/browse/LENS-1381
 Project: Apache Lens
  Issue Type: New Feature
Reporter: Puneet Gupta


Currently Lens supports Union-ing data across different storages in a single 
Fact. With this JIRA Lens server will be able to Union Data Across Facts too.





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 53835: LENS-1377 : Optimize measure covering set to exclude fact covering all measures in other combinations

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53835/#review156196
---


Ship it!




Ship It!

- Puneet Gupta


On Nov. 17, 2016, 4:20 a.m., Amareshwari Sriramadasu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53835/
> ---
> 
> (Updated Nov. 17, 2016, 4:20 a.m.)
> 
> 
> Review request for lens and Puneet Gupta.
> 
> 
> Bugs: LENS-1377
> https://issues.apache.org/jira/browse/LENS-1377
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Finding measure covering set is including facts which cover all measures in 
> other fact combinations as well, which can be removed.
> 
> 
> Diffs
> -
> 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  510bd8c 
> 
> Diff: https://reviews.apache.org/r/53835/diff/
> 
> 
> Testing
> ---
> 
> All cube tests passed :
> ---
>  T E S T S
> ---
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; 
> support was removed in 8.0
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; 
> support was removed in 8.0
> Running TestSuite
> Tests run: 418, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1,135.432 
> sec - in TestSuite
> 
> Results :
> 
> Tests run: 418, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> Thanks,
> 
> Amareshwari Sriramadasu
> 
>

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51964/#review156012
---




lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (line 52)
<https://reviews.apache.org/r/51964/#comment226164>

classLoaderCache needs to be updated on addDBJar.



lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (line 114)
<https://reviews.apache.org/r/51964/#comment226142>

This method should be private .



lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (lines 265 - 268)
<https://reviews.apache.org/r/51964/#comment226143>

This method should be private



lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (lines 408 - 414)
<https://reviews.apache.org/r/51964/#comment226136>

Should we decide which map to use based on mode (local/hdfs or remote ) 
which is decided on startup



lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (line 416)
<https://reviews.apache.org/r/51964/#comment226145>

addremoteDbResourceEntry and addLocalDbResourceEntry can be private . 
We can also decide and remove these methods and directly add map entries in 
calling code.



lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (line 420)
<https://reviews.apache.org/r/51964/#comment226111>

Should we call this method updateLocalDBResourceEntries since its replacing 
all the entries for the DB ?

Simlaraly updateRemoteDbResourceEntries too



lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (line 434)
<https://reviews.apache.org/r/51964/#comment226165>

QueryExecutionServiceImpl#addSessionResourcesToDriver needs to remove old 
jars added to the hive sessions and add the newly uploaded jar to it (there is 
one hive session per User and per DB. Only the current DB sessions should get 
affected)

This implies that there is no guarantee on success of currently running 
queries on the affected Hive sessions



lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (line 436)
<https://reviews.apache.org/r/51964/#comment226095>

Should we also add DB name to this log ?



lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (line 476)
<https://reviews.apache.org/r/51964/#comment226108>

jarFilePath has the complete path for the jar file. Do we need currentDB 
and baseDir ?



lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (line 484)
<https://reviews.apache.org/r/51964/#comment226132>

should we check the status of this opeartion and throw exception in case of 
failure.



lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (line 505)
<https://reviews.apache.org/r/51964/#comment226096>

should we resuse FileSystem created while starting the service ? This can 
be done for all FieSystem.newInstance calls in this method



lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (line 508)
<https://reviews.apache.org/r/51964/#comment226098>

should we also check the boolean value returned by this call and proceed 
accrodingly



lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (line 522)
<https://reviews.apache.org/r/51964/#comment226101>

Should we use FileSystem.delete(path,false) instead  and check the boolean 
value returned by this call before proceeding further?



lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (line 535)
<https://reviews.apache.org/r/51964/#comment226135>

Should we INFO log that jar uploaded to {path}


- Puneet Gupta


On Nov. 8, 2016, 10:18 a.m., Sushil Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51964/
> ---
> 
> (Updated Nov. 8, 2016, 10:18 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-317
> https://issues.apache.org/jira/browse/LENS-317
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Server side api call to update database jar without restarting lens server. 
> More details can be found in LENS-317.
> 
> 
> Diffs
> -
> 
>   lens-cli/pom.xml 8e5e3eb 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/LensDatabaseCommands.java 
> c6ae02b 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensDat

Re: Review Request 51964: LENS-317: Server side calls for updating database jars

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51964/#review155416
---




lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
(lines 837 - 849)
<https://reviews.apache.org/r/51964/#comment225885>

Should we add the new properties to default lens server config file along 
with the description on how and when to use them?



lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (line 84)
<https://reviews.apache.org/r/51964/#comment225881>

[Suggestion] Should we simplify this method by assuming there will be only 
one level of folders under the base resource directory ?

If we use this knowledge we can sync one DB at a time and paring the urls 
may not be required.



lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (line 87)
<https://reviews.apache.org/r/51964/#comment225769>

Can we reuse "dbResourceFs" ?



lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (lines 97 - 109)
<https://reviews.apache.org/r/51964/#comment225886>

Can we add log entries when jars are downloaded



lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (line 143)
<https://reviews.apache.org/r/51964/#comment225349>

This needs to be moved to end so that service state is changed to STARTED 
in the end . 
org.apache.hive.service.AbstractService#start



lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (lines 157 - 159)
<https://reviews.apache.org/r/51964/#comment225350>

What will happen in case the scheme is not hdfs? 
Will the flow work gracefully or throw an execption



lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (lines 161 - 163)
<https://reviews.apache.org/r/51964/#comment225890>

What do we do for use cases where the user does not need any DB resources ? 
In those cases it may not be an ERROR to not have top resource directory



lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (lines 193 - 194)
<https://reviews.apache.org/r/51964/#comment225888>

Can we set dbLocalResTopDir to dbResTopDir when dbResTopDir is local path. 
This check would not be required then. 

OR

If needed we can also store the mode in start method as a boolean 
(local/hdfs) locally and use it in mapCommonResourceEntries(boolean mode) and 
mapDbResourceEntries(boolean mode)



lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (lines 210 - 211)
<https://reviews.apache.org/r/51964/#comment225893>

This will never be true since the DB path is got by listing the base 
directory.



lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (line 231)
<https://reviews.apache.org/r/51964/#comment225889>

Can we create the loacl fileSystem object only once (may be in start() 
method and) use it elsewhere as hadoop FileSystem object is a heavy and 
mainatins state/cache inside it.



lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (lines 233 - 237)
<https://reviews.apache.org/r/51964/#comment225892>

Isn't this condition already checked in the calling method ?



lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (line 265)
<https://reviews.apache.org/r/51964/#comment225984>

Can we just retun the jar path/name or null in case there is no jar in the 
folder and shouldIncrVersion = false



lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (line 272)
<https://reviews.apache.org/r/51964/#comment225980>

Can we reuase FileSystem instance here too ?



lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (line 278)
<https://reviews.apache.org/r/51964/#comment225981>

Should this be >=1 ?



lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java
 (line 446)
<https://reviews.apache.org/r/51964/#comment225985>

Should we use LensConfConstants.DB_RESOURCE_COPY_FROM_HDFS property to 
figure out HDFS vs Local ? 

We can rename the property to DB_RESOURCES_IN_HDFS = true/false?


This review only covers the startup flow. addDBJar Flow Review is pending, will 
review it soon.

- Puneet Gupta


On Nov. 8, 2016, 10:18 a.m., Sushil Mohanty wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51964/
> ---
> 
> (Up

[jira] [Commented] (LENS-1359) Add driver hooks for user based filtering of queries

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15662838#comment-15662838
 ] 

Puneet Gupta commented on LENS-1359:


Committed. Thanks [~prongs]

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>  Labels: incompatible
> Fix For: 2.7
>
> Attachments: LENS-1359.01.patch, LENS-1359.02.patch, 
> LENS-1359.03.patch, LENS-1359.04.patch, LENS-1359.05.patch, 
> LENS-1359.06.patch, LENS-1359.07.patch, LENS-1359.08.patch, 
> LENS-1359.09.patch, LENS-1359.10.patch, LENS-1359.11.patch, 
> LENS-1359.12.patch, LENS-1359.13.patch, LENS-1359.14.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1359) Add driver hooks for user based filtering of queries

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1359:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>  Labels: incompatible
> Fix For: 2.7
>
> Attachments: LENS-1359.01.patch, LENS-1359.02.patch, 
> LENS-1359.03.patch, LENS-1359.04.patch, LENS-1359.05.patch, 
> LENS-1359.06.patch, LENS-1359.07.patch, LENS-1359.08.patch, 
> LENS-1359.09.patch, LENS-1359.10.patch, LENS-1359.11.patch, 
> LENS-1359.12.patch, LENS-1359.13.patch, LENS-1359.14.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1359) Add driver hooks for user based filtering of queries

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1359:
---
Fix Version/s: 2.7

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>  Labels: incompatible
> Fix For: 2.7
>
> Attachments: LENS-1359.01.patch, LENS-1359.02.patch, 
> LENS-1359.03.patch, LENS-1359.04.patch, LENS-1359.05.patch, 
> LENS-1359.06.patch, LENS-1359.07.patch, LENS-1359.08.patch, 
> LENS-1359.09.patch, LENS-1359.10.patch, LENS-1359.11.patch, 
> LENS-1359.12.patch, LENS-1359.13.patch, LENS-1359.14.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1359) Add driver hooks for user based filtering of queries

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15650700#comment-15650700
 ] 

Puneet Gupta commented on LENS-1359:


Patch doesn't cleanly apply. Please sync with latest and update

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>  Labels: incompatible
> Attachments: LENS-1359.01.patch, LENS-1359.02.patch, 
> LENS-1359.03.patch, LENS-1359.04.patch, LENS-1359.05.patch, 
> LENS-1359.06.patch, LENS-1359.07.patch, LENS-1359.08.patch, 
> LENS-1359.09.patch, LENS-1359.10.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1359) Add driver hooks for user based filtering of queries

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1359:
---
Status: Open  (was: Patch Available)

> Add driver hooks for user based filtering of queries
> 
>
> Key: LENS-1359
> URL: https://issues.apache.org/jira/browse/LENS-1359
> Project: Apache Lens
>  Issue Type: Task
>Reporter: Rajat Khandelwal
>Assignee: Rajat Khandelwal
>  Labels: incompatible
> Attachments: LENS-1359.01.patch, LENS-1359.02.patch, 
> LENS-1359.03.patch, LENS-1359.04.patch, LENS-1359.05.patch, 
> LENS-1359.06.patch, LENS-1359.07.patch, LENS-1359.08.patch, 
> LENS-1359.09.patch, LENS-1359.10.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: November 2016 report

[Puneet Gupta]

+1

Thanks,
Puneet Gupta

On Wed, Nov 9, 2016 at 11:06 AM, Amareshwari Sriramdasu <
amareshw...@apache.org> wrote:

> Hello Lens dev,
>
> Have put up report for November month at
> https://cwiki.apache.org/confluence/display/LENS/November%2C2016.
>
> Please review and let me know your comments.
>
> Will post the report to board EOD.
>
> Thanks
> Amareshwari
>

-- 
_
The information contained in this communication is intended solely for the 
use of the individual or entity to whom it is addressed and others 
authorized to receive it. It may contain confidential or legally privileged 
information. If you are not the intended recipient you are hereby notified 
that any disclosure, copying, distribution or taking any action in reliance 
on the contents of this information is strictly prohibited and may be 
unlawful. If you have received this communication in error, please notify 
us immediately by responding to this email and then delete it from your 
system. The firm is neither liable for the proper and complete transmission 
of the information contained in this communication nor for any delay in its 
receipt.

[jira] [Commented] (LENS-1342) Unclosed InputStreamReader in PropertyBasedUserConfigLoader

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15628238#comment-15628238
 ] 

Puneet Gupta commented on LENS-1342:


Resubmitting to check failures 
https://builds.apache.org/job/PreCommit-Lens-Build/1143/

> Unclosed InputStreamReader in PropertyBasedUserConfigLoader
> ---
>
> Key: LENS-1342
> URL: https://issues.apache.org/jira/browse/LENS-1342
> Project: Apache Lens
>  Issue Type: Bug
>Reporter: Ted Yu
>Priority: Minor
> Attachments: 1342.v1.txt
>
>
> {code}
> try {
>   properties.load(new InputStreamReader(new FileInputStream(new 
> File(filename)), "UTF-8"));
> } catch (IOException e) {
>   throw new UserConfigLoaderException("property file not found. Provided 
> path was: " + filename);
> }
> {code}
> The InputStreamReader should be closed upon return from the method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 53217: LENS-968 : Timeout long running queries

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53217/#review154118
---




lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 
(line 1180)
<https://reviews.apache.org/r/53217/#comment223620>

should we call this "query.expiry.check.interval.millis"



lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 (line 1636)
<https://reviews.apache.org/r/53217/#comment224089>

The log message needs to be updated for time unit.



lens-server/src/main/resources/lensserver-default.xml (line 296)
<https://reviews.apache.org/r/53217/#comment224090>

We might need a smaller default check interval if in most cases "query 
lens.query.timeout.millis" is very small.


- Puneet Gupta


On Oct. 27, 2016, 9:04 a.m., Amareshwari Sriramadasu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53217/
> ---
> 
> (Updated Oct. 27, 2016, 9:04 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-968
> https://issues.apache.org/jira/browse/LENS-968
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> Adds configurable timeout for queries, which is overridable at driver level 
> and even at query level.
> Adds a period checker which checks if any of queries timedout and canel them.
> 
> 
> Diffs
> -
> 
>   lens-driver-es/src/main/resources/esdriver-default.xml 5bd56b3 
>   lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 89726c4 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  3ae59c6 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  64c7145 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java
>  2a2963f 
>   
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
>  b5e996f 
>   lens-server/src/main/resources/lensserver-default.xml 8e5fe8a 
>   lens-server/src/main/resources/lenssession-default.xml 9a8f9da 
>   
> lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java
>  5a8d5e6 
>   
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
> ecbd689 
>   lens-server/src/test/resources/lens-site.xml d96659f 
>   lens-server/src/test/resources/logback.xml 6b91a77 
>   src/site/apt/admin/config.apt f22fc0c 
>   src/site/apt/admin/esdriver-config.apt ce952ae 
>   src/site/apt/admin/jdbcdriver-config.apt c64d6ee 
>   src/site/apt/admin/session-config.apt d480f88 
> 
> Diff: https://reviews.apache.org/r/53217/diff/
> 
> 
> Testing
> ---
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules . SUCCESS [1.484s]
> [INFO] Lens .. SUCCESS [2.843s]
> [INFO] Lens API .. SUCCESS [21.049s]
> [INFO] Lens API for server and extensions  SUCCESS [19.230s]
> [INFO] Lens Cube . SUCCESS 
> [14:06.805s]
> [INFO] Lens DB storage ... SUCCESS [16.439s]
> [INFO] Lens Query Library  SUCCESS [12.739s]
> [INFO] Lens Hive Driver .. SUCCESS [1:15.184s]
> [INFO] Lens Driver for JDBC .. SUCCESS [39.351s]
> [INFO] Lens Elastic Search Driver  SUCCESS [19.958s]
> [INFO] Lens Server ... SUCCESS 
> [16:28.932s]
> [INFO] Lens client ... SUCCESS [1:21.876s]
> [INFO] Lens CLI .. SUCCESS [1:12.501s]
> [INFO] Lens Examples . SUCCESS [8.167s]
> [INFO] Lens Ship Jars to Distributed Cache ... SUCCESS [0.618s]
> [INFO] Lens Distribution . SUCCESS [8.981s]
> [INFO] Lens ML Lib ... SUCCESS [1:02.132s]
> [INFO] Lens ML Ext Distribution .. SUCCESS [2.106s]
> [INFO] Lens Regression ... SUCCESS [12.315s]
> [INFO] Lens UI ... SUCCESS [30.001s]
> [INFO] Lens Contrib .

[jira] [Resolved] (LENS-1310) Release Lens 2.6

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta resolved LENS-1310.

   Resolution: Fixed
Fix Version/s: 2.6

> Release Lens 2.6
> 
>
> Key: LENS-1310
> URL: https://issues.apache.org/jira/browse/LENS-1310
> Project: Apache Lens
>  Issue Type: Task
>  Components: build
>    Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.6
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1363) Error While building Lens Site

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1363:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Error While building Lens Site
> --
>
> Key: LENS-1363
> URL: https://issues.apache.org/jira/browse/LENS-1363
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: build
>    Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.7
>
> Attachments: lens-1363.patch
>
>
> 1. The output of enunciate had changed after upgrading it. 
> Need to update tools/scripts/generate-site-public.sh accordingly. 
> 2. Download links are pointing to lens 2.6. Need to change to point to 2.6.1
> 3. Roles need to be updated in pom.xml for two team members 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1363) Error While building Lens Site

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1363:
---
Fix Version/s: 2.7

> Error While building Lens Site
> --
>
> Key: LENS-1363
> URL: https://issues.apache.org/jira/browse/LENS-1363
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: build
>    Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.7
>
> Attachments: lens-1363.patch
>
>
> 1. The output of enunciate had changed after upgrading it. 
> Need to update tools/scripts/generate-site-public.sh accordingly. 
> 2. Download links are pointing to lens 2.6. Need to change to point to 2.6.1
> 3. Roles need to be updated in pom.xml for two team members 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (LENS-1363) Error While building Lens Site

[Puneet Gupta (JIRA)]

[ 
https://issues.apache.org/jira/browse/LENS-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15607539#comment-15607539
 ] 

Puneet Gupta commented on LENS-1363:


Committed myself.

> Error While building Lens Site
> --
>
> Key: LENS-1363
> URL: https://issues.apache.org/jira/browse/LENS-1363
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: build
>    Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.7
>
> Attachments: lens-1363.patch
>
>
> 1. The output of enunciate had changed after upgrading it. 
> Need to update tools/scripts/generate-site-public.sh accordingly. 
> 2. Download links are pointing to lens 2.6. Need to change to point to 2.6.1
> 3. Roles need to be updated in pom.xml for two team members 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[ANNOUNCE] Apache Lens 2.6.1 release

[Puneet Gupta]

Hi All,

The Apache Lens team is proud to announce the release of Apache Lens 2.6.1.
This is the first GA release which supports Hive 2.

Apache Lens provides an Unified Analytics interface. Lens aims to cut the
Data Analytics silos by providing a single view of data across multiple
tiered data stores and optimal execution environment for the analytical
query. It seamlessly integrates Hadoop with traditional data warehouses to
appear like one.


More details on Apache Lens can be found at
http://lens.apache.org/

Getting started available at
http://lens.apache.org/lenshome/quick-start.html

For quick ramp-up, you can watch a video at
http://cwiki.apache.org/confluence/display/LENS/2015/07/13/20+Minute+video+demo+of+Apache+Lens+through+examples

How to for Contributors available at
http://lens.apache.org/developer/contribute.html

The release artifacts are downloadable from
http://lens.apache.org/releases/download.html

Maven jar artifacts have also been made available on
https://repository.apache.org/content/repositories/releases/org/apache/lens

Release notes available at
https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12333846==12315923

We would like to thank all the contributors who made this release possible.


Regards,
Puneet Gupta

[jira] [Updated] (LENS-1363) Error While building Lens Site

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1363:
---
Description: 
1. The output of enunciate had changed after upgrading it. 
Need to update tools/scripts/generate-site-public.sh accordingly. 

2. Download links are pointing to lens 2.6. Need to change to point to 2.6.1

3. Roles need to be updated in pom.xml for two team members 

  was:
The output of enunciate had changed after upgrading it. 
Need to update tools/scripts/generate-site-public.sh accordingly. 


> Error While building Lens Site
> --
>
> Key: LENS-1363
> URL: https://issues.apache.org/jira/browse/LENS-1363
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: build
>    Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Attachments: lens-1363.patch
>
>
> 1. The output of enunciate had changed after upgrading it. 
> Need to update tools/scripts/generate-site-public.sh accordingly. 
> 2. Download links are pointing to lens 2.6. Need to change to point to 2.6.1
> 3. Roles need to be updated in pom.xml for two team members 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1363) Error While building Lens Site

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1363:
---
Status: Patch Available  (was: Open)

Small Change. Attaching patch directly for review

> Error While building Lens Site
> --
>
> Key: LENS-1363
> URL: https://issues.apache.org/jira/browse/LENS-1363
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: build
>    Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Attachments: lens-1363.patch
>
>
> The output of enunciate had changed after upgrading it. 
> Need to update tools/scripts/generate-site-public.sh accordingly. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1363) Error While building Lens Site

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1363:
---
Attachment: lens-1363.patch

> Error While building Lens Site
> --
>
> Key: LENS-1363
> URL: https://issues.apache.org/jira/browse/LENS-1363
> Project: Apache Lens
>  Issue Type: Sub-task
>  Components: build
>    Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Attachments: lens-1363.patch
>
>
> The output of enunciate had changed after upgrading it. 
> Need to update tools/scripts/generate-site-public.sh accordingly. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1365) REST Api docs generated via enunciate plugin 2.5 has two entries for JSON data type

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1365:
---
Description: See attached images

> REST Api docs generated via enunciate plugin 2.5 has two entries for JSON 
> data type
> ---
>
> Key: LENS-1365
> URL: https://issues.apache.org/jira/browse/LENS-1365
> Project: Apache Lens
>  Issue Type: Bug
>    Reporter: Puneet Gupta
> Attachments: screenshot-1.png, screenshot-2.png
>
>
> See attached images



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1365) REST Api docs generated via enunciate plugin 2.5 has two entries for JSON data type

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1365:
---
Attachment: screenshot-2.png

> REST Api docs generated via enunciate plugin 2.5 has two entries for JSON 
> data type
> ---
>
> Key: LENS-1365
> URL: https://issues.apache.org/jira/browse/LENS-1365
> Project: Apache Lens
>  Issue Type: Bug
>    Reporter: Puneet Gupta
> Attachments: screenshot-1.png, screenshot-2.png
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (LENS-1365) REST Api docs generated via enunciate plugin 2.5 has two entries for JSON data type

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1365:
---
Attachment: screenshot-1.png

> REST Api docs generated via enunciate plugin 2.5 has two entries for JSON 
> data type
> ---
>
> Key: LENS-1365
> URL: https://issues.apache.org/jira/browse/LENS-1365
> Project: Apache Lens
>  Issue Type: Bug
>    Reporter: Puneet Gupta
> Attachments: screenshot-1.png, screenshot-2.png
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (LENS-1365) REST Api docs generated via enunciate plugin 2.5 has two entries for JSON data type

[Puneet Gupta (JIRA)]

Puneet Gupta created LENS-1365:
--

 Summary: REST Api docs generated via enunciate plugin 2.5 has two 
entries for JSON data type
 Key: LENS-1365
 URL: https://issues.apache.org/jira/browse/LENS-1365
 Project: Apache Lens
  Issue Type: Bug
Reporter: Puneet Gupta






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (LENS-1363) Error While building Lens Site

[Puneet Gupta (JIRA)]

Puneet Gupta created LENS-1363:
--

 Summary: Error While building Lens Site
 Key: LENS-1363
 URL: https://issues.apache.org/jira/browse/LENS-1363
 Project: Apache Lens
  Issue Type: Sub-task
Reporter: Puneet Gupta
Assignee: Puneet Gupta


The output of enunciate had changed after upgrading it. 
Need to update tools/scripts/generate-site-public.sh accordingly. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: Review Request 52924: LENS-1359: Add driver hooks for user based filtering of queries

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/#review153518
---


Ship it!




Ship It!

- Puneet Gupta


On Oct. 19, 2016, 12:06 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52924/
> ---
> 
> (Updated Oct. 19, 2016, 12:06 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1359
> https://issues.apache.org/jira/browse/LENS-1359
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/parse/Parser.java PRE-CREATION 
>   lens-driver-hive/src/main/resources/hivedriver-default.xml 
> f5fd3bb20b9d6b82292c4483d860ea14c8104c5c 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
>  43b33f331f4d9017d76bccbe0f6936aaeb184f8f 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java
>  961ec4ec781d3d7fd0f28edc4f23e9b39549592f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  3ae59c6ca126f0a3535974352adf97e7a495838f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
>  8f30aa06ab234cedb53acb17544210ba4190ab53 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java
>  69a1a0b7ce57c24602a17ea7c97c0664a77c6568 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java
>  f8a9ee07d8c8b737a41de339ab44ca7752c90748 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java
>  146223942d05cfd952599297144e2a6bc02df273 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java
>  4f1f2eb99ed0bec8e6e471a9723a6b002a092202 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java
>  476855021288ff0d91762d240cb04c8aea9d302b 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java
>  4712f11e94f93d34b71f4f3ddb7c19af003d9fca 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHookTest.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHookTest.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java
>  f70979abf7c44d3b4ed3588628de5a7517adfa81 
>   lens-server/src/main/resources/lensserver-default.xml 
> 8e5fe8a2b7f9ddfcadef104189b89c40ca1b3df6 
>   pom.xml 4928c1fa840fc51e4383ed4803f94102aa833221 
>   src/site/apt/admin/config.apt f22fc0c36f53fa7227dc990c58a079e66630a2a1 
>   src/site/apt/admin/hivedriver-config.apt 
> b1a25c3b5bb58fc2d0773dc168c110ee5e60c635 
> 
> Diff: https://reviews.apache.org/r/52924/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

[RESULT][VOTE] Release of Apache Lens 2.6.1

[Puneet Gupta]

Hi all,

Thanks for taking time to validate the release candidate and
vote. Voting is closed now.

Vote has passed with 4 [+1] votes and no [0] or [-1] votes.

+1 votes:
Raju Bairishetti
Amareshwari Sriramadasu
Puneet Gupta
Rajat Khandelwal

Archana H(non-binding)


+0 No votes

-1 No votes

Vote thread:
http://mail-archives.apache.org/mod_mbox/lens-dev/201609.mbox/%3cCAFNbQoWXa7xbBinLWXZcSAziRU0a=49rk_tp+_yjookvkot...@mail.gmail.com%3e


I will proceed to next set of steps for the release.


Regards,
Puneet Gupta

Re: [VOTE] Release of Apache Lens 2.6.1

[Puneet Gupta]

Was able to run all 151 the examples with apache-hive-2.1.0 (HIVE_HOME//lib/*
jars were linked to HADOOP_HOME/share/hadoop/common/lib)

Successful queries 151 out of 151queries
Total time for running examples(in millis) :945103



On Thu, Sep 29, 2016 at 7:17 PM, archana h  wrote:

> Build  : Successful.
> Example queries : Successful queries 47 out of 151 queries.
> Regression tests had all passed. (apart from few known bugs)
>
>  +1 from my side for release.
>
>
> On Thu, Sep 29, 2016 at 6:18 PM, Rajat Khandelwal 
> wrote:
>
> > Build passed.
> > Tried running examples, and got errors as Amareshwari mentioned.
> >
> > Won't block release for this, +1 from my side for releasing.
> >
>

Re: Review Request 52924: LENS-1359: Add driver hooks for user based filtering of queries

[Puneet Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52924/#review153254
---




lens-driver-hive/src/main/resources/hivedriver-default.xml (line 38)
<https://reviews.apache.org/r/52924/#comment222531>





lens-driver-hive/src/main/resources/hivedriver-default.xml (line 38)
<https://reviews.apache.org/r/52924/#comment222532>

We can stop supporting the old property "lens.driver.hive.query.hook.class" 
since we are chnaging the package anyway (incomptible change)



lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java
 (line 22)
<https://reviews.apache.org/r/52924/#comment222536>

Package change is an incompatible change for people implementing their 
hooks. Can we leave and comment of JIRA and also tag it incompatible



lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHook.java
 (line 36)
<https://reviews.apache.org/r/52924/#comment222537>

Comment needs update.



lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHook.java
 (line 131)
<https://reviews.apache.org/r/52924/#comment222540>

This  should be the driver that created this hook (and not selected driver)



lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java
 (line 74)
<https://reviews.apache.org/r/52924/#comment222545>

Can we move the  parser to non error package ?


- Puneet Gupta


On Oct. 18, 2016, 2:35 p.m., Rajat Khandelwal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52924/
> ---
> 
> (Updated Oct. 18, 2016, 2:35 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1359
> https://issues.apache.org/jira/browse/LENS-1359
> 
> 
> Repository: lens
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   lens-api/src/main/java/org/apache/lens/api/error/parse/Parser.java 
> PRE-CREATION 
>   lens-driver-hive/src/main/resources/hivedriver-default.xml 
> f5fd3bb20b9d6b82292c4483d860ea14c8104c5c 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java
>  43b33f331f4d9017d76bccbe0f6936aaeb184f8f 
>   
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java
>  961ec4ec781d3d7fd0f28edc4f23e9b39549592f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  3ae59c6ca126f0a3535974352adf97e7a495838f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
>  8f30aa06ab234cedb53acb17544210ba4190ab53 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java
>  69a1a0b7ce57c24602a17ea7c97c0664a77c6568 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java
>  f8a9ee07d8c8b737a41de339ab44ca7752c90748 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java
>  146223942d05cfd952599297144e2a6bc02df273 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java
>  4f1f2eb99ed0bec8e6e471a9723a6b002a092202 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java
>  PRE-CREATION 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java
>  476855021288ff0d91762d240cb04c8aea9d302b 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java
>  4712f11e94f93d34b71f4f3ddb7c19af003d9fca 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHookTest.java
>  PRE-CREATION 
>   
> lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHookTest.java
>  PRE-CREATION 
>   
> lens-se

[jira] [Updated] (LENS-1325) Support encoded urls for query HTTP notifications

[Puneet Gupta (JIRA)]

 [ 
https://issues.apache.org/jira/browse/LENS-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Puneet Gupta updated LENS-1325:
---
Attachment: lens-1325.v2.patch

> Support encoded urls for query HTTP notifications
> -
>
> Key: LENS-1325
> URL: https://issues.apache.org/jira/browse/LENS-1325
> Project: Apache Lens
>  Issue Type: Improvement
>  Components: server
>    Reporter: Puneet Gupta
>Assignee: Puneet Gupta
> Fix For: 2.7
>
> Attachments: lens-1325.v2.patch
>
>
> This notification url is working : 
> http://x:8000/v1/data/?access_token=ABC123
> This is giving 400 bad request : 
> http://:8000/v1/data/?access_token=ABC123=xyz
> Please check.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)