Re: Follow-Up: ORB Dependencies and Java 11

[David Blevins]

Good discussion with great questions.  A couple updates/points:

 - Jakarta EE 9 has entirely removed requirements and tests for CORBA/ORB 
support (resolved and executed)

 - Java 11 may or may not stay as the target jvm version for Jakarta EE 9 (new 
discussion 
https://www.eclipse.org/lists/jakartaee-spec-project-leads/msg00600.html)

 - TomEE 8x being the master branch, we have some stability limitations on 
removing/adding major features

Here's where I think that pushes us.

CORBA/ORB

We probably don't want to be adding CORBA support.  We maybe could have gotten 
some small benefit 10 years ago when it would have allowed us to pursue Java EE 
Full Profile certification, but with it being dropped by the JDK and Jakarta 
platform we'd be setting ourselves up to have to carry a ton of weight.

That brings us remove vs maintain, which really becomes a stability question 
linked to the fact that TomEE 8.0.x is living in master.  We might want to 
explore ways to support the very limited ties we have without a compile time 
dependency: reflection; move that to another jar released separately and just 
import it; generate a class or two with ASM (we do this to support Hibernate 
due to LGPL restrictions).

Open to ideas.


JAVA 11

We almost certainly would not be able to drop Java 8 support between TomEE 
8.0.2 and the coming 8.0.3.  More than likely we'd have to compile on Java 8 
and then run the TCK tests on both Java 8 and Java 11 to verify all works.  
What that means is any support for Java 11 in the build itself is likely 
nice-to-have.

This might become even less of a discussion if Java 8 becomes the primary java 
version for Jakarta EE 9, instead of simply being optional as it is now.  This 
decision will be made by next Tuesday, but honestly given we're stuck with Java 
8 due to TomEE 8/Jakarta EE 8, we're not really affected either way.

Where I think that brings us is that we can do work to make the build run on 
Java 11 as long as it does not break the Java 8 build.

Open to ideas and discussion on that.


-- 
David Blevins
http://twitter.com/dblevins
http://www.tomitribe.com

> On Jul 7, 2020, at 1:48 AM, Zowalla, Richard 
>  wrote:
> 
> Hi,
> 
> I was digging around the GitHub Repo and noticed PR 664 [1], which
> tries to prepare TomEE to be build with JDK 11 but CORBA was removed in
> JDK 11.
> 
> There was a disucssion 2 years ago about removing CORBA related access
> [2]. There even exist a JIRA (TOMEE-2324) for it [3]. 
> 
> If we want to build TomEE with JDK 11, we either need to (a) remove
> CORBA dependencies (and check the implications as suggested in TOMEE-
> 2324) or (b) add the CORBA API / IMPL back (e.g. via "jacorb" [4] or
> via the glassfish api/impl ("glassfish-corba-orb" [5]). 
> 
> What is the plan for this? Any opinions? :)
> 
> Best,
> Richard
> 
> 
> [1] https://github.com/apache/tomee/pull/664
> [2] https://www.mail-archive.com/dev@tomee.apache.org/msg08054.html
> [3] https://issues.apache.org/jira/projects/TOMEE/issues/TOMEE-2324
> [4] https://www.jacorb.org/
> [5] https://javaee.github.io/glassfish-corba/



smime.p7s
Description: S/MIME cryptographic signature

Re: Follow-Up: ORB Dependencies and Java 11

[David Jencks]

I’d be quite surprised if any new applications are developed using CORBA and 
I’d suspect any existing applications are at companies with ${big} support 
contracts and little interest in migrating.  I don’t know much about users of 
TomEE however. 

Generally jax-rs is an easier to deal with solution nowadays.

David Jencks

> On Jul 7, 2020, at 12:40 PM, Daniel Dias Dos Santos 
>  wrote:
> 
> Hello ,
> 
> Thanks Richard   for the information .
> 
> But @David Jencks CORBA is important in TomEE ? has any impact?
> 
> --
> 
> *Daniel Dias dos Santos*
> Java Developer
> SouJava & JCP Member
> GitHub: https://github.com/Daniel-Dos
> Linkedin: www.linkedin.com/in/danieldiasjava
> Twitter: http://twitter.com/danieldiasjava
> 
> 
> Em ter., 7 de jul. de 2020 às 16:35, David Jencks 
> escreveu:
> 
>> BTW, supporting CORBA, no matter which orb you pick, is quite difficult
>> unless you happen to already be a CORBA expert, probably because you’ve
>> already implemented significant parts of an ORB. The CORBA documentation is
>> fairly opaque, and the semantics are quite different from what you are used
>> to in java.  Even though Yoko was used to certify IBM Liberty, getting it
>> to work with TomEE is likely to be a significant and painful adventure.
>> 
>> David Jencks
>> 
>>> On Jul 7, 2020, at 9:53 AM, David Jencks 
>> wrote:
>>> 
>>> Apache Yoko (part of geronimo project) is probably also a viable
>> possibility, a few years ago it was the IBM Liberty corba implementation,
>> and is presumably still used in OpenLiberty.  I think jacorb has an
>> incompatible license, which is why we didn’t use it in Geronimo.  I don’t
>> know about the glassfish orb.
>>> 
>>> David Jencks
>>> 
 On Jul 7, 2020, at 1:48 AM, Zowalla, Richard <
>> richard.zowa...@hs-heilbronn.de> wrote:
 
 Hi,
 
 I was digging around the GitHub Repo and noticed PR 664 [1], which
 tries to prepare TomEE to be build with JDK 11 but CORBA was removed in
 JDK 11.
 
 There was a disucssion 2 years ago about removing CORBA related access
 [2]. There even exist a JIRA (TOMEE-2324) for it [3].
 
 If we want to build TomEE with JDK 11, we either need to (a) remove
 CORBA dependencies (and check the implications as suggested in TOMEE-
 2324) or (b) add the CORBA API / IMPL back (e.g. via "jacorb" [4] or
 via the glassfish api/impl ("glassfish-corba-orb" [5]).
 
 What is the plan for this? Any opinions? :)
 
 Best,
 Richard
 
 
 [1] https://github.com/apache/tomee/pull/664
 [2] https://www.mail-archive.com/dev@tomee.apache.org/msg08054.html
 [3] https://issues.apache.org/jira/projects/TOMEE/issues/TOMEE-2324
 [4] https://www.jacorb.org/
 [5] https://javaee.github.io/glassfish-corba/
>>> 
>> 
>> 

[GitHub] [tomee] Daniel-Dos merged pull request #671: Fix logic in assertProperties method. Fixes TOMEE-1417

[GitBox]

Daniel-Dos merged pull request #671:
URL: https://github.com/apache/tomee/pull/671


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Follow-Up: ORB Dependencies and Java 11

[Daniel Dias Dos Santos]

Hello ,

Thanks Richard   for the information .

But @David Jencks CORBA is important in TomEE ? has any impact?

--

*Daniel Dias dos Santos*
Java Developer
SouJava & JCP Member
GitHub: https://github.com/Daniel-Dos
Linkedin: www.linkedin.com/in/danieldiasjava
Twitter: http://twitter.com/danieldiasjava


Em ter., 7 de jul. de 2020 às 16:35, David Jencks 
escreveu:

> BTW, supporting CORBA, no matter which orb you pick, is quite difficult
> unless you happen to already be a CORBA expert, probably because you’ve
> already implemented significant parts of an ORB. The CORBA documentation is
> fairly opaque, and the semantics are quite different from what you are used
> to in java.  Even though Yoko was used to certify IBM Liberty, getting it
> to work with TomEE is likely to be a significant and painful adventure.
>
> David Jencks
>
> > On Jul 7, 2020, at 9:53 AM, David Jencks 
> wrote:
> >
> > Apache Yoko (part of geronimo project) is probably also a viable
> possibility, a few years ago it was the IBM Liberty corba implementation,
> and is presumably still used in OpenLiberty.  I think jacorb has an
> incompatible license, which is why we didn’t use it in Geronimo.  I don’t
> know about the glassfish orb.
> >
> > David Jencks
> >
> >> On Jul 7, 2020, at 1:48 AM, Zowalla, Richard <
> richard.zowa...@hs-heilbronn.de> wrote:
> >>
> >> Hi,
> >>
> >> I was digging around the GitHub Repo and noticed PR 664 [1], which
> >> tries to prepare TomEE to be build with JDK 11 but CORBA was removed in
> >> JDK 11.
> >>
> >> There was a disucssion 2 years ago about removing CORBA related access
> >> [2]. There even exist a JIRA (TOMEE-2324) for it [3].
> >>
> >> If we want to build TomEE with JDK 11, we either need to (a) remove
> >> CORBA dependencies (and check the implications as suggested in TOMEE-
> >> 2324) or (b) add the CORBA API / IMPL back (e.g. via "jacorb" [4] or
> >> via the glassfish api/impl ("glassfish-corba-orb" [5]).
> >>
> >> What is the plan for this? Any opinions? :)
> >>
> >> Best,
> >> Richard
> >>
> >>
> >> [1] https://github.com/apache/tomee/pull/664
> >> [2] https://www.mail-archive.com/dev@tomee.apache.org/msg08054.html
> >> [3] https://issues.apache.org/jira/projects/TOMEE/issues/TOMEE-2324
> >> [4] https://www.jacorb.org/
> >> [5] https://javaee.github.io/glassfish-corba/
> >
>
>

Re: Follow-Up: ORB Dependencies and Java 11

[David Jencks]

BTW, supporting CORBA, no matter which orb you pick, is quite difficult unless 
you happen to already be a CORBA expert, probably because you’ve already 
implemented significant parts of an ORB. The CORBA documentation is fairly 
opaque, and the semantics are quite different from what you are used to in 
java.  Even though Yoko was used to certify IBM Liberty, getting it to work 
with TomEE is likely to be a significant and painful adventure.

David Jencks

> On Jul 7, 2020, at 9:53 AM, David Jencks  wrote:
> 
> Apache Yoko (part of geronimo project) is probably also a viable possibility, 
> a few years ago it was the IBM Liberty corba implementation, and is 
> presumably still used in OpenLiberty.  I think jacorb has an incompatible 
> license, which is why we didn’t use it in Geronimo.  I don’t know about the 
> glassfish orb.
> 
> David Jencks
> 
>> On Jul 7, 2020, at 1:48 AM, Zowalla, Richard 
>>  wrote:
>> 
>> Hi,
>> 
>> I was digging around the GitHub Repo and noticed PR 664 [1], which
>> tries to prepare TomEE to be build with JDK 11 but CORBA was removed in
>> JDK 11.
>> 
>> There was a disucssion 2 years ago about removing CORBA related access
>> [2]. There even exist a JIRA (TOMEE-2324) for it [3]. 
>> 
>> If we want to build TomEE with JDK 11, we either need to (a) remove
>> CORBA dependencies (and check the implications as suggested in TOMEE-
>> 2324) or (b) add the CORBA API / IMPL back (e.g. via "jacorb" [4] or
>> via the glassfish api/impl ("glassfish-corba-orb" [5]). 
>> 
>> What is the plan for this? Any opinions? :)
>> 
>> Best,
>> Richard
>> 
>> 
>> [1] https://github.com/apache/tomee/pull/664
>> [2] https://www.mail-archive.com/dev@tomee.apache.org/msg08054.html
>> [3] https://issues.apache.org/jira/projects/TOMEE/issues/TOMEE-2324
>> [4] https://www.jacorb.org/
>> [5] https://javaee.github.io/glassfish-corba/
> 

Re: TOMEE-1417 Fix

[Daniel Dias Dos Santos]

Hello David,

great, thanks .   :  )
--

*Daniel Dias dos Santos*
Java Developer
SouJava & JCP Member
GitHub: https://github.com/Daniel-Dos
Linkedin: www.linkedin.com/in/danieldiasjava
Twitter: http://twitter.com/danieldiasjava


Em ter., 7 de jul. de 2020 às 13:43, David Salter 
escreveu:

> Hi,
>
> I've submitted a PR (https://github.com/apache/tomee/pull/671) for
> TOMEE-1417.
>
>
> The code tests that 2 Properties objects are the same, but doesn't flag
> errors correctly when they contain the same keys but different values.
> I've fixed the logic so it now works in this case.
>
> Please can someone take a look and merge if its OK?
>
>
> Cheers,
>
> Dave.
>
> --
> David Salter
>
>
>

Re: Follow-Up: ORB Dependencies and Java 11

[David Jencks]

Apache Yoko (part of geronimo project) is probably also a viable possibility, a 
few years ago it was the IBM Liberty corba implementation, and is presumably 
still used in OpenLiberty.  I think jacorb has an incompatible license, which 
is why we didn’t use it in Geronimo.  I don’t know about the glassfish orb.

David Jencks

> On Jul 7, 2020, at 1:48 AM, Zowalla, Richard 
>  wrote:
> 
> Hi,
> 
> I was digging around the GitHub Repo and noticed PR 664 [1], which
> tries to prepare TomEE to be build with JDK 11 but CORBA was removed in
> JDK 11.
> 
> There was a disucssion 2 years ago about removing CORBA related access
> [2]. There even exist a JIRA (TOMEE-2324) for it [3]. 
> 
> If we want to build TomEE with JDK 11, we either need to (a) remove
> CORBA dependencies (and check the implications as suggested in TOMEE-
> 2324) or (b) add the CORBA API / IMPL back (e.g. via "jacorb" [4] or
> via the glassfish api/impl ("glassfish-corba-orb" [5]). 
> 
> What is the plan for this? Any opinions? :)
> 
> Best,
> Richard
> 
> 
> [1] https://github.com/apache/tomee/pull/664
> [2] https://www.mail-archive.com/dev@tomee.apache.org/msg08054.html
> [3] https://issues.apache.org/jira/projects/TOMEE/issues/TOMEE-2324
> [4] https://www.jacorb.org/
> [5] https://javaee.github.io/glassfish-corba/

TOMEE-1417 Fix

[David Salter]

Hi,

I've submitted a PR (https://github.com/apache/tomee/pull/671) for 
TOMEE-1417.



The code tests that 2 Properties objects are the same, but doesn't flag 
errors correctly when they contain the same keys but different values.  
I've fixed the logic so it now works in this case.


Please can someone take a look and merge if its OK?


Cheers,

Dave.

--
David Salter

[GitHub] [tomee] davidsalter opened a new pull request #671: Fix logic in assertProperties method. Fixes TOMEE-1417

[GitBox]

davidsalter opened a new pull request #671:
URL: https://github.com/apache/tomee/pull/671


   In the assertProperties() methodf, the logic for comparing when a property 
exists in both collections, but has a different value, the logic is incorrect 
and never fails.
   
   I've changed the logic now so that it will fail as appropriate and catch any 
future errors.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [tomee] Daniel-Dos commented on a change in pull request #670: TOMEE-55 - Review alignment for pages that originally had html tables

[GitBox]

Daniel-Dos commented on a change in pull request #670:
URL: https://github.com/apache/tomee/pull/670#discussion_r450972572



##
File path: examples/spring-integration/pom.xml
##
@@ -0,0 +1,155 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+4.0.0
+
+org.superbiz
+spring-integration
+1.1-SNAPSHOT

Review comment:
   I don't know if the example still works with the current version of 
Tomee 8.0.3





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [tomee] Daniel-Dos commented on a change in pull request #670: TOMEE-55 - Review alignment for pages that originally had html tables

[GitBox]

Daniel-Dos commented on a change in pull request #670:
URL: https://github.com/apache/tomee/pull/670#discussion_r450969465



##
File path: examples/spring-integration/pom.xml
##
@@ -0,0 +1,155 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+4.0.0
+
+org.superbiz
+spring-integration
+1.1-SNAPSHOT

Review comment:
   change 1.1-SNAPSHOT to 
8.0.4-SNAPSHOT
   
   also add the following :
   
   ```
   
   org.tomitribe.transformer
   org.eclipse.transformer.maven
   0.1.1a
   
 jakartaee9
   
   
 
   
 run
   
   package
 
   
  
   ```
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Follow-Up: ORB Dependencies and Java 11

[Zowalla, Richard]

Hi Daniel,

CORBA is an acronym for "Common Object Request Broker Architecture" - a
standard defined by the Object Management Group (OMG) published in 1991
(rather legacy) and which evolves outside the Java Community Process.

You can find some more details about it (and the motivation why it was
removed in Java 11 in JEP 320 [1]. Oracle provides a more (code-driven) 
introduction to the topic [2].

I hope, this provides some insights into this (ancient) technology :).

Best,
Richard


[1] https://openjdk.java.net/jeps/320
[2] 
https://www.oracle.com/technical-resources/articles/javase/rmi-corba.html

Am Dienstag, den 07.07.2020, 09:33 -0300 schrieb Daniel Dias Dos
Santos:
> Hello Richard,
> 
> Fantastic.
> sorry for ignorance don't ask.
> 
> What would CORBA be and what is it for?
> --
> 
> *Daniel Dias dos Santos*
> Java Developer
> SouJava & JCP Member
> GitHub: https://github.com/Daniel-Dos
> Linkedin: www.linkedin.com/in/danieldiasjava
> Twitter: http://twitter.com/danieldiasjava
> 
> 
> Em ter., 7 de jul. de 2020 às 05:48, Zowalla, Richard <
> richard.zowa...@hs-heilbronn.de> escreveu:
> 
> > Hi,
> > 
> > I was digging around the GitHub Repo and noticed PR 664 [1], which
> > tries to prepare TomEE to be build with JDK 11 but CORBA was
> > removed in
> > JDK 11.
> > 
> > There was a disucssion 2 years ago about removing CORBA related
> > access
> > [2]. There even exist a JIRA (TOMEE-2324) for it [3].
> > 
> > If we want to build TomEE with JDK 11, we either need to (a) remove
> > CORBA dependencies (and check the implications as suggested in
> > TOMEE-
> > 2324) or (b) add the CORBA API / IMPL back (e.g. via "jacorb" [4]
> > or
> > via the glassfish api/impl ("glassfish-corba-orb" [5]).
> > 
> > What is the plan for this? Any opinions? :)
> > 
> > Best,
> > Richard
> > 
> > 
> > [1] https://github.com/apache/tomee/pull/664
> > [2] https://www.mail-archive.com/dev@tomee.apache.org/msg08054.html
> > [3] https://issues.apache.org/jira/projects/TOMEE/issues/TOMEE-2324
> > [4] https://www.jacorb.org/
> > [5] https://javaee.github.io/glassfish-corba/
> > 


smime.p7s
Description: S/MIME cryptographic signature

Re: Follow-Up: ORB Dependencies and Java 11

[Daniel Dias Dos Santos]

Hello Richard,

Fantastic.
sorry for ignorance don't ask.

What would CORBA be and what is it for?
--

*Daniel Dias dos Santos*
Java Developer
SouJava & JCP Member
GitHub: https://github.com/Daniel-Dos
Linkedin: www.linkedin.com/in/danieldiasjava
Twitter: http://twitter.com/danieldiasjava


Em ter., 7 de jul. de 2020 às 05:48, Zowalla, Richard <
richard.zowa...@hs-heilbronn.de> escreveu:

> Hi,
>
> I was digging around the GitHub Repo and noticed PR 664 [1], which
> tries to prepare TomEE to be build with JDK 11 but CORBA was removed in
> JDK 11.
>
> There was a disucssion 2 years ago about removing CORBA related access
> [2]. There even exist a JIRA (TOMEE-2324) for it [3].
>
> If we want to build TomEE with JDK 11, we either need to (a) remove
> CORBA dependencies (and check the implications as suggested in TOMEE-
> 2324) or (b) add the CORBA API / IMPL back (e.g. via "jacorb" [4] or
> via the glassfish api/impl ("glassfish-corba-orb" [5]).
>
> What is the plan for this? Any opinions? :)
>
> Best,
> Richard
>
>
> [1] https://github.com/apache/tomee/pull/664
> [2] https://www.mail-archive.com/dev@tomee.apache.org/msg08054.html
> [3] https://issues.apache.org/jira/projects/TOMEE/issues/TOMEE-2324
> [4] https://www.jacorb.org/
> [5] https://javaee.github.io/glassfish-corba/
>

Re: Consumer instances are not created as per MDB instance limt

[Dignesh]

Thank you very much Jon. It is clear now.
One more question. Looking at the code changes you made for 7.0.9 version, 
I think the instance Limit was honored properly in 7.0.2 -- at least by
looking into the 7.0.2 code base. The only piece of block missing was JMS
monitoring. Can you please confirm if this is correct. May be the
instanceLimit not setting properly was introduced in later versions of
tomee..?

MdbContainer.java
  

I have attached the 7.0.2 version of file by adding the diff(s) change.Hope
the diff changes i copied are fine :) 



--
Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: Consumer instances are not created as per MDB instance limt

[Jonathan Gallimore]

Sorry, my last reply was a little rushed as I was on my phone. With respect
to JBoss, I don't know how those stats are computed, so I can't make too
much comment there. In TomEE, the stuff under org.apache.activemq is
provided by the ActiveMQ embedded inside TomEE. TomEE provides these
"as-is", so we don't have any control over the values. Your config exposes
the broker with an NIO OpenWire port, so any stats would also include
external connections to that port.

I did a quick test with your config, and used the ActiveMQ
producer/consumer commands (e.g. ./activemq consumer --brokerUrl
nio://localhost:54545 --destination queue://TEST --messageCount 10)
which use 20 threads by default, and this also shows as one consumer in the
broker JMX stats.

For reference, here's the class that provides the MBean you're looking at
in JConsole:
https://github.com/apache/activemq/blob/activemq-5.15.x/activemq-broker/src/main/java/org/apache/activemq/broker/jmx/SubscriptionView.java
-
you're really looking at subscription to the queue for the connection, so
I'd only expect to see one.

Usually when I see these types of questions, people are really more
concerned about concurrency and getting the right throughput through their
MDBs, and having an accurate measure of that. The "instanceCount" should
provide an accurate measure there (feedback is welcome!), but a test is
worthwhile. This is a basic test that you can build on:
https://github.com/apache/tomee/blob/master/container/openejb-core/src/test/java/org/apache/openejb/core/mdb/MaxInstanceEndpointHandlerTest.java

It:

* loads a queue up with messages:
https://github.com/apache/tomee/blob/master/container/openejb-core/src/test/java/org/apache/openejb/core/mdb/MaxInstanceEndpointHandlerTest.java#L90-L96
* starts the MDB:
https://github.com/apache/tomee/blob/master/container/openejb-core/src/test/java/org/apache/openejb/core/mdb/MaxInstanceEndpointHandlerTest.java#L99
* and checks we had the concurrency we expected (30 concurrent instances):
https://github.com/apache/tomee/blob/master/container/openejb-core/src/test/java/org/apache/openejb/core/mdb/MaxInstanceEndpointHandlerTest.java#L102

If you wanted to have a go building on this test to include multiple queues
and MDBs that would be really awesome. Adding some checks in there for the
instance count through JMX would be a good improvement too.

I hope that helps. I appreciate that this isn't necessarily
straightforward, so if you have more questions, please ask!

Jon


On Tue, Jul 7, 2020 at 9:38 AM Dignesh  wrote:

> Thank you Jon.
> I was expecting the consumer count shown in the jconsole tool to be matched
> with maxsessions/InstanceLimit.
>
> When I switch the Appserver to JBoss, I do notice the consumer count value
> shown properly.
>
> If it is expected in TomEE, the only way to find the number of consumers is
> via InstanceLimit ? Am i correct ? Jboss-ConsumerCoun.png
> <
> http://tomee-openejb.979440.n4.nabble.com/file/t375864/Jboss-ConsumerCoun.png>
>
> TomEE_-_consumercount.JPG
> <
> http://tomee-openejb.979440.n4.nabble.com/file/t375864/TomEE_-_consumercount.JPG>
>
>
> I have attached the screenshots of both the application servers.
>
>
>
> --
> Sent from:
> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
>

[GitHub] [tomee] rzo1 commented on pull request #624: Fix typo in excluding URLs in the DeploymentResolver

[GitBox]

rzo1 commented on pull request #624:
URL: https://github.com/apache/tomee/pull/624#issuecomment-654704778


   The JIRA: https://issues.apache.org/jira/projects/TOMEE/issues/TOMEE-2756
   
   The commit 
https://github.com/apache/tomee/commit/c5fc549b697c61c1e081aeef487c1c36a5eaa1df 
which introduced the "typo".



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Follow-Up: ORB Dependencies and Java 11

[Zowalla, Richard]

Hi,

I was digging around the GitHub Repo and noticed PR 664 [1], which
tries to prepare TomEE to be build with JDK 11 but CORBA was removed in
JDK 11.

There was a disucssion 2 years ago about removing CORBA related access
[2]. There even exist a JIRA (TOMEE-2324) for it [3]. 

If we want to build TomEE with JDK 11, we either need to (a) remove
CORBA dependencies (and check the implications as suggested in TOMEE-
2324) or (b) add the CORBA API / IMPL back (e.g. via "jacorb" [4] or
via the glassfish api/impl ("glassfish-corba-orb" [5]). 

What is the plan for this? Any opinions? :)

Best,
Richard


[1] https://github.com/apache/tomee/pull/664
[2] https://www.mail-archive.com/dev@tomee.apache.org/msg08054.html
[3] https://issues.apache.org/jira/projects/TOMEE/issues/TOMEE-2324
[4] https://www.jacorb.org/
[5] https://javaee.github.io/glassfish-corba/


smime.p7s
Description: S/MIME cryptographic signature

Re: Consumer instances are not created as per MDB instance limt

[Dignesh]

Thank you Jon.
I was expecting the consumer count shown in the jconsole tool to be matched
with maxsessions/InstanceLimit.

When I switch the Appserver to JBoss, I do notice the consumer count value
shown properly.

If it is expected in TomEE, the only way to find the number of consumers is
via InstanceLimit ? Am i correct ? Jboss-ConsumerCoun.png
 
 
TomEE_-_consumercount.JPG

  

I have attached the screenshots of both the application servers.



--
Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html

Re: Consumer instances are not created as per MDB instance limt

[Jonathan Gallimore]

That's expected. ActiveMQ multiplexes multiple sessions into one
connection, so you'll only see one consumer there. The number of
concurrently active inactive MDB instances is not a 1:1 with the consumer
count.

Jon

On Tue, 7 Jul 2020, 07:30 Dignesh,  wrote:

> Hi Jon,
>
> Looks like you resolved the issue -
> https://issues.apache.org/jira/browse/TOMEE-2859
> I have made the diff(s) of changes locally, I am now able to see the
> instances count in JMX.
>
> screenshot.JPG
> 
> instancecount.JPG
> 
>
>
> If you refer the instanceCount screenshot, the values are populated
> properly.
> However, I was under impression that all the instances of consumers will be
> shown in JMX broker. But I still see only one consumer  - refer to
> screenshot.jpg.
>
> Is that expected ? - TomEE will only show the instancecount and
> instanceLimit, but consumer displayed will always be one ?
>
> Thank you once again.
>
>
>
> --
> Sent from:
> http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html
>

Re: Consumer instances are not created as per MDB instance limt

[Dignesh]

Hi Jon,

Looks like you resolved the issue -
https://issues.apache.org/jira/browse/TOMEE-2859 
I have made the diff(s) of changes locally, I am now able to see the
instances count in JMX.

screenshot.JPG
  
instancecount.JPG
  

If you refer the instanceCount screenshot, the values are populated
properly. 
However, I was under impression that all the instances of consumers will be
shown in JMX broker. But I still see only one consumer  - refer to
screenshot.jpg.

Is that expected ? - TomEE will only show the instancecount and
instanceLimit, but consumer displayed will always be one ?

Thank you once again.



--
Sent from: http://tomee-openejb.979440.n4.nabble.com/TomEE-Dev-f982480.html