[GitHub] [flink] faaronzheng removed a comment on issue #10299: [FLINK-14560] [runtime] The value of taskmanager.memory.size in flink…
faaronzheng removed a comment on issue #10299: [FLINK-14560] [runtime] The value of taskmanager.memory.size in flink… URL: https://github.com/apache/flink/pull/10299#issuecomment-559917269 > ## CI report: > * [f7802ae](https://github.com/apache/flink/commit/f7802aefa43e285597bfba62592e05d0cb2f074f) : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137937387) > > Bot commands @flinkbot run travis This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10299: [FLINK-14560] [runtime] The value of taskmanager.memory.size in flink…
flinkbot edited a comment on issue #10299: [FLINK-14560] [runtime] The value of taskmanager.memory.size in flink… URL: https://github.com/apache/flink/pull/10299#issuecomment-557882742 ## CI report: * f7802aefa43e285597bfba62592e05d0cb2f074f : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/137937387) * 4992a53890baa7a8ebe5e7b22191169a3c16c402 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/138770602) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] faaronzheng removed a comment on issue #10299: [FLINK-14560] [runtime] The value of taskmanager.memory.size in flink…
faaronzheng removed a comment on issue #10299: [FLINK-14560] [runtime] The value of taskmanager.memory.size in flink… URL: https://github.com/apache/flink/pull/10299#issuecomment-559909732 > * @flinkbot run travis @flinkbot run travis This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] faaronzheng commented on issue #10299: [FLINK-14560] [runtime] The value of taskmanager.memory.size in flink…
faaronzheng commented on issue #10299: [FLINK-14560] [runtime] The value of taskmanager.memory.size in flink… URL: https://github.com/apache/flink/pull/10299#issuecomment-559917269 > ## CI report: > * [f7802ae](https://github.com/apache/flink/commit/f7802aefa43e285597bfba62592e05d0cb2f074f) : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137937387) > > Bot commands @flinkbot run travis This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9984: [FLINK-9495][kubernetes] Implement ResourceManager for Kubernetes.
flinkbot edited a comment on issue #9984: [FLINK-9495][kubernetes] Implement ResourceManager for Kubernetes. URL: https://github.com/apache/flink/pull/9984#issuecomment-545881191 ## CI report: * 802ebf37e3d932169f9826b40df483bb5e9ac064 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/133366796) * f16938ce2fb38ae216def737d14643b94d6083a1 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/133940607) * 20de5cfc7af9a8ba57080d5218fd0293f393a40e : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/133998545) * 56bfbb65802c1d5c48caa625a152070934bb5d79 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134010321) * 3ea229382fef64b1046673c79ff845d4689c5db4 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137145261) * 3169988a33e0126e79cd449740c93d3561296ead : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138017410) * a0dd858b0b91443fc87895a2d32ebfbbc0b9fe4c : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138730857) * 86b4537979265a0fbecf7c1841ed8fd2f7ebfd86 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138770610) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9965: [FLINK-10935][kubernetes]Implement KubeClient with Faric8 Kubernetes clients
flinkbot edited a comment on issue #9965: [FLINK-10935][kubernetes]Implement KubeClient with Faric8 Kubernetes clients URL: https://github.com/apache/flink/pull/9965#issuecomment-544813931 ## CI report: * 6f90b457e56a0a8cb45d63c1b05b47d2e38030a1 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/132938440) * 86aa5ce8f77faf233c51a7231b3f71e518fd6c92 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/132962300) * 7851d845a43f799627b2c788ace8eb7e6caccb03 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/133133283) * d49bb0a622e1667baffd29f19fdcc60d0022fe82 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/133366914) * 0e88e0e5be77f450c82cbc460ea4f02a1effc920 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/133998649) * 9afcc7ba840186c68f36b30d6b28b8c1cbf09b61 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137145224) * 06e6b2bee4c1788b150f2b83c43eb4723709864b : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138017584) * 816a11afe713e736cdfd2eb566762ee2addf7071 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138708643) * e80691082c9fc8ac704b0bccaa5180b7de0718d5 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138770607) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10193: [FLINK-13938][yarn] Use pre-uploaded flink binary to accelerate flink submission
flinkbot edited a comment on issue #10193: [FLINK-13938][yarn] Use pre-uploaded flink binary to accelerate flink submission URL: https://github.com/apache/flink/pull/10193#issuecomment-553881527 ## CI report: * e3ac83fe02a7583159184772ff4b4341fa65f827 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136517817) * eefbec6756be60a27698d275a1b94bef7cd0c1e2 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136636043) * 19a83ead105c951505dbafb0280fa2d25132c9a0 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136645898) * dd2b911c850a56e3d6aa4a3c7e16b30431977bf5 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136651764) * 06b368d9fbd88eabf71391fc1662b4d8a626d43c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137165694) * d4b77c8aab32cdeb11806fdd45ea88141051a157 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137317107) * 53b86608c1d008c53112b34c634ccf96419cd921 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137343147) * 2969fb4fb3afc8c331415c1ca478b05f3cb47b47 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137394777) * edccba4a6db80772f9494f5631e1bc6a340d6586 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137697818) * a109168bc5582fad8bbd3dade6f30990931583b5 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/138010243) * 6600e07db82467eb3ce41e6d1c8032c9bcdd9751 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/138072264) * b3155b18b290b31df0fc5e6bdf29ef421bf68373 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/138160080) * 5350fff0d5479bd2015de2e61895a4da06aece47 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138181974) * 3f24f8ce1b43bb832ca1987323be3717ed7bc6bd : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138197839) * ef0a6430c6e026f134905b40e9c79915ffc87ee3 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/138387359) * 74d293dad137877a8a6966f8d9ceb8a72da79898 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/138591690) * 29ff6192e49efafe70f835aca6230035ca17455b : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138606137) * 337ae22623b46aff87bbbe26becac1633e16a468 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/13876) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-14991) Export `FLINK_HOME` environment variable to all the entrypoint
[ https://issues.apache.org/jira/browse/FLINK-14991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985271#comment-16985271 ] Jeff Zhang commented on FLINK-14991: +1, but it would be better to reserve `FLINK_CONF_DIR`. That means we could derive `FLINK_LIB_DIR`,`FLINK_OPT_DIR`,`FLINK_PLUGIN_DIR`,`FLINK_BIN_DIR` from `FLINK_HOME`, but try to look for env `FLINK_CONF_DIR` first, if it doesn't exist, then use `FLINK_HOME/conf`. The reason is that some vendor flink distribution will define `FLINK_HOME/conf` separately. > Export `FLINK_HOME` environment variable to all the entrypoint > -- > > Key: FLINK-14991 > URL: https://issues.apache.org/jira/browse/FLINK-14991 > Project: Flink > Issue Type: Improvement > Components: Runtime / Coordination >Reporter: Guowei Ma >Priority: Minor > > Currently, Flink depends on 6 types of files: configuration files, system > jars files, script files、library jar files, plugin jar files, and user jars > files. These files are in different directories. > Flink exports 5 environment variables to locate these different type files: > `FLINK_CONF_DIR`,`FLINK_LIB_DIR`,`FLINK_OPT_DIR`,`FLINK_PLUGIN_DIR`,`FLINK_BIN_DIR`. > It is not a good style that exports an environment variable for every type of > file. > So this jira proposes to export the `FLINK_HOME` environment variable to all > the entrypoint. Derive the directory of the different type files from the > `FLINK_HOME` environment variable and every type file has a fixed directory > name. > This also has another benefit that the method implies the directory > structure is the same in all the situations. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #10369: [FLINK-14893][flink-core]Try child classLoader when parent classLoader could not load in parentFirstPatterns
flinkbot edited a comment on issue #10369: [FLINK-14893][flink-core]Try child classLoader when parent classLoader could not load in parentFirstPatterns URL: https://github.com/apache/flink/pull/10369#issuecomment-559908998 ## CI report: * 39957f4f139cc7b2d133e592e6a95ed9add9492b : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138769998) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10299: [FLINK-14560] [runtime] The value of taskmanager.memory.size in flink…
flinkbot edited a comment on issue #10299: [FLINK-14560] [runtime] The value of taskmanager.memory.size in flink… URL: https://github.com/apache/flink/pull/10299#issuecomment-557882742 ## CI report: * f7802aefa43e285597bfba62592e05d0cb2f074f : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/137937387) * 4992a53890baa7a8ebe5e7b22191169a3c16c402 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/138770602) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (FLINK-14984) Remove old WebUI
[ https://issues.apache.org/jira/browse/FLINK-14984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985263#comment-16985263 ] lamber-ken edited comment on FLINK-14984 at 11/30/19 5:18 AM: -- hi, [~chesnay] I think I can do it. Could you assign it to me? was (Author: lamber-ken): hi, [~chesnay] I think I can do it. Could anyon assign it to me? > Remove old WebUI > > > Key: FLINK-14984 > URL: https://issues.apache.org/jira/browse/FLINK-14984 > Project: Flink > Issue Type: Improvement > Components: Runtime / Web Frontend >Reporter: Chesnay Schepler >Priority: Major > Fix For: 1.10.0 > > > Following the discussion on the > [ML|https://lists.apache.org/thread.html/ae8528b620b51f6f8270b840a7d22c3b4231cd6f717f8280650a9be6@%3Cdev.flink.apache.org%3E], > remove the old WebUI. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (FLINK-14984) Remove old WebUI
[ https://issues.apache.org/jira/browse/FLINK-14984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985263#comment-16985263 ] lamber-ken commented on FLINK-14984: hi, [~chesnay] I think I can do it. Could anyon assign it to me? > Remove old WebUI > > > Key: FLINK-14984 > URL: https://issues.apache.org/jira/browse/FLINK-14984 > Project: Flink > Issue Type: Improvement > Components: Runtime / Web Frontend >Reporter: Chesnay Schepler >Priority: Major > Fix For: 1.10.0 > > > Following the discussion on the > [ML|https://lists.apache.org/thread.html/ae8528b620b51f6f8270b840a7d22c3b4231cd6f717f8280650a9be6@%3Cdev.flink.apache.org%3E], > remove the old WebUI. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #10161: [FLINK-13986][runtime] Clean up legacy code for FLIP-49.
flinkbot edited a comment on issue #10161: [FLINK-13986][runtime] Clean up legacy code for FLIP-49. URL: https://github.com/apache/flink/pull/10161#issuecomment-552882313 ## CI report: * 2c0501f41bea1da031777069dd46eb17c5ae8038 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136122509) * a93fe47a7f1a91c8a33e7cac2bfc095e3f17012b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136270502) * 649d050fe4173a390df026156f6e9bae4f346360 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/136299400) * 08dafb5d2c6f38599bf86c06516465aeaa324941 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136328000) * 8700267a462544e3d51aa40baa60ea07482305c5 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136460282) * b90d7ea0e63b16b064f7e54e886202fff63a7516 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136474353) * 0366a60deac3f1da4902e76a7879bd75996dc15b : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137744753) * 2d1421dc8595923aa04200a90dcc3a1eb2f9229e : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137877709) * f778ef42223274946279a328552684b7c03e1d1b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/138184361) * 298d6c299a83f2e2424fce5b54b25dc11b2fdcbc : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138768101) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10146: [FLINK-14188][runtime] TaskExecutor derive and register with default slot resource profile
flinkbot edited a comment on issue #10146: [FLINK-14188][runtime] TaskExecutor derive and register with default slot resource profile URL: https://github.com/apache/flink/pull/10146#issuecomment-552307115 ## CI report: * 25f9e4b87846e5a736aa329c834f82962e1f50c4 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/135875925) * c4b4f4d5c88a1a5009325a6260cf2d91ed69ca96 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/135885120) * 2d5269d2498d96550682d113d61382b7a9ac9721 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/135902960) * 5ee8701f76b9e6f2dcb451eb988371bea3b0a38d : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136486584) * 2c52d7157f5e1b25dfaa00fe50cf7b04e7d6a97e : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136497720) * 2d734eeff7480adc2ea1f3695f31ba5a169f3a05 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136501966) * 4edae43ff7eaf0357f5e8604b02b88749c8d153f : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136522752) * 927a11838172fe792636923e9378677f92a48b73 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/138028348) * a73de7a3fc63fe2d2a9bd12e03efb45bfcbf9ca8 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138455883) * d06a271e355a36fd316f35d98e2905df8829273a : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138768094) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9984: [FLINK-9495][kubernetes] Implement ResourceManager for Kubernetes.
flinkbot edited a comment on issue #9984: [FLINK-9495][kubernetes] Implement ResourceManager for Kubernetes. URL: https://github.com/apache/flink/pull/9984#issuecomment-545881191 ## CI report: * 802ebf37e3d932169f9826b40df483bb5e9ac064 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/133366796) * f16938ce2fb38ae216def737d14643b94d6083a1 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/133940607) * 20de5cfc7af9a8ba57080d5218fd0293f393a40e : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/133998545) * 56bfbb65802c1d5c48caa625a152070934bb5d79 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134010321) * 3ea229382fef64b1046673c79ff845d4689c5db4 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137145261) * 3169988a33e0126e79cd449740c93d3561296ead : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138017410) * a0dd858b0b91443fc87895a2d32ebfbbc0b9fe4c : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138730857) * 86b4537979265a0fbecf7c1841ed8fd2f7ebfd86 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/138770610) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9965: [FLINK-10935][kubernetes]Implement KubeClient with Faric8 Kubernetes clients
flinkbot edited a comment on issue #9965: [FLINK-10935][kubernetes]Implement KubeClient with Faric8 Kubernetes clients URL: https://github.com/apache/flink/pull/9965#issuecomment-544813931 ## CI report: * 6f90b457e56a0a8cb45d63c1b05b47d2e38030a1 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/132938440) * 86aa5ce8f77faf233c51a7231b3f71e518fd6c92 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/132962300) * 7851d845a43f799627b2c788ace8eb7e6caccb03 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/133133283) * d49bb0a622e1667baffd29f19fdcc60d0022fe82 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/133366914) * 0e88e0e5be77f450c82cbc460ea4f02a1effc920 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/133998649) * 9afcc7ba840186c68f36b30d6b28b8c1cbf09b61 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137145224) * 06e6b2bee4c1788b150f2b83c43eb4723709864b : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138017584) * 816a11afe713e736cdfd2eb566762ee2addf7071 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138708643) * e80691082c9fc8ac704b0bccaa5180b7de0718d5 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/138770607) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10299: [FLINK-14560] [runtime] The value of taskmanager.memory.size in flink…
flinkbot edited a comment on issue #10299: [FLINK-14560] [runtime] The value of taskmanager.memory.size in flink… URL: https://github.com/apache/flink/pull/10299#issuecomment-557882742 ## CI report: * f7802aefa43e285597bfba62592e05d0cb2f074f : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/137937387) * 4992a53890baa7a8ebe5e7b22191169a3c16c402 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/138770602) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10193: [FLINK-13938][yarn] Use pre-uploaded flink binary to accelerate flink submission
flinkbot edited a comment on issue #10193: [FLINK-13938][yarn] Use pre-uploaded flink binary to accelerate flink submission URL: https://github.com/apache/flink/pull/10193#issuecomment-553881527 ## CI report: * e3ac83fe02a7583159184772ff4b4341fa65f827 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136517817) * eefbec6756be60a27698d275a1b94bef7cd0c1e2 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136636043) * 19a83ead105c951505dbafb0280fa2d25132c9a0 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136645898) * dd2b911c850a56e3d6aa4a3c7e16b30431977bf5 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136651764) * 06b368d9fbd88eabf71391fc1662b4d8a626d43c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137165694) * d4b77c8aab32cdeb11806fdd45ea88141051a157 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137317107) * 53b86608c1d008c53112b34c634ccf96419cd921 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137343147) * 2969fb4fb3afc8c331415c1ca478b05f3cb47b47 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137394777) * edccba4a6db80772f9494f5631e1bc6a340d6586 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137697818) * a109168bc5582fad8bbd3dade6f30990931583b5 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/138010243) * 6600e07db82467eb3ce41e6d1c8032c9bcdd9751 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/138072264) * b3155b18b290b31df0fc5e6bdf29ef421bf68373 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/138160080) * 5350fff0d5479bd2015de2e61895a4da06aece47 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138181974) * 3f24f8ce1b43bb832ca1987323be3717ed7bc6bd : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138197839) * ef0a6430c6e026f134905b40e9c79915ffc87ee3 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/138387359) * 74d293dad137877a8a6966f8d9ceb8a72da79898 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/138591690) * 29ff6192e49efafe70f835aca6230035ca17455b : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138606137) * 337ae22623b46aff87bbbe26becac1633e16a468 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/13876) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9984: [FLINK-9495][kubernetes] Implement ResourceManager for Kubernetes.
flinkbot edited a comment on issue #9984: [FLINK-9495][kubernetes] Implement ResourceManager for Kubernetes. URL: https://github.com/apache/flink/pull/9984#issuecomment-545881191 ## CI report: * 802ebf37e3d932169f9826b40df483bb5e9ac064 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/133366796) * f16938ce2fb38ae216def737d14643b94d6083a1 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/133940607) * 20de5cfc7af9a8ba57080d5218fd0293f393a40e : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/133998545) * 56bfbb65802c1d5c48caa625a152070934bb5d79 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134010321) * 3ea229382fef64b1046673c79ff845d4689c5db4 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137145261) * 3169988a33e0126e79cd449740c93d3561296ead : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138017410) * a0dd858b0b91443fc87895a2d32ebfbbc0b9fe4c : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138730857) * 86b4537979265a0fbecf7c1841ed8fd2f7ebfd86 : UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9965: [FLINK-10935][kubernetes]Implement KubeClient with Faric8 Kubernetes clients
flinkbot edited a comment on issue #9965: [FLINK-10935][kubernetes]Implement KubeClient with Faric8 Kubernetes clients URL: https://github.com/apache/flink/pull/9965#issuecomment-544813931 ## CI report: * 6f90b457e56a0a8cb45d63c1b05b47d2e38030a1 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/132938440) * 86aa5ce8f77faf233c51a7231b3f71e518fd6c92 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/132962300) * 7851d845a43f799627b2c788ace8eb7e6caccb03 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/133133283) * d49bb0a622e1667baffd29f19fdcc60d0022fe82 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/133366914) * 0e88e0e5be77f450c82cbc460ea4f02a1effc920 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/133998649) * 9afcc7ba840186c68f36b30d6b28b8c1cbf09b61 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137145224) * 06e6b2bee4c1788b150f2b83c43eb4723709864b : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138017584) * 816a11afe713e736cdfd2eb566762ee2addf7071 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138708643) * e80691082c9fc8ac704b0bccaa5180b7de0718d5 : UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10369: [FLINK-14893][flink-core]Try child classLoader when parent classLoader could not load in parentFirstPatterns
flinkbot edited a comment on issue #10369: [FLINK-14893][flink-core]Try child classLoader when parent classLoader could not load in parentFirstPatterns URL: https://github.com/apache/flink/pull/10369#issuecomment-559908998 ## CI report: * 39957f4f139cc7b2d133e592e6a95ed9add9492b : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/138769998) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10299: [FLINK-14560] [runtime] The value of taskmanager.memory.size in flink…
flinkbot edited a comment on issue #10299: [FLINK-14560] [runtime] The value of taskmanager.memory.size in flink… URL: https://github.com/apache/flink/pull/10299#issuecomment-557882742 ## CI report: * f7802aefa43e285597bfba62592e05d0cb2f074f : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/137937387) * 4992a53890baa7a8ebe5e7b22191169a3c16c402 : UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] faaronzheng commented on issue #10299: [FLINK-14560] [runtime] The value of taskmanager.memory.size in flink…
faaronzheng commented on issue #10299: [FLINK-14560] [runtime] The value of taskmanager.memory.size in flink… URL: https://github.com/apache/flink/pull/10299#issuecomment-559909732 > * @flinkbot run travis @flinkbot run travis This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] faaronzheng removed a comment on issue #10299: [FLINK-14560] [runtime] The value of taskmanager.memory.size in flink…
faaronzheng removed a comment on issue #10299: [FLINK-14560] [runtime] The value of taskmanager.memory.size in flink… URL: https://github.com/apache/flink/pull/10299#issuecomment-559813698 > * @flinkbot run travis @flinkbot run travis This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10193: [FLINK-13938][yarn] Use pre-uploaded flink binary to accelerate flink submission
flinkbot edited a comment on issue #10193: [FLINK-13938][yarn] Use pre-uploaded flink binary to accelerate flink submission URL: https://github.com/apache/flink/pull/10193#issuecomment-553881527 ## CI report: * e3ac83fe02a7583159184772ff4b4341fa65f827 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136517817) * eefbec6756be60a27698d275a1b94bef7cd0c1e2 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136636043) * 19a83ead105c951505dbafb0280fa2d25132c9a0 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136645898) * dd2b911c850a56e3d6aa4a3c7e16b30431977bf5 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136651764) * 06b368d9fbd88eabf71391fc1662b4d8a626d43c : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137165694) * d4b77c8aab32cdeb11806fdd45ea88141051a157 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137317107) * 53b86608c1d008c53112b34c634ccf96419cd921 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137343147) * 2969fb4fb3afc8c331415c1ca478b05f3cb47b47 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137394777) * edccba4a6db80772f9494f5631e1bc6a340d6586 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137697818) * a109168bc5582fad8bbd3dade6f30990931583b5 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/138010243) * 6600e07db82467eb3ce41e6d1c8032c9bcdd9751 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/138072264) * b3155b18b290b31df0fc5e6bdf29ef421bf68373 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/138160080) * 5350fff0d5479bd2015de2e61895a4da06aece47 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138181974) * 3f24f8ce1b43bb832ca1987323be3717ed7bc6bd : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138197839) * ef0a6430c6e026f134905b40e9c79915ffc87ee3 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/138387359) * 74d293dad137877a8a6966f8d9ceb8a72da79898 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/138591690) * 29ff6192e49efafe70f835aca6230035ca17455b : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138606137) * 337ae22623b46aff87bbbe26becac1633e16a468 : UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10369: [FLINK-14893][flink-core]Try child classLoader when parent classLoader could not load in parentFirstPatterns
flinkbot commented on issue #10369: [FLINK-14893][flink-core]Try child classLoader when parent classLoader could not load in parentFirstPatterns URL: https://github.com/apache/flink/pull/10369#issuecomment-559908998 ## CI report: * 39957f4f139cc7b2d133e592e6a95ed9add9492b : UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] wangyang0918 commented on issue #10193: [FLINK-13938][yarn] Use pre-uploaded flink binary to accelerate flink submission
wangyang0918 commented on issue #10193: [FLINK-13938][yarn] Use pre-uploaded flink binary to accelerate flink submission URL: https://github.com/apache/flink/pull/10193#issuecomment-559908500 @TisonKun @walterddr Thanks a lot for your review. I have added a fixup to address all your comments. Please take a look. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] wangyang0918 commented on a change in pull request #10193: [FLINK-13938][yarn] Use pre-uploaded flink binary to accelerate flink submission
wangyang0918 commented on a change in pull request #10193: [FLINK-13938][yarn]
Use pre-uploaded flink binary to accelerate flink submission
URL: https://github.com/apache/flink/pull/10193#discussion_r352263878
##
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
##
@@ -253,6 +253,13 @@
.noDefaultValue()
.withDescription("Specify YARN node label for
the YARN application.");
+ public static final ConfigOption PRE_UPLOADED_FLINK_PATH =
+ key("yarn.pre-uploaded.flink.path")
+ .stringType()
+ .noDefaultValue()
+ .withDescription("Specify the pre-uploaded path of
flink. It will be used to accelerate the job submission" +
Review comment:
I will update the description.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on a change in pull request #10193: [FLINK-13938][yarn] Use pre-uploaded flink binary to accelerate flink submission
wangyang0918 commented on a change in pull request #10193: [FLINK-13938][yarn]
Use pre-uploaded flink binary to accelerate flink submission
URL: https://github.com/apache/flink/pull/10193#discussion_r352263872
##
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##
@@ -155,6 +156,10 @@
private String zookeeperNamespace;
+ // Pre-uploaded flink files, key is relative path(for example,
lib/flink-dist_{version}.jar),
Review comment:
Will fix it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on a change in pull request #10193: [FLINK-13938][yarn] Use pre-uploaded flink binary to accelerate flink submission
wangyang0918 commented on a change in pull request #10193: [FLINK-13938][yarn]
Use pre-uploaded flink binary to accelerate flink submission
URL: https://github.com/apache/flink/pull/10193#discussion_r352263878
##
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/configuration/YarnConfigOptions.java
##
@@ -253,6 +253,13 @@
.noDefaultValue()
.withDescription("Specify YARN node label for
the YARN application.");
+ public static final ConfigOption PRE_UPLOADED_FLINK_PATH =
+ key("yarn.pre-uploaded.flink.path")
+ .stringType()
+ .noDefaultValue()
+ .withDescription("Specify the pre-uploaded path of
flink. It will be used to accelerate the job submission" +
Review comment:
I will change the description.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on a change in pull request #10193: [FLINK-13938][yarn] Use pre-uploaded flink binary to accelerate flink submission
wangyang0918 commented on a change in pull request #10193: [FLINK-13938][yarn]
Use pre-uploaded flink binary to accelerate flink submission
URL: https://github.com/apache/flink/pull/10193#discussion_r352263870
##
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##
@@ -155,6 +156,10 @@
private String zookeeperNamespace;
+ // Pre-uploaded flink files, key is relative path(for example,
lib/flink-dist_{version}.jar),
+ // and value is remote file status.
+ private final Map preUploadedFlinkFiles;
Review comment:
Will fix it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on a change in pull request #10193: [FLINK-13938][yarn] Use pre-uploaded flink binary to accelerate flink submission
wangyang0918 commented on a change in pull request #10193: [FLINK-13938][yarn]
Use pre-uploaded flink binary to accelerate flink submission
URL: https://github.com/apache/flink/pull/10193#discussion_r352263865
##
File path: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java
##
@@ -596,6 +644,30 @@ static ContainerLaunchContext createTaskExecutorContext(
return ctx;
}
+ static Map getPreUploadedFlinkFiles(
+ @Nullable String flinkSharedBinary,
+ Configuration yarnConfiguration) {
+ Map flinkShareFiles = new HashMap<>();
+ if (flinkSharedBinary != null) {
+ try {
+ FileSystem fileSystem =
FileSystem.get(yarnConfiguration);
+ Path flinkSharedPath = new
Path(flinkSharedBinary);
+ if (fileSystem.exists(flinkSharedPath)) {
+ RemoteIterator
iterable = fileSystem.listFiles(flinkSharedPath, true);
+ while (iterable.hasNext()) {
+ LocatedFileStatus
locatedFileStatus = iterable.next();
+ String relative =
flinkSharedPath.toUri().relativize(locatedFileStatus.getPath().toUri()).getPath();
+ flinkShareFiles.put(relative,
locatedFileStatus);
+ LOG.debug("Found pre-uploaded
file {} under {}", relative, flinkSharedPath);
+ }
+ }
+ } catch (IOException e) {
+ LOG.warn("Error to get the ");
Review comment:
Nice catch. I will fix it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Assigned] (FLINK-14893) Using Child ClassLoader to load class when Parent ClassLoader couldn't load in ParentFirstPatterns
[ https://issues.apache.org/jira/browse/FLINK-14893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen reassigned FLINK-14893: - Assignee: hailong wang > Using Child ClassLoader to load class when Parent ClassLoader couldn't load > in ParentFirstPatterns > > > Key: FLINK-14893 > URL: https://issues.apache.org/jira/browse/FLINK-14893 > Project: Flink > Issue Type: Improvement > Components: Runtime / Task >Affects Versions: 1.9.0 >Reporter: hailong wang >Assignee: hailong wang >Priority: Major > Labels: pull-request-available > Fix For: 1.10.0 > > Time Spent: 10m > Remaining Estimate: 0h > > In ChildFirstClassLoader#loadClass, when a class is in ParentFirstPattern, > but it load failed for that parent does not contain it. It will throw a > ClassNotFoundException. I think when loading failed, we should use findClass > to load later. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] TisonKun commented on issue #10369: [FLINK-14893][flink-core]Try child classLoader when parent classLoader could not load in parentFirstPatterns
TisonKun commented on issue #10369: [FLINK-14893][flink-core]Try child classLoader when parent classLoader could not load in parentFirstPatterns URL: https://github.com/apache/flink/pull/10369#issuecomment-559907351 @wangxlong thanks for your contribution. Changes look good to me. It would be better if you can write a test for the specific case and I think it is somewhat necessary :-) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10369: [FLINK-14893][flink-core]Try child classLoader when parent classLoader could not load in parentFirstPatterns
flinkbot commented on issue #10369: [FLINK-14893][flink-core]Try child classLoader when parent classLoader could not load in parentFirstPatterns URL: https://github.com/apache/flink/pull/10369#issuecomment-559907305 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit 39957f4f139cc7b2d133e592e6a95ed9add9492b (Sat Nov 30 02:56:47 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-14893).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work. Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-14893) Using Child ClassLoader to load class when Parent ClassLoader couldn't load in ParentFirstPatterns
[ https://issues.apache.org/jira/browse/FLINK-14893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-14893: --- Labels: pull-request-available (was: ) > Using Child ClassLoader to load class when Parent ClassLoader couldn't load > in ParentFirstPatterns > > > Key: FLINK-14893 > URL: https://issues.apache.org/jira/browse/FLINK-14893 > Project: Flink > Issue Type: Improvement > Components: Runtime / Task >Affects Versions: 1.9.0 >Reporter: hailong wang >Priority: Major > Labels: pull-request-available > Fix For: 1.10.0 > > > In ChildFirstClassLoader#loadClass, when a class is in ParentFirstPattern, > but it load failed for that parent does not contain it. It will throw a > ClassNotFoundException. I think when loading failed, we should use findClass > to load later. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] wangxlong opened a new pull request #10369: [FLINK-14893][flink-core]Try child classLoader when parent classLoader could not load in parentFirstPatterns
wangxlong opened a new pull request #10369: [FLINK-14893][flink-core]Try child classLoader when parent classLoader could not load in parentFirstPatterns URL: https://github.com/apache/flink/pull/10369 ## What is the purpose of the change Try child classLoader to load class when parent classLoader couldn't be found. ## Brief change log In ChildFirstClassLoader#loadClass, try child classLoader to load class when parent classLoader couldn't be found. ## Verifying this change This change is a trivial rework without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (yes / no / don't know) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] caidezhi closed pull request #10365: [FLINK-14994] StreamTableEnvironment.connect throw exception when using "FileSystem" connector and "CSV" format
caidezhi closed pull request #10365: [FLINK-14994] StreamTableEnvironment.connect throw exception when using "FileSystem" connector and "CSV" format URL: https://github.com/apache/flink/pull/10365 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10161: [FLINK-13986][runtime] Clean up legacy code for FLIP-49.
flinkbot edited a comment on issue #10161: [FLINK-13986][runtime] Clean up legacy code for FLIP-49. URL: https://github.com/apache/flink/pull/10161#issuecomment-552882313 ## CI report: * 2c0501f41bea1da031777069dd46eb17c5ae8038 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136122509) * a93fe47a7f1a91c8a33e7cac2bfc095e3f17012b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136270502) * 649d050fe4173a390df026156f6e9bae4f346360 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/136299400) * 08dafb5d2c6f38599bf86c06516465aeaa324941 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136328000) * 8700267a462544e3d51aa40baa60ea07482305c5 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136460282) * b90d7ea0e63b16b064f7e54e886202fff63a7516 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136474353) * 0366a60deac3f1da4902e76a7879bd75996dc15b : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137744753) * 2d1421dc8595923aa04200a90dcc3a1eb2f9229e : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137877709) * f778ef42223274946279a328552684b7c03e1d1b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/138184361) * 298d6c299a83f2e2424fce5b54b25dc11b2fdcbc : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/138768101) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10146: [FLINK-14188][runtime] TaskExecutor derive and register with default slot resource profile
flinkbot edited a comment on issue #10146: [FLINK-14188][runtime] TaskExecutor derive and register with default slot resource profile URL: https://github.com/apache/flink/pull/10146#issuecomment-552307115 ## CI report: * 25f9e4b87846e5a736aa329c834f82962e1f50c4 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/135875925) * c4b4f4d5c88a1a5009325a6260cf2d91ed69ca96 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/135885120) * 2d5269d2498d96550682d113d61382b7a9ac9721 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/135902960) * 5ee8701f76b9e6f2dcb451eb988371bea3b0a38d : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136486584) * 2c52d7157f5e1b25dfaa00fe50cf7b04e7d6a97e : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136497720) * 2d734eeff7480adc2ea1f3695f31ba5a169f3a05 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136501966) * 4edae43ff7eaf0357f5e8604b02b88749c8d153f : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136522752) * 927a11838172fe792636923e9378677f92a48b73 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/138028348) * a73de7a3fc63fe2d2a9bd12e03efb45bfcbf9ca8 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138455883) * d06a271e355a36fd316f35d98e2905df8829273a : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/138768094) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-14947) Implement LocalExecutor as new Executor interface
[
https://issues.apache.org/jira/browse/FLINK-14947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985232#comment-16985232
]
Zili Chen commented on FLINK-14947:
---
Sorry for late response but I think you already got it in the pull request of
FLINK-14972. The idea here is that {{RemoteExecutor}} should has configuration
about host:port of web interface to communicate with, so that no matter in
which deployment the manner keeps.
> Implement LocalExecutor as new Executor interface
> -
>
> Key: FLINK-14947
> URL: https://issues.apache.org/jira/browse/FLINK-14947
> Project: Flink
> Issue Type: Sub-task
> Components: Client / Job Submission
>Reporter: Zili Chen
>Assignee: Kostas Kloudas
>Priority: Major
> Fix For: 1.10.0
>
>
> We can replace {{PlanExecutor}} things with new Executor interface. One of
> this series is implement a {{LocalExecutor}} that execute pipeline within a
> {{MiniCluster}}. For proper lifecycle management I would wait for FLINK-14762
> & FLINK-14948 being merged.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (FLINK-14854) Add executeAsync() method to execution environments
[
https://issues.apache.org/jira/browse/FLINK-14854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985231#comment-16985231
]
Zili Chen commented on FLINK-14854:
---
I notice that for batch code path, it is easy we introduce a
{{executeAsync(jobName?)}} method while in streaming code path things become a
bit tricky that we modify StreamGraph after compilation in blink planner.
Trying to find a clean way for extend asynchronous version {{execute}} in
streaming code path, falling back to add {{@Internal
executeAsync(StreamGraph)}}.
> Add executeAsync() method to execution environments
> ---
>
> Key: FLINK-14854
> URL: https://issues.apache.org/jira/browse/FLINK-14854
> Project: Flink
> Issue Type: Sub-task
> Components: API / DataSet, API / DataStream
>Reporter: Aljoscha Krettek
>Assignee: Zili Chen
>Priority: Major
>
> The new {{executeAsync()}} method should return a {{JobClient}}. This exposes
> the new executor/job client work on the user API.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] TisonKun commented on issue #10346: [FLINK-14972] Make Remote(Stream)Environment use Executors.
TisonKun commented on issue #10346: [FLINK-14972] Make Remote(Stream)Environment use Executors. URL: https://github.com/apache/flink/pull/10346#issuecomment-559905389 OK make sense. Possibly we can remote `RemoteExecutor extends PlanExecutor` since it is no more in used. I think eventually we have executors in this new inheritance hierarchy and don't need `PlanExecutor` any more. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-14893) Using Child ClassLoader to load class when Parent ClassLoader couldn't load in ParentFirstPatterns
[ https://issues.apache.org/jira/browse/FLINK-14893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985230#comment-16985230 ] hailong wang commented on FLINK-14893: -- Hi, [~chesnay]. I am glad to work on this. Thanks you for assigning this issue to me. > Using Child ClassLoader to load class when Parent ClassLoader couldn't load > in ParentFirstPatterns > > > Key: FLINK-14893 > URL: https://issues.apache.org/jira/browse/FLINK-14893 > Project: Flink > Issue Type: Improvement > Components: Runtime / Task >Affects Versions: 1.9.0 >Reporter: hailong wang >Priority: Major > Fix For: 1.10.0 > > > In ChildFirstClassLoader#loadClass, when a class is in ParentFirstPattern, > but it load failed for that parent does not contain it. It will throw a > ClassNotFoundException. I think when loading failed, we should use findClass > to load later. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #10146: [FLINK-14188][runtime] TaskExecutor derive and register with default slot resource profile
flinkbot edited a comment on issue #10146: [FLINK-14188][runtime] TaskExecutor derive and register with default slot resource profile URL: https://github.com/apache/flink/pull/10146#issuecomment-552307115 ## CI report: * 25f9e4b87846e5a736aa329c834f82962e1f50c4 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/135875925) * c4b4f4d5c88a1a5009325a6260cf2d91ed69ca96 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/135885120) * 2d5269d2498d96550682d113d61382b7a9ac9721 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/135902960) * 5ee8701f76b9e6f2dcb451eb988371bea3b0a38d : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136486584) * 2c52d7157f5e1b25dfaa00fe50cf7b04e7d6a97e : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136497720) * 2d734eeff7480adc2ea1f3695f31ba5a169f3a05 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136501966) * 4edae43ff7eaf0357f5e8604b02b88749c8d153f : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136522752) * 927a11838172fe792636923e9378677f92a48b73 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/138028348) * a73de7a3fc63fe2d2a9bd12e03efb45bfcbf9ca8 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138455883) * d06a271e355a36fd316f35d98e2905df8829273a : UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10161: [FLINK-13986][runtime] Clean up legacy code for FLIP-49.
flinkbot edited a comment on issue #10161: [FLINK-13986][runtime] Clean up legacy code for FLIP-49. URL: https://github.com/apache/flink/pull/10161#issuecomment-552882313 ## CI report: * 2c0501f41bea1da031777069dd46eb17c5ae8038 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136122509) * a93fe47a7f1a91c8a33e7cac2bfc095e3f17012b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136270502) * 649d050fe4173a390df026156f6e9bae4f346360 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/136299400) * 08dafb5d2c6f38599bf86c06516465aeaa324941 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136328000) * 8700267a462544e3d51aa40baa60ea07482305c5 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136460282) * b90d7ea0e63b16b064f7e54e886202fff63a7516 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136474353) * 0366a60deac3f1da4902e76a7879bd75996dc15b : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137744753) * 2d1421dc8595923aa04200a90dcc3a1eb2f9229e : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/137877709) * f778ef42223274946279a328552684b7c03e1d1b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/138184361) * 298d6c299a83f2e2424fce5b54b25dc11b2fdcbc : UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] walterddr commented on a change in pull request #10193: [FLINK-13938][yarn] Use pre-uploaded flink binary to accelerate flink submission
walterddr commented on a change in pull request #10193: [FLINK-13938][yarn] Use
pre-uploaded flink binary to accelerate flink submission
URL: https://github.com/apache/flink/pull/10193#discussion_r352259924
##
File path: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java
##
@@ -596,6 +644,30 @@ static ContainerLaunchContext createTaskExecutorContext(
return ctx;
}
+ static Map getPreUploadedFlinkFiles(
+ @Nullable String flinkSharedBinary,
+ Configuration yarnConfiguration) {
+ Map flinkShareFiles = new HashMap<>();
+ if (flinkSharedBinary != null) {
+ try {
+ FileSystem fileSystem =
FileSystem.get(yarnConfiguration);
+ Path flinkSharedPath = new
Path(flinkSharedBinary);
+ if (fileSystem.exists(flinkSharedPath)) {
+ RemoteIterator
iterable = fileSystem.listFiles(flinkSharedPath, true);
+ while (iterable.hasNext()) {
+ LocatedFileStatus
locatedFileStatus = iterable.next();
+ String relative =
flinkSharedPath.toUri().relativize(locatedFileStatus.getPath().toUri()).getPath();
+ flinkShareFiles.put(relative,
locatedFileStatus);
+ LOG.debug("Found pre-uploaded
file {} under {}", relative, flinkSharedPath);
+ }
+ }
+ } catch (IOException e) {
+ LOG.warn("Error to get the ");
Review comment:
oops. missed this one.
```
LOG.warn("Error getting pre-uploaded Flink binary via path: {}",
flinkSharedBinary, e);
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime] Extend TaskExecutor to support dynamic slot allocation
azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime]
Extend TaskExecutor to support dynamic slot allocation
URL: https://github.com/apache/flink/pull/10330#discussion_r352216048
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotTable.java
##
@@ -205,10 +221,11 @@ public SlotReport createSlotReport(ResourceID
resourceId) {
// -
/**
-* Allocate the slot with the given index for the given job and
allocation id. Returns true if
-* the slot could be allocated. Otherwise it returns false.
+* Allocate the slot with the given index for the given job and
allocation id. If negative index is
+* given, a new auto increasing index will be generated. Returns true
if the slot could be allocated.
Review comment:
Do we actually still need indexing by index of slots in TM?
Would it be enough to keep only indexing by `AllocationID`?
It seems the index is currently needed only in legacy RM to statically
identify free slots in the report. The current implementation of slot report
creation looks compatible with the legacy RM. Dynamic slots could just stay
with negative index and added to the report as now.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime] Extend TaskExecutor to support dynamic slot allocation
azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime]
Extend TaskExecutor to support dynamic slot allocation
URL: https://github.com/apache/flink/pull/10330#discussion_r352208420
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotTable.java
##
@@ -560,6 +589,10 @@ public Task getTask(ExecutionAttemptID
executionAttemptID) {
* @return Allocation id of the specified slot if allocated; otherwise
null
*/
public AllocationID getCurrentAllocation(int index) {
+ TaskSlot taskSlot = taskSlots.get(index);
+ if (taskSlot == null) {
+ return null;
+ }
return taskSlots.get(index).getAllocationId();
Review comment:
`return taskSlot.getAllocationId();`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime] Extend TaskExecutor to support dynamic slot allocation
azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime]
Extend TaskExecutor to support dynamic slot allocation
URL: https://github.com/apache/flink/pull/10330#discussion_r352207899
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotTable.java
##
@@ -412,7 +441,7 @@ public boolean tryMarkSlotActive(JobID jobId, AllocationID
allocationId) {
public boolean isSlotFree(int index) {
TaskSlot taskSlot = taskSlots.get(index);
- return taskSlot.isFree();
+ return taskSlot == null || taskSlot.isFree();
Review comment:
`taskSlot.isFree()` should be always `false` now if `taskSlot != null`.
We could also consider removing `TaskSlotState#ACTIVE` and `FREE`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime] Extend TaskExecutor to support dynamic slot allocation
azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime]
Extend TaskExecutor to support dynamic slot allocation
URL: https://github.com/apache/flink/pull/10330#discussion_r352228685
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/SlotReport.java
##
@@ -46,18 +50,33 @@ public SlotReport(SlotStatus slotStatus) {
}
public SlotReport(final Collection slotsStatus) {
+ this(slotsStatus,
Review comment:
we should annotate the first 2 constructors with `@VisibleForTesting`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime] Extend TaskExecutor to support dynamic slot allocation
azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime]
Extend TaskExecutor to support dynamic slot allocation
URL: https://github.com/apache/flink/pull/10330#discussion_r35143
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfileBookkeeper.java
##
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.clusterframework.types;
+
+import org.apache.flink.util.Preconditions;
+
+/**
+ * Bookkeeper for {@link ResourceProfile}.
+ *
+ * For a given total resource budget, this class handles reserving and
releasing resources
+ * from the budget, and rejects reservations if they cannot be satisfied by
the remaining budget.
+ *
+ * Both the total budget and the reservations are in the form of {@link
ResourceProfile}.
+ */
+public class ResourceProfileBookkeeper {
+
+ private final ResourceProfile totalBudget;
+
+ private ResourceProfile availableBudget;
+
+ public ResourceProfileBookkeeper(final ResourceProfile totalBudget) {
+ checkResourceProfileNotNullOrUnknown(totalBudget);
+ this.totalBudget = totalBudget;
+ this.availableBudget = totalBudget;
+ }
+
+ public ResourceProfile getTotalBudget() {
+ return totalBudget;
+ }
+
+ public ResourceProfile getAvailableBudget() {
+ return availableBudget;
+ }
+
+ public synchronized boolean reserve(final ResourceProfile reservation) {
+ checkResourceProfileNotNullOrUnknown(reservation);
+ if (!availableBudget.isMatching(reservation)) {
+ return false;
+ }
+
+ availableBudget = availableBudget.subtract(reservation);
+ return true;
+ }
+
+ public synchronized boolean release(final ResourceProfile reservation) {
+ checkResourceProfileNotNullOrUnknown(reservation);
+ if
(!totalBudget.isMatching(availableBudget.merge(reservation))) {
+ return false;
+ }
+
+ availableBudget = availableBudget.merge(reservation);
Review comment:
put `availableBudget.merge(reservation)` into a local var to reuse?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime] Extend TaskExecutor to support dynamic slot allocation
azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime]
Extend TaskExecutor to support dynamic slot allocation
URL: https://github.com/apache/flink/pull/10330#discussion_r352199731
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
##
@@ -296,22 +291,11 @@ private static TaskSlotTable createTaskSlotTable(
final long timerServiceShutdownTimeout,
final int pageSize) {
final int numberOfSlots = (int) (1.0 /
taskExecutorResourceSpec.getDefaultSlotFraction());
- final List resourceProfiles =
- Collections.nCopies(numberOfSlots,
-
TaskExecutorResourceUtils.generateDefaultSlotResourceProfile(taskExecutorResourceSpec));
+ final ResourceProfile resourceProfile =
TaskExecutorResourceUtils.generateDefaultSlotResourceProfile(taskExecutorResourceSpec);
final TimerService timerService = new
TimerService<>(
new ScheduledThreadPoolExecutor(1),
timerServiceShutdownTimeout);
- return new
TaskSlotTable(createTaskSlotsFromResources(resourceProfiles, pageSize),
timerService);
- }
-
- private static List createTaskSlotsFromResources(
Review comment:
could you move the whole `createTaskSlotsFromResources` into `TaskSlotTable`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime] Extend TaskExecutor to support dynamic slot allocation
azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime]
Extend TaskExecutor to support dynamic slot allocation
URL: https://github.com/apache/flink/pull/10330#discussion_r352221149
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfileBookkeeper.java
##
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.clusterframework.types;
+
+import org.apache.flink.util.Preconditions;
+
+/**
+ * Bookkeeper for {@link ResourceProfile}.
+ *
+ * For a given total resource budget, this class handles reserving and
releasing resources
+ * from the budget, and rejects reservations if they cannot be satisfied by
the remaining budget.
+ *
+ * Both the total budget and the reservations are in the form of {@link
ResourceProfile}.
+ */
+public class ResourceProfileBookkeeper {
Review comment:
`(TaskExecutor)AvailableResourceManager`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime] Extend TaskExecutor to support dynamic slot allocation
azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime]
Extend TaskExecutor to support dynamic slot allocation
URL: https://github.com/apache/flink/pull/10330#discussion_r352208816
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/SlotID.java
##
@@ -32,6 +32,13 @@
*/
public class SlotID implements ResourceIDRetrievable, Serializable {
+ /**
+* Generate a SlotID without actual slot index for dynamic slot
allocation.
+*/
+ public static SlotID generateDynamicSlotID(ResourceID resourceID) {
Review comment:
we usually put static methods at the end
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime] Extend TaskExecutor to support dynamic slot allocation
azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime]
Extend TaskExecutor to support dynamic slot allocation
URL: https://github.com/apache/flink/pull/10330#discussion_r352221737
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfileBookkeeper.java
##
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.clusterframework.types;
+
+import org.apache.flink.util.Preconditions;
+
+/**
+ * Bookkeeper for {@link ResourceProfile}.
+ *
+ * For a given total resource budget, this class handles reserving and
releasing resources
+ * from the budget, and rejects reservations if they cannot be satisfied by
the remaining budget.
+ *
+ * Both the total budget and the reservations are in the form of {@link
ResourceProfile}.
+ */
+public class ResourceProfileBookkeeper {
+
+ private final ResourceProfile totalBudget;
+
+ private ResourceProfile availableBudget;
+
+ public ResourceProfileBookkeeper(final ResourceProfile totalBudget) {
+ checkResourceProfileNotNullOrUnknown(totalBudget);
+ this.totalBudget = totalBudget;
+ this.availableBudget = totalBudget;
+ }
+
+ public ResourceProfile getTotalBudget() {
+ return totalBudget;
+ }
+
+ public ResourceProfile getAvailableBudget() {
+ return availableBudget;
+ }
+
+ public synchronized boolean reserve(final ResourceProfile reservation) {
Review comment:
any reason to make this class thread safe?
It is accessed the same way as slot table which is not thread safe.
Is it not supposed to be accessed only from TM main thread?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime] Extend TaskExecutor to support dynamic slot allocation
azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime]
Extend TaskExecutor to support dynamic slot allocation
URL: https://github.com/apache/flink/pull/10330#discussion_r352204987
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotTable.java
##
@@ -196,16 +217,21 @@ public SlotReport createSlotReport(ResourceID
resourceId) {
public boolean allocateSlot(int index, JobID jobId, AllocationID
allocationId, Time slotTimeout) {
checkInit();
+ Preconditions.checkArgument(index < numberSlots);
+
TaskSlot taskSlot = allocationIDTaskSlotMap.get(allocationId);
if (taskSlot != null) {
LOG.info("Allocation ID {} is already allocated in
{}.", allocationId, taskSlot);
return false;
}
- taskSlot = taskSlots.get(index);
+
+ taskSlot = new TaskSlot(index, defaultSlotResourceProfile,
memoryPageSize);
boolean result = taskSlot.allocate(jobId, allocationId);
if (result) {
+ taskSlots.put(index, taskSlot);
Review comment:
`result` should be always `true` for the newly created slot but we could
sanity-check whether `taskSlots` contains the `index`, basically non-freed slot.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime] Extend TaskExecutor to support dynamic slot allocation
azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime]
Extend TaskExecutor to support dynamic slot allocation
URL: https://github.com/apache/flink/pull/10330#discussion_r352228283
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotTable.java
##
@@ -242,10 +263,15 @@ public boolean allocateSlot(int index, JobID jobId,
AllocationID allocationId, T
return false;
}
+ ResourceProfile slotResourceProfile =
defaultSlotResourceProfile;
+ if (!resourceProfileBookkeeper.reserve(slotResourceProfile)) {
+ return false;
Review comment:
would be nice to log how much we tried to allocate and what was available
budget in case of failure
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime] Extend TaskExecutor to support dynamic slot allocation
azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime]
Extend TaskExecutor to support dynamic slot allocation
URL: https://github.com/apache/flink/pull/10330#discussion_r352200275
##
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotUtils.java
##
@@ -62,17 +59,21 @@ public static TaskSlotTable createTaskSlotTable(int
numberOfSlots, Time timeout)
private static TaskSlotTable createTaskSlotTable(
int numberOfSlots,
TimerService timerService) {
- return new TaskSlotTable(createDefaultSlots(numberOfSlots),
timerService);
+ return new TaskSlotTable(numberOfSlots,
+ createDefaultSlotResourceProfile(),
+ createDefaultMemoryPageSize(),
+ timerService);
}
- public static TimerService createDefaultTimerService(long
shutdownTimeout) {
- return new TimerService<>(TestingUtils.defaultExecutor(),
shutdownTimeout);
+ public static ResourceProfile createDefaultSlotResourceProfile() {
+ return DEFAULT_RESOURCE_PROFILE;
Review comment:
why do we need `createDefaultSlotResourceProfile` and
`createDefaultMemoryPageSize`? why not just use `DEFAULT_RESOURCE_PROFILE` and
`MemoryManager.MIN_PAGE_SIZE`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime] Extend TaskExecutor to support dynamic slot allocation
azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime] Extend TaskExecutor to support dynamic slot allocation URL: https://github.com/apache/flink/pull/10330#discussion_r352229577 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerImpl.java ## @@ -854,6 +854,7 @@ private void allocateSlot(TaskManagerSlot taskManagerSlot, PendingSlotRequest pe slotId, pendingSlotRequest.getJobId(), allocationId, + ResourceProfile.ZERO, Review comment: `pendingSlotRequest.getResourceProfile()` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime] Extend TaskExecutor to support dynamic slot allocation
azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime]
Extend TaskExecutor to support dynamic slot allocation
URL: https://github.com/apache/flink/pull/10330#discussion_r352227509
##
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotUtils.java
##
@@ -69,6 +70,22 @@ public static ResourceProfile
createDefaultSlotResourceProfile() {
return DEFAULT_RESOURCE_PROFILE;
}
+ public static ResourceProfile createTotalResourceProfile(int
numberOfSlots) {
+ return createTotalResourceProfile(numberOfSlots,
DEFAULT_RESOURCE_PROFILE);
+ }
+
+ public static ResourceProfile createTotalResourceProfile(int
numberOfSlots, ResourceProfile defaultResourceProfile) {
+ ResourceProfile result = defaultResourceProfile;
+ while (numberOfSlots > 1) {
+ result = result.merge(result);
+ if (numberOfSlots % 2 != 0) {
+ result = result.merge(defaultResourceProfile);
+ }
+ numberOfSlots = numberOfSlots / 2;
Review comment:
I would keep it as simple loop merging `defaultResourceProfile`
`numberOfSlots - 1` times for simpler readability.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime] Extend TaskExecutor to support dynamic slot allocation
azagrebin commented on a change in pull request #10330: [FLINK-14189][runtime]
Extend TaskExecutor to support dynamic slot allocation
URL: https://github.com/apache/flink/pull/10330#discussion_r352200409
##
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotUtils.java
##
@@ -62,17 +59,21 @@ public static TaskSlotTable createTaskSlotTable(int
numberOfSlots, Time timeout)
private static TaskSlotTable createTaskSlotTable(
int numberOfSlots,
TimerService timerService) {
- return new TaskSlotTable(createDefaultSlots(numberOfSlots),
timerService);
+ return new TaskSlotTable(numberOfSlots,
Review comment:
`numberOfSlots` to the next line
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Closed] (FLINK-14976) Cassandra Connector leaks Semaphore on Throwable; hangs on close
[
https://issues.apache.org/jira/browse/FLINK-14976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrey Zagrebin closed FLINK-14976.
---
Resolution: Fixed
merged into master by 07b66b60dd8c72f5ecd98054fa322d768c774e74
merged into 1.9 by 6039e11c1cad20fe3468715ff594a49cbdc8d95e
merged into 1.8 by 8747e3d4ec29394fa65e875b9da68b2af863f92a
> Cassandra Connector leaks Semaphore on Throwable; hangs on close
>
>
> Key: FLINK-14976
> URL: https://issues.apache.org/jira/browse/FLINK-14976
> Project: Flink
> Issue Type: Bug
> Components: Connectors / Cassandra
>Affects Versions: 1.8.2, 1.10.0, 1.9.1
>Reporter: Mads Chr. Olesen
>Assignee: Mads Chr. Olesen
>Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This issue was mostly fixed in FLINK-13059; unfortunately, the fix only
> caught {{Exception}} so any non-{{Exception Throwable}} can still cause the
> issue of leaking semaphores.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #10368: [FLINK-14983][table-common] Add interfaces for input type inference
flinkbot edited a comment on issue #10368: [FLINK-14983][table-common] Add interfaces for input type inference URL: https://github.com/apache/flink/pull/10368#issuecomment-559849270 ## CI report: * a38c5d9c361f67d4922932f3634c2387288c1d6e : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138737366) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] twalthr commented on a change in pull request #10342: [FLINK-14967][table] Add a utility for creating data types via reflection
twalthr commented on a change in pull request #10342: [FLINK-14967][table] Add
a utility for creating data types via reflection
URL: https://github.com/apache/flink/pull/10342#discussion_r352221356
##
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/annotation/DataTypeHint.java
##
@@ -0,0 +1,241 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.annotation;
+
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.api.common.typeutils.TypeSerializer;
+import org.apache.flink.table.api.DataTypes;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.inference.TypeInference;
+import org.apache.flink.table.types.logical.LogicalType;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+
+/**
+ * A hint that influences the reflection-based extraction of a {@link
DataType}.
+ *
+ * Data type hints can parameterize or replace the default extraction logic
of individual function parameters
+ * and return types, structured classes, or fields of structured classes. An
implementer can choose to
+ * what extent the default extraction logic should be modified.
+ *
+ * The following examples show how to explicitly specify data types, how to
parameterize the extraction
+ * logic, or how to accept any data type as an input data type:
+ *
+ * {@code @DataTypeHint("INT")} defines an INT data type with a default
conversion class.
+ *
+ * {@code @DataTypeHint(value = "TIMESTAMP(3)", bridgedTo =
java.sql.Timestamp.class)} defines a TIMESTAMP
+ * data type of millisecond precision with an explicit conversion class.
+ *
+ * {@code @DataTypeHint(value = "RAW", rawSerializer =
MyCustomSerializer.class)} defines a RAW data type
+ * with a custom serializer class.
+ *
+ * {@code @DataTypeHint(version = V1, allowRawGlobally = TRUE)}
parameterizes the extraction by requesting
+ * a extraction logic version of 1 and allowing the RAW data type in this
structured type (and possibly
+ * nested fields).
+ *
+ * {@code @DataTypeHint(bridgedTo = MyPojo.class, allowRawGlobally = TRUE)}
defines that a type should be
+ * extracted from the given conversion class but with parameterized extraction
for allowing RAW types.
+ *
+ * {@code @DataTypeHint(inputGroup = ANY)} defines that the input
validation should accept any
+ * data type.
+ *
+ * Note: All hint parameters are optional. Hint parameters defined on top
of a structured type are
+ * inherited by all (deeply) nested fields unless annotated differently. For
example, all occurrences of
+ * {@link java.math.BigDecimal} will be extracted as {@code DECIMAL(12, 2)} if
the enclosing structured
+ * class is annotated with {@code @DataTypeHint(defaultDecimalPrecision = 12,
defaultDecimalScale = 2)}. Individual
+ * field annotations allow to deviate from those default values.
+ */
+@PublicEvolving
+@Retention(RetentionPolicy.RUNTIME)
+@Target({ElementType.TYPE, ElementType.METHOD, ElementType.FIELD,
ElementType.PARAMETER})
+public @interface DataTypeHint {
+
+ // Note to implementers:
+ // Because "null" is not supported as an annotation value. Every
annotation parameter has
+ // some representation for unknown values in order to merge multi-level
annotations.
+
+ //
+ // Explicit data type specification
+ //
+
+ /**
+* The explicit string representation of a data type. See {@link
DataTypes} for a list of supported
+* data types. For example, {@code INT} for an integer data type or
{@code DECIMAL(12, 5)} for decimal
+* data type with precision 12 and scale 5.
+*
+* Use an unparameterized {@code RAW} string for explicitly
declaring an opaque data type. For
+* Flink's default RAW serializer, use {@code @DataTypeHint("RAW")}.
For a custom RAW serializer,
+* use {@code @DataTypeHint(value =
[GitHub] [flink] twalthr commented on a change in pull request #10342: [FLINK-14967][table] Add a utility for creating data types via reflection
twalthr commented on a change in pull request #10342: [FLINK-14967][table] Add
a utility for creating data types via reflection
URL: https://github.com/apache/flink/pull/10342#discussion_r352218595
##
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/annotation/DataTypeHint.java
##
@@ -0,0 +1,241 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.annotation;
+
+import org.apache.flink.annotation.PublicEvolving;
+import org.apache.flink.api.common.typeutils.TypeSerializer;
+import org.apache.flink.table.api.DataTypes;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.inference.TypeInference;
+import org.apache.flink.table.types.logical.LogicalType;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+
+/**
+ * A hint that influences the reflection-based extraction of a {@link
DataType}.
+ *
+ * Data type hints can parameterize or replace the default extraction logic
of individual function parameters
+ * and return types, structured classes, or fields of structured classes. An
implementer can choose to
+ * what extent the default extraction logic should be modified.
+ *
+ * The following examples show how to explicitly specify data types, how to
parameterize the extraction
+ * logic, or how to accept any data type as an input data type:
+ *
+ * {@code @DataTypeHint("INT")} defines an INT data type with a default
conversion class.
+ *
+ * {@code @DataTypeHint(value = "TIMESTAMP(3)", bridgedTo =
java.sql.Timestamp.class)} defines a TIMESTAMP
+ * data type of millisecond precision with an explicit conversion class.
+ *
+ * {@code @DataTypeHint(value = "RAW", rawSerializer =
MyCustomSerializer.class)} defines a RAW data type
+ * with a custom serializer class.
+ *
+ * {@code @DataTypeHint(version = V1, allowRawGlobally = TRUE)}
parameterizes the extraction by requesting
+ * a extraction logic version of 1 and allowing the RAW data type in this
structured type (and possibly
+ * nested fields).
+ *
+ * {@code @DataTypeHint(bridgedTo = MyPojo.class, allowRawGlobally = TRUE)}
defines that a type should be
+ * extracted from the given conversion class but with parameterized extraction
for allowing RAW types.
+ *
+ * {@code @DataTypeHint(inputGroup = ANY)} defines that the input
validation should accept any
+ * data type.
+ *
+ * Note: All hint parameters are optional. Hint parameters defined on top
of a structured type are
+ * inherited by all (deeply) nested fields unless annotated differently. For
example, all occurrences of
+ * {@link java.math.BigDecimal} will be extracted as {@code DECIMAL(12, 2)} if
the enclosing structured
+ * class is annotated with {@code @DataTypeHint(defaultDecimalPrecision = 12,
defaultDecimalScale = 2)}. Individual
+ * field annotations allow to deviate from those default values.
+ */
+@PublicEvolving
+@Retention(RetentionPolicy.RUNTIME)
+@Target({ElementType.TYPE, ElementType.METHOD, ElementType.FIELD,
ElementType.PARAMETER})
+public @interface DataTypeHint {
+
+ // Note to implementers:
+ // Because "null" is not supported as an annotation value. Every
annotation parameter has
+ // some representation for unknown values in order to merge multi-level
annotations.
+
+ //
+ // Explicit data type specification
+ //
+
+ /**
+* The explicit string representation of a data type. See {@link
DataTypes} for a list of supported
+* data types. For example, {@code INT} for an integer data type or
{@code DECIMAL(12, 5)} for decimal
+* data type with precision 12 and scale 5.
+*
+* Use an unparameterized {@code RAW} string for explicitly
declaring an opaque data type. For
+* Flink's default RAW serializer, use {@code @DataTypeHint("RAW")}.
For a custom RAW serializer,
+* use {@code @DataTypeHint(value =
[GitHub] [flink] azagrebin commented on issue #10339: [FLINK-14976][cassandra] Release semaphore on all Throwable's in send()
azagrebin commented on issue #10339: [FLINK-14976][cassandra] Release semaphore on all Throwable's in send() URL: https://github.com/apache/flink/pull/10339#issuecomment-559856230 merged into master by 07b66b60dd8c72f5ecd98054fa322d768c774e74 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] azagrebin merged pull request #10339: [FLINK-14976][cassandra] Release semaphore on all Throwable's in send()
azagrebin merged pull request #10339: [FLINK-14976][cassandra] Release semaphore on all Throwable's in send() URL: https://github.com/apache/flink/pull/10339 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9984: [FLINK-9495][kubernetes] Implement ResourceManager for Kubernetes.
flinkbot edited a comment on issue #9984: [FLINK-9495][kubernetes] Implement ResourceManager for Kubernetes. URL: https://github.com/apache/flink/pull/9984#issuecomment-545881191 ## CI report: * 802ebf37e3d932169f9826b40df483bb5e9ac064 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/133366796) * f16938ce2fb38ae216def737d14643b94d6083a1 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/133940607) * 20de5cfc7af9a8ba57080d5218fd0293f393a40e : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/133998545) * 56bfbb65802c1d5c48caa625a152070934bb5d79 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134010321) * 3ea229382fef64b1046673c79ff845d4689c5db4 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137145261) * 3169988a33e0126e79cd449740c93d3561296ead : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138017410) * a0dd858b0b91443fc87895a2d32ebfbbc0b9fe4c : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138730857) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10368: [FLINK-14983][table-common] Add interfaces for input type inference
flinkbot edited a comment on issue #10368: [FLINK-14983][table-common] Add interfaces for input type inference URL: https://github.com/apache/flink/pull/10368#issuecomment-559849270 ## CI report: * a38c5d9c361f67d4922932f3634c2387288c1d6e : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/138737366) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #10193: [FLINK-13938][yarn] Use pre-uploaded flink binary to accelerate flink submission
TisonKun commented on a change in pull request #10193: [FLINK-13938][yarn] Use
pre-uploaded flink binary to accelerate flink submission
URL: https://github.com/apache/flink/pull/10193#discussion_r352214874
##
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##
@@ -155,6 +156,10 @@
private String zookeeperNamespace;
+ // Pre-uploaded flink files, key is relative path(for example,
lib/flink-dist_{version}.jar),
+ // and value is remote file status.
+ private final Map preUploadedFlinkFiles;
Review comment:
nit: follow the other configs pattern, i.e., init a empty map and call
`addAll` when deploy instead of initializing in constructor. It can be a
follow-up we generally refactor deployment inside YarnClusterDescriptor.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #10193: [FLINK-13938][yarn] Use pre-uploaded flink binary to accelerate flink submission
TisonKun commented on a change in pull request #10193: [FLINK-13938][yarn] Use
pre-uploaded flink binary to accelerate flink submission
URL: https://github.com/apache/flink/pull/10193#discussion_r352214528
##
File path: flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java
##
@@ -596,6 +644,30 @@ static ContainerLaunchContext createTaskExecutorContext(
return ctx;
}
+ static Map getPreUploadedFlinkFiles(
+ @Nullable String flinkSharedBinary,
+ Configuration yarnConfiguration) {
+ Map flinkShareFiles = new HashMap<>();
+ if (flinkSharedBinary != null) {
+ try {
+ FileSystem fileSystem =
FileSystem.get(yarnConfiguration);
+ Path flinkSharedPath = new
Path(flinkSharedBinary);
+ if (fileSystem.exists(flinkSharedPath)) {
+ RemoteIterator
iterable = fileSystem.listFiles(flinkSharedPath, true);
+ while (iterable.hasNext()) {
+ LocatedFileStatus
locatedFileStatus = iterable.next();
+ String relative =
flinkSharedPath.toUri().relativize(locatedFileStatus.getPath().toUri()).getPath();
+ flinkShareFiles.put(relative,
locatedFileStatus);
+ LOG.debug("Found pre-uploaded
file {} under {}", relative, flinkSharedPath);
+ }
+ }
+ } catch (IOException e) {
+ LOG.warn("Error to get the ");
Review comment:
@walterddr @wangyang0918 please fix this log when merging.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on a change in pull request #10193: [FLINK-13938][yarn] Use pre-uploaded flink binary to accelerate flink submission
TisonKun commented on a change in pull request #10193: [FLINK-13938][yarn] Use
pre-uploaded flink binary to accelerate flink submission
URL: https://github.com/apache/flink/pull/10193#discussion_r352214594
##
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java
##
@@ -155,6 +156,10 @@
private String zookeeperNamespace;
+ // Pre-uploaded flink files, key is relative path(for example,
lib/flink-dist_{version}.jar),
Review comment:
nit: can be doc comment.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10114: [FLINK -14651][runtime] Enable DefaultScheduler
flinkbot edited a comment on issue #10114: [FLINK -14651][runtime] Enable DefaultScheduler URL: https://github.com/apache/flink/pull/10114#issuecomment-551014940 ## CI report: * c436371614d7db5dfc8c97e01a4594c3139715db : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/135418856) * d2f3a108547945633de80938684aa9c750534269 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/135432444) * dcb4596a1246234038c1f327d9e858b7c654966e : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/135445805) * 3bf7b045474d4bf278eb416491c32c9fb3c218a9 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/135495382) * 90152b07e795bc931c37b4baf2092ba0ee9219f1 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/135649425) * 1657e4dd1f3ecbfa2956552efd401641c94a56aa : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/135963847) * 31de348cd4fc6f1c41cdd94853c1e5ecb8206b4c : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136101528) * 641fae6542a62c3ba329e628f69387d53b95b0b6 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136421792) * 639a9c20d8bb35d7fb7fb48511fe62feac619fb9 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136517722) * 8c1235c8b5a1de6a974ea40f0287680d5c1f5f46 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136568224) * 5c508e3be15e685c067cfddfd2450b60c1fcfba7 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136696854) * 72b9c027dd87b09477958fc2d077933491cb0d4d : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136738729) * 44b7e4785aac200e4fc63659d2376a78f566a517 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137159954) * 2b73f20851eed3026e7881c8ae162e2e309848ee : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137238368) * 48bec2c450e8dd14313c58d206d3af0571f45972 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137361133) * e67ebd1eb36cadd4a10e5494168f19074d0640be : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137394691) * 14e06e47a8675be77c07f79fe28cc5c2122005ce : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/137413258) * 99795cfb3fb946c478f4e86c4b53b508e9e42092 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137439435) * aa3aaea5dc747bfe4c06b7f41d1809280526dff6 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137534672) * 93a48786992d6f8ac6f27608fcbf86cd2a2e0d5b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137590164) * 4091ee1e5d61018c60e279a04ff3d39d67c3544b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137725590) * 3a8e1edc7c7a53c030558c5a45867d20d9c90ee3 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137886191) * faf9849aea036ba44162bb6c32ab832bee657f57 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/138628854) * ff4a164ffea359aaacbf9ce848080c1212c2c704 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/138734438) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10368: [FLINK-14983][table-common] Add interfaces for input type inference
flinkbot commented on issue #10368: [FLINK-14983][table-common] Add interfaces for input type inference URL: https://github.com/apache/flink/pull/10368#issuecomment-559849270 ## CI report: * a38c5d9c361f67d4922932f3634c2387288c1d6e : UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10366: [1.8][FLINK-14995][kinesis][legal] Update NOTICE
flinkbot edited a comment on issue #10366: [1.8][FLINK-14995][kinesis][legal] Update NOTICE URL: https://github.com/apache/flink/pull/10366#issuecomment-559835705 ## CI report: * 5c57da1ec7e28742c3b53a7bbc5587c2abac4fa4 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138730813) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10367: [1.9][FLINK-14995][kinesis][legal] Update NOTICE
flinkbot edited a comment on issue #10367: [1.9][FLINK-14995][kinesis][legal] Update NOTICE URL: https://github.com/apache/flink/pull/10367#issuecomment-559835744 ## CI report: * b0e8b316663349ba4d3a9d72643d2bdc75917ffb : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138730828) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (FLINK-14729) Multi-topics consuming from KafkaTableSource
[ https://issues.apache.org/jira/browse/FLINK-14729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985127#comment-16985127 ] Rong Rong commented on FLINK-14729: --- Hi [~fangpengcheng95] [~50man] I think it would be nice if you can share more of the motivation/problem statement for why supporting consumption from multiple topics as the underlying data source for ONE table. One of the reason I can think of is the support for handling something similar to [Kafka DLQ|https://www.confluent.io/blog/kafka-connect-deep-dive-error-handling-dead-letter-queues/] - is this want you are trying to support? > Multi-topics consuming from KafkaTableSource > > > Key: FLINK-14729 > URL: https://issues.apache.org/jira/browse/FLINK-14729 > Project: Flink > Issue Type: New Feature > Components: Connectors / Kafka >Reporter: Leo Zhang >Priority: Major > Labels: features, pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > Hi, all. I propose a new functionality of KafkaTableSource which can consume > multiple topics at the same time. > *Design plan* > * Add a new constructor in KafkaTableSource which accepts topics with List > type as one parameter. > * Modify the existed one which only accepts one topic as string type to call > the proposed one to finish the instantiation. That is to say, wrap this topic > in a list and pass it to the multi-topics-consuming constructor. > * Modify the overridden method createKafkaConsumer in KafkaTableSource to > pass topics as List instead of String. > * Replace the field topic with topics as List type in KafkaTableSourceBase > and modify every place using topic with topics. So we just need to modify the > constructor KafkaTableSourceBase, method getDataStream, and equals and > hashCode. > *Test plan* > There is less to do as KafkaTableSource is based on FlinkKafkaConsumer which > already supports consuming multiple topics and is tested well. Of course, we > can easily add further more tests if needed. > > So what's your opinion? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #10346: [FLINK-14972] Make Remote(Stream)Environment use Executors.
flinkbot edited a comment on issue #10346: [FLINK-14972] Make Remote(Stream)Environment use Executors. URL: https://github.com/apache/flink/pull/10346#issuecomment-559445838 ## CI report: * 9d133e6ba91f6d688401f493cc39729b4b34feb6 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/138552538) * 8ef4796fe5eefa1ba4a8c0411687f1594b84d637 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138557811) * 73d9858a69d860ca089ea776ddb9126d810c9792 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138672498) * de55ac4f29e099597a253c6312fbd089204a039d : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/138717503) * 269e359359c1253756b884ff3d18cbd0ffa46362 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138722990) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10114: [FLINK -14651][runtime] Enable DefaultScheduler
flinkbot edited a comment on issue #10114: [FLINK -14651][runtime] Enable DefaultScheduler URL: https://github.com/apache/flink/pull/10114#issuecomment-551014940 ## CI report: * c436371614d7db5dfc8c97e01a4594c3139715db : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/135418856) * d2f3a108547945633de80938684aa9c750534269 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/135432444) * dcb4596a1246234038c1f327d9e858b7c654966e : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/135445805) * 3bf7b045474d4bf278eb416491c32c9fb3c218a9 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/135495382) * 90152b07e795bc931c37b4baf2092ba0ee9219f1 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/135649425) * 1657e4dd1f3ecbfa2956552efd401641c94a56aa : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/135963847) * 31de348cd4fc6f1c41cdd94853c1e5ecb8206b4c : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136101528) * 641fae6542a62c3ba329e628f69387d53b95b0b6 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136421792) * 639a9c20d8bb35d7fb7fb48511fe62feac619fb9 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136517722) * 8c1235c8b5a1de6a974ea40f0287680d5c1f5f46 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/136568224) * 5c508e3be15e685c067cfddfd2450b60c1fcfba7 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136696854) * 72b9c027dd87b09477958fc2d077933491cb0d4d : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/136738729) * 44b7e4785aac200e4fc63659d2376a78f566a517 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137159954) * 2b73f20851eed3026e7881c8ae162e2e309848ee : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137238368) * 48bec2c450e8dd14313c58d206d3af0571f45972 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137361133) * e67ebd1eb36cadd4a10e5494168f19074d0640be : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137394691) * 14e06e47a8675be77c07f79fe28cc5c2122005ce : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/137413258) * 99795cfb3fb946c478f4e86c4b53b508e9e42092 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137439435) * aa3aaea5dc747bfe4c06b7f41d1809280526dff6 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137534672) * 93a48786992d6f8ac6f27608fcbf86cd2a2e0d5b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137590164) * 4091ee1e5d61018c60e279a04ff3d39d67c3544b : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137725590) * 3a8e1edc7c7a53c030558c5a45867d20d9c90ee3 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137886191) * faf9849aea036ba44162bb6c32ab832bee657f57 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/138628854) * ff4a164ffea359aaacbf9ce848080c1212c2c704 : UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10368: [FLINK-14983][table-common] Add interfaces for input type inference
flinkbot commented on issue #10368: [FLINK-14983][table-common] Add interfaces for input type inference URL: https://github.com/apache/flink/pull/10368#issuecomment-559843992 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the progress of the review. ## Automated Checks Last check on commit a38c5d9c361f67d4922932f3634c2387288c1d6e (Fri Nov 29 16:54:37 UTC 2019) **Warnings:** * No documentation files were touched! Remember to keep the Flink docs up to date! Mention the bot in a comment to re-run the automated checks. ## Review Progress * ❓ 1. The [description] looks good. * ❓ 2. There is [consensus] that the contribution should go into to Flink. * ❓ 3. Needs [attention] from. * ❓ 4. The change fits into the overall [architecture]. * ❓ 5. Overall code [quality] is good. Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands The @flinkbot bot supports the following commands: - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`) - `@flinkbot approve all` to approve all aspects - `@flinkbot approve-until architecture` to approve everything until `architecture` - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention - `@flinkbot disapprove architecture` to remove an approval you gave earlier This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (FLINK-14974) Managed memory fractions should be rounded properly to not summed up to be more than 1.0
[
https://issues.apache.org/jira/browse/FLINK-14974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-14974.
Resolution: Fixed
master: daa2f9590a5db69ee57ebc1c5878799cd08bd2b5
> Managed memory fractions should be rounded properly to not summed up to be
> more than 1.0
>
>
> Key: FLINK-14974
> URL: https://issues.apache.org/jira/browse/FLINK-14974
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / Coordination
>Affects Versions: 1.10.0
>Reporter: Zhu Zhu
>Assignee: Zhu Zhu
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.10.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Managed memory fractions should be rounded to floor at a certain precision
> when divided by the number of operators, otherwise the fractions can be
> summed up to be more than 1.0 due to the double precision issue, and the last
> operator may fail to allocate managed memory it is supposed to be able to
> acquire.
> To achieve that, I think we should change
> {{StreamingJobGraphGenerator#setManagedMemoryFractionForOperator}} to use
> BigDecimal#divide(otherValue, scale, RoundMode.ROUND_DOWN) to calculate the
> fractions. In this way, the sum of the fractions will not exceed 1.0.
> The scale can be a bit larger (maybe 16) so that we only lose little managed
> memory.
> cc [~chesnay]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-14983) Add interfaces for input type inference
[
https://issues.apache.org/jira/browse/FLINK-14983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-14983:
---
Labels: pull-request-available (was: )
> Add interfaces for input type inference
> ---
>
> Key: FLINK-14983
> URL: https://issues.apache.org/jira/browse/FLINK-14983
> Project: Flink
> Issue Type: Sub-task
> Components: Table SQL / API
>Reporter: Timo Walther
>Assignee: Timo Walther
>Priority: Major
> Labels: pull-request-available
>
> The [design
> document|https://docs.google.com/document/d/1RM_-XvD25AldUOl7xRSvA3sascWBa1-Jze3i5mvb7WU/edit#]
> around {{TypeInference}} already mentioned an {{InputTypesInference}} that
> enables the derivation of missing or incomplete input signatures. The Calcite
> equivalent is called {{SqlOperandTypeInference}}.
> For FLIP-65, we will need to implement those interfaces as the planner needs
> infer the {{DataType}} s out of logical types that come from the logical
> query. This is also beneficial to support the {{NULL}} literal in the future.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] zentol merged pull request #10341: [FLINK-14974][runtime] Calculate managed memory fractions with BigDecimal and round down it properly
zentol merged pull request #10341: [FLINK-14974][runtime] Calculate managed memory fractions with BigDecimal and round down it properly URL: https://github.com/apache/flink/pull/10341 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] twalthr opened a new pull request #10368: [FLINK-14983][table-common] Add interfaces for input type inference
twalthr opened a new pull request #10368: [FLINK-14983][table-common] Add interfaces for input type inference URL: https://github.com/apache/flink/pull/10368 ## What is the purpose of the change This adds a similar class as Calcite's `SqlOperandTypeInference` to Flink's type inference. For FLIP-65, we will need to implement those interfaces as the planner needs infer the `DataType`s out of logical types that come from the logical query. This is also beneficial to support the NULL literal in the future. ## Brief change log - Introduction of `InputTypeStrategy` - Update of the `TypeInferenceUtil` - Integration into `ResolveCallByArgumentsRule` (not used yet) - Implementation of built-in `InputTypeStrategies` ## Verifying this change This change added tests and can be verified as follows: `InputTypeStrategiesTest` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? yes - If yes, how is the feature documented? JavaDocs This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #9984: [FLINK-9495][kubernetes] Implement ResourceManager for Kubernetes.
flinkbot edited a comment on issue #9984: [FLINK-9495][kubernetes] Implement ResourceManager for Kubernetes. URL: https://github.com/apache/flink/pull/9984#issuecomment-545881191 ## CI report: * 802ebf37e3d932169f9826b40df483bb5e9ac064 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/133366796) * f16938ce2fb38ae216def737d14643b94d6083a1 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/133940607) * 20de5cfc7af9a8ba57080d5218fd0293f393a40e : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/133998545) * 56bfbb65802c1d5c48caa625a152070934bb5d79 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134010321) * 3ea229382fef64b1046673c79ff845d4689c5db4 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137145261) * 3169988a33e0126e79cd449740c93d3561296ead : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138017410) * a0dd858b0b91443fc87895a2d32ebfbbc0b9fe4c : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/138730857) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10367: [1.9][FLINK-14995][kinesis][legal] Update NOTICE
flinkbot edited a comment on issue #10367: [1.9][FLINK-14995][kinesis][legal] Update NOTICE URL: https://github.com/apache/flink/pull/10367#issuecomment-559835744 ## CI report: * b0e8b316663349ba4d3a9d72643d2bdc75917ffb : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/138730828) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10366: [1.8][FLINK-14995][kinesis][legal] Update NOTICE
flinkbot edited a comment on issue #10366: [1.8][FLINK-14995][kinesis][legal] Update NOTICE URL: https://github.com/apache/flink/pull/10366#issuecomment-559835705 ## CI report: * 5c57da1ec7e28742c3b53a7bbc5587c2abac4fa4 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/138730813) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10363: [FLINK-14104][build] Upgrade to flink-shaded 9.0
flinkbot edited a comment on issue #10363: [FLINK-14104][build] Upgrade to flink-shaded 9.0 URL: https://github.com/apache/flink/pull/10363#issuecomment-559809874 ## CI report: * 29f293aede9db08019c380fec1da3f24d19c51d3 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138717535) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] azagrebin edited a comment on issue #10146: [FLINK-14188][runtime] TaskExecutor derive and register with default slot resource profile
azagrebin edited a comment on issue #10146: [FLINK-14188][runtime] TaskExecutor derive and register with default slot resource profile URL: https://github.com/apache/flink/pull/10146#issuecomment-559841792 We should consider all current usages of deprecated `TaskManagerOptions.NUM_TASK_SLOTS` in code base and migrate to `DEFAULT_SLOT_FRACTION` wherever it is possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10339: [FLINK-14976][cassandra] Release semaphore on all Throwable's in send()
flinkbot edited a comment on issue #10339: [FLINK-14976][cassandra] Release semaphore on all Throwable's in send() URL: https://github.com/apache/flink/pull/10339#issuecomment-559115891 ## CI report: * 65f4f8552770a2e1fd05c604a5cc074f32487c74 : CANCELED [Build](https://travis-ci.com/flink-ci/flink/builds/138425013) * 8efd77647534f028e8549ac3a210447b78e8d6de : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138439684) * 10e4a64ff821f17d5b34cab8339cf18df4c56775 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138597065) * 2f4df30f8141065f822634132dc2fb72e223bc55 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138717474) Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] azagrebin edited a comment on issue #10146: [FLINK-14188][runtime] TaskExecutor derive and register with default slot resource profile
azagrebin edited a comment on issue #10146: [FLINK-14188][runtime] TaskExecutor derive and register with default slot resource profile URL: https://github.com/apache/flink/pull/10146#issuecomment-559841792 We should consider all current usages of deprecated `TaskManagerOptions.NUM_TASK_SLOTS` in code base and migrate it to `DEFAULT_SLOT_FRACTION` wherever it is possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] azagrebin commented on issue #10146: [FLINK-14188][runtime] TaskExecutor derive and register with default slot resource profile
azagrebin commented on issue #10146: [FLINK-14188][runtime] TaskExecutor derive and register with default slot resource profile URL: https://github.com/apache/flink/pull/10146#issuecomment-559841792 We should consider all current usage of deprecated `TaskManagerOptions.NUM_TASK_SLOTS` in code base and migrate to `DEFAULT_SLOT_FRACTION` wherever it is possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (FLINK-14651) Set default value of config option jobmanager.scheduler to "ng"
[
https://issues.apache.org/jira/browse/FLINK-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary Yao updated FLINK-14651:
-
Priority: Critical (was: Major)
> Set default value of config option jobmanager.scheduler to "ng"
> ---
>
> Key: FLINK-14651
> URL: https://issues.apache.org/jira/browse/FLINK-14651
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / Coordination
>Affects Versions: 1.10.0
>Reporter: Gary Yao
>Assignee: Gary Yao
>Priority: Critical
> Labels: pull-request-available
> Fix For: 1.10.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Config option {{jobmanager.scheduler}} should be set to {{"ng"}} by default
> so that the new {{DefaultScheduler}} will be used.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (FLINK-14651) Set default value of config option jobmanager.scheduler to "ng"
[
https://issues.apache.org/jira/browse/FLINK-14651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary Yao updated FLINK-14651:
-
Parent: FLINK-10429
Issue Type: Sub-task (was: Bug)
> Set default value of config option jobmanager.scheduler to "ng"
> ---
>
> Key: FLINK-14651
> URL: https://issues.apache.org/jira/browse/FLINK-14651
> Project: Flink
> Issue Type: Sub-task
> Components: Runtime / Coordination
>Affects Versions: 1.10.0
>Reporter: Gary Yao
>Assignee: Gary Yao
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.10.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Config option {{jobmanager.scheduler}} should be set to {{"ng"}} by default
> so that the new {{DefaultScheduler}} will be used.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [flink] flinkbot edited a comment on issue #9984: [FLINK-9495][kubernetes] Implement ResourceManager for Kubernetes.
flinkbot edited a comment on issue #9984: [FLINK-9495][kubernetes] Implement ResourceManager for Kubernetes. URL: https://github.com/apache/flink/pull/9984#issuecomment-545881191 ## CI report: * 802ebf37e3d932169f9826b40df483bb5e9ac064 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/133366796) * f16938ce2fb38ae216def737d14643b94d6083a1 : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/133940607) * 20de5cfc7af9a8ba57080d5218fd0293f393a40e : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/133998545) * 56bfbb65802c1d5c48caa625a152070934bb5d79 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/134010321) * 3ea229382fef64b1046673c79ff845d4689c5db4 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/137145261) * 3169988a33e0126e79cd449740c93d3561296ead : SUCCESS [Build](https://travis-ci.com/flink-ci/flink/builds/138017410) * a0dd858b0b91443fc87895a2d32ebfbbc0b9fe4c : UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run travis` re-run the last Travis build This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [flink] azagrebin commented on a change in pull request #10146: [FLINK-14188][runtime] TaskExecutor derive and register with default slot resource profile
azagrebin commented on a change in pull request #10146: [FLINK-14188][runtime]
TaskExecutor derive and register with default slot resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r351831109
##
File path:
flink-core/src/main/java/org/apache/flink/api/common/resources/Resource.java
##
@@ -67,6 +67,12 @@ public Resource subtract(Resource other) {
return create(value.subtract(other.value));
}
+ public Resource multiply(double multiplier) {
Review comment:
do we want a test for this?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] azagrebin commented on a change in pull request #10146: [FLINK-14188][runtime] TaskExecutor derive and register with default slot resource profile
azagrebin commented on a change in pull request #10146: [FLINK-14188][runtime]
TaskExecutor derive and register with default slot resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r352157448
##
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceUtilsTest.java
##
@@ -556,6 +559,82 @@ public void testConfigTotalProcessMemoryAddUpFailure() {
validateFail(conf);
}
+ @Test
+ public void testConfigDefaultSlotFraction() {
+ final double defaultSlotFraction = 0.5;
+
+ Configuration conf = new Configuration();
+ conf.setDouble(TaskManagerOptions.DEFAULT_SLOT_FRACTION,
(float) defaultSlotFraction);
+
+ validateInAllConfigurations(conf, taskExecutorResourceSpec -> {
Review comment:
this check can be deduplicated with the next test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] azagrebin commented on a change in pull request #10146: [FLINK-14188][runtime] TaskExecutor derive and register with default slot resource profile
azagrebin commented on a change in pull request #10146: [FLINK-14188][runtime]
TaskExecutor derive and register with default slot resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r351880023
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceSpec.java
##
@@ -78,6 +81,8 @@
*/
public class TaskExecutorResourceSpec implements Serializable {
+ private final Optional cpuCores;
Review comment:
according to the Flink code style, we agreed to use `Optional` only to
return values from public methods. The private class fields should be
`@Nullable`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] azagrebin commented on a change in pull request #10146: [FLINK-14188][runtime] TaskExecutor derive and register with default slot resource profile
azagrebin commented on a change in pull request #10146: [FLINK-14188][runtime]
TaskExecutor derive and register with default slot resource profile
URL: https://github.com/apache/flink/pull/10146#discussion_r351839963
##
File path:
flink-mesos/src/main/java/org/apache/flink/mesos/util/MesosUtils.java
##
@@ -107,8 +107,6 @@ public static MesosTaskManagerParameters
createTmParameters(Configuration config
final MesosTaskManagerParameters taskManagerParameters =
MesosTaskManagerParameters.create(configuration);
final TaskExecutorResourceSpec taskExecutorResourceSpec =
taskManagerParameters.containeredParameters().getTaskExecutorResourceSpec();
- log.info("TaskManagers will be created with {} task slots",
-
taskManagerParameters.containeredParameters().numSlots());
Review comment:
I think complete removal of this log (or better to say change to log default
fraction instead of number of slots) belongs to the next commits. Here we can
substitute `taskManagerParameters.containeredParameters().numSlots()` also with
`configuration.getInteger(MESOS_RM_TASKS_SLOTS)`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
