[jira] [Commented] (HBASE-18770) Remove bypass method in ObserverContext and implement the 'bypass' logic case by case
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223268#comment-16223268
]
Hadoop QA commented on HBASE-18770:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
9s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
53s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
50m 3s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
26s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 44m 41s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}116m 0s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestBlocksScanned |
| | hadoop.hbase.coprocessor.TestCoprocessorInterface |
| | hadoop.hbase.procedure.TestProcedureManager |
| | hadoop.hbase.io.encoding.TestPrefixTree |
| | hadoop.hbase.filter.TestColumnPrefixFilter |
| | hadoop.hbase.regionserver.TestHRegionFileSystem |
| | hadoop.hbase.filter.TestFilterFromRegionSide |
| | hadoop.hbase.master.balancer.TestRegionLocationFinder |
| | hadoop.hbase.regionserver.TestScanner |
| | hadoop.hbase.filter.TestDependentColumnFilter |
| | hadoop.hbase.regionserver.TestResettingCounters |
| | hadoop.hbase.io.encoding.TestSeekBeforeWithReverseScan |
| | hadoop.hbase.regionserver.TestKeepDeletes |
| | hadoop.hbase.regionserver.TestStoreFileRefresherChore |
| | hadoop.hbase.coprocessor.TestRegionObserverStacking |
| | hadoop.hbase.regionserver.wal.TestWALActionsListener |
| | hadoop.hbase.ipc.TestNettyRpcServer |
| | hadoop.hbase.io.hfile.TestScannerSelectionUsingKeyRange |
| | hadoop.hbase.regionserver.TestScanWithBloomError |
| | hadoop.hbase.filter.TestFilter |
| | hadoop.hbase.filter.TestInvocationRecordFilter |
| | hadoop.hbase.filter.TestMultipleColumnPrefixFilter |
| |
[jira] [Commented] (HBASE-19110) Add default for Server#isStopping
[ https://issues.apache.org/jira/browse/HBASE-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223262#comment-16223262 ] Peter Somogyi commented on HBASE-19110: --- Since the default is added to getFileSystem as well the title and commit message should reflect that as well. > Add default for Server#isStopping > - > > Key: HBASE-19110 > URL: https://issues.apache.org/jira/browse/HBASE-19110 > Project: HBase > Issue Type: Improvement >Reporter: stack >Assignee: stack >Priority: Minor > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19110.master.001.patch, > HBASE-19110.master.002.patch, HBASE-19110.master.003.patch > > > Over in HBASE-19007 "Align Services Interfaces in Master and RegionServer", > we moved the isStopping method back into Server. In a late review, [~appy] > suggested that I should have had the Interface provide a default. This issue > is about doing as [~appy] suggested. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18988) Add release managers to reference guide
[ https://issues.apache.org/jira/browse/HBASE-18988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223257#comment-16223257 ] Peter Somogyi commented on HBASE-18988: --- I think this is the list: 1.4 Andrew Purtell 2.0 Michael Stack I think there is no RM for 1.5 yet. > Add release managers to reference guide > --- > > Key: HBASE-18988 > URL: https://issues.apache.org/jira/browse/HBASE-18988 > Project: HBase > Issue Type: Task > Components: documentation >Reporter: Peter Somogyi >Priority: Trivial > Labels: beginner > > Reference guide lists release managers only up to version 1.3. We should have > a complete list there. > http://hbase.apache.org/book.html#_release_managers -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19110) Add default for Server#isStopping
[ https://issues.apache.org/jira/browse/HBASE-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223238#comment-16223238 ] Sean Busbey commented on HBASE-19110: - +1 > Add default for Server#isStopping > - > > Key: HBASE-19110 > URL: https://issues.apache.org/jira/browse/HBASE-19110 > Project: HBase > Issue Type: Improvement >Reporter: stack >Assignee: stack >Priority: Minor > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19110.master.001.patch, > HBASE-19110.master.002.patch, HBASE-19110.master.003.patch > > > Over in HBASE-19007 "Align Services Interfaces in Master and RegionServer", > we moved the isStopping method back into Server. In a late review, [~appy] > suggested that I should have had the Interface provide a default. This issue > is about doing as [~appy] suggested. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223236#comment-16223236 ] ramkrishna.s.vasudevan commented on HBASE-18995: Thanks a ton for taking this through [~saint@gmail.com]. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.002.patch, > HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch, > HBASE-18995_002-branch-2.patch, HBASE-18995_002-branch-2.patch, > HBASE-18995_003-branch-2.patch, HBASE-18995_1.patch, HBASE-18995_2.patch, > HBASE-18995_2.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-12091) Optionally ignore edits for dropped tables for replication.
[ https://issues.apache.org/jira/browse/HBASE-12091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223223#comment-16223223 ] Lars Hofhansl commented on HBASE-12091: --- Thinking about some tests now. > Optionally ignore edits for dropped tables for replication. > --- > > Key: HBASE-12091 > URL: https://issues.apache.org/jira/browse/HBASE-12091 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl > Attachments: 12091.txt > > > We just ran into a scenario where we dropped a table from both the source and > the sink, but the source still has outstanding edits that now it could not > get rid of. Now all replication is backed up behind these unreplicatable > edits. > We should have an option to ignore edits for tables dropped at the source. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18770) Remove bypass method in ObserverContext and implement the 'bypass' logic case by case
[ https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223219#comment-16223219 ] stack commented on HBASE-18770: --- .005 Fix NPE. Going to see some interesting failures now we fail bypass use when not allowed. > Remove bypass method in ObserverContext and implement the 'bypass' logic case > by case > - > > Key: HBASE-18770 > URL: https://issues.apache.org/jira/browse/HBASE-18770 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang >Assignee: stack >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18770.master.001.patch, > HBASE-18770.master.002.patch, HBASE-18770.master.003.patch, > HBASE-18770.master.004.patch, HBASE-18770.master.005.patch > > > http://search-hadoop.com/m/HBase/YGbbXd0RDCIHSC1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18770) Remove bypass method in ObserverContext and implement the 'bypass' logic case by case
[ https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18770: -- Attachment: HBASE-18770.master.005.patch > Remove bypass method in ObserverContext and implement the 'bypass' logic case > by case > - > > Key: HBASE-18770 > URL: https://issues.apache.org/jira/browse/HBASE-18770 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang >Assignee: stack >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18770.master.001.patch, > HBASE-18770.master.002.patch, HBASE-18770.master.003.patch, > HBASE-18770.master.004.patch, HBASE-18770.master.005.patch > > > http://search-hadoop.com/m/HBase/YGbbXd0RDCIHSC1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18770) Remove bypass method in ObserverContext and implement the 'bypass' logic case by case
[ https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223213#comment-16223213 ] stack commented on HBASE-18770: --- .004 Rebase. > Remove bypass method in ObserverContext and implement the 'bypass' logic case > by case > - > > Key: HBASE-18770 > URL: https://issues.apache.org/jira/browse/HBASE-18770 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang >Assignee: stack >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18770.master.001.patch, > HBASE-18770.master.002.patch, HBASE-18770.master.003.patch, > HBASE-18770.master.004.patch > > > http://search-hadoop.com/m/HBase/YGbbXd0RDCIHSC1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18770) Remove bypass method in ObserverContext and implement the 'bypass' logic case by case
[ https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18770: -- Attachment: HBASE-18770.master.004.patch > Remove bypass method in ObserverContext and implement the 'bypass' logic case > by case > - > > Key: HBASE-18770 > URL: https://issues.apache.org/jira/browse/HBASE-18770 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang >Assignee: stack >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18770.master.001.patch, > HBASE-18770.master.002.patch, HBASE-18770.master.003.patch, > HBASE-18770.master.004.patch > > > http://search-hadoop.com/m/HBase/YGbbXd0RDCIHSC1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19110) Add default for Server#isStopping
[ https://issues.apache.org/jira/browse/HBASE-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19110: -- Attachment: HBASE-19110.master.003.patch > Add default for Server#isStopping > - > > Key: HBASE-19110 > URL: https://issues.apache.org/jira/browse/HBASE-19110 > Project: HBase > Issue Type: Improvement >Reporter: stack >Assignee: stack >Priority: Minor > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19110.master.001.patch, > HBASE-19110.master.002.patch, HBASE-19110.master.003.patch > > > Over in HBASE-19007 "Align Services Interfaces in Master and RegionServer", > we moved the isStopping method back into Server. In a late review, [~appy] > suggested that I should have had the Interface provide a default. This issue > is about doing as [~appy] suggested. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18722) Replace copied guava code w/ pointer to the (shaded) lib
[
https://issues.apache.org/jira/browse/HBASE-18722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223209#comment-16223209
]
Asim Zafir commented on HBASE-18722:
This is my first ticket to hbase so perhaps some dummy questions.. but I
folllow the strategy:
1) identify code copies from guauva sources - question is how? (perhaps to get
the get the guava source and compare the list of the file that are included and
then get rid of them from the repo hiearchy?
2) where the import statement should then go to include
org.apache.hadoop.hbase.shaded.com.google.guava
I am ready for all kind of work to support you guys - QA/Test/ Bug fixes,
pretty much anything.
Asim
> Replace copied guava code w/ pointer to the (shaded) lib
>
>
> Key: HBASE-18722
> URL: https://issues.apache.org/jira/browse/HBASE-18722
> Project: HBase
> Issue Type: Bug
>Reporter: stack
>Priority: Minor
> Labels: beginner
>
> I found a few bits of code copied from guava src:
> {code}
> ./src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java: * Copied
> from guava source code v15 (LimitedInputStream)
> ./src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java: * allows to
> be compatible with guava 11 to 15+.
> ./src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java: *
> from guava v21
> ./src/main/java/org/apache/hadoop/hbase/util/Bytes.java: *
> comparator from guava v21
> {code}
> We can instead point back at guava implementations now we use shaded guava
> internally. No point having it in our code base when latest guava is on
> latest CLASSPATH (This wasn't always the case; this is why the code was
> copied into hbase).
> Also, there are other copies other than the above.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19110) Add default for Server#isStopping
[ https://issues.apache.org/jira/browse/HBASE-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223208#comment-16223208 ] stack commented on HBASE-19110: --- .003 address [~busbey] review comments. > Add default for Server#isStopping > - > > Key: HBASE-19110 > URL: https://issues.apache.org/jira/browse/HBASE-19110 > Project: HBase > Issue Type: Improvement >Reporter: stack >Assignee: stack >Priority: Minor > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19110.master.001.patch, > HBASE-19110.master.002.patch, HBASE-19110.master.003.patch > > > Over in HBASE-19007 "Align Services Interfaces in Master and RegionServer", > we moved the isStopping method back into Server. In a late review, [~appy] > suggested that I should have had the Interface provide a default. This issue > is about doing as [~appy] suggested. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19110) Add default for Server#isStopping
[
https://issues.apache.org/jira/browse/HBASE-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223204#comment-16223204
]
Sean Busbey commented on HBASE-19110:
-
{code}
fs = c == null? null: FileSystem.get(c);
{code}
nit: an if block will be clearer (esp given the spacing)
+1 on v2 as is or with the nit addressed
> Add default for Server#isStopping
> -
>
> Key: HBASE-19110
> URL: https://issues.apache.org/jira/browse/HBASE-19110
> Project: HBase
> Issue Type: Improvement
>Reporter: stack
>Assignee: stack
>Priority: Minor
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-19110.master.001.patch,
> HBASE-19110.master.002.patch
>
>
> Over in HBASE-19007 "Align Services Interfaces in Master and RegionServer",
> we moved the isStopping method back into Server. In a late review, [~appy]
> suggested that I should have had the Interface provide a default. This issue
> is about doing as [~appy] suggested.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18233) We shouldn't wait for readlock in doMiniBatchMutation in case of deadlock
[ https://issues.apache.org/jira/browse/HBASE-18233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18233: -- Attachment: HBASE-18233-branch-1.2.v4 (2).patch Retry. Would like to get this into a 1.2.7. > We shouldn't wait for readlock in doMiniBatchMutation in case of deadlock > - > > Key: HBASE-18233 > URL: https://issues.apache.org/jira/browse/HBASE-18233 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.7 >Reporter: Allan Yang >Assignee: Allan Yang >Priority: Blocker > Fix For: 1.3.2, 1.2.7 > > Attachments: HBASE-18233-branch-1.2.patch, > HBASE-18233-branch-1.2.v2.patch, HBASE-18233-branch-1.2.v3.patch, > HBASE-18233-branch-1.2.v4 (1).patch, HBASE-18233-branch-1.2.v4 (1).patch, > HBASE-18233-branch-1.2.v4 (2).patch, HBASE-18233-branch-1.2.v4.patch, > HBASE-18233-branch-1.2.v4.patch, HBASE-18233-branch-1.2.v4.patch, > HBASE-18233-branch-1.2.v4.patch, HBASE-18233-branch-1.2.v4.patch, > HBASE-18233-branch-1.2.v4.patch > > > Please refer to the discuss in HBASE-18144 > https://issues.apache.org/jira/browse/HBASE-18144?focusedCommentId=16051701=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16051701 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19110) Add default for Server#isStopping
[ https://issues.apache.org/jira/browse/HBASE-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223201#comment-16223201 ] stack commented on HBASE-19110: --- .002 add a dodgy default for getFileSystem. > Add default for Server#isStopping > - > > Key: HBASE-19110 > URL: https://issues.apache.org/jira/browse/HBASE-19110 > Project: HBase > Issue Type: Improvement >Reporter: stack >Assignee: stack >Priority: Minor > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19110.master.001.patch, > HBASE-19110.master.002.patch > > > Over in HBASE-19007 "Align Services Interfaces in Master and RegionServer", > we moved the isStopping method back into Server. In a late review, [~appy] > suggested that I should have had the Interface provide a default. This issue > is about doing as [~appy] suggested. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19110) Add default for Server#isStopping
[ https://issues.apache.org/jira/browse/HBASE-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19110: -- Attachment: HBASE-19110.master.002.patch > Add default for Server#isStopping > - > > Key: HBASE-19110 > URL: https://issues.apache.org/jira/browse/HBASE-19110 > Project: HBase > Issue Type: Improvement >Reporter: stack >Assignee: stack >Priority: Minor > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19110.master.001.patch, > HBASE-19110.master.002.patch > > > Over in HBASE-19007 "Align Services Interfaces in Master and RegionServer", > we moved the isStopping method back into Server. In a late review, [~appy] > suggested that I should have had the Interface provide a default. This issue > is about doing as [~appy] suggested. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18438) Precommit doesn't warn about unused imports
[ https://issues.apache.org/jira/browse/HBASE-18438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223200#comment-16223200 ] Mike Drob commented on HBASE-18438: --- That should have failed, right? > Precommit doesn't warn about unused imports > --- > > Key: HBASE-18438 > URL: https://issues.apache.org/jira/browse/HBASE-18438 > Project: HBase > Issue Type: Bug > Components: build >Reporter: Mike Drob >Assignee: Chia-Ping Tsai >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-18438.patch, HBASE-18438.v2.patch, > HBASE-18438.v2.patch > > > On HBASE-18419 I accidentally included an unused import in my patch, but > precommit didn't flag it. Use this issue to diagnose and fix. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19064) Synchronous replication for HBase
[ https://issues.apache.org/jira/browse/HBASE-19064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223198#comment-16223198 ] Sean Busbey commented on HBASE-19064: - Can you periodically post a PDF snapshot of the design doc here? I'd like to make sure there are copies on ASF infra. > Synchronous replication for HBase > - > > Key: HBASE-19064 > URL: https://issues.apache.org/jira/browse/HBASE-19064 > Project: HBase > Issue Type: New Feature > Components: Replication >Reporter: Duo Zhang >Assignee: Duo Zhang > Fix For: 3.0.0 > > > The guys from Alibaba made a presentation on HBaseCon Asia about the > synchronous replication for HBase. We(Xiaomi) think this is a very useful > feature for HBase so we want to bring it into the community version. > This is a big feature so we plan to do it in a feature branch. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18722) Replace copied guava code w/ pointer to the (shaded) lib
[
https://issues.apache.org/jira/browse/HBASE-18722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223195#comment-16223195
]
Mike Drob commented on HBASE-18722:
---
[~azafir] - Thanks for your interest in helping out here. If you are familiar
with git, you can make your changed locally and attach a patch file to this
JIRA. Then our automated QA system will review it and one of the committers
should be by to look at it shortly.
As far as the actual changes in the patch... we would probably want to delete
the code that is copied from guava sources, and then update any other
references that were using that code to the guava available at
org.apache.hadoop.hbase.shaded.com.google.guava package imports. Let me know if
this is unclear or you think you need more guidance.
> Replace copied guava code w/ pointer to the (shaded) lib
>
>
> Key: HBASE-18722
> URL: https://issues.apache.org/jira/browse/HBASE-18722
> Project: HBase
> Issue Type: Bug
>Reporter: stack
>Priority: Minor
> Labels: beginner
>
> I found a few bits of code copied from guava src:
> {code}
> ./src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java: * Copied
> from guava source code v15 (LimitedInputStream)
> ./src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java: * allows to
> be compatible with guava 11 to 15+.
> ./src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java: *
> from guava v21
> ./src/main/java/org/apache/hadoop/hbase/util/Bytes.java: *
> comparator from guava v21
> {code}
> We can instead point back at guava implementations now we use shaded guava
> internally. No point having it in our code base when latest guava is on
> latest CLASSPATH (This wasn't always the case; this is why the code was
> copied into hbase).
> Also, there are other copies other than the above.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-15625) Make minimum values configurable and smaller
[ https://issues.apache.org/jira/browse/HBASE-15625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223193#comment-16223193 ] Asim Zafir commented on HBASE-15625: Is someone working on this? Can I attempt to get this fixed? > Make minimum values configurable and smaller > > > Key: HBASE-15625 > URL: https://issues.apache.org/jira/browse/HBASE-15625 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.0 >Reporter: Jean-Marc Spaggiari >Assignee: Konstantin Ryakhovskiy >Priority: Minor > Labels: beginner > > When we start a RS, we check > HConstants.HBASE_CLUSTER_MINIMUM_MEMORY_THRESHOLD to make sure we always keep > 20% of the heap for HBase (See below). In the past maximum heap size was > about 20GB, which means 4GB for HBase. > Today, with huge heaps and GC1, 20% gives a lot to HBase. Like with 80GB > heap, it gives 16GB, which I think it not required. > We need to make HBASE_CLUSTER_MINIMUM_MEMORY_THRESHOLD configurable and lower > it's default value to 10%. It will not make any difference on any HBase > configuration but will allow admins to be more flexible. > Same thing for the minimum memstore and blockcache sizes. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18722) Replace copied guava code w/ pointer to the (shaded) lib
[
https://issues.apache.org/jira/browse/HBASE-18722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223190#comment-16223190
]
Asim Zafir commented on HBASE-18722:
so i guess we need to do a code clean up and get rid of entire guava snippet of
code that is in hbase code base? how do I go about carrying this out?
> Replace copied guava code w/ pointer to the (shaded) lib
>
>
> Key: HBASE-18722
> URL: https://issues.apache.org/jira/browse/HBASE-18722
> Project: HBase
> Issue Type: Bug
>Reporter: stack
>Priority: Minor
> Labels: beginner
>
> I found a few bits of code copied from guava src:
> {code}
> ./src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java: * Copied
> from guava source code v15 (LimitedInputStream)
> ./src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java: * allows to
> be compatible with guava 11 to 15+.
> ./src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java: *
> from guava v21
> ./src/main/java/org/apache/hadoop/hbase/util/Bytes.java: *
> comparator from guava v21
> {code}
> We can instead point back at guava implementations now we use shaded guava
> internally. No point having it in our code base when latest guava is on
> latest CLASSPATH (This wasn't always the case; this is why the code was
> copied into hbase).
> Also, there are other copies other than the above.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18988) Add release managers to reference guide
[ https://issues.apache.org/jira/browse/HBASE-18988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223187#comment-16223187 ] Asim Zafir commented on HBASE-18988: where can we get the complete list. ? > Add release managers to reference guide > --- > > Key: HBASE-18988 > URL: https://issues.apache.org/jira/browse/HBASE-18988 > Project: HBase > Issue Type: Task > Components: documentation >Reporter: Peter Somogyi >Priority: Trivial > Labels: beginner > > Reference guide lists release managers only up to version 1.3. We should have > a complete list there. > http://hbase.apache.org/book.html#_release_managers -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18624) Added support for clearing BlockCache based on table name
[
https://issues.apache.org/jira/browse/HBASE-18624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223182#comment-16223182
]
Hadoop QA commented on HBASE-18624:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 3 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
28s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
5s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
2s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
22s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 3m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
56s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m
13s{color} | {color:red} The patch generated 6 new + 359 unchanged - 1 fixed =
365 total (was 360) {color} |
| {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red} 0m
5s{color} | {color:red} The patch generated 5 new + 740 unchanged - 0 fixed =
745 total (was 740) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
10s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
64m 48s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green}
2m 32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
37s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
26s{color} | {color:green} hbase-protocol in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
13s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}126m
57s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m
31s{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} |
[jira] [Commented] (HBASE-19113) Restore dropped constants from TableInputFormatBase for compatibility
[ https://issues.apache.org/jira/browse/HBASE-19113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223180#comment-16223180 ] Hudson commented on HBASE-19113: FAILURE: Integrated in Jenkins build HBase-1.4 #977 (See [https://builds.apache.org/job/HBase-1.4/977/]) HBASE-19113 Restore dropped constants from TableInputFormatBase for (apurtell: rev 8a5d87f4105e127debefc7009e0f0bba7c04c35c) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java > Restore dropped constants from TableInputFormatBase for compatibility > - > > Key: HBASE-19113 > URL: https://issues.apache.org/jira/browse/HBASE-19113 > Project: HBase > Issue Type: Sub-task > Components: mapreduce >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0, 1.5.0 > > Attachments: HBASE-19113-branch-1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Work stopped] (HBASE-18276) Release 1.2.7
[ https://issues.apache.org/jira/browse/HBASE-18276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-18276 stopped by Sean Busbey. --- > Release 1.2.7 > - > > Key: HBASE-18276 > URL: https://issues.apache.org/jira/browse/HBASE-18276 > Project: HBase > Issue Type: Task > Components: community >Reporter: Sean Busbey >Assignee: Sean Busbey > Fix For: 1.2.7 > > > about time to get rolling on 1.2.7 for ~monthly -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18233) We shouldn't wait for readlock in doMiniBatchMutation in case of deadlock
[ https://issues.apache.org/jira/browse/HBASE-18233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223171#comment-16223171 ] Sean Busbey commented on HBASE-18233: - Any progress here? Am I correct that this issue has been present since 1.2.0? If so, I'd like to downgrade priority to Critical and continue on with a 1.2.7 release unless y'all think this will land by Tuesday morning. > We shouldn't wait for readlock in doMiniBatchMutation in case of deadlock > - > > Key: HBASE-18233 > URL: https://issues.apache.org/jira/browse/HBASE-18233 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.7 >Reporter: Allan Yang >Assignee: Allan Yang >Priority: Blocker > Fix For: 1.3.2, 1.2.7 > > Attachments: HBASE-18233-branch-1.2.patch, > HBASE-18233-branch-1.2.v2.patch, HBASE-18233-branch-1.2.v3.patch, > HBASE-18233-branch-1.2.v4 (1).patch, HBASE-18233-branch-1.2.v4 (1).patch, > HBASE-18233-branch-1.2.v4.patch, HBASE-18233-branch-1.2.v4.patch, > HBASE-18233-branch-1.2.v4.patch, HBASE-18233-branch-1.2.v4.patch, > HBASE-18233-branch-1.2.v4.patch, HBASE-18233-branch-1.2.v4.patch > > > Please refer to the discuss in HBASE-18144 > https://issues.apache.org/jira/browse/HBASE-18144?focusedCommentId=16051701=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16051701 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19102) TestZooKeeperMainServer fails with KeeperException$ConnectionLossException
[
https://issues.apache.org/jira/browse/HBASE-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223170#comment-16223170
]
Hadoop QA commented on HBASE-19102:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
1s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 1m
32s{color} | {color:red} root in master failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
39s{color} | {color:red} hbase-server in master failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
25s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 2m
31s{color} | {color:red} branch has 348 errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
38s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 1m
31s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
36s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 36s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 1m
10s{color} | {color:red} patch has 348 errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m
4s{color} | {color:red} The patch causes 348 errors with Hadoop v2.6.1. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m
58s{color} | {color:red} The patch causes 348 errors with Hadoop v2.6.2.
{color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m
51s{color} | {color:red} The patch causes 348 errors with Hadoop v2.6.3.
{color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m
44s{color} | {color:red} The patch causes 348 errors with Hadoop v2.6.4.
{color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m
37s{color} | {color:red} The patch causes 348 errors with Hadoop v2.6.5.
{color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 6m
30s{color} | {color:red} The patch causes 348 errors with Hadoop v2.7.1.
{color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 7m
23s{color} | {color:red} The patch causes 348 errors with Hadoop v2.7.2.
{color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 8m
17s{color} | {color:red} The patch causes 348 errors with Hadoop v2.7.3.
{color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 9m
12s{color} | {color:red} The patch causes 348 errors with Hadoop v3.0.0-alpha4.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
36s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 36s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
|
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223169#comment-16223169 ] Hudson commented on HBASE-18995: FAILURE: Integrated in Jenkins build HBase-2.0 #758 (See [https://builds.apache.org/job/HBase-2.0/758/]) HBASE-18995 Move methods that are for internal usage from CellUtil to (stack: rev 250a8bc7ad05080692b461a28f6fe1fa614b5830) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ExplicitColumnTracker.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AllowPartialScanResultCache.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultiRowRangeFilter.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/client/ClientSideRegionScanner.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ReversedStoreScanner.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/NormalUserScanQueryMatcher.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/DiffKeyDeltaEncoder.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/util/RowColBloomHashKey.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/UserScanQueryMatcher.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileRefresherChore.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java * (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestCellBasedHFileOutputFormat2.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestDataBlockEncoders.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java * (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestByteBufferKeyValue.java * (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java * (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTsv.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestSeekToBlockWithEncoders.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java * (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestCellComparator.java * (edit) hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/decode/PrefixTreeCell.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestSeekTo.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/StripeCompactionScanQueryMatcher.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestCoprocessorScanPolicy.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobUtils.java * (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java * (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTSVWithVisibilityLabels.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/TimestampsFilter.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/MajorCompactionScanQueryMatcher.java * (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSnapshotInputFormatImpl.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ReversedKeyValueHeap.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStoreFile.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterImpl.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultipleColumnPrefixFilter.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRecoveredEdits.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/NewVersionBehaviorTracker.java * (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/util/MapReduceCell.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/BatchScanResultCache.java * (edit)
[jira] [Commented] (HBASE-19113) Restore dropped constants from TableInputFormatBase for compatibility
[ https://issues.apache.org/jira/browse/HBASE-19113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223168#comment-16223168 ] Hudson commented on HBASE-19113: FAILURE: Integrated in Jenkins build HBase-1.5 #120 (See [https://builds.apache.org/job/HBase-1.5/120/]) HBASE-19113 Restore dropped constants from TableInputFormatBase for (apurtell: rev 0d26ca7dfbdf0a2b618916d17813adf6c3e273ba) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java > Restore dropped constants from TableInputFormatBase for compatibility > - > > Key: HBASE-19113 > URL: https://issues.apache.org/jira/browse/HBASE-19113 > Project: HBase > Issue Type: Sub-task > Components: mapreduce >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0, 1.5.0 > > Attachments: HBASE-19113-branch-1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223166#comment-16223166 ] Hudson commented on HBASE-18995: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3958 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3958/]) HBASE-18995 Move methods that are for internal usage from CellUtil to (stack: rev f6c2490b82968f33e7d7db0b96896eebdf745e19) * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStoreFile.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileRefresherChore.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/CompareFilter.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestTags.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeMultiFileWriter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPrefixFilter.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/NewVersionBehaviorTracker.java * (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestCellUtil.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ReplicationProtbufUtil.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ReversedKeyValueHeap.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SegmentScanner.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerSideScanMetricsFromClientSide.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/BatchScanResultCache.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestSeekToBlockWithEncoders.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ReversedStoreScanner.java * (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/ipc/TestCellBlockBuilder.java * (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestPrefixTreeEncoding.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultMemStore.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobUtils.java * (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestSyncTable.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestPartialResultsFromClientSide.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Delete.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java * (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/filter/TestComparators.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlLists.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/util/RowBloomHashKey.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTableScanMetrics.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestDataBlockEncoders.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/NormalUserScanQueryMatcher.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java * (edit)
[jira] [Commented] (HBASE-18770) Remove bypass method in ObserverContext and implement the 'bypass' logic case by case
[
https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223165#comment-16223165
]
Hadoop QA commented on HBASE-18770:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
16s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 1m
19s{color} | {color:red} root in master failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
33s{color} | {color:red} hbase-server in master failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
22s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 2m
2s{color} | {color:red} branch has 348 errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
30s{color} | {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 1m
18s{color} | {color:red} root in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
30s{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 30s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} shadedjars {color} | {color:red} 1m
0s{color} | {color:red} patch has 348 errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m
47s{color} | {color:red} The patch causes 348 errors with Hadoop v2.6.1.
{color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m
31s{color} | {color:red} The patch causes 348 errors with Hadoop v2.6.2.
{color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m
18s{color} | {color:red} The patch causes 348 errors with Hadoop v2.6.3.
{color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m
4s{color} | {color:red} The patch causes 348 errors with Hadoop v2.6.4. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m
48s{color} | {color:red} The patch causes 348 errors with Hadoop v2.6.5.
{color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m
33s{color} | {color:red} The patch causes 348 errors with Hadoop v2.7.1.
{color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 6m
20s{color} | {color:red} The patch causes 348 errors with Hadoop v2.7.2.
{color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 7m
6s{color} | {color:red} The patch causes 348 errors with Hadoop v2.7.3. {color}
|
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 7m
53s{color} | {color:red} The patch causes 348 errors with Hadoop v3.0.0-alpha4.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
29s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 31s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
8s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 18m 51s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
|
[jira] [Commented] (HBASE-18438) Precommit doesn't warn about unused imports
[
https://issues.apache.org/jira/browse/HBASE-18438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223151#comment-16223151
]
Hadoop QA commented on HBASE-18438:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m
21s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
25s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 4m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 9m
28s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
59s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
52s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 4m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 3m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
35s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
48m 23s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}153m
54s{color} | {color:green} root in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
22s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}244m 50s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-18438 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12894453/HBASE-18438.v2.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile xml |
| uname | Linux f7178adaf4be 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11
12:48:20 UTC 2017 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 4dee4a854f |
| Default Java | 1.8.0_141 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/9457/testReport/ |
| modules | C: . U: . |
| Console output |
[jira] [Commented] (HBASE-19111) Add missing CellUtil#isXXX(Cell) methods
[ https://issues.apache.org/jira/browse/HBASE-19111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223143#comment-16223143 ] Josh Elser commented on HBASE-19111: Yup yup. I saw that patch. Waiting for that to land and then I'll put up a V2 on top of those good changes. > Add missing CellUtil#isXXX(Cell) methods > > > Key: HBASE-19111 > URL: https://issues.apache.org/jira/browse/HBASE-19111 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19111.001.branch-2.patch > > > Over in HBASE-19002 while trying to write some RegionObservers, I found that > I couldn't find a public-API method to determine if a Cell was for a Put. We > seem to only have API for determining if it's a Delete. > Let's get some methods added to CellUtil for users to consume. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x
[
https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223139#comment-16223139
]
Andrew Purtell commented on HBASE-19052:
Yes. I don't understand how we can't be backwards compatible in 2.0 and up,
rather than forwards compatible from somewhere in 1.x.
Double upgrade to latest 1.x then to 2.0 is a shit thing to require of an
operator. Let's avoid it.
> FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x
>
>
> Key: HBASE-19052
> URL: https://issues.apache.org/jira/browse/HBASE-19052
> Project: HBase
> Issue Type: Improvement
> Components: HFile
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Critical
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 1.1.13
>
> Attachments: 19052.branch-1.txt
>
>
> HBASE-18945 has gone into branch-2 .
> Let's consider rolling upgrade scenario from 1.x to 2.0 where there're three
> servers: s1, s2, s3
> s1 is upgraded to 2.0 first. It flushes to hfile in region r1 with
> CellComparatorImpl written in the hfile trailer.
> Somehow s1 crashes and master assigns r1 to s2 which is still running 1.x
> The following code in FixedFileTrailer would be triggered:
> {code}
> try {
> comparatorKlass = (Class)
> Class.forName(comparatorClassName);
> } catch (ClassNotFoundException e) {
> throw new IOException(e);
> }
> {code}
> since s2 is not aware of CellComparatorImpl.
> This issue is to backport CellComparatorImpl related change to branch-1.x
> Note: CellComparatorImpl wouldn't be used in write path, only in read path.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-18233) We shouldn't wait for readlock in doMiniBatchMutation in case of deadlock
[ https://issues.apache.org/jira/browse/HBASE-18233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-18233: Fix Version/s: (was: 1.4.0) (was: 2.0.0) > We shouldn't wait for readlock in doMiniBatchMutation in case of deadlock > - > > Key: HBASE-18233 > URL: https://issues.apache.org/jira/browse/HBASE-18233 > Project: HBase > Issue Type: Bug >Affects Versions: 1.2.7 >Reporter: Allan Yang >Assignee: Allan Yang >Priority: Blocker > Fix For: 1.3.2, 1.2.7 > > Attachments: HBASE-18233-branch-1.2.patch, > HBASE-18233-branch-1.2.v2.patch, HBASE-18233-branch-1.2.v3.patch, > HBASE-18233-branch-1.2.v4 (1).patch, HBASE-18233-branch-1.2.v4 (1).patch, > HBASE-18233-branch-1.2.v4.patch, HBASE-18233-branch-1.2.v4.patch, > HBASE-18233-branch-1.2.v4.patch, HBASE-18233-branch-1.2.v4.patch, > HBASE-18233-branch-1.2.v4.patch, HBASE-18233-branch-1.2.v4.patch > > > Please refer to the discuss in HBASE-18144 > https://issues.apache.org/jira/browse/HBASE-18144?focusedCommentId=16051701=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16051701 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19114) Split out o.a.h.h.zookeeper from hbase-server and hbase-client
[
https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223127#comment-16223127
]
Hadoop QA commented on HBASE-19114:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s{color}
| {color:red} HBASE-19114 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-19114 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12894486/HBASE-19114.master.001.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9460/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Split out o.a.h.h.zookeeper from hbase-server and hbase-client
> --
>
> Key: HBASE-19114
> URL: https://issues.apache.org/jira/browse/HBASE-19114
> Project: HBase
> Issue Type: Sub-task
>Reporter: Appy
>Assignee: Appy
> Attachments: HBASE-19114.master.001.patch
>
>
> Changes so far:
> - Moved DrainingServerTracker and RegionServerTracker to
> hbase-server:o.a.h.h.master.
> - Move Abortable to hbase-common. Since it's IA.Private and independent of
> anything, moving it to hbase-common which is at bottom of the dependency tree
> is better.
> - Moved RecoveringRegionWatcher to hbase-server:o.a.h.h.regionserver
> - Moved SplitOrMergeTracker to oahh.master (because it depends on a PB)
> - Moving hbase-client:oahh.zookeeper.* to hbase-zookeeper module. We want to
> keep hbase-zookeeper very independent and hence at lowest levels in our
> dependency tree.
> - ZKUtil is a huge tangle since it's linked to almost everything in
> \[hbase-client/]oahh.zookeeper. And pulling it down requires some basic proto
> functions (mergeFrom, PBmagic, etc). So what i did was:
>** Pulled down common and basic protobuf functions (which only depend on
> com.google.protobuf.\*) to hbase-common so other code depending on them can
> be pulled down if possible/wanted in future. This will help future dependency
> untangling too. These are ProtobufMagic and ProtobufHelpers.
> ** Didn't move any hbase-specific PB stuff to hbase-common. We can't pull
> things into hbase-common which add dependency between it and
> hbase-protobuf/hbase-shaded-protobuf since we very recently untangled them.
> - DEFAULT_REPLICA_ID is used in many places in ZK. Declared a new constant in
> HConstants (since it's in hbase-common) and using it in hbase-zookeeper.
> RegionInfo.DEFAULT_REPLICA_ID also takes its value from it to avoid case
> where two values can become different.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19111) Add missing CellUtil#isXXX(Cell) methods
[
https://issues.apache.org/jira/browse/HBASE-19111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223125#comment-16223125
]
Hadoop QA commented on HBASE-19111:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 6s{color}
| {color:red} HBASE-19111 does not apply to branch-2. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-19111 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12894481/HBASE-19111.001.branch-2.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/9459/console |
| Powered by | Apache Yetus 0.4.0 http://yetus.apache.org |
This message was automatically generated.
> Add missing CellUtil#isXXX(Cell) methods
>
>
> Key: HBASE-19111
> URL: https://issues.apache.org/jira/browse/HBASE-19111
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19111.001.branch-2.patch
>
>
> Over in HBASE-19002 while trying to write some RegionObservers, I found that
> I couldn't find a public-API method to determine if a Cell was for a Put. We
> seem to only have API for determining if it's a Delete.
> Let's get some methods added to CellUtil for users to consume.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18925) Need updated mockito for using java optional
[
https://issues.apache.org/jira/browse/HBASE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223119#comment-16223119
]
Hadoop QA commented on HBASE-18925:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 56 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 5m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 7m
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 17m
58s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m
12s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
17s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 9m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 8m
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
1s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
17s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
26s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
51m 45s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 5m
48s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}109m 40s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
22s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}235m 22s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.regionserver.wal.TestAsyncWALReplayCompressed |
| | hadoop.hbase.regionserver.wal.TestWALReplayCompressed |
| | hadoop.hbase.regionserver.wal.TestSecureAsyncWALReplay |
| | hadoop.hbase.regionserver.wal.TestAsyncWALReplay |
| | hadoop.hbase.regionserver.wal.TestWALReplay |
| | hadoop.hbase.TestHBaseTestingUtility |
| | hadoop.hbase.regionserver.wal.TestSecureWALReplay |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-18925 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/1289/HBASE-18925.master.006.patch
|
| Optional Tests | asflicense javac javadoc unit shadedjars hadoopcheck
xml compile findbugs hbaseanti checkstyle |
| uname |
[jira] [Commented] (HBASE-18770) Remove bypass method in ObserverContext and implement the 'bypass' logic case by case
[ https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223113#comment-16223113 ] stack commented on HBASE-18770: --- .003 fixes some unit tests. Throws exceptions if you try to bypass on a method that doesn't support bypass. > Remove bypass method in ObserverContext and implement the 'bypass' logic case > by case > - > > Key: HBASE-18770 > URL: https://issues.apache.org/jira/browse/HBASE-18770 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang >Assignee: stack >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18770.master.001.patch, > HBASE-18770.master.002.patch, HBASE-18770.master.003.patch > > > http://search-hadoop.com/m/HBase/YGbbXd0RDCIHSC1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18770) Remove bypass method in ObserverContext and implement the 'bypass' logic case by case
[ https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18770: -- Attachment: HBASE-18770.master.003.patch > Remove bypass method in ObserverContext and implement the 'bypass' logic case > by case > - > > Key: HBASE-18770 > URL: https://issues.apache.org/jira/browse/HBASE-18770 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang >Assignee: stack >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18770.master.001.patch, > HBASE-18770.master.002.patch, HBASE-18770.master.003.patch > > > http://search-hadoop.com/m/HBase/YGbbXd0RDCIHSC1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19102) TestZooKeeperMainServer fails with KeeperException$ConnectionLossException
[ https://issues.apache.org/jira/browse/HBASE-19102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19102: -- Assignee: stack Status: Patch Available (was: Open) > TestZooKeeperMainServer fails with KeeperException$ConnectionLossException > -- > > Key: HBASE-19102 > URL: https://issues.apache.org/jira/browse/HBASE-19102 > Project: HBase > Issue Type: Bug >Reporter: stack >Assignee: stack > Attachments: HBASE-19102.master.001.patch > > > I'm trying to run test suite on a local machine. I never get to the second > part because I fail on below test with below exception near every time (and > an ipv6 test... will do that next). > 1 > --- > 2 Test set: org.apache.hadoop.hbase.zookeeper.TestZooKeeperMainServer > 3 > --- > 4 Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 16.161 s > <<< FAILURE! - in org.apache.hadoop.hbase.zookeeper.TestZooKeeperMainServer > 5 > testCommandLineWorks(org.apache.hadoop.hbase.zookeeper.TestZooKeeperMainServer) > Time elapsed: 15.848 s <<< ERROR! > 6 org.apache.zookeeper.KeeperException$ConnectionLossException: > KeeperErrorCode = ConnectionLoss for /testCommandLineWorks > 7 at > org.apache.hadoop.hbase.zookeeper.TestZooKeeperMainServer.testCommandLineWorks(TestZooKeeperMainServer.java:81) > Looks like running the command before we are connected causes the above -- we > pause 15 seconds and then throw the above. If I wait until connected before > proceding, stuff seems to work reliably. I don't have access to the watcher > on connections since we override the zk main class... so this seems only > avenue available at mo (This zk main thing is all a hack around zk main > because it had bugs ... but I think we have to keep the hack because folks > use different versions of zk. My $workplace defaults to something that is > years old, 3.4.5 for instance). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18995) Move methods that are for internal usage from CellUtil to Private util class
[ https://issues.apache.org/jira/browse/HBASE-18995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-18995: -- Resolution: Fixed Hadoop Flags: Reviewed Release Note: Split CellUtil into public CellUtil and PrivateCellUtil for Internal use only. Status: Resolved (was: Patch Available) Pushed to master and branch-2. Thanks for the nice patch Ram. Check me. I pushed HBASE-18995-branch-2.002.patch to branch-2 and HBASE-18995_2.patch to master. That what you wanted sir? [~ram_krish] Thanks. > Move methods that are for internal usage from CellUtil to Private util class > > > Key: HBASE-18995 > URL: https://issues.apache.org/jira/browse/HBASE-18995 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0-alpha-3 >Reporter: ramkrishna.s.vasudevan >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18995-branch-2.002.patch, > HBASE-18995-branch-2.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_1.patch, > HBASE-18995-branch-2_1.patch, HBASE-18995-branch-2_2.patch, > HBASE-18995_002-branch-2.patch, HBASE-18995_002-branch-2.patch, > HBASE-18995_003-branch-2.patch, HBASE-18995_1.patch, HBASE-18995_2.patch, > HBASE-18995_2.patch > > > This was brought up long time back. We need to move some of the public APIs > from CellUtil to internal private Util class because they are used in some > internal flow and does not make sense to have it in a @public exposed Util > class. > The topic again came in HBASE-18945 RB comments also. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[ https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223095#comment-16223095 ] stack commented on HBASE-19095: --- Moved to beta-1. [~eshcar] and [~anastas] FYI. > Add CP hooks in RegionObserver for in memory compaction > --- > > Key: HBASE-19095 > URL: https://issues.apache.org/jira/browse/HBASE-19095 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang > Fix For: 2.0.0-beta-1 > > > This is a hole in our CP hooks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[ https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19095: -- Fix Version/s: (was: 2.0.0-alpha-4) 2.0.0-beta-1 > Add CP hooks in RegionObserver for in memory compaction > --- > > Key: HBASE-19095 > URL: https://issues.apache.org/jira/browse/HBASE-19095 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang > Fix For: 2.0.0-beta-1 > > > This is a hole in our CP hooks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[ https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223093#comment-16223093 ] Duo Zhang commented on HBASE-19095: --- I do not have a patch yet. And I think in memory compaction itself is not stable enough yet? So I think it is OK to delay this to beta-1? Say in release note of alpha4 that in memory compaction is still under development so the CP hooks for it will be added later is OK? Thanks. > Add CP hooks in RegionObserver for in memory compaction > --- > > Key: HBASE-19095 > URL: https://issues.apache.org/jira/browse/HBASE-19095 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang > Fix For: 2.0.0-alpha-4 > > > This is a hole in our CP hooks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19112) Suspect methods on Cell to be deprecated
[
https://issues.apache.org/jira/browse/HBASE-19112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-19112:
--
Priority: Blocker (was: Major)
> Suspect methods on Cell to be deprecated
>
>
> Key: HBASE-19112
> URL: https://issues.apache.org/jira/browse/HBASE-19112
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: Josh Elser
>Priority: Blocker
> Fix For: 2.0.0-beta-1
>
>
> [~chia7712] suggested on the [mailing
> list|https://lists.apache.org/thread.html/e6de9af26d9b888a358ba48bf74655ccd893573087c032c0fcf01585@%3Cdev.hbase.apache.org%3E]
> that we have some methods on Cell which should be deprecated for removal:
> * {{#getType()}}
> * {{#getTimestamp()}}
> * {{#getTag()}}
> * {{#getSequenceId()}}
> Let's make a pass over these (and maybe the rest) to make sure that there
> aren't others which are either implementation details or methods returning
> now-private-marked classes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19111) Add missing CellUtil#isXXX(Cell) methods
[ https://issues.apache.org/jira/browse/HBASE-19111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223089#comment-16223089 ] stack commented on HBASE-19111: --- Looks lovely. +1 We have Cell, CellBuilder, and then CellUtil (PrivateCellUtil and CellUtil). We need to add some packageinfo and doc linking the three so folks are able to navigate Not for this issue. > Add missing CellUtil#isXXX(Cell) methods > > > Key: HBASE-19111 > URL: https://issues.apache.org/jira/browse/HBASE-19111 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19111.001.branch-2.patch > > > Over in HBASE-19002 while trying to write some RegionObservers, I found that > I couldn't find a public-API method to determine if a Cell was for a Put. We > seem to only have API for determining if it's a Delete. > Let's get some methods added to CellUtil for users to consume. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19099) Evaluate the remaining compatibility concerns between branch-1.3 and branch-1.4 / branch-1
[ https://issues.apache.org/jira/browse/HBASE-19099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223075#comment-16223075 ] Andrew Purtell commented on HBASE-19099: Thanks for talking a look [~elserj] > Edit: I should really refresh posts before typing a reply Yeah, I embarrassed myself today talking with [~abhishek.chouhan] about something before refreshing another JIRA issue. Same here. > Evaluate the remaining compatibility concerns between branch-1.3 and > branch-1.4 / branch-1 > -- > > Key: HBASE-19099 > URL: https://issues.apache.org/jira/browse/HBASE-19099 > Project: HBase > Issue Type: Task >Affects Versions: 1.4.0, 1.5.0 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Blocker > Fix For: 1.4.0, 1.5.0 > > > For discussion, here are the remaining compatibility concerns you will > encounter upon moving up from 1.3 to 1.4: > The below all relate to source level compatibility. Recompilation of a client > program may be terminated with the message "class C is not abstract and does > not override abstract method M in TYPE". According to our compatibility > guidelines we are allowed to add methods to interfaces, so these are ALLOWED. > Please let me know if you disagree. > package org.apache.hadoop.hbase.client > interface Admin > * Abstract method clearDeadServers ( List ) has been added to > this interface. > * Abstract method cloneSnapshot ( String, TableName, boolean ) has been added > to this interface. > * Abstract method isCleanerChoreEnabled ( ) has been added to this interface. > * Abstract method isMasterInMaintenanceMode ( ) has been added to this > interface. > * Abstract method listDeadServers ( ) has been added to this interface. > * Abstract method restoreSnapshot ( String, boolean, boolean ) has been added > to this interface. > * Abstract method runCleanerChore ( ) has been added to this interface. > * Abstract method setCleanerChoreRunning ( boolean ) has been added to this > interface. > package org.apache.hadoop.hbase.client > interface ResultScanner > * Abstract method renewLease ( ) has been added to this interface. > * Abstract method getScanMetrics ( ) has been added to this interface. > package org.apache.hadoop.hbase.client > interface Table > * Abstract method getReadRpcTimeout ( ) has been added to this interface. > * Abstract method getWriteRpcTimeout ( ) has been added to this interface. > * Abstract method setReadRpcTimeout ( int ) has been added to this interface. > * Abstract method setWriteRpcTimeout ( int ) has been added to this interface. > package org.apache.hadoop.hbase.replication > interface ReplicationPeer > * Abstract method getPeerBandwidth ( ) has been added to this interface. > * Abstract method trackPeerConfigChanges ( ReplicationPeerConfigListener ) > has been added to this interface. > package org.apache.hadoop.hbase.coprocessor > interface MasterCoprocessorEnvironment > * Abstract method getMetricRegistryForMaster ( ) has been added to this > interface. > package org.apache.hadoop.hbase.coprocessor > interface MasterObserver > * Abstract method postAddRSGroup ( > ObserverContext, String ) has been added to > this interface. > * Abstract method postBalanceRSGroup ( > ObserverContext, String, boolean ) has been > added to this interface. > * Abstract method postClearDeadServers ( > ObserverContext ) has been added to this > interface. > * Abstract method postListDeadServers ( > ObserverContext ) has been added to this > interface. > * Abstract method postMoveServers ( > ObserverContext, Set, String ) has > been added to this interface. > * Abstract method postMoveServersAndTables ( > ObserverContext, Set, Set, > String ) has been added to this interface. > * Abstract method postMoveTables ( > ObserverContext, Set, String ) has > been added to this interface. > * Abstract method postRemoveRSGroup ( > ObserverContext, String ) has been added to > this interface. > * Abstract method preAddRSGroup ( > ObserverContext, String ) has been added to > this interface. > * Abstract method preBalanceRSGroup ( > ObserverContext, String ) has been added to > this interface. > * Abstract method preClearDeadServers ( > ObserverContext ) has been added to this > interface. > * Abstract method preListDeadServers ( > ObserverContext ) has been added to this > interface. > * Abstract method preMoveServers ( > ObserverContext, Set, String ) has > been added to this interface. > * Abstract method preMoveServersAndTables ( > ObserverContext, Set, Set, > String ) has been added to this interface. > * Abstract method preMoveTables ( > ObserverContext, Set, String ) has > been added to this interface. > * Abstract method preRemoveRSGroup ( >
[jira] [Comment Edited] (HBASE-19099) Evaluate the remaining compatibility concerns between branch-1.3 and branch-1.4 / branch-1
[ https://issues.apache.org/jira/browse/HBASE-19099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223066#comment-16223066 ] Josh Elser edited comment on HBASE-19099 at 10/28/17 12:02 AM: --- bq. Two constants were removed from Public class TableInputFormatBase These are the only two that caught my eye. Looks like they're configuration that's now invalid after the changes made by HBASE-16894 -- autobalancing regions across Mappers is only a factor of Region size now. I have to assume that since we committed the change in functionality, it's a "net-improvement" kind of scenario. I think release notes on HBASE-16894 would be sufficient to justify the constants being removed -- the compilation error is a good "heads up" to users who might not otherwise realize that the implementation changed. +1 on the rest. Thanks for the leg work, Andrew. (Edit: I should really refresh posts before typing a reply. Restoring them is fine too. Don't care strongly enough either way) was (Author: elserj): bq. Two constants were removed from Public class TableInputFormatBase These are the only two that caught my eye. Looks like they're configuration that's now invalid after the changes made by HBASE-16894 -- autobalancing regions across Mappers is only a factor of Region size now. I have to assume that since we committed the change in functionality, it's a "net-improvement" kind of scenario. I think release notes on HBASE-16894 would be sufficient to justify the constants being removed -- the compilation error is a good "heads up" to users who might not otherwise realize that the implementation changed. +1 on the rest. Thanks for the leg work, Andrew. > Evaluate the remaining compatibility concerns between branch-1.3 and > branch-1.4 / branch-1 > -- > > Key: HBASE-19099 > URL: https://issues.apache.org/jira/browse/HBASE-19099 > Project: HBase > Issue Type: Task >Affects Versions: 1.4.0, 1.5.0 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Blocker > Fix For: 1.4.0, 1.5.0 > > > For discussion, here are the remaining compatibility concerns you will > encounter upon moving up from 1.3 to 1.4: > The below all relate to source level compatibility. Recompilation of a client > program may be terminated with the message "class C is not abstract and does > not override abstract method M in TYPE". According to our compatibility > guidelines we are allowed to add methods to interfaces, so these are ALLOWED. > Please let me know if you disagree. > package org.apache.hadoop.hbase.client > interface Admin > * Abstract method clearDeadServers ( List ) has been added to > this interface. > * Abstract method cloneSnapshot ( String, TableName, boolean ) has been added > to this interface. > * Abstract method isCleanerChoreEnabled ( ) has been added to this interface. > * Abstract method isMasterInMaintenanceMode ( ) has been added to this > interface. > * Abstract method listDeadServers ( ) has been added to this interface. > * Abstract method restoreSnapshot ( String, boolean, boolean ) has been added > to this interface. > * Abstract method runCleanerChore ( ) has been added to this interface. > * Abstract method setCleanerChoreRunning ( boolean ) has been added to this > interface. > package org.apache.hadoop.hbase.client > interface ResultScanner > * Abstract method renewLease ( ) has been added to this interface. > * Abstract method getScanMetrics ( ) has been added to this interface. > package org.apache.hadoop.hbase.client > interface Table > * Abstract method getReadRpcTimeout ( ) has been added to this interface. > * Abstract method getWriteRpcTimeout ( ) has been added to this interface. > * Abstract method setReadRpcTimeout ( int ) has been added to this interface. > * Abstract method setWriteRpcTimeout ( int ) has been added to this interface. > package org.apache.hadoop.hbase.replication > interface ReplicationPeer > * Abstract method getPeerBandwidth ( ) has been added to this interface. > * Abstract method trackPeerConfigChanges ( ReplicationPeerConfigListener ) > has been added to this interface. > package org.apache.hadoop.hbase.coprocessor > interface MasterCoprocessorEnvironment > * Abstract method getMetricRegistryForMaster ( ) has been added to this > interface. > package org.apache.hadoop.hbase.coprocessor > interface MasterObserver > * Abstract method postAddRSGroup ( > ObserverContext, String ) has been added to > this interface. > * Abstract method postBalanceRSGroup ( > ObserverContext, String, boolean ) has been > added to this interface. > * Abstract method postClearDeadServers ( > ObserverContext ) has been added to this > interface. > * Abstract method
[jira] [Commented] (HBASE-19099) Evaluate the remaining compatibility concerns between branch-1.3 and branch-1.4 / branch-1
[ https://issues.apache.org/jira/browse/HBASE-19099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223066#comment-16223066 ] Josh Elser commented on HBASE-19099: bq. Two constants were removed from Public class TableInputFormatBase These are the only two that caught my eye. Looks like they're configuration that's now invalid after the changes made by HBASE-16894 -- autobalancing regions across Mappers is only a factor of Region size now. I have to assume that since we committed the change in functionality, it's a "net-improvement" kind of scenario. I think release notes on HBASE-16894 would be sufficient to justify the constants being removed -- the compilation error is a good "heads up" to users who might not otherwise realize that the implementation changed. +1 on the rest. Thanks for the leg work, Andrew. > Evaluate the remaining compatibility concerns between branch-1.3 and > branch-1.4 / branch-1 > -- > > Key: HBASE-19099 > URL: https://issues.apache.org/jira/browse/HBASE-19099 > Project: HBase > Issue Type: Task >Affects Versions: 1.4.0, 1.5.0 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Blocker > Fix For: 1.4.0, 1.5.0 > > > For discussion, here are the remaining compatibility concerns you will > encounter upon moving up from 1.3 to 1.4: > The below all relate to source level compatibility. Recompilation of a client > program may be terminated with the message "class C is not abstract and does > not override abstract method M in TYPE". According to our compatibility > guidelines we are allowed to add methods to interfaces, so these are ALLOWED. > Please let me know if you disagree. > package org.apache.hadoop.hbase.client > interface Admin > * Abstract method clearDeadServers ( List ) has been added to > this interface. > * Abstract method cloneSnapshot ( String, TableName, boolean ) has been added > to this interface. > * Abstract method isCleanerChoreEnabled ( ) has been added to this interface. > * Abstract method isMasterInMaintenanceMode ( ) has been added to this > interface. > * Abstract method listDeadServers ( ) has been added to this interface. > * Abstract method restoreSnapshot ( String, boolean, boolean ) has been added > to this interface. > * Abstract method runCleanerChore ( ) has been added to this interface. > * Abstract method setCleanerChoreRunning ( boolean ) has been added to this > interface. > package org.apache.hadoop.hbase.client > interface ResultScanner > * Abstract method renewLease ( ) has been added to this interface. > * Abstract method getScanMetrics ( ) has been added to this interface. > package org.apache.hadoop.hbase.client > interface Table > * Abstract method getReadRpcTimeout ( ) has been added to this interface. > * Abstract method getWriteRpcTimeout ( ) has been added to this interface. > * Abstract method setReadRpcTimeout ( int ) has been added to this interface. > * Abstract method setWriteRpcTimeout ( int ) has been added to this interface. > package org.apache.hadoop.hbase.replication > interface ReplicationPeer > * Abstract method getPeerBandwidth ( ) has been added to this interface. > * Abstract method trackPeerConfigChanges ( ReplicationPeerConfigListener ) > has been added to this interface. > package org.apache.hadoop.hbase.coprocessor > interface MasterCoprocessorEnvironment > * Abstract method getMetricRegistryForMaster ( ) has been added to this > interface. > package org.apache.hadoop.hbase.coprocessor > interface MasterObserver > * Abstract method postAddRSGroup ( > ObserverContext, String ) has been added to > this interface. > * Abstract method postBalanceRSGroup ( > ObserverContext, String, boolean ) has been > added to this interface. > * Abstract method postClearDeadServers ( > ObserverContext ) has been added to this > interface. > * Abstract method postListDeadServers ( > ObserverContext ) has been added to this > interface. > * Abstract method postMoveServers ( > ObserverContext, Set, String ) has > been added to this interface. > * Abstract method postMoveServersAndTables ( > ObserverContext, Set, Set, > String ) has been added to this interface. > * Abstract method postMoveTables ( > ObserverContext, Set, String ) has > been added to this interface. > * Abstract method postRemoveRSGroup ( > ObserverContext, String ) has been added to > this interface. > * Abstract method preAddRSGroup ( > ObserverContext, String ) has been added to > this interface. > * Abstract method preBalanceRSGroup ( > ObserverContext, String ) has been added to > this interface. > * Abstract method preClearDeadServers ( > ObserverContext ) has been added to this > interface. > * Abstract method preListDeadServers ( >
[jira] [Commented] (HBASE-19100) Missing break in catch block of InterruptedException in HRegion#waitForFlushesAndCompactions
[ https://issues.apache.org/jira/browse/HBASE-19100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223060#comment-16223060 ] Ted Yu commented on HBASE-19100: >From https://builds.apache.org/job/PreCommit-HBASE-Build/9451/ , there was one >failed test: TestCoprocessorWhitelistMasterObserver The test passes locally. > Missing break in catch block of InterruptedException in > HRegion#waitForFlushesAndCompactions > > > Key: HBASE-19100 > URL: https://issues.apache.org/jira/browse/HBASE-19100 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: Ted Yu > Attachments: 19100.v1.txt, 19100.v1.txt > > > Over in HBASE-19072, Anoop reminded me that there was a missing break in > HRegion#waitForFlushesAndCompactions as well. > This issue would fix the defect. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19114) Split out o.a.h.h.zookeeper from hbase-server and hbase-client
[ https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-19114: - Description: Changes so far: - Moved DrainingServerTracker and RegionServerTracker to hbase-server:o.a.h.h.master. - Move Abortable to hbase-common. Since it's IA.Private and independent of anything, moving it to hbase-common which is at bottom of the dependency tree is better. - Moved RecoveringRegionWatcher to hbase-server:o.a.h.h.regionserver - Moved SplitOrMergeTracker to oahh.master (because it depends on a PB) - Moving hbase-client:oahh.zookeeper.* to hbase-zookeeper module. We want to keep hbase-zookeeper very independent and hence at lowest levels in our dependency tree. - ZKUtil is a huge tangle since it's linked to almost everything in \[hbase-client/]oahh.zookeeper. And pulling it down requires some basic proto functions (mergeFrom, PBmagic, etc). So what i did was: ** Pulled down common and basic protobuf functions (which only depend on com.google.protobuf.\*) to hbase-common so other code depending on them can be pulled down if possible/wanted in future. This will help future dependency untangling too. These are ProtobufMagic and ProtobufHelpers. ** Didn't move any hbase-specific PB stuff to hbase-common. We can't pull things into hbase-common which add dependency between it and hbase-protobuf/hbase-shaded-protobuf since we very recently untangled them. - DEFAULT_REPLICA_ID is used in many places in ZK. Declared a new constant in HConstants (since it's in hbase-common) and using it in hbase-zookeeper. RegionInfo.DEFAULT_REPLICA_ID also takes its value from it to avoid case where two values can become different. was: Changes so far: - Moved DrainingServerTracker and RegionServerTracker to hbase-server:o.a.h.h.master. - Move Abortable to hbase-common. Since it's IA.Private and independent of anything, moving it to hbase-common which is at bottom of the dependency tree is better. - Moved RecoveringRegionWatcher to hbase-server:o.a.h.h.regionserver - Moved SplitOrMergeTracker to oahh.master (because it depends on a PB) - Moving hbase-client:oahh.zookeeper.* to hbase-zookeeper module. We want to keep hbase-zookeeper very independent and hence at lowest levels in our dependency tree. - ZKUtil is a huge tangle since it's linked to almost everything in \[hbase-client/]oahh.zookeeper. And pulling it down requires some basic proto functions (mergeFrom, PBmagic, etc). So what i did was: ** Pulled down common and basic protobuf functions (which only depend on com.google.protobuf.\*) to hbase-common so other code depending on them can be pulled down if possible/wanted in future. This will help future dependency untangling too. These are ProtobufMagic and ProtobufHelpers. ** Didn't move any hbase-specific PB stuff to hbase-common. We can't pull things into hbase-common which add dependency between it and hbase-protobuf/hbase-shaded-protobuf since we very recently untangled them. - DEFAULT_REPLICA_ID is used in many places in ZK. Declared a new contant in HConstants (since it's in hbase-common) and using it in hbase-zookeeper. RegionInfo.DEFAULT_REPLICA_ID too takes its value from it. > Split out o.a.h.h.zookeeper from hbase-server and hbase-client > -- > > Key: HBASE-19114 > URL: https://issues.apache.org/jira/browse/HBASE-19114 > Project: HBase > Issue Type: Sub-task >Reporter: Appy >Assignee: Appy > Attachments: HBASE-19114.master.001.patch > > > Changes so far: > - Moved DrainingServerTracker and RegionServerTracker to > hbase-server:o.a.h.h.master. > - Move Abortable to hbase-common. Since it's IA.Private and independent of > anything, moving it to hbase-common which is at bottom of the dependency tree > is better. > - Moved RecoveringRegionWatcher to hbase-server:o.a.h.h.regionserver > - Moved SplitOrMergeTracker to oahh.master (because it depends on a PB) > - Moving hbase-client:oahh.zookeeper.* to hbase-zookeeper module. We want to > keep hbase-zookeeper very independent and hence at lowest levels in our > dependency tree. > - ZKUtil is a huge tangle since it's linked to almost everything in > \[hbase-client/]oahh.zookeeper. And pulling it down requires some basic proto > functions (mergeFrom, PBmagic, etc). So what i did was: >** Pulled down common and basic protobuf functions (which only depend on > com.google.protobuf.\*) to hbase-common so other code depending on them can > be pulled down if possible/wanted in future. This will help future dependency > untangling too. These are ProtobufMagic and ProtobufHelpers. > ** Didn't move any hbase-specific PB stuff to hbase-common. We can't pull > things into hbase-common which add dependency between it and > hbase-protobuf/hbase-shaded-protobuf since we very
[jira] [Updated] (HBASE-19114) Split out o.a.h.h.zookeeper from hbase-server and hbase-client
[ https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-19114: - Status: Patch Available (was: Open) > Split out o.a.h.h.zookeeper from hbase-server and hbase-client > -- > > Key: HBASE-19114 > URL: https://issues.apache.org/jira/browse/HBASE-19114 > Project: HBase > Issue Type: Sub-task >Reporter: Appy >Assignee: Appy > Attachments: HBASE-19114.master.001.patch > > > Changes so far: > - Moved DrainingServerTracker and RegionServerTracker to > hbase-server:o.a.h.h.master. > - Move Abortable to hbase-common. Since it's IA.Private and independent of > anything, moving it to hbase-common which is at bottom of the dependency tree > is better. > - Moved RecoveringRegionWatcher to hbase-server:o.a.h.h.regionserver > - Moved SplitOrMergeTracker to oahh.master (because it depends on a PB) > - Moving hbase-client:oahh.zookeeper.* to hbase-zookeeper module. We want to > keep hbase-zookeeper very independent and hence at lowest levels in our > dependency tree. > - ZKUtil is a huge tangle since it's linked to almost everything in > \[hbase-client/]oahh.zookeeper. And pulling it down requires some basic proto > functions (mergeFrom, PBmagic, etc). So what i did was: >** Pulled down common and basic protobuf functions (which only depend on > com.google.protobuf.\*) to hbase-common so other code depending on them can > be pulled down if possible/wanted in future. This will help future dependency > untangling too. These are ProtobufMagic and ProtobufHelpers. > ** Didn't move any hbase-specific PB stuff to hbase-common. We can't pull > things into hbase-common which add dependency between it and > hbase-protobuf/hbase-shaded-protobuf since we very recently untangled them. > - DEFAULT_REPLICA_ID is used in many places in ZK. Declared a new contant in > HConstants (since it's in hbase-common) and using it in hbase-zookeeper. > RegionInfo.DEFAULT_REPLICA_ID too takes its value from it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19114) Split out o.a.h.h.zookeeper from hbase-server and hbase-client
[ https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-19114: - Description: Changes so far: - Moved DrainingServerTracker and RegionServerTracker to hbase-server:o.a.h.h.master. - Move Abortable to hbase-common. Since it's IA.Private and independent of anything, moving it to hbase-common which is at bottom of the dependency tree is better. - Moved RecoveringRegionWatcher to hbase-server:o.a.h.h.regionserver - Moved SplitOrMergeTracker to oahh.master (because it depends on a PB) - Moving hbase-client:oahh.zookeeper.* to hbase-zookeeper module. We want to keep hbase-zookeeper very independent and hence at lowest levels in our dependency tree. - ZKUtil is a huge tangle since it's linked to almost everything in \[hbase-client/]oahh.zookeeper. And pulling it down requires some basic proto functions (mergeFrom, PBmagic, etc). So what i did was: **Pulled down common and basic protobuf functions (which only depend on com.google.protobuf.\*) to hbase-common so other code depending on them can be pulled down if possible/wanted in future. This will help future dependency untangling too. These are ProtobufMagic and ProtobufHelpers. **Didn't move any hbase-specific PB stuff to hbase-common. We can't pull things into hbase-common which add dependency between it and hbase-protobuf/hbase-shaded-protobuf since we very recently untangled them. - DEFAULT_REPLICA_ID is used in many places in ZK. Declared a new contant in HConstants (since it's in hbase-common) and using it in hbase-zookeeper. RegionInfo.DEFAULT_REPLICA_ID too takes its value from it. was: Changes so far: - Moved DrainingServerTracker and RegionServerTracker to hbase-server:o.a.h.h.master. - Move Abortable to hbase-common. Since it's IA.Private and independent of anything, moving it to hbase-common which is at bottom of the dependency tree is better. - Moved RecoveringRegionWatcher to hbase-server:o.a.h.h.regionserver - Moved SplitOrMergeTracker to oahh.master (because it depends on a PB) - Moving hbase-client:oahh.zookeeper.* to hbase-zookeeper module. We want to keep hbase-zookeeper very independent and hence at lowest levels in our dependency tree. - ZKUtil is a huge tangle since it's linked to almost everything in [hbase-client/]oahh.zookeeper. And pulling it down requires some basic proto functions (mergeFrom, PBmagic, etc). So what i did was: **Pulled down common and basic protobuf functions (which only depend on com.google.protobuf.\*) to hbase-common so other code depending on them can be pulled down if possible/wanted in future. This will help future dependency untangling too. These are ProtobufMagic and ProtobufHelpers. **Didn't move any hbase-specific PB stuff to hbase-common. We can't pull things into hbase-common which add dependency between it and hbase-protobuf/hbase-shaded-protobuf since we very recently untangled them. - DEFAULT_REPLICA_ID is used in many places in ZK. Declared a new contant in HConstants (since it's in hbase-common) and using it in hbase-zookeeper. RegionInfo.DEFAULT_REPLICA_ID too takes its value from it. > Split out o.a.h.h.zookeeper from hbase-server and hbase-client > -- > > Key: HBASE-19114 > URL: https://issues.apache.org/jira/browse/HBASE-19114 > Project: HBase > Issue Type: Sub-task >Reporter: Appy >Assignee: Appy > Attachments: HBASE-19114.master.001.patch > > > Changes so far: > - Moved DrainingServerTracker and RegionServerTracker to > hbase-server:o.a.h.h.master. > - Move Abortable to hbase-common. Since it's IA.Private and independent of > anything, moving it to hbase-common which is at bottom of the dependency tree > is better. > - Moved RecoveringRegionWatcher to hbase-server:o.a.h.h.regionserver > - Moved SplitOrMergeTracker to oahh.master (because it depends on a PB) > - Moving hbase-client:oahh.zookeeper.* to hbase-zookeeper module. We want to > keep hbase-zookeeper very independent and hence at lowest levels in our > dependency tree. > - ZKUtil is a huge tangle since it's linked to almost everything in > \[hbase-client/]oahh.zookeeper. And pulling it down requires some basic proto > functions (mergeFrom, PBmagic, etc). So what i did was: >**Pulled down common and basic protobuf functions (which only depend on > com.google.protobuf.\*) to hbase-common so other code depending on them can > be pulled down if possible/wanted in future. This will help future dependency > untangling too. These are ProtobufMagic and ProtobufHelpers. > **Didn't move any hbase-specific PB stuff to hbase-common. We can't pull > things into hbase-common which add dependency between it and > hbase-protobuf/hbase-shaded-protobuf since we very recently untangled them. > - DEFAULT_REPLICA_ID is used in many
[jira] [Updated] (HBASE-19114) Split out o.a.h.h.zookeeper from hbase-server and hbase-client
[ https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-19114: - Description: Changes so far: - Moved DrainingServerTracker and RegionServerTracker to hbase-server:o.a.h.h.master. - Move Abortable to hbase-common. Since it's IA.Private and independent of anything, moving it to hbase-common which is at bottom of the dependency tree is better. - Moved RecoveringRegionWatcher to hbase-server:o.a.h.h.regionserver - Moved SplitOrMergeTracker to oahh.master (because it depends on a PB) - Moving hbase-client:oahh.zookeeper.* to hbase-zookeeper module. We want to keep hbase-zookeeper very independent and hence at lowest levels in our dependency tree. - ZKUtil is a huge tangle since it's linked to almost everything in \[hbase-client/]oahh.zookeeper. And pulling it down requires some basic proto functions (mergeFrom, PBmagic, etc). So what i did was: ** Pulled down common and basic protobuf functions (which only depend on com.google.protobuf.\*) to hbase-common so other code depending on them can be pulled down if possible/wanted in future. This will help future dependency untangling too. These are ProtobufMagic and ProtobufHelpers. ** Didn't move any hbase-specific PB stuff to hbase-common. We can't pull things into hbase-common which add dependency between it and hbase-protobuf/hbase-shaded-protobuf since we very recently untangled them. - DEFAULT_REPLICA_ID is used in many places in ZK. Declared a new contant in HConstants (since it's in hbase-common) and using it in hbase-zookeeper. RegionInfo.DEFAULT_REPLICA_ID too takes its value from it. was: Changes so far: - Moved DrainingServerTracker and RegionServerTracker to hbase-server:o.a.h.h.master. - Move Abortable to hbase-common. Since it's IA.Private and independent of anything, moving it to hbase-common which is at bottom of the dependency tree is better. - Moved RecoveringRegionWatcher to hbase-server:o.a.h.h.regionserver - Moved SplitOrMergeTracker to oahh.master (because it depends on a PB) - Moving hbase-client:oahh.zookeeper.* to hbase-zookeeper module. We want to keep hbase-zookeeper very independent and hence at lowest levels in our dependency tree. - ZKUtil is a huge tangle since it's linked to almost everything in \[hbase-client/]oahh.zookeeper. And pulling it down requires some basic proto functions (mergeFrom, PBmagic, etc). So what i did was: **Pulled down common and basic protobuf functions (which only depend on com.google.protobuf.\*) to hbase-common so other code depending on them can be pulled down if possible/wanted in future. This will help future dependency untangling too. These are ProtobufMagic and ProtobufHelpers. **Didn't move any hbase-specific PB stuff to hbase-common. We can't pull things into hbase-common which add dependency between it and hbase-protobuf/hbase-shaded-protobuf since we very recently untangled them. - DEFAULT_REPLICA_ID is used in many places in ZK. Declared a new contant in HConstants (since it's in hbase-common) and using it in hbase-zookeeper. RegionInfo.DEFAULT_REPLICA_ID too takes its value from it. > Split out o.a.h.h.zookeeper from hbase-server and hbase-client > -- > > Key: HBASE-19114 > URL: https://issues.apache.org/jira/browse/HBASE-19114 > Project: HBase > Issue Type: Sub-task >Reporter: Appy >Assignee: Appy > Attachments: HBASE-19114.master.001.patch > > > Changes so far: > - Moved DrainingServerTracker and RegionServerTracker to > hbase-server:o.a.h.h.master. > - Move Abortable to hbase-common. Since it's IA.Private and independent of > anything, moving it to hbase-common which is at bottom of the dependency tree > is better. > - Moved RecoveringRegionWatcher to hbase-server:o.a.h.h.regionserver > - Moved SplitOrMergeTracker to oahh.master (because it depends on a PB) > - Moving hbase-client:oahh.zookeeper.* to hbase-zookeeper module. We want to > keep hbase-zookeeper very independent and hence at lowest levels in our > dependency tree. > - ZKUtil is a huge tangle since it's linked to almost everything in > \[hbase-client/]oahh.zookeeper. And pulling it down requires some basic proto > functions (mergeFrom, PBmagic, etc). So what i did was: >** Pulled down common and basic protobuf functions (which only depend on > com.google.protobuf.\*) to hbase-common so other code depending on them can > be pulled down if possible/wanted in future. This will help future dependency > untangling too. These are ProtobufMagic and ProtobufHelpers. > ** Didn't move any hbase-specific PB stuff to hbase-common. We can't pull > things into hbase-common which add dependency between it and > hbase-protobuf/hbase-shaded-protobuf since we very recently untangled them. > - DEFAULT_REPLICA_ID is used in
[jira] [Updated] (HBASE-19114) Split out o.a.h.h.zookeeper from hbase-server and hbase-client
[ https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-19114: - Description: Changes so far: - Moved DrainingServerTracker and RegionServerTracker to hbase-server:o.a.h.h.master. - Move Abortable to hbase-common. Since it's IA.Private and independent of anything, moving it to hbase-common which is at bottom of the dependency tree is better. - Moved RecoveringRegionWatcher to hbase-server:o.a.h.h.regionserver - Moved SplitOrMergeTracker to oahh.master (because it depends on a PB) - Moving hbase-client:oahh.zookeeper.* to hbase-zookeeper module. We want to keep hbase-zookeeper very independent and hence at lowest levels in our dependency tree. - ZKUtil is a huge tangle since it's linked to almost everything in [hbase-client/]oahh.zookeeper. And pulling it down requires some basic proto functions (mergeFrom, PBmagic, etc). So what i did was: **Pulled down common and basic protobuf functions (which only depend on com.google.protobuf.\*) to hbase-common so other code depending on them can be pulled down if possible/wanted in future. This will help future dependency untangling too. These are ProtobufMagic and ProtobufHelpers. **Didn't move any hbase-specific PB stuff to hbase-common. We can't pull things into hbase-common which add dependency between it and hbase-protobuf/hbase-shaded-protobuf since we very recently untangled them. - DEFAULT_REPLICA_ID is used in many places in ZK. Declared a new contant in HConstants (since it's in hbase-common) and using it in hbase-zookeeper. RegionInfo.DEFAULT_REPLICA_ID too takes its value from it. was: Changes so far: - Moved DrainingServerTracker and RegionServerTracker to hbase-server:o.a.h.h.master. - Move Abortable to hbase-common. Since it's IA.Private and independent of anything, moving it to hbase-common which is at bottom of the dependency tree is better. - Moved RecoveringRegionWatcher to hbase-server:o.a.h.h.regionserver - Moved SplitOrMergeTracker to oahh.master (because it depends on a PB) - Moving hbase-client:oahh.zookeeper.* to hbase-zookeeper module. We want to keep hbase-zookeeper very independent and hence at lowest levels in our dependency tree. - ZKUtil is a huge tangle since it's linked to almost everything in [hbase-client/]oahh.zookeeper. And pulling it down requires some basic proto functions (mergeFrom, PBmagic, etc). So what i did was: **Pulled down common and basic protobuf functions (which only depend on com.google.protobuf.*) to hbase-common so other code depending on them can be pulled down if possible/wanted in future. This will help future dependency untangling too. These are ProtobufMagic and ProtobufHelpers. **Didn't move any hbase-specific PB stuff to hbase-common. We can't pull things into hbase-common which add dependency between it and hbase-protobuf/hbase-shaded-protobuf since we very recently untangled them. - DEFAULT_REPLICA_ID is used in many places in ZK. Declared a new contant in HConstants (since it's in hbase-common) and using it in hbase-zookeeper. RegionInfo.DEFAULT_REPLICA_ID too takes its value from it. > Split out o.a.h.h.zookeeper from hbase-server and hbase-client > -- > > Key: HBASE-19114 > URL: https://issues.apache.org/jira/browse/HBASE-19114 > Project: HBase > Issue Type: Sub-task >Reporter: Appy >Assignee: Appy > Attachments: HBASE-19114.master.001.patch > > > Changes so far: > - Moved DrainingServerTracker and RegionServerTracker to > hbase-server:o.a.h.h.master. > - Move Abortable to hbase-common. Since it's IA.Private and independent of > anything, moving it to hbase-common which is at bottom of the dependency tree > is better. > - Moved RecoveringRegionWatcher to hbase-server:o.a.h.h.regionserver > - Moved SplitOrMergeTracker to oahh.master (because it depends on a PB) > - Moving hbase-client:oahh.zookeeper.* to hbase-zookeeper module. We want to > keep hbase-zookeeper very independent and hence at lowest levels in our > dependency tree. > - ZKUtil is a huge tangle since it's linked to almost everything in > [hbase-client/]oahh.zookeeper. And pulling it down requires some basic proto > functions (mergeFrom, PBmagic, etc). So what i did was: >**Pulled down common and basic protobuf functions (which only depend on > com.google.protobuf.\*) to hbase-common so other code depending on them can > be pulled down if possible/wanted in future. This will help future dependency > untangling too. These are ProtobufMagic and ProtobufHelpers. > **Didn't move any hbase-specific PB stuff to hbase-common. We can't pull > things into hbase-common which add dependency between it and > hbase-protobuf/hbase-shaded-protobuf since we very recently untangled them. > - DEFAULT_REPLICA_ID is used in many
[jira] [Updated] (HBASE-19114) Split out o.a.h.h.zookeeper from hbase-server and hbase-client
[ https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-19114: - Description: Changes so far: - Moved DrainingServerTracker and RegionServerTracker to hbase-server:o.a.h.h.master. - Move Abortable to hbase-common. Since it's IA.Private and independent of anything, moving it to hbase-common which is at bottom of the dependency tree is better. - Moved RecoveringRegionWatcher to hbase-server:o.a.h.h.regionserver - Moved SplitOrMergeTracker to oahh.master (because it depends on a PB) - Moving hbase-client:oahh.zookeeper.* to hbase-zookeeper module. We want to keep hbase-zookeeper very independent and hence at lowest levels in our dependency tree. - ZKUtil is a huge tangle since it's linked to almost everything in [hbase-client/]oahh.zookeeper. And pulling it down requires some basic proto functions (mergeFrom, PBmagic, etc). So what i did was: **Pulled down common and basic protobuf functions (which only depend on com.google.protobuf.*) to hbase-common so other code depending on them can be pulled down if possible/wanted in future. This will help future dependency untangling too. These are ProtobufMagic and ProtobufHelpers. **Didn't move any hbase-specific PB stuff to hbase-common. We can't pull things into hbase-common which add dependency between it and hbase-protobuf/hbase-shaded-protobuf since we very recently untangled them. - DEFAULT_REPLICA_ID is used in many places in ZK. Declared a new contant in HConstants (since it's in hbase-common) and using it in hbase-zookeeper. RegionInfo.DEFAULT_REPLICA_ID too takes its value from it. > Split out o.a.h.h.zookeeper from hbase-server and hbase-client > -- > > Key: HBASE-19114 > URL: https://issues.apache.org/jira/browse/HBASE-19114 > Project: HBase > Issue Type: Sub-task >Reporter: Appy >Assignee: Appy > Attachments: HBASE-19114.master.001.patch > > > Changes so far: > - Moved DrainingServerTracker and RegionServerTracker to > hbase-server:o.a.h.h.master. > - Move Abortable to hbase-common. Since it's IA.Private and independent of > anything, moving it to hbase-common which is at bottom of the dependency tree > is better. > - Moved RecoveringRegionWatcher to hbase-server:o.a.h.h.regionserver > - Moved SplitOrMergeTracker to oahh.master (because it depends on a PB) > - Moving hbase-client:oahh.zookeeper.* to hbase-zookeeper module. We want to > keep hbase-zookeeper very independent and hence at lowest levels in our > dependency tree. > - ZKUtil is a huge tangle since it's linked to almost everything in > [hbase-client/]oahh.zookeeper. And pulling it down requires some basic proto > functions (mergeFrom, PBmagic, etc). So what i did was: >**Pulled down common and basic protobuf functions (which only depend on > com.google.protobuf.*) to hbase-common so other code depending on them can be > pulled down if possible/wanted in future. This will help future dependency > untangling too. These are ProtobufMagic and ProtobufHelpers. > **Didn't move any hbase-specific PB stuff to hbase-common. We can't pull > things into hbase-common which add dependency between it and > hbase-protobuf/hbase-shaded-protobuf since we very recently untangled them. > - DEFAULT_REPLICA_ID is used in many places in ZK. Declared a new contant in > HConstants (since it's in hbase-common) and using it in hbase-zookeeper. > RegionInfo.DEFAULT_REPLICA_ID too takes its value from it. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19114) Split out o.a.h.h.zookeeper from hbase-server and hbase-client
[ https://issues.apache.org/jira/browse/HBASE-19114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-19114: - Attachment: HBASE-19114.master.001.patch > Split out o.a.h.h.zookeeper from hbase-server and hbase-client > -- > > Key: HBASE-19114 > URL: https://issues.apache.org/jira/browse/HBASE-19114 > Project: HBase > Issue Type: Sub-task >Reporter: Appy >Assignee: Appy > Attachments: HBASE-19114.master.001.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19114) Split out o.a.h.h.zookeeper from hbase-server and hbase-client
Appy created HBASE-19114: Summary: Split out o.a.h.h.zookeeper from hbase-server and hbase-client Key: HBASE-19114 URL: https://issues.apache.org/jira/browse/HBASE-19114 Project: HBase Issue Type: Sub-task Reporter: Appy Assignee: Appy -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19111) Add missing CellUtil#isXXX(Cell) methods
[ https://issues.apache.org/jira/browse/HBASE-19111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-19111: --- Status: Patch Available (was: Open) > Add missing CellUtil#isXXX(Cell) methods > > > Key: HBASE-19111 > URL: https://issues.apache.org/jira/browse/HBASE-19111 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Critical > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-19111.001.branch-2.patch > > > Over in HBASE-19002 while trying to write some RegionObservers, I found that > I couldn't find a public-API method to determine if a Cell was for a Put. We > seem to only have API for determining if it's a Delete. > Let's get some methods added to CellUtil for users to consume. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19111) Add missing CellUtil#isXXX(Cell) methods
[
https://issues.apache.org/jira/browse/HBASE-19111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Elser updated HBASE-19111:
---
Attachment: HBASE-19111.001.branch-2.patch
.001 Adds {{CellUtil#isPut(Cell)}}, marks {{Cell#getType()}} and
{{CellUtil#isDelete(byte)}} as deprecated. Trivial test case added too.
> Add missing CellUtil#isXXX(Cell) methods
>
>
> Key: HBASE-19111
> URL: https://issues.apache.org/jira/browse/HBASE-19111
> Project: HBase
> Issue Type: Bug
> Components: Client
>Reporter: Josh Elser
>Assignee: Josh Elser
>Priority: Critical
> Fix For: 2.0.0-beta-1
>
> Attachments: HBASE-19111.001.branch-2.patch
>
>
> Over in HBASE-19002 while trying to write some RegionObservers, I found that
> I couldn't find a public-API method to determine if a Cell was for a Put. We
> seem to only have API for determining if it's a Delete.
> Let's get some methods added to CellUtil for users to consume.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19024) provide a configurable option to hsync WAL edits to the disk for better durability
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223034#comment-16223034
]
Andrew Purtell commented on HBASE-19024:
The reported unit test failures are legit and need to be fixed.
I see this FWIW, with the patch applied. Passes at current HEAD of master.
{noformat}
[ERROR] Tests run: 103, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
58.959 s <<< FAILURE! - in org.apache.hadoop.hbase.regionserver.TestHRegion
[ERROR]
testMemstoreSnapshotSize(org.apache.hadoop.hbase.regionserver.TestHRegion)
Time elapsed: 0.035 s <<< FAILURE!
java.lang.AssertionError: The regionserver should have thrown an exception
at
org.apache.hadoop.hbase.regionserver.TestHRegion.testMemstoreSnapshotSize(TestHRegion.java:352)
{noformat}
> provide a configurable option to hsync WAL edits to the disk for better
> durability
> --
>
> Key: HBASE-19024
> URL: https://issues.apache.org/jira/browse/HBASE-19024
> Project: HBase
> Issue Type: Improvement
> Components: wal
> Environment:
>Reporter: Vikas Vishwakarma
>Assignee: Harshal Jain
> Attachments: master.patch, master.v2.patch
>
>
> At present we do not have an option to hsync WAL edits to the disk for better
> durability. In our local tests we see 10-15% latency impact of using hsync
> instead of hflush which is not very high.
> We should have a configurable option to hysnc WAL edits instead of just
> sync/hflush which will call the corresponding API on the hadoop side.
> Currently HBase handles both SYNC_WAL and FSYNC_WAL as the same calling
> FSDataOutputStream sync/hflush on the hadoop side. This can be modified to
> let FSYNC_WAL call hsync on the hadoop side instead of sync/hflush. We can
> keep the default value to sync as the current behavior and hsync can be
> enabled based on explicit configuration.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19024) provide a configurable option to hsync WAL edits to the disk for better durability
[
https://issues.apache.org/jira/browse/HBASE-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16223001#comment-16223001
]
Andrew Purtell commented on HBASE-19024:
Changes lgtm.
Let me check these failures locally
{noformat}
Failed junit tests hadoop.hbase.regionserver.TestHRegionWithInMemoryFlush
hadoop.hbase.regionserver.TestHRegion
{noformat}
I will also try to bring the changes back to branch-1. If all good will commit.
> provide a configurable option to hsync WAL edits to the disk for better
> durability
> --
>
> Key: HBASE-19024
> URL: https://issues.apache.org/jira/browse/HBASE-19024
> Project: HBase
> Issue Type: Improvement
> Components: wal
> Environment:
>Reporter: Vikas Vishwakarma
>Assignee: Harshal Jain
> Attachments: master.patch, master.v2.patch
>
>
> At present we do not have an option to hsync WAL edits to the disk for better
> durability. In our local tests we see 10-15% latency impact of using hsync
> instead of hflush which is not very high.
> We should have a configurable option to hysnc WAL edits instead of just
> sync/hflush which will call the corresponding API on the hadoop side.
> Currently HBase handles both SYNC_WAL and FSYNC_WAL as the same calling
> FSDataOutputStream sync/hflush on the hadoop side. This can be modified to
> let FSYNC_WAL call hsync on the hadoop side instead of sync/hflush. We can
> keep the default value to sync as the current behavior and hsync can be
> enabled based on explicit configuration.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19099) Evaluate the remaining compatibility concerns between branch-1.3 and branch-1.4 / branch-1
[ https://issues.apache.org/jira/browse/HBASE-19099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222964#comment-16222964 ] Andrew Purtell commented on HBASE-19099: Subtask resolved. Leaving this open until Monday, then will proceed with the 1.4.0 RC0 > Evaluate the remaining compatibility concerns between branch-1.3 and > branch-1.4 / branch-1 > -- > > Key: HBASE-19099 > URL: https://issues.apache.org/jira/browse/HBASE-19099 > Project: HBase > Issue Type: Task >Affects Versions: 1.4.0, 1.5.0 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Blocker > Fix For: 1.4.0, 1.5.0 > > > For discussion, here are the remaining compatibility concerns you will > encounter upon moving up from 1.3 to 1.4: > The below all relate to source level compatibility. Recompilation of a client > program may be terminated with the message "class C is not abstract and does > not override abstract method M in TYPE". According to our compatibility > guidelines we are allowed to add methods to interfaces, so these are ALLOWED. > Please let me know if you disagree. > package org.apache.hadoop.hbase.client > interface Admin > * Abstract method clearDeadServers ( List ) has been added to > this interface. > * Abstract method cloneSnapshot ( String, TableName, boolean ) has been added > to this interface. > * Abstract method isCleanerChoreEnabled ( ) has been added to this interface. > * Abstract method isMasterInMaintenanceMode ( ) has been added to this > interface. > * Abstract method listDeadServers ( ) has been added to this interface. > * Abstract method restoreSnapshot ( String, boolean, boolean ) has been added > to this interface. > * Abstract method runCleanerChore ( ) has been added to this interface. > * Abstract method setCleanerChoreRunning ( boolean ) has been added to this > interface. > package org.apache.hadoop.hbase.client > interface ResultScanner > * Abstract method renewLease ( ) has been added to this interface. > * Abstract method getScanMetrics ( ) has been added to this interface. > package org.apache.hadoop.hbase.client > interface Table > * Abstract method getReadRpcTimeout ( ) has been added to this interface. > * Abstract method getWriteRpcTimeout ( ) has been added to this interface. > * Abstract method setReadRpcTimeout ( int ) has been added to this interface. > * Abstract method setWriteRpcTimeout ( int ) has been added to this interface. > package org.apache.hadoop.hbase.replication > interface ReplicationPeer > * Abstract method getPeerBandwidth ( ) has been added to this interface. > * Abstract method trackPeerConfigChanges ( ReplicationPeerConfigListener ) > has been added to this interface. > package org.apache.hadoop.hbase.coprocessor > interface MasterCoprocessorEnvironment > * Abstract method getMetricRegistryForMaster ( ) has been added to this > interface. > package org.apache.hadoop.hbase.coprocessor > interface MasterObserver > * Abstract method postAddRSGroup ( > ObserverContext, String ) has been added to > this interface. > * Abstract method postBalanceRSGroup ( > ObserverContext, String, boolean ) has been > added to this interface. > * Abstract method postClearDeadServers ( > ObserverContext ) has been added to this > interface. > * Abstract method postListDeadServers ( > ObserverContext ) has been added to this > interface. > * Abstract method postMoveServers ( > ObserverContext, Set, String ) has > been added to this interface. > * Abstract method postMoveServersAndTables ( > ObserverContext, Set, Set, > String ) has been added to this interface. > * Abstract method postMoveTables ( > ObserverContext, Set, String ) has > been added to this interface. > * Abstract method postRemoveRSGroup ( > ObserverContext, String ) has been added to > this interface. > * Abstract method preAddRSGroup ( > ObserverContext, String ) has been added to > this interface. > * Abstract method preBalanceRSGroup ( > ObserverContext, String ) has been added to > this interface. > * Abstract method preClearDeadServers ( > ObserverContext ) has been added to this > interface. > * Abstract method preListDeadServers ( > ObserverContext ) has been added to this > interface. > * Abstract method preMoveServers ( > ObserverContext, Set, String ) has > been added to this interface. > * Abstract method preMoveServersAndTables ( > ObserverContext, Set, Set, > String ) has been added to this interface. > * Abstract method preMoveTables ( > ObserverContext, Set, String ) has > been added to this interface. > * Abstract method preRemoveRSGroup ( > ObserverContext, String ) has been added to > this interface. > package org.apache.hadoop.hbase.coprocessor > interface
[jira] [Updated] (HBASE-19113) Restore dropped constants from TableInputFormatBase for compatibility
[ https://issues.apache.org/jira/browse/HBASE-19113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-19113: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Pushed to branch-1.4 and branch-1 > Restore dropped constants from TableInputFormatBase for compatibility > - > > Key: HBASE-19113 > URL: https://issues.apache.org/jira/browse/HBASE-19113 > Project: HBase > Issue Type: Sub-task > Components: mapreduce >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0, 1.5.0 > > Attachments: HBASE-19113-branch-1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19110) Add default for Server#isStopping
[ https://issues.apache.org/jira/browse/HBASE-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-19110: Priority: Minor (was: Major) > Add default for Server#isStopping > - > > Key: HBASE-19110 > URL: https://issues.apache.org/jira/browse/HBASE-19110 > Project: HBase > Issue Type: Improvement >Reporter: stack >Assignee: stack >Priority: Minor > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19110.master.001.patch > > > Over in HBASE-19007 "Align Services Interfaces in Master and RegionServer", > we moved the isStopping method back into Server. In a late review, [~appy] > suggested that I should have had the Interface provide a default. This issue > is about doing as [~appy] suggested. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19110) Add default for Server#isStopping
[ https://issues.apache.org/jira/browse/HBASE-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-19110: Issue Type: Improvement (was: Bug) > Add default for Server#isStopping > - > > Key: HBASE-19110 > URL: https://issues.apache.org/jira/browse/HBASE-19110 > Project: HBase > Issue Type: Improvement >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19110.master.001.patch > > > Over in HBASE-19007 "Align Services Interfaces in Master and RegionServer", > we moved the isStopping method back into Server. In a late review, [~appy] > suggested that I should have had the Interface provide a default. This issue > is about doing as [~appy] suggested. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19110) Add default for Server#isStopping
[
https://issues.apache.org/jira/browse/HBASE-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222920#comment-16222920
]
Sean Busbey commented on HBASE-19110:
-
sorry for the late note, what about adding a default for the similarly added
{{public FileSystem getFileSystem()}} that returns {{null}}. would mean a bit
of test code can come out.
> Add default for Server#isStopping
> -
>
> Key: HBASE-19110
> URL: https://issues.apache.org/jira/browse/HBASE-19110
> Project: HBase
> Issue Type: Bug
>Reporter: stack
>Assignee: stack
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-19110.master.001.patch
>
>
> Over in HBASE-19007 "Align Services Interfaces in Master and RegionServer",
> we moved the isStopping method back into Server. In a late review, [~appy]
> suggested that I should have had the Interface provide a default. This issue
> is about doing as [~appy] suggested.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-18770) Remove bypass method in ObserverContext and implement the 'bypass' logic case by case
[ https://issues.apache.org/jira/browse/HBASE-18770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222919#comment-16222919 ] stack commented on HBASE-18770: --- I went back to have another look. The current operation execution engine works with methods. The method signature can be anything. Method can optionally return results. This precludes my being able to use return signaling bypass. Given no other channel and not wanting to do hackery like last-param-if-it-is-type-X-is-the-control object, I opted to hold to the existing meta-channel facility, bypass in ObserverContext. That said, on this reexamination, I see that I can simplify more and give strong signal where bypass is not supported. Thanks. Todo in here is fix unit tests, write unit tests to prove we have bypass for all the CPs that were mentioned in the dev discussion, ensure that on bypass, metrics are updated regardless (so we can get away with not exposing metrics to Coprocessors), and finally, open up a few more methods. I'll be back soon. > Remove bypass method in ObserverContext and implement the 'bypass' logic case > by case > - > > Key: HBASE-18770 > URL: https://issues.apache.org/jira/browse/HBASE-18770 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang >Assignee: stack >Priority: Critical > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-18770.master.001.patch, > HBASE-18770.master.002.patch > > > http://search-hadoop.com/m/HBase/YGbbXd0RDCIHSC1 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19099) Evaluate the remaining compatibility concerns between branch-1.3 and branch-1.4 / branch-1
[ https://issues.apache.org/jira/browse/HBASE-19099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222911#comment-16222911 ] Sean Busbey commented on HBASE-19099: - bq. Ok - so, restore the TableInputFormatBase constants. Will put up a patch. Anything else? I'm fine with the rest that showed up. > Evaluate the remaining compatibility concerns between branch-1.3 and > branch-1.4 / branch-1 > -- > > Key: HBASE-19099 > URL: https://issues.apache.org/jira/browse/HBASE-19099 > Project: HBase > Issue Type: Task >Affects Versions: 1.4.0, 1.5.0 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Blocker > Fix For: 1.4.0, 1.5.0 > > > For discussion, here are the remaining compatibility concerns you will > encounter upon moving up from 1.3 to 1.4: > The below all relate to source level compatibility. Recompilation of a client > program may be terminated with the message "class C is not abstract and does > not override abstract method M in TYPE". According to our compatibility > guidelines we are allowed to add methods to interfaces, so these are ALLOWED. > Please let me know if you disagree. > package org.apache.hadoop.hbase.client > interface Admin > * Abstract method clearDeadServers ( List ) has been added to > this interface. > * Abstract method cloneSnapshot ( String, TableName, boolean ) has been added > to this interface. > * Abstract method isCleanerChoreEnabled ( ) has been added to this interface. > * Abstract method isMasterInMaintenanceMode ( ) has been added to this > interface. > * Abstract method listDeadServers ( ) has been added to this interface. > * Abstract method restoreSnapshot ( String, boolean, boolean ) has been added > to this interface. > * Abstract method runCleanerChore ( ) has been added to this interface. > * Abstract method setCleanerChoreRunning ( boolean ) has been added to this > interface. > package org.apache.hadoop.hbase.client > interface ResultScanner > * Abstract method renewLease ( ) has been added to this interface. > * Abstract method getScanMetrics ( ) has been added to this interface. > package org.apache.hadoop.hbase.client > interface Table > * Abstract method getReadRpcTimeout ( ) has been added to this interface. > * Abstract method getWriteRpcTimeout ( ) has been added to this interface. > * Abstract method setReadRpcTimeout ( int ) has been added to this interface. > * Abstract method setWriteRpcTimeout ( int ) has been added to this interface. > package org.apache.hadoop.hbase.replication > interface ReplicationPeer > * Abstract method getPeerBandwidth ( ) has been added to this interface. > * Abstract method trackPeerConfigChanges ( ReplicationPeerConfigListener ) > has been added to this interface. > package org.apache.hadoop.hbase.coprocessor > interface MasterCoprocessorEnvironment > * Abstract method getMetricRegistryForMaster ( ) has been added to this > interface. > package org.apache.hadoop.hbase.coprocessor > interface MasterObserver > * Abstract method postAddRSGroup ( > ObserverContext, String ) has been added to > this interface. > * Abstract method postBalanceRSGroup ( > ObserverContext, String, boolean ) has been > added to this interface. > * Abstract method postClearDeadServers ( > ObserverContext ) has been added to this > interface. > * Abstract method postListDeadServers ( > ObserverContext ) has been added to this > interface. > * Abstract method postMoveServers ( > ObserverContext, Set, String ) has > been added to this interface. > * Abstract method postMoveServersAndTables ( > ObserverContext, Set, Set, > String ) has been added to this interface. > * Abstract method postMoveTables ( > ObserverContext, Set, String ) has > been added to this interface. > * Abstract method postRemoveRSGroup ( > ObserverContext, String ) has been added to > this interface. > * Abstract method preAddRSGroup ( > ObserverContext, String ) has been added to > this interface. > * Abstract method preBalanceRSGroup ( > ObserverContext, String ) has been added to > this interface. > * Abstract method preClearDeadServers ( > ObserverContext ) has been added to this > interface. > * Abstract method preListDeadServers ( > ObserverContext ) has been added to this > interface. > * Abstract method preMoveServers ( > ObserverContext, Set, String ) has > been added to this interface. > * Abstract method preMoveServersAndTables ( > ObserverContext, Set, Set, > String ) has been added to this interface. > * Abstract method preMoveTables ( > ObserverContext, Set, String ) has > been added to this interface. > * Abstract method preRemoveRSGroup ( > ObserverContext, String ) has been added to > this interface. > package
[jira] [Commented] (HBASE-18624) Added support for clearing BlockCache based on table name
[ https://issues.apache.org/jira/browse/HBASE-18624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222892#comment-16222892 ] Zach York commented on HBASE-18624: --- [~chia7712] [~tedyu] I tried to fix the ruby warnings where it made sense and added the ASF License, but I don't see any log for the shaded jars errors. Could you point me to where that would be? > Added support for clearing BlockCache based on table name > - > > Key: HBASE-18624 > URL: https://issues.apache.org/jira/browse/HBASE-18624 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0, 1.3.0 >Reporter: Ajay Jadhav >Assignee: Zach York > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-18624.branch-1.001.patch, > HBASE-18624.master.001.patch, HBASE-18624.master.002.patch, > HBASE-18624.master.003.patch, HBASE-18624.master.004.patch, > HBASE-18624.master.005.patch, HBASE-18624.master.006.patch, > HBASE-18624.master.007.patch > > > Bulk loading the primary HBase cluster triggers a lot of compactions > resulting in archival/ creation > of multiple HFiles. This process will cause a lot of items to become stale in > replica’s BlockCache. > This patch will help users to clear the block cache for a given table by > either using shell or API. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18624) Added support for clearing BlockCache based on table name
[ https://issues.apache.org/jira/browse/HBASE-18624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-18624: -- Status: In Progress (was: Patch Available) > Added support for clearing BlockCache based on table name > - > > Key: HBASE-18624 > URL: https://issues.apache.org/jira/browse/HBASE-18624 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.3.0, 2.0.0 >Reporter: Ajay Jadhav >Assignee: Zach York > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-18624.branch-1.001.patch, > HBASE-18624.master.001.patch, HBASE-18624.master.002.patch, > HBASE-18624.master.003.patch, HBASE-18624.master.004.patch, > HBASE-18624.master.005.patch, HBASE-18624.master.006.patch, > HBASE-18624.master.007.patch > > > Bulk loading the primary HBase cluster triggers a lot of compactions > resulting in archival/ creation > of multiple HFiles. This process will cause a lot of items to become stale in > replica’s BlockCache. > This patch will help users to clear the block cache for a given table by > either using shell or API. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18624) Added support for clearing BlockCache based on table name
[ https://issues.apache.org/jira/browse/HBASE-18624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-18624: -- Attachment: HBASE-18624.master.007.patch > Added support for clearing BlockCache based on table name > - > > Key: HBASE-18624 > URL: https://issues.apache.org/jira/browse/HBASE-18624 > Project: HBase > Issue Type: Sub-task >Affects Versions: 2.0.0, 1.3.0 >Reporter: Ajay Jadhav >Assignee: Zach York > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-18624.branch-1.001.patch, > HBASE-18624.master.001.patch, HBASE-18624.master.002.patch, > HBASE-18624.master.003.patch, HBASE-18624.master.004.patch, > HBASE-18624.master.005.patch, HBASE-18624.master.006.patch, > HBASE-18624.master.007.patch > > > Bulk loading the primary HBase cluster triggers a lot of compactions > resulting in archival/ creation > of multiple HFiles. This process will cause a lot of items to become stale in > replica’s BlockCache. > This patch will help users to clear the block cache for a given table by > either using shell or API. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18624) Added support for clearing BlockCache based on table name
[ https://issues.apache.org/jira/browse/HBASE-18624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zach York updated HBASE-18624: -- Status: Patch Available (was: In Progress) > Added support for clearing BlockCache based on table name > - > > Key: HBASE-18624 > URL: https://issues.apache.org/jira/browse/HBASE-18624 > Project: HBase > Issue Type: Sub-task >Affects Versions: 1.3.0, 2.0.0 >Reporter: Ajay Jadhav >Assignee: Zach York > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-18624.branch-1.001.patch, > HBASE-18624.master.001.patch, HBASE-18624.master.002.patch, > HBASE-18624.master.003.patch, HBASE-18624.master.004.patch, > HBASE-18624.master.005.patch, HBASE-18624.master.006.patch, > HBASE-18624.master.007.patch > > > Bulk loading the primary HBase cluster triggers a lot of compactions > resulting in archival/ creation > of multiple HFiles. This process will cause a lot of items to become stale in > replica’s BlockCache. > This patch will help users to clear the block cache for a given table by > either using shell or API. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19113) Restore dropped constants from TableInputFormatBase for compatibility
[ https://issues.apache.org/jira/browse/HBASE-19113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-19113: Component/s: mapreduce > Restore dropped constants from TableInputFormatBase for compatibility > - > > Key: HBASE-19113 > URL: https://issues.apache.org/jira/browse/HBASE-19113 > Project: HBase > Issue Type: Sub-task > Components: mapreduce >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0, 1.5.0 > > Attachments: HBASE-19113-branch-1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19113) Restore dropped constants from TableInputFormatBase for compatibility
[ https://issues.apache.org/jira/browse/HBASE-19113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222886#comment-16222886 ] Sean Busbey commented on HBASE-19113: - +1 Thanks for doing this, sorry I didn't get to it first. > Restore dropped constants from TableInputFormatBase for compatibility > - > > Key: HBASE-19113 > URL: https://issues.apache.org/jira/browse/HBASE-19113 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0, 1.5.0 > > Attachments: HBASE-19113-branch-1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19095) Add CP hooks in RegionObserver for in memory compaction
[ https://issues.apache.org/jira/browse/HBASE-19095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222881#comment-16222881 ] Josh Elser commented on HBASE-19095: bq. we could punt on this till beta-1 We're adding net-new CP APIs for a net-new feature, right? I'd say if [~Apache9] doesn't have a patch ready to go, we take this up in beta-1... > Add CP hooks in RegionObserver for in memory compaction > --- > > Key: HBASE-19095 > URL: https://issues.apache.org/jira/browse/HBASE-19095 > Project: HBase > Issue Type: Sub-task > Components: Coprocessors >Reporter: Duo Zhang > Fix For: 2.0.0-alpha-4 > > > This is a hole in our CP hooks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18438) Precommit doesn't warn about unused imports
[ https://issues.apache.org/jira/browse/HBASE-18438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18438: --- Attachment: HBASE-18438.v2.patch retry v2 > Precommit doesn't warn about unused imports > --- > > Key: HBASE-18438 > URL: https://issues.apache.org/jira/browse/HBASE-18438 > Project: HBase > Issue Type: Bug > Components: build >Reporter: Mike Drob >Assignee: Chia-Ping Tsai >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-18438.patch, HBASE-18438.v2.patch, > HBASE-18438.v2.patch > > > On HBASE-18419 I accidentally included an unused import in my patch, but > precommit didn't flag it. Use this issue to diagnose and fix. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Work stopped] (HBASE-18438) Precommit doesn't warn about unused imports
[ https://issues.apache.org/jira/browse/HBASE-18438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-18438 stopped by Chia-Ping Tsai. -- > Precommit doesn't warn about unused imports > --- > > Key: HBASE-18438 > URL: https://issues.apache.org/jira/browse/HBASE-18438 > Project: HBase > Issue Type: Bug > Components: build >Reporter: Mike Drob >Assignee: Chia-Ping Tsai >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-18438.patch, HBASE-18438.v2.patch, > HBASE-18438.v2.patch > > > On HBASE-18419 I accidentally included an unused import in my patch, but > precommit didn't flag it. Use this issue to diagnose and fix. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18438) Precommit doesn't warn about unused imports
[ https://issues.apache.org/jira/browse/HBASE-18438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-18438: --- Status: Patch Available (was: Open) > Precommit doesn't warn about unused imports > --- > > Key: HBASE-18438 > URL: https://issues.apache.org/jira/browse/HBASE-18438 > Project: HBase > Issue Type: Bug > Components: build >Reporter: Mike Drob >Assignee: Chia-Ping Tsai >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-18438.patch, HBASE-18438.v2.patch, > HBASE-18438.v2.patch > > > On HBASE-18419 I accidentally included an unused import in my patch, but > precommit didn't flag it. Use this issue to diagnose and fix. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18396) Encode ZNode names to reduce ZooKeeper jute buffer length requirements and thus reduce memory usage
[
https://issues.apache.org/jira/browse/HBASE-18396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222848#comment-16222848
]
Andrew Purtell commented on HBASE-18396:
FWIW we have a replication backup and related issues currently producing
actually observed jute messages of ~26MB. Encoding can help relieve pressure
until we fix the underlying cause. HBase shouldn't manage replication state in
ZooKeeper, full stop. We have other JIRAs in place proposing a migration to
HBase hosted system tables. While doing that we can work on keeping queue state
tracking scalable as number of queues and WALs increase. I think that's the
long term direction. In the interim maybe we can consider half measures like
this as pain relief.
> Encode ZNode names to reduce ZooKeeper jute buffer length requirements and
> thus reduce memory usage
> ---
>
> Key: HBASE-18396
> URL: https://issues.apache.org/jira/browse/HBASE-18396
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Karan Mehta
>
> In our production environment, we hit the error {{ZooKeeper connectionLoss
> due to jute.maxbuffer len of 1M getting exceeded}}. Usually 1 MB is a lot,
> but in case of multi requests, it can exceed the maximum buffer length that
> is allocated.
> This JIRA is a discussion for encoding various znode names. IMO, this will
> reduce the path lengths, thus reducing the size of buffer required as well as
> network packet size and also pack more requests in a single multi. As with
> encoding, this will introduce overhead, but we need to determine how feasible
> this idea is.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x
[ https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222845#comment-16222845 ] stack edited comment on HBASE-19052 at 10/27/17 9:20 PM: - I love the rationale that has it that because there is no test in issue A, issue B doesn't need one and that migration being neither branch-1 nor branch-2, but in-between, is somehow untestable. Thanks lads for the reminder on this one. I did not have this in my incompat section in the hbase2 doc. Added it. I also started up an upgrade/migration doc. on requirements and how to migrate: https://docs.google.com/document/d/1sL92WaCcYyBTruTf6PMCHaDiWJV2hbObZIbS_JH_x60/edit#heading=h.m2ilt6k4zqn5 Regards the larger issue of requiring our users double-upgrade I see [~anoop.hbase] asked over in HBASE-16189 the below: bq. This issue came up again in the dev@ discussion thread. We fixed this in later versions of 1.x means when rolling upgrade done to 2.0, first users have to upgrade to some 1.x versions which is having this fix and then to 2.0.. What do you guys think Whether we should avoid this kind of indirection? cc Enis Soztutar, Stack, Ted Yu, Matteo Bertozzi and he got no answer. Expecting users to double-upgrade -- first to latest branch-1 and then to branch-2 -- and then go through a double-rolling restart to upgrade is going to piss off our operators. Is trailer the only reason we require folks go to the latest in branch-1 (seems weird trying to teach hbase1 about hbase2... where do we stop doing this)? If this the only reason to go to the latest on branch-1, can we figure a means of doing w/o? Changing the trailer such that it has arguments that parsers no longer understand screams for our updating the version on the hfile. But new version because of change in comparator name doesn't seem substantial enough of a reason to up our hfile number, not without distinct benefit. Can we go Poste [1]l here... If we wrote the old name into the hfile, could new hfile readers in hbase2 map the old String to the new classes? Thanks. 1. https://en.wikipedia.org/wiki/Robustness_principle was (Author: stack): I love the rationale that has it that because there is no test in issue A, issue B doesn't need one and that migration being neither branch-1 nor branch-2, but in-between, is somehow untestable. Thanks lads for the reminder on this one. I did not have this in my incompat section in the hbase2 doc. Added it. I also started up an upgrade/migration doc. on requirements and how to migrate: https://docs.google.com/document/d/1sL92WaCcYyBTruTf6PMCHaDiWJV2hbObZIbS_JH_x60/edit#heading=h.m2ilt6k4zqn5 Regards the larger issue of requiring our users double-upgrade I see [~anoop.hbase] asked over in HBASE-16189 the below: bq. This issue came up again in the dev@ discussion thread. We fixed this in later versions of 1.x means when rolling upgrade done to 2.0, first users have to upgrade to some 1.x versions which is having this fix and then to 2.0.. What do you guys think Whether we should avoid this kind of indirection? cc Enis Soztutar, Stack, Ted Yu, Matteo Bertozzi and he got no answer. Expecting users to double-upgrade -- first to latest branch-1 and then to branch-2 -- and then go through a double-rolling restart to upgrade is going to piss off our operators. Is trailer the only reason we require folks go to the latest in branch-1 (seems weird trying to teach hbase1 about hbase2... where do we stop doing this)? If this the only reason to go to the latest on branch-1, can we figure a means of doing w/o? Changing the trailer such that it has arguments that parsers no longer understand screams for our updating the version on the hfile. But new version because of change in comparator name doesn't seem substantial enough of a reason to up our hfile number, not without distinct benefit. If we wrote the old name into the hfile, could new hfile readers in hbase2 map the old String to the new classes? Thanks. > FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x > > > Key: HBASE-19052 > URL: https://issues.apache.org/jira/browse/HBASE-19052 > Project: HBase > Issue Type: Improvement > Components: HFile >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Critical > Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 1.1.13 > > Attachments: 19052.branch-1.txt > > > HBASE-18945 has gone into branch-2 . > Let's consider rolling upgrade scenario from 1.x to 2.0 where there're three > servers: s1, s2, s3 > s1 is upgraded to 2.0 first. It flushes to hfile in region r1 with > CellComparatorImpl written in the hfile trailer. > Somehow s1 crashes and master assigns r1 to s2 which is still
[jira] [Commented] (HBASE-19052) FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x
[
https://issues.apache.org/jira/browse/HBASE-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222845#comment-16222845
]
stack commented on HBASE-19052:
---
I love the rationale that has it that because there is no test in issue A,
issue B doesn't need one and that migration being neither branch-1 nor
branch-2, but in-between, is somehow untestable.
Thanks lads for the reminder on this one. I did not have this in my incompat
section in the hbase2 doc. Added it. I also started up an upgrade/migration
doc. on requirements and how to migrate:
https://docs.google.com/document/d/1sL92WaCcYyBTruTf6PMCHaDiWJV2hbObZIbS_JH_x60/edit#heading=h.m2ilt6k4zqn5
Regards the larger issue of requiring our users double-upgrade I see
[~anoop.hbase] asked over in HBASE-16189 the below:
bq. This issue came up again in the dev@ discussion thread. We fixed this in
later versions of 1.x means when rolling upgrade done to 2.0, first users have
to upgrade to some 1.x versions which is having this fix and then to 2.0.. What
do you guys think Whether we should avoid this kind of indirection? cc Enis
Soztutar, Stack, Ted Yu, Matteo Bertozzi
and he got no answer.
Expecting users to double-upgrade -- first to latest branch-1 and then to
branch-2 -- and then go through a double-rolling restart to upgrade is going to
piss off our operators.
Is trailer the only reason we require folks go to the latest in branch-1 (seems
weird trying to teach hbase1 about hbase2... where do we stop doing this)? If
this the only reason to go to the latest on branch-1, can we figure a means of
doing w/o?
Changing the trailer such that it has arguments that parsers no longer
understand screams for our updating the version on the hfile. But new version
because of change in comparator name doesn't seem substantial enough of a
reason to up our hfile number, not without distinct benefit.
If we wrote the old name into the hfile, could new hfile readers in hbase2 map
the old String to the new classes?
Thanks.
> FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x
>
>
> Key: HBASE-19052
> URL: https://issues.apache.org/jira/browse/HBASE-19052
> Project: HBase
> Issue Type: Improvement
> Components: HFile
>Reporter: Ted Yu
>Assignee: Ted Yu
>Priority: Critical
> Fix For: 1.4.0, 1.3.2, 1.5.0, 1.2.7, 1.1.13
>
> Attachments: 19052.branch-1.txt
>
>
> HBASE-18945 has gone into branch-2 .
> Let's consider rolling upgrade scenario from 1.x to 2.0 where there're three
> servers: s1, s2, s3
> s1 is upgraded to 2.0 first. It flushes to hfile in region r1 with
> CellComparatorImpl written in the hfile trailer.
> Somehow s1 crashes and master assigns r1 to s2 which is still running 1.x
> The following code in FixedFileTrailer would be triggered:
> {code}
> try {
> comparatorKlass = (Class)
> Class.forName(comparatorClassName);
> } catch (ClassNotFoundException e) {
> throw new IOException(e);
> }
> {code}
> since s2 is not aware of CellComparatorImpl.
> This issue is to backport CellComparatorImpl related change to branch-1.x
> Note: CellComparatorImpl wouldn't be used in write path, only in read path.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19099) Evaluate the remaining compatibility concerns between branch-1.3 and branch-1.4 / branch-1
[ https://issues.apache.org/jira/browse/HBASE-19099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222836#comment-16222836 ] Andrew Purtell commented on HBASE-19099: bq. restore the TableInputFormatBase constants. Will put up a patch. See subtask HBASE-19113 > Evaluate the remaining compatibility concerns between branch-1.3 and > branch-1.4 / branch-1 > -- > > Key: HBASE-19099 > URL: https://issues.apache.org/jira/browse/HBASE-19099 > Project: HBase > Issue Type: Task >Affects Versions: 1.4.0, 1.5.0 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Blocker > Fix For: 1.4.0, 1.5.0 > > > For discussion, here are the remaining compatibility concerns you will > encounter upon moving up from 1.3 to 1.4: > The below all relate to source level compatibility. Recompilation of a client > program may be terminated with the message "class C is not abstract and does > not override abstract method M in TYPE". According to our compatibility > guidelines we are allowed to add methods to interfaces, so these are ALLOWED. > Please let me know if you disagree. > package org.apache.hadoop.hbase.client > interface Admin > * Abstract method clearDeadServers ( List ) has been added to > this interface. > * Abstract method cloneSnapshot ( String, TableName, boolean ) has been added > to this interface. > * Abstract method isCleanerChoreEnabled ( ) has been added to this interface. > * Abstract method isMasterInMaintenanceMode ( ) has been added to this > interface. > * Abstract method listDeadServers ( ) has been added to this interface. > * Abstract method restoreSnapshot ( String, boolean, boolean ) has been added > to this interface. > * Abstract method runCleanerChore ( ) has been added to this interface. > * Abstract method setCleanerChoreRunning ( boolean ) has been added to this > interface. > package org.apache.hadoop.hbase.client > interface ResultScanner > * Abstract method renewLease ( ) has been added to this interface. > * Abstract method getScanMetrics ( ) has been added to this interface. > package org.apache.hadoop.hbase.client > interface Table > * Abstract method getReadRpcTimeout ( ) has been added to this interface. > * Abstract method getWriteRpcTimeout ( ) has been added to this interface. > * Abstract method setReadRpcTimeout ( int ) has been added to this interface. > * Abstract method setWriteRpcTimeout ( int ) has been added to this interface. > package org.apache.hadoop.hbase.replication > interface ReplicationPeer > * Abstract method getPeerBandwidth ( ) has been added to this interface. > * Abstract method trackPeerConfigChanges ( ReplicationPeerConfigListener ) > has been added to this interface. > package org.apache.hadoop.hbase.coprocessor > interface MasterCoprocessorEnvironment > * Abstract method getMetricRegistryForMaster ( ) has been added to this > interface. > package org.apache.hadoop.hbase.coprocessor > interface MasterObserver > * Abstract method postAddRSGroup ( > ObserverContext, String ) has been added to > this interface. > * Abstract method postBalanceRSGroup ( > ObserverContext, String, boolean ) has been > added to this interface. > * Abstract method postClearDeadServers ( > ObserverContext ) has been added to this > interface. > * Abstract method postListDeadServers ( > ObserverContext ) has been added to this > interface. > * Abstract method postMoveServers ( > ObserverContext, Set, String ) has > been added to this interface. > * Abstract method postMoveServersAndTables ( > ObserverContext, Set, Set, > String ) has been added to this interface. > * Abstract method postMoveTables ( > ObserverContext, Set, String ) has > been added to this interface. > * Abstract method postRemoveRSGroup ( > ObserverContext, String ) has been added to > this interface. > * Abstract method preAddRSGroup ( > ObserverContext, String ) has been added to > this interface. > * Abstract method preBalanceRSGroup ( > ObserverContext, String ) has been added to > this interface. > * Abstract method preClearDeadServers ( > ObserverContext ) has been added to this > interface. > * Abstract method preListDeadServers ( > ObserverContext ) has been added to this > interface. > * Abstract method preMoveServers ( > ObserverContext, Set, String ) has > been added to this interface. > * Abstract method preMoveServersAndTables ( > ObserverContext, Set, Set, > String ) has been added to this interface. > * Abstract method preMoveTables ( > ObserverContext, Set, String ) has > been added to this interface. > * Abstract method preRemoveRSGroup ( > ObserverContext, String ) has been added to > this interface. > package org.apache.hadoop.hbase.coprocessor > interface
[jira] [Updated] (HBASE-19113) Restore dropped constants from TableInputFormatBase for compatibility
[ https://issues.apache.org/jira/browse/HBASE-19113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-19113: --- Summary: Restore dropped constants from TableInputFormatBase for compatibility (was: Restore dropped constants from TableInputFormatBase for compatability) > Restore dropped constants from TableInputFormatBase for compatibility > - > > Key: HBASE-19113 > URL: https://issues.apache.org/jira/browse/HBASE-19113 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0, 1.5.0 > > Attachments: HBASE-19113-branch-1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18925) Need updated mockito for using java optional
[ https://issues.apache.org/jira/browse/HBASE-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-18925: - Attachment: HBASE-18925.master.006.patch > Need updated mockito for using java optional > > > Key: HBASE-18925 > URL: https://issues.apache.org/jira/browse/HBASE-18925 > Project: HBase > Issue Type: Improvement >Reporter: Appy >Assignee: Appy > Fix For: 2.0.0-beta-1 > > Attachments: HBASE-18925.master.001.patch, > HBASE-18925.master.002.patch, HBASE-18925.master.002.patch, > HBASE-18925.master.003.patch, HBASE-18925.master.004.patch, > HBASE-18925.master.005.patch, HBASE-18925.master.006.patch > > > Came up when i was trying to test HBASE-18878. > It kept failing because mock of RpcCall returned null where return type was > Optional. > Instead, we want it to return Optional.empty(). > New mockito versions support this (and other java8 things) - > https://github.com/mockito/mockito/wiki/What%27s-new-in-Mockito-2 > We use mockito-all which was last released in Dec2014. However, mockito-core > has had more than 50 releases after that > (https://mvnrepository.com/artifact/org.mockito/mockito-core). > We need to change our deps from mockito-all to mockito-core. > However that comes with fair breakages, so this is not a simple task of > changing pom files. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19113) Restore dropped constants from TableInputFormatBase for compatability
[ https://issues.apache.org/jira/browse/HBASE-19113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-19113: --- Attachment: HBASE-19113-branch-1.patch > Restore dropped constants from TableInputFormatBase for compatability > - > > Key: HBASE-19113 > URL: https://issues.apache.org/jira/browse/HBASE-19113 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0, 1.5.0 > > Attachments: HBASE-19113-branch-1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-18962) Support atomic BatchOperations through batchMutate()
[ https://issues.apache.org/jira/browse/HBASE-18962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Umesh Agashe updated HBASE-18962: - Attachment: hbase-18962.master.001.patch > Support atomic BatchOperations through batchMutate() > > > Key: HBASE-18962 > URL: https://issues.apache.org/jira/browse/HBASE-18962 > Project: HBase > Issue Type: Sub-task > Components: regionserver >Affects Versions: 2.0.0-alpha-3 >Reporter: Umesh Agashe >Assignee: Umesh Agashe > Fix For: 2.0.0-beta-1 > > Attachments: hbase-18962.master.001.patch > > > Support all mutations in BatchOperations to be applied atomically (all or > none) by locking all rows corresponding to mutations exclusively. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19113) Restore dropped constants from TableInputFormatBase for compatability
[ https://issues.apache.org/jira/browse/HBASE-19113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-19113: --- Status: Patch Available (was: Open) > Restore dropped constants from TableInputFormatBase for compatability > - > > Key: HBASE-19113 > URL: https://issues.apache.org/jira/browse/HBASE-19113 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0, 1.5.0 > > Attachments: HBASE-19113-branch-1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19113) Restore dropped constants from TableInputFormatBase for compatability
Andrew Purtell created HBASE-19113: -- Summary: Restore dropped constants from TableInputFormatBase for compatability Key: HBASE-19113 URL: https://issues.apache.org/jira/browse/HBASE-19113 Project: HBase Issue Type: Sub-task Reporter: Andrew Purtell Assignee: Andrew Purtell Fix For: 1.4.0, 1.5.0 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-19113) Restore dropped constants from TableInputFormatBase for compatability
[ https://issues.apache.org/jira/browse/HBASE-19113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222831#comment-16222831 ] Andrew Purtell commented on HBASE-19113: [~busbey] > Restore dropped constants from TableInputFormatBase for compatability > - > > Key: HBASE-19113 > URL: https://issues.apache.org/jira/browse/HBASE-19113 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Andrew Purtell > Fix For: 1.4.0, 1.5.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-16189) [Rolling Upgrade] 2.0 hfiles cannot be opened by 1.x servers
[
https://issues.apache.org/jira/browse/HBASE-16189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222826#comment-16222826
]
stack commented on HBASE-16189:
---
This issue is not enough. You'll need HBASE-19052 tooo
> [Rolling Upgrade] 2.0 hfiles cannot be opened by 1.x servers
>
>
> Key: HBASE-16189
> URL: https://issues.apache.org/jira/browse/HBASE-16189
> Project: HBase
> Issue Type: Sub-task
> Components: migration
>Reporter: Enis Soztutar
>Assignee: ramkrishna.s.vasudevan
>Priority: Critical
> Fix For: 1.3.0, 1.4.0, 1.1.6, 1.2.3
>
> Attachments: HBASE-16189.branch-1.patch, HBASE-16189.patch,
> HBASE-16189_branch-1.patch
>
>
> HBASE-10800 added MetaCellComparator, which gets written to the HFile. 1.x
> code does not have the new class, hence fails to open the regions. I did not
> check whether this is only for meta or for regular tables as well.
> {code}
> Caused by: org.apache.hadoop.hbase.io.hfile.CorruptHFileException: Problem
> reading HFile Trailer from file
> hdfs://cn017.l42scl.hortonworks.com:8020/apps/hbase/data/data/hbase/meta/1588230740/info/aa96e4ef463b4a82956330b236440437
> at
> org.apache.hadoop.hbase.io.hfile.HFile.pickReaderVersion(HFile.java:483)
> at org.apache.hadoop.hbase.io.hfile.HFile.createReader(HFile.java:511)
> at
> org.apache.hadoop.hbase.regionserver.StoreFile$Reader.(StoreFile.java:1123)
> at
> org.apache.hadoop.hbase.regionserver.StoreFileInfo.open(StoreFileInfo.java:267)
> at
> org.apache.hadoop.hbase.regionserver.StoreFile.open(StoreFile.java:409)
> at
> org.apache.hadoop.hbase.regionserver.StoreFile.createReader(StoreFile.java:512)
> at
> org.apache.hadoop.hbase.regionserver.HStore.createStoreFileAndReader(HStore.java:687)
> at
> org.apache.hadoop.hbase.regionserver.HStore.access$000(HStore.java:130)
> at org.apache.hadoop.hbase.regionserver.HStore$1.call(HStore.java:554)
> at org.apache.hadoop.hbase.regionserver.HStore$1.call(HStore.java:551)
> ... 6 more
> Caused by: java.io.IOException: java.lang.ClassNotFoundException:
> org.apache.hadoop.hbase.CellComparator$MetaCellComparator
> at
> org.apache.hadoop.hbase.io.hfile.FixedFileTrailer.getComparatorClass(FixedFileTrailer.java:581)
> at
> org.apache.hadoop.hbase.io.hfile.FixedFileTrailer.deserializeFromPB(FixedFileTrailer.java:300)
> at
> org.apache.hadoop.hbase.io.hfile.FixedFileTrailer.deserialize(FixedFileTrailer.java:242)
> at
> org.apache.hadoop.hbase.io.hfile.FixedFileTrailer.readFromStream(FixedFileTrailer.java:407)
> at
> org.apache.hadoop.hbase.io.hfile.HFile.pickReaderVersion(HFile.java:468)
> ... 15 more
> Caused by: java.lang.ClassNotFoundException:
> org.apache.hadoop.hbase.CellComparator$MetaCellComparator
> at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:264)
> at
> org.apache.hadoop.hbase.io.hfile.FixedFileTrailer.getComparatorClass(FixedFileTrailer.java:579)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19047) CP exposed Scanner types should not extend Shipper
[
https://issues.apache.org/jira/browse/HBASE-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222823#comment-16222823
]
Appy commented on HBASE-19047:
--
Given the core design is already out there, and not a part of this patch, you
don't necessarily have to change it. This patch is already changing things for
good. So am all +1 for it. Which path do you want, take your pick:
- Deleting the check and assign and get it in for alpha4.
- Separate out shipper from RegionScanner.
- Change RegionScanner *is a* Shipper (inheritance) to RegionScanner *has a*
Shipper (composition). And if the scanner after postScannerOpen returns empty
Optional, then go with a default shipper. (Probably best to do in follow-on for
beta1)
{noformat}
RegionScanner implements ShipperProvider {...}
interface ShipperProvider {
Optional getShipper();
}
{noformat}
> CP exposed Scanner types should not extend Shipper
> --
>
> Key: HBASE-19047
> URL: https://issues.apache.org/jira/browse/HBASE-19047
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Critical
> Fix For: 2.0.0-alpha-4
>
> Attachments: HBASE-19047.patch, HBASE-19047_V2.patch,
> HBASE-19047_V2.patch, HBASE-19047_V3.patch, HBASE-19047_V4.patch,
> HBASE-19047_V4.patch, HBASE-19047_V4.patch
>
>
> Shipper is a IA.Private interface and very much internal..
> Right now CP exposed RegionScanner is extending this and so exposing the
> shipped() method. This by mistake is called, can harm the correctness of the
> cells in the Results.
> preScannerOpen() allowing to return a new Scanner is also problematic now.
> This can allow users to create a Region scanner from Region and then wrap it
> and return back (Well same can be done by postScannerOpen also), it can so
> happen that the wrapper is not implementing the shipped() properly. In any
> way exposing the shipped () is problematic.
> Solution Steps
> 1. Remove preScannerOpen() , the use case I can think of is wrapping the
> original scanner. The original scanner can be created by Region.getScanner
> way only.. May be no need to remove this hook. Just remove the ability for
> it to return a RegionScanner instance. Call this with the Scan object and
> the CP can change the Scan object if they want.
> 2. Let RegionScanner not extending Shipper but only RegionScannerImpl
> implements this
> 3. We have ref to the RegionScanner created by core and let that be used by
> RegionScannerShippedCallBack when the post hook doing a wrap.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HBASE-19110) Add default for Server#isStopping
[ https://issues.apache.org/jira/browse/HBASE-19110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222816#comment-16222816 ] Umesh Agashe commented on HBASE-19110: -- +1 > Add default for Server#isStopping > - > > Key: HBASE-19110 > URL: https://issues.apache.org/jira/browse/HBASE-19110 > Project: HBase > Issue Type: Bug >Reporter: stack >Assignee: stack > Fix For: 2.0.0-alpha-4 > > Attachments: HBASE-19110.master.001.patch > > > Over in HBASE-19007 "Align Services Interfaces in Master and RegionServer", > we moved the isStopping method back into Server. In a late review, [~appy] > suggested that I should have had the Interface provide a default. This issue > is about doing as [~appy] suggested. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-18993) Backport patches in HBASE-18410 to branch-1.x branches.
[ https://issues.apache.org/jira/browse/HBASE-18993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222812#comment-16222812 ] Andrew Purtell commented on HBASE-18993: bq. I think it should not throw NoSuchMethodError exception. I think the issue is if someone coded static method invocation Filter. instead of super.. It's technically a binary compatibility break. I want to make sure it gets wide exposure for discussion. I'd like to place a "soft veto" on commit of this to 1.x until we have another opinion. I don't have a strong opinion on this. > Backport patches in HBASE-18410 to branch-1.x branches. > --- > > Key: HBASE-18993 > URL: https://issues.apache.org/jira/browse/HBASE-18993 > Project: HBase > Issue Type: Bug > Components: Filters >Reporter: Zheng Hu >Assignee: Zheng Hu > Fix For: 1.4.0, 1.5.0 > > Attachments: HBASE-18993-branch-1.1.v1.patch, > HBASE-18993-branch-1.2.v1.patch, HBASE-18993-branch-1.3.v1.patch, > HBASE-18993-branch-1.4.v1.patch, HBASE-18993-branch-1.4.v1.patch, > HBASE-18993-branch-1.4.v1.patch > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-19099) Evaluate the remaining compatibility concerns between branch-1.3 and branch-1.4 / branch-1
[ https://issues.apache.org/jira/browse/HBASE-19099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell reassigned HBASE-19099: -- Assignee: Andrew Purtell Ok - so, restore the TableInputFormatBase constants. Will put up a patch. Anything else? > Evaluate the remaining compatibility concerns between branch-1.3 and > branch-1.4 / branch-1 > -- > > Key: HBASE-19099 > URL: https://issues.apache.org/jira/browse/HBASE-19099 > Project: HBase > Issue Type: Task >Affects Versions: 1.4.0, 1.5.0 >Reporter: Andrew Purtell >Assignee: Andrew Purtell >Priority: Blocker > Fix For: 1.4.0, 1.5.0 > > > For discussion, here are the remaining compatibility concerns you will > encounter upon moving up from 1.3 to 1.4: > The below all relate to source level compatibility. Recompilation of a client > program may be terminated with the message "class C is not abstract and does > not override abstract method M in TYPE". According to our compatibility > guidelines we are allowed to add methods to interfaces, so these are ALLOWED. > Please let me know if you disagree. > package org.apache.hadoop.hbase.client > interface Admin > * Abstract method clearDeadServers ( List ) has been added to > this interface. > * Abstract method cloneSnapshot ( String, TableName, boolean ) has been added > to this interface. > * Abstract method isCleanerChoreEnabled ( ) has been added to this interface. > * Abstract method isMasterInMaintenanceMode ( ) has been added to this > interface. > * Abstract method listDeadServers ( ) has been added to this interface. > * Abstract method restoreSnapshot ( String, boolean, boolean ) has been added > to this interface. > * Abstract method runCleanerChore ( ) has been added to this interface. > * Abstract method setCleanerChoreRunning ( boolean ) has been added to this > interface. > package org.apache.hadoop.hbase.client > interface ResultScanner > * Abstract method renewLease ( ) has been added to this interface. > * Abstract method getScanMetrics ( ) has been added to this interface. > package org.apache.hadoop.hbase.client > interface Table > * Abstract method getReadRpcTimeout ( ) has been added to this interface. > * Abstract method getWriteRpcTimeout ( ) has been added to this interface. > * Abstract method setReadRpcTimeout ( int ) has been added to this interface. > * Abstract method setWriteRpcTimeout ( int ) has been added to this interface. > package org.apache.hadoop.hbase.replication > interface ReplicationPeer > * Abstract method getPeerBandwidth ( ) has been added to this interface. > * Abstract method trackPeerConfigChanges ( ReplicationPeerConfigListener ) > has been added to this interface. > package org.apache.hadoop.hbase.coprocessor > interface MasterCoprocessorEnvironment > * Abstract method getMetricRegistryForMaster ( ) has been added to this > interface. > package org.apache.hadoop.hbase.coprocessor > interface MasterObserver > * Abstract method postAddRSGroup ( > ObserverContext, String ) has been added to > this interface. > * Abstract method postBalanceRSGroup ( > ObserverContext, String, boolean ) has been > added to this interface. > * Abstract method postClearDeadServers ( > ObserverContext ) has been added to this > interface. > * Abstract method postListDeadServers ( > ObserverContext ) has been added to this > interface. > * Abstract method postMoveServers ( > ObserverContext, Set, String ) has > been added to this interface. > * Abstract method postMoveServersAndTables ( > ObserverContext, Set, Set, > String ) has been added to this interface. > * Abstract method postMoveTables ( > ObserverContext, Set, String ) has > been added to this interface. > * Abstract method postRemoveRSGroup ( > ObserverContext, String ) has been added to > this interface. > * Abstract method preAddRSGroup ( > ObserverContext, String ) has been added to > this interface. > * Abstract method preBalanceRSGroup ( > ObserverContext, String ) has been added to > this interface. > * Abstract method preClearDeadServers ( > ObserverContext ) has been added to this > interface. > * Abstract method preListDeadServers ( > ObserverContext ) has been added to this > interface. > * Abstract method preMoveServers ( > ObserverContext, Set, String ) has > been added to this interface. > * Abstract method preMoveServersAndTables ( > ObserverContext, Set, Set, > String ) has been added to this interface. > * Abstract method preMoveTables ( > ObserverContext, Set, String ) has > been added to this interface. > * Abstract method preRemoveRSGroup ( > ObserverContext, String ) has been added to > this interface. > package org.apache.hadoop.hbase.coprocessor > interface
[jira] [Commented] (HBASE-19111) Add missing CellUtil#isXXX(Cell) methods
[ https://issues.apache.org/jira/browse/HBASE-19111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16222804#comment-16222804 ] Josh Elser commented on HBASE-19111: Oh, excellent. My hope is to get this fixed today. Maybe I can still slide it into alpha-4... > Add missing CellUtil#isXXX(Cell) methods > > > Key: HBASE-19111 > URL: https://issues.apache.org/jira/browse/HBASE-19111 > Project: HBase > Issue Type: Bug > Components: Client >Reporter: Josh Elser >Assignee: Josh Elser >Priority: Critical > Fix For: 2.0.0-beta-1 > > > Over in HBASE-19002 while trying to write some RegionObservers, I found that > I couldn't find a public-API method to determine if a Cell was for a Put. We > seem to only have API for determining if it's a Delete. > Let's get some methods added to CellUtil for users to consume. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Assigned] (HBASE-12091) Optionally ignore edits for dropped tables for replication.
[ https://issues.apache.org/jira/browse/HBASE-12091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lars Hofhansl reassigned HBASE-12091: - Assignee: Lars Hofhansl > Optionally ignore edits for dropped tables for replication. > --- > > Key: HBASE-12091 > URL: https://issues.apache.org/jira/browse/HBASE-12091 > Project: HBase > Issue Type: Bug >Reporter: Lars Hofhansl >Assignee: Lars Hofhansl > Attachments: 12091.txt > > > We just ran into a scenario where we dropped a table from both the source and > the sink, but the source still has outstanding edits that now it could not > get rid of. Now all replication is backed up behind these unreplicatable > edits. > We should have an option to ignore edits for tables dropped at the source. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (HBASE-19112) Suspect methods on Cell to be deprecated
Josh Elser created HBASE-19112:
--
Summary: Suspect methods on Cell to be deprecated
Key: HBASE-19112
URL: https://issues.apache.org/jira/browse/HBASE-19112
Project: HBase
Issue Type: Bug
Components: Client
Reporter: Josh Elser
Fix For: 2.0.0-beta-1
[~chia7712] suggested on the [mailing
list|https://lists.apache.org/thread.html/e6de9af26d9b888a358ba48bf74655ccd893573087c032c0fcf01585@%3Cdev.hbase.apache.org%3E]
that we have some methods on Cell which should be deprecated for removal:
* {{#getType()}}
* {{#getTimestamp()}}
* {{#getTag()}}
* {{#getSequenceId()}}
Let's make a pass over these (and maybe the rest) to make sure that there
aren't others which are either implementation details or methods returning
now-private-marked classes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
