date:20200417

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:52c0a136f9ff: [ExpandableListItem] make it touch-friendly 
(authored by ngraham).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28808?vs=80218=80445

REVISION DETAIL
  https://phabricator.kde.org/D28808

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/ExpandableListItem.qml

To: ngraham, #plasma, apol, #vdg, niccolove
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng updated this revision to Diff 80444.
xuetianweng added a comment.


  Fix the handling when layout formats has background.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25339?vs=80438=80444

BRANCH
  arcpatch-D25339

REVISION DETAIL
  https://phabricator.kde.org/D25339

AFFECTED FILES
  src/render/katerenderer.cpp

To: xuetianweng, #ktexteditor, cullmann, dhaumann
Cc: anthonyfieroni, kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, 
cblack, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng added a comment.


  F8244684: Screenshot_20200417_222110.png 

  
  Add a screenshot to demostrate the change.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann
Cc: anthonyfieroni, kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, 
cblack, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Failing!

2020-04-17 Thread Ben Cooksley

Hi all,

Please see below - any ideas as to why KHelpCenter no longer successfully
builds?

It doesn't look like KHelpCenter has changed...

Cheers,
Ben

-- Forwarded message -
From: CI System 
Date: Sat, Apr 18, 2020 at 4:38 PM
Subject: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5
FreeBSDQt5.14 - Build # 7 - Still Failing!
To: 


*BUILD FAILURE*
Build URL
https://build.kde.org/job/Administration/job/Dependency%20Build%20Plasma%20stable-kf5-qt5%20FreeBSDQt5.14/7/
Project: Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14
Date of build: Sat, 18 Apr 2020 04:09:43 +
Build duration: 28 min and counting
* CONSOLE OUTPUT *
[...truncated 117391 lines...]
[2020-04-18T04:38:09.745Z] Scanning dependencies of target testmetainfo
[2020-04-18T04:38:09.745Z] [ 22%] Built target
doc-onlinehelp-index-cache-bz2
[2020-04-18T04:38:09.745Z] [ 23%] Building CXX object
searchhandlers/CMakeFiles/khc_xapianindexer.dir/htmltextdump.cpp.o
[2020-04-18T04:38:10.007Z] [ 25%] Building CXX object
tests/CMakeFiles/testmetainfo.dir/testmetainfo_autogen/mocs_compilation.cpp.o
[2020-04-18T04:38:10.007Z] [ 27%] Building CXX object
searchhandlers/CMakeFiles/khc_xapianindexer.dir/cachereader.cpp.o
[2020-04-18T04:38:10.007Z] [ 28%] Building CXX object
searchhandlers/CMakeFiles/khc_xapianindexer.dir/xapiancommon.cpp.o
[2020-04-18T04:38:10.007Z] [ 30%] Building CXX object
searchhandlers/CMakeFiles/khc_xapianindexer.dir/xapianindexer.cpp.o
[2020-04-18T04:38:10.007Z] [ 32%] Building CXX object
tests/CMakeFiles/testmetainfo.dir/testmetainfo.cpp.o
[2020-04-18T04:38:10.007Z] [ 33%] Building CXX object
tests/CMakeFiles/testmetainfo.dir/__/docmetainfo.cpp.o
[2020-04-18T04:38:10.007Z] [ 33%] Built target
doc-khelpcenter-index-cache-bz2
[2020-04-18T04:38:10.007Z] [ 35%] Building CXX object
tests/CMakeFiles/testmetainfo.dir/__/docentry.cpp.o
[2020-04-18T04:38:10.265Z] [ 35%] Built target doc-glossary-index-cache-bz2
[2020-04-18T04:38:10.265Z] [ 37%] Building CXX object
tests/CMakeFiles/testmetainfo.dir/__/docentrytraverser.cpp.o
[2020-04-18T04:38:10.524Z] [ 37%] Built target
doc-fundamentals-index-cache-bz2
[2020-04-18T04:38:10.524Z] [ 38%] Building CXX object
tests/CMakeFiles/testmetainfo.dir/khc_debug.cpp.o
[2020-04-18T04:38:10.524Z] [ 38%] Built target kdeinit_khelpcenter_autogen
[2020-04-18T04:38:10.524Z] [ 40%] Building CXX object
tests/CMakeFiles/testmetainfo.dir/prefs.cpp.o
[2020-04-18T04:38:11.094Z]
/usr/home/jenkins/workspace/Administration/Dependency Build Plasma
stable-kf5-qt5
FreeBSDQt5.14/khelpcenter/searchhandlers/cachereader.cpp:108:10: error: no
member named 'fromList' in 'QSet'; did you mean
'QStack::fromList'?
[2020-04-18T04:38:11.094Z] return QSet::fromList(
mRanges.uniqueKeys() );
[2020-04-18T04:38:11.094Z] ^~~
[2020-04-18T04:38:11.094Z] QStack::fromList
[2020-04-18T04:38:11.094Z] /usr/local/include/qt5/QtCore/qvector.h:301:23:
note: 'QStack::fromList' declared here
[2020-04-18T04:38:11.094Z] static QVector fromList(const QList );
[2020-04-18T04:38:11.094Z] ^
[2020-04-18T04:38:11.094Z] [ 42%] Generating prefs.h, prefs.cpp
[2020-04-18T04:38:11.094Z] 1 error generated.
[2020-04-18T04:38:11.094Z] gmake[2]: ***
[searchhandlers/CMakeFiles/khc_xapianindexer.dir/build.make:96:
searchhandlers/CMakeFiles/khc_xapianindexer.dir/cachereader.cpp.o] Error 1
[2020-04-18T04:38:11.094Z] gmake[2]: *** Waiting for unfinished jobs
[2020-04-18T04:38:11.354Z] [ 44%] Linking CXX executable
../bin/khc_xapiansearch
[2020-04-18T04:38:11.354Z] [ 44%] Built target khc_xapiansearch
[2020-04-18T04:38:11.354Z] Scanning dependencies of target
kdeinit_khelpcenter
[2020-04-18T04:38:11.354Z] [ 47%] Building CXX object
CMakeFiles/kdeinit_khelpcenter.dir/navigatorappgroupitem.cpp.o
[2020-04-18T04:38:11.354Z] [ 47%] Building CXX object
CMakeFiles/kdeinit_khelpcenter.dir/kdeinit_khelpcenter_autogen/mocs_compilation.cpp.o
[2020-04-18T04:38:11.354Z] [ 49%] Building CXX object
CMakeFiles/kdeinit_khelpcenter.dir/searchwidget.cpp.o
[2020-04-18T04:38:11.354Z] [ 50%] Building CXX object
CMakeFiles/kdeinit_khelpcenter.dir/docmetainfo.cpp.o
[2020-04-18T04:38:11.354Z] [ 54%] Building CXX object
CMakeFiles/kdeinit_khelpcenter.dir/navigator.cpp.o
[2020-04-18T04:38:11.354Z] [ 54%] Building CXX object
CMakeFiles/kdeinit_khelpcenter.dir/navigatoritem.cpp.o
[2020-04-18T04:38:11.354Z] [ 57%] Building CXX object
CMakeFiles/kdeinit_khelpcenter.dir/view.cpp.o
[2020-04-18T04:38:11.354Z] [ 57%] Building CXX object
CMakeFiles/kdeinit_khelpcenter.dir/navigatorappitem.cpp.o
[2020-04-18T04:38:11.354Z] [ 59%] Building CXX object
CMakeFiles/kdeinit_khelpcenter.dir/searchengine.cpp.o
[2020-04-18T04:38:11.354Z] [ 61%] Building CXX object
CMakeFiles/kdeinit_khelpcenter.dir/docentrytraverser.cpp.o
[2020-04-18T04:38:11.613Z] gmake[1]: *** [CMakeFiles/Makefile2:570:
searchhandlers/CMakeFiles/khc_xapianindexer.dir/all] Error 2
[2020-04-18T04:38:11.614Z] gmake[1]: *** Waiting for unfinished jobs
[2020-04-18T04:38:11.614Z] [ 62%] Building

Re: KDE CI: Administration » Dependency Build Extragear stable-kf5-qt5 AndroidQt5.14 - Build # 10 - Still Failing!

2020-04-17 Thread Ben Cooksley

On Fri, Apr 17, 2020 at 8:28 AM Nicolas Fella  wrote:
>
> Hi,

Hi Nicolas,

>
>
>
> this looks like a simple prison build failure to me. However, I cannot 
> reprocuce this with the binary factory container and the current Prison 
> Android CI builds is blue. There is a single red Android build in the Prison 
> CI history 
> (https://build.kde.org/job/Frameworks/job/prison/job/kf5-qt5%20AndroidQt5.14/5/)
>  with what appears to be the same error message. Not sure how to explain that 
> though.
>

Thanks for taking a look.

I've now done a rebuild of the image and after that the Dependency
Build ran through fine - so all sorted now!

>
>
> Nico

Cheers,
Ben

>
>
>
>
>
> On Donnerstag, 16. April 2020 21:10:44 CEST Ben Cooksley wrote:
>
> > On Fri, Apr 17, 2020 at 6:37 AM Johan Ouwerkerk  
> > wrote:
>
> > > On Thu, Apr 16, 2020 at 10:51 AM Ben Cooksley  wrote:
>
> > >> Hi all,
>
> > >>
>
> > >> Does anyone know why the below would have suddenly started failing a
>
> > >> little while back?
>
> > >>
>
> > >> Thanks,
>
> > >> Ben
>
> > >
>
> > > Based on the error message I would expect this to be related to the effort
>
> > > to fix Android pkgs not being generated for both 32bit and 64bit ARM.
>
> > I see. Do we have a timeline for this being fixed?
>
> >
>
> > > Regards,
>
> > >
>
> > > - Johan
>
> >
>
> > Cheers,
>
> > Ben
>
>
>
>

D28934: baloo_file stop throwing ASSERT failure

2020-04-17 Thread Leszek Lesner

leszeklesner created this revision.
leszeklesner added a reviewer: Baloo.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
leszeklesner requested review of this revision.

REVISION SUMMARY
  I build baloo from 5.69 and always get on executing baloo_file.
  
baloo_file
ASSERT failure in KCatalogPrivate::setupGettextEnv: "You need to 
instantiate a Q*Application before using KCatalog", file 
/home/leszek/kde/src/ki18n/src/kcatalog.cpp, line 223
fish: 'baloo_file' terminated by signal SIGABRT
  
  Using translations after QApplications in baloo_file fixes the issue.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28934

AFFECTED FILES
  src/file/main.cpp

To: leszeklesner, #baloo
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 554 - Still Unstable!

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/554/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 18 Apr 2020 02:56:18 +
 Build duration:
13 min and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34937/62148)40%
(17726/43908)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9813/10283)46%
(4578/9882)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(101/115)88%
(101/115)59%
(8500/14316)51%
(4464/8698)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8341)43%
(2081/4826)src.gui100%
(5/5)100%
(5/5)81%
(332/412)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(711/1286)41%
(423/1036)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(646/1375)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 63 - Still Unstable!

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/63/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Sat, 18 Apr 2020 02:56:19 +
 Build duration:
7 min 53 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 55 - Still Unstable!

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/55/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Sat, 18 Apr 2020 02:56:19 +
 Build duration:
7 min 15 sec and counting
   BUILD ARTIFACTS
  acc/KF5KIO-5.70.0.xmllogs/KF5KIO/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 53 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(24/36)67%
(270/406)67%
(270/406)56%
(34940/62150)40%
(17732/43904)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(58/58)100%
(58/58)95%
(9813/10282)46%
(4580/9882)autotests.http100%
(5/5)100%
(5/5)99%
(582/583)65%
(88/136)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core88%
(101/115)88%
(101/115)59%
(8496/14316)51%
(4464/8698)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets68%
(26/38)68%
(26/38)56%
(4694/8343)43%
(2079/4822)src.gui100%
(5/5)100%
(5/5)81%
(332/412)58%
(163/280)src.ioslaves.file100%
(7/7)100%
(7/7)55%
(711/1286)41%
(423/1036)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/168)0%
(0/89)src.ioslaves.ftp100%
(2/2)100%
(2/2)47%
(646/1375)37%
(525/1420)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)42%
(1796/4287)36%
(1309/3628)src.ioslaves.http.kcookiejar40%
(2/5)40%
(2/5)48%
(634/1333)56%
(578/1029)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(74/270)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%

D28910: [KFileBookMarkHandler] Port to new KBookmarkMenu-5.69

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:bd7607f43dea: [KFileBookMarkHandler] Port to new 
KBookmarkMenu-5.69 (authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28910?vs=80440=80441

REVISION DETAIL
  https://phabricator.kde.org/D28910

AFFECTED FILES
  src/filewidgets/kfilebookmarkhandler.cpp
  src/filewidgets/kfilebookmarkhandler_p.h

To: ahmadsamir, #frameworks, dfaure, nicolasfella
Cc: asturmlechner, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28910: [KFileBookMarkHandler] Port to new KBookmarkMenu-5.69

ahmadsamir updated this revision to Diff 80440.
ahmadsamir added a comment.


  Remove ifdef, all KF5 parts require the same version

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28910?vs=80364=80440

BRANCH
  l-kbookmark (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28910

AFFECTED FILES
  src/filewidgets/kfilebookmarkhandler.cpp
  src/filewidgets/kfilebookmarkhandler_p.h

To: ahmadsamir, #frameworks, dfaure, nicolasfella
Cc: asturmlechner, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28874: Taiwanese holidays

ngraham added a comment.


  Sure, I can do it.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28874

To: shrapnel, #vdg, Zren, winterz
Cc: ngraham, winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28910: [KFileBookMarkHandler] Port to new KBookmarkMenu-5.69

ahmadsamir added a comment.


  In D28910#650745 , @dfaure wrote:
  
  > Thanks.
  >
  > Well, all of KF5 is supposed to always be the same version. You don't need 
the ifdef for old kbookmarks version. KIO 5.70 requires KBookmarks 5.70.
  
  
  Ah, yes, my mind was "preset" from other ports. Will remove.

REPOSITORY
  R241 KIO

BRANCH
  l-kbookmark (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28910

To: ahmadsamir, #frameworks, dfaure, nicolasfella
Cc: asturmlechner, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28932: Store filename terms just once

bruns updated this revision to Diff 80439.
bruns added a comment.


  add missing tests

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28932?vs=80435=80439

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28932

AFFECTED FILES
  autotests/integration/querytest.cpp
  src/engine/termgenerator.cpp
  src/engine/termgenerator.h
  src/file/basicindexingjob.cpp
  src/lib/searchstore.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

Re: Downtime for SVN - Action Required

2020-04-17 Thread Nicolás Alvarez

El dom., 12 de abr. de 2020 a la(s) 05:57, Ben Cooksley
(bcooks...@kde.org) escribió:
>
> Hi all,
>
> As you may be aware, KDE is currently undertaking a migration to Gitlab.
>
> As part of this, we also need to migrate our Subversion repository
> from the server it currently resides on to the new system that also
> hosts Gitlab. To simplify our systems we will also transition
> management of SSH keys to Gitlab when we do this.
>
> It is intended at this time that we perform the migration of the
> Subversion repository next weekend.
>
> We therefore need all holders of a Developer account, even if they
> only use our Subversion repository, to login to Gitlab and upload
> their SSH keys there.
>
> Our Gitlab instance can be found at https://invent.kde.org/ and you
> should be able to login there using your KDE Identity
> (identity.kde.org) details.
>
> Additionally, following this migration we will begin limiting access
> to the Subversion repository to those actively using it. The list of
> people whose access will be continued can be found at
> https://cgit.kde.org/repo-management.git/tree/svn-ssh-keys/users-list
>
> Should you still need access to the repository, but are not on the
> above list, please let us know by emailing sysad...@kde.org.
>
> If anyone has any questions on the above, please let us know.

Hi all,

I wanted to add that this server migration will also change the SSH
host keys for "svn.kde.org". After we switch servers, you will get the
nasty "WARNING: REMOTE HOST IDENTIFICATION HAS CHANGED!" message from
ssh when you use SVN. To avoid this, you should add the new keys to
your ~/.ssh/known_hosts. You don't need to wait for the server switch,
you can add it now (keeping both old and new keys in the file) and it
will Just Work.

I have added instructions for all these changes and the new ssh host
keys to the wiki:
https://community.kde.org/Infrastructure/Subversion/2020_Changes

-- 
Nicolás
KDE Sysadmin Team

Re: Downtime for SVN - Action Required

2020-04-17 Thread Nicolás Alvarez

El dom., 12 de abr. de 2020 a la(s) 05:57, Ben Cooksley
(bcooks...@kde.org) escribió:
>
> Hi all,
>
> As you may be aware, KDE is currently undertaking a migration to Gitlab.
>
> As part of this, we also need to migrate our Subversion repository
> from the server it currently resides on to the new system that also
> hosts Gitlab. To simplify our systems we will also transition
> management of SSH keys to Gitlab when we do this.
>
> It is intended at this time that we perform the migration of the
> Subversion repository next weekend.
>
> We therefore need all holders of a Developer account, even if they
> only use our Subversion repository, to login to Gitlab and upload
> their SSH keys there.
>
> Our Gitlab instance can be found at https://invent.kde.org/ and you
> should be able to login there using your KDE Identity
> (identity.kde.org) details.
>
> Additionally, following this migration we will begin limiting access
> to the Subversion repository to those actively using it. The list of
> people whose access will be continued can be found at
> https://cgit.kde.org/repo-management.git/tree/svn-ssh-keys/users-list
>
> Should you still need access to the repository, but are not on the
> above list, please let us know by emailing sysad...@kde.org.
>
> If anyone has any questions on the above, please let us know.

Hi all,

I wanted to add that this server migration will also change the SSH
host keys for "svn.kde.org". After we switch servers, you will get the
nasty "WARNING: REMOTE HOST IDENTIFICATION HAS CHANGED!" message from
ssh when you use SVN. To avoid this, you should add the new keys to
your ~/.ssh/known_hosts. You don't need to wait for the server switch,
you can add it now (keeping both old and new keys in the file) and it
will Just Work.

I have added instructions for all these changes and the new ssh host
keys to the wiki:
https://community.kde.org/Infrastructure/Subversion/2020_Changes

-- 
Nicolás
KDE Sysadmin Team

Re: Calindori in kdereview

2020-04-17 Thread Dimitris Kardarakos

On April 17, 2020 12:02:59 AM GMT+03:00, Albert Astals Cid  
wrote:
>El diumenge, 12 d’abril de 2020, a les 15:42:15 CEST, Dimitris
>Kardarakos va escriure:
>> Hello everyone,
>> 
>> I'd like to let you know that the Calindori [1] application has been
>> moved to kdereview.
>
>Some comments from playing with it a bit on the desktop.
>
Many thanks Albert for the review.

>Going from the day view to the month view in my computer takes about 4
>seconds. Can you reproduce that? Seems like if i have that on a phone
>that's less powerful would be worse.
>

Nope, but the month view, yes, it does cause performance issues. I had a short 
discussion with Marco on it during the plamo mini sprint.

>On the top bar of the Month view you're using the "wrong" way to format
>month + year 
>See how i get "of April 2020" when used in catalan, you should be using
>standaloneMonthName there if you're not going to put the day in front
>(korganizer makes that mistake almost everywhere)
>https://i.imgur.com/4BwMCCn.png
>
It will be addressed.

>In the month view, I find it a bit weird that if i change the month to
>January 2020, it still says "16 April 2020", which i get, it's still
>"the selected date", but my brain is totally unhappy about it.
>
I get your point. But what would be a sensible value for the selected date 
after month change? 1st day of month? Same day of the next month?

>In the month view, the "Today" button is weird because it isn't
>actually "today" it's "show this month", if i am in this month, but
>have selected a different day (e.g. 30 of April) click "Today" does
>nothing. I would expect it to select today.
>
It should select the current day, I ll look into it.

>I find it a bit weird that going from Day view to Week view selects a
>different day, i.e. if i'm on Day view i get 16 of April, if i go to
>Week view i end up on 13 of April.
>
I thinks of global actions as context agnostic. On the other hand, if it was a 
contextual action, it would be required to remember the selected day. Dunno...

>When adding an event i find it a bit strange that the default duration
>is 0 seconds.
>
Well, I have never find useful the default event interval of Android calendar; 
I always end up changing the duration. What duration value would be a sensible 
default?

>The week view seems to use the megashort day names and at least in the
>desktop seems a bit empty https://i.imgur.com/qHAXXz8.png 
>Wouldn't it make more sense to at least have the numbers in the list
>too?
This view is supposed to be filled with event and task summaries. If you add 
some events does it feel less empty?

>Where are the tasks stored? Is it using a standard format?
>
Calendar files in the standard kde app location, in ical format, using the 
kcalendarcore framework.

>Feature request: (obviously ignore for now)
>* I always want my events to have a reminder, let me set in options
>"create a reminder for events by default"
>
Yep, it is in my todo list :)

>Cheers,
>  Albert
>
>P.S: I get like a million QML warnings in the command line, but most of
>those seem to be more kirigami than yours
>
Mostly yes, we have to check them one by one.

>> 
>> Calindori is a calendar application, built with Kirigami and
>following
>> the KDE HIGs. It has been created for Plasma Mobile but it can also
>> run on Linux desktop environments.
>> 
>> It offers:
>> 
>> - Month view
>> - Week view
>> - Day view
>> - Event management
>> - Repeating events
>> - Alarms and notifications
>> - Todo management
>> - Multiple calendars
>> - Calendar import
>> 
>> A set of touch friendly date and time pickers have also been created
>> for Calindori.
>> 
>> I would be be happy if you reviewed and helped it to become part of
>> the release service.
>> 
>> [1] https://invent.kde.org/kde/calindori/
>> 
>> Have a great day,
>> 
>> --
>> Dimitris
>> 


Dimitris

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng added a comment.

  In D25339#563937 , @cullmann wrote:

  > Actually, I could live with:
  >
  > 1. All lines are a bit higher, for me that makes reading even easier. But 
the rendering shall have no glitches.
  > 2. Some lines have different heights. But I assume this is hard to 
implement at the moment.

  After some experiment and reading the Qt code, seems there is no easy way to 
extend the line height..
  E.g. QPlainTextEdit will show the text with different line height, so I 
believe I couldn't do it with in Qt.

  So I tried to use a small trick to fill the gap.
  If there is some gap need to be filled, then the code tried to draw some 
transparent text so the background will be extended to fill the gap. Then draw 
the real text.

  The solution is hacky though.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann
Cc: anthonyfieroni, kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, 
cblack, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng updated this revision to Diff 80438.
xuetianweng added a comment.


  handle the range with multiple lines.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25339?vs=80433=80438

BRANCH
  arcpatch-D25339

REVISION DETAIL
  https://phabricator.kde.org/D25339

AFFECTED FILES
  src/render/katerenderer.cpp

To: xuetianweng, #ktexteditor, cullmann, dhaumann
Cc: anthonyfieroni, kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, 
cblack, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28933: [Coding] Avoid recurrent detach and size checks

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  QVector::append() is quite expensive, as each access checks if the array
  needs to be detached or has to grow. Resizing the array and setting
  the elements with an iterator is significantly faster.

TEST PLAN
  valgrind --tool=callgrind baloosearch the_test.txt

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28933

AFFECTED FILES
  src/codecs/coding.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28900: Fix wayland scanner warnings

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:3734a5368e44: Fix wayland scanner warnings (authored by 
apol).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28900?vs=80334=80436

REVISION DETAIL
  https://phabricator.kde.org/D28900

AFFECTED FILES
  find-modules/FindQtWaylandScanner.cmake
  find-modules/FindWaylandScanner.cmake

To: apol, #build_system, #kwin, #frameworks, davidedmundson
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, 
michaelh, ngraham, bruns

D28932: Store filename terms just once

bruns updated this revision to Diff 80435.
bruns added a comment.


  whitespace

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28932?vs=80434=80435

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28932

AFFECTED FILES
  autotests/integration/querytest.cpp
  src/engine/termgenerator.cpp
  src/engine/termgenerator.h
  src/file/basicindexingjob.cpp
  src/lib/searchstore.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28932: Store filename terms just once

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Filename terms where stored twice, once with the "F" filename property
  prefix, and once without prefix. This allows to trivially search for
  files where a term matches in filename or content, but has a number
  of drawbacks:
  
  1. It is not possible to search for a term in content only
  2. The storage size for filenames is approximately doubled
  3. File renaming can cause significant I/O load
  4. Terms appearing in both content and filename may be stored incomplete in 
the phrase storage.
  
  Re (2.), in case full text indexing is disabled this is a significant
  part of the storage size. With full text indexing, the space savings
  are likely neglegible.
  
  Re (3.), when renaming a file where part of the filename is a common term,
  e.g. "The fox.txt", renaming caused rewriting of data for "the", "fox"
  and "txt". While for "txt" and "fox" this is neglegible, "the" is common
  enough to cause a of rewrite of 10% of the whole DB.
  
  The default search behaviour of matching both filename and content
  can be restored by internally creating queries for both filename and
  content and ORing both together. This extra step does not have any
  noticeable (or even measurable) performance impact.
  
  Depends on D28929 

TEST PLAN
  $> ctest -R querytest
  $> baloosearch content:pdf
  $> baloosearch filename:pdf
  $> baloosearch pdf
  $> baloosearch content:pdf OR filename:pdf
  (the last two queries are equivalent)

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28932

AFFECTED FILES
  autotests/integration/querytest.cpp
  src/engine/termgenerator.cpp
  src/engine/termgenerator.h
  src/file/basicindexingjob.cpp
  src/lib/searchstore.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28929: [QueryTest] Track if phrase matches in content or filename

bruns added a dependent revision: D28932: Store filename terms just once.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28929

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng updated this revision to Diff 80433.
xuetianweng added a comment.


  Try to fill the gap if we increase the line height with representitive char.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25339?vs=69848=80433

BRANCH
  arcpatch-D25339

REVISION DETAIL
  https://phabricator.kde.org/D25339

AFFECTED FILES
  src/render/katerenderer.cpp

To: xuetianweng, #ktexteditor, cullmann, dhaumann
Cc: anthonyfieroni, kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, 
cblack, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D28910: [KFileBookMarkHandler] Port to new KBookmarkMenu-5.69

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Thanks.
  
  Well, all of KF5 is supposed to always be the same version. You don't need 
the ifdef for old kbookmarks version. KIO 5.70 requires KBookmarks 5.70.

REPOSITORY
  R241 KIO

BRANCH
  l-kbookmark (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28910

To: ahmadsamir, #frameworks, dfaure, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27816: KI18N_WRAP_UI macro: set SKIP_AUTOUIC property on ui file and gen. header

2020-04-17 Thread Friedrich W. H. Kossebau

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R249:2797750b7f8f: KI18N_WRAP_UI macro: set SKIP_AUTOUIC 
property on ui file and gen. header (authored by kossebau).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27816?vs=76887=80430

REVISION DETAIL
  https://phabricator.kde.org/D27816

AFFECTED FILES
  cmake/KF5I18nMacros.cmake.in

To: kossebau, #frameworks, ilic
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28901: Add KIO::StatRecursiveSize detail value so kio_trash only does this on demand

dfaure updated this revision to Diff 80428.
dfaure added a comment.


  Remove comment change above StatBasic

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28901?vs=80335=80428

BRANCH
  2020_optimize_recursive_size

REVISION DETAIL
  https://phabricator.kde.org/D28901

AFFECTED FILES
  src/core/global.h
  src/ioslaves/trash/kio_trash.cpp
  src/ioslaves/trash/kio_trash.h
  src/ioslaves/trash/trashimpl.cpp
  src/ioslaves/trash/trashimpl.h

To: dfaure, meven, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Polish translation of "Cancel"

2020-04-17 Thread Luigi Toscano

Łukasz Wojniłowicz ha scritto:
> No problem but give me some time. I must schedule that but I'm not sure of 
> Luigi's plans in that matter.

I would say: please go ahead and plan it. We can set a check point in a few
weeks and see if more time or help is needed.



-- 
Luigi

D28901: Add KIO::StatRecursiveSize detail value so kio_trash only does this on demand

dfaure added inline comments.

INLINE COMMENTS

> meven wrote in trashimpl.cpp:1105
> Maybe, check for `details & KIO::StatTime`
> Down the rabbit hole...

Well, if StatRecursiveSize is set, we have the info, so we might as well 
provide it.

If it's not set, then this would mean we need to do the whole recursive thing 
also when StatTime is set, and it's part of StatDefaultDetails so I expect 
we'll do this often for nothing. I think we don't really want to do that, in 
practice we need both pieces of information, or none.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28901

To: dfaure, meven, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28924: [SearchStore] Allow querying exact matches for non-properties

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:de261f8bae5a: [SearchStore] Allow querying exact matches 
for non-properties (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28924?vs=80417=80426

REVISION DETAIL
  https://phabricator.kde.org/D28924

AFFECTED FILES
  src/lib/searchstore.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28925: [QueryTest] Extend phrase query tests

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:0a626db918a9: [QueryTest] Extend phrase query tests 
(authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28925?vs=80418=80427

REVISION DETAIL
  https://phabricator.kde.org/D28925

AFFECTED FILES
  autotests/integration/querytest.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28874: Taiwanese holidays

winterz added a comment.


  In D28874#650661 , @ngraham wrote:
  
  > Do you not have commit access? I thought you were the maintainer based on 
the repo's history!
  
  
  Yes of course.
  I'm asking for assistance at this time.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28874

To: shrapnel, #vdg, Zren, winterz
Cc: ngraham, winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

Re: Calindori in kdereview

2020-04-17 Thread Albert Astals Cid

El divendres, 17 d’abril de 2020, a les 15:27:04 CEST, Dimitris Kardarakos va 
escriure:
> On April 17, 2020 12:02:59 AM GMT+03:00, Albert Astals Cid  
> wrote:
> >El diumenge, 12 d’abril de 2020, a les 15:42:15 CEST, Dimitris
> >Kardarakos va escriure:
> >> Hello everyone,
> >> 
> >> I'd like to let you know that the Calindori [1] application has been
> >> moved to kdereview.
> >
> >Some comments from playing with it a bit on the desktop.
> >
> Many thanks Albert for the review.
> 
> >Going from the day view to the month view in my computer takes about 4
> >seconds. Can you reproduce that? Seems like if i have that on a phone
> >that's less powerful would be worse.
> >
> 
> Nope, but the month view, yes, it does cause performance issues. I had a 
> short discussion with Marco on it during the plamo mini sprint.
> 
> >On the top bar of the Month view you're using the "wrong" way to format
> >month + year 
> >See how i get "of April 2020" when used in catalan, you should be using
> >standaloneMonthName there if you're not going to put the day in front
> >(korganizer makes that mistake almost everywhere)
> >https://i.imgur.com/4BwMCCn.png
> >
> It will be addressed.
> 
> >In the month view, I find it a bit weird that if i change the month to
> >January 2020, it still says "16 April 2020", which i get, it's still
> >"the selected date", but my brain is totally unhappy about it.
> >
> I get your point. But what would be a sensible value for the selected date 
> after month change? 1st day of month? Same day of the next month?

That is a good question, and honestly I'm not really an UX expert, but in my 
opinion any of "1st day of month", "Same day of the other month" or even "no 
day selection" are better than keeping a huge text in the middle of the screen 
that no longer refers to the current month on view.

> 
> >In the month view, the "Today" button is weird because it isn't
> >actually "today" it's "show this month", if i am in this month, but
> >have selected a different day (e.g. 30 of April) click "Today" does
> >nothing. I would expect it to select today.
> >
> It should select the current day, I ll look into it.
> 
> >I find it a bit weird that going from Day view to Week view selects a
> >different day, i.e. if i'm on Day view i get 16 of April, if i go to
> >Week view i end up on 13 of April.
> >
> I thinks of global actions as context agnostic. On the other hand, if it was 
> a contextual action, it would be required to remember the selected day. 
> Dunno...

I don't understand what you mean as context agnostic. What i mean is 
 * going to Month will show me the current month with the current day 
selected
 * going to Day   will show me the current day   with the current day 
selected
 * going to Week  will show me the current week  with NOT the current day 
selected

The third sentence seems like it would be more coherent to the other two if it 
selected the current day.

> 
> >When adding an event i find it a bit strange that the default duration
> >is 0 seconds.
> >
> Well, I have never find useful the default event interval of Android 
> calendar; I always end up changing the duration. What duration value would be 
> a sensible default?

1 hour? I guess eventually once you have settings you should let people chose 
that.

> >The week view seems to use the megashort day names and at least in the
> >desktop seems a bit empty https://i.imgur.com/qHAXXz8.png 
> >Wouldn't it make more sense to at least have the numbers in the list
> >too?
> This view is supposed to be filled with event and task summaries. If you add 
> some events does it feel less empty?

I guess, yes.

Cheers,
  Albert

> 
> >Where are the tasks stored? Is it using a standard format?
> >
> Calendar files in the standard kde app location, in ical format, using the 
> kcalendarcore framework.
> 
> >Feature request: (obviously ignore for now)
> >* I always want my events to have a reminder, let me set in options
> >"create a reminder for events by default"
> >
> Yep, it is in my todo list :)
> 
> >Cheers,
> >  Albert
> >
> >P.S: I get like a million QML warnings in the command line, but most of
> >those seem to be more kirigami than yours
> >
> Mostly yes, we have to check them one by one.
> 
> >> 
> >> Calindori is a calendar application, built with Kirigami and
> >following
> >> the KDE HIGs. It has been created for Plasma Mobile but it can also
> >> run on Linux desktop environments.
> >> 
> >> It offers:
> >> 
> >> - Month view
> >> - Week view
> >> - Day view
> >> - Event management
> >> - Repeating events
> >> - Alarms and notifications
> >> - Todo management
> >> - Multiple calendars
> >> - Calendar import
> >> 
> >> A set of touch friendly date and time pickers have also been created
> >> for Calindori.
> >> 
> >> I would be be happy if you reviewed and helped it to become part of
> >> the release service.
> >> 
> >> [1] https://invent.kde.org/kde/calindori/
> >> 
> >> Have a great day,
> >> 
> >> --
> >> Dimitris
>

D28929: [QueryTest] Track if phrase matches in content or filename

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  When checking for matches, a phrase can match the content, the filename,
  or both.
  
  Currently, it is not possible to only match the content, but not the
  filename, thus the filename matches are not checked.
  
  This is a preparatory change, no functional changes
  
  Depends on D28925 

TEST PLAN
  ctest -R querytest

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28929

AFFECTED FILES
  autotests/integration/querytest.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28925: [QueryTest] Extend phrase query tests

bruns added a dependent revision: D28929: [QueryTest] Track if phrase matches 
in content or filename.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28925

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28923: Update links in README.md

2020-04-17 Thread Noah Davis

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:e5dfa14b64a6: Update links in README.md (authored by 
ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28923?vs=80414=80423

REVISION DETAIL
  https://phabricator.kde.org/D28923

AFFECTED FILES
  README.md

To: ndavis, #vdg, ngraham
Cc: alex-l, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

Re: Polish translation of "Cancel"

2020-04-17 Thread Shinjo Park

I wanted to avoid this topic because I don't know Polish language, but due to 
the comments in the said bug and this list, and my personal experience, I 
changed my mind.

2020년 4월 17일 금요일 오후 8시 31분 12초 CEST에 Łukasz Wojniłowicz 님이 쓴 글:
> > I also do not understand how this one word became a cause worth fighting
> > for.
> 
> For me it's a case of language correctness and purity.
> ...
> The thing is, that some people see this translation as "absurd", "invalid",
> "ancient" and I presume it is so because it's not what they've been
> accustomed to by the mainstream OS, which is Windows.

Back around 1990s the similar movement used to exist in Korea. The computer-
related words were primarily "imported" from English, and earlier computer 
users and experts tried to "purify" the terms which is not considered as 
proper Korean. However, that movement lost the motivation around late 1990s-
earlier 2000s as technologies were basically exponentially expanding, and most 
of the "purified" words created in earlier days are nearly nowhere to see in 
these days. As an example, one person tried to "purify" the Korean translation 
of Notepad++, using the words proposed around 1990s [1], and the community 
consensus was "reject" stating that these words are not mainstream anymore.

[1] https://github.com/notepad-plus-plus/notepad-plus-plus/pull/7935

I'm afraid that the history repeats itself. When Korean KDE translation was 
not properly maintained in mid 2000s, it used to contain some traces of 
linguistic purism from the past. That was one of the reason for Korean users 
avoiding KDE at that time. Personally, I think KDE is not the place to 
"promote" any kind of linguistic purism (or any other linguistic ideals), but 
rather "reflect the reality" only when it is a mainstream in the said language.

ps.

https://bugs.kde.org/show_bug.cgi?id=404286:
> I wonder why languages like: Ukrainian, Spanish, Catalan, Basque, Serbian,
> Greek, Turkish, Chinese, Korean, Arabic, Hebrew, Punjabi, and probably some
> others translated it differently.

Korean language is not using Latin alphabet as a primary script, and the term 
"OK" as a standard dialog button was translated even before I started using 
computer.

D28924: [SearchStore] Allow querying exact matches for non-properties

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28924

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

Re: Polish translation of "Cancel"

2020-04-17 Thread Łukasz Wojniłowicz

No problem but give me some time. I must schedule that but I'm not sure of 
Luigi's plans in that matter.
--
Łukasz

Dnia piątek, 17 kwietnia 2020 21:56:02 CEST Nate Graham pisze:
> Thanks! When it's done, can you close the bug report or let us know?
> 
> Nate
> 
> On 4/17/20 1:53 PM, Łukasz Wojniłowicz wrote:
> > Nothing. I would do that myself. I see that's the only way to solve this
> > tension.
> > 
> > Dnia piątek, 17 kwietnia 2020 21:26:03 CEST Luigi Toscano pisze:
> >> Let me ask clearly: if I commit the patch from
> >> https://bugs.kde.org/show_bug.cgi?id=404286#c65
> >> 
> >> what will you do?

D28925: [QueryTest] Extend phrase query tests

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28925

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

Re: Polish translation of "Cancel"

2020-04-17 Thread Nate Graham


Thanks! When it's done, can you close the bug report or let us know?

Nate


On 4/17/20 1:53 PM, Łukasz Wojniłowicz wrote:

Nothing. I would do that myself. I see that's the only way to solve this
tension.

Dnia piątek, 17 kwietnia 2020 21:26:03 CEST Luigi Toscano pisze:

Let me ask clearly: if I commit the patch from
https://bugs.kde.org/show_bug.cgi?id=404286#c65

what will you do?

Re: Polish translation of "Cancel"

2020-04-17 Thread Łukasz Wojniłowicz

Nothing. I would do that myself. I see that's the only way to solve this 
tension.

Dnia piątek, 17 kwietnia 2020 21:26:03 CEST Luigi Toscano pisze:
> Let me ask clearly: if I commit the patch from
> https://bugs.kde.org/show_bug.cgi?id=404286#c65
> 
> what will you do?

D28874: Taiwanese holidays

ngraham added a comment.


  Do you not have commit access? I thought you were the maintainer based on the 
repo's history!

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28874

To: shrapnel, #vdg, Zren, winterz
Cc: ngraham, winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28923: Update links in README.md

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  readme (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28923

To: ndavis, #vdg, ngraham
Cc: alex-l, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28925: [QueryTest] Extend phrase query tests

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Add the filename also with the "F" prefix, like the BasicIndexingJob does.
  
  Do a rename operation on one file to also capture the shadowing of
  content by the filename.

TEST PLAN
  ctest -R querytest

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28925

AFFECTED FILES
  autotests/integration/querytest.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D28924: [SearchStore] Allow querying exact matches for non-properties

bruns created this revision.
bruns added reviewers: Baloo, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Exact matches were only possible for prefixed properties, e.g.
  filename=test or tag=test, but content matches were always
  prefix queries. Allow to control the query type, i.e. content=test
  (exact) or content:test (prefix).

TEST PLAN
  $> echo "test" > doc1.txt
  $> echo "testing" > doc2.txt
  $> baloosearch content:test  -> doc1, doc2
  $> baloosearch content=test  -> doc1
  $> baloosearch content=testing  -> doc2

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D28924

AFFECTED FILES
  src/lib/searchstore.cpp

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

Re: Polish translation of "Cancel"

2020-04-17 Thread Grzegorz Szymaszek

Hi,

On Fri, Apr 17, 2020 at 08:31:12PM +0200, Łukasz Wojniłowicz wrote:
> AmigaOS and macOS are both niche OS. The translation was done by
> community. It's just like KDE. It can be considered niche OS and the
> translation is done by community.

But in this case, the community has clearly expressed that’s not the
translation they want.

> The thing is, that some people see this translation as "absurd",
> "invalid", "ancient" and I presume it is so because it's not what
> they've been accustomed to by the mainstream OS, which is Windows.

Again, I feel you are still not convinced that _most_ people see this
translation as “absurd” etc.

New and existing users will complain, they will waste hours reading and
writing new #404286 comments, blog posts, emails, patches, until you
revert the translation. How long are you going to wait?

Regards

-- 
Grzegorz Szymaszek

signature.asc
Description: PGP signature

Re: Polish translation of "Cancel"

2020-04-17 Thread Luigi Toscano

Łukasz Wojniłowicz ha scritto:
>> I think without violating confidentiality, I can say that the CWG has
>> gotten multiple questions about this. I need some information. IF there is
>> a revert of the "ancient term" in to the "consistent" alternative, will
>> there be a revert war?
> 
> That would be another outbreak of violence. There is much of it already here 
> https://bugs.kde.org/show_bug.cgi?id=404286
> 
> 
>> I also do not understand how this one word became a cause worth fighting
>> for.
> 
> For me it's a case of language correctness and purity.
> 
> The correctness is questioned by a linguist at
> https://sjp.pwn.pl/poradnia/haslo/poniechac;7346.html
> 
> One can see that "anuluj" was in fact used by macOS but in context of 
> reverting an action. Screenshots at
> https://aresluna.org/attached/terminology/articles/gryzieniejablek/pics/rys3
> 
> As Konrad Kostecki noted at
> https://marc.info/?l=kde-devel=158697228606229=2
> the alternative translation was also used by AmigaOS. It ranged from 2001 
> till 
> 2016.
> 
> Their dictionary can be downloaded at
> https://ato.exec.pl/files/slownik.lha
> 
> The alternative translation was also used by macOS from 1986 till 2006.
> Their dictionary can be viewed at
> https://aresluna.org/attached/terminology/glossaries/mac
> 
> AmigaOS and macOS are both niche OS. The translation was done by community.
> It's just like KDE. It can be considered niche OS and the translation is done 
> by community.

AmigaOS is a dead OS. macOS (which is not so niche anymore) changed, and that
should be considered as well.

> 
> The thing is, that some people see this translation as "absurd", "invalid", 
> "ancient" and I presume it is so because it's not what they've been 
> accustomed 
> to by the mainstream OS, which is Windows.

That's basically the most accepted translation for that term, sorry. It makes
sense for us to use it, and this has nothing to do with FLOSS and proprietary..


Let me ask clearly: if I commit the patch from
https://bugs.kde.org/show_bug.cgi?id=404286#c65

what will you do?

-- 
Luigi

Re: Polish translation of "Cancel"

2020-04-17 Thread Nate Graham

Apparently the Polish-speaking KDE community does not share your
appreciation for linguistic purity. So you can continue to irritate your
users for the sake of an abstract principle, or you can compromise and
make your users happy.

Personally I don't understand the point of developing software that
knowingly upsets users--especially when there is no benefit to them that
counterbalances the irritation you are imposing (your personal feelings
regarding linguistic purity are not a benefit for your users). Users are
the reason why we do this. If we're not making our users happy, we are
failing, and principles and purity are irrelevant.

I would strongly recommend that you change the translation to be in line
with what your users expect.

Nate

On 4/17/20 12:31 PM, Łukasz Wojniłowicz wrote:

I think without violating confidentiality, I can say that the CWG has
gotten multiple questions about this. I need some information. IF there is
a revert of the "ancient term" in to the "consistent" alternative, will
there be a revert war?

That would be another outbreak of violence. There is much of it already here
https://bugs.kde.org/show_bug.cgi?id=404286

I also do not understand how this one word became a cause worth fighting
for.

For me it's a case of language correctness and purity.

The correctness is questioned by a linguist at
https://sjp.pwn.pl/poradnia/haslo/poniechac;7346.html

One can see that "anuluj" was in fact used by macOS but in context of
reverting an action. Screenshots at
https://aresluna.org/attached/terminology/articles/gryzieniejablek/pics/rys3

As Konrad Kostecki noted at
https://marc.info/?l=kde-devel=158697228606229=2
the alternative translation was also used by AmigaOS. It ranged from 2001 till
2016.

Their dictionary can be downloaded at
https://ato.exec.pl/files/slownik.lha

The alternative translation was also used by macOS from 1986 till 2006.
Their dictionary can be viewed at
https://aresluna.org/attached/terminology/glossaries/mac

AmigaOS and macOS are both niche OS. The translation was done by community.
It's just like KDE. It can be considered niche OS and the translation is done
by community.

The thing is, that some people see this translation as "absurd", "invalid",
"ancient" and I presume it is so because it's not what they've been accustomed
to by the mainstream OS, which is Windows.

--
Łukasz

BTW.
Regarding "ancient term", from your message. It's in fact not ancient. This
term has been used 10 days ago in a press release by the mayor of one of the
greatest Polish city to criticize government in wake of coronavirus. You can
find his quote at
https://epoznan.pl/news-news-104619-prezydent_poznania_o_wyborach_korespondencyjnych_to_co_sie_teraz_dzieje_jest_zbrodnia_na_narodzie

Exact word is "zaniechanie" which is another conjugation of "zaniechaj". The
man is 56 years old and still works, so he's not ancient in my opinion.

Dnia piątek, 17 kwietnia 2020 07:39:42 CEST Valorie Zimmerman pisze:

On 4/16/20 1:13 AM, Łukasz Wojniłowicz wrote:

I would like to solve the tension, that rose around the translation of
"cancel".
Is there really no one, who thinks, that translated "zaniechaj" is worth
keeping?

I don't know Polish so I can't comment on the technical correctness of
the word in question, but in disputes like this I find that it's
generally important to pay attention to the group consensus. IMO it's
usually better to compromise and accommodate the group rather than
ignore it and cause friction.

Nate

D28891: Nicaragua Holidays

winterz accepted this revision.
winterz added a comment.
This revision is now accepted and ready to land.


  other than the indentation in the .qrc file this is good to go.. tests pass
  
  would appreciate if someone would commit this for us.  (after fixing the 
indentation)

REPOSITORY
  R175 KHolidays

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28891

To: carguello, winterz, #frameworks
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns

D28874: Taiwanese holidays

winterz accepted this revision.
winterz added a comment.
This revision is now accepted and ready to land.


  looks good.  all tests pass.
  
  could someone commit this for us?

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28874

To: shrapnel, #vdg, Zren, winterz
Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Polish translation of "Cancel"

2020-04-17 Thread Łukasz Wojniłowicz

> I think without violating confidentiality, I can say that the CWG has
> gotten multiple questions about this. I need some information. IF there is
> a revert of the "ancient term" in to the "consistent" alternative, will
> there be a revert war?

That would be another outbreak of violence. There is much of it already here 
https://bugs.kde.org/show_bug.cgi?id=404286

> I also do not understand how this one word became a cause worth fighting
> for.

For me it's a case of language correctness and purity.

The correctness is questioned by a linguist at
https://sjp.pwn.pl/poradnia/haslo/poniechac;7346.html

One can see that "anuluj" was in fact used by macOS but in context of 
reverting an action. Screenshots at
https://aresluna.org/attached/terminology/articles/gryzieniejablek/pics/rys3

As Konrad Kostecki noted at
https://marc.info/?l=kde-devel=158697228606229=2
the alternative translation was also used by AmigaOS. It ranged from 2001 till 
2016.

Their dictionary can be downloaded at
https://ato.exec.pl/files/slownik.lha

The alternative translation was also used by macOS from 1986 till 2006.
Their dictionary can be viewed at
https://aresluna.org/attached/terminology/glossaries/mac

AmigaOS and macOS are both niche OS. The translation was done by community.
It's just like KDE. It can be considered niche OS and the translation is done 
by community.

The thing is, that some people see this translation as "absurd", "invalid", 
"ancient" and I presume it is so because it's not what they've been accustomed 
to by the mainstream OS, which is Windows.

--
Łukasz

BTW.
Regarding "ancient term", from your message. It's in fact not ancient. This 
term has been used 10 days ago in a press release by the mayor of one of the 
greatest Polish city to criticize government in wake of coronavirus. You can 
find his quote at
https://epoznan.pl/news-news-104619-prezydent_poznania_o_wyborach_korespondencyjnych_to_co_sie_teraz_dzieje_jest_zbrodnia_na_narodzie

Exact word is "zaniechanie" which is another conjugation of "zaniechaj". The 
man is 56 years old and still works, so he's not ancient in my opinion.

Dnia piątek, 17 kwietnia 2020 07:39:42 CEST Valorie Zimmerman pisze:
> On 4/16/20 1:13 AM, Łukasz Wojniłowicz wrote:
> > I would like to solve the tension, that rose around the translation of
> > "cancel".
> > Is there really no one, who thinks, that translated "zaniechaj" is worth
> > keeping?
> 
> I don't know Polish so I can't comment on the technical correctness of
> the word in question, but in disputes like this I find that it's
> generally important to pay attention to the group consensus. IMO it's
> usually better to compromise and accommodate the group rather than
> ignore it and cause friction.
> 
> Nate

D28923: Update links in README.md

2020-04-17 Thread Noah Davis

ndavis added a subscriber: alex-l.
ndavis added inline comments.

INLINE COMMENTS

> ngraham wrote in README.md:22
> Should we mention this? Is it still a thing?

It hasn't been used much for quite a while, but I don't think @alex-l would 
like it if we didn't include it. I'm in there, so at least anyone who joins 
won't be completely alone.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28923

To: ndavis, #vdg
Cc: alex-l, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28701: Add KPackage support to KNewStuffCore

2020-04-17 Thread Dan Leinir Turthra Jensen

leinir added a comment.

  In D28701#650616 , @ngraham wrote:

  > Thanks, the hang is gone now. However I have a new problem:
  >
  > 1. Open Global Themes KCM and click new new global themes
  > 2. Install Sweet KDE and McMojave LAF global themes
  > 3. Close the GHNS dialog
  > 4. Open the dialog again
  > 5. Uninstall the McMojave LAF theme
  > 6. Close the dialog
  >
  >   Both McMojave LAF and also Sweet KDE have disappeared from the KCM. Sweet 
KDE still shows up as installed in the GHNS dialog and Discover, but does not 
appear in the KCM.
  >
  >   The same thing happens for plasma themes too. It seems that deleting one 
item from the GHNS dialog marks all of the installed GHNS items of that type as 
deleted.

  i can confirm this, and looking at it a bit with some debug output i have a 
suspicion that i might be holding some part of kpackage's api incorrectly... 
Perhaps someone with a longer experience with KPackage than me can tell me 
whether that is the case perhaps?

org.kde.knewstuff.core: Install:  "Sweet KDE"  from  
"/tmp/AfOprO-Sweet.tar.xz"
org.kde.knewstuff.core: installdir:  "/tmp"
org.kde.knewstuff.core: Using KPackage for installation
org.kde.knewstuff.core: Package metadata is valid
org.kde.knewstuff.core: Service type discovered as "Plasma/Theme"
org.kde.knewstuff.core: About to attempt to install "Sweet" into 
"/home/leinir/.local/share/plasma/desktoptheme/"
org.kde.knewstuff.core: Attempting to perform an installation operation of 
type 2 on the package "/tmp/AfOprO-Sweet.tar.xz" of type "Plasma/Theme" in the 
package root "/home/leinir/.local/share/plasma/desktoptheme/"
org.kde.knewstuff.core: Service type understood
org.kde.knewstuff.core: Installer successfully created and has a valid 
structure
kf5.kpackage: Generated  
"/home/leinir/.local/share/plasma/desktoptheme//kpluginindex.json"  ( 2  
plugins)
org.kde.knewstuff.core: Created job, now let's wait for it to do its 
thing...
org.kde.knewstuff.core: Install job finished with no error and we now have 
files "/home/leinir/.local/share/plasma/desktoptheme/Sweet"
org.kde.knewstuff.core: Write registry
org.kde.knewstuff.core: about to uninstall entry  "1294174"
org.kde.knewstuff.core: Attempting to perform an installation operation of 
type 3 on the package "/home/leinir/.local/share/plasma/desktoptheme/Sweet" of 
type "Plasma/Theme" in the package root 
"/home/leinir/.local/share/plasma/desktoptheme/"
org.kde.knewstuff.core: Service type understood
org.kde.knewstuff.core: Installer successfully created and has a valid 
structure
org.kde.knewstuff.core: Created job, now let's wait for it to do its 
thing...
org.kde.knewstuff.core: Write registry
org.kde.knewstuff.core: about to uninstall entry  "1305006"
org.kde.knewstuff.core: Write registry

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28701

To: leinir, #plasma, #knewstuff, #frameworks, ngraham, mart, davidedmundson, 
broulik, bshah
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28874: Taiwanese holidays

2020-04-17 Thread Ricky Lindén

shrapnel updated this revision to Diff 80415.
shrapnel added a comment.


  Removed patch-file

REPOSITORY
  R175 KHolidays

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28874?vs=80346=80415

REVISION DETAIL
  https://phabricator.kde.org/D28874

AFFECTED FILES
  holidays/holidays.qrc
  holidays/plan2/holiday_tw_zh

To: shrapnel, #vdg, Zren, winterz
Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28923: Update links in README.md

ngraham added inline comments.

INLINE COMMENTS

> README.md:22
> +- The VDG Telegram room: 
> +- The Breeze Icons Telegram room: 
> +- The visual-des...@kde.org mailing list: 
> 

Should we mention this? Is it still a thing?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28923

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28701: Add KPackage support to KNewStuffCore

ngraham added a comment.


  Thanks, the hang is gone now. However I have a new problem:
  
  1. Open Global Themes KCM and click new new global themes
  2. Install Sweet KDE and McMojave LAF global themes
  3. Close the GHNS dialog
  4. Open the dialog again
  5. Uninstall the McMojave LAF theme
  6. Close the dialog
  
  Both McMojave LAF and also Sweet KDE have disappeared from the KCM. Sweet KDE 
still shows up as installed in the GHNS dialog and Discover, but does not 
appear in the KCM.
  
  The same thing happens for plasma themes too. It seems that deleting one item 
from the GHNS dialog marks all of the installed GHNS items of that type as 
deleted.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28701

To: leinir, #plasma, #knewstuff, #frameworks, ngraham, mart, davidedmundson, 
broulik, bshah
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28923: Update links in README.md

2020-04-17 Thread Noah Davis

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  - Change the HIG link to hig.kde.org
  - Changed the bugtracker link to include the icons component
  - Changed the contact links to include all VDG chat rooms
  - Slightly changed the wording

REPOSITORY
  R266 Breeze Icons

BRANCH
  readme (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28923

AFFECTED FILES
  README.md

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 420 - Still Unstable!

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/420/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 17 Apr 2020 17:18:42 +
 Build duration:
3 min 16 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.70.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512 Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_pagerouter.qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)47%
(16/34)47%
(16/34)46%
(1665/3634)31%
(748/2413)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(1/1)100%
(1/1)100%
(1/1)100%
(0/0)examples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src63%
(12/19)63%
(12/19)45%
(1193/2666)31%
(529/1698)src.libkirigami50%
(3/6)50%
(3/6)73%
(471/647)39%
(219/567)src.scenegraph0%
(0/7)0%
(0/7)0%
(0/312)0%
(0/148)

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.14 - Build # 23 - Still Unstable!

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.14/23/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 17 Apr 2020 17:18:42 +
 Build duration:
2 min 55 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.70.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514 Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514.autotests.tst_pagerouter.qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)47%
(16/34)47%
(16/34)46%
(1665/3634)31%
(748/2413)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(1/1)100%
(1/1)100%
(1/1)100%
(0/0)examples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src63%
(12/19)63%
(12/19)45%
(1193/2666)31%
(529/1698)src.libkirigami50%
(3/6)50%
(3/6)73%
(471/647)39%
(219/567)src.scenegraph0%
(0/7)0%
(0/7)0%
(0/312)0%
(0/148)

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 27 - Still Unstable!

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/27/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 17 Apr 2020 17:18:42 +
 Build duration:
1 min 21 sec and counting
   JUnit Tests
  Name: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt514 Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt514.autotests.tst_pagerouter.qml

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80411.
apol added a comment.


  Include the server side and some renames

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28882?vs=80284=80411

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28882

AFFECTED FILES
  src/client/CMakeLists.txt
  src/client/protocols/screencast.xml
  src/client/screencasting.cpp
  src/client/screencasting.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28882: Create protocol to manage video feeds

apol marked 2 inline comments as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28882

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28919: Drop delayed second phase

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Makes sense, sounds like the second phase is quite arbitrary there.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D28919

To: broulik, #plasma, dfaure, davidedmundson, apol
Cc: apol, kde-frameworks-devel, davidedmundson, LeGast00n, cblack, michaelh, 
ngraham, bruns

D28874: Taiwanese holidays

winterz added a comment.


  remove holidays/0001-added-holiday_tw_zh-and-updated-holiday.qrc.patch

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28874

To: shrapnel, #vdg, Zren, winterz
Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28891: Nicaragua Holidays

winterz added inline comments.

INLINE COMMENTS

> holidays.qrc:101
>  plan2/holiday_mx_es
> -plan2/holiday_na_en-gb
> + plan2/holiday_na_en-gb
>  plan2/holiday_nc_fr

realign the indentation

> holidays.qrc:103
>  plan2/holiday_nc_fr
> + plan2/holiday_ni_es
>  plan2/holiday_nl_nl

realign the indentation

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28891

To: carguello, winterz, #frameworks
Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns

D28892: [autotests] Optimistic attempt to fix RemoteAccessTest reilability

2020-04-17 Thread David Edmundson

davidedmundson added a comment.


  > This seems super complicated.
  
  It is :D

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28892

To: davidedmundson, #kwin, zzag
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.12 - Build # 125 - Fixed!

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.12/125/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 17 Apr 2020 14:02:21 +
 Build duration:
6 min 10 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.70.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 47 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(244/272)90%
(244/272)85%
(27731/32764)53%
(11162/20991)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12615/12687)50%
(6631/13155)autotests.server100%
(6/6)100%
(6/6)99%
(518/521)50%
(233/468)src.client96%
(73/76)96%
(73/76)85%
(6345/7479)65%
(1837/2834)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(120/126)95%
(120/126)83%
(8172/9797)63%
(2461/3903)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 10 - Still Unstable!

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/10/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 17 Apr 2020 14:02:21 +
 Build duration:
6 min 30 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 12 test(s), Passed: 31 test(s), Skipped: 0 test(s), Total: 43 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

D28892: [autotests] Optimistic attempt to fix RemoteAccessTest reilability

2020-04-17 Thread David Edmundson

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:1b1412943b6b: [autotests] Optimistic attempt to fix 
RemoteAccessTest reilability (authored by davidedmundson).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28892?vs=80312=80390

REVISION DETAIL
  https://phabricator.kde.org/D28892

AFFECTED FILES
  autotests/client/test_remote_access.cpp

To: davidedmundson, #kwin, zzag
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28919: Drop delayed second phase

2020-04-17 Thread David Edmundson

davidedmundson added a comment.


  > @davidedmundson did some bootchart that showed startup is actually faster 
without this
  
  It was probably just noise as it wasn't a full average of N tests, just 2 
clean boots.  However ksplash removed 100ms earlier. I can attach if needed.
  
  As for the patch, +1

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D28919

To: broulik, #plasma, dfaure, davidedmundson
Cc: kde-frameworks-devel, davidedmundson, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28919: Drop delayed second phase

2020-04-17 Thread Kai Uwe Broulik

broulik created this revision.
broulik added reviewers: Plasma, dfaure, davidedmundson.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  kded runs Phase 0 and Phase 1 on startup and then plasma-session Startup 
calls Phase 2 somewhere around the end of startup.
  Investigation and testing shows this has little effect on startup, if any, 
makes it slower.
  More importantly, it complicates startup and makes it harder to recreate the 
startup sequence as systemd units.

TEST PLAN
  - All services are still started
  - @davidedmundson did some bootchart that showed startup is actually 
//faster// without this
  
  Also refer to my lovely table of services we start: T12616 


REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D28919

AFFECTED FILES
  src/kded.cpp
  src/kded.h
  src/kdedadaptor.h

To: broulik, #plasma, dfaure, davidedmundson
Cc: kde-frameworks-devel, davidedmundson, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28355: Introduce function ecm_install_configured_file

apol added a comment.


  Are we stuck somewhere? The patch looks good to me.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D28355

To: davidedmundson
Cc: apol, kossebau, pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
cblack, bencreasy, michaelh, ngraham, bruns

D28128: Add force save behavior to KEntryMap

2020-04-17 Thread Benjamin Port

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:be28e096c533: Add force save behavior to KEntryMap 
(authored by bport).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28128?vs=78861=80383

REVISION DETAIL
  https://phabricator.kde.org/D28128

AFFECTED FILES
  autotests/kconfigtest.cpp
  autotests/kconfigtest.h
  src/core/kconfigdata.cpp
  src/core/kconfigdata.h
  src/core/kconfigini.cpp

To: bport, ervin, dfaure, meven, crossi, hchain
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Polish translation of "Cancel"

2020-04-17 Thread Boudhayan Gupta

Hi,

On Fri, 17 Apr 2020 at 13:07, Luigi Toscano 
wrote:

> Please note that, given that Polish has declensions, a patch from a native
> speaker was needed (a simple search wouldn't have worked). A patch was
> provided two days ago only.
>

I noticed that on the bug report. I also noticed that there were real
usability bugs stemming from the use of the "more correct" term, if I may
say so. So great, now that we have a patch let's merge it!

I simply cannot comment on which word is more appropriate. All I see are
the following:

1. We switched to using a word that isn't used by any other computer
software in regular usage.
2. This caused people to get confused, including causing people to misclick
buttons and lose work (they thought the button was for saving).

Whichever word is more correct notwithstanding, one of them is an industry
standard, and use of the other word causes people real problems.

KDE is also not the place to teach people the finer differences between
almost-synonyms. Native speakers who also actually use software in Polish
can have this argument amongst themselves, and once they have a clear
decision (with or without support from the CWG as requested), they can
change this word. For the time being, without there being clear consensus,
we should be sticking to the industry standard.

Thanks,
Boudhayan

Re: Polish translation of "Cancel"

2020-04-17 Thread Luigi Toscano

Boudhayan Gupta ha scritto:
> Hi,
> 
> This discussion has gone on for two days, which is two more days than is
> necessary in my opinion because I believe as people who do not speak Polish,
> we (anybody in this thread who does not speak Polish, including but not
> limited to me, Nate, Valorie, etc) have absolutely zero authority to be a
> gatekeeper to this issue.
> 
> Right now, what we can see is that an overwhelming number of Polish users are
> complaining about the current status quo. In good faith, I think the best
> course of action to take will be to change the word in question without
> further undue delay. 

Please note that, given that Polish has declensions, a patch from a native
speaker was needed (a simple search wouldn't have worked). A patch was
provided two days ago only.

-- 
Luigi

D28910: [KFileBookMarkHandler] Port to new KBookmarkMenu-5.69

ahmadsamir added a comment.


  Though maybe I should add a comment about the action collection, if the 
kfiledialog ever grows a shortcuts editor dialog, those actions will be 
missing, and tracking down the issue mightn't be that easy...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28910

To: ahmadsamir, #frameworks, dfaure, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Polish translation of "Cancel"

2020-04-17 Thread Boudhayan Gupta

Hi,

This discussion has gone on for two days, which is two more days than is
necessary in my opinion because I believe as people who do not speak
Polish, we (anybody in this thread who does not speak Polish, including but
not limited to me, Nate, Valorie, etc) have absolutely zero authority to be
a gatekeeper to this issue.

Right now, what we can see is that an overwhelming number of Polish users
are complaining about the current status quo. In good faith, I think the
best course of action to take will be to change the word in question
without further undue delay. If there is a "revert war", this will be a
bridge we will cross if we come to that. It is also a bridge, that in my
opinion only the Polish translation team will have the authority to cross.
I think in this situation, we should only be there to lend help if the
Polish translators expressly ask for it. Even without the special
linguistic circumstances in play here, language in Europe is a sensitive
subject, and non-speakers arbitrating over a linguistic issue is more
likely to be seen as an insult.

Thanks,
Boudhayan

On Fri, 17 Apr 2020 at 12:09, Michal Policht  wrote:

> Hi,
>
> Majority of software uses "Anuluj".  As Konrad pointed out "Zaniechaj"
> is more or less a synonym, but it is odd, freaky choice... It affects
> user experience in a negative way, because eyes naturally look for a
> familiar "Anuluj" button.
>
> Regards
> Michał
>
>
> > [+ kde-devel mailing list since I don't know if I got the right
> > localization mailing list and couldn't find a polish-specific one]
> >
> >
> > Hello translators,
> > I don't speak any Polish, but it's come to my attention that some
> > native Polish speakers are complaining about the Polish translation of
> > the word "Cancel", with no resolution on the issue:
> > https://bugs.kde.org/show_bug.cgi?id=404286
> >
> > The bug has 150 votes and a lot of discussion. I think there's a
> > fairly strong argument in favor of consistency. Given that consistency
> > was even selected as an explicit KDE goal this year, my sense is that
> > it would be good to be consistent with the translation used by the
> > wider software world, even if it's maybe not perfect.
> >
> > However not being familiar with the language, I thought I would bring
> > up the subject here for wider visibility.
> >
> > Nate
>
>
>

D28910: [KFileBookMarkHandler] Port to new KBookmarkMenu-5.69

ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, nicolasfella.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Use new KBookMarkMenu ctor that doesn't take a KActionCollection parameter;
  AFAICS there's no need to add the KBookMarkMenu actions to the 
actionCollection
  here because there's no shortcuts editor dialog for KFileDialog/Widget.
  
  Remove an old comment from kfilebookmarkhandler_p.h, it has been tested
  and it seems to work.

TEST PLAN
  - make && ctest
  - The bookmarks menu in the KDE open file dialog still works

REPOSITORY
  R241 KIO

BRANCH
  l-kbookmark (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28910

AFFECTED FILES
  src/filewidgets/kfilebookmarkhandler.cpp
  src/filewidgets/kfilebookmarkhandler_p.h

To: ahmadsamir, #frameworks, dfaure, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28909: smb: port to Result system to force serialization of error/finish condition

2020-04-17 Thread Harald Sitter

sitter created this revision.
sitter added a reviewer: dfaure.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  the Result system was originally introduced to the FTP slave and now also
  makes an appearance in the SMB slave. the system introduces a separation
  between logic and fronting API class to more tightly control when state
  changing calls (finished()/error()) are made. since these calls may only
  be made once during a given command multiple calls are at the very least
  indicative of bad code and at worst cause severe state confusion for the
  slavebase that it won't be able to recover from, rendering the slave
  instance broken.
  
  in the internal class Results are returned whenever an error can appear and
  these Results must be handled in some form. the only way to effectively
  produce user visible errors is to forward results up the call chain.
  
  this is also introducing scopeguards for file descriptors to simplify
  error condition returning (i.e. not having to worry about closing the fd
  manually). as a result we now require Qt 5.12 (which we do via KF5.66
  anyway, albeit implicitly)

TEST PLAN
  - copy, lots and lots of copy
  - rename
  - delete

REPOSITORY
  R320 KIO Extras

BRANCH
  smb-result

REVISION DETAIL
  https://phabricator.kde.org/D28909

AFFECTED FILES
  CMakeLists.txt
  smb/kio_smb.cpp
  smb/kio_smb.h
  smb/kio_smb_auth.cpp
  smb/kio_smb_browse.cpp
  smb/kio_smb_config.cpp
  smb/kio_smb_dir.cpp
  smb/kio_smb_file.cpp
  smb/kio_smb_mount.cpp

To: sitter, dfaure
Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, 
fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, meven, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, 
emmanuelp, rdieter, mikesomov

D28701: Add KPackage support to KNewStuffCore

2020-04-17 Thread Dan Leinir Turthra Jensen

leinir added reviewers: broulik, bshah.
leinir added a comment.


  Tagging in a couple of people who were in the original chat about doing this 
integration... :)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D28701

To: leinir, #plasma, #knewstuff, #frameworks, ngraham, mart, davidedmundson, 
broulik, bshah
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

Re: Polish translation of "Cancel"

2020-04-17 Thread Michal Policht

Hi,

Majority of software uses "Anuluj".  As Konrad pointed out "Zaniechaj"
is more or less a synonym, but it is odd, freaky choice... It affects
user experience in a negative way, because eyes naturally look for a
familiar "Anuluj" button.

Regards
Michał


> [+ kde-devel mailing list since I don't know if I got the right
> localization mailing list and couldn't find a polish-specific one]
>
>
> Hello translators,
> I don't speak any Polish, but it's come to my attention that some
> native Polish speakers are complaining about the Polish translation of
> the word "Cancel", with no resolution on the issue:
> https://bugs.kde.org/show_bug.cgi?id=404286
>
> The bug has 150 votes and a lot of discussion. I think there's a
> fairly strong argument in favor of consistency. Given that consistency
> was even selected as an explicit KDE goal this year, my sense is that
> it would be good to be consistent with the translation used by the
> wider software world, even if it's maybe not perfect.
>
> However not being familiar with the language, I thought I would bring
> up the subject here for wider visibility.
>
> Nate

D28901: Add KIO::StatRecursiveSize detail value so kio_trash only does this on demand

dfaure added inline comments.

INLINE COMMENTS

> meven wrote in global.h:323
> I don't think we should assume that, it defeats quite the purpose.
> For instance even if we the ioslave gets the filename or type for its needs 
> it may just not include it in the UDSEntry if StatBasic was not passed.

There are bugs in the current kio_file implementation if StatBasic isn't set.

  mode_t type = 0;
  if (details & KIO::StatBasic) {
  ... code that sets type ...
  }
  if (details & KIO::StatAcl) {
  appendACLAtoms(targetPath, entry, type); // oops type is 0
  }

Hmm I thought I saw more, but now I don't see more (must have been fixed 
meanwhile). If you fix the bug I'm happy to remove the comment, LOL.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28901

To: dfaure, meven, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

2020-04-17 Thread Roman Gilg

romangg added inline comments.

INLINE COMMENTS

> screencast.xml:8
> +  ]]>
> +
> +

Interface names should be scoped too. Example 
.

Don't ask me why exactly why. I think it has something to do with the C structs 
becoming ambiguous otherwise. Someone else knows?

But in any case I would follow the examples set by upstream.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28882

To: apol, #kwin, jgrulich
Cc: romangg, zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, 
bruns

D28882: Create protocol to manage video feeds

2020-04-17 Thread Jan Grulich

jgrulich added inline comments.

INLINE COMMENTS

> screencast.xml:13
> +
> +
> +

Can we switch the values to follow xdg-desktop-portal specification?

See 
https://github.com/flatpak/xdg-desktop-portal/blob/master/data/org.freedesktop.impl.portal.ScreenCast.xml#L168.

Even not following the specs, output will be the most used one.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D28882

To: apol, #kwin, jgrulich
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.14 - Build # 22 - Still Unstable!

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.14/22/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 17 Apr 2020 08:17:54 +
 Build duration:
2 min 43 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.70.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514 Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514.autotests.tst_pagerouter.qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)47%
(16/34)47%
(16/34)46%
(1665/3634)31%
(748/2413)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(1/1)100%
(1/1)100%
(1/1)100%
(0/0)examples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src63%
(12/19)63%
(12/19)45%
(1193/2666)31%
(529/1698)src.libkirigami50%
(3/6)50%
(3/6)73%
(471/647)39%
(219/567)src.scenegraph0%
(0/7)0%
(0/7)0%
(0/312)0%
(0/148)

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 419 - Still Unstable!

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/419/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 17 Apr 2020 08:17:54 +
 Build duration:
2 min 0 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.70.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512 Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_pagerouter.qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)47%
(16/34)47%
(16/34)46%
(1665/3634)31%
(748/2413)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(1/1)100%
(1/1)100%
(1/1)100%
(0/0)examples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src63%
(12/19)63%
(12/19)45%
(1193/2666)31%
(529/1698)src.libkirigami50%
(3/6)50%
(3/6)73%
(471/647)39%
(219/567)src.scenegraph0%
(0/7)0%
(0/7)0%
(0/312)0%
(0/148)

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 26 - Still Unstable!

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/26/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 17 Apr 2020 08:17:54 +
 Build duration:
51 sec and counting
   JUnit Tests
  Name: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt514 Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt514.autotests.tst_pagerouter.qml

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.14 - Build # 21 - Still Unstable!

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.14/21/
 Project:
kf5-qt5 SUSEQt5.14
 Date of build:
Fri, 17 Apr 2020 08:03:09 +
 Build duration:
5 min 21 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.70.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514 Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt514.autotests.tst_pagerouter.qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)47%
(16/34)47%
(16/34)46%
(1665/3634)31%
(748/2413)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(1/1)100%
(1/1)100%
(1/1)100%
(0/0)examples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src63%
(12/19)63%
(12/19)45%
(1193/2666)31%
(529/1698)src.libkirigami50%
(3/6)50%
(3/6)73%
(471/647)39%
(219/567)src.scenegraph0%
(0/7)0%
(0/7)0%
(0/312)0%
(0/148)

D28901: Add KIO::StatRecursiveSize detail value so kio_trash only does this on demand

meven requested changes to this revision.
meven added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> global.h:323
>  StatNoDetails = 0x0,
> -/// Filename, access, type, size, linkdest
> +/// Filename, access, type, size, linkdest -- necessary for all others 
> below
>  StatBasic = 0x1,

I don't think we should assume that, it defeats quite the purpose.
For instance even if we the ioslave gets the filename or type for its needs it 
may just not include it in the UDSEntry if StatBasic was not passed.

> meven wrote in trashimpl.cpp:1105
> Maybe, check for `details & KIO::StatTime`
> Down the rabbit hole...

(I don't expect it)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28901

To: dfaure, meven, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 418 - Still Unstable!

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/418/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 17 Apr 2020 08:03:09 +
 Build duration:
1 min 56 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Kirigami2-5.70.0.xmlcompat_reports/KF5Kirigami2_compat_report.htmllogs/KF5Kirigami2/5.70.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512 Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectroot.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_SUSEQt512.autotests.tst_pagerouter.qml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)47%
(16/34)47%
(16/34)46%
(1665/3634)31%
(748/2413)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(1/1)100%
(1/1)100%
(1/1)100%
(0/0)examples.applicationitemapp0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src63%
(12/19)63%
(12/19)45%
(1193/2666)31%
(529/1698)src.libkirigami50%
(3/6)50%
(3/6)73%
(471/647)39%
(219/567)src.scenegraph0%
(0/7)0%
(0/7)0%
(0/312)0%
(0/148)

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 25 - Still Unstable!

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/25/
 Project:
kf5-qt5 FreeBSDQt5.14
 Date of build:
Fri, 17 Apr 2020 08:03:09 +
 Build duration:
54 sec and counting
   JUnit Tests
  Name: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt514 Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: projectroot.usr.home.jenkins.workspace.Frameworks.kirigami.kf5-qt5_FreeBSDQt514.autotests.tst_pagerouter.qml

D28901: Add KIO::StatRecursiveSize detail value so kio_trash only does this on demand

meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.


  So we are gonna need a patch to baloo-widget stat, with 
`KIO::StatRecursiveSize`
  A test would nice for trash:/ with `KIO::StatRecursiveSize`

INLINE COMMENTS

> trashimpl.cpp:1105
> -
> -entry.fastInsert(KIO::UDSEntry::UDS_MODIFICATION_TIME, 
> latestModifiedDate / 1000);
> -// access date is unreliable for the trash folder, use the modified date 
> instead

Maybe, check for `details & KIO::StatTime`
Down the rabbit hole...

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28901

To: dfaure, meven, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28902: CopyJob: when stat'ing the dest, use StatBasic.

meven added a comment.


  I believe that's just fine but the comment could be updated :
  From udsentry.h
  
/// A local file path if the ioslave display files sitting
/// on the local filesystem (but in another hierarchy, e.g. settings:/ or 
remote:/)
UDS_LOCAL_PATH
  
  So the `settings:/` , `remote:/` should return UDS_LOCAL_PATH for 
KIO::StatBasic, but file:/ should not .
  The code here uses UDS_LOCAL_PATH when present only and does not require it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28902

To: dfaure, meven
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28902: CopyJob: when stat'ing the dest, use StatBasic.