Re: Patch test with several minor dialog alignment fixes
On 25/12/2018 18:20, Jürgen Spitzmüller wrote: Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel: Thanks. But the buttons are misaligned now (see attachment). Try again with recent master. Jürgen I'll give up. It was fun. Daniel
Re: Patch test with several minor dialog alignment fixes
On 25/12/2018 16:29, Jürgen Spitzmüller wrote: Am Dienstag, den 25.12.2018, 13:56 +0100 schrieb Daniel: Did you check whether those not on the list do actually have GBs? Yes. Daniel And some are missing from your list, like FindAndReplaceUi.ui. Thanks, added. Jürgen Okay, I'll give in. Daniel
Re: Patch test with several minor dialog alignment fixes
Am Dienstag, den 25.12.2018, 12:35 +0100 schrieb Jürgen Spitzmüller: > Am Montag, den 24.12.2018, 22:11 +0100 schrieb Daniel: > > Thanks. But I like mine more (see attached screen shot). > > I don't see the misalignment in your screenshot here on Linux. But I > saw a misalignment with your patch. It maybe depends on the Qt style. Try again with recent master. Jürgen signature.asc Description: This is a digitally signed message part
Re: Patch test with several minor dialog alignment fixes
Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel: > Thanks. But the buttons are misaligned now (see attachment). Try again with recent master. Jürgen signature.asc Description: This is a digitally signed message part
Re: Patch test with several minor dialog alignment fixes
Am Dienstag, den 25.12.2018, 13:56 +0100 schrieb Daniel: > > Did you check whether those not on the list do actually have GBs? Yes. > > > > Daniel > > And some are missing from your list, like FindAndReplaceUi.ui. Thanks, added. Jürgen signature.asc Description: This is a digitally signed message part
Re: Patch test with several minor dialog alignment fixes
Am Dienstag, den 25.12.2018, 13:43 +0100 schrieb Daniel: > > I am probably confused. Do you ask me to recreate my patch with > current > master Yes, please. > which you successfully applied before and found to be misaligned? Yes. Thanks Jürgen > > Daniel > signature.asc Description: This is a digitally signed message part
Re: Patch test with several minor dialog alignment fixes
On 25/12/2018 14:10, Daniel wrote: On 25/12/2018 12:51, Daniel wrote: On 25/12/2018 12:26, Jürgen Spitzmüller wrote: Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel: Thanks. But the buttons are misaligned now (see attachment). Not for me (see attachment). * the Cancel button needs to go on a line of its own. I understand that this is a general rule of dialogs in LyX. However, please consider an exception to this rule for the quick search and replace dialog. No. That's hard to reason with. All apps I checked have the checkboxes aligned to minimize space. BTW your patch (in the following message) does not apply to master. If you remove your patch it should apply fine. Merry Christmas Jürgen Merry Christmas to you too! Daniel I really like your critical approach. I think it is beneficial for the development of LyX. But I hope you understand that I question something if I have seen it differently in many other parts of or up until now in LyX or in many other applications. And if I put my work and thought into something, then it leaves me frustrated when I get a "Thanks, but no." without further explanation. Maybe you don't have time to explain things but please say so if that is the case, then I can make a decision of whether something is worth my possible frustration. It might also be beneficial to clarify what the rules are. For example, If it is best practice to put button boxes at the bottom of a dialog, then if a dialog has a button box it has to be at the bottom. If that is the rule LyX by which you operate, then I can understand your reaction. Though I strongly disagree with the rule since best practices should be broken for good reasons. I can also understand that you don't explain your decision against something if no reason has been given in favour of it. It might be too time consuming to explain everything proactively. I hope clarifying this will help. Daniel If it is best practice to put button boxes at the bottom of a dialog, then if a dialog has a button box it has to be at the bottom. To directly apply to the current problem it should have said, If it is best practice to put button boxes in their own line, then if a dialog has a button box it has to be at in its own line. Daniel
Re: Patch test with several minor dialog alignment fixes
On 25/12/2018 12:51, Daniel wrote: On 25/12/2018 12:26, Jürgen Spitzmüller wrote: Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel: Thanks. But the buttons are misaligned now (see attachment). Not for me (see attachment). * the Cancel button needs to go on a line of its own. I understand that this is a general rule of dialogs in LyX. However, please consider an exception to this rule for the quick search and replace dialog. No. That's hard to reason with. All apps I checked have the checkboxes aligned to minimize space. BTW your patch (in the following message) does not apply to master. If you remove your patch it should apply fine. Merry Christmas Jürgen Merry Christmas to you too! Daniel I really like your critical approach. I think it is beneficial for the development of LyX. But I hope you understand that I question something if I have seen it differently in many other parts of or up until now in LyX or in many other applications. And if I put my work and thought into something, then it leaves me frustrated when I get a "Thanks, but no." without further explanation. Maybe you don't have time to explain things but please say so if that is the case, then I can make a decision of whether something is worth my possible frustration. It might also be beneficial to clarify what the rules are. For example, If it is best practice to put button boxes at the bottom of a dialog, then if a dialog has a button box it has to be at the bottom. If that is the rule LyX by which you operate, then I can understand your reaction. Though I strongly disagree with the rule since best practices should be broken for good reasons. I can also understand that you don't explain your decision against something if no reason has been given in favour of it. It might be too time consuming to explain everything proactively. I hope clarifying this will help. Daniel
Re: Patch test with several minor dialog alignment fixes
On 25/12/2018 13:46, Daniel wrote: On 25/12/2018 13:22, Jürgen Spitzmüller wrote: Am Dienstag, den 25.12.2018, 12:40 +0100 schrieb Daniel: It is not that only some of the GBs are out of line. Almost all are non-flat. I count only a minority where the flat designation was missing. Namely src/frontends/qt4/ui/CharacterUi.ui src/frontends/qt4/ui/CitationUi.ui src/frontends/qt4/ui/CompareUi.ui src/frontends/qt4/ui/ExternalUi.ui src/frontends/qt4/ui/FloatPlacementUi.ui src/frontends/qt4/ui/IncludeUi.ui src/frontends/qt4/ui/LaTeXUi.ui src/frontends/qt4/ui/ListingsUi.ui src/frontends/qt4/ui/MathMatrixUi.ui src/frontends/qt4/ui/PhantomUi.ui src/frontends/qt4/ui/PrefConvertersUi.ui src/frontends/qt4/ui/ProgressViewUi.ui src/frontends/qt4/ui/TabularUi.ui Jürgen Did you check whether those not on the list do actually have GBs? Daniel And some are missing from your list, like FindAndReplaceUi.ui. Even though it looks a bit ugly on Windows. I won't fight for this. Maybe it looks better on other systems, I couldn't tell. Daniel
Re: Patch test with several minor dialog alignment fixes
On 25/12/2018 13:22, Jürgen Spitzmüller wrote: Am Dienstag, den 25.12.2018, 12:40 +0100 schrieb Daniel: It is not that only some of the GBs are out of line. Almost all are non-flat. I count only a minority where the flat designation was missing. Namely src/frontends/qt4/ui/CharacterUi.ui src/frontends/qt4/ui/CitationUi.ui src/frontends/qt4/ui/CompareUi.ui src/frontends/qt4/ui/ExternalUi.ui src/frontends/qt4/ui/FloatPlacementUi.ui src/frontends/qt4/ui/IncludeUi.ui src/frontends/qt4/ui/LaTeXUi.ui src/frontends/qt4/ui/ListingsUi.ui src/frontends/qt4/ui/MathMatrixUi.ui src/frontends/qt4/ui/PhantomUi.ui src/frontends/qt4/ui/PrefConvertersUi.ui src/frontends/qt4/ui/ProgressViewUi.ui src/frontends/qt4/ui/TabularUi.ui Jürgen Did you check whether those not on the list do actually have GBs? Daniel
Re: Patch test with several minor dialog alignment fixes
On 25/12/2018 13:26, Jürgen Spitzmüller wrote: Am Dienstag, den 25.12.2018, 13:08 +0100 schrieb Daniel: Can you show me what my patch looks like on the style you use? Then I could try to figure out what went wrong with it. If you send me a patch that applies to master, sure. Jürgen You wrote before But I saw a misalignment with your patch. I am probably confused. Do you ask me to recreate my patch with current master which you successfully applied before and found to be misaligned? Daniel
Re: Patch test with several minor dialog alignment fixes
Am Dienstag, den 25.12.2018, 13:08 +0100 schrieb Daniel: > Can you show me what my patch looks like on the style you use? Then > I > could try to figure out what went wrong with it. If you send me a patch that applies to master, sure. Jürgen > > Daniel > signature.asc Description: This is a digitally signed message part
Re: Patch test with several minor dialog alignment fixes
Am Dienstag, den 25.12.2018, 12:40 +0100 schrieb Daniel: > > It is not that only some of the GBs are out of line. Almost all are > non-flat. I count only a minority where the flat designation was missing. Namely src/frontends/qt4/ui/CharacterUi.ui src/frontends/qt4/ui/CitationUi.ui src/frontends/qt4/ui/CompareUi.ui src/frontends/qt4/ui/ExternalUi.ui src/frontends/qt4/ui/FloatPlacementUi.ui src/frontends/qt4/ui/IncludeUi.ui src/frontends/qt4/ui/LaTeXUi.ui src/frontends/qt4/ui/ListingsUi.ui src/frontends/qt4/ui/MathMatrixUi.ui src/frontends/qt4/ui/PhantomUi.ui src/frontends/qt4/ui/PrefConvertersUi.ui src/frontends/qt4/ui/ProgressViewUi.ui src/frontends/qt4/ui/TabularUi.ui Jürgen signature.asc Description: This is a digitally signed message part
Re: Patch test with several minor dialog alignment fixes
On 25/12/2018 12:35, Jürgen Spitzmüller wrote: Am Montag, den 24.12.2018, 22:11 +0100 schrieb Daniel: Thanks. But I like mine more (see attached screen shot). I don't see the misalignment in your screenshot here on Linux. But I saw a misalignment with your patch. It maybe depends on the Qt style. Jürgen Can you show me what my patch looks like on the style you use? Then I could try to figure out what went wrong with it. Daniel
Re: Patch test with several minor dialog alignment fixes
On 25/12/2018 12:26, Jürgen Spitzmüller wrote: Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel: Thanks. But the buttons are misaligned now (see attachment). Not for me (see attachment). Sorry, forgot to comment on this. That the misalignment does not happen for you is because text fields in your window manager have the same height as push buttons. But that is not true on other operating systems, like Windows. Daniel
Re: Patch test with several minor dialog alignment fixes
On 25/12/2018 12:26, Jürgen Spitzmüller wrote: Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel: Thanks. But the buttons are misaligned now (see attachment). Not for me (see attachment). * the Cancel button needs to go on a line of its own. I understand that this is a general rule of dialogs in LyX. However, please consider an exception to this rule for the quick search and replace dialog. No. That's hard to reason with. All apps I checked have the checkboxes aligned to minimize space. BTW your patch (in the following message) does not apply to master. If you remove your patch it should apply fine. Merry Christmas Jürgen Merry Christmas to you too! Daniel
Re: Patch test with several minor dialog alignment fixes
On 25/12/2018 12:28, Jürgen Spitzmüller wrote: Am Montag, den 24.12.2018, 22:21 +0100 schrieb Daniel: Thanks. You changed the group box style to flat, right? I still think this isn't LyX standard. It's LyX standard. We changed that some years ago. If some GBs are non- flat, we should change that. Jürgen It is not that only some of the GBs are out of line. Almost all are non-flat. I don't know why the decision was made to go away from the Qt default but at leat on Windows it would be a change for the worse. Also given that almost no dialogs of LyX follow LyX's standard, and no one seems to complain, I suggest to reconsider change. What's the benefit of it? Daniel
Re: Patch test with several minor dialog alignment fixes
Am Montag, den 24.12.2018, 22:11 +0100 schrieb Daniel: > Thanks. But I like mine more (see attached screen shot). I don't see the misalignment in your screenshot here on Linux. But I saw a misalignment with your patch. It maybe depends on the Qt style. Jürgen signature.asc Description: This is a digitally signed message part
Re: Patch test with several minor dialog alignment fixes
Am Montag, den 24.12.2018, 22:21 +0100 schrieb Daniel: > Thanks. You changed the group box style to flat, right? I still > think > this isn't LyX standard. It's LyX standard. We changed that some years ago. If some GBs are non- flat, we should change that. Jürgen signature.asc Description: This is a digitally signed message part
Re: Patch test with several minor dialog alignment fixes
Am Montag, den 24.12.2018, 22:45 +0100 schrieb Daniel: > Thanks. But the buttons are misaligned now (see attachment). Not for me (see attachment). > > * the Cancel button needs to go on a line of its own. > > I understand that this is a general rule of dialogs in LyX. However, > please consider an exception to this rule for the quick search and > replace dialog. No. BTW your patch (in the following message) does not apply to master. Merry Christmas Jürgen signature.asc Description: This is a digitally signed message part
Re: Patch test with several minor dialog alignment fixes
On 24/12/2018 22:45, Daniel wrote:
On 24/12/2018 14:48, Jürgen Spitzmüller wrote:
Am Montag, den 29.10.2018, 15:16 +0100 schrieb Daniel:
On 29/10/2018 14:12, Daniel wrote:
Attached is a patch for the Find & Replace (Quick) dialog for
master. If
the patch is works, I could proceed with the other dialog fixes.
Sorry, reordered checkboxes for no good reason...
Finally applied to master, with some changes:
* the "Replace All" button didn't align well with the others (at least
in German l7n)
Thanks. But the buttons are misaligned now (see attachment). For some
reason I cannot choose another UI language in master, so I can't test
what it looks like in German.
* the Cancel button needs to go on a line of its own.
I understand that this is a general rule of dialogs in LyX. However,
please consider an exception to this rule for the quick search and
replace dialog. The reason are that
1) quick and search should use as limited space as possible because
might float over the work area to make search results visisble
and
2) this is a very restricted button box with only one button anyway.
Daniel
Attached is another attempt at the Find & Replace (Quick) dialog (patch
and screen shots). As you see from the shots, I managed to change
languages too, so that should work as well. Thanks for checking that in
the first place.
Daniel
From 876c8d8f6cbe1e0cd6a597f5823c6c6e01941d30 Mon Sep 17 00:00:00 2001
From: Daniel Ramoeller
Date: Mon, 29 Oct 2018 14:08:34 +0100
Subject: [PATCH 1/2] Fix for Find & Replace (Quick) dialog: - fixed maximum
height to minimum height - uncouple buttons from checkboxes
---
src/frontends/qt4/GuiSearch.cpp | 3 +
src/frontends/qt4/ui/SearchUi.ui | 340 ---
2 files changed, 174 insertions(+), 169 deletions(-)
diff --git a/src/frontends/qt4/GuiSearch.cpp b/src/frontends/qt4/GuiSearch.cpp
index dd1a002fed..02678fae60 100644
--- a/src/frontends/qt4/GuiSearch.cpp
+++ b/src/frontends/qt4/GuiSearch.cpp
@@ -47,6 +47,9 @@ GuiSearch::GuiSearch(GuiView & lv)
{
setupUi(this);
+ // fix height to minimum
+ setFixedHeight(sizeHint().height());
+
connect(buttonBox, SIGNAL(clicked(QAbstractButton *)),
this, SLOT(slotButtonBox(QAbstractButton *)));
connect(findPB, SIGNAL(clicked()), this, SLOT(findClicked()));
diff --git a/src/frontends/qt4/ui/SearchUi.ui b/src/frontends/qt4/ui/SearchUi.ui
index ebc00e3cfc..7886d94de9 100644
--- a/src/frontends/qt4/ui/SearchUi.ui
+++ b/src/frontends/qt4/ui/SearchUi.ui
@@ -16,48 +16,10 @@
true
-
-
-
-
- Find:
-
-
- findCO
-
-
-
-
-
-
-
- 0
- 0
-
-
-
- Qt::StrongFocus
-
-
- true
-
-
- 666
-
-
- QComboBox::InsertAtTop
-
-
- false
-
-
- false
-
-
-
-
-
-
+
+
+
+
false
@@ -70,151 +32,191 @@
-
-
-
-false
+
+
+
+Find:
+
+
+findCO
+
+
+
+
-Replace
+Replace with:
+
+
+replaceCO
-
-
-
+
+
+
+
+ 0
+ 0
+
+
+
+Qt::StrongFocus
+
+
+true
+
+
+666
+
+
+QComboBox::InsertAtTop
+
+
false
-
-Replace All
+
+false
-
-
-
-QDialogButtonBox::Close
+
+
+
+
+ 0
+ 0
+
+
+
+true
+
+
+666
+
+
+QComboBox::InsertAtTop
+
+
+false
+
+
+false
+
+
+
+
+
+
+false
+
+
+Replace
-
-
-
- Replace with:
-
-
- replaceCO
-
-
-
-
-
-
-
- 0
- 0
-
-
-
- true
-
-
- 666
-
-
- QComboBox::InsertAtTop
-
-
- false
-
-
- false
-
-
-
-
-
-
- Case sensitive[[search]]
-
-
-
-
-
-
- Qt::Horizontal
-
-
- QSizePolicy::Expanding
-
-
-
- 20
- 20
-
-
-
-
-
-
-
- Match whole words only
-
-
-
-
-
-
- Search backwards
-
-
-
-
-
-
- Qt::Vertical
-
-
- QSizePolicy::Expanding
-
-
-
- 20
- 20
-
-
-
-
-
-
-
- Qt::Vertical
-
-
-
Re: Patch test with several minor dialog alignment fixes
On 24/12/2018 14:48, Jürgen Spitzmüller wrote: Am Montag, den 29.10.2018, 15:16 +0100 schrieb Daniel: On 29/10/2018 14:12, Daniel wrote: Attached is a patch for the Find & Replace (Quick) dialog for master. If the patch is works, I could proceed with the other dialog fixes. Sorry, reordered checkboxes for no good reason... Finally applied to master, with some changes: * the "Replace All" button didn't align well with the others (at least in German l7n) Thanks. But the buttons are misaligned now (see attachment). For some reason I cannot choose another UI language in master, so I can't test what it looks like in German. * the Cancel button needs to go on a line of its own. I understand that this is a general rule of dialogs in LyX. However, please consider an exception to this rule for the quick search and replace dialog. The reason are that 1) quick and search should use as limited space as possible because might float over the work area to make search results visisble and 2) this is a very restricted button box with only one button anyway. Daniel
Re: Patch test with several minor dialog alignment fixes
On 24/12/2018 16:01, Jürgen Spitzmüller wrote: Am Mittwoch, den 31.10.2018, 07:57 +0100 schrieb Daniel: Compare dialog. Reworked version committed. Thanks, Jürgen Thanks. You changed the group box style to flat, right? I still think this isn't LyX standard. It is also not Qt's default. Maybe one reason for this is that the flat grouping isn't obvious - at least in Windows 10. In the attached screenshot of your change the grouping isn't as obvious as with the box around it. Please reconsider this change. Why not use the standard? But if not then all other dialogs in LyX have to be changed to have flat grouping boxes as well so at least it is consistent. Daniel
Re: Patch test with several minor dialog alignment fixes
On 24/12/2018 17:46, Jürgen Spitzmüller wrote: Am Mittwoch, den 24.10.2018, 13:36 +0200 schrieb Daniel: fixed version attached. Please repost as separate patch, should this combined patch include something not yet addressed. Thanks, Jürgen I don't think so. I separated all after being told so. Thanks, Daniel
Re: Patch test with several minor dialog alignment fixes
On 24/12/2018 16:03, Jürgen Spitzmüller wrote: Am Mittwoch, den 31.10.2018, 16:58 +0100 schrieb Daniel: Okay, maybe I should explain a bit, especially if a change might be controversial. I think the checkbox is better placed next to the button box because it makes is more obvious where it belongs to. There is no other obvious divider between the button box and the content of the preferences. Alternatively, there could be a line between the checkbox and the content but that would make the dialog even taller. The space was a secondary concern in my choice. I don't agree with this proposal. The button box should only contain buttons. I moved the checkbox to the place it is now intentionally. Jürgen I find my proposal very similar to yours for the Text Style dialog where the Apply changes immediately is moved next to the buttons it applies to. Daniel
Re: Patch test with several minor dialog alignment fixes
Am Mittwoch, den 24.10.2018, 13:36 +0200 schrieb Daniel: > fixed version attached. Please repost as separate patch, should this combined patch include something not yet addressed. Thanks, Jürgen signature.asc Description: This is a digitally signed message part
Re: Patch test with several minor dialog alignment fixes
Am Mittwoch, den 31.10.2018, 18:20 +0100 schrieb Daniel: > Search & Replace Advanced. A bit more extensive changes. Slightly modified version committed (additional vspacer added). Thanks, Jürgen signature.asc Description: This is a digitally signed message part
Re: Patch test with several minor dialog alignment fixes
Am Donnerstag, den 22.11.2018, 11:03 +0100 schrieb Daniel: > Paragraph dialog fixes attached. Committed minus the group box changes (we use flat GBs in all dialogs). Thanks, Jürgen signature.asc Description: This is a digitally signed message part
Re: Patch test with several minor dialog alignment fixes
Am Donnerstag, den 22.11.2018, 10:41 +0100 schrieb Daniel: > > I suggest a fixed minimum height for the Text Properties dialog. > > > > Reasons: > > - It cannot profit from greater height > > - It might not have its minimum height initially and hence look > > awkwardly stretched > > > > Daniel > > And the patch ... Committed. Thanks, Jürgen signature.asc Description: This is a digitally signed message part
Re: Patch test with several minor dialog alignment fixes
Am Freitag, den 16.11.2018, 15:41 +0100 schrieb Daniel: > Just stumbled upon a misplaced spacer in the Table Insert dialog. > Patch and screen captures attached. Committed. Thanks, Jürgen signature.asc Description: This is a digitally signed message part
Re: Patch test with several minor dialog alignment fixes
Am Mittwoch, den 31.10.2018, 17:46 +0100 schrieb Daniel: > Messages Pane. Committed. Thanks, Jürgen signature.asc Description: This is a digitally signed message part
Re: Patch test with several minor dialog alignment fixes
Am Mittwoch, den 31.10.2018, 16:58 +0100 schrieb Daniel: > Okay, maybe I should explain a bit, especially if a change might be > controversial. I think the checkbox is better placed next to the > button > box because it makes is more obvious where it belongs to. There is > no > other obvious divider between the button box and the content of the > preferences. Alternatively, there could be a line between the > checkbox > and the content but that would make the dialog even taller. The > space > was a secondary concern in my choice. I don't agree with this proposal. The button box should only contain buttons. I moved the checkbox to the place it is now intentionally. Jürgen > > Daniel > signature.asc Description: This is a digitally signed message part
Re: Patch test with several minor dialog alignment fixes
Am Mittwoch, den 31.10.2018, 07:57 +0100 schrieb Daniel: > Compare dialog. Reworked version committed. Thanks, Jürgen signature.asc Description: This is a digitally signed message part
Re: Patch test with several minor dialog alignment fixes
Am Mittwoch, den 31.10.2018, 07:24 +0100 schrieb Daniel: > Thesaurus dialog. Committed. Thanks, Jürgen signature.asc Description: This is a digitally signed message part
Re: Patch test with several minor dialog alignment fixes
Am Dienstag, den 30.10.2018, 21:23 +0100 schrieb Daniel: > Spellchecker dialog. Committed. Jürgen signature.asc Description: This is a digitally signed message part
Re: Patch test with several minor dialog alignment fixes
Am Montag, den 29.10.2018, 15:16 +0100 schrieb Daniel: > On 29/10/2018 14:12, Daniel wrote: > > Attached is a patch for the Find & Replace (Quick) dialog for > > master. If > > the patch is works, I could proceed with the other dialog fixes. > > Sorry, reordered checkboxes for no good reason... Finally applied to master, with some changes: * the "Replace All" button didn't align well with the others (at least in German l7n) * the Cancel button needs to go on a line of its own. Thanks, Jürgen > > Daniel signature.asc Description: This is a digitally signed message part
Re: Patch test with several minor dialog alignment fixes
Am Donnerstag, 22. November 2018 11:03:00 CET schrieb Daniel : > Paragraph dialog fixes attached. > > Daniel +1 Kornel signature.asc Description: This is a digitally signed message part.
Re: Patch test with several minor dialog alignment fixes
On 22/11/2018 10:41, Daniel wrote:
On 22/11/2018 10:38, Daniel wrote:
On 16/11/2018 15:41, Daniel wrote:
On 31/10/2018 18:20, Daniel wrote:
On 31/10/2018 17:46, Daniel wrote:
On 31/10/2018 15:25, Daniel wrote:
On 31/10/2018 07:57, Daniel wrote:
On 31/10/2018 07:24, Daniel wrote:
On 30/10/2018 21:23, Daniel wrote:
On 30/10/2018 17:37, Daniel wrote:
On 30/10/2018 16:46, Scott Kostyshak wrote:
On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote:
Thanks for checking. The minimum height was actually a bit
imprecise. I
should have written: "fixed at minimum height". In current
master you can
increase the height but I couldn't see what is to be gained
by this and many
other apps have fixed height find dialogs.
Ah I see. Thanks for the explanation. Seems reasonable to me.
Great. When I find time, I go ahead and fix what seem to me
positioning issues in the other dialogs.
Daniel
Spellchecker dialog.
Thesaurus dialog.
Compare dialog.
Preferences dialog. (This might be a more controversial change.)
Messages Pane.
Search & Replace Advanced. A bit more extensive changes.
Just stumbled upon a misplaced spacer in the Table Insert dialog.
Patch and screen captures attached.
Daniel
I suggest a fixed minimum height for the Text Properties dialog.
Reasons:
- It cannot profit from greater height
- It might not have its minimum height initially and hence look
awkwardly stretched
Daniel
And the patch ...
Paragraph dialog fixes attached.
Daniel
>From ce562ab9c66b7b3bd0c5087101fc5c19ea761e68 Mon Sep 17 00:00:00 2001
From: Daniel Ramoeller
Date: Thu, 22 Nov 2018 10:53:36 +0100
Subject: [PATCH] Paragraph dialog fixes: - Fixed minimum height - Non-flat
groups boxes
---
src/frontends/qt4/GuiParagraph.cpp | 3 +++
src/frontends/qt4/ui/ParagraphUi.ui | 15 ---
2 files changed, 3 insertions(+), 15 deletions(-)
diff --git a/src/frontends/qt4/GuiParagraph.cpp
b/src/frontends/qt4/GuiParagraph.cpp
index b7e1050a3f..09690f7a9e 100644
--- a/src/frontends/qt4/GuiParagraph.cpp
+++ b/src/frontends/qt4/GuiParagraph.cpp
@@ -50,6 +50,9 @@ GuiParagraph::GuiParagraph(GuiView & lv)
{
setupUi(this);
+ // fix height to minimum
+ setFixedHeight(sizeHint().height());
+
connect(alignDefaultRB, SIGNAL(clicked()), this, SLOT(changed()));
connect(alignJustRB, SIGNAL(clicked()), this, SLOT(changed()));
connect(alignLeftRB, SIGNAL(clicked()), this, SLOT(changed()));
diff --git a/src/frontends/qt4/ui/ParagraphUi.ui
b/src/frontends/qt4/ui/ParagraphUi.ui
index 64d7139b2f..09b6c1b96f 100644
--- a/src/frontends/qt4/ui/ParagraphUi.ui
+++ b/src/frontends/qt4/ui/ParagraphUi.ui
@@ -22,9 +22,6 @@
Line spacing
-
- true
-
9
@@ -85,9 +82,6 @@
Alignment
-
- true
-
9
@@ -153,9 +147,6 @@
Label Width
-
- true
-
9
@@ -207,12 +198,6 @@
Qt::Vertical
-
-
- 351
- 16
-
-
--
2.17.0.windows.1
Re: Patch test with several minor dialog alignment fixes
On 22/11/2018 10:38, Daniel wrote:
On 16/11/2018 15:41, Daniel wrote:
On 31/10/2018 18:20, Daniel wrote:
On 31/10/2018 17:46, Daniel wrote:
On 31/10/2018 15:25, Daniel wrote:
On 31/10/2018 07:57, Daniel wrote:
On 31/10/2018 07:24, Daniel wrote:
On 30/10/2018 21:23, Daniel wrote:
On 30/10/2018 17:37, Daniel wrote:
On 30/10/2018 16:46, Scott Kostyshak wrote:
On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote:
Thanks for checking. The minimum height was actually a bit
imprecise. I
should have written: "fixed at minimum height". In current
master you can
increase the height but I couldn't see what is to be gained
by this and many
other apps have fixed height find dialogs.
Ah I see. Thanks for the explanation. Seems reasonable to me.
Great. When I find time, I go ahead and fix what seem to me
positioning issues in the other dialogs.
Daniel
Spellchecker dialog.
Thesaurus dialog.
Compare dialog.
Preferences dialog. (This might be a more controversial change.)
Messages Pane.
Search & Replace Advanced. A bit more extensive changes.
Just stumbled upon a misplaced spacer in the Table Insert dialog.
Patch and screen captures attached.
Daniel
I suggest a fixed minimum height for the Text Properties dialog.
Reasons:
- It cannot profit from greater height
- It might not have its minimum height initially and hence look
awkwardly stretched
Daniel
And the patch ...
>From 48176e2a4f695a8e65033a1e4c58a6037cf80092 Mon Sep 17 00:00:00 2001
From: Daniel Ramoeller
Date: Thu, 22 Nov 2018 10:40:09 +0100
Subject: [PATCH] Set fixed minimal height for Text Properties dialog.
---
src/frontends/qt4/GuiCharacter.cpp | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/frontends/qt4/GuiCharacter.cpp
b/src/frontends/qt4/GuiCharacter.cpp
index 8b7f3e83d3..bccd3e6115 100644
--- a/src/frontends/qt4/GuiCharacter.cpp
+++ b/src/frontends/qt4/GuiCharacter.cpp
@@ -211,6 +211,9 @@ GuiCharacter::GuiCharacter(GuiView & lv)
{
setupUi(this);
+ // fix height to minimum
+ setFixedHeight(sizeHint().height());
+
connect(buttonBox, SIGNAL(clicked(QAbstractButton *)),
this, SLOT(slotButtonBox(QAbstractButton *)));
connect(autoapplyCB, SIGNAL(stateChanged(int)), this,
--
2.17.0.windows.1
Re: Patch test with several minor dialog alignment fixes
On 16/11/2018 15:41, Daniel wrote: On 31/10/2018 18:20, Daniel wrote: On 31/10/2018 17:46, Daniel wrote: On 31/10/2018 15:25, Daniel wrote: On 31/10/2018 07:57, Daniel wrote: On 31/10/2018 07:24, Daniel wrote: On 30/10/2018 21:23, Daniel wrote: On 30/10/2018 17:37, Daniel wrote: On 30/10/2018 16:46, Scott Kostyshak wrote: On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: Thanks for checking. The minimum height was actually a bit imprecise. I should have written: "fixed at minimum height". In current master you can increase the height but I couldn't see what is to be gained by this and many other apps have fixed height find dialogs. Ah I see. Thanks for the explanation. Seems reasonable to me. Great. When I find time, I go ahead and fix what seem to me positioning issues in the other dialogs. Daniel Spellchecker dialog. Thesaurus dialog. Compare dialog. Preferences dialog. (This might be a more controversial change.) Messages Pane. Search & Replace Advanced. A bit more extensive changes. Just stumbled upon a misplaced spacer in the Table Insert dialog. Patch and screen captures attached. Daniel I suggest a fixed minimum height for the Text Properties dialog. Reasons: - It cannot profit from greater height - It might not have its minimum height initially and hence look awkwardly stretched Daniel
Re: Patch test with several minor dialog alignment fixes
On 31/10/2018 18:20, Daniel wrote: On 31/10/2018 17:46, Daniel wrote: On 31/10/2018 15:25, Daniel wrote: On 31/10/2018 07:57, Daniel wrote: On 31/10/2018 07:24, Daniel wrote: On 30/10/2018 21:23, Daniel wrote: On 30/10/2018 17:37, Daniel wrote: On 30/10/2018 16:46, Scott Kostyshak wrote: On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: Thanks for checking. The minimum height was actually a bit imprecise. I should have written: "fixed at minimum height". In current master you can increase the height but I couldn't see what is to be gained by this and many other apps have fixed height find dialogs. Ah I see. Thanks for the explanation. Seems reasonable to me. Great. When I find time, I go ahead and fix what seem to me positioning issues in the other dialogs. Daniel Spellchecker dialog. Thesaurus dialog. Compare dialog. Preferences dialog. (This might be a more controversial change.) Messages Pane. Search & Replace Advanced. A bit more extensive changes. Just stumbled upon a misplaced spacer in the Table Insert dialog. Patch and screen captures attached. Daniel >From 9922b971ae8c8419a1e369e427b8981072b4c01e Mon Sep 17 00:00:00 2001 From: Daniel Ramoeller Date: Fri, 16 Nov 2018 15:28:59 +0100 Subject: [PATCH] Fix for Insert Table dialog: - Correct spacer position --- src/frontends/qt4/ui/TabularCreateUi.ui | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/src/frontends/qt4/ui/TabularCreateUi.ui b/src/frontends/qt4/ui/TabularCreateUi.ui index 11dbf5bfe6..6a0ad76e50 100644 --- a/src/frontends/qt4/ui/TabularCreateUi.ui +++ b/src/frontends/qt4/ui/TabularCreateUi.ui @@ -83,23 +83,17 @@ + + + + Qt::Horizontal + + + - - - - Qt::Horizontal - - - - 40 - 20 - - - - -- 2.17.0.windows.1
Re: Patch test with several minor dialog alignment fixes
On Thu, Nov 01, 2018 at 09:35:25PM +0100, Daniel wrote: > On 2018-11-01 21:07, Scott Kostyshak wrote: > > On Thu, Nov 01, 2018 at 05:18:18PM +0100, Daniel wrote: > > > On 01/11/2018 16:58, Scott Kostyshak wrote: > > > > On Thu, Nov 01, 2018 at 06:52:11AM +0100, Daniel wrote: > > > > > > > > > Great. And by the way, while I tend to think all the changes I make > > > > > sense, I > > > > > can change things on feedback. > > > > > > > > Sounds good. One comment which I'm not sure is relevant is: often Qt > > > > Creator reformats a bunch of things when you save. I find it helpful if > > > > you just save a version that only contains the reformatting. This is the > > > > analog of in LyX, when opening a 2.2.x document in LyX 2.3.x, save a > > > > no-op (e.g. make a change, then save, then undo the change, then save). > > > > Then, commit that. Then commit your changes in a separate commit. This > > > > will make it easier to see exactly what you changed. I don't suggest you > > > > go back and redo things, but I would prefer this for future changes (you > > > > might want to check with others though; perhaps this is just my personal > > > > preference). > > > > > > I am not sure I can follow. Is the idea to make two commits? One with the > > > changes and one with the changes undone? > > > > The idea is to make two commits: one with possibly changes to style, and > > one with actual content change. It might be that the first commit is > > unnecessary. To see, do the following: open a .ui file, make a change, > > save, undo the change, save. If there is no diff, then this commit is > > unnecessary. If there is a diff, then commit that. Sometimes newer Qt > > Creator versions just add whitespace somewhere or have a different > > style. > > > > The analog is like opening a 2.2.x file in LyX 2.3.x. It makes sense to > > commit just the lyx2lyx changes before committing changes to actual > > content. Otherwise, it's not clear what changes are just the different > > format and which changes are to the content. > > Thanks, got it. > > Another thing I realized is that when moving elements and back again to try > things out in Creator this sometimes still causes changes. So, it might be > better to undo changes using the undo function rather than "manually" > undoing. Good to know. That makes sense. I think the key is to save before doing undo, otherwise the buffer might not be marked as dirty. An alternative might be to not do any operation and just use "Save As" instead. Scott signature.asc Description: PGP signature
Re: Patch test with several minor dialog alignment fixes
On 2018-11-01 21:07, Scott Kostyshak wrote: On Thu, Nov 01, 2018 at 05:18:18PM +0100, Daniel wrote: On 01/11/2018 16:58, Scott Kostyshak wrote: On Thu, Nov 01, 2018 at 06:52:11AM +0100, Daniel wrote: Great. And by the way, while I tend to think all the changes I make sense, I can change things on feedback. Sounds good. One comment which I'm not sure is relevant is: often Qt Creator reformats a bunch of things when you save. I find it helpful if you just save a version that only contains the reformatting. This is the analog of in LyX, when opening a 2.2.x document in LyX 2.3.x, save a no-op (e.g. make a change, then save, then undo the change, then save). Then, commit that. Then commit your changes in a separate commit. This will make it easier to see exactly what you changed. I don't suggest you go back and redo things, but I would prefer this for future changes (you might want to check with others though; perhaps this is just my personal preference). I am not sure I can follow. Is the idea to make two commits? One with the changes and one with the changes undone? The idea is to make two commits: one with possibly changes to style, and one with actual content change. It might be that the first commit is unnecessary. To see, do the following: open a .ui file, make a change, save, undo the change, save. If there is no diff, then this commit is unnecessary. If there is a diff, then commit that. Sometimes newer Qt Creator versions just add whitespace somewhere or have a different style. The analog is like opening a 2.2.x file in LyX 2.3.x. It makes sense to commit just the lyx2lyx changes before committing changes to actual content. Otherwise, it's not clear what changes are just the different format and which changes are to the content. Thanks, got it. Another thing I realized is that when moving elements and back again to try things out in Creator this sometimes still causes changes. So, it might be better to undo changes using the undo function rather than "manually" undoing. Daniel
Re: Patch test with several minor dialog alignment fixes
On Thu, Nov 01, 2018 at 05:18:18PM +0100, Daniel wrote: > On 01/11/2018 16:58, Scott Kostyshak wrote: > > On Thu, Nov 01, 2018 at 06:52:11AM +0100, Daniel wrote: > > > > > Great. And by the way, while I tend to think all the changes I make > > > sense, I > > > can change things on feedback. > > > > Sounds good. One comment which I'm not sure is relevant is: often Qt > > Creator reformats a bunch of things when you save. I find it helpful if > > you just save a version that only contains the reformatting. This is the > > analog of in LyX, when opening a 2.2.x document in LyX 2.3.x, save a > > no-op (e.g. make a change, then save, then undo the change, then save). > > Then, commit that. Then commit your changes in a separate commit. This > > will make it easier to see exactly what you changed. I don't suggest you > > go back and redo things, but I would prefer this for future changes (you > > might want to check with others though; perhaps this is just my personal > > preference). > > I am not sure I can follow. Is the idea to make two commits? One with the > changes and one with the changes undone? The idea is to make two commits: one with possibly changes to style, and one with actual content change. It might be that the first commit is unnecessary. To see, do the following: open a .ui file, make a change, save, undo the change, save. If there is no diff, then this commit is unnecessary. If there is a diff, then commit that. Sometimes newer Qt Creator versions just add whitespace somewhere or have a different style. The analog is like opening a 2.2.x file in LyX 2.3.x. It makes sense to commit just the lyx2lyx changes before committing changes to actual content. Otherwise, it's not clear what changes are just the different format and which changes are to the content. Scott signature.asc Description: PGP signature
Re: Patch test with several minor dialog alignment fixes
On 01/11/2018 16:58, Scott Kostyshak wrote: On Thu, Nov 01, 2018 at 06:52:11AM +0100, Daniel wrote: Great. And by the way, while I tend to think all the changes I make sense, I can change things on feedback. Sounds good. One comment which I'm not sure is relevant is: often Qt Creator reformats a bunch of things when you save. I find it helpful if you just save a version that only contains the reformatting. This is the analog of in LyX, when opening a 2.2.x document in LyX 2.3.x, save a no-op (e.g. make a change, then save, then undo the change, then save). Then, commit that. Then commit your changes in a separate commit. This will make it easier to see exactly what you changed. I don't suggest you go back and redo things, but I would prefer this for future changes (you might want to check with others though; perhaps this is just my personal preference). I am not sure I can follow. Is the idea to make two commits? One with the changes and one with the changes undone? Also, if you come across some oddity in a dialog that I haven't caught yet, please let me know. I think I got the hang of Qt Creator. Thank you for this offer! I have a ticket that has been itching me for a long time that I tried to fix but couldn't figure out how. I'll CC you on it to see if you have any ideas, but no pressure :) And I can't promise anything :) Daniel
Re: Patch test with several minor dialog alignment fixes
On Thu, Nov 01, 2018 at 06:52:11AM +0100, Daniel wrote: > Great. And by the way, while I tend to think all the changes I make sense, I > can change things on feedback. Sounds good. One comment which I'm not sure is relevant is: often Qt Creator reformats a bunch of things when you save. I find it helpful if you just save a version that only contains the reformatting. This is the analog of in LyX, when opening a 2.2.x document in LyX 2.3.x, save a no-op (e.g. make a change, then save, then undo the change, then save). Then, commit that. Then commit your changes in a separate commit. This will make it easier to see exactly what you changed. I don't suggest you go back and redo things, but I would prefer this for future changes (you might want to check with others though; perhaps this is just my personal preference). > Also, if you come across some oddity in a > dialog that I haven't caught yet, please let me know. I think I got the hang > of Qt Creator. Thank you for this offer! I have a ticket that has been itching me for a long time that I tried to fix but couldn't figure out how. I'll CC you on it to see if you have any ideas, but no pressure :) Scott signature.asc Description: PGP signature
Re: Patch test with several minor dialog alignment fixes
On 01/11/2018 12:45, Kornel Benko wrote: Am Donnerstag, 1. November 2018 12:32:13 CET schrieb Daniel : On 01/11/2018 10:42, Kornel Benko wrote: Am Donnerstag, 1. November 2018 06:52:11 CET schrieb Daniel : Thanks for checking. That the left hand labels don't stretch was driven by the idea that it would be easier to match the label and the text boxes. As for the buttons: I have never seen a (professional) dialog UI where the buttons stretch. So, I suggest to stick to what has been used elsewhere. (Probably for good reason but I am not sure about what that might be.) Also, my hunch was that this stretching behaviour was unintentional because it does not appear so long as the dialog is kept to a narrow width. Makes sense. Thanks, Scott Great. And by the way, while I tend to think all the changes I make sense, I can change things on feedback. Also, if you come across some oddity in a dialog that I haven't caught yet, please let me know. I think I got the hang of Qt Creator. Are you considering also different languages? LTR vs. RTL for instance, or different sizes of text fields? (All your examples are English only, therefore the question) Good point. I just tried RTL and it seems to me that Qt takes care of this pretty well. Nice feature. Though I must confess that my UI intuitions are a bit weak there. Basically, everything should be mirrored, right? Don't know. Just made a point. I am not sure what you mean by different sizes of text fields. However, as far as I can see my changes give text field more rather than less (horizontal) space, if that is the concern. Daniel I meant the width of translatable entries. Kornel I see. It was probably a bit ambiguous when I wrote "fixed width" in the description of changes. I did not set any width to a fixed number but only to their minimal size given their content. Daniel
Re: Patch test with several minor dialog alignment fixes
Am Donnerstag, 1. November 2018 12:32:13 CET schrieb Daniel : > On 01/11/2018 10:42, Kornel Benko wrote: > > Am Donnerstag, 1. November 2018 06:52:11 CET schrieb Daniel > > : > > > Thanks for checking. That the left hand labels don't stretch was driven > by > the idea that it would be easier to match the label and the text boxes. > As > for the buttons: I have never seen a (professional) dialog UI where the > buttons stretch. So, I suggest to stick to what has been used elsewhere. > (Probably for good reason but I am not sure about what that might be.) > Also, > my hunch was that this stretching behaviour was unintentional because it > does not appear so long as the dialog is kept to a narrow width. > >>> > >>> Makes sense. Thanks, > >>> > >>> Scott > >>> > >> > >> Great. And by the way, while I tend to think all the changes I make > >> sense, I can change things on feedback. Also, if you come across some > >> oddity in a dialog that I haven't caught yet, please let me know. I > >> think I got the hang of Qt Creator. > > > > Are you considering also different languages? LTR vs. RTL for instance, > > or different sizes of text fields? > > > > (All your examples are English only, therefore the question) > > Good point. I just tried RTL and it seems to me that Qt takes care of > this pretty well. Nice feature. Though I must confess that my UI > intuitions are a bit weak there. Basically, everything should be > mirrored, right? Don't know. Just made a point. > I am not sure what you mean by different sizes of text fields. However, > as far as I can see my changes give text field more rather than less > (horizontal) space, if that is the concern. > > Daniel > I meant the width of translatable entries. Kornel signature.asc Description: This is a digitally signed message part.
Re: Patch test with several minor dialog alignment fixes
On 01/11/2018 10:42, Kornel Benko wrote: Am Donnerstag, 1. November 2018 06:52:11 CET schrieb Daniel : Thanks for checking. That the left hand labels don't stretch was driven by the idea that it would be easier to match the label and the text boxes. As for the buttons: I have never seen a (professional) dialog UI where the buttons stretch. So, I suggest to stick to what has been used elsewhere. (Probably for good reason but I am not sure about what that might be.) Also, my hunch was that this stretching behaviour was unintentional because it does not appear so long as the dialog is kept to a narrow width. Makes sense. Thanks, Scott Great. And by the way, while I tend to think all the changes I make sense, I can change things on feedback. Also, if you come across some oddity in a dialog that I haven't caught yet, please let me know. I think I got the hang of Qt Creator. Are you considering also different languages? LTR vs. RTL for instance, or different sizes of text fields? (All your examples are English only, therefore the question) Good point. I just tried RTL and it seems to me that Qt takes care of this pretty well. Nice feature. Though I must confess that my UI intuitions are a bit weak there. Basically, everything should be mirrored, right? I am not sure what you mean by different sizes of text fields. However, as far as I can see my changes give text field more rather than less (horizontal) space, if that is the concern. Daniel
Re: Patch test with several minor dialog alignment fixes
Am Donnerstag, 1. November 2018 06:52:11 CET schrieb Daniel : ... > >> Thanks for checking. That the left hand labels don't stretch was driven by > >> the idea that it would be easier to match the label and the text boxes. As > >> for the buttons: I have never seen a (professional) dialog UI where the > >> buttons stretch. So, I suggest to stick to what has been used elsewhere. > >> (Probably for good reason but I am not sure about what that might be.) > >> Also, > >> my hunch was that this stretching behaviour was unintentional because it > >> does not appear so long as the dialog is kept to a narrow width. > > > > Makes sense. Thanks, > > > > Scott > > > > Great. And by the way, while I tend to think all the changes I make > sense, I can change things on feedback. Also, if you come across some > oddity in a dialog that I haven't caught yet, please let me know. I > think I got the hang of Qt Creator. Are you considering also different languages? LTR vs. RTL for instance, or different sizes of text fields? (All your examples are English only, therefore the question) > Daniel Kornel signature.asc Description: This is a digitally signed message part.
Re: Patch test with several minor dialog alignment fixes
On 01/11/2018 02:02, Scott Kostyshak wrote: On Wed, Oct 31, 2018 at 04:54:21PM +0100, Daniel wrote: On 31/10/2018 16:05, Scott Kostyshak wrote: On Wed, Oct 31, 2018 at 07:24:46AM +0100, Daniel wrote: On 30/10/2018 21:23, Daniel wrote: On 30/10/2018 17:37, Daniel wrote: On 30/10/2018 16:46, Scott Kostyshak wrote: On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: Thanks for checking. The minimum height was actually a bit imprecise. I should have written: "fixed at minimum height". In current master you can increase the height but I couldn't see what is to be gained by this and many other apps have fixed height find dialogs. Ah I see. Thanks for the explanation. Seems reasonable to me. Great. When I find time, I go ahead and fix what seem to me positioning issues in the other dialogs. Daniel Spellchecker dialog. Thesaurus dialog. What's the intuition behind this change? I haven't decided yet whether I like the before or the after better, but I'm curious why you propose this change. Are you thinking of only aesthetics? Or are you think that sometimes users want to enter a long keyword? As for why large buttons might be useful, well you don't need to have pinpoint accuracy with the mouse. I wonder what UI guides say. Probably they have some guidelines on which elements to stretch, and I wouldn't be surprised if your changes are in accordance with the guidelines. I'm just giving my first impression. Thanks for your work on these dialogs. Scott Thanks for checking. That the left hand labels don't stretch was driven by the idea that it would be easier to match the label and the text boxes. As for the buttons: I have never seen a (professional) dialog UI where the buttons stretch. So, I suggest to stick to what has been used elsewhere. (Probably for good reason but I am not sure about what that might be.) Also, my hunch was that this stretching behaviour was unintentional because it does not appear so long as the dialog is kept to a narrow width. Makes sense. Thanks, Scott Great. And by the way, while I tend to think all the changes I make sense, I can change things on feedback. Also, if you come across some oddity in a dialog that I haven't caught yet, please let me know. I think I got the hang of Qt Creator. Daniel
Re: Patch test with several minor dialog alignment fixes
On Wed, Oct 31, 2018 at 04:54:21PM +0100, Daniel wrote: > On 31/10/2018 16:05, Scott Kostyshak wrote: > > On Wed, Oct 31, 2018 at 07:24:46AM +0100, Daniel wrote: > > > On 30/10/2018 21:23, Daniel wrote: > > > > On 30/10/2018 17:37, Daniel wrote: > > > > > On 30/10/2018 16:46, Scott Kostyshak wrote: > > > > > > On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: > > > > > > > > > > > > > Thanks for checking. The minimum height was actually a bit > > > > > > > imprecise. I > > > > > > > should have written: "fixed at minimum height". In current > > > > > > > master you can > > > > > > > increase the height but I couldn't see what is to be gained > > > > > > > by this and many > > > > > > > other apps have fixed height find dialogs. > > > > > > > > > > > > Ah I see. Thanks for the explanation. Seems reasonable to me. > > > > > > > > > > Great. When I find time, I go ahead and fix what seem to me > > > > > positioning issues in the other dialogs. > > > > > > > > > > Daniel > > > > > > > > Spellchecker dialog. > > > > > > Thesaurus dialog. > > > > What's the intuition behind this change? I haven't decided yet whether I > > like the before or the after better, but I'm curious why you propose > > this change. Are you thinking of only aesthetics? Or are you think that > > sometimes users want to enter a long keyword? As for why large buttons > > might be useful, well you don't need to have pinpoint accuracy with the > > mouse. I wonder what UI guides say. Probably they have some guidelines > > on which elements to stretch, and I wouldn't be surprised if your > > changes are in accordance with the guidelines. I'm just giving my first > > impression. > > > > Thanks for your work on these dialogs. > > > > Scott > > > > Thanks for checking. That the left hand labels don't stretch was driven by > the idea that it would be easier to match the label and the text boxes. As > for the buttons: I have never seen a (professional) dialog UI where the > buttons stretch. So, I suggest to stick to what has been used elsewhere. > (Probably for good reason but I am not sure about what that might be.) Also, > my hunch was that this stretching behaviour was unintentional because it > does not appear so long as the dialog is kept to a narrow width. Makes sense. Thanks, Scott signature.asc Description: PGP signature
Re: Patch test with several minor dialog alignment fixes
On 31/10/2018 15:25, Daniel wrote: On 31/10/2018 07:57, Daniel wrote: On 31/10/2018 07:24, Daniel wrote: On 30/10/2018 21:23, Daniel wrote: On 30/10/2018 17:37, Daniel wrote: On 30/10/2018 16:46, Scott Kostyshak wrote: On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: Thanks for checking. The minimum height was actually a bit imprecise. I should have written: "fixed at minimum height". In current master you can increase the height but I couldn't see what is to be gained by this and many other apps have fixed height find dialogs. Ah I see. Thanks for the explanation. Seems reasonable to me. Great. When I find time, I go ahead and fix what seem to me positioning issues in the other dialogs. Daniel Spellchecker dialog. Thesaurus dialog. Compare dialog. Preferences dialog. (This might be a more controversial change.) Messages Pane. >From 7096147624ff1d3564a670fd9a09b77f220da27c Mon Sep 17 00:00:00 2001 From: Daniel Ramoeller Date: Wed, 31 Oct 2018 17:44:27 +0100 Subject: [PATCH] Fix for Messages dialog UI: - keep the options together --- src/frontends/qt4/ui/ProgressViewUi.ui | 213 ++--- 1 file changed, 119 insertions(+), 94 deletions(-) diff --git a/src/frontends/qt4/ui/ProgressViewUi.ui b/src/frontends/qt4/ui/ProgressViewUi.ui index 1ae1c6d653..8ac7a326b6 100644 --- a/src/frontends/qt4/ui/ProgressViewUi.ui +++ b/src/frontends/qt4/ui/ProgressViewUi.ui @@ -1,165 +1,184 @@ - - - - + + ProgressViewUi - - + + 0 0 -543 +498 298 - - -7 -13 + + 0 0 - + 0 0 - + 0 0 - + 0 0 - + - - + + 9 - + +9 + + +9 + + +9 + + 6 - - - + + + true - - - 7 - 13 + + 0 0 - + 0 0 - + false - + Qt::LeftToRight - + false - + QTabWidget::East - + QTabWidget::Rounded - + 0 - - + + Output - - + + +9 + + +9 + + +9 + + 9 - + 6 - - - - - 7 - 13 + + + + 1 0 - + 16777215 16777215 - + QFrame::StyledPanel - + QFrame::Sunken - + 1 - + true - - + + Settings - - + + 9 - + +9 + + +9 + + +9 + + 6 - - - + + + Select the debug messages that should be displayed - + 1 - + - + Qt::Vertical - + QSizePolicy::Preferred - + 187 3 @@ -167,62 +186,69 @@ - - - + + + Automatic cleanup of the window before LaTeX compilation proceeds - + Clear automatically - - - - - 5 - 0 + + + + 0 0 - + Debug messages - - + + + 9 + + + 9 + + + 9 + + 9 - + 6 - - - + + + Display no debug messages - + None - - - + + + Display the debug messages selected to the right - + Selected - - - + + + Display
Re: Patch test with several minor dialog alignment fixes
On 31/10/2018 15:25, Daniel wrote: On 31/10/2018 07:57, Daniel wrote: On 31/10/2018 07:24, Daniel wrote: On 30/10/2018 21:23, Daniel wrote: On 30/10/2018 17:37, Daniel wrote: On 30/10/2018 16:46, Scott Kostyshak wrote: On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: Thanks for checking. The minimum height was actually a bit imprecise. I should have written: "fixed at minimum height". In current master you can increase the height but I couldn't see what is to be gained by this and many other apps have fixed height find dialogs. Ah I see. Thanks for the explanation. Seems reasonable to me. Great. When I find time, I go ahead and fix what seem to me positioning issues in the other dialogs. Daniel Spellchecker dialog. Thesaurus dialog. Compare dialog. Preferences dialog. (This might be a more controversial change.) Okay, maybe I should explain a bit, especially if a change might be controversial. I think the checkbox is better placed next to the button box because it makes is more obvious where it belongs to. There is no other obvious divider between the button box and the content of the preferences. Alternatively, there could be a line between the checkbox and the content but that would make the dialog even taller. The space was a secondary concern in my choice. Daniel
Re: Patch test with several minor dialog alignment fixes
On 31/10/2018 16:05, Scott Kostyshak wrote: On Wed, Oct 31, 2018 at 07:24:46AM +0100, Daniel wrote: On 30/10/2018 21:23, Daniel wrote: On 30/10/2018 17:37, Daniel wrote: On 30/10/2018 16:46, Scott Kostyshak wrote: On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: Thanks for checking. The minimum height was actually a bit imprecise. I should have written: "fixed at minimum height". In current master you can increase the height but I couldn't see what is to be gained by this and many other apps have fixed height find dialogs. Ah I see. Thanks for the explanation. Seems reasonable to me. Great. When I find time, I go ahead and fix what seem to me positioning issues in the other dialogs. Daniel Spellchecker dialog. Thesaurus dialog. What's the intuition behind this change? I haven't decided yet whether I like the before or the after better, but I'm curious why you propose this change. Are you thinking of only aesthetics? Or are you think that sometimes users want to enter a long keyword? As for why large buttons might be useful, well you don't need to have pinpoint accuracy with the mouse. I wonder what UI guides say. Probably they have some guidelines on which elements to stretch, and I wouldn't be surprised if your changes are in accordance with the guidelines. I'm just giving my first impression. Thanks for your work on these dialogs. Scott Thanks for checking. That the left hand labels don't stretch was driven by the idea that it would be easier to match the label and the text boxes. As for the buttons: I have never seen a (professional) dialog UI where the buttons stretch. So, I suggest to stick to what has been used elsewhere. (Probably for good reason but I am not sure about what that might be.) Also, my hunch was that this stretching behaviour was unintentional because it does not appear so long as the dialog is kept to a narrow width. Daniel
Re: Patch test with several minor dialog alignment fixes
On Wed, Oct 31, 2018 at 07:24:46AM +0100, Daniel wrote: > On 30/10/2018 21:23, Daniel wrote: > > On 30/10/2018 17:37, Daniel wrote: > > > On 30/10/2018 16:46, Scott Kostyshak wrote: > > > > On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: > > > > > > > > > Thanks for checking. The minimum height was actually a bit imprecise. > > > > > I > > > > > should have written: "fixed at minimum height". In current > > > > > master you can > > > > > increase the height but I couldn't see what is to be gained > > > > > by this and many > > > > > other apps have fixed height find dialogs. > > > > > > > > Ah I see. Thanks for the explanation. Seems reasonable to me. > > > > > > Great. When I find time, I go ahead and fix what seem to me > > > positioning issues in the other dialogs. > > > > > > Daniel > > > > Spellchecker dialog. > > Thesaurus dialog. What's the intuition behind this change? I haven't decided yet whether I like the before or the after better, but I'm curious why you propose this change. Are you thinking of only aesthetics? Or are you think that sometimes users want to enter a long keyword? As for why large buttons might be useful, well you don't need to have pinpoint accuracy with the mouse. I wonder what UI guides say. Probably they have some guidelines on which elements to stretch, and I wouldn't be surprised if your changes are in accordance with the guidelines. I'm just giving my first impression. Thanks for your work on these dialogs. Scott signature.asc Description: PGP signature
Re: Patch test with several minor dialog alignment fixes
On 31/10/2018 07:24, Daniel wrote: On 30/10/2018 21:23, Daniel wrote: On 30/10/2018 17:37, Daniel wrote: On 30/10/2018 16:46, Scott Kostyshak wrote: On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: Thanks for checking. The minimum height was actually a bit imprecise. I should have written: "fixed at minimum height". In current master you can increase the height but I couldn't see what is to be gained by this and many other apps have fixed height find dialogs. Ah I see. Thanks for the explanation. Seems reasonable to me. Great. When I find time, I go ahead and fix what seem to me positioning issues in the other dialogs. Daniel Spellchecker dialog. Thesaurus dialog. Compare dialog. >From 4bc23c796007af34dd09be23b7dd1d3d4bf1c53d Mon Sep 17 00:00:00 2001 From: Daniel Ramoeller Date: Wed, 31 Oct 2018 07:42:31 +0100 Subject: [PATCH] Fix for Compare dialog UI: - statusbar next to buttonbox and aligned at bottom - fixed width group box --- src/frontends/qt4/ui/CompareUi.ui | 125 ++ 1 file changed, 77 insertions(+), 48 deletions(-) diff --git a/src/frontends/qt4/ui/CompareUi.ui b/src/frontends/qt4/ui/CompareUi.ui index 2893772a3f..16c618b3ca 100644 --- a/src/frontends/qt4/ui/CompareUi.ui +++ b/src/frontends/qt4/ui/CompareUi.ui @@ -13,6 +13,9 @@ + + true + 0 @@ -106,36 +109,42 @@ - - - - - 0 - 0 - + + + +Turns on the change tracking and showing changes in LaTeX output for the resulting document + + +Enable change tracking features in the output + + +false - -Copy Document Settings from: - - - - - - New Document - - - - - - - Old Document - - - - - + + + + + + + +false + + + + + + +QDialogButtonBox::Cancel|QDialogButtonBox::Ok + + + + + + + + 24 @@ -145,35 +154,55 @@ - - + + + +Qt::Vertical + + + + + - - - QDialogButtonBox::Cancel|QDialogButtonBox::Ok + + + + 0 + 0 + + + + Copy Document Settings from: + + + + + New Document + + + + + + + Old Document + + + + + + + + Qt::Horizontal + + + - - - -Turns on the change tracking and showing changes in LaTeX output for the resulting document - - -Enable change tracking features in the output - - -false - - - - - - -- 2.17.0.windows.1
Re: Patch test with several minor dialog alignment fixes
On 30/10/2018 21:23, Daniel wrote: On 30/10/2018 17:37, Daniel wrote: On 30/10/2018 16:46, Scott Kostyshak wrote: On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: Thanks for checking. The minimum height was actually a bit imprecise. I should have written: "fixed at minimum height". In current master you can increase the height but I couldn't see what is to be gained by this and many other apps have fixed height find dialogs. Ah I see. Thanks for the explanation. Seems reasonable to me. Great. When I find time, I go ahead and fix what seem to me positioning issues in the other dialogs. Daniel Spellchecker dialog. Thesaurus dialog. >From 665d52a28bf6c96f10cb451729d84b9b5e7ebe44 Mon Sep 17 00:00:00 2001 From: Daniel Ramoeller Date: Wed, 31 Oct 2018 07:23:33 +0100 Subject: [PATCH] Fix for Thesaurus dialog UI: - don't stretch labels and buttons --- src/frontends/qt4/ui/ThesaurusUi.ui | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/frontends/qt4/ui/ThesaurusUi.ui b/src/frontends/qt4/ui/ThesaurusUi.ui index 52a05e66aa..9e7b8293ca 100644 --- a/src/frontends/qt4/ui/ThesaurusUi.ui +++ b/src/frontends/qt4/ui/ThesaurusUi.ui @@ -16,7 +16,7 @@ true - + -- 2.17.0.windows.1
Re: Patch test with several minor dialog alignment fixes
On 30/10/2018 17:37, Daniel wrote: On 30/10/2018 16:46, Scott Kostyshak wrote: On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: Thanks for checking. The minimum height was actually a bit imprecise. I should have written: "fixed at minimum height". In current master you can increase the height but I couldn't see what is to be gained by this and many other apps have fixed height find dialogs. Ah I see. Thanks for the explanation. Seems reasonable to me. Great. When I find time, I go ahead and fix what seem to me positioning issues in the other dialogs. Daniel Spellchecker dialog. >From 7e9d36065fa3c892d53b69951d0f7055325d02b9 Mon Sep 17 00:00:00 2001 From: Daniel Ramoeller Date: Tue, 30 Oct 2018 21:22:26 +0100 Subject: [PATCH] Fix for Spellchecker dialog UI: - fixed button width --- src/frontends/qt4/ui/SpellcheckerUi.ui | 249 +++-- 1 file changed, 107 insertions(+), 142 deletions(-) diff --git a/src/frontends/qt4/ui/SpellcheckerUi.ui b/src/frontends/qt4/ui/SpellcheckerUi.ui index c8d6a863b9..1b66dc9d40 100644 --- a/src/frontends/qt4/ui/SpellcheckerUi.ui +++ b/src/frontends/qt4/ui/SpellcheckerUi.ui @@ -1,7 +1,8 @@ - + + SpellcheckerUi - - + + 0 0 @@ -9,223 +10,187 @@ 380 - + 260 320 - + Spell Checker - - - + + + + + Qt::StrongFocus + + + Replace with selected word + + + true + + + QComboBox::InsertAtTop + + + true + + + false + + + + + + + Replace word with current choice + + + Replace + + + + + + + Ignore this word + + + Ignore + + + + + - - + + Language: - + languageCO - - - + + + 100 32 - + The checked language. Switching this alters the language of the checked word. - - - - Qt::Horizontal + + + + + + + Find Next - - - + + + Unknown word: - + wordED - - - + + + Current word - - - - - 100 - 32 - - - - - - - Find Next - - - - - - + + + Replacement: - + replaceCO - - - - Qt::StrongFocus - - - Replace with selected word - - - true - - - QComboBox::InsertAtTop - - - true - - - false - - - - - - - - 100 - 32 - - - - Replace word with current choice - - - Replace - - - - - - - + + + + 0 0 - + Suggestions: - + suggestionsLW - - - - - 100 - 32 - - - + + + - + Replace All - - - - - - - - 100 - 32 - - - - Ignore this word - - - Ignore - - - - - - - - 100 - 32 - - - + + + Ignore this word throughout this session - + Ignore All - - - - - 100 - 32 - + + + + Qt::Horizontal - + + + + + + + + Add the word to your personal dictionary - + Add - + - + Qt::Vertical - + QSizePolicy::Expanding - + 74 98 -- 2.17.0.windows.1
Re: Patch test with several minor dialog alignment fixes
On 30/10/2018 16:46, Scott Kostyshak wrote: On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: Thanks for checking. The minimum height was actually a bit imprecise. I should have written: "fixed at minimum height". In current master you can increase the height but I couldn't see what is to be gained by this and many other apps have fixed height find dialogs. Ah I see. Thanks for the explanation. Seems reasonable to me. Great. When I find time, I go ahead and fix what seem to me positioning issues in the other dialogs. Daniel
Re: Patch test with several minor dialog alignment fixes
On Tue, Oct 30, 2018 at 04:16:16PM +0100, Daniel wrote: > Thanks for checking. The minimum height was actually a bit imprecise. I > should have written: "fixed at minimum height". In current master you can > increase the height but I couldn't see what is to be gained by this and many > other apps have fixed height find dialogs. Ah I see. Thanks for the explanation. Seems reasonable to me. Scott signature.asc Description: PGP signature
Re: Patch test with several minor dialog alignment fixes
On 30/10/2018 16:09, Scott Kostyshak wrote: On Tue, Oct 30, 2018 at 09:07:54AM +0100, Daniel wrote: On 30/10/2018 00:14, Richard Kimberly Heck wrote: On 10/29/18 10:16 AM, Daniel wrote: On 29/10/2018 14:12, Daniel wrote: Attached is a patch for the Find & Replace (Quick) dialog for master. If the patch is works, I could proceed with the other dialog fixes. Sorry, reordered checkboxes for no good reason... Can you say what exactly it is meant to do? E.g., provide before and after shots? Then it should be easy for me to see if it also does that here. Sure. Attached are shots with marked effects you should see. The screenshots really help to get an idea. Thanks. I think the changes look good! Regarding "minimum height", for me (on Linux) the dialog on current master appears to have a minimum height (at least, I cannot make the height too small). Scott Thanks for checking. The minimum height was actually a bit imprecise. I should have written: "fixed at minimum height". In current master you can increase the height but I couldn't see what is to be gained by this and many other apps have fixed height find dialogs. Daniel
Re: Patch test with several minor dialog alignment fixes
On Tue, Oct 30, 2018 at 09:07:54AM +0100, Daniel wrote: > On 30/10/2018 00:14, Richard Kimberly Heck wrote: > > On 10/29/18 10:16 AM, Daniel wrote: > > > On 29/10/2018 14:12, Daniel wrote: > > > > Attached is a patch for the Find & Replace (Quick) dialog for master. > > > > If the patch is works, I could proceed with the other dialog fixes. > > > > > > Sorry, reordered checkboxes for no good reason... > > > > > > Can you say what exactly it is meant to do? E.g., provide before and > > after shots? Then it should be easy for me to see if it also does that here. > > Sure. Attached are shots with marked effects you should see. The screenshots really help to get an idea. Thanks. I think the changes look good! Regarding "minimum height", for me (on Linux) the dialog on current master appears to have a minimum height (at least, I cannot make the height too small). Scott signature.asc Description: PGP signature
Re: Patch test with several minor dialog alignment fixes
On 30/10/2018 00:14, Richard Kimberly Heck wrote: On 10/29/18 10:16 AM, Daniel wrote: On 29/10/2018 14:12, Daniel wrote: Attached is a patch for the Find & Replace (Quick) dialog for master. If the patch is works, I could proceed with the other dialog fixes. Sorry, reordered checkboxes for no good reason... Can you say what exactly it is meant to do? E.g., provide before and after shots? Then it should be easy for me to see if it also does that here. Sure. Attached are shots with marked effects you should see. Daniel
Re: Patch test with several minor dialog alignment fixes
On 10/29/18 10:16 AM, Daniel wrote: > On 29/10/2018 14:12, Daniel wrote: >> Attached is a patch for the Find & Replace (Quick) dialog for master. >> If the patch is works, I could proceed with the other dialog fixes. > > Sorry, reordered checkboxes for no good reason... Can you say what exactly it is meant to do? E.g., provide before and after shots? Then it should be easy for me to see if it also does that here. Riki
Re: Patch test with several minor dialog alignment fixes
On 29/10/2018 14:12, Daniel wrote:
Attached is a patch for the Find & Replace (Quick) dialog for master. If
the patch is works, I could proceed with the other dialog fixes.
Sorry, reordered checkboxes for no good reason...
Daniel
From 3a91987679bae0211959101a6fd27d7e74c474df Mon Sep 17 00:00:00 2001
From: Daniel Ramoeller
Date: Mon, 29 Oct 2018 14:08:34 +0100
Subject: [PATCH] Fix for Find & Replace (Quick) dialog: - fixed maximum height
to minimum height - uncouple buttons from checkboxes
---
src/frontends/qt4/GuiSearch.cpp | 3 +
src/frontends/qt4/ui/SearchUi.ui | 337 +++
2 files changed, 171 insertions(+), 169 deletions(-)
diff --git a/src/frontends/qt4/GuiSearch.cpp b/src/frontends/qt4/GuiSearch.cpp
index dd1a002fed..02678fae60 100644
--- a/src/frontends/qt4/GuiSearch.cpp
+++ b/src/frontends/qt4/GuiSearch.cpp
@@ -47,6 +47,9 @@ GuiSearch::GuiSearch(GuiView & lv)
{
setupUi(this);
+ // fix height to minimum
+ setFixedHeight(sizeHint().height());
+
connect(buttonBox, SIGNAL(clicked(QAbstractButton *)),
this, SLOT(slotButtonBox(QAbstractButton *)));
connect(findPB, SIGNAL(clicked()), this, SLOT(findClicked()));
diff --git a/src/frontends/qt4/ui/SearchUi.ui b/src/frontends/qt4/ui/SearchUi.ui
index ebc00e3cfc..dacf2a152f 100644
--- a/src/frontends/qt4/ui/SearchUi.ui
+++ b/src/frontends/qt4/ui/SearchUi.ui
@@ -16,48 +16,10 @@
true
-
-
-
-
- Find:
-
-
- findCO
-
-
-
-
-
-
-
- 0
- 0
-
-
-
- Qt::StrongFocus
-
-
- true
-
-
- 666
-
-
- QComboBox::InsertAtTop
-
-
- false
-
-
- false
-
-
-
-
-
-
+
+
+
+
false
@@ -70,151 +32,188 @@
-
-
-
-false
+
+
+
+Find:
+
+
+findCO
+
+
+
+
-Replace
+Replace with:
+
+
+replaceCO
-
-
-
+
+
+
+
+ 0
+ 0
+
+
+
+Qt::StrongFocus
+
+
+true
+
+
+666
+
+
+QComboBox::InsertAtTop
+
+
false
-
-Replace All
+
+false
-
-
-
-QDialogButtonBox::Close
+
+
+
+
+ 0
+ 0
+
+
+
+true
+
+
+666
+
+
+QComboBox::InsertAtTop
+
+
+false
+
+
+false
+
+
+
+
+
+
+false
+
+
+Replace
-
-
-
- Replace with:
-
-
- replaceCO
-
-
-
-
-
-
-
- 0
- 0
-
-
-
- true
-
-
- 666
-
-
- QComboBox::InsertAtTop
-
-
- false
-
-
- false
-
-
-
-
-
-
- Case sensitive[[search]]
-
-
-
-
-
-
- Qt::Horizontal
-
-
- QSizePolicy::Expanding
-
-
-
- 20
- 20
-
-
-
-
-
-
-
- Match whole words only
-
-
-
-
-
-
- Search backwards
-
-
-
-
-
-
- Qt::Vertical
-
-
- QSizePolicy::Expanding
-
-
-
- 20
- 20
-
-
-
-
-
-
-
- Qt::Vertical
-
-
- QSizePolicy::Expanding
-
-
-
- 20
- 20
-
-
-
+
+
+
+
+
+
+
+ Qt::Vertical
+
+
+
+ 0
+ 10
+
+
+
+
+
+
+
+ Case sensitive[[search]]
+
+
+
+
+
+
+ Match whole words only
+
+
+
+
+
+
+ Search backwards
+
+
+
+
+
+
+ Qt::Vertical
+
+
+ QSizePolicy::Expanding
+
+
+
+ 0
+ 0
+
+
+
+
+
+
+
+
+
+
+
+ false
+
+
+ Replace All
+
+
+
+
+
+
+ Qt::Vertical
+
+
+ QSizePolicy::Expanding
+
+
+
+ 0
+ 0
+
+
+
+
+
+
+
Re: Patch test with several minor dialog alignment fixes
Attached is a patch for the Find & Replace (Quick) dialog for master. If
the patch is works, I could proceed with the other dialog fixes.
Daniel
From edca7251626378a5bff5aab0806a0a1689debd0a Mon Sep 17 00:00:00 2001
From: Daniel Ramoeller
Date: Mon, 29 Oct 2018 14:08:34 +0100
Subject: [PATCH] Fix for Find & Replace (Quick) dialog: - fixed maximum height
to minimum height - uncouple buttons from checkboxes
---
src/frontends/qt4/GuiSearch.cpp | 3 +
src/frontends/qt4/ui/SearchUi.ui | 331 +++
2 files changed, 165 insertions(+), 169 deletions(-)
diff --git a/src/frontends/qt4/GuiSearch.cpp b/src/frontends/qt4/GuiSearch.cpp
index dd1a002fed..02678fae60 100644
--- a/src/frontends/qt4/GuiSearch.cpp
+++ b/src/frontends/qt4/GuiSearch.cpp
@@ -47,6 +47,9 @@ GuiSearch::GuiSearch(GuiView & lv)
{
setupUi(this);
+ // fix height to minimum
+ setFixedHeight(sizeHint().height());
+
connect(buttonBox, SIGNAL(clicked(QAbstractButton *)),
this, SLOT(slotButtonBox(QAbstractButton *)));
connect(findPB, SIGNAL(clicked()), this, SLOT(findClicked()));
diff --git a/src/frontends/qt4/ui/SearchUi.ui b/src/frontends/qt4/ui/SearchUi.ui
index ebc00e3cfc..f0e4bcc78a 100644
--- a/src/frontends/qt4/ui/SearchUi.ui
+++ b/src/frontends/qt4/ui/SearchUi.ui
@@ -16,48 +16,10 @@
true
-
-
-
-
- Find:
-
-
- findCO
-
-
-
-
-
-
-
- 0
- 0
-
-
-
- Qt::StrongFocus
-
-
- true
-
-
- 666
-
-
- QComboBox::InsertAtTop
-
-
- false
-
-
- false
-
-
-
-
-
-
+
+
+
+
false
@@ -70,151 +32,182 @@
-
-
-
-false
+
+
+
+Find:
+
+
+findCO
+
+
+
+
-Replace
+Replace with:
+
+
+replaceCO
-
-
-
+
+
+
+
+ 0
+ 0
+
+
+
+Qt::StrongFocus
+
+
+true
+
+
+666
+
+
+QComboBox::InsertAtTop
+
+
false
-
-Replace All
+
+false
-
-
-
-QDialogButtonBox::Close
+
+
+
+
+ 0
+ 0
+
+
+
+true
+
+
+666
+
+
+QComboBox::InsertAtTop
+
+
+false
+
+
+false
+
+
+
+
+
+
+false
+
+
+Replace
-
-
-
- Replace with:
-
-
- replaceCO
-
-
-
-
-
-
-
- 0
- 0
-
-
-
- true
-
-
- 666
-
-
- QComboBox::InsertAtTop
-
-
- false
-
-
- false
-
-
-
-
-
-
- Case sensitive[[search]]
-
-
-
-
-
-
- Qt::Horizontal
-
-
- QSizePolicy::Expanding
-
-
-
- 20
- 20
-
-
-
-
-
-
-
- Match whole words only
-
-
-
-
-
-
- Search backwards
-
-
-
-
-
-
- Qt::Vertical
-
-
- QSizePolicy::Expanding
-
-
-
- 20
- 20
-
-
-
-
-
-
-
- Qt::Vertical
-
-
- QSizePolicy::Expanding
-
-
-
- 20
- 20
-
-
-
+
+
+
+
+
+
+
+ Qt::Vertical
+
+
+
+ 0
+ 10
+
+
+
+
+
+
+
+ Case sensitive[[search]]
+
+
+
+
+
+
+ Search backwards
+
+
+
+
+
+
+ Match whole words only
+
+
+
+
+
+
+ Qt::Vertical
+
+
+ QSizePolicy::Expanding
+
+
+
+ 0
+ 0
+
+
+
+
+
+
+
+
+
+
+
+ false
+
+
+ Replace All
+
+
+
+
+
+
+ Qt::Vertical
+
+
+ QSizePolicy::Expanding
+
+
+
+
+
+
+ QDialogButtonBox::Close
+
+
+
+
+
+
-
- findCO
- replaceCO
- caseCB
- wordsCB
-
Re: Patch test with several minor dialog alignment fixes
On 10/27/18 1:43 PM, Daniel wrote: > On 27/10/2018 19:33, Richard Kimberly Heck wrote: >> On 10/24/18 7:36 AM, Daniel wrote: >>> On 24/10/2018 12:20, Daniel wrote: On 24/10/2018 11:40, Daniel wrote: > On 23/10/2018 18:37, Daniel wrote: >> On 23/10/2018 11:21, Daniel wrote: >> [...] >>> One thing I couldn't try out is the Advanced Search & Replace >>> dialog when docked to the top or bottom. I remember that this is >>> possible, for example, on MacOS but it seems not to be on Windows. >>> So, it would be great if someone could test what it looks like >>> when docked to the top.[...] >> >> This was apparently due to a bug in Qt 5.11.2. Docking works fine >> in Windows with Qt 5.9.7. Top/bottom docked looks a bit ugly (as it >> used to). I'll try to fix it. > > New patch attached. Also a screen capture as an example of how I > changed things. > > Two things I noticed: > > - The Quick Find & Replace dialog had a variable height but there > were no elements in it that would need a variable height so I fixed > it. But maybe there is a specific reason for not having dialogs with > fixed sizes in general? > > - There is something strange going on with the size of the Advanced > Find and Replace Widget. > > When docked to the top (or docked to the top and then undocked) its > minimum height is the minimum height it has when docked to the side. > But since the box layout is switched from horizontal to vertical > this makes no sense. > > And also when the widget is first called it is on the side and can > be made rather narrow. But once it has been docked to the top and > back to the side it cannot be as narrow any more since it is > restricted to the minimum width as if it were docked to the top (or > docked to the top and undocked). > > Is this a known problem? Sorry, I saw another dialog (Compare) for improvement on my way out. Patched in the attachment. Screen captures attached as well. >>> >>> Didn't know that the last open tab in the Creator becomes the >>> default... fixed version attached. >> >> >> I had a look through this. Unfortunately, these *.ui patches are >> basically impossible to read. There are too many changes shown, and I >> anyway can't tell what the effect is likely to be. So the only thing we >> can do is commit and test. I think it's too late for 2.3.2, but we can >> commit as soon as 2.3.x is open. >> >> Unfortunately, the patch does not apply to master. That's not terribly >> surprising, because of how the *.ui changes work. (You really only >> change a few things, but the file actually changes quite a lot.) So >> we'll need to redo it, in effect, for there. That could be committed >> right now, though. >> >> Riki > > Thanks for taking a look. Yes, there were quite some changes that > seemed reasonable to me. I hope they are rather safe but I have only > tested them on Win10. > > I guess the problem of porting goes both ways, right? So, a patch for > master would also be hard to apply to 2.3.x? When there are changes to *.ui files, yes, I expect so. Usually changes to *.cpp files and the like port easily, or can be easily fixed. > I could just redo all the changes for a new patch. There were quite a > few but I think I'd be quickly done. OK. > By the way, is there a point in creating separate patches, i.e. one > for each dialog? It wouldn't hurt. It would at least make it easier to find problems, if any arise. Riki
Re: Patch test with several minor dialog alignment fixes
On 27/10/2018 19:33, Richard Kimberly Heck wrote: On 10/24/18 7:36 AM, Daniel wrote: On 24/10/2018 12:20, Daniel wrote: On 24/10/2018 11:40, Daniel wrote: On 23/10/2018 18:37, Daniel wrote: On 23/10/2018 11:21, Daniel wrote: [...] One thing I couldn't try out is the Advanced Search & Replace dialog when docked to the top or bottom. I remember that this is possible, for example, on MacOS but it seems not to be on Windows. So, it would be great if someone could test what it looks like when docked to the top.[...] This was apparently due to a bug in Qt 5.11.2. Docking works fine in Windows with Qt 5.9.7. Top/bottom docked looks a bit ugly (as it used to). I'll try to fix it. New patch attached. Also a screen capture as an example of how I changed things. Two things I noticed: - The Quick Find & Replace dialog had a variable height but there were no elements in it that would need a variable height so I fixed it. But maybe there is a specific reason for not having dialogs with fixed sizes in general? - There is something strange going on with the size of the Advanced Find and Replace Widget. When docked to the top (or docked to the top and then undocked) its minimum height is the minimum height it has when docked to the side. But since the box layout is switched from horizontal to vertical this makes no sense. And also when the widget is first called it is on the side and can be made rather narrow. But once it has been docked to the top and back to the side it cannot be as narrow any more since it is restricted to the minimum width as if it were docked to the top (or docked to the top and undocked). Is this a known problem? Sorry, I saw another dialog (Compare) for improvement on my way out. Patched in the attachment. Screen captures attached as well. Didn't know that the last open tab in the Creator becomes the default... fixed version attached. I had a look through this. Unfortunately, these *.ui patches are basically impossible to read. There are too many changes shown, and I anyway can't tell what the effect is likely to be. So the only thing we can do is commit and test. I think it's too late for 2.3.2, but we can commit as soon as 2.3.x is open. Unfortunately, the patch does not apply to master. That's not terribly surprising, because of how the *.ui changes work. (You really only change a few things, but the file actually changes quite a lot.) So we'll need to redo it, in effect, for there. That could be committed right now, though. Riki Thanks for taking a look. Yes, there were quite some changes that seemed reasonable to me. I hope they are rather safe but I have only tested them on Win10. I guess the problem of porting goes both ways, right? So, a patch for master would also be hard to apply to 2.3.x? I could just redo all the changes for a new patch. There were quite a few but I think I'd be quickly done. By the way, is there a point in creating separate patches, i.e. one for each dialog? Daniel
Re: Patch test with several minor dialog alignment fixes
On 10/24/18 7:36 AM, Daniel wrote: > On 24/10/2018 12:20, Daniel wrote: >> On 24/10/2018 11:40, Daniel wrote: >>> On 23/10/2018 18:37, Daniel wrote: On 23/10/2018 11:21, Daniel wrote: [...] > One thing I couldn't try out is the Advanced Search & Replace > dialog when docked to the top or bottom. I remember that this is > possible, for example, on MacOS but it seems not to be on Windows. > So, it would be great if someone could test what it looks like > when docked to the top.[...] This was apparently due to a bug in Qt 5.11.2. Docking works fine in Windows with Qt 5.9.7. Top/bottom docked looks a bit ugly (as it used to). I'll try to fix it. >>> >>> New patch attached. Also a screen capture as an example of how I >>> changed things. >>> >>> Two things I noticed: >>> >>> - The Quick Find & Replace dialog had a variable height but there >>> were no elements in it that would need a variable height so I fixed >>> it. But maybe there is a specific reason for not having dialogs with >>> fixed sizes in general? >>> >>> - There is something strange going on with the size of the Advanced >>> Find and Replace Widget. >>> >>> When docked to the top (or docked to the top and then undocked) its >>> minimum height is the minimum height it has when docked to the side. >>> But since the box layout is switched from horizontal to vertical >>> this makes no sense. >>> >>> And also when the widget is first called it is on the side and can >>> be made rather narrow. But once it has been docked to the top and >>> back to the side it cannot be as narrow any more since it is >>> restricted to the minimum width as if it were docked to the top (or >>> docked to the top and undocked). >>> >>> Is this a known problem? >> >> Sorry, I saw another dialog (Compare) for improvement on my way out. >> Patched in the attachment. Screen captures attached as well. > > Didn't know that the last open tab in the Creator becomes the > default... fixed version attached. I had a look through this. Unfortunately, these *.ui patches are basically impossible to read. There are too many changes shown, and I anyway can't tell what the effect is likely to be. So the only thing we can do is commit and test. I think it's too late for 2.3.2, but we can commit as soon as 2.3.x is open. Unfortunately, the patch does not apply to master. That's not terribly surprising, because of how the *.ui changes work. (You really only change a few things, but the file actually changes quite a lot.) So we'll need to redo it, in effect, for there. That could be committed right now, though. Riki
Re: Patch test with several minor dialog alignment fixes
On 24/10/2018 13:36, Daniel wrote: On 24/10/2018 12:20, Daniel wrote: On 24/10/2018 11:40, Daniel wrote: On 23/10/2018 18:37, Daniel wrote: - There is something strange going on with the size of the Advanced Find and Replace Widget. When docked to the top (or docked to the top and then undocked) its minimum height is the minimum height it has when docked to the side. But since the box layout is switched from horizontal to vertical this makes no sense. And also when the widget is first called it is on the side and can be made rather narrow. But once it has been docked to the top and back to the side it cannot be as narrow any more since it is restricted to the minimum width as if it were docked to the top (or docked to the top and undocked). I noticed that the Code Preview Pane does not share this strange behaviour with the other panes. And I noticed that its implemented differs a bit. For example, GuiViewSource.cpp has a ViewSourceWidget::ViewSourceWidget(QWidget * parent) : QWidget(parent), document_(new QTextDocument(this)), highlighter_(new LaTeXHighlighter(document_)) while the other panes seem not to have this. Could something like that explain the difference? I am just poking around in the dark... Daniel
Re: Patch test with several minor dialog alignment fixes
On 25/10/2018 20:40, Richard Kimberly Heck wrote: On 10/25/18 5:47 AM, Daniel wrote: The patch was created with 2.3.x checked out. Maybe that is not how one has to do it? I was unable to work on master due to incompatibility with visual studio. These problems are fixed now but I don't know how to "forport". Any suggestion appreciated. Or is it enough that the patch can be applied to 2.3.x? We can port the patch to master, don't worry. I think people are just very busy right now. I know I am. Riki No hurry! It is just some minor UI stuff anyway. I was just wondering whether it will work in principle. Daniel
Re: Patch test with several minor dialog alignment fixes
On 10/25/18 5:47 AM, Daniel wrote: > The patch was created with 2.3.x checked out. Maybe that is not how > one has to do it? I was unable to work on master due to > incompatibility with visual studio. These problems are fixed now but I > don't know how to "forport". Any suggestion appreciated. Or is it > enough that the patch can be applied to 2.3.x? We can port the patch to master, don't worry. I think people are just very busy right now. I know I am. Riki
Re: Patch test with several minor dialog alignment fixes
The patch was created with 2.3.x checked out. Maybe that is not how one has to do it? I was unable to work on master due to incompatibility with visual studio. These problems are fixed now but I don't know how to "forport". Any suggestion appreciated. Or is it enough that the patch can be applied to 2.3.x? Best, Daniel
Re: Patch test with several minor dialog alignment fixes
On 24/10/2018 12:20, Daniel wrote:
On 24/10/2018 11:40, Daniel wrote:
On 23/10/2018 18:37, Daniel wrote:
On 23/10/2018 11:21, Daniel wrote:
[...]
One thing I couldn't try out is the Advanced Search & Replace dialog
when docked to the top or bottom. I remember that this is possible,
for example, on MacOS but it seems not to be on Windows. So, it
would be great if someone could test what it looks like when docked
to the top.[...]
This was apparently due to a bug in Qt 5.11.2. Docking works fine in
Windows with Qt 5.9.7. Top/bottom docked looks a bit ugly (as it used
to). I'll try to fix it.
New patch attached. Also a screen capture as an example of how I
changed things.
Two things I noticed:
- The Quick Find & Replace dialog had a variable height but there were
no elements in it that would need a variable height so I fixed it. But
maybe there is a specific reason for not having dialogs with fixed
sizes in general?
- There is something strange going on with the size of the Advanced
Find and Replace Widget.
When docked to the top (or docked to the top and then undocked) its
minimum height is the minimum height it has when docked to the side.
But since the box layout is switched from horizontal to vertical this
makes no sense.
And also when the widget is first called it is on the side and can be
made rather narrow. But once it has been docked to the top and back to
the side it cannot be as narrow any more since it is restricted to the
minimum width as if it were docked to the top (or docked to the top
and undocked).
Is this a known problem?
Sorry, I saw another dialog (Compare) for improvement on my way out.
Patched in the attachment. Screen captures attached as well.
Didn't know that the last open tab in the Creator becomes the default...
fixed version attached.
Daniel
From ef0e75cacfc95a25617ac44ecbf31fe800e47e36 Mon Sep 17 00:00:00 2001
From: Daniel Ramoeller
Date: Tue, 23 Oct 2018 10:48:50 +0200
Subject: [PATCH] Several minor dialog alignment fixes: - Thesaurus: Close
button to right - Label: to top - Search: decouple lower buttons and
checkboxes, align Close button to bottom, fixed height - ProgressView: fixed
Debug messages group width - FindAndReplace: decouple lower buttons and
checkboxes, don't expand button widths - Compare: move status bar next to OK
button, fixed size of Copy Document Settings from Group, fixed height
---
src/frontends/qt4/GuiCompare.cpp | 3 +
src/frontends/qt4/GuiSearch.cpp | 3 +
src/frontends/qt4/ui/CompareUi.ui| 413 +++---
src/frontends/qt4/ui/FindAndReplaceUi.ui | 236 +++--
src/frontends/qt4/ui/LabelUi.ui | 38 +-
src/frontends/qt4/ui/ProgressViewUi.ui | 211 +++-
src/frontends/qt4/ui/SearchUi.ui | 419 ---
src/frontends/qt4/ui/ThesaurusUi.ui | 27 +-
8 files changed, 749 insertions(+), 601 deletions(-)
diff --git a/src/frontends/qt4/GuiCompare.cpp b/src/frontends/qt4/GuiCompare.cpp
index 4ea7f35784..9ca1f010b0 100644
--- a/src/frontends/qt4/GuiCompare.cpp
+++ b/src/frontends/qt4/GuiCompare.cpp
@@ -46,6 +46,9 @@ GuiCompare::GuiCompare(GuiView & lv)
setupUi(this);
setModal(Qt::WindowModal);
+ // fix height to minimum
+ setFixedHeight(sizeHint().height());
+
connect(okPB, SIGNAL(clicked()), this, SLOT(slotOK()));
connect(closePB, SIGNAL(clicked()), this, SLOT(slotCancel()));
diff --git a/src/frontends/qt4/GuiSearch.cpp b/src/frontends/qt4/GuiSearch.cpp
index 411ba2ef10..a506e4edeb 100644
--- a/src/frontends/qt4/GuiSearch.cpp
+++ b/src/frontends/qt4/GuiSearch.cpp
@@ -47,6 +47,9 @@ GuiSearch::GuiSearch(GuiView & lv)
{
setupUi(this);
+ // fix height to minimum
+ setFixedHeight(sizeHint().height());
+
connect(closePB, SIGNAL(clicked()), this, SLOT(slotClose()));
connect(findPB, SIGNAL(clicked()), this, SLOT(findClicked()));
connect(replacePB, SIGNAL(clicked()), this, SLOT(replaceClicked()));
diff --git a/src/frontends/qt4/ui/CompareUi.ui
b/src/frontends/qt4/ui/CompareUi.ui
index 31573c3dde..32acaaef5e 100644
--- a/src/frontends/qt4/ui/CompareUi.ui
+++ b/src/frontends/qt4/ui/CompareUi.ui
@@ -1,200 +1,221 @@
-
- CompareUi
-
-
-
-0
-0
-450
-294
-
-
-
-
-
-
-
-0
-
-
-
-
-10
-
-
-
-
-New Document:
-
-
-newFileCB
-
-
+
+
+ CompareUi
+
+
+
+0
+0
+450
+294
+
+
+
+
+
+
+ true
+
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+
+
+ 10
+
+
+ 10
+
+
+ 10
+
+
+ 10
+
+
+
+
+New Document:
+
+
+newFileCB
+
Re: Patch test with several minor dialog alignment fixes
On 24/10/2018 11:40, Daniel wrote:
On 23/10/2018 18:37, Daniel wrote:
On 23/10/2018 11:21, Daniel wrote:
[...]
One thing I couldn't try out is the Advanced Search & Replace dialog
when docked to the top or bottom. I remember that this is possible,
for example, on MacOS but it seems not to be on Windows. So, it would
be great if someone could test what it looks like when docked to the
top.[...]
This was apparently due to a bug in Qt 5.11.2. Docking works fine in
Windows with Qt 5.9.7. Top/bottom docked looks a bit ugly (as it used
to). I'll try to fix it.
New patch attached. Also a screen capture as an example of how I changed
things.
Two things I noticed:
- The Quick Find & Replace dialog had a variable height but there were
no elements in it that would need a variable height so I fixed it. But
maybe there is a specific reason for not having dialogs with fixed sizes
in general?
- There is something strange going on with the size of the Advanced Find
and Replace Widget.
When docked to the top (or docked to the top and then undocked) its
minimum height is the minimum height it has when docked to the side. But
since the box layout is switched from horizontal to vertical this makes
no sense.
And also when the widget is first called it is on the side and can be
made rather narrow. But once it has been docked to the top and back to
the side it cannot be as narrow any more since it is restricted to the
minimum width as if it were docked to the top (or docked to the top and
undocked).
Is this a known problem?
Sorry, I saw another dialog (Compare) for improvement on my way out.
Patched in the attachment. Screen captures attached as well.
Daniel
From 706c1baff4171ee2ac0ccc703e1954ddbe226803 Mon Sep 17 00:00:00 2001
From: Daniel Ramoeller
Date: Tue, 23 Oct 2018 10:48:50 +0200
Subject: [PATCH] Several minor dialog alignment fixes: - Thesaurus: Close
button to right - Label: to top - Search: decouple lower buttons and
checkboxes, align Close button to bottom, fixed height - ProgressView: fixed
Debug messages group width - FindAndReplace: decouple lower buttons and
checkboxes, don't expand button widths - Compare: move status bar next to OK
button, fixed size of Copy Document Settings from Group, fixed height
---
src/frontends/qt4/GuiCompare.cpp | 3 +
src/frontends/qt4/GuiSearch.cpp | 3 +
src/frontends/qt4/ui/CompareUi.ui| 413 +++---
src/frontends/qt4/ui/FindAndReplaceUi.ui | 236 +++--
src/frontends/qt4/ui/LabelUi.ui | 38 +-
src/frontends/qt4/ui/ProgressViewUi.ui | 213 +++-
src/frontends/qt4/ui/SearchUi.ui | 419 ---
src/frontends/qt4/ui/ThesaurusUi.ui | 27 +-
8 files changed, 750 insertions(+), 602 deletions(-)
diff --git a/src/frontends/qt4/GuiCompare.cpp b/src/frontends/qt4/GuiCompare.cpp
index 4ea7f35784..9ca1f010b0 100644
--- a/src/frontends/qt4/GuiCompare.cpp
+++ b/src/frontends/qt4/GuiCompare.cpp
@@ -46,6 +46,9 @@ GuiCompare::GuiCompare(GuiView & lv)
setupUi(this);
setModal(Qt::WindowModal);
+ // fix height to minimum
+ setFixedHeight(sizeHint().height());
+
connect(okPB, SIGNAL(clicked()), this, SLOT(slotOK()));
connect(closePB, SIGNAL(clicked()), this, SLOT(slotCancel()));
diff --git a/src/frontends/qt4/GuiSearch.cpp b/src/frontends/qt4/GuiSearch.cpp
index 411ba2ef10..a506e4edeb 100644
--- a/src/frontends/qt4/GuiSearch.cpp
+++ b/src/frontends/qt4/GuiSearch.cpp
@@ -47,6 +47,9 @@ GuiSearch::GuiSearch(GuiView & lv)
{
setupUi(this);
+ // fix height to minimum
+ setFixedHeight(sizeHint().height());
+
connect(closePB, SIGNAL(clicked()), this, SLOT(slotClose()));
connect(findPB, SIGNAL(clicked()), this, SLOT(findClicked()));
connect(replacePB, SIGNAL(clicked()), this, SLOT(replaceClicked()));
diff --git a/src/frontends/qt4/ui/CompareUi.ui
b/src/frontends/qt4/ui/CompareUi.ui
index 31573c3dde..32acaaef5e 100644
--- a/src/frontends/qt4/ui/CompareUi.ui
+++ b/src/frontends/qt4/ui/CompareUi.ui
@@ -1,200 +1,221 @@
-
- CompareUi
-
-
-
-0
-0
-450
-294
-
-
-
-
-
-
-
-0
-
-
-
-
-10
-
-
-
-
-New Document:
-
-
-newFileCB
-
-
+
+
+ CompareUi
+
+
+
+0
+0
+450
+294
+
+
+
+
+
+
+ true
+
+
+
+0
+
+
+0
+
+
+0
+
+
+0
+
+
+
+
+ 10
+
+
+ 10
+
+
+ 10
+
+
+ 10
+
+
+
+
+New Document:
+
+
+newFileCB
+
+
+
+
+
+
+Browse...
+
+
+false
+
+
+
+
+
+
Re: Patch test with several minor dialog alignment fixes
On 23/10/2018 18:37, Daniel wrote:
On 23/10/2018 11:21, Daniel wrote:
[...]
One thing I couldn't try out is the Advanced Search & Replace dialog
when docked to the top or bottom. I remember that this is possible,
for example, on MacOS but it seems not to be on Windows. So, it would
be great if someone could test what it looks like when docked to the
top.[...]
This was apparently due to a bug in Qt 5.11.2. Docking works fine in
Windows with Qt 5.9.7. Top/bottom docked looks a bit ugly (as it used
to). I'll try to fix it.
New patch attached. Also a screen capture as an example of how I changed
things.
Two things I noticed:
- The Quick Find & Replace dialog had a variable height but there were
no elements in it that would need a variable height so I fixed it. But
maybe there is a specific reason for not having dialogs with fixed sizes
in general?
- There is something strange going on with the size of the Advanced Find
and Replace Widget.
When docked to the top (or docked to the top and then undocked) its
minimum height is the minimum height it has when docked to the side. But
since the box layout is switched from horizontal to vertical this makes
no sense.
And also when the widget is first called it is on the side and can be
made rather narrow. But once it has been docked to the top and back to
the side it cannot be as narrow any more since it is restricted to the
minimum width as if it were docked to the top (or docked to the top and
undocked).
Is this a known problem?
Daniel
From ffc054ac40b605405f6cac1d9ff2b3a49b99a3ce Mon Sep 17 00:00:00 2001
From: Daniel Ramoeller
Date: Tue, 23 Oct 2018 10:48:50 +0200
Subject: [PATCH] Several minor dialog alignment fixes: - Thesaurus: Close
button to right - Label: to top - Search: decouple lower buttons and
checkboxes, align Close button to bottom - ProgressView: fixed Debug messages
group width - FindAndReplace: decouple lower buttons and checkboxes, don't
expand button widths
---
src/frontends/qt4/GuiSearch.cpp | 3 +
src/frontends/qt4/ui/FindAndReplaceUi.ui | 236 +++--
src/frontends/qt4/ui/LabelUi.ui | 38 +-
src/frontends/qt4/ui/ProgressViewUi.ui | 213 +++-
src/frontends/qt4/ui/SearchUi.ui | 419 ---
src/frontends/qt4/ui/ThesaurusUi.ui | 27 +-
6 files changed, 530 insertions(+), 406 deletions(-)
diff --git a/src/frontends/qt4/GuiSearch.cpp b/src/frontends/qt4/GuiSearch.cpp
index 411ba2ef10..a506e4edeb 100644
--- a/src/frontends/qt4/GuiSearch.cpp
+++ b/src/frontends/qt4/GuiSearch.cpp
@@ -47,6 +47,9 @@ GuiSearch::GuiSearch(GuiView & lv)
{
setupUi(this);
+ // fix height to minimum
+ setFixedHeight(sizeHint().height());
+
connect(closePB, SIGNAL(clicked()), this, SLOT(slotClose()));
connect(findPB, SIGNAL(clicked()), this, SLOT(findClicked()));
connect(replacePB, SIGNAL(clicked()), this, SLOT(replaceClicked()));
diff --git a/src/frontends/qt4/ui/FindAndReplaceUi.ui
b/src/frontends/qt4/ui/FindAndReplaceUi.ui
index 9510685470..66aa1977bc 100644
--- a/src/frontends/qt4/ui/FindAndReplaceUi.ui
+++ b/src/frontends/qt4/ui/FindAndReplaceUi.ui
@@ -20,7 +20,7 @@
Search
-
+
@@ -70,99 +70,109 @@
-
-
-
-
- Perform a case-sensitive search
-
-
- Case sensitive
-
-
-
-
-
-
- true
-
-
-
- 100
- 32
-
-
-
- Find next occurrence [Enter]
-
-
- Find Next
-
-
- true
-
-
+
+
+
+
+
+
+ true
+
+
+ Find next occurrence [Enter]
+
+
+ Find Next
+
+
+ true
+
+
+
+
+
+
+ true
+
+
+ Replace and find next occurrence [Enter]
+
+
+ Replace
+
+
+
+
+
+
+ true
+
+
+ Replace all occurrences at once
+
+
+ Replace All
+
+
+
+
-
-
- true
-
-
- Restrict search to whole words only
-
-
- Whole words
-
-
-
-
-
-
- true
-
-
-
- 100
- 32
-
-
-
- Replace and find next occurrence [Enter]
-
-
- Replace
-
-
+
+
+
+
+ Perform a case-sensitive search
+
+
+ Case sensitive
+
+
+
+
+
Re: Patch test with several minor dialog alignment fixes
On 23/10/2018 11:21, Daniel wrote: [...] One thing I couldn't try out is the Advanced Search & Replace dialog when docked to the top or bottom. I remember that this is possible, for example, on MacOS but it seems not to be on Windows. So, it would be great if someone could test what it looks like when docked to the top.[...] This was apparently due to a bug in Qt 5.11.2. Docking works fine in Windows with Qt 5.9.7. Top/bottom docked looks a bit ugly (as it used to). I'll try to fix it. Daniel
